)]}'
{"tools/validate-all-file.py":[{"author":{"_account_id":22165,"name":"caoyuan","email":"cao.yingjunz@gmail.com","username":"caoyuan"},"change_message_id":"fcdf1e72c6f2812b62f41b8520c30f671020e064","unresolved":false,"context_lines":[{"line_number":137,"context_line":"                    tasks \u003d yaml.safe_load(fp)"},{"line_number":138,"context_line":"                tasks \u003d tasks or []"},{"line_number":139,"context_line":"                for task in tasks:"},{"line_number":140,"context_line":"                    for module in docker_modules:"},{"line_number":141,"context_line":"                        if module in task and not task.get(\u0027become\u0027):"},{"line_number":142,"context_line":"                            return_code \u003d 1"},{"line_number":143,"context_line":"                            LOG.error(\"Use of %s module without become in \""},{"line_number":144,"context_line":"                                      \"task %s in %s\","},{"line_number":145,"context_line":"                                      module, task[\u0027name\u0027], fullpath)"},{"line_number":146,"context_line":"                    for module in cmd_modules:"},{"line_number":147,"context_line":"                        if (module in task and"},{"line_number":148,"context_line":"                                task[module].startswith(\u0027docker\u0027) and"}],"source_content_type":"text/x-python","patch_set":6,"id":"7faddb67_4d042a7c","line":145,"range":{"start_line":140,"start_character":0,"end_line":145,"end_character":69},"updated":"2019-07-04 03:23:08.000000000","message":"a task just have one module, when get the return_code,  we should break the loop, and return 1,  it\u0027s unnecessary to check the  rest of docker_modules.","commit_id":"920943b7ea66f6e0450b821a3fe21ba276c33d50"},{"author":{"_account_id":22165,"name":"caoyuan","email":"cao.yingjunz@gmail.com","username":"caoyuan"},"change_message_id":"fcdf1e72c6f2812b62f41b8520c30f671020e064","unresolved":false,"context_lines":[{"line_number":143,"context_line":"                            LOG.error(\"Use of %s module without become in \""},{"line_number":144,"context_line":"                                      \"task %s in %s\","},{"line_number":145,"context_line":"                                      module, task[\u0027name\u0027], fullpath)"},{"line_number":146,"context_line":"                    for module in cmd_modules:"},{"line_number":147,"context_line":"                        if (module in task and"},{"line_number":148,"context_line":"                                task[module].startswith(\u0027docker\u0027) and"},{"line_number":149,"context_line":"                                not task.get(\u0027become\u0027)):"},{"line_number":150,"context_line":"                            return_code \u003d 1"},{"line_number":151,"context_line":"                            LOG.error(\"Use of docker in %s module without \""},{"line_number":152,"context_line":"                                      \"become in task %s in %s\","},{"line_number":153,"context_line":"                                      module, task[\u0027name\u0027], fullpath)"},{"line_number":154,"context_line":""},{"line_number":155,"context_line":"    return return_code"},{"line_number":156,"context_line":""}],"source_content_type":"text/x-python","patch_set":6,"id":"7faddb67_edf8767d","line":153,"range":{"start_line":146,"start_character":18,"end_line":153,"end_character":69},"updated":"2019-07-04 03:23:08.000000000","message":"ditto","commit_id":"920943b7ea66f6e0450b821a3fe21ba276c33d50"}]}