)]}'
{"ansible/roles/influxdb/templates/influxdb.conf.j2":[{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"192823467989fe5c33e5dd6c45b126f2160969f5","unresolved":false,"context_lines":[{"line_number":11,"context_line":"  wal-dir \u003d \"/var/lib/influxdb/wal\""},{"line_number":12,"context_line":"  wal-logging-enabled \u003d true"},{"line_number":13,"context_line":"  data-logging-enabled \u003d true"},{"line_number":14,"context_line":"  index-version \u003d \"tsi1\""},{"line_number":15,"context_line":"[coordinator]"},{"line_number":16,"context_line":"  write-timeout \u003d \"10s\""},{"line_number":17,"context_line":"  max-concurrent-queries \u003d 0"}],"source_content_type":"text/x-jinja2","patch_set":1,"id":"9fb8cfa7_6fdc2a18","line":14,"updated":"2019-06-21 08:33:03.000000000","message":"Would it make sense to make this configurable, so that someone not wanting to migrate could keep the old setting? Or if it\u0027s invasive perhaps we even keep the old setting as the default and document it?","commit_id":"09d3621f105210cd87b8492deebc3ccd17595171"},{"author":{"_account_id":17669,"name":"Doug Szumski","email":"doug@stackhpc.com","username":"DougSzumski"},"change_message_id":"25cde23652a44b8a57c28fdc7adbfcef68ca464b","unresolved":false,"context_lines":[{"line_number":11,"context_line":"  wal-dir \u003d \"/var/lib/influxdb/wal\""},{"line_number":12,"context_line":"  wal-logging-enabled \u003d true"},{"line_number":13,"context_line":"  data-logging-enabled \u003d true"},{"line_number":14,"context_line":"  index-version \u003d \"tsi1\""},{"line_number":15,"context_line":"[coordinator]"},{"line_number":16,"context_line":"  write-timeout \u003d \"10s\""},{"line_number":17,"context_line":"  max-concurrent-queries \u003d 0"}],"source_content_type":"text/x-jinja2","patch_set":1,"id":"9fb8cfa7_2bff0502","line":14,"in_reply_to":"9fb8cfa7_6fdc2a18","updated":"2019-06-21 09:05:05.000000000","message":"I think it is worth making it configurable, particularly as the InfluxDB config file uses some bizarre nested sections which are not compatible with merge_configs.","commit_id":"09d3621f105210cd87b8492deebc3ccd17595171"}],"releasenotes/notes/enable-influxdb-tsi-858cc95e99605107.yaml":[{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"b68a580fff2ea91124bc83f43ffd3c0b5fe31293","unresolved":false,"context_lines":[{"line_number":3,"context_line":"  - InfluxDB TSI has been enabled by default. It is recommended for all"},{"line_number":4,"context_line":"    customers by InfluxData. Instructions to migrate existing data to the"},{"line_number":5,"context_line":"    new, disk based format are detailed in the following link:"},{"line_number":6,"context_line":"    https://docs.influxdata.com/influxdb/v1.7/administration/upgrading/"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"9fb8cfa7_0f780e29","line":6,"updated":"2019-06-21 08:30:00.000000000","message":"What happens if you don\u0027t do this? Is it risky to add this as a default in existing systems?","commit_id":"09d3621f105210cd87b8492deebc3ccd17595171"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"3d441c6527fa09eddf0d03508566b43a3490c5aa","unresolved":false,"context_lines":[{"line_number":3,"context_line":"  - InfluxDB TSI has been enabled by default. It is recommended for all"},{"line_number":4,"context_line":"    customers by InfluxData. Instructions to migrate existing data to the"},{"line_number":5,"context_line":"    new, disk based format are detailed in the following link:"},{"line_number":6,"context_line":"    https://docs.influxdata.com/influxdb/v1.7/administration/upgrading/"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"9fb8cfa7_6f050a7a","line":6,"in_reply_to":"9fb8cfa7_0f780e29","updated":"2019-06-21 08:35:52.000000000","message":"Would it be risky to automate the conversion?","commit_id":"09d3621f105210cd87b8492deebc3ccd17595171"},{"author":{"_account_id":17669,"name":"Doug Szumski","email":"doug@stackhpc.com","username":"DougSzumski"},"change_message_id":"25cde23652a44b8a57c28fdc7adbfcef68ca464b","unresolved":false,"context_lines":[{"line_number":3,"context_line":"  - InfluxDB TSI has been enabled by default. It is recommended for all"},{"line_number":4,"context_line":"    customers by InfluxData. Instructions to migrate existing data to the"},{"line_number":5,"context_line":"    new, disk based format are detailed in the following link:"},{"line_number":6,"context_line":"    https://docs.influxdata.com/influxdb/v1.7/administration/upgrading/"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"9fb8cfa7_ef233abd","line":6,"in_reply_to":"9fb8cfa7_6f050a7a","updated":"2019-06-21 09:05:05.000000000","message":"In my limited testing of not migrating the data after the TSI is enabled, it just carries on working before you migrate to the new format. According to the release notes for 1.7.0, the TSI migration can be triggered automatically:\n\n`To take advantage of these improvements:\nRebuild your indexes or wait for a TSI compaction of your indexes, at which point the new TSI format will be applied.\nHot shards and new shards immediately use the new TSI format.`\n\nhttps://github.com/influxdata/docs.influxdata.com/blob/master/content/influxdb/v1.7/about_the_project/releasenotes-changelog.md#time-series-index-tsi-query-performance-and-throughputs-improvements\n\n\nI will try enabling TSI and not-migrating to see if the above still happens.\n\nSince there are various upgrade paths depending on your previous version and configuration of InfluxDB, and that enabling the TSI shouldn\u0027t break anything, I think automation isn\u0027t worth the effort in this case.\n\nIt\u0027s also worth noting that the InfluxDB doc link in the upgrade note describes a simple process of reverting back to the old in memory index, so if this doesn\u0027t work for anyone, and they don\u0027t have a backup for whatever reason, there should still be an easy path out.","commit_id":"09d3621f105210cd87b8492deebc3ccd17595171"}]}