)]}'
{"ansible/roles/keystone/tasks/init_fernet.yml":[{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"d5b5033f6478a2fd7c0ae21c022176678e17eabf","unresolved":false,"context_lines":[{"line_number":22,"context_line":""},{"line_number":23,"context_line":"- name: Run key distribution"},{"line_number":24,"context_line":"  become: true"},{"line_number":25,"context_line":"  command: docker exec -t keystone_fernet /usr/bin/fernet-rotate.sh --no-rotate"},{"line_number":26,"context_line":"  run_once: True"},{"line_number":27,"context_line":"  delegate_to: \"{{ groups[\u0027keystone\u0027][0] }}\""}],"source_content_type":"text/x-yaml","patch_set":1,"id":"9fb8cfa7_d4e92180","line":25,"range":{"start_line":25,"start_character":58,"end_line":25,"end_character":79},"updated":"2019-06-21 18:40:29.000000000","message":"Not confusing at all!\ndo --dont-do\n\nAlso, this seems to be the only place that kolla-ansible calls this script. Would not it be better if it only did one thing it is really meant to (split responsibilites)?","commit_id":"029a732eb2d5d7fc402c714a176977b90a7d9739"},{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"d6dabc3fa7dd6df3471121634979112c33d8d728","unresolved":false,"context_lines":[{"line_number":22,"context_line":""},{"line_number":23,"context_line":"- name: Run key distribution"},{"line_number":24,"context_line":"  become: true"},{"line_number":25,"context_line":"  command: docker exec -t keystone_fernet /usr/bin/fernet-rotate.sh --no-rotate"},{"line_number":26,"context_line":"  run_once: True"},{"line_number":27,"context_line":"  delegate_to: \"{{ groups[\u0027keystone\u0027][0] }}\""}],"source_content_type":"text/x-yaml","patch_set":1,"id":"9fb8cfa7_e2430c3e","line":25,"range":{"start_line":25,"start_character":58,"end_line":25,"end_character":79},"in_reply_to":"9fb8cfa7_12ca5c19","updated":"2019-06-26 12:29:44.000000000","message":"Loose thought: Also, this task should manifest its idempotency somehow. It is not changing every time.","commit_id":"029a732eb2d5d7fc402c714a176977b90a7d9739"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"577d2b64c43fbca6cab387fe04e6b9257a4cdfef","unresolved":false,"context_lines":[{"line_number":22,"context_line":""},{"line_number":23,"context_line":"- name: Run key distribution"},{"line_number":24,"context_line":"  become: true"},{"line_number":25,"context_line":"  command: docker exec -t keystone_fernet /usr/bin/fernet-rotate.sh --no-rotate"},{"line_number":26,"context_line":"  run_once: True"},{"line_number":27,"context_line":"  delegate_to: \"{{ groups[\u0027keystone\u0027][0] }}\""}],"source_content_type":"text/x-yaml","patch_set":1,"id":"9fb8cfa7_12ca5c19","line":25,"range":{"start_line":25,"start_character":58,"end_line":25,"end_character":79},"in_reply_to":"9fb8cfa7_d4e92180","updated":"2019-06-24 08:42:43.000000000","message":"Yeah, this did cross my mind. This script is also called from ansible/roles/keystone/templates/crontab.j2, where we do want a rotate and a sync. I could split into two scripts I suppose.","commit_id":"029a732eb2d5d7fc402c714a176977b90a7d9739"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"e2be33de6d2d36798449bb0160618451e33401c0","unresolved":false,"context_lines":[{"line_number":22,"context_line":""},{"line_number":23,"context_line":"- name: Run key distribution"},{"line_number":24,"context_line":"  become: true"},{"line_number":25,"context_line":"  command: docker exec -t keystone_fernet /usr/bin/fernet-rotate.sh --no-rotate"},{"line_number":26,"context_line":"  run_once: True"},{"line_number":27,"context_line":"  delegate_to: \"{{ groups[\u0027keystone\u0027][0] }}\""}],"source_content_type":"text/x-yaml","patch_set":1,"id":"9fb8cfa7_bc8bf4bd","line":25,"range":{"start_line":25,"start_character":58,"end_line":25,"end_character":79},"in_reply_to":"9fb8cfa7_e2430c3e","updated":"2019-06-26 15:05:03.000000000","message":"Can\u0027t think of any obvious ways to fix that, can you?","commit_id":"029a732eb2d5d7fc402c714a176977b90a7d9739"},{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"22580060e0446b1de39ffba11d4aaab58508567c","unresolved":false,"context_lines":[{"line_number":22,"context_line":""},{"line_number":23,"context_line":"- name: Run key distribution"},{"line_number":24,"context_line":"  become: true"},{"line_number":25,"context_line":"  command: docker exec -t keystone_fernet /usr/bin/fernet-push.sh"},{"line_number":26,"context_line":"  run_once: True"},{"line_number":27,"context_line":"  delegate_to: \"{{ groups[\u0027keystone\u0027][0] }}\""}],"source_content_type":"text/x-yaml","patch_set":3,"id":"9fb8cfa7_d2033141","line":25,"updated":"2019-06-26 16:25:54.000000000","message":"Re: idempotency\nI think we might do rsync with --info\u003dNAME and then check here if it shows anything in stdout - if not, all files were up to date.","commit_id":"99a5eeb972432387a5fc4ff76ad814913067141e"}],"ansible/roles/keystone/templates/fernet-push.sh.j2":[{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"dae44d70daddf2736a32fdb35e027d89b306a159","unresolved":false,"context_lines":[{"line_number":5,"context_line":"/usr/bin/rsync -az --info\u003dNAME -e \u0027ssh -i /var/lib/keystone/.ssh/id_rsa -p {{ hostvars[host][\u0027keystone_ssh_port\u0027] }} -F /var/lib/keystone/.ssh/config\u0027 --delete /etc/keystone/fernet-keys/ keystone@{{ hostvars[host][\u0027ansible_\u0027 + hostvars[host][\u0027api_interface\u0027]][\u0027ipv4\u0027][\u0027address\u0027] }}:/etc/keystone/fernet-keys"},{"line_number":6,"context_line":"{% endif %}"},{"line_number":7,"context_line":"{% endfor %}"},{"line_number":8,"context_line":""}],"source_content_type":"text/x-jinja2","patch_set":4,"id":"9fb8cfa7_4b01cc69","line":8,"updated":"2019-06-26 18:42:38.000000000","message":"extra line","commit_id":"55cdea335eafe57f51d91be1eff12e0108a22b74"}]}