)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"e5fa6001c6b707b7bf9dff7310a5f53b22b70aef","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Handle more return codes from nova-status upgrade check"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Currently, the \"Upgrade status check result\" does nothing because the"},{"line_number":10,"context_line":"previous task can only succeed when `nova-status upgrade check` returns"},{"line_number":11,"context_line":"code 0. This change allows this command to err so that the value of"},{"line_number":12,"context_line":"returned code stored in `nova_upgrade_check_stdout` can then be"},{"line_number":13,"context_line":"analysed."},{"line_number":14,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"9fb8cfa7_c5cca4bc","line":11,"range":{"start_line":9,"start_character":0,"end_line":11,"end_character":6},"updated":"2019-06-28 14:35:04.000000000","message":"This is only true in a single controller scenario. With multiple controllers the others will continue.","commit_id":"e31c326b96aad848d3f0e7275b66f7a3ae334306"}],"ansible/roles/nova/tasks/upgrade.yml":[{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"e5fa6001c6b707b7bf9dff7310a5f53b22b70aef","unresolved":false,"context_lines":[{"line_number":4,"context_line":"  command: docker exec -t nova_api nova-status upgrade check"},{"line_number":5,"context_line":"  register: nova_upgrade_check_stdout"},{"line_number":6,"context_line":"  when: inventory_hostname \u003d\u003d groups[\u0027nova-api\u0027][0]"},{"line_number":7,"context_line":"  ignore_errors: True"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"- name: Upgrade status check result"},{"line_number":10,"context_line":"  fail:"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"9fb8cfa7_c541040c","line":7,"updated":"2019-06-28 14:35:04.000000000","message":"Use failed_when: false\n\nThat will not show the task as failed, which is less confusing.","commit_id":"e31c326b96aad848d3f0e7275b66f7a3ae334306"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"e5fa6001c6b707b7bf9dff7310a5f53b22b70aef","unresolved":false,"context_lines":[{"line_number":13,"context_line":"      - \"See the detail at https://docs.openstack.org/nova/latest/cli/nova-status.html#nova-status-checks\""},{"line_number":14,"context_line":"  vars:"},{"line_number":15,"context_line":"    first_nova_api_host: \"{{ groups[\u0027nova-api\u0027][0] }}\""},{"line_number":16,"context_line":"  when: hostvars[first_nova_api_host][\u0027nova_upgrade_check_stdout\u0027][\u0027rc\u0027] !\u003d 0 and hostvars[first_nova_api_host][\u0027nova_upgrade_check_stdout\u0027][\u0027rc\u0027] !\u003d 1"},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"- include_tasks: legacy_upgrade.yml"},{"line_number":19,"context_line":"  when: not nova_enable_rolling_upgrade | bool"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"9fb8cfa7_e538c8a0","line":16,"range":{"start_line":16,"start_character":8,"end_line":16,"end_character":77},"updated":"2019-06-28 14:35:04.000000000","message":"hostvars[first_nova_api_host][\u0027nova_upgrade_check_stdout\u0027][\u0027rc\u0027] not in [0, 1]","commit_id":"e31c326b96aad848d3f0e7275b66f7a3ae334306"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"14f922afb11bce1825c344ea0f4da8d7f0f66e04","unresolved":false,"context_lines":[{"line_number":9,"context_line":"- name: Upgrade status check result"},{"line_number":10,"context_line":"  fail:"},{"line_number":11,"context_line":"    msg:"},{"line_number":12,"context_line":"      - \"There was an upgrade status check warning or failure!\""},{"line_number":13,"context_line":"      - \"See the detail at https://docs.openstack.org/nova/latest/cli/nova-status.html#nova-status-checks\""},{"line_number":14,"context_line":"  vars:"},{"line_number":15,"context_line":"    first_nova_api_host: \"{{ groups[\u0027nova-api\u0027][0] }}\""}],"source_content_type":"text/x-yaml","patch_set":3,"id":"7faddb67_6d0217b7","line":12,"range":{"start_line":12,"start_character":43,"end_line":12,"end_character":53},"updated":"2019-07-08 13:10:21.000000000","message":"Now it\u0027s always a failure.","commit_id":"6f19597c96470bf07c042efba27dec84aee2f8fc"}]}