)]}'
{"ansible/action_plugins/merge_configs.py":[{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"bb3583b87b968100c29421434e2e7984b83b6ffb","unresolved":false,"context_lines":[{"line_number":141,"context_line":"                os.path.join(self._loader._basedir, \u0027templates\u0027),"},{"line_number":142,"context_line":"                os.path.dirname(source),"},{"line_number":143,"context_line":"            ]"},{"line_number":144,"context_line":"            self._templar.environment.loader.searchpath \u003d searchpath"},{"line_number":145,"context_line":""},{"line_number":146,"context_line":"            result \u003d self._templar.template(template_data)"},{"line_number":147,"context_line":"            fakefile \u003d StringIO(result)"}],"source_content_type":"text/x-python","patch_set":3,"id":"7faddb67_5551d361","line":144,"updated":"2019-07-09 09:33:23.000000000","message":"I was thinking you could just extend the existing list?","commit_id":"94e7c30fa0d58673287115140b97f739b6dfd68f"},{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"efb821838b2b2490e16da8588ddbb840fc70edb9","unresolved":false,"context_lines":[{"line_number":141,"context_line":"                os.path.join(self._loader._basedir, \u0027templates\u0027),"},{"line_number":142,"context_line":"                os.path.dirname(source),"},{"line_number":143,"context_line":"            ]"},{"line_number":144,"context_line":"            self._templar.environment.loader.searchpath \u003d searchpath"},{"line_number":145,"context_line":""},{"line_number":146,"context_line":"            result \u003d self._templar.template(template_data)"},{"line_number":147,"context_line":"            fakefile \u003d StringIO(result)"}],"source_content_type":"text/x-python","patch_set":3,"id":"7faddb67_b82efe40","line":144,"in_reply_to":"7faddb67_5551d361","updated":"2019-07-09 10:16:18.000000000","message":"I mimic what the template module does here. They overwrite the variable, not extend. No idea why but it does not seem to be wrong to do it this way (we know exactly what we can include :-) ).","commit_id":"94e7c30fa0d58673287115140b97f739b6dfd68f"}],"ansible/action_plugins/merge_yaml.py":[{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"8fd16a298e12405b1a58205d472812d429d2d40a","unresolved":false,"context_lines":[{"line_number":82,"context_line":""},{"line_number":83,"context_line":"            # set search path to source dir to allow relative includes"},{"line_number":84,"context_line":"            searchpath \u003d [os.path.dirname(source)]"},{"line_number":85,"context_line":"            self._templar.environment.loader.searchpath \u003d searchpath"},{"line_number":86,"context_line":""},{"line_number":87,"context_line":"            template_data \u003d self._templar.template(template_data)"},{"line_number":88,"context_line":"            result \u003d safe_load(template_data)"}],"source_content_type":"text/x-python","patch_set":2,"id":"7faddb67_b894cc8c","line":85,"updated":"2019-07-08 16:06:18.000000000","message":"What is the default for this? Are there other paths that we should include as well?","commit_id":"9aedddd4fedf87618bd7b4b459d9bd346b0804da"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"4741b959adb648f149f950bb30c14a7e4cc17c8c","unresolved":false,"context_lines":[{"line_number":82,"context_line":""},{"line_number":83,"context_line":"            # set search path to source dir to allow relative includes"},{"line_number":84,"context_line":"            searchpath \u003d [os.path.dirname(source)]"},{"line_number":85,"context_line":"            self._templar.environment.loader.searchpath \u003d searchpath"},{"line_number":86,"context_line":""},{"line_number":87,"context_line":"            template_data \u003d self._templar.template(template_data)"},{"line_number":88,"context_line":"            result \u003d safe_load(template_data)"}],"source_content_type":"text/x-python","patch_set":2,"id":"7faddb67_ce7d3e6f","line":85,"in_reply_to":"7faddb67_1363811c","updated":"2019-07-08 17:26:08.000000000","message":"Let\u0027s include the defaults and extend with the template source. Custom templates could rely on it feasibly.","commit_id":"9aedddd4fedf87618bd7b4b459d9bd346b0804da"},{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"8f0fcfa8864be677616e07d8551b644e2aaa36ee","unresolved":false,"context_lines":[{"line_number":82,"context_line":""},{"line_number":83,"context_line":"            # set search path to source dir to allow relative includes"},{"line_number":84,"context_line":"            searchpath \u003d [os.path.dirname(source)]"},{"line_number":85,"context_line":"            self._templar.environment.loader.searchpath \u003d searchpath"},{"line_number":86,"context_line":""},{"line_number":87,"context_line":"            template_data \u003d self._templar.template(template_data)"},{"line_number":88,"context_line":"            result \u003d safe_load(template_data)"}],"source_content_type":"text/x-python","patch_set":2,"id":"7faddb67_1363811c","line":85,"in_reply_to":"7faddb67_b894cc8c","updated":"2019-07-08 17:11:03.000000000","message":"Ansible DataLoader\u0027s basedir which is the directory of the playbook or the role (obviously not documented, had to check it).\nWe don\u0027t use any includes so it is pretty much irrelevant.\nWe can make it work like it does for the real template module - i.e. include the basedir and \u0027templates\u0027 subdir - we could then refactor all usages to simplify them.","commit_id":"9aedddd4fedf87618bd7b4b459d9bd346b0804da"}],"ansible/roles/nova/templates/nova.conf.j2":[{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"8fd16a298e12405b1a58205d472812d429d2d40a","unresolved":false,"context_lines":[{"line_number":187,"context_line":""},{"line_number":188,"context_line":"{% if service_name \u003d\u003d \u0027nova-compute\u0027 %}"},{"line_number":189,"context_line":"{% if nova_compute_virt_type in [\u0027kvm\u0027, \u0027qemu\u0027] %}"},{"line_number":190,"context_line":"{% include \u0027nova.conf.d/libvirt.conf.j2\u0027 %}"},{"line_number":191,"context_line":"{% endif %}"},{"line_number":192,"context_line":"{% endif %}"},{"line_number":193,"context_line":""}],"source_content_type":"text/x-jinja2","patch_set":2,"id":"7faddb67_f874849b","line":190,"updated":"2019-07-08 16:06:18.000000000","message":"Should probably add a comment here so someone doesn\u0027t \u0027optimise\u0027 this fix away.","commit_id":"9aedddd4fedf87618bd7b4b459d9bd346b0804da"},{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"8f0fcfa8864be677616e07d8551b644e2aaa36ee","unresolved":false,"context_lines":[{"line_number":187,"context_line":""},{"line_number":188,"context_line":"{% if service_name \u003d\u003d \u0027nova-compute\u0027 %}"},{"line_number":189,"context_line":"{% if nova_compute_virt_type in [\u0027kvm\u0027, \u0027qemu\u0027] %}"},{"line_number":190,"context_line":"{% include \u0027nova.conf.d/libvirt.conf.j2\u0027 %}"},{"line_number":191,"context_line":"{% endif %}"},{"line_number":192,"context_line":"{% endif %}"},{"line_number":193,"context_line":""}],"source_content_type":"text/x-jinja2","patch_set":2,"id":"7faddb67_f8456418","line":190,"in_reply_to":"7faddb67_f874849b","updated":"2019-07-08 17:11:03.000000000","message":"Good point. Will refer to the bug report.","commit_id":"9aedddd4fedf87618bd7b4b459d9bd346b0804da"}]}