)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"d90fa3b39e79f116626058363f49a7fc48651fc3","unresolved":false,"context_lines":[{"line_number":33,"context_line":""},{"line_number":34,"context_line":"[1] https://review.opendev.org/#/c/668765/"},{"line_number":35,"context_line":""},{"line_number":36,"context_line":"Co-Authored-By: Mark Goddard \u003cmark@stackhpc.com\u003e"},{"line_number":37,"context_line":""},{"line_number":38,"context_line":"Change-Id: I91e5c1840ace8f567daf462c4eb3ec1f0c503823"},{"line_number":39,"context_line":"Implements: blueprint ansible-pacemaker-support"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":17,"id":"bf51134e_bb1228b3","line":36,"updated":"2020-07-22 12:41:31.000000000","message":"which reminds me I need to add myself","commit_id":"952a1f7e5ecf21f743c1984b7d183c04c7fe8a00"},{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"0c7b1355b2591fb266c85001d3a3d2f819d1c3a0","unresolved":false,"context_lines":[{"line_number":22,"context_line":"the roles under masakari to avoid confusion with full-blown"},{"line_number":23,"context_line":"hacluster as it happens e.g. in charms."},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"Status testing."},{"line_number":26,"context_line":""},{"line_number":27,"context_line":"Fix containers check (likely caps order)."},{"line_number":28,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":38,"id":"9f560f44_89aeee95","line":25,"range":{"start_line":25,"start_character":0,"end_line":25,"end_character":15},"updated":"2020-07-30 16:34:24.000000000","message":"I just did that, but forgot to remove.","commit_id":"478659520b800955b970977b7c2e351de6573775"}],"ansible/roles/hacluster/defaults/main.yml":[{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"13f9b2ac6bcb495c9a740626392ed9e1cf3cb286","unresolved":false,"context_lines":[{"line_number":18,"context_line":"    image: \"{{ hacluster_pacemaker_image_full }}\""},{"line_number":19,"context_line":"    environment:"},{"line_number":20,"context_line":"      PCMK_logfile: /var/log/kolla/hacluster/pacemaker.log"},{"line_number":21,"context_line":"      PCMK_debug: \"{{ \u0027on\u0027 if openstack_logging_debug else \u0027off\u0027 }}\""},{"line_number":22,"context_line":"    volumes: \"{{ hacluster_pacemaker_default_volumes + hacluster_pacemaker_extra_volumes }}\""},{"line_number":23,"context_line":"    ipc_mode: \"host\""},{"line_number":24,"context_line":"    privileged: true"}],"source_content_type":"text/x-yaml","patch_set":16,"id":"bf51134e_c7d2a5d1","line":21,"range":{"start_line":21,"start_character":30,"end_line":21,"end_character":53},"updated":"2020-07-22 12:18:56.000000000","message":"| bool","commit_id":"2578aa5ca68a4ef4ff307282136b29222f560470"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"13f9b2ac6bcb495c9a740626392ed9e1cf3cb286","unresolved":false,"context_lines":[{"line_number":40,"context_line":""},{"line_number":41,"context_line":"####################"},{"line_number":42,"context_line":"# Docker"},{"line_number":43,"context_line":"####################"},{"line_number":44,"context_line":"hacluster_corosync_image: \"{{ docker_registry ~ \u0027/\u0027 if docker_registry else \u0027\u0027 }}{{ docker_namespace }}/{{ kolla_base_distro }}-{{ kolla_install_type }}-hacluster-corosync\""},{"line_number":45,"context_line":"hacluster_corosync_tag: \"{{ openstack_release }}\""},{"line_number":46,"context_line":"hacluster_corosync_image_full: \"{{ hacluster_corosync_image }}:{{ hacluster_corosync_tag }}\""}],"source_content_type":"text/x-yaml","patch_set":16,"id":"bf51134e_67e3d9a5","line":43,"updated":"2020-07-22 12:18:56.000000000","message":"typically we have a hacluster_tag variable.","commit_id":"2578aa5ca68a4ef4ff307282136b29222f560470"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"13f9b2ac6bcb495c9a740626392ed9e1cf3cb286","unresolved":false,"context_lines":[{"line_number":42,"context_line":"# Docker"},{"line_number":43,"context_line":"####################"},{"line_number":44,"context_line":"hacluster_corosync_image: \"{{ docker_registry ~ \u0027/\u0027 if docker_registry else \u0027\u0027 }}{{ docker_namespace }}/{{ kolla_base_distro }}-{{ kolla_install_type }}-hacluster-corosync\""},{"line_number":45,"context_line":"hacluster_corosync_tag: \"{{ openstack_release }}\""},{"line_number":46,"context_line":"hacluster_corosync_image_full: \"{{ hacluster_corosync_image }}:{{ hacluster_corosync_tag }}\""},{"line_number":47,"context_line":"hacluster_corosync_dimensions: \"{{ default_container_dimensions }}\""},{"line_number":48,"context_line":"hacluster_pacemaker_image: \"{{ docker_registry ~ \u0027/\u0027 if docker_registry else \u0027\u0027 }}{{ docker_namespace }}/{{ kolla_base_distro }}-{{ kolla_install_type }}-hacluster-pacemaker\""}],"source_content_type":"text/x-yaml","patch_set":16,"id":"bf51134e_27d9e1f3","line":45,"range":{"start_line":45,"start_character":28,"end_line":45,"end_character":45},"updated":"2020-07-22 12:18:56.000000000","message":"openstack_tag","commit_id":"2578aa5ca68a4ef4ff307282136b29222f560470"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"13f9b2ac6bcb495c9a740626392ed9e1cf3cb286","unresolved":false,"context_lines":[{"line_number":60,"context_line":"hacluster_pacemaker_remote_extra_volumes: \"{{ hacluster_extra_volumes }}\""},{"line_number":61,"context_line":"hacluster_corosync_default_volumes:"},{"line_number":62,"context_line":"  - \"{{ node_config_directory }}/hacluster-corosync/:{{ container_config_directory }}/:ro\""},{"line_number":63,"context_line":"  - \"/etc/localtime:/etc/localtime:ro\""},{"line_number":64,"context_line":"  - \"kolla_logs:/var/log/kolla/\""},{"line_number":65,"context_line":"  - \"hacluster_corosync:/var/lib/corosync\""},{"line_number":66,"context_line":"hacluster_pacemaker_default_volumes:"}],"source_content_type":"text/x-yaml","patch_set":16,"id":"bf51134e_478cd5d6","line":63,"updated":"2020-07-22 12:18:56.000000000","message":"/etc/timezone","commit_id":"2578aa5ca68a4ef4ff307282136b29222f560470"}],"ansible/roles/hacluster/handlers/main.yml":[{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"13f9b2ac6bcb495c9a740626392ed9e1cf3cb286","unresolved":false,"context_lines":[{"line_number":15,"context_line":"    dimensions: \"{{ service.dimensions }}\""},{"line_number":16,"context_line":"  when:"},{"line_number":17,"context_line":"    - kolla_action !\u003d \"config\""},{"line_number":18,"context_line":"    - service | service_enabled_and_mapped_to_host"},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"- name: Restart hacluster-pacemaker container"},{"line_number":21,"context_line":"  vars:"}],"source_content_type":"text/x-yaml","patch_set":16,"id":"bf51134e_277561cd","line":18,"range":{"start_line":18,"start_character":5,"end_line":18,"end_character":50},"updated":"2020-07-22 12:18:56.000000000","message":"I don\u0027t think it\u0027s required","commit_id":"2578aa5ca68a4ef4ff307282136b29222f560470"}],"ansible/roles/hacluster/tasks/bootstrap_service.yml":[{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"8113ea2402e76c1161fb2f721c18b3e1ff784ed3","unresolved":true,"context_lines":[{"line_number":14,"context_line":"    pacemaker_service: \"{{ hacluster_services[\u0027hacluster-pacemaker\u0027] }}\""},{"line_number":15,"context_line":"    pacemaker_remote_service: \"{{ hacluster_services[\u0027hacluster-pacemaker-remote\u0027] }}\""},{"line_number":16,"context_line":"  shell: \u003e"},{"line_number":17,"context_line":"    docker exec {{ pacemaker_service.container_name }}"},{"line_number":18,"context_line":"    cibadmin --modify --scope resources -X \u0027"},{"line_number":19,"context_line":"      \u003cresources\u003e"},{"line_number":20,"context_line":"        \u003cprimitive id\u003d\"{{ ansible_hostname }}\" class\u003d\"ocf\" provider\u003d\"pacemaker\" type\u003d\"remote\"\u003e"}],"source_content_type":"text/x-yaml","patch_set":47,"id":"9365e06f_b66f5aa4","line":17,"updated":"2020-12-16 07:59:00.000000000","message":"No option to use pacemaker_resource here using kolla_toolbox?","commit_id":"0e560b0f538db97b54a1a2868fe8e973574c233d"},{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"1816fbde1ebb7503e1f98b69358bb2242d0373f3","unresolved":false,"context_lines":[{"line_number":14,"context_line":"    pacemaker_service: \"{{ hacluster_services[\u0027hacluster-pacemaker\u0027] }}\""},{"line_number":15,"context_line":"    pacemaker_remote_service: \"{{ hacluster_services[\u0027hacluster-pacemaker-remote\u0027] }}\""},{"line_number":16,"context_line":"  shell: \u003e"},{"line_number":17,"context_line":"    docker exec {{ pacemaker_service.container_name }}"},{"line_number":18,"context_line":"    cibadmin --modify --scope resources -X \u0027"},{"line_number":19,"context_line":"      \u003cresources\u003e"},{"line_number":20,"context_line":"        \u003cprimitive id\u003d\"{{ ansible_hostname }}\" class\u003d\"ocf\" provider\u003d\"pacemaker\" type\u003d\"remote\"\u003e"}],"source_content_type":"text/x-yaml","patch_set":47,"id":"799798d9_31516dd5","line":17,"in_reply_to":"11d4289c_6fc18546","updated":"2021-03-14 19:59:37.000000000","message":"Done","commit_id":"0e560b0f538db97b54a1a2868fe8e973574c233d"},{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"351468ce01fbf1ad0175350d339a948c1be98317","unresolved":true,"context_lines":[{"line_number":14,"context_line":"    pacemaker_service: \"{{ hacluster_services[\u0027hacluster-pacemaker\u0027] }}\""},{"line_number":15,"context_line":"    pacemaker_remote_service: \"{{ hacluster_services[\u0027hacluster-pacemaker-remote\u0027] }}\""},{"line_number":16,"context_line":"  shell: \u003e"},{"line_number":17,"context_line":"    docker exec {{ pacemaker_service.container_name }}"},{"line_number":18,"context_line":"    cibadmin --modify --scope resources -X \u0027"},{"line_number":19,"context_line":"      \u003cresources\u003e"},{"line_number":20,"context_line":"        \u003cprimitive id\u003d\"{{ ansible_hostname }}\" class\u003d\"ocf\" provider\u003d\"pacemaker\" type\u003d\"remote\"\u003e"}],"source_content_type":"text/x-yaml","patch_set":47,"id":"b64f98f6_de700f2c","line":17,"in_reply_to":"9365e06f_b66f5aa4","updated":"2020-12-16 19:44:41.000000000","message":"Hmm, that makes sense. Thanks, Michał!","commit_id":"0e560b0f538db97b54a1a2868fe8e973574c233d"},{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"5ff59da374219c793800aba76a2edb0593b6db7d","unresolved":true,"context_lines":[{"line_number":14,"context_line":"    pacemaker_service: \"{{ hacluster_services[\u0027hacluster-pacemaker\u0027] }}\""},{"line_number":15,"context_line":"    pacemaker_remote_service: \"{{ hacluster_services[\u0027hacluster-pacemaker-remote\u0027] }}\""},{"line_number":16,"context_line":"  shell: \u003e"},{"line_number":17,"context_line":"    docker exec {{ pacemaker_service.container_name }}"},{"line_number":18,"context_line":"    cibadmin --modify --scope resources -X \u0027"},{"line_number":19,"context_line":"      \u003cresources\u003e"},{"line_number":20,"context_line":"        \u003cprimitive id\u003d\"{{ ansible_hostname }}\" class\u003d\"ocf\" provider\u003d\"pacemaker\" type\u003d\"remote\"\u003e"}],"source_content_type":"text/x-yaml","patch_set":47,"id":"11d4289c_6fc18546","line":17,"in_reply_to":"b64f98f6_de700f2c","updated":"2020-12-17 16:52:36.000000000","message":"I have checked it today and it does not fit the bill.","commit_id":"0e560b0f538db97b54a1a2868fe8e973574c233d"},{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"1816fbde1ebb7503e1f98b69358bb2242d0373f3","unresolved":true,"context_lines":[{"line_number":19,"context_line":"      \u003cresources\u003e"},{"line_number":20,"context_line":"        \u003cprimitive id\u003d\"{{ ansible_hostname }}\" class\u003d\"ocf\" provider\u003d\"pacemaker\" type\u003d\"remote\"\u003e"},{"line_number":21,"context_line":"          \u003coperations\u003e"},{"line_number":22,"context_line":"            \u003cop id\u003d\"{{ ansible_hostname }}-monitor-interval\" name\u003d\"monitor\" interval\u003d\"60\" timeout\u003d\"30\"/\u003e"},{"line_number":23,"context_line":"          \u003c/operations\u003e"},{"line_number":24,"context_line":"        \u003c/primitive\u003e"},{"line_number":25,"context_line":"      \u003c/resources\u003e"}],"source_content_type":"text/x-yaml","patch_set":47,"id":"3bbd53eb_76518823","line":22,"range":{"start_line":22,"start_character":50,"end_line":22,"end_character":59},"updated":"2021-03-14 19:59:37.000000000","message":"note-to-self: drop this part for clarity","commit_id":"0e560b0f538db97b54a1a2868fe8e973574c233d"},{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"1816fbde1ebb7503e1f98b69358bb2242d0373f3","unresolved":true,"context_lines":[{"line_number":21,"context_line":"          \u003coperations\u003e"},{"line_number":22,"context_line":"            \u003cop id\u003d\"{{ ansible_hostname }}-monitor-interval\" name\u003d\"monitor\" interval\u003d\"60\" timeout\u003d\"30\"/\u003e"},{"line_number":23,"context_line":"          \u003c/operations\u003e"},{"line_number":24,"context_line":"        \u003c/primitive\u003e"},{"line_number":25,"context_line":"      \u003c/resources\u003e"},{"line_number":26,"context_line":"    \u0027"},{"line_number":27,"context_line":"  become: true"}],"source_content_type":"text/x-yaml","patch_set":47,"id":"c2433c9c_b7d615ec","line":24,"range":{"start_line":24,"start_character":8,"end_line":24,"end_character":20},"updated":"2021-03-14 19:59:37.000000000","message":"note-to-self: add instance_attributes: server (with the desired ip address) and reconnect_interval","commit_id":"0e560b0f538db97b54a1a2868fe8e973574c233d"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"1196ae3eb529f7ae866c89fc977dfad923df24b7","unresolved":true,"context_lines":[{"line_number":3,"context_line":"  vars:"},{"line_number":4,"context_line":"    service: \"{{ hacluster_services[\u0027hacluster-pacemaker\u0027] }}\""},{"line_number":5,"context_line":"  command: docker exec {{ service.container_name }} crm_attribute --type crm_config --name stonith-enabled --update false"},{"line_number":6,"context_line":"  run_once: true"},{"line_number":7,"context_line":"  become: true"},{"line_number":8,"context_line":"  when:"},{"line_number":9,"context_line":"    - inventory_hostname in groups[service.group]"},{"line_number":10,"context_line":"    - service.enabled | bool"},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"- name: Ensure remote node is added"},{"line_number":13,"context_line":"  vars:"}],"source_content_type":"text/x-yaml","patch_set":50,"id":"3b11a3d9_55d2d931","line":10,"range":{"start_line":6,"start_character":0,"end_line":10,"end_character":28},"updated":"2021-04-09 16:41:43.000000000","message":"run_once \u0026 when don\u0027t play nicely together. If the selected host does not match, it will be skipped. We typically use delegate_to to work around that.","commit_id":"9f578c85e0b4e498e9bfb7d3795a9db1c545a611"},{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"447e485baaab55e8a0e11d9d46ef6b063dad3815","unresolved":true,"context_lines":[{"line_number":3,"context_line":"  vars:"},{"line_number":4,"context_line":"    service: \"{{ hacluster_services[\u0027hacluster-pacemaker\u0027] }}\""},{"line_number":5,"context_line":"  command: docker exec {{ service.container_name }} crm_attribute --type crm_config --name stonith-enabled --update false"},{"line_number":6,"context_line":"  run_once: true"},{"line_number":7,"context_line":"  become: true"},{"line_number":8,"context_line":"  when:"},{"line_number":9,"context_line":"    - inventory_hostname in groups[service.group]"},{"line_number":10,"context_line":"    - service.enabled | bool"},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"- name: Ensure remote node is added"},{"line_number":13,"context_line":"  vars:"}],"source_content_type":"text/x-yaml","patch_set":50,"id":"e3d0b23d_5909ae73","line":10,"range":{"start_line":6,"start_character":0,"end_line":10,"end_character":28},"in_reply_to":"3b11a3d9_55d2d931","updated":"2021-04-24 18:51:50.000000000","message":"Amending this in https://review.opendev.org/c/openstack/kolla-ansible/+/787858","commit_id":"9f578c85e0b4e498e9bfb7d3795a9db1c545a611"}],"ansible/roles/hacluster/tasks/precheck.yml":[{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"313d2c6d6077d3ecf5fda6e99bb4d5da47ef253c","unresolved":false,"context_lines":[{"line_number":10,"context_line":"# for it being up or down (TCP-only); in fact these prechecks should only really"},{"line_number":11,"context_line":"# check if the port is taken already by the host and not contact it"},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"- name: Check free port for Pacemaker Remote"},{"line_number":14,"context_line":"  wait_for:"},{"line_number":15,"context_line":"    host: \"{{ api_interface_address }}\""},{"line_number":16,"context_line":"    port: \"{{ hacluster_pacemaker_remote_port }}\""},{"line_number":17,"context_line":"    connect_timeout: 1"},{"line_number":18,"context_line":"    timeout: 1"},{"line_number":19,"context_line":"    state: stopped"},{"line_number":20,"context_line":"  when:"},{"line_number":21,"context_line":"    - container_facts[\u0027hacluster_pacemaker_remote\u0027] is not defined"},{"line_number":22,"context_line":"    - inventory_hostname in groups[\u0027hacluster-remote\u0027]"}],"source_content_type":"text/x-yaml","patch_set":46,"id":"9f560f44_97066421","line":22,"range":{"start_line":13,"start_character":0,"end_line":22,"end_character":54},"updated":"2020-09-14 10:39:43.000000000","message":"if it\u0027s udp - so why do we even check this?","commit_id":"8757e0d5f8cc9fa4ea78534a21eeb73a010a564f"},{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"9f77588653b903e1d5b83bc340998d067889b2ef","unresolved":false,"context_lines":[{"line_number":10,"context_line":"# for it being up or down (TCP-only); in fact these prechecks should only really"},{"line_number":11,"context_line":"# check if the port is taken already by the host and not contact it"},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"- name: Check free port for Pacemaker Remote"},{"line_number":14,"context_line":"  wait_for:"},{"line_number":15,"context_line":"    host: \"{{ api_interface_address }}\""},{"line_number":16,"context_line":"    port: \"{{ hacluster_pacemaker_remote_port }}\""},{"line_number":17,"context_line":"    connect_timeout: 1"},{"line_number":18,"context_line":"    timeout: 1"},{"line_number":19,"context_line":"    state: stopped"},{"line_number":20,"context_line":"  when:"},{"line_number":21,"context_line":"    - container_facts[\u0027hacluster_pacemaker_remote\u0027] is not defined"},{"line_number":22,"context_line":"    - inventory_hostname in groups[\u0027hacluster-remote\u0027]"}],"source_content_type":"text/x-yaml","patch_set":46,"id":"9f560f44_f197e844","line":22,"range":{"start_line":13,"start_character":0,"end_line":22,"end_character":54},"in_reply_to":"9f560f44_5124d4b2","updated":"2020-09-14 11:35:57.000000000","message":"I left an empty line! :D","commit_id":"8757e0d5f8cc9fa4ea78534a21eeb73a010a564f"},{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"c6e2ed44bda8ef3b834d0b62c4019b8db87bf984","unresolved":false,"context_lines":[{"line_number":10,"context_line":"# for it being up or down (TCP-only); in fact these prechecks should only really"},{"line_number":11,"context_line":"# check if the port is taken already by the host and not contact it"},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"- name: Check free port for Pacemaker Remote"},{"line_number":14,"context_line":"  wait_for:"},{"line_number":15,"context_line":"    host: \"{{ api_interface_address }}\""},{"line_number":16,"context_line":"    port: \"{{ hacluster_pacemaker_remote_port }}\""},{"line_number":17,"context_line":"    connect_timeout: 1"},{"line_number":18,"context_line":"    timeout: 1"},{"line_number":19,"context_line":"    state: stopped"},{"line_number":20,"context_line":"  when:"},{"line_number":21,"context_line":"    - container_facts[\u0027hacluster_pacemaker_remote\u0027] is not defined"},{"line_number":22,"context_line":"    - inventory_hostname in groups[\u0027hacluster-remote\u0027]"}],"source_content_type":"text/x-yaml","patch_set":46,"id":"9f560f44_5124d4b2","line":22,"range":{"start_line":13,"start_character":0,"end_line":22,"end_character":54},"in_reply_to":"9f560f44_860ab476","updated":"2020-09-14 11:04:03.000000000","message":"Right, I assumed the todo is related to the code below it :-)","commit_id":"8757e0d5f8cc9fa4ea78534a21eeb73a010a564f"},{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"3775653eb92cef8d3a0a8f1ed26a31f34f73f862","unresolved":false,"context_lines":[{"line_number":10,"context_line":"# for it being up or down (TCP-only); in fact these prechecks should only really"},{"line_number":11,"context_line":"# check if the port is taken already by the host and not contact it"},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"- name: Check free port for Pacemaker Remote"},{"line_number":14,"context_line":"  wait_for:"},{"line_number":15,"context_line":"    host: \"{{ api_interface_address }}\""},{"line_number":16,"context_line":"    port: \"{{ hacluster_pacemaker_remote_port }}\""},{"line_number":17,"context_line":"    connect_timeout: 1"},{"line_number":18,"context_line":"    timeout: 1"},{"line_number":19,"context_line":"    state: stopped"},{"line_number":20,"context_line":"  when:"},{"line_number":21,"context_line":"    - container_facts[\u0027hacluster_pacemaker_remote\u0027] is not defined"},{"line_number":22,"context_line":"    - inventory_hostname in groups[\u0027hacluster-remote\u0027]"}],"source_content_type":"text/x-yaml","patch_set":46,"id":"9f560f44_860ab476","line":22,"range":{"start_line":13,"start_character":0,"end_line":22,"end_character":54},"in_reply_to":"9f560f44_97066421","updated":"2020-09-14 10:43:16.000000000","message":"this is Pacemaker Remote, it\u0027s TCP","commit_id":"8757e0d5f8cc9fa4ea78534a21eeb73a010a564f"}],"ansible/roles/hacluster/templates/hacluster_corosync.conf.j2":[{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"905ad0a6d076ac03e8d6dc2dada6d8265d8c118a","unresolved":false,"context_lines":[{"line_number":1,"context_line":"totem {"},{"line_number":2,"context_line":"    version: 2"},{"line_number":3,"context_line":"    cluster_name: kolla-hacluster"},{"line_number":4,"context_line":"    # These prevent startup."},{"line_number":5,"context_line":"    #crypto_cipher: aes256"},{"line_number":6,"context_line":"    #crypto_hash: sha256"},{"line_number":7,"context_line":"    transport: udpu"},{"line_number":8,"context_line":"    interface {"},{"line_number":9,"context_line":"        ringnumber: 0"}],"source_content_type":"text/x-jinja2","patch_set":20,"id":"bf51134e_168cb033","line":6,"range":{"start_line":4,"start_character":4,"end_line":6,"end_character":24},"updated":"2020-07-23 08:55:49.000000000","message":"to drop, it has sensible defaults","commit_id":"8363bbab6926697c7fdece8df19058adb08fa849"},{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"905ad0a6d076ac03e8d6dc2dada6d8265d8c118a","unresolved":false,"context_lines":[{"line_number":8,"context_line":"    interface {"},{"line_number":9,"context_line":"        ringnumber: 0"},{"line_number":10,"context_line":"        bindnetaddr: {{ api_interface_address }}"},{"line_number":11,"context_line":"        mcastport: {{ hacluster_corosync_port }}"},{"line_number":12,"context_line":"    }"},{"line_number":13,"context_line":"}"},{"line_number":14,"context_line":""}],"source_content_type":"text/x-jinja2","patch_set":20,"id":"bf51134e_d6987876","line":11,"range":{"start_line":11,"start_character":8,"end_line":11,"end_character":48},"updated":"2020-07-23 08:55:49.000000000","message":"I do wonder whether this is to set the unicast port as well; to check (we are running unicast with udpu)","commit_id":"8363bbab6926697c7fdece8df19058adb08fa849"},{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"905ad0a6d076ac03e8d6dc2dada6d8265d8c118a","unresolved":false,"context_lines":[{"line_number":29,"context_line":"{% endif %}"},{"line_number":30,"context_line":"}"},{"line_number":31,"context_line":""},{"line_number":32,"context_line":"service {"},{"line_number":33,"context_line":"     name: pacemaker"},{"line_number":34,"context_line":"     ver: 1"},{"line_number":35,"context_line":"}"},{"line_number":36,"context_line":""},{"line_number":37,"context_line":"logging {"},{"line_number":38,"context_line":"    debug: {{ \u0027on\u0027 if openstack_logging_debug | bool else \u0027off\u0027 }}"}],"source_content_type":"text/x-jinja2","patch_set":20,"id":"bf51134e_d6ea38d6","line":35,"range":{"start_line":32,"start_character":0,"end_line":35,"end_character":1},"updated":"2020-07-23 08:55:49.000000000","message":"this to go away most likely","commit_id":"8363bbab6926697c7fdece8df19058adb08fa849"},{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"905ad0a6d076ac03e8d6dc2dada6d8265d8c118a","unresolved":false,"context_lines":[{"line_number":38,"context_line":"    debug: {{ \u0027on\u0027 if openstack_logging_debug | bool else \u0027off\u0027 }}"},{"line_number":39,"context_line":"    to_logfile: yes"},{"line_number":40,"context_line":"    logfile: /var/log/kolla/hacluster/corosync.log"},{"line_number":41,"context_line":"    to_syslog: yes"},{"line_number":42,"context_line":"    timestamp: on"},{"line_number":43,"context_line":"}"}],"source_content_type":"text/x-jinja2","patch_set":20,"id":"bf51134e_96e0c0fa","line":41,"range":{"start_line":41,"start_character":15,"end_line":41,"end_character":18},"updated":"2020-07-23 08:55:49.000000000","message":"probably no","commit_id":"8363bbab6926697c7fdece8df19058adb08fa849"}],"etc/kolla/globals.yml":[{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"13f9b2ac6bcb495c9a740626392ed9e1cf3cb286","unresolved":false,"context_lines":[{"line_number":222,"context_line":"# These roles are required for Kolla to be operation, however a savvy deployer"},{"line_number":223,"context_line":"# could disable some of these required roles and run their own services."},{"line_number":224,"context_line":"#enable_glance: \"{{ enable_openstack_core | bool }}\""},{"line_number":225,"context_line":"#enable_hacluster: \"no\""},{"line_number":226,"context_line":"#enable_haproxy: \"yes\""},{"line_number":227,"context_line":"#enable_keepalived: \"{{ enable_haproxy | bool }}\""},{"line_number":228,"context_line":"#enable_keystone: \"{{ enable_openstack_core | bool }}\""}],"source_content_type":"text/x-yaml","patch_set":16,"id":"bf51134e_6a6280da","line":225,"updated":"2020-07-22 12:18:56.000000000","message":"Move to main block","commit_id":"2578aa5ca68a4ef4ff307282136b29222f560470"}],"tests/test-masakari.sh":[{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"7b13c22d930bba074429bfbbaadae3da32defd66","unresolved":false,"context_lines":[{"line_number":53,"context_line":"    fi"},{"line_number":54,"context_line":"}"},{"line_number":55,"context_line":""},{"line_number":56,"context_line":"function test_masakari_logged {"},{"line_number":57,"context_line":"    # Source OpenStack credentials"},{"line_number":58,"context_line":"    . /etc/kolla/admin-openrc.sh"},{"line_number":59,"context_line":""}],"source_content_type":"text/x-sh","patch_set":38,"id":"9f560f44_49d5f642","line":56,"updated":"2020-07-30 16:25:48.000000000","message":"I find it disturbing git diff seems to treat this line as \u0027not modifed yet different\u0027... what the...","commit_id":"478659520b800955b970977b7c2e351de6573775"}]}
