)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"6e3360dabb4efcb93fdcd41e23c450f3dd3ab8e5","unresolved":false,"context_lines":[{"line_number":126,"context_line":"it is obsolete, and the default in Keystone is CADF."},{"line_number":127,"context_line":""},{"line_number":128,"context_line":"* Mistral:"},{"line_number":129,"context_line":"It was hardcoded \"noop\" as the driver. However, that does not seem a"},{"line_number":130,"context_line":"good practice. Instead, I applied the same standard of using the driver"},{"line_number":131,"context_line":"and pushing to \"notifications\" queue if Ceilometer is enabled."},{"line_number":132,"context_line":""},{"line_number":133,"context_line":"* Cyborg:"},{"line_number":134,"context_line":"I created a mechanism similar to what we have in AODH, Cinder, Nova,"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":10,"id":"7faddb67_3de26aa1","line":131,"range":{"start_line":129,"start_character":0,"end_line":131,"end_character":62},"updated":"2019-08-05 16:40:36.000000000","message":"Is this because Mistral does not support notifications? Perhaps there are some services that do not?","commit_id":"3e72ea33f3c2a30d10d4e4bd5819e7d5d5287290"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"0114b5bdf5b4a4ec8ceb6040e1081fbae6029385","unresolved":false,"context_lines":[{"line_number":126,"context_line":"it is obsolete, and the default in Keystone is CADF."},{"line_number":127,"context_line":""},{"line_number":128,"context_line":"* Mistral:"},{"line_number":129,"context_line":"It was hardcoded \"noop\" as the driver. However, that does not seem a"},{"line_number":130,"context_line":"good practice. Instead, I applied the same standard of using the driver"},{"line_number":131,"context_line":"and pushing to \"notifications\" queue if Ceilometer is enabled."},{"line_number":132,"context_line":""},{"line_number":133,"context_line":"* Cyborg:"},{"line_number":134,"context_line":"I created a mechanism similar to what we have in AODH, Cinder, Nova,"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":10,"id":"7faddb67_855460ff","line":131,"range":{"start_line":129,"start_character":0,"end_line":131,"end_character":62},"in_reply_to":"7faddb67_3857d828","updated":"2019-08-05 18:43:00.000000000","message":"I agree in principle, I\u0027d like to be sure that there is nothing else that depends on it though.\n\nThe changes in https://review.opendev.org/#/c/674579 suggests it could be used for the keystone audit middleware (although the docs for it suggests it should use [audit_middleware_notifications]). Either way, I guess it would need the driver to be set, but that could be done via a custom configuration file.","commit_id":"3e72ea33f3c2a30d10d4e4bd5819e7d5d5287290"},{"author":{"_account_id":28356,"name":"Rafael Weingartner","email":"rafael@apache.org","username":"rafaelweingartner"},"change_message_id":"ed26de7e037a6e1ee4cd0a5708c94348596512f4","unresolved":false,"context_lines":[{"line_number":126,"context_line":"it is obsolete, and the default in Keystone is CADF."},{"line_number":127,"context_line":""},{"line_number":128,"context_line":"* Mistral:"},{"line_number":129,"context_line":"It was hardcoded \"noop\" as the driver. However, that does not seem a"},{"line_number":130,"context_line":"good practice. Instead, I applied the same standard of using the driver"},{"line_number":131,"context_line":"and pushing to \"notifications\" queue if Ceilometer is enabled."},{"line_number":132,"context_line":""},{"line_number":133,"context_line":"* Cyborg:"},{"line_number":134,"context_line":"I created a mechanism similar to what we have in AODH, Cinder, Nova,"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":10,"id":"7faddb67_3857d828","line":131,"range":{"start_line":129,"start_character":0,"end_line":131,"end_character":62},"in_reply_to":"7faddb67_3de26aa1","updated":"2019-08-05 17:31:38.000000000","message":"If it does not, it would make more sense not to have the section there. What do you think?","commit_id":"3e72ea33f3c2a30d10d4e4bd5819e7d5d5287290"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"6e3360dabb4efcb93fdcd41e23c450f3dd3ab8e5","unresolved":false,"context_lines":[{"line_number":158,"context_line":"It was already using a similar scheme; I just modified it a little bit"},{"line_number":159,"context_line":"to be the same as we have in all other components"},{"line_number":160,"context_line":""},{"line_number":161,"context_line":"Closes-Bug: https://bugs.launchpad.net/kolla-ansible/+bug/1838985"},{"line_number":162,"context_line":""},{"line_number":163,"context_line":"Change-Id: I88bdb004814f37c81c9a9c4e5e491fac69f6f202"},{"line_number":164,"context_line":"Signed-off-by: Rafael Weingärtner \u003crafael@apache.org\u003e"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":10,"id":"7faddb67_7da462a6","line":161,"range":{"start_line":161,"start_character":0,"end_line":161,"end_character":65},"updated":"2019-08-05 16:40:36.000000000","message":"Closes-Bug: #1838985","commit_id":"3e72ea33f3c2a30d10d4e4bd5819e7d5d5287290"},{"author":{"_account_id":28356,"name":"Rafael Weingartner","email":"rafael@apache.org","username":"rafaelweingartner"},"change_message_id":"ed26de7e037a6e1ee4cd0a5708c94348596512f4","unresolved":false,"context_lines":[{"line_number":158,"context_line":"It was already using a similar scheme; I just modified it a little bit"},{"line_number":159,"context_line":"to be the same as we have in all other components"},{"line_number":160,"context_line":""},{"line_number":161,"context_line":"Closes-Bug: https://bugs.launchpad.net/kolla-ansible/+bug/1838985"},{"line_number":162,"context_line":""},{"line_number":163,"context_line":"Change-Id: I88bdb004814f37c81c9a9c4e5e491fac69f6f202"},{"line_number":164,"context_line":"Signed-off-by: Rafael Weingärtner \u003crafael@apache.org\u003e"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":10,"id":"7faddb67_5852d436","line":161,"range":{"start_line":161,"start_character":0,"end_line":161,"end_character":65},"in_reply_to":"7faddb67_7da462a6","updated":"2019-08-05 17:31:38.000000000","message":"fixed","commit_id":"3e72ea33f3c2a30d10d4e4bd5819e7d5d5287290"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"6bff47c84488a243dc659e90d6bd9c56cfe4357a","unresolved":false,"context_lines":[{"line_number":14,"context_line":"enable/disable notifications across projects based on components (e.g."},{"line_number":15,"context_line":"Ceilometer) being enabled or disabled. Here follows the list of"},{"line_number":16,"context_line":"components, and the respective changes I did."},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"* Aodh:"},{"line_number":19,"context_line":"It was already properly configured."},{"line_number":20,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":19,"id":"7faddb67_4a89e572","line":17,"updated":"2019-08-15 13:00:40.000000000","message":"These need updating to reflect the current set.","commit_id":"da9035b157d95fb431339982a017fd9d6e177421"}],"ansible/group_vars/all.yml":[{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"4404ee155988275999e1c0196010757e249a3f35","unresolved":false,"context_lines":[{"line_number":519,"context_line":"enable_barbican: \"no\""},{"line_number":520,"context_line":"enable_blazar: \"no\""},{"line_number":521,"context_line":"enable_ceilometer: \"no\""},{"line_number":522,"context_line":"enable_cadf_notifications: \"no\""},{"line_number":523,"context_line":"enable_ceilometer_ipmi: \"no\""},{"line_number":524,"context_line":"enable_central_logging: \"no\""},{"line_number":525,"context_line":"enable_ceph: \"no\""}],"source_content_type":"text/x-yaml","patch_set":13,"id":"7faddb67_567b7279","line":522,"range":{"start_line":522,"start_character":0,"end_line":522,"end_character":31},"updated":"2019-08-06 15:32:39.000000000","message":"nit: should be before ceilometer to preserve original ordering.\n\nAlso, please add a comment like this here:\n\n# NOTE: This variable has been deprecated and will be removed in the U cycle.","commit_id":"06c487dcb9c589dfc5b9234b03dae385437e6123"},{"author":{"_account_id":28356,"name":"Rafael Weingartner","email":"rafael@apache.org","username":"rafaelweingartner"},"change_message_id":"a96c6dd9ede39c5244631d196fa2e1b6514ef8ef","unresolved":false,"context_lines":[{"line_number":519,"context_line":"enable_barbican: \"no\""},{"line_number":520,"context_line":"enable_blazar: \"no\""},{"line_number":521,"context_line":"enable_ceilometer: \"no\""},{"line_number":522,"context_line":"enable_cadf_notifications: \"no\""},{"line_number":523,"context_line":"enable_ceilometer_ipmi: \"no\""},{"line_number":524,"context_line":"enable_central_logging: \"no\""},{"line_number":525,"context_line":"enable_ceph: \"no\""}],"source_content_type":"text/x-yaml","patch_set":13,"id":"7faddb67_046b80b6","line":522,"range":{"start_line":522,"start_character":0,"end_line":522,"end_character":31},"in_reply_to":"7faddb67_567b7279","updated":"2019-08-06 16:33:41.000000000","message":"Done, thanks","commit_id":"06c487dcb9c589dfc5b9234b03dae385437e6123"}],"ansible/roles/barbican/defaults/main.yml":[{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"f66a70a6c455c0d1ebf10bb1f92865d859f85260","unresolved":false,"context_lines":[{"line_number":115,"context_line":"barbican_dev_repos_pull: \"{{ kolla_dev_repos_pull }}\""},{"line_number":116,"context_line":"barbican_dev_mode: \"{{ kolla_dev_mode }}\""},{"line_number":117,"context_line":"barbican_source_version: \"{{ kolla_source_version }}\""},{"line_number":118,"context_line":""},{"line_number":119,"context_line":"####################"},{"line_number":120,"context_line":"# Notifications"},{"line_number":121,"context_line":"####################"}],"source_content_type":"text/x-yaml","patch_set":6,"id":"7faddb67_0fe2dfd5","line":118,"updated":"2019-08-04 17:40:45.000000000","message":"Adding some general comments in here, but these are optional. It might be better to make these changes (if you want to) in a separate patch.","commit_id":"774889bc06596b8af04f5b96d28836b8cee7e03f"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"f66a70a6c455c0d1ebf10bb1f92865d859f85260","unresolved":false,"context_lines":[{"line_number":120,"context_line":"# Notifications"},{"line_number":121,"context_line":"####################"},{"line_number":122,"context_line":"barbican_notification_topics:"},{"line_number":123,"context_line":"  - name: notifications"},{"line_number":124,"context_line":"    enabled: \"{{ enable_ceilometer | bool }}\""},{"line_number":125,"context_line":""},{"line_number":126,"context_line":"barbican_enabled_notification_topics: \"{{ barbican_notification_topics | selectattr(\u0027enabled\u0027, \u0027equalto\u0027, true) | list }}\""}],"source_content_type":"text/x-yaml","patch_set":6,"id":"7faddb67_cfe7e7e2","line":123,"range":{"start_line":123,"start_character":10,"end_line":123,"end_character":23},"updated":"2019-08-04 17:40:45.000000000","message":"Might be nice to make this configurable per-service, with a global default. e.g.\n\ngroup_vars/all.yml:\nnotification_topic: notifications\n\nthis file:\nbarbican_notification_topic: \"{{ notification_topic }}\"","commit_id":"774889bc06596b8af04f5b96d28836b8cee7e03f"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"f66a70a6c455c0d1ebf10bb1f92865d859f85260","unresolved":false,"context_lines":[{"line_number":121,"context_line":"####################"},{"line_number":122,"context_line":"barbican_notification_topics:"},{"line_number":123,"context_line":"  - name: notifications"},{"line_number":124,"context_line":"    enabled: \"{{ enable_ceilometer | bool }}\""},{"line_number":125,"context_line":""},{"line_number":126,"context_line":"barbican_enabled_notification_topics: \"{{ barbican_notification_topics | selectattr(\u0027enabled\u0027, \u0027equalto\u0027, true) | list }}\""}],"source_content_type":"text/x-yaml","patch_set":6,"id":"7faddb67_8fcd6f5e","line":124,"range":{"start_line":124,"start_character":17,"end_line":124,"end_character":41},"updated":"2019-08-04 17:40:45.000000000","message":"Also, could extract this into a global and per-service flag. e.g.\n\ngroup_vars/all.yml\nnotifications_enabled: \"{{ enable_ceilometer | bool }}\"\n\nthis file:\nbarbican_notifications_enabled: \"{{ notifications_enabled }}\"\n\nThis means we could enable notifications even if we\u0027re not using ceilometer.","commit_id":"774889bc06596b8af04f5b96d28836b8cee7e03f"}],"ansible/roles/barbican/templates/barbican.conf.j2":[{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"6e3360dabb4efcb93fdcd41e23c450f3dd3ab8e5","unresolved":false,"context_lines":[{"line_number":66,"context_line":""},{"line_number":67,"context_line":"[oslo_messaging_notifications]"},{"line_number":68,"context_line":"transport_url \u003d {{ notify_transport_url }}"},{"line_number":69,"context_line":"{% if barbican_enabled_notification_topics %}"},{"line_number":70,"context_line":"driver \u003d messagingv2"},{"line_number":71,"context_line":"topics \u003d {{ barbican_enabled_notification_topics | map(attribute\u003d\u0027name\u0027) | join(\u0027,\u0027) }}"},{"line_number":72,"context_line":"{% else %}"},{"line_number":73,"context_line":"driver \u003d noop"},{"line_number":74,"context_line":"{% endif %}"},{"line_number":75,"context_line":""},{"line_number":76,"context_line":"[oslo_middleware]"},{"line_number":77,"context_line":"enable_proxy_headers_parsing \u003d True"}],"source_content_type":"text/x-jinja2","patch_set":10,"id":"7faddb67_1d368e04","line":74,"range":{"start_line":69,"start_character":0,"end_line":74,"end_character":11},"updated":"2019-08-05 16:40:36.000000000","message":"I\u0027m not actually sure that barbican produces notifications. I grepped the source and could not see any. OSA does not configure a driver: https://github.com/openstack/openstack-ansible-os_barbican/blob/master/templates/barbican.conf.j2.","commit_id":"3e72ea33f3c2a30d10d4e4bd5819e7d5d5287290"},{"author":{"_account_id":28356,"name":"Rafael Weingartner","email":"rafael@apache.org","username":"rafaelweingartner"},"change_message_id":"d224d4e7880eacf64a928d95a83b1907b21fd305","unresolved":false,"context_lines":[{"line_number":66,"context_line":""},{"line_number":67,"context_line":"[oslo_messaging_notifications]"},{"line_number":68,"context_line":"transport_url \u003d {{ notify_transport_url }}"},{"line_number":69,"context_line":"{% if barbican_enabled_notification_topics %}"},{"line_number":70,"context_line":"driver \u003d messagingv2"},{"line_number":71,"context_line":"topics \u003d {{ barbican_enabled_notification_topics | map(attribute\u003d\u0027name\u0027) | join(\u0027,\u0027) }}"},{"line_number":72,"context_line":"{% else %}"},{"line_number":73,"context_line":"driver \u003d noop"},{"line_number":74,"context_line":"{% endif %}"},{"line_number":75,"context_line":""},{"line_number":76,"context_line":"[oslo_middleware]"},{"line_number":77,"context_line":"enable_proxy_headers_parsing \u003d True"}],"source_content_type":"text/x-jinja2","patch_set":10,"id":"7faddb67_98692c26","line":74,"range":{"start_line":69,"start_character":0,"end_line":74,"end_character":11},"in_reply_to":"7faddb67_1d368e04","updated":"2019-08-05 17:30:46.000000000","message":"Me neither. I just wanted to maintain what was already in place. I saw an \"oslo_messaging\" section here. Therefore, I applied the method at least to configure it properly. If it does not have, we could remove it. However, I would rather do the removal after this PR gets merged. Right now, we are just using the same standard method to control notifications.","commit_id":"3e72ea33f3c2a30d10d4e4bd5819e7d5d5287290"}],"ansible/roles/congress/templates/congress.conf.j2":[{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"6e3360dabb4efcb93fdcd41e23c450f3dd3ab8e5","unresolved":false,"context_lines":[{"line_number":44,"context_line":""},{"line_number":45,"context_line":"[oslo_messaging_notifications]"},{"line_number":46,"context_line":"transport_url \u003d {{ notify_transport_url }}"},{"line_number":47,"context_line":"driver \u003d messagingv2"},{"line_number":48,"context_line":""},{"line_number":49,"context_line":"{% if congress_policy_file is defined %}"},{"line_number":50,"context_line":"[oslo_policy]"}],"source_content_type":"text/x-jinja2","patch_set":10,"id":"7faddb67_7d0f8236","line":47,"updated":"2019-08-05 16:40:36.000000000","message":"OSA does not configure this. Perhaps congress does not generate notifications.\n\nhttps://github.com/openstack/openstack-ansible-os_congress/blob/master/templates/congress.conf.j2","commit_id":"3e72ea33f3c2a30d10d4e4bd5819e7d5d5287290"},{"author":{"_account_id":28356,"name":"Rafael Weingartner","email":"rafael@apache.org","username":"rafaelweingartner"},"change_message_id":"d224d4e7880eacf64a928d95a83b1907b21fd305","unresolved":false,"context_lines":[{"line_number":44,"context_line":""},{"line_number":45,"context_line":"[oslo_messaging_notifications]"},{"line_number":46,"context_line":"transport_url \u003d {{ notify_transport_url }}"},{"line_number":47,"context_line":"driver \u003d messagingv2"},{"line_number":48,"context_line":""},{"line_number":49,"context_line":"{% if congress_policy_file is defined %}"},{"line_number":50,"context_line":"[oslo_policy]"}],"source_content_type":"text/x-jinja2","patch_set":10,"id":"7faddb67_f8638040","line":47,"in_reply_to":"7faddb67_7d0f8236","updated":"2019-08-05 17:30:46.000000000","message":"I remember checking this, and it seems that congress can use notifications queue. However, I might be mistaken. If it does not use, we should remove the whole section, right? Can we do the removal discussion in a separated PR then?","commit_id":"3e72ea33f3c2a30d10d4e4bd5819e7d5d5287290"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"0114b5bdf5b4a4ec8ceb6040e1081fbae6029385","unresolved":false,"context_lines":[{"line_number":44,"context_line":""},{"line_number":45,"context_line":"[oslo_messaging_notifications]"},{"line_number":46,"context_line":"transport_url \u003d {{ notify_transport_url }}"},{"line_number":47,"context_line":"driver \u003d messagingv2"},{"line_number":48,"context_line":""},{"line_number":49,"context_line":"{% if congress_policy_file is defined %}"},{"line_number":50,"context_line":"[oslo_policy]"}],"source_content_type":"text/x-jinja2","patch_set":10,"id":"7faddb67_856d40cd","line":47,"in_reply_to":"7faddb67_f8638040","updated":"2019-08-05 18:43:00.000000000","message":"I didn\u0027t check congress itself. In fact I remember your comment about the fixed topics, which suggests it does.","commit_id":"3e72ea33f3c2a30d10d4e4bd5819e7d5d5287290"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"4404ee155988275999e1c0196010757e249a3f35","unresolved":false,"context_lines":[{"line_number":44,"context_line":""},{"line_number":45,"context_line":"[oslo_messaging_notifications]"},{"line_number":46,"context_line":"transport_url \u003d {{ notify_transport_url }}"},{"line_number":47,"context_line":"driver \u003d messagingv2"},{"line_number":48,"context_line":""},{"line_number":49,"context_line":"{% if congress_policy_file is defined %}"},{"line_number":50,"context_line":"[oslo_policy]"}],"source_content_type":"text/x-jinja2","patch_set":13,"id":"7faddb67_36911653","line":47,"range":{"start_line":47,"start_character":0,"end_line":47,"end_character":20},"updated":"2019-08-06 15:32:39.000000000","message":"Does something within congress consume these notifications, or should we gate this on enable_ceilometer?","commit_id":"06c487dcb9c589dfc5b9234b03dae385437e6123"},{"author":{"_account_id":28356,"name":"Rafael Weingartner","email":"rafael@apache.org","username":"rafaelweingartner"},"change_message_id":"a96c6dd9ede39c5244631d196fa2e1b6514ef8ef","unresolved":false,"context_lines":[{"line_number":44,"context_line":""},{"line_number":45,"context_line":"[oslo_messaging_notifications]"},{"line_number":46,"context_line":"transport_url \u003d {{ notify_transport_url }}"},{"line_number":47,"context_line":"driver \u003d messagingv2"},{"line_number":48,"context_line":""},{"line_number":49,"context_line":"{% if congress_policy_file is defined %}"},{"line_number":50,"context_line":"[oslo_policy]"}],"source_content_type":"text/x-jinja2","patch_set":13,"id":"7faddb67_84d45021","line":47,"range":{"start_line":47,"start_character":0,"end_line":47,"end_character":20},"in_reply_to":"7faddb67_36911653","updated":"2019-08-06 16:33:41.000000000","message":"I think we should use the \"enable_ceilometer\".\n\nI will do that.","commit_id":"06c487dcb9c589dfc5b9234b03dae385437e6123"},{"author":{"_account_id":28356,"name":"Rafael Weingartner","email":"rafael@apache.org","username":"rafaelweingartner"},"change_message_id":"417dfefa45abab47441b2dbb0bd8a8e5b757f9b8","unresolved":false,"context_lines":[{"line_number":44,"context_line":""},{"line_number":45,"context_line":"[oslo_messaging_notifications]"},{"line_number":46,"context_line":"transport_url \u003d {{ notify_transport_url }}"},{"line_number":47,"context_line":"driver \u003d messagingv2"},{"line_number":48,"context_line":""},{"line_number":49,"context_line":"{% if congress_policy_file is defined %}"},{"line_number":50,"context_line":"[oslo_policy]"}],"source_content_type":"text/x-jinja2","patch_set":13,"id":"7faddb67_77c8e520","line":47,"range":{"start_line":47,"start_character":0,"end_line":47,"end_character":20},"in_reply_to":"7faddb67_648354cc","updated":"2019-08-06 19:41:18.000000000","message":"It is not connected to listen, but to push messages, right?","commit_id":"06c487dcb9c589dfc5b9234b03dae385437e6123"},{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"7c32640e26bf9812f0778bdbcc3b25d0889acffb","unresolved":false,"context_lines":[{"line_number":44,"context_line":""},{"line_number":45,"context_line":"[oslo_messaging_notifications]"},{"line_number":46,"context_line":"transport_url \u003d {{ notify_transport_url }}"},{"line_number":47,"context_line":"driver \u003d messagingv2"},{"line_number":48,"context_line":""},{"line_number":49,"context_line":"{% if congress_policy_file is defined %}"},{"line_number":50,"context_line":"[oslo_policy]"}],"source_content_type":"text/x-jinja2","patch_set":13,"id":"7faddb67_648354cc","line":47,"range":{"start_line":47,"start_character":0,"end_line":47,"end_character":20},"in_reply_to":"7faddb67_84d45021","updated":"2019-08-06 16:44:09.000000000","message":"Well, in the same comment Mark has proven that ceilometer by default does not listen for congress notifications. So it is a bit more complicated. :-)","commit_id":"06c487dcb9c589dfc5b9234b03dae385437e6123"}],"ansible/roles/designate/defaults/main.yml":[{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"f66a70a6c455c0d1ebf10bb1f92865d859f85260","unresolved":false,"context_lines":[{"line_number":214,"context_line":"designate_topic_name: \"notifications_designate\""},{"line_number":215,"context_line":""},{"line_number":216,"context_line":"designate_notification_topics:"},{"line_number":217,"context_line":"  - name: \"{{ designate_topic_name }}\""},{"line_number":218,"context_line":"    enabled: True"},{"line_number":219,"context_line":""},{"line_number":220,"context_line":"designate_enabled_notification_topics: \"{{ designate_notification_topics | selectattr(\u0027enabled\u0027, \u0027equalto\u0027, true) | list }}\""}],"source_content_type":"text/x-yaml","patch_set":6,"id":"7faddb67_cfb287e5","line":217,"updated":"2019-08-04 17:40:45.000000000","message":"designate_notification_topic_name","commit_id":"774889bc06596b8af04f5b96d28836b8cee7e03f"},{"author":{"_account_id":28356,"name":"Rafael Weingartner","email":"rafael@apache.org","username":"rafaelweingartner"},"change_message_id":"2bb235f9459ffc3961367d21e5040d33431e4d7e","unresolved":false,"context_lines":[{"line_number":214,"context_line":"designate_topic_name: \"notifications_designate\""},{"line_number":215,"context_line":""},{"line_number":216,"context_line":"designate_notification_topics:"},{"line_number":217,"context_line":"  - name: \"{{ designate_topic_name }}\""},{"line_number":218,"context_line":"    enabled: True"},{"line_number":219,"context_line":""},{"line_number":220,"context_line":"designate_enabled_notification_topics: \"{{ designate_notification_topics | selectattr(\u0027enabled\u0027, \u0027equalto\u0027, true) | list }}\""}],"source_content_type":"text/x-yaml","patch_set":6,"id":"7faddb67_d6f0dbff","line":217,"in_reply_to":"7faddb67_cfb287e5","updated":"2019-08-05 11:50:30.000000000","message":"fixed","commit_id":"774889bc06596b8af04f5b96d28836b8cee7e03f"}],"ansible/roles/ironic/defaults/main.yml":[{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"277d01f4ac767dae2bbc63e6ad49778e524f8701","unresolved":false,"context_lines":[{"line_number":210,"context_line":"ironic_dev_repos_pull: \"{{ kolla_dev_repos_pull }}\""},{"line_number":211,"context_line":"ironic_dev_mode: \"{{ kolla_dev_mode }}\""},{"line_number":212,"context_line":"ironic_source_version: \"{{ kolla_source_version }}\""},{"line_number":213,"context_line":""},{"line_number":214,"context_line":""},{"line_number":215,"context_line":"####################"},{"line_number":216,"context_line":"# Notifications"},{"line_number":217,"context_line":"####################"},{"line_number":218,"context_line":"ironic_notification_topics:"},{"line_number":219,"context_line":"  - name: notifications"},{"line_number":220,"context_line":"    enabled: \"{{ enable_ceilometer | bool }}\""},{"line_number":221,"context_line":""},{"line_number":222,"context_line":"ironic_enabled_notification_topics: \"{{ ironic_notification_topics | selectattr(\u0027enabled\u0027, \u0027equalto\u0027, true) | list }}\""}],"source_content_type":"text/x-yaml","patch_set":7,"id":"7faddb67_896ec42c","line":222,"range":{"start_line":213,"start_character":0,"end_line":222,"end_character":118},"updated":"2019-08-05 13:24:52.000000000","message":"This is necessary - ironic supports notifications but ironic inspector does not.","commit_id":"a13cab6896062b90c191d51d3c03801d55b4fbb9"},{"author":{"_account_id":28356,"name":"Rafael Weingartner","email":"rafael@apache.org","username":"rafaelweingartner"},"change_message_id":"f1314d6460faccc0bc1c88c63efeb523e2e4207e","unresolved":false,"context_lines":[{"line_number":210,"context_line":"ironic_dev_repos_pull: \"{{ kolla_dev_repos_pull }}\""},{"line_number":211,"context_line":"ironic_dev_mode: \"{{ kolla_dev_mode }}\""},{"line_number":212,"context_line":"ironic_source_version: \"{{ kolla_source_version }}\""},{"line_number":213,"context_line":""},{"line_number":214,"context_line":""},{"line_number":215,"context_line":"####################"},{"line_number":216,"context_line":"# Notifications"},{"line_number":217,"context_line":"####################"},{"line_number":218,"context_line":"ironic_notification_topics:"},{"line_number":219,"context_line":"  - name: notifications"},{"line_number":220,"context_line":"    enabled: \"{{ enable_ceilometer | bool }}\""},{"line_number":221,"context_line":""},{"line_number":222,"context_line":"ironic_enabled_notification_topics: \"{{ ironic_notification_topics | selectattr(\u0027enabled\u0027, \u0027equalto\u0027, true) | list }}\""}],"source_content_type":"text/x-yaml","patch_set":7,"id":"7faddb67_8c4c9242","line":222,"range":{"start_line":213,"start_character":0,"end_line":222,"end_character":118},"in_reply_to":"7faddb67_896ec42c","updated":"2019-08-05 14:09:39.000000000","message":"Yes, sorry for that.\n\nMy brain is still cold this morning...","commit_id":"a13cab6896062b90c191d51d3c03801d55b4fbb9"}],"ansible/roles/ironic/templates/ironic-inspector.conf.j2":[{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"f66a70a6c455c0d1ebf10bb1f92865d859f85260","unresolved":false,"context_lines":[{"line_number":11,"context_line":""},{"line_number":12,"context_line":"[oslo_messaging_notifications]"},{"line_number":13,"context_line":"transport_url \u003d {{ notify_transport_url }}"},{"line_number":14,"context_line":"{% if ironic_enabled_notification_topics %}"},{"line_number":15,"context_line":"driver \u003d messagingv2"},{"line_number":16,"context_line":"topics \u003d {{ ironic_enabled_notification_topics | map(attribute\u003d\u0027name\u0027) | join(\u0027,\u0027) }}"},{"line_number":17,"context_line":"{% else %}"},{"line_number":18,"context_line":"driver \u003d noop"},{"line_number":19,"context_line":"{% endif %}"},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"[ironic]"},{"line_number":22,"context_line":"{% if enable_keystone | bool %}"}],"source_content_type":"text/x-jinja2","patch_set":6,"id":"7faddb67_4fbe97ae","line":19,"range":{"start_line":14,"start_character":0,"end_line":19,"end_character":11},"updated":"2019-08-04 17:40:45.000000000","message":"I don\u0027t think ironic inspector produces notifications currently.","commit_id":"774889bc06596b8af04f5b96d28836b8cee7e03f"},{"author":{"_account_id":28356,"name":"Rafael Weingartner","email":"rafael@apache.org","username":"rafaelweingartner"},"change_message_id":"2bb235f9459ffc3961367d21e5040d33431e4d7e","unresolved":false,"context_lines":[{"line_number":11,"context_line":""},{"line_number":12,"context_line":"[oslo_messaging_notifications]"},{"line_number":13,"context_line":"transport_url \u003d {{ notify_transport_url }}"},{"line_number":14,"context_line":"{% if ironic_enabled_notification_topics %}"},{"line_number":15,"context_line":"driver \u003d messagingv2"},{"line_number":16,"context_line":"topics \u003d {{ ironic_enabled_notification_topics | map(attribute\u003d\u0027name\u0027) | join(\u0027,\u0027) }}"},{"line_number":17,"context_line":"{% else %}"},{"line_number":18,"context_line":"driver \u003d noop"},{"line_number":19,"context_line":"{% endif %}"},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"[ironic]"},{"line_number":22,"context_line":"{% if enable_keystone | bool %}"}],"source_content_type":"text/x-jinja2","patch_set":6,"id":"7faddb67_b6d99f83","line":19,"range":{"start_line":14,"start_character":0,"end_line":19,"end_character":11},"in_reply_to":"7faddb67_4fbe97ae","updated":"2019-08-05 11:50:30.000000000","message":"I was not sure. If it does not use notifications, shouldn\u0027t we remove the oslo messaging section then?","commit_id":"774889bc06596b8af04f5b96d28836b8cee7e03f"},{"author":{"_account_id":28356,"name":"Rafael Weingartner","email":"rafael@apache.org","username":"rafaelweingartner"},"change_message_id":"26cd1c5d111e57bc55044ea0d5f43b419382e9a7","unresolved":false,"context_lines":[{"line_number":11,"context_line":""},{"line_number":12,"context_line":"[oslo_messaging_notifications]"},{"line_number":13,"context_line":"transport_url \u003d {{ notify_transport_url }}"},{"line_number":14,"context_line":"{% if ironic_enabled_notification_topics %}"},{"line_number":15,"context_line":"driver \u003d messagingv2"},{"line_number":16,"context_line":"topics \u003d {{ ironic_enabled_notification_topics | map(attribute\u003d\u0027name\u0027) | join(\u0027,\u0027) }}"},{"line_number":17,"context_line":"{% else %}"},{"line_number":18,"context_line":"driver \u003d noop"},{"line_number":19,"context_line":"{% endif %}"},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"[ironic]"},{"line_number":22,"context_line":"{% if enable_keystone | bool %}"}],"source_content_type":"text/x-jinja2","patch_set":6,"id":"7faddb67_36684ff3","line":19,"range":{"start_line":14,"start_character":0,"end_line":19,"end_character":11},"in_reply_to":"7faddb67_56d86b1c","updated":"2019-08-05 12:17:05.000000000","message":"Ok, I will remove it then.","commit_id":"774889bc06596b8af04f5b96d28836b8cee7e03f"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"1d13659162a0ddcc8a42e754092f53bd33bccd3a","unresolved":false,"context_lines":[{"line_number":11,"context_line":""},{"line_number":12,"context_line":"[oslo_messaging_notifications]"},{"line_number":13,"context_line":"transport_url \u003d {{ notify_transport_url }}"},{"line_number":14,"context_line":"{% if ironic_enabled_notification_topics %}"},{"line_number":15,"context_line":"driver \u003d messagingv2"},{"line_number":16,"context_line":"topics \u003d {{ ironic_enabled_notification_topics | map(attribute\u003d\u0027name\u0027) | join(\u0027,\u0027) }}"},{"line_number":17,"context_line":"{% else %}"},{"line_number":18,"context_line":"driver \u003d noop"},{"line_number":19,"context_line":"{% endif %}"},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"[ironic]"},{"line_number":22,"context_line":"{% if enable_keystone | bool %}"}],"source_content_type":"text/x-jinja2","patch_set":6,"id":"7faddb67_56d86b1c","line":19,"range":{"start_line":14,"start_character":0,"end_line":19,"end_character":11},"in_reply_to":"7faddb67_b6d99f83","updated":"2019-08-05 12:02:45.000000000","message":"Yes I think so. If it does add support for them, it should be configured separately from ironic.","commit_id":"774889bc06596b8af04f5b96d28836b8cee7e03f"}],"ansible/roles/keystone/defaults/main.yml":[{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"277d01f4ac767dae2bbc63e6ad49778e524f8701","unresolved":false,"context_lines":[{"line_number":120,"context_line":"####################"},{"line_number":121,"context_line":"keystone_notification_topics:"},{"line_number":122,"context_line":"  - name: notifications"},{"line_number":123,"context_line":"    enabled: \"{{ enable_ceilometer | bool }}\""},{"line_number":124,"context_line":"  - name: barbican_notifications"},{"line_number":125,"context_line":"    enabled: \"{{ enable_barbican | bool }}\""},{"line_number":126,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":7,"id":"7faddb67_2968f0f2","line":123,"range":{"start_line":123,"start_character":13,"end_line":123,"end_character":45},"updated":"2019-08-05 13:24:52.000000000","message":"Thinking about this again, I think we might need an \u0027enable notifications\u0027 flag at least for keystone since its a bit different from the rest. That was probably the intention of enable_cadf_notifications, even if it didn\u0027t get it quite right.\n\nHow about adding \u0027enable_keystone_notifications\u0027 in here, possibly also \u0027keystone_notifications_topic\u0027.\n\nWe could even set it to enable_cadf_notifications by default, and provide a clean transition with a deprecation.\n\nSorry to change again on this, it\u0027s a bit fiddly.\n\nWDYT?","commit_id":"a13cab6896062b90c191d51d3c03801d55b4fbb9"},{"author":{"_account_id":28356,"name":"Rafael Weingartner","email":"rafael@apache.org","username":"rafaelweingartner"},"change_message_id":"f1314d6460faccc0bc1c88c63efeb523e2e4207e","unresolved":false,"context_lines":[{"line_number":120,"context_line":"####################"},{"line_number":121,"context_line":"keystone_notification_topics:"},{"line_number":122,"context_line":"  - name: notifications"},{"line_number":123,"context_line":"    enabled: \"{{ enable_ceilometer | bool }}\""},{"line_number":124,"context_line":"  - name: barbican_notifications"},{"line_number":125,"context_line":"    enabled: \"{{ enable_barbican | bool }}\""},{"line_number":126,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":7,"id":"7faddb67_4cc3fa38","line":123,"range":{"start_line":123,"start_character":13,"end_line":123,"end_character":45},"in_reply_to":"7faddb67_2968f0f2","updated":"2019-08-05 14:09:39.000000000","message":"ok. I see what you mean. It is all due to the third-party integrations that Keystone might have.\n\nCan you see my last changeset? I am not using \u0027enable_cadf_notifications\u0027 there though.","commit_id":"a13cab6896062b90c191d51d3c03801d55b4fbb9"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"6e3360dabb4efcb93fdcd41e23c450f3dd3ab8e5","unresolved":false,"context_lines":[{"line_number":118,"context_line":"####################"},{"line_number":119,"context_line":"# Notifications"},{"line_number":120,"context_line":"####################"},{"line_number":121,"context_line":"keystone_default_notifications_topic_enabled: \"{{ enable_ceilometer }}\""},{"line_number":122,"context_line":"keystne_default_notifications_topic_name: \"notifications\""},{"line_number":123,"context_line":""},{"line_number":124,"context_line":"keystone_notification_topics:"}],"source_content_type":"text/x-yaml","patch_set":10,"id":"7faddb67_bde41ae1","line":121,"range":{"start_line":121,"start_character":50,"end_line":121,"end_character":67},"updated":"2019-08-05 16:40:36.000000000","message":"How about:\n\n{{ enable_cadf_notifications | bool or enable_ceilometer | bool }}\n\nGiven that this did actually work (see other comment), I\u0027m concerned about backwards compat.\n\nDoes ceilometer actually consume keystone notifications though?","commit_id":"3e72ea33f3c2a30d10d4e4bd5819e7d5d5287290"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"0a54516279d080bf5c13fda76c6be78095e344d9","unresolved":false,"context_lines":[{"line_number":118,"context_line":"####################"},{"line_number":119,"context_line":"# Notifications"},{"line_number":120,"context_line":"####################"},{"line_number":121,"context_line":"keystone_default_notifications_topic_enabled: \"{{ enable_ceilometer }}\""},{"line_number":122,"context_line":"keystne_default_notifications_topic_name: \"notifications\""},{"line_number":123,"context_line":""},{"line_number":124,"context_line":"keystone_notification_topics:"}],"source_content_type":"text/x-yaml","patch_set":10,"id":"7faddb67_f818521e","line":121,"range":{"start_line":121,"start_character":50,"end_line":121,"end_character":67},"in_reply_to":"7faddb67_094de639","updated":"2019-08-06 11:23:40.000000000","message":"Much of kolla-ansible is undocumented (and possibly even misleading). That doesn\u0027t mean we can throw backwards compatibility out of the window.\n\nAs I mentioned elsewhere, the default value for the topics option is \u0027notifications\u0027, which means it doesn\u0027t need to be set to make it work. That is why I changed my mind about this.\n\nTo be fair, it\u0027s not even that misleading. If it is \u0027no\u0027, CADF notifications are disabled. If it is \u0027yes\u0027, CADF notifications are enabled. The only minor issue is it sets a config option to a value which is already the default.","commit_id":"3e72ea33f3c2a30d10d4e4bd5819e7d5d5287290"},{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"f36f2c9c2208d5f205467878a5f8e5d53cafce1f","unresolved":false,"context_lines":[{"line_number":118,"context_line":"####################"},{"line_number":119,"context_line":"# Notifications"},{"line_number":120,"context_line":"####################"},{"line_number":121,"context_line":"keystone_default_notifications_topic_enabled: \"{{ enable_ceilometer }}\""},{"line_number":122,"context_line":"keystne_default_notifications_topic_name: \"notifications\""},{"line_number":123,"context_line":""},{"line_number":124,"context_line":"keystone_notification_topics:"}],"source_content_type":"text/x-yaml","patch_set":10,"id":"7faddb67_094de639","line":121,"range":{"start_line":121,"start_character":50,"end_line":121,"end_character":67},"in_reply_to":"7faddb67_42dc1ee3","updated":"2019-08-06 06:48:22.000000000","message":"Mark, the point is it is misleading (CADF already default), half-broken (topics not set anyway) and *undocumented*. I don\u0027t think it deserves more than a mention in the upgrade notes.","commit_id":"3e72ea33f3c2a30d10d4e4bd5819e7d5d5287290"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"deefe3afc5e792bcc13b422fdf3116ce97bb3c55","unresolved":false,"context_lines":[{"line_number":118,"context_line":"####################"},{"line_number":119,"context_line":"# Notifications"},{"line_number":120,"context_line":"####################"},{"line_number":121,"context_line":"keystone_default_notifications_topic_enabled: \"{{ enable_ceilometer }}\""},{"line_number":122,"context_line":"keystne_default_notifications_topic_name: \"notifications\""},{"line_number":123,"context_line":""},{"line_number":124,"context_line":"keystone_notification_topics:"}],"source_content_type":"text/x-yaml","patch_set":10,"id":"7faddb67_ce7a6c86","line":121,"range":{"start_line":121,"start_character":50,"end_line":121,"end_character":67},"in_reply_to":"7faddb67_530aa725","updated":"2019-08-06 12:50:35.000000000","message":"Sorry if I wasn\u0027t clear enough.","commit_id":"3e72ea33f3c2a30d10d4e4bd5819e7d5d5287290"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"09d5657924cbc61b320e0eea49b21fc414540785","unresolved":false,"context_lines":[{"line_number":118,"context_line":"####################"},{"line_number":119,"context_line":"# Notifications"},{"line_number":120,"context_line":"####################"},{"line_number":121,"context_line":"keystone_default_notifications_topic_enabled: \"{{ enable_ceilometer }}\""},{"line_number":122,"context_line":"keystne_default_notifications_topic_name: \"notifications\""},{"line_number":123,"context_line":""},{"line_number":124,"context_line":"keystone_notification_topics:"}],"source_content_type":"text/x-yaml","patch_set":10,"id":"7faddb67_73e483e0","line":121,"range":{"start_line":121,"start_character":50,"end_line":121,"end_character":67},"in_reply_to":"7faddb67_580ac625","updated":"2019-08-06 12:22:35.000000000","message":"For most services, notifications are only enabled if ceilometer is enabled. Enabling notifications without something draining the rabbitmq queues will cause problems.","commit_id":"3e72ea33f3c2a30d10d4e4bd5819e7d5d5287290"},{"author":{"_account_id":28356,"name":"Rafael Weingartner","email":"rafael@apache.org","username":"rafaelweingartner"},"change_message_id":"a2d7feb28da5f2aa9080e69b5b1c5518d4e70ddf","unresolved":false,"context_lines":[{"line_number":118,"context_line":"####################"},{"line_number":119,"context_line":"# Notifications"},{"line_number":120,"context_line":"####################"},{"line_number":121,"context_line":"keystone_default_notifications_topic_enabled: \"{{ enable_ceilometer }}\""},{"line_number":122,"context_line":"keystne_default_notifications_topic_name: \"notifications\""},{"line_number":123,"context_line":""},{"line_number":124,"context_line":"keystone_notification_topics:"}],"source_content_type":"text/x-yaml","patch_set":10,"id":"7faddb67_935c9f7d","line":121,"range":{"start_line":121,"start_character":50,"end_line":121,"end_character":67},"in_reply_to":"7faddb67_73e483e0","updated":"2019-08-06 12:32:29.000000000","message":"True that. That is why there is the check there. However, as you pointed out, we might have third party integrations. That is why I externalized this to `keystone_default_notifications_topic_enabled`. Also, because of that, I addressed the issue with versioned notifications in Nova here as well.","commit_id":"3e72ea33f3c2a30d10d4e4bd5819e7d5d5287290"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"3b229e159b58c406a135b193ed1bc72bdc5910fa","unresolved":false,"context_lines":[{"line_number":118,"context_line":"####################"},{"line_number":119,"context_line":"# Notifications"},{"line_number":120,"context_line":"####################"},{"line_number":121,"context_line":"keystone_default_notifications_topic_enabled: \"{{ enable_ceilometer }}\""},{"line_number":122,"context_line":"keystne_default_notifications_topic_name: \"notifications\""},{"line_number":123,"context_line":""},{"line_number":124,"context_line":"keystone_notification_topics:"}],"source_content_type":"text/x-yaml","patch_set":10,"id":"7faddb67_b3643b23","line":121,"range":{"start_line":121,"start_character":50,"end_line":121,"end_character":67},"in_reply_to":"7faddb67_935c9f7d","updated":"2019-08-06 12:41:07.000000000","message":"I agree keystone_default_notifications_topic_enabled is the right path forward, I\u0027m just saying we can\u0027t break backwards compatibility without a deprecation period. It\u0027s really not a big deal to keep enable_cadf_notifications around for a release or two, and use it to set the default for keystone_default_notifications_topic_enabled.","commit_id":"3e72ea33f3c2a30d10d4e4bd5819e7d5d5287290"},{"author":{"_account_id":28356,"name":"Rafael Weingartner","email":"rafael@apache.org","username":"rafaelweingartner"},"change_message_id":"bb21a5c3062b9a516f559c0c4cd08fe82349c82e","unresolved":false,"context_lines":[{"line_number":118,"context_line":"####################"},{"line_number":119,"context_line":"# Notifications"},{"line_number":120,"context_line":"####################"},{"line_number":121,"context_line":"keystone_default_notifications_topic_enabled: \"{{ enable_ceilometer }}\""},{"line_number":122,"context_line":"keystne_default_notifications_topic_name: \"notifications\""},{"line_number":123,"context_line":""},{"line_number":124,"context_line":"keystone_notification_topics:"}],"source_content_type":"text/x-yaml","patch_set":10,"id":"7faddb67_530aa725","line":121,"range":{"start_line":121,"start_character":50,"end_line":121,"end_character":67},"in_reply_to":"7faddb67_b3643b23","updated":"2019-08-06 12:47:03.000000000","message":"now, I see what you want here. I will reintroduce the parameter then.","commit_id":"3e72ea33f3c2a30d10d4e4bd5819e7d5d5287290"},{"author":{"_account_id":28356,"name":"Rafael Weingartner","email":"rafael@apache.org","username":"rafaelweingartner"},"change_message_id":"d224d4e7880eacf64a928d95a83b1907b21fd305","unresolved":false,"context_lines":[{"line_number":118,"context_line":"####################"},{"line_number":119,"context_line":"# Notifications"},{"line_number":120,"context_line":"####################"},{"line_number":121,"context_line":"keystone_default_notifications_topic_enabled: \"{{ enable_ceilometer }}\""},{"line_number":122,"context_line":"keystne_default_notifications_topic_name: \"notifications\""},{"line_number":123,"context_line":""},{"line_number":124,"context_line":"keystone_notification_topics:"}],"source_content_type":"text/x-yaml","patch_set":10,"id":"7faddb67_f815c09c","line":121,"range":{"start_line":121,"start_character":50,"end_line":121,"end_character":67},"in_reply_to":"7faddb67_bde41ae1","updated":"2019-08-05 17:30:46.000000000","message":"My problem with \"enable_cadf_notifications\" is that it is misleading. That is what I discussed with Rados during the first version of this proposal, which was way smaller.  We (my team here) just discovered this, because when debugging an issue between barbican and Ceilometer, we noticed that Keystone was not generating notifications. We were using `enable_cadf_notifications\u003dno` because we did not want the CADF format, but we wanted notifications. We interpreted the name of that property as an indicator of the format only, and not something to enable/disable notifications. Moreover, we checked that the default is already CADF in Keystone. Therefore, what we needed is something to enable/disable notifications in Keystone, which is what is being proposed here.\n\nWith the introduction of `keystone_default_notifications_topic_enabled` (as you suggested), we now get a method to enable/disable notifications in Keystone as well (without needing to rely on Ceilometer).\n\n\u003e Does ceilometer actually consume keystone notifications though?\n\nYes, it does.","commit_id":"3e72ea33f3c2a30d10d4e4bd5819e7d5d5287290"},{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"ee593ed8ed3cd04fb7123dad4d3048c2eafacf7f","unresolved":false,"context_lines":[{"line_number":118,"context_line":"####################"},{"line_number":119,"context_line":"# Notifications"},{"line_number":120,"context_line":"####################"},{"line_number":121,"context_line":"keystone_default_notifications_topic_enabled: \"{{ enable_ceilometer }}\""},{"line_number":122,"context_line":"keystne_default_notifications_topic_name: \"notifications\""},{"line_number":123,"context_line":""},{"line_number":124,"context_line":"keystone_notification_topics:"}],"source_content_type":"text/x-yaml","patch_set":10,"id":"7faddb67_1929ade4","line":121,"range":{"start_line":121,"start_character":50,"end_line":121,"end_character":67},"in_reply_to":"7faddb67_ce7a6c86","updated":"2019-08-06 15:53:24.000000000","message":"Ah, clear now. All those funny defaults made me confused. Agree with Mark here.","commit_id":"3e72ea33f3c2a30d10d4e4bd5819e7d5d5287290"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"0114b5bdf5b4a4ec8ceb6040e1081fbae6029385","unresolved":false,"context_lines":[{"line_number":118,"context_line":"####################"},{"line_number":119,"context_line":"# Notifications"},{"line_number":120,"context_line":"####################"},{"line_number":121,"context_line":"keystone_default_notifications_topic_enabled: \"{{ enable_ceilometer }}\""},{"line_number":122,"context_line":"keystne_default_notifications_topic_name: \"notifications\""},{"line_number":123,"context_line":""},{"line_number":124,"context_line":"keystone_notification_topics:"}],"source_content_type":"text/x-yaml","patch_set":10,"id":"7faddb67_42dc1ee3","line":121,"range":{"start_line":121,"start_character":50,"end_line":121,"end_character":67},"in_reply_to":"7faddb67_f815c09c","updated":"2019-08-05 18:43:00.000000000","message":"I agree it is misleading. We can deprecate enable_cadf_notifications, but I was only happy to remove it when I thought it was useless. Now that I know it is not (because it does actually enable keystone notifications), we need a deprecation period while we transition to a new variable.","commit_id":"3e72ea33f3c2a30d10d4e4bd5819e7d5d5287290"},{"author":{"_account_id":28356,"name":"Rafael Weingartner","email":"rafael@apache.org","username":"rafaelweingartner"},"change_message_id":"4ae67af6343c85696e66de6d82bb7e02be36de6c","unresolved":false,"context_lines":[{"line_number":118,"context_line":"####################"},{"line_number":119,"context_line":"# Notifications"},{"line_number":120,"context_line":"####################"},{"line_number":121,"context_line":"keystone_default_notifications_topic_enabled: \"{{ enable_ceilometer }}\""},{"line_number":122,"context_line":"keystne_default_notifications_topic_name: \"notifications\""},{"line_number":123,"context_line":""},{"line_number":124,"context_line":"keystone_notification_topics:"}],"source_content_type":"text/x-yaml","patch_set":10,"id":"7faddb67_580ac625","line":121,"range":{"start_line":121,"start_character":50,"end_line":121,"end_character":67},"in_reply_to":"7faddb67_f818521e","updated":"2019-08-06 11:52:13.000000000","message":"Here is the problem. The issue (our issue here) is not with the default for the topic name (\u0027notifications\u0027). The issue is that the default for the driver is \u0027\u0027 (empty). Therefore, it does not send notifications, when CADF is set to \u0027no\u0027. However, (at least) from our perspective, the opposite of CADF (CADF\u003d\u0027yes\u0027) is not \u0027noop\u0027 for the driver of oslo messaging, it (when CADF\u003d\u0027no\u0027) is \u0027basic\u0027 format for notifications.\n\nIn a minimum viable deployment with Kolla-ansible we would expect notifications to be activated for the most common systems such as Nova, Keystone, Glance, and so on. That is why I went through the systems that declared the oslo messaging section (I assumed they were the most important ones because people somehow already declared the oslo messaging sections there) and applied the approach that is used in Nova. The format, for instance, can be then configured using the overriding mechanism.","commit_id":"3e72ea33f3c2a30d10d4e4bd5819e7d5d5287290"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"6e3360dabb4efcb93fdcd41e23c450f3dd3ab8e5","unresolved":false,"context_lines":[{"line_number":119,"context_line":"# Notifications"},{"line_number":120,"context_line":"####################"},{"line_number":121,"context_line":"keystone_default_notifications_topic_enabled: \"{{ enable_ceilometer }}\""},{"line_number":122,"context_line":"keystne_default_notifications_topic_name: \"notifications\""},{"line_number":123,"context_line":""},{"line_number":124,"context_line":"keystone_notification_topics:"},{"line_number":125,"context_line":"  - name: \"{{ keystne_default_notifications_topic_name }}\""}],"source_content_type":"text/x-yaml","patch_set":10,"id":"7faddb67_7dd22202","line":122,"range":{"start_line":122,"start_character":0,"end_line":122,"end_character":7},"updated":"2019-08-05 16:40:36.000000000","message":"keystone","commit_id":"3e72ea33f3c2a30d10d4e4bd5819e7d5d5287290"},{"author":{"_account_id":28356,"name":"Rafael Weingartner","email":"rafael@apache.org","username":"rafaelweingartner"},"change_message_id":"d224d4e7880eacf64a928d95a83b1907b21fd305","unresolved":false,"context_lines":[{"line_number":119,"context_line":"# Notifications"},{"line_number":120,"context_line":"####################"},{"line_number":121,"context_line":"keystone_default_notifications_topic_enabled: \"{{ enable_ceilometer }}\""},{"line_number":122,"context_line":"keystne_default_notifications_topic_name: \"notifications\""},{"line_number":123,"context_line":""},{"line_number":124,"context_line":"keystone_notification_topics:"},{"line_number":125,"context_line":"  - name: \"{{ keystne_default_notifications_topic_name }}\""}],"source_content_type":"text/x-yaml","patch_set":10,"id":"7faddb67_b80bc87a","line":122,"range":{"start_line":122,"start_character":0,"end_line":122,"end_character":7},"in_reply_to":"7faddb67_7dd22202","updated":"2019-08-05 17:30:46.000000000","message":"fixed","commit_id":"3e72ea33f3c2a30d10d4e4bd5819e7d5d5287290"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"6e3360dabb4efcb93fdcd41e23c450f3dd3ab8e5","unresolved":false,"context_lines":[{"line_number":122,"context_line":"keystne_default_notifications_topic_name: \"notifications\""},{"line_number":123,"context_line":""},{"line_number":124,"context_line":"keystone_notification_topics:"},{"line_number":125,"context_line":"  - name: \"{{ keystne_default_notifications_topic_name }}\""},{"line_number":126,"context_line":"    enabled: \"{{ keystone_default_notifications_topic_enabled | bool }}\""},{"line_number":127,"context_line":"  - name: barbican_notifications"},{"line_number":128,"context_line":"    enabled: \"{{ enable_barbican | bool }}\""}],"source_content_type":"text/x-yaml","patch_set":10,"id":"7faddb67_ddb236e5","line":125,"range":{"start_line":125,"start_character":14,"end_line":125,"end_character":21},"updated":"2019-08-05 16:40:36.000000000","message":"keystone","commit_id":"3e72ea33f3c2a30d10d4e4bd5819e7d5d5287290"},{"author":{"_account_id":28356,"name":"Rafael Weingartner","email":"rafael@apache.org","username":"rafaelweingartner"},"change_message_id":"d224d4e7880eacf64a928d95a83b1907b21fd305","unresolved":false,"context_lines":[{"line_number":122,"context_line":"keystne_default_notifications_topic_name: \"notifications\""},{"line_number":123,"context_line":""},{"line_number":124,"context_line":"keystone_notification_topics:"},{"line_number":125,"context_line":"  - name: \"{{ keystne_default_notifications_topic_name }}\""},{"line_number":126,"context_line":"    enabled: \"{{ keystone_default_notifications_topic_enabled | bool }}\""},{"line_number":127,"context_line":"  - name: barbican_notifications"},{"line_number":128,"context_line":"    enabled: \"{{ enable_barbican | bool }}\""}],"source_content_type":"text/x-yaml","patch_set":10,"id":"7faddb67_d80ec48a","line":125,"range":{"start_line":125,"start_character":14,"end_line":125,"end_character":21},"in_reply_to":"7faddb67_ddb236e5","updated":"2019-08-05 17:30:46.000000000","message":"fixed","commit_id":"3e72ea33f3c2a30d10d4e4bd5819e7d5d5287290"}],"ansible/roles/keystone/templates/keystone.conf.j2":[{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"cbe99c9c000dffb2004f213a31808dea294145fc","unresolved":false,"context_lines":[{"line_number":1,"context_line":"[DEFAULT]"},{"line_number":2,"context_line":"debug \u003d {{ keystone_logging_debug }}"},{"line_number":3,"context_line":"{% if enable_cadf_notifications | bool %}"},{"line_number":4,"context_line":"notification_format \u003d cadf"},{"line_number":5,"context_line":"{% endif %}"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"transport_url \u003d {{ rpc_transport_url }}"},{"line_number":8,"context_line":""}],"source_content_type":"text/x-jinja2","patch_set":2,"id":"7faddb67_b12470b0","side":"PARENT","line":5,"range":{"start_line":3,"start_character":0,"end_line":5,"end_character":11},"updated":"2019-07-16 08:22:09.000000000","message":"Agree this is useless, given the keystone default.","commit_id":"83dbed6b78caa13aa01330e33a760fcaff0ba174"},{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"0f2758135190d1967e5fafc48ce68525d6eeb305","unresolved":false,"context_lines":[{"line_number":1,"context_line":"[DEFAULT]"},{"line_number":2,"context_line":"debug \u003d {{ keystone_logging_debug }}"},{"line_number":3,"context_line":"{% if enable_cadf_notifications | bool %}"},{"line_number":4,"context_line":"notification_format \u003d cadf"},{"line_number":5,"context_line":"{% endif %}"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"transport_url \u003d {{ rpc_transport_url }}"},{"line_number":8,"context_line":""}],"source_content_type":"text/x-jinja2","patch_set":2,"id":"7faddb67_71f7d8d4","side":"PARENT","line":5,"range":{"start_line":3,"start_character":0,"end_line":5,"end_character":11},"in_reply_to":"7faddb67_b12470b0","updated":"2019-07-16 08:31:59.000000000","message":"+1","commit_id":"83dbed6b78caa13aa01330e33a760fcaff0ba174"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"cbe99c9c000dffb2004f213a31808dea294145fc","unresolved":false,"context_lines":[{"line_number":1,"context_line":"[DEFAULT]"},{"line_number":2,"context_line":"debug \u003d {{ keystone_logging_debug }}"},{"line_number":3,"context_line":"{% if enable_cadf_notifications | bool %}"},{"line_number":4,"context_line":"notification_format \u003d cadf"},{"line_number":5,"context_line":"{% else %}"},{"line_number":6,"context_line":"notification_format \u003d basic"},{"line_number":7,"context_line":"{% endif %}"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"transport_url \u003d {{ rpc_transport_url }}"},{"line_number":10,"context_line":""}],"source_content_type":"text/x-jinja2","patch_set":2,"id":"7faddb67_f1a188f9","line":7,"range":{"start_line":3,"start_character":0,"end_line":7,"end_character":11},"updated":"2019-07-16 08:22:09.000000000","message":"This would be better represented by a \u0027keystone_notification_format\u0027 variable, but we normally don\u0027t provide variables that map to a single config option.","commit_id":"26675bd12eb2678eb238fe879cc07ddf451c9f98"},{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"40d691a1fd7f7d47e7b52c1c0e58314eb85010d9","unresolved":false,"context_lines":[{"line_number":1,"context_line":"[DEFAULT]"},{"line_number":2,"context_line":"debug \u003d {{ keystone_logging_debug }}"},{"line_number":3,"context_line":"{% if enable_cadf_notifications | bool %}"},{"line_number":4,"context_line":"notification_format \u003d cadf"},{"line_number":5,"context_line":"{% else %}"},{"line_number":6,"context_line":"notification_format \u003d basic"},{"line_number":7,"context_line":"{% endif %}"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"transport_url \u003d {{ rpc_transport_url }}"},{"line_number":10,"context_line":""}],"source_content_type":"text/x-jinja2","patch_set":2,"id":"7faddb67_91da9448","line":7,"range":{"start_line":3,"start_character":0,"end_line":7,"end_character":11},"in_reply_to":"7faddb67_314f2035","updated":"2019-07-16 08:32:38.000000000","message":"I mean - remove and not add a new one. ;-)","commit_id":"26675bd12eb2678eb238fe879cc07ddf451c9f98"},{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"0f2758135190d1967e5fafc48ce68525d6eeb305","unresolved":false,"context_lines":[{"line_number":1,"context_line":"[DEFAULT]"},{"line_number":2,"context_line":"debug \u003d {{ keystone_logging_debug }}"},{"line_number":3,"context_line":"{% if enable_cadf_notifications | bool %}"},{"line_number":4,"context_line":"notification_format \u003d cadf"},{"line_number":5,"context_line":"{% else %}"},{"line_number":6,"context_line":"notification_format \u003d basic"},{"line_number":7,"context_line":"{% endif %}"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"transport_url \u003d {{ rpc_transport_url }}"},{"line_number":10,"context_line":""}],"source_content_type":"text/x-jinja2","patch_set":2,"id":"7faddb67_314f2035","line":7,"range":{"start_line":3,"start_character":0,"end_line":7,"end_character":11},"in_reply_to":"7faddb67_f1a188f9","updated":"2019-07-16 08:31:59.000000000","message":"Then we leave it alone. ;-)","commit_id":"26675bd12eb2678eb238fe879cc07ddf451c9f98"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"cbe99c9c000dffb2004f213a31808dea294145fc","unresolved":false,"context_lines":[{"line_number":55,"context_line":""},{"line_number":56,"context_line":"[oslo_messaging_notifications]"},{"line_number":57,"context_line":"transport_url \u003d {{ notify_transport_url }}"},{"line_number":58,"context_line":"driver \u003d messagingv2"},{"line_number":59,"context_line":""},{"line_number":60,"context_line":"{% if enable_osprofiler | bool %}"},{"line_number":61,"context_line":"[profiler]"}],"source_content_type":"text/x-jinja2","patch_set":2,"id":"7faddb67_f153c815","line":58,"range":{"start_line":58,"start_character":0,"end_line":58,"end_character":20},"updated":"2019-07-16 08:22:09.000000000","message":"Do we also need to configure notification topics? For example, nova has this:\n\nnova_notification_topics:\n  - name: notifications\n    enabled: \"{{ enable_ceilometer | bool or enable_searchlight | bool or enable_neutron_infoblox_ipam_agent | bool }}\"\n  - name: notifications_designate\n    enabled: \"{{ enable_designate | bool }}\"\n  - name: vitrage_notifications\n    enabled: \"{{ enable_vitrage | bool }}\"\n\nnova_enabled_notification_topics: \"{{ nova_notification_topics | selectattr(\u0027enabled\u0027, \u0027equalto\u0027, true) | list }}\"\n\nIt also only sets the driver if one or more topics are configured. This pattern seems to be fairly consistent throughout kolla-ansible.","commit_id":"26675bd12eb2678eb238fe879cc07ddf451c9f98"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"eae54a830998683e46c7becaad8c301bd6ef5286","unresolved":false,"context_lines":[{"line_number":55,"context_line":""},{"line_number":56,"context_line":"[oslo_messaging_notifications]"},{"line_number":57,"context_line":"transport_url \u003d {{ notify_transport_url }}"},{"line_number":58,"context_line":"driver \u003d messagingv2"},{"line_number":59,"context_line":""},{"line_number":60,"context_line":"{% if enable_osprofiler | bool %}"},{"line_number":61,"context_line":"[profiler]"}],"source_content_type":"text/x-jinja2","patch_set":2,"id":"7faddb67_3ddcd1e2","line":58,"range":{"start_line":58,"start_character":0,"end_line":58,"end_character":20},"in_reply_to":"7faddb67_ddefbd1b","updated":"2019-07-16 13:07:51.000000000","message":"That would make sense to me, but I haven\u0027t spent a huge amount of time with keystone notifications. Are they normally published to ceilometer?\n\nIf we remove enable_cadf_notifications then we would be removing the ability to control whether keystone notifications are enabled.","commit_id":"26675bd12eb2678eb238fe879cc07ddf451c9f98"},{"author":{"_account_id":28356,"name":"Rafael Weingartner","email":"rafael@apache.org","username":"rafaelweingartner"},"change_message_id":"a09beb407caf3ccd3e47735637b8592c0952464a","unresolved":false,"context_lines":[{"line_number":55,"context_line":""},{"line_number":56,"context_line":"[oslo_messaging_notifications]"},{"line_number":57,"context_line":"transport_url \u003d {{ notify_transport_url }}"},{"line_number":58,"context_line":"driver \u003d messagingv2"},{"line_number":59,"context_line":""},{"line_number":60,"context_line":"{% if enable_osprofiler | bool %}"},{"line_number":61,"context_line":"[profiler]"}],"source_content_type":"text/x-jinja2","patch_set":2,"id":"7faddb67_ddefbd1b","line":58,"range":{"start_line":58,"start_character":0,"end_line":58,"end_character":20},"in_reply_to":"7faddb67_f153c815","updated":"2019-07-16 12:40:15.000000000","message":"Would you guys like to see something like this in Kolla-ansible with respect to Keystone configurations?","commit_id":"26675bd12eb2678eb238fe879cc07ddf451c9f98"},{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"0f2758135190d1967e5fafc48ce68525d6eeb305","unresolved":false,"context_lines":[{"line_number":55,"context_line":""},{"line_number":56,"context_line":"[oslo_messaging_notifications]"},{"line_number":57,"context_line":"transport_url \u003d {{ notify_transport_url }}"},{"line_number":58,"context_line":"driver \u003d messagingv2"},{"line_number":59,"context_line":""},{"line_number":60,"context_line":"{% if enable_osprofiler | bool %}"},{"line_number":61,"context_line":"[profiler]"}],"source_content_type":"text/x-jinja2","patch_set":2,"id":"7faddb67_f10bc8d2","line":58,"range":{"start_line":58,"start_character":0,"end_line":58,"end_character":20},"in_reply_to":"7faddb67_f153c815","updated":"2019-07-16 08:31:59.000000000","message":"Yeah, I had that thought too but forgot. The thing with keystone is probably that it\u0027s external systems that would like to listen for its notifications anyway.\nThe default topic is \u0027notifications\u0027 which probably is wrong in many cases unless we like all notifications in one bag.","commit_id":"26675bd12eb2678eb238fe879cc07ddf451c9f98"},{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"7b252cd6f34fb8c6c3f7c22f084c0484dece3220","unresolved":false,"context_lines":[{"line_number":1,"context_line":"[DEFAULT]"},{"line_number":2,"context_line":"debug \u003d {{ keystone_logging_debug }}"},{"line_number":3,"context_line":"{% if enable_cadf_notifications | bool %}"},{"line_number":4,"context_line":"notification_format \u003d cadf"},{"line_number":5,"context_line":"{% endif %}"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"transport_url \u003d {{ rpc_transport_url }}"},{"line_number":8,"context_line":""}],"source_content_type":"text/x-jinja2","patch_set":4,"id":"7faddb67_e68cc5d8","line":5,"range":{"start_line":3,"start_character":0,"end_line":5,"end_character":11},"updated":"2019-07-26 14:38:04.000000000","message":"has to be removed","commit_id":"dd924b5cdacff24cd5e28480a57d41ff1992205e"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"f66a70a6c455c0d1ebf10bb1f92865d859f85260","unresolved":false,"context_lines":[{"line_number":50,"context_line":""},{"line_number":51,"context_line":"[oslo_messaging_notifications]"},{"line_number":52,"context_line":"transport_url \u003d {{ notify_transport_url }}"},{"line_number":53,"context_line":"{% if keystone_enabled_notification_topics %}"},{"line_number":54,"context_line":"driver \u003d messagingv2"},{"line_number":55,"context_line":"topics \u003d {{ keystone_enabled_notification_topics | map(attribute\u003d\u0027name\u0027) | join(\u0027,\u0027) }}"},{"line_number":56,"context_line":"{% else %}"}],"source_content_type":"text/x-jinja2","patch_set":6,"id":"7faddb67_efde630f","line":53,"updated":"2019-08-04 17:40:45.000000000","message":"Slight backwards compat issue: if a user had set enable_cadf_notifications to true and manually overridden the topics, their notifications would stop if neither ceilometer nor barbican are enabled. It\u0027s a bit of a corner case.","commit_id":"774889bc06596b8af04f5b96d28836b8cee7e03f"},{"author":{"_account_id":28356,"name":"Rafael Weingartner","email":"rafael@apache.org","username":"rafaelweingartner"},"change_message_id":"2bb235f9459ffc3961367d21e5040d33431e4d7e","unresolved":false,"context_lines":[{"line_number":50,"context_line":""},{"line_number":51,"context_line":"[oslo_messaging_notifications]"},{"line_number":52,"context_line":"transport_url \u003d {{ notify_transport_url }}"},{"line_number":53,"context_line":"{% if keystone_enabled_notification_topics %}"},{"line_number":54,"context_line":"driver \u003d messagingv2"},{"line_number":55,"context_line":"topics \u003d {{ keystone_enabled_notification_topics | map(attribute\u003d\u0027name\u0027) | join(\u0027,\u0027) }}"},{"line_number":56,"context_line":"{% else %}"}],"source_content_type":"text/x-jinja2","patch_set":6,"id":"7faddb67_36d7ef4d","line":53,"in_reply_to":"7faddb67_607fe014","updated":"2019-08-05 11:50:30.000000000","message":"I would say so. I will create a release notes with an upgrade note","commit_id":"774889bc06596b8af04f5b96d28836b8cee7e03f"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"66a88197b9648e793c619b776172ddc5489a80bd","unresolved":false,"context_lines":[{"line_number":50,"context_line":""},{"line_number":51,"context_line":"[oslo_messaging_notifications]"},{"line_number":52,"context_line":"transport_url \u003d {{ notify_transport_url }}"},{"line_number":53,"context_line":"{% if keystone_enabled_notification_topics %}"},{"line_number":54,"context_line":"driver \u003d messagingv2"},{"line_number":55,"context_line":"topics \u003d {{ keystone_enabled_notification_topics | map(attribute\u003d\u0027name\u0027) | join(\u0027,\u0027) }}"},{"line_number":56,"context_line":"{% else %}"}],"source_content_type":"text/x-jinja2","patch_set":6,"id":"7faddb67_d6da1b49","line":53,"in_reply_to":"7faddb67_607fe014","updated":"2019-08-05 11:50:12.000000000","message":"Potentially.","commit_id":"774889bc06596b8af04f5b96d28836b8cee7e03f"},{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"917e3197f87f7c5d5e8fe446a69d1c63ea86b6b3","unresolved":false,"context_lines":[{"line_number":50,"context_line":""},{"line_number":51,"context_line":"[oslo_messaging_notifications]"},{"line_number":52,"context_line":"transport_url \u003d {{ notify_transport_url }}"},{"line_number":53,"context_line":"{% if keystone_enabled_notification_topics %}"},{"line_number":54,"context_line":"driver \u003d messagingv2"},{"line_number":55,"context_line":"topics \u003d {{ keystone_enabled_notification_topics | map(attribute\u003d\u0027name\u0027) | join(\u0027,\u0027) }}"},{"line_number":56,"context_line":"{% else %}"}],"source_content_type":"text/x-jinja2","patch_set":6,"id":"7faddb67_607fe014","line":53,"in_reply_to":"7faddb67_efde630f","updated":"2019-08-05 06:23:55.000000000","message":"Solvable by upgrade note I guess?","commit_id":"774889bc06596b8af04f5b96d28836b8cee7e03f"}],"releasenotes/notes/standard-oslo-messaging-sections-4769da25bc58aa02.yaml":[{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"277d01f4ac767dae2bbc63e6ad49778e524f8701","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"prelude:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    After all of the discussions, we had on"}],"source_content_type":"text/x-yaml","patch_set":7,"id":"7faddb67_b6243f0e","line":1,"updated":"2019-08-05 13:24:52.000000000","message":"Thanks for a very thorough release note! In practice though we tend to use only these sections in this project: features, upgrade, deprecations.","commit_id":"a13cab6896062b90c191d51d3c03801d55b4fbb9"},{"author":{"_account_id":28356,"name":"Rafael Weingartner","email":"rafael@apache.org","username":"rafaelweingartner"},"change_message_id":"f1314d6460faccc0bc1c88c63efeb523e2e4207e","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"prelude:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    After all of the discussions, we had on"}],"source_content_type":"text/x-yaml","patch_set":7,"id":"7faddb67_8cfb3277","line":1,"in_reply_to":"7faddb67_b6243f0e","updated":"2019-08-05 14:09:39.000000000","message":"ok. I will remove then.","commit_id":"a13cab6896062b90c191d51d3c03801d55b4fbb9"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"277d01f4ac767dae2bbc63e6ad49778e524f8701","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"prelude:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    After all of the discussions, we had on"},{"line_number":5,"context_line":"    \"https://review.opendev.org/#/c/670626/2\", the same method that is"}],"source_content_type":"text/x-yaml","patch_set":7,"id":"7faddb67_167bd3f4","line":2,"range":{"start_line":2,"start_character":0,"end_line":2,"end_character":7},"updated":"2019-08-05 13:24:52.000000000","message":"There is only one prelude section per release, so not necessary here.","commit_id":"a13cab6896062b90c191d51d3c03801d55b4fbb9"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"277d01f4ac767dae2bbc63e6ad49778e524f8701","unresolved":false,"context_lines":[{"line_number":13,"context_line":"    \"https://review.opendev.org/#/c/670626\""},{"line_number":14,"context_line":"features:"},{"line_number":15,"context_line":"  - |"},{"line_number":16,"context_line":"    Standard method to execute the configuration of \"oslo_messaging\" sections"},{"line_number":17,"context_line":"issues:"},{"line_number":18,"context_line":"  - |"},{"line_number":19,"context_line":"    * Kolla-ansible does not configure nova notifications as it should. If"}],"source_content_type":"text/x-yaml","patch_set":7,"id":"7faddb67_f6b87775","line":16,"updated":"2019-08-05 13:24:52.000000000","message":"This is one feature, although probably the less interesting. The main change here is to enable notifications for a number of new services. This can be added as a second item in this feature list.","commit_id":"a13cab6896062b90c191d51d3c03801d55b4fbb9"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"6e3360dabb4efcb93fdcd41e23c450f3dd3ab8e5","unresolved":false,"context_lines":[{"line_number":13,"context_line":"    \"https://review.opendev.org/#/c/670626\""},{"line_number":14,"context_line":"features:"},{"line_number":15,"context_line":"  - |"},{"line_number":16,"context_line":"    Standard method to execute the configuration of \"oslo_messaging\" sections"},{"line_number":17,"context_line":"issues:"},{"line_number":18,"context_line":"  - |"},{"line_number":19,"context_line":"    * Kolla-ansible does not configure nova notifications as it should. If"}],"source_content_type":"text/x-yaml","patch_set":7,"id":"7faddb67_dd5c767e","line":16,"in_reply_to":"7faddb67_6c4116a6","updated":"2019-08-05 16:40:36.000000000","message":"I meant the second - adding a new feature to the list here.","commit_id":"a13cab6896062b90c191d51d3c03801d55b4fbb9"},{"author":{"_account_id":28356,"name":"Rafael Weingartner","email":"rafael@apache.org","username":"rafaelweingartner"},"change_message_id":"f1314d6460faccc0bc1c88c63efeb523e2e4207e","unresolved":false,"context_lines":[{"line_number":13,"context_line":"    \"https://review.opendev.org/#/c/670626\""},{"line_number":14,"context_line":"features:"},{"line_number":15,"context_line":"  - |"},{"line_number":16,"context_line":"    Standard method to execute the configuration of \"oslo_messaging\" sections"},{"line_number":17,"context_line":"issues:"},{"line_number":18,"context_line":"  - |"},{"line_number":19,"context_line":"    * Kolla-ansible does not configure nova notifications as it should. If"}],"source_content_type":"text/x-yaml","patch_set":7,"id":"7faddb67_6c4116a6","line":16,"in_reply_to":"7faddb67_f6b87775","updated":"2019-08-05 14:09:39.000000000","message":"I did not understand. Do you mean remove the feature here? Or, add a new \"feature\" in the list as \"enable notifications for a number of services\"?","commit_id":"a13cab6896062b90c191d51d3c03801d55b4fbb9"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"277d01f4ac767dae2bbc63e6ad49778e524f8701","unresolved":false,"context_lines":[{"line_number":14,"context_line":"features:"},{"line_number":15,"context_line":"  - |"},{"line_number":16,"context_line":"    Standard method to execute the configuration of \"oslo_messaging\" sections"},{"line_number":17,"context_line":"issues:"},{"line_number":18,"context_line":"  - |"},{"line_number":19,"context_line":"    * Kolla-ansible does not configure nova notifications as it should. If"},{"line_number":20,"context_line":"    \u0027searchlight\u0027 is not installed (enabled) the \u0027notification_format\u0027"},{"line_number":21,"context_line":"    should be \u0027unversioned\u0027. The default is \u0027both\u0027; so nova will send a"},{"line_number":22,"context_line":"    notification to the queue versioned_notifications; but that queue has"},{"line_number":23,"context_line":"    no consumer when \u0027searchlight\u0027 is disabled. "},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"    https://bugzilla.redhat.com/show_bug.cgi?id\u003d1478274"},{"line_number":26,"context_line":"    https://bugs.launchpad.net/ceilometer/+bug/1665449"},{"line_number":27,"context_line":""},{"line_number":28,"context_line":"    *  Barbican needs its own queue to capture events from Keystone."},{"line_number":29,"context_line":"    Otherwise, it has an impact on Ceilometer and other systems that are"},{"line_number":30,"context_line":"    connected to the \"notifications\" default queue."},{"line_number":31,"context_line":""},{"line_number":32,"context_line":"    * By default, Kolla-ansible was not enabling Keystone notification when "},{"line_number":33,"context_line":"    \u0027enable_cadf_notification\u0027 was set to \u0027no\u0027. That parameter was a bit"},{"line_number":34,"context_line":"    misleading, one could interpret that when it is set to \u0027no\u0027, the legacy"},{"line_number":35,"context_line":"    mode is used. However, that is not what happens. As a consequence, "},{"line_number":36,"context_line":"    Keystone is configured without any notifications."},{"line_number":37,"context_line":"upgrade:"},{"line_number":38,"context_line":"  - |"},{"line_number":39,"context_line":"    If a user sets \u0027enable_cadf_notifications\u0027 to \u0027yes\u0027 and manually"}],"source_content_type":"text/x-yaml","patch_set":7,"id":"7faddb67_564dcbc1","line":36,"range":{"start_line":17,"start_character":0,"end_line":36,"end_character":53},"updated":"2019-08-05 13:24:52.000000000","message":"Issues section is normally for known issues, not fixed issues. We don\u0027t use either section.\n\nHowever, this information would be very useful in a (or multiple if you prefer) bug report on launchpad, which can then be referenced in the commit message via:\n\nCloses-Bug: #\u003cbug ID\u003e","commit_id":"a13cab6896062b90c191d51d3c03801d55b4fbb9"},{"author":{"_account_id":28356,"name":"Rafael Weingartner","email":"rafael@apache.org","username":"rafaelweingartner"},"change_message_id":"f1314d6460faccc0bc1c88c63efeb523e2e4207e","unresolved":false,"context_lines":[{"line_number":14,"context_line":"features:"},{"line_number":15,"context_line":"  - |"},{"line_number":16,"context_line":"    Standard method to execute the configuration of \"oslo_messaging\" sections"},{"line_number":17,"context_line":"issues:"},{"line_number":18,"context_line":"  - |"},{"line_number":19,"context_line":"    * Kolla-ansible does not configure nova notifications as it should. If"},{"line_number":20,"context_line":"    \u0027searchlight\u0027 is not installed (enabled) the \u0027notification_format\u0027"},{"line_number":21,"context_line":"    should be \u0027unversioned\u0027. The default is \u0027both\u0027; so nova will send a"},{"line_number":22,"context_line":"    notification to the queue versioned_notifications; but that queue has"},{"line_number":23,"context_line":"    no consumer when \u0027searchlight\u0027 is disabled. "},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"    https://bugzilla.redhat.com/show_bug.cgi?id\u003d1478274"},{"line_number":26,"context_line":"    https://bugs.launchpad.net/ceilometer/+bug/1665449"},{"line_number":27,"context_line":""},{"line_number":28,"context_line":"    *  Barbican needs its own queue to capture events from Keystone."},{"line_number":29,"context_line":"    Otherwise, it has an impact on Ceilometer and other systems that are"},{"line_number":30,"context_line":"    connected to the \"notifications\" default queue."},{"line_number":31,"context_line":""},{"line_number":32,"context_line":"    * By default, Kolla-ansible was not enabling Keystone notification when "},{"line_number":33,"context_line":"    \u0027enable_cadf_notification\u0027 was set to \u0027no\u0027. That parameter was a bit"},{"line_number":34,"context_line":"    misleading, one could interpret that when it is set to \u0027no\u0027, the legacy"},{"line_number":35,"context_line":"    mode is used. However, that is not what happens. As a consequence, "},{"line_number":36,"context_line":"    Keystone is configured without any notifications."},{"line_number":37,"context_line":"upgrade:"},{"line_number":38,"context_line":"  - |"},{"line_number":39,"context_line":"    If a user sets \u0027enable_cadf_notifications\u0027 to \u0027yes\u0027 and manually"}],"source_content_type":"text/x-yaml","patch_set":7,"id":"7faddb67_ec0e668a","line":36,"range":{"start_line":17,"start_character":0,"end_line":36,"end_character":53},"in_reply_to":"7faddb67_564dcbc1","updated":"2019-08-05 14:09:39.000000000","message":"Ok, I will remove this","commit_id":"a13cab6896062b90c191d51d3c03801d55b4fbb9"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"277d01f4ac767dae2bbc63e6ad49778e524f8701","unresolved":false,"context_lines":[{"line_number":36,"context_line":"    Keystone is configured without any notifications."},{"line_number":37,"context_line":"upgrade:"},{"line_number":38,"context_line":"  - |"},{"line_number":39,"context_line":"    If a user sets \u0027enable_cadf_notifications\u0027 to \u0027yes\u0027 and manually"},{"line_number":40,"context_line":"    overrides the default topics, his/her notifications would stop if"},{"line_number":41,"context_line":"    neither ceilometer nor barbican is enabled. Therefore, when upgrading"},{"line_number":42,"context_line":"    the user must add the custom topics in \u0027keystone_notification_topics\u0027"},{"line_number":43,"context_line":"    list, enabled them (the new ones), and disable the default ones."},{"line_number":44,"context_line":"deprecations:"},{"line_number":45,"context_line":"  - |"},{"line_number":46,"context_line":"    * \u0027enable_cadf_notification\u0027 parameter was removed."}],"source_content_type":"text/x-yaml","patch_set":7,"id":"7faddb67_297eb0e3","line":43,"range":{"start_line":39,"start_character":0,"end_line":43,"end_character":68},"updated":"2019-08-05 13:24:52.000000000","message":"How about:\n\nRemoves the ``enable_cadf_notifications`` variable. This was used to set the keystone notification format to CADF, but this is the default anyway. It also set the ``[oslo_messaging_notifications] driver`` option to ``messagingv2``, but without setting the ``topics`` option this does not actually enable notifications.\n\nIt is now possible to enable keystone notifications by ... TBD.","commit_id":"a13cab6896062b90c191d51d3c03801d55b4fbb9"},{"author":{"_account_id":28356,"name":"Rafael Weingartner","email":"rafael@apache.org","username":"rafaelweingartner"},"change_message_id":"f1314d6460faccc0bc1c88c63efeb523e2e4207e","unresolved":false,"context_lines":[{"line_number":36,"context_line":"    Keystone is configured without any notifications."},{"line_number":37,"context_line":"upgrade:"},{"line_number":38,"context_line":"  - |"},{"line_number":39,"context_line":"    If a user sets \u0027enable_cadf_notifications\u0027 to \u0027yes\u0027 and manually"},{"line_number":40,"context_line":"    overrides the default topics, his/her notifications would stop if"},{"line_number":41,"context_line":"    neither ceilometer nor barbican is enabled. Therefore, when upgrading"},{"line_number":42,"context_line":"    the user must add the custom topics in \u0027keystone_notification_topics\u0027"},{"line_number":43,"context_line":"    list, enabled them (the new ones), and disable the default ones."},{"line_number":44,"context_line":"deprecations:"},{"line_number":45,"context_line":"  - |"},{"line_number":46,"context_line":"    * \u0027enable_cadf_notification\u0027 parameter was removed."}],"source_content_type":"text/x-yaml","patch_set":7,"id":"7faddb67_ac52ae65","line":43,"range":{"start_line":39,"start_character":0,"end_line":43,"end_character":68},"in_reply_to":"7faddb67_297eb0e3","updated":"2019-08-05 14:09:39.000000000","message":"I liked it. Will do as suggested","commit_id":"a13cab6896062b90c191d51d3c03801d55b4fbb9"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"6e3360dabb4efcb93fdcd41e23c450f3dd3ab8e5","unresolved":false,"context_lines":[{"line_number":36,"context_line":"    Keystone is configured without any notifications."},{"line_number":37,"context_line":"upgrade:"},{"line_number":38,"context_line":"  - |"},{"line_number":39,"context_line":"    If a user sets \u0027enable_cadf_notifications\u0027 to \u0027yes\u0027 and manually"},{"line_number":40,"context_line":"    overrides the default topics, his/her notifications would stop if"},{"line_number":41,"context_line":"    neither ceilometer nor barbican is enabled. Therefore, when upgrading"},{"line_number":42,"context_line":"    the user must add the custom topics in \u0027keystone_notification_topics\u0027"},{"line_number":43,"context_line":"    list, enabled them (the new ones), and disable the default ones."},{"line_number":44,"context_line":"deprecations:"},{"line_number":45,"context_line":"  - |"},{"line_number":46,"context_line":"    * \u0027enable_cadf_notification\u0027 parameter was removed."}],"source_content_type":"text/x-yaml","patch_set":7,"id":"7faddb67_3d758a32","line":43,"range":{"start_line":39,"start_character":0,"end_line":43,"end_character":68},"in_reply_to":"7faddb67_ac52ae65","updated":"2019-08-05 16:40:36.000000000","message":"I went and looked up the default for topics, and it is actually \u0027notifications\u0027. https://docs.openstack.org/oslo.messaging/latest/configuration/opts.html#oslo-messaging-notifications\n\nThis means that enable_cadf_notifications is not as useless as first thought - it does enable keystone notifications.","commit_id":"a13cab6896062b90c191d51d3c03801d55b4fbb9"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"277d01f4ac767dae2bbc63e6ad49778e524f8701","unresolved":false,"context_lines":[{"line_number":41,"context_line":"    neither ceilometer nor barbican is enabled. Therefore, when upgrading"},{"line_number":42,"context_line":"    the user must add the custom topics in \u0027keystone_notification_topics\u0027"},{"line_number":43,"context_line":"    list, enabled them (the new ones), and disable the default ones."},{"line_number":44,"context_line":"deprecations:"},{"line_number":45,"context_line":"  - |"},{"line_number":46,"context_line":"    * \u0027enable_cadf_notification\u0027 parameter was removed."}],"source_content_type":"text/x-yaml","patch_set":7,"id":"7faddb67_b673dfe6","line":46,"range":{"start_line":44,"start_character":0,"end_line":46,"end_character":55},"updated":"2019-08-05 13:24:52.000000000","message":"This isn\u0027t a deprecation, it\u0027s a removal. Lets say that in the upgrade section.","commit_id":"a13cab6896062b90c191d51d3c03801d55b4fbb9"},{"author":{"_account_id":28356,"name":"Rafael Weingartner","email":"rafael@apache.org","username":"rafaelweingartner"},"change_message_id":"f1314d6460faccc0bc1c88c63efeb523e2e4207e","unresolved":false,"context_lines":[{"line_number":41,"context_line":"    neither ceilometer nor barbican is enabled. Therefore, when upgrading"},{"line_number":42,"context_line":"    the user must add the custom topics in \u0027keystone_notification_topics\u0027"},{"line_number":43,"context_line":"    list, enabled them (the new ones), and disable the default ones."},{"line_number":44,"context_line":"deprecations:"},{"line_number":45,"context_line":"  - |"},{"line_number":46,"context_line":"    * \u0027enable_cadf_notification\u0027 parameter was removed."}],"source_content_type":"text/x-yaml","patch_set":7,"id":"7faddb67_8cdc92e4","line":46,"range":{"start_line":44,"start_character":0,"end_line":46,"end_character":55},"in_reply_to":"7faddb67_b673dfe6","updated":"2019-08-05 14:09:39.000000000","message":"section removed","commit_id":"a13cab6896062b90c191d51d3c03801d55b4fbb9"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"6e3360dabb4efcb93fdcd41e23c450f3dd3ab8e5","unresolved":false,"context_lines":[{"line_number":8,"context_line":"    Removes the ``enable_cadf_notifications`` variable. This was used to"},{"line_number":9,"context_line":"    set the keystone notification format to CADF, but this is the default"},{"line_number":10,"context_line":"    anyway. It also set the ``[oslo_messaging_notifications] driver``"},{"line_number":11,"context_line":"    option to ``messagingv2``, but without setting the ``topics`` option"},{"line_number":12,"context_line":"    this does not actually enable notifications."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"    It is now possible to enable keystone notifications via"},{"line_number":15,"context_line":"    \u0027keystone_default_notifications_topic_enabled\u0027 parameter"}],"source_content_type":"text/x-yaml","patch_set":10,"id":"7faddb67_1d676e4f","line":12,"range":{"start_line":11,"start_character":31,"end_line":12,"end_character":48},"updated":"2019-08-05 16:40:36.000000000","message":"As mentioned in another comment, this is not true since the default for topics is \u0027notifications\u0027.","commit_id":"3e72ea33f3c2a30d10d4e4bd5819e7d5d5287290"},{"author":{"_account_id":28356,"name":"Rafael Weingartner","email":"rafael@apache.org","username":"rafaelweingartner"},"change_message_id":"d224d4e7880eacf64a928d95a83b1907b21fd305","unresolved":false,"context_lines":[{"line_number":8,"context_line":"    Removes the ``enable_cadf_notifications`` variable. This was used to"},{"line_number":9,"context_line":"    set the keystone notification format to CADF, but this is the default"},{"line_number":10,"context_line":"    anyway. It also set the ``[oslo_messaging_notifications] driver``"},{"line_number":11,"context_line":"    option to ``messagingv2``, but without setting the ``topics`` option"},{"line_number":12,"context_line":"    this does not actually enable notifications."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"    It is now possible to enable keystone notifications via"},{"line_number":15,"context_line":"    \u0027keystone_default_notifications_topic_enabled\u0027 parameter"}],"source_content_type":"text/x-yaml","patch_set":10,"id":"7faddb67_38e278a1","line":12,"range":{"start_line":11,"start_character":31,"end_line":12,"end_character":48},"in_reply_to":"7faddb67_1d676e4f","updated":"2019-08-05 17:30:46.000000000","message":"Now, this will be true. Because we changed the mechanism remember? We enable/disable notifications based on topics; this means, if we have at least one enabled topic, we do enable the notification mechanism for that topic.","commit_id":"3e72ea33f3c2a30d10d4e4bd5819e7d5d5287290"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"4404ee155988275999e1c0196010757e249a3f35","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Standard method to execute the configuration of \"oslo_messaging\" sections"}],"source_content_type":"text/x-yaml","patch_set":13,"id":"7faddb67_56c932a9","line":1,"updated":"2019-08-06 15:32:39.000000000","message":"nit: ``backticks`` for variables","commit_id":"06c487dcb9c589dfc5b9234b03dae385437e6123"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"846b7d84268001ef788a573cb93e8d7a1edcf987","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Standard method to execute the configuration of \"oslo_messaging\" sections"}],"source_content_type":"text/x-yaml","patch_set":13,"id":"7faddb67_b97ad984","line":1,"in_reply_to":"7faddb67_56c932a9","updated":"2019-08-06 15:34:31.000000000","message":"Oh and pep8 doesn\u0027t like the trailing whitespace in here.","commit_id":"06c487dcb9c589dfc5b9234b03dae385437e6123"},{"author":{"_account_id":28356,"name":"Rafael Weingartner","email":"rafael@apache.org","username":"rafaelweingartner"},"change_message_id":"a96c6dd9ede39c5244631d196fa2e1b6514ef8ef","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Standard method to execute the configuration of \"oslo_messaging\" sections"}],"source_content_type":"text/x-yaml","patch_set":13,"id":"7faddb67_04d14023","line":1,"in_reply_to":"7faddb67_56c932a9","updated":"2019-08-06 16:33:41.000000000","message":"got it","commit_id":"06c487dcb9c589dfc5b9234b03dae385437e6123"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"4404ee155988275999e1c0196010757e249a3f35","unresolved":false,"context_lines":[{"line_number":5,"context_line":""},{"line_number":6,"context_line":"upgrade:"},{"line_number":7,"context_line":"  - |"},{"line_number":8,"context_line":"    The ``enable_cadf_notifications`` variable is deprecated. Therefore, users must stop using it, "},{"line_number":9,"context_line":"    and start to use \u0027enable_ceilometer\u0027 or \u0027keystone_default_notifications_topic_enabled\u0027"},{"line_number":10,"context_line":"    to enable keystone notifications."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"deprecations:"},{"line_number":13,"context_line":"  - |"}],"source_content_type":"text/x-yaml","patch_set":13,"id":"7faddb67_b632e6a5","line":10,"range":{"start_line":8,"start_character":0,"end_line":10,"end_character":37},"updated":"2019-08-06 15:32:39.000000000","message":"How about:\n\nThe ``enable_cadf_notifications`` variable is deprecated. CADF is the default notification format in keystone. To enable keystone notifications, users should now set ``keystone_default_notifications_topic_enabled`` to ``yes`` or enable Ceilometer via ``enable_ceilometer``.","commit_id":"06c487dcb9c589dfc5b9234b03dae385437e6123"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"4404ee155988275999e1c0196010757e249a3f35","unresolved":false,"context_lines":[{"line_number":11,"context_line":""},{"line_number":12,"context_line":"deprecations:"},{"line_number":13,"context_line":"  - |"},{"line_number":14,"context_line":"    \u0027enable_cadf_notification\u0027 parameter is scheduled to be removed in the next upcomming release."},{"line_number":15,"context_line":"    This was used to set the keystone notification format to CADF, but it is the default"},{"line_number":16,"context_line":"    anyway. It sets the ``[oslo_messaging_notifications] driver`` option to ``messagingv2``, "},{"line_number":17,"context_line":"    to enable notifications. However, it can lead users to think that the setting it to \u0027no\u0027, "},{"line_number":18,"context_line":"    will enable the \u0027basic\u0027 notifications format. However, that is not how it was implemeted."}],"source_content_type":"text/x-yaml","patch_set":13,"id":"7faddb67_76dd4e3f","line":18,"range":{"start_line":14,"start_character":4,"end_line":18,"end_character":93},"updated":"2019-08-06 15:32:39.000000000","message":"I\u0027d just go with the same content as the upgrade note here - too much backstory or context in a release note can make people stop reading :)","commit_id":"06c487dcb9c589dfc5b9234b03dae385437e6123"},{"author":{"_account_id":28356,"name":"Rafael Weingartner","email":"rafael@apache.org","username":"rafaelweingartner"},"change_message_id":"a96c6dd9ede39c5244631d196fa2e1b6514ef8ef","unresolved":false,"context_lines":[{"line_number":11,"context_line":""},{"line_number":12,"context_line":"deprecations:"},{"line_number":13,"context_line":"  - |"},{"line_number":14,"context_line":"    \u0027enable_cadf_notification\u0027 parameter is scheduled to be removed in the next upcomming release."},{"line_number":15,"context_line":"    This was used to set the keystone notification format to CADF, but it is the default"},{"line_number":16,"context_line":"    anyway. It sets the ``[oslo_messaging_notifications] driver`` option to ``messagingv2``, "},{"line_number":17,"context_line":"    to enable notifications. However, it can lead users to think that the setting it to \u0027no\u0027, "},{"line_number":18,"context_line":"    will enable the \u0027basic\u0027 notifications format. However, that is not how it was implemeted."}],"source_content_type":"text/x-yaml","patch_set":13,"id":"7faddb67_e4966449","line":18,"range":{"start_line":14,"start_character":4,"end_line":18,"end_character":93},"in_reply_to":"7faddb67_76dd4e3f","updated":"2019-08-06 16:33:41.000000000","message":"ok. I will use the same content then.","commit_id":"06c487dcb9c589dfc5b9234b03dae385437e6123"}]}