)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"34010bd68238e2088baab5c0b1f137a4b09221b7","unresolved":false,"context_lines":[{"line_number":5,"context_line":"CommitDate: 2019-09-15 20:46:18 +0200"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"CI: Use VXLAN overlay network"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Includes fix for haproxy precheck failing on CentOS"},{"line_number":10,"context_line":"on which \u0027/sbin\u0027 is not included in regular user\u0027s PATH."},{"line_number":11,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":19,"id":"3fa7e38b_f27d91e7","line":8,"updated":"2019-09-18 13:14:47.000000000","message":"Probably needs a bit more context in here about why we\u0027re doing this. Also explicitly state we\u0027re enabling haproxy in multinode CI.","commit_id":"ed23ceea18f75d6747f323bb8020c63583074f65"}],"tests/get_logs.sh":[{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"839f75dacd7a946708420a929a8f5e435f8ac330","unresolved":false,"context_lines":[{"line_number":31,"context_line":"    ip l \u003e\u003e ${LOG_DIR}/system_logs/ip.txt"},{"line_number":32,"context_line":"    ip r \u003e\u003e ${LOG_DIR}/system_logs/ip.txt"},{"line_number":33,"context_line":"    ping -c 4 169.254.169.10 \u003e\u003e ${LOG_DIR}/system_logs/ip.txt"},{"line_number":34,"context_line":"    iptables -L \u003e ${LOG_DIR}/system_logs/iptables.txt"},{"line_number":35,"context_line":"    ss -putona \u003e ${LOG_DIR}/system_logs/ss.txt"},{"line_number":36,"context_line":""},{"line_number":37,"context_line":"    if [ `command -v dpkg` ]; then"}],"source_content_type":"text/x-sh","patch_set":6,"id":"7faddb67_1a32465f","line":34,"updated":"2019-07-15 19:15:24.000000000","message":"-v -n ?","commit_id":"b3361012fb10cb5ee1f1a88588322d719ba9c173"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"34010bd68238e2088baab5c0b1f137a4b09221b7","unresolved":false,"context_lines":[{"line_number":32,"context_line":"    ip a \u003e ${LOG_DIR}/system_logs/ip.txt"},{"line_number":33,"context_line":"    ip l \u003e\u003e ${LOG_DIR}/system_logs/ip.txt"},{"line_number":34,"context_line":"    ip r \u003e\u003e ${LOG_DIR}/system_logs/ip.txt"},{"line_number":35,"context_line":"    ping -c 4 ${KOLLA_INTERNAL_VIP_ADDRESS} \u003e\u003e ${LOG_DIR}/system_logs/ip.txt"},{"line_number":36,"context_line":"    iptables -v -n -L \u003e ${LOG_DIR}/system_logs/iptables.txt"},{"line_number":37,"context_line":"    ss -putona \u003e ${LOG_DIR}/system_logs/ss.txt"},{"line_number":38,"context_line":""}],"source_content_type":"text/x-sh","patch_set":19,"id":"3fa7e38b_0527de14","line":35,"updated":"2019-09-18 13:14:47.000000000","message":"If we\u0027re going to chuck these in one file, we should probably add some blank lines or a string containing the command being run?","commit_id":"ed23ceea18f75d6747f323bb8020c63583074f65"}],"tests/run.yml":[{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"34010bd68238e2088baab5c0b1f137a4b09221b7","unresolved":false,"context_lines":[{"line_number":17,"context_line":"        api_interface_tunnel_vni: 10001"},{"line_number":18,"context_line":"        tunnel_local_address: \"{{ nodepool.private_ipv4 }}\""},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"    - name: Create VXLAN interface"},{"line_number":21,"context_line":"      become: true"},{"line_number":22,"context_line":"      command: ip link add {{ api_interface_name }} type vxlan id {{ api_interface_tunnel_vni }} local {{ tunnel_local_address }} dstport 4789"},{"line_number":23,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":19,"id":"3fa7e38b_852179a2","line":20,"updated":"2019-09-18 13:14:47.000000000","message":"Thinking about it, we should really do this in pre.yml. I know this kind of messes with the variables.","commit_id":"ed23ceea18f75d6747f323bb8020c63583074f65"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"34010bd68238e2088baab5c0b1f137a4b09221b7","unresolved":false,"context_lines":[{"line_number":47,"context_line":"    - name: Add IP address for VXLAN network"},{"line_number":48,"context_line":"      become: true"},{"line_number":49,"context_line":"      vars:"},{"line_number":50,"context_line":"        address_prefix: \"{{ api_interface_address }}/{{ api_network_prefix_length }}\""},{"line_number":51,"context_line":"        # NOTE(yoctozepto): we have to compute and explicitly set the broadcast address,"},{"line_number":52,"context_line":"        # otherwise bifrost fails its pre-bootstrap sanity checks due to missing"},{"line_number":53,"context_line":"        # broadcast address as ansible picks up scope (\u0027global\u0027) as the interface\u0027s"}],"source_content_type":"text/x-yaml","patch_set":19,"id":"3fa7e38b_12806d8b","line":50,"range":{"start_line":50,"start_character":8,"end_line":50,"end_character":22},"updated":"2019-09-18 13:14:47.000000000","message":"api_network_cidr?","commit_id":"ed23ceea18f75d6747f323bb8020c63583074f65"}],"tests/templates/globals-default.j2":[{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"0f4f36a333137dfa5c691ae0dc7f3f0c66669923","unresolved":false,"context_lines":[{"line_number":18,"context_line":"{% if need_build_image and not is_previous_release %}"},{"line_number":19,"context_line":"# NOTE(Jeffrey4l): use different a docker namespace name in case it pull image from hub.docker.io when deplying"},{"line_number":20,"context_line":"docker_namespace: \"lokolla\""},{"line_number":21,"context_line":"docker_registry: \"{{ primary_address }}:4000\""},{"line_number":22,"context_line":"openstack_release: \"{{ build_image_tag }}\""},{"line_number":23,"context_line":"{% else %}"},{"line_number":24,"context_line":"# use docker hub images"}],"source_content_type":"text/x-jinja2","patch_set":27,"id":"3fa7e38b_8603a673","line":21,"updated":"2019-09-19 17:04:33.000000000","message":"We should really split out the image building from setup_gate.sh, and not do it on every node.","commit_id":"8e40629161a329a22022d38b3cb48dea66121b36"},{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"5e8afb2da6d16325d5c8a447debede838f66d308","unresolved":false,"context_lines":[{"line_number":18,"context_line":"{% if need_build_image and not is_previous_release %}"},{"line_number":19,"context_line":"# NOTE(Jeffrey4l): use different a docker namespace name in case it pull image from hub.docker.io when deplying"},{"line_number":20,"context_line":"docker_namespace: \"lokolla\""},{"line_number":21,"context_line":"docker_registry: \"{{ primary_address }}:4000\""},{"line_number":22,"context_line":"openstack_release: \"{{ build_image_tag }}\""},{"line_number":23,"context_line":"{% else %}"},{"line_number":24,"context_line":"# use docker hub images"}],"source_content_type":"text/x-jinja2","patch_set":27,"id":"3fa7e38b_f3e6d744","line":21,"in_reply_to":"3fa7e38b_8603a673","updated":"2019-09-19 18:25:46.000000000","message":"But we already do that on one node. Hence it has registry on primary. By all means, it is orthogonal to VXLAN...","commit_id":"8e40629161a329a22022d38b3cb48dea66121b36"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"7a4f55b3c29f7d7228c882f2ae3e0232c70d40f0","unresolved":false,"context_lines":[{"line_number":18,"context_line":"{% if need_build_image and not is_previous_release %}"},{"line_number":19,"context_line":"# NOTE(Jeffrey4l): use different a docker namespace name in case it pull image from hub.docker.io when deplying"},{"line_number":20,"context_line":"docker_namespace: \"lokolla\""},{"line_number":21,"context_line":"docker_registry: \"{{ primary_address }}:4000\""},{"line_number":22,"context_line":"openstack_release: \"{{ build_image_tag }}\""},{"line_number":23,"context_line":"{% else %}"},{"line_number":24,"context_line":"# use docker hub images"}],"source_content_type":"text/x-jinja2","patch_set":27,"id":"3fa7e38b_32177e54","line":21,"in_reply_to":"3fa7e38b_f3e6d744","updated":"2019-09-20 12:05:33.000000000","message":"Oh man, I think my brain is busted.","commit_id":"8e40629161a329a22022d38b3cb48dea66121b36"}],"tests/test-openstack.sh":[{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"34010bd68238e2088baab5c0b1f137a4b09221b7","unresolved":false,"context_lines":[{"line_number":104,"context_line":""},{"line_number":105,"context_line":"function test_openstack_logged {"},{"line_number":106,"context_line":"    . /etc/kolla/admin-openrc.sh"},{"line_number":107,"context_line":"    export DASHBOARD_URL\u003d${OS_AUTH_URL%:*}"},{"line_number":108,"context_line":"    . ~/openstackclient-venv/bin/activate"},{"line_number":109,"context_line":"    test_smoke"},{"line_number":110,"context_line":"    test_instance_boot"}],"source_content_type":"text/x-sh","patch_set":19,"id":"3fa7e38b_52da65e9","line":107,"range":{"start_line":107,"start_character":3,"end_line":107,"end_character":42},"updated":"2019-09-18 13:14:47.000000000","message":"move to check_dashboard?","commit_id":"ed23ceea18f75d6747f323bb8020c63583074f65"},{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"fed69d4c1bd4c7ac0aa7c6c332e0308dc163c276","unresolved":false,"context_lines":[{"line_number":104,"context_line":""},{"line_number":105,"context_line":"function test_openstack_logged {"},{"line_number":106,"context_line":"    . /etc/kolla/admin-openrc.sh"},{"line_number":107,"context_line":"    export DASHBOARD_URL\u003d${OS_AUTH_URL%:*}"},{"line_number":108,"context_line":"    . ~/openstackclient-venv/bin/activate"},{"line_number":109,"context_line":"    test_smoke"},{"line_number":110,"context_line":"    test_instance_boot"}],"source_content_type":"text/x-sh","patch_set":19,"id":"3fa7e38b_a35b4d85","line":107,"range":{"start_line":107,"start_character":3,"end_line":107,"end_character":42},"in_reply_to":"3fa7e38b_03bd81b6","updated":"2019-09-18 14:50:17.000000000","message":"Aye, mate! Roger that.","commit_id":"ed23ceea18f75d6747f323bb8020c63583074f65"},{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"13343545cf4b0fa5e13e1e02b200aa83c3cfffb9","unresolved":false,"context_lines":[{"line_number":104,"context_line":""},{"line_number":105,"context_line":"function test_openstack_logged {"},{"line_number":106,"context_line":"    . /etc/kolla/admin-openrc.sh"},{"line_number":107,"context_line":"    export DASHBOARD_URL\u003d${OS_AUTH_URL%:*}"},{"line_number":108,"context_line":"    . ~/openstackclient-venv/bin/activate"},{"line_number":109,"context_line":"    test_smoke"},{"line_number":110,"context_line":"    test_instance_boot"}],"source_content_type":"text/x-sh","patch_set":19,"id":"3fa7e38b_c30d2938","line":107,"range":{"start_line":107,"start_character":3,"end_line":107,"end_character":42},"in_reply_to":"3fa7e38b_52da65e9","updated":"2019-09-18 14:30:27.000000000","message":"unnecessary recomputation?","commit_id":"ed23ceea18f75d6747f323bb8020c63583074f65"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"a083b3e3efc2dbab7e357b4786f78bfb1951f6bc","unresolved":false,"context_lines":[{"line_number":104,"context_line":""},{"line_number":105,"context_line":"function test_openstack_logged {"},{"line_number":106,"context_line":"    . /etc/kolla/admin-openrc.sh"},{"line_number":107,"context_line":"    export DASHBOARD_URL\u003d${OS_AUTH_URL%:*}"},{"line_number":108,"context_line":"    . ~/openstackclient-venv/bin/activate"},{"line_number":109,"context_line":"    test_smoke"},{"line_number":110,"context_line":"    test_instance_boot"}],"source_content_type":"text/x-sh","patch_set":19,"id":"3fa7e38b_03bd81b6","line":107,"range":{"start_line":107,"start_character":3,"end_line":107,"end_character":42},"in_reply_to":"3fa7e38b_c30d2938","updated":"2019-09-18 14:44:22.000000000","message":"It\u0027s not the best optimisation I\u0027ve seen :) would prefer to just make it easier to read.","commit_id":"ed23ceea18f75d6747f323bb8020c63583074f65"}]}