)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"8021344112ea9165f50abe17da2e6a588dc3db5f","unresolved":false,"context_lines":[{"line_number":16,"context_line":"We lose option to set \u0027runtime directory\u0027 but it was done using"},{"line_number":17,"context_line":"\u0027--graph\u0027 option which does not exist in 18.09 version."},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"Also no way for setting custom Docker options. If someone used that at"},{"line_number":20,"context_line":"all."},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"Change-Id: I1215e04ec15b01c0b43bac8c0e81293f6724f278"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"7faddb67_83bab46b","line":20,"range":{"start_line":19,"start_character":46,"end_line":20,"end_character":3},"updated":"2019-07-25 14:25:12.000000000","message":"CI does, unfortunately.","commit_id":"93505cbc5cb0b5e1bdcf5ca121077489d74b266a"},{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"e6e202bd135181ba55e441c1b2d5cac0fe87d54e","unresolved":false,"context_lines":[{"line_number":16,"context_line":"We lose option to set \u0027runtime directory\u0027 but it was done using"},{"line_number":17,"context_line":"\u0027--graph\u0027 option which does not exist in 18.09 version."},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"Also no way for setting custom Docker options. If someone used that at"},{"line_number":20,"context_line":"all."},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"Change-Id: I1215e04ec15b01c0b43bac8c0e81293f6724f278"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"7faddb67_5e05fd12","line":20,"range":{"start_line":19,"start_character":46,"end_line":20,"end_character":3},"in_reply_to":"7faddb67_7e79d9c2","updated":"2019-08-02 11:54:25.000000000","message":"It was a gentle reminder that this is not going to ever pass CI tests unless you take care of it.","commit_id":"93505cbc5cb0b5e1bdcf5ca121077489d74b266a"},{"author":{"_account_id":24072,"name":"Marcin Juszkiewicz","email":"mjuszkiewicz@redhat.com","username":"hrw"},"change_message_id":"83faeef13877981b77e0c11baccf265e33614470","unresolved":false,"context_lines":[{"line_number":16,"context_line":"We lose option to set \u0027runtime directory\u0027 but it was done using"},{"line_number":17,"context_line":"\u0027--graph\u0027 option which does not exist in 18.09 version."},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"Also no way for setting custom Docker options. If someone used that at"},{"line_number":20,"context_line":"all."},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"Change-Id: I1215e04ec15b01c0b43bac8c0e81293f6724f278"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"7faddb67_7e79d9c2","line":20,"range":{"start_line":19,"start_character":46,"end_line":20,"end_character":3},"in_reply_to":"7faddb67_83bab46b","updated":"2019-08-02 11:51:18.000000000","message":"tools/setup_*.sh scripts do it on their own so we can ignore that.","commit_id":"93505cbc5cb0b5e1bdcf5ca121077489d74b266a"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"be5960de2906a73878c8967093074ef1124b971d","unresolved":false,"context_lines":[{"line_number":13,"context_line":"So instead of changing Docker daemon command line let\u0027s change config"},{"line_number":14,"context_line":"for Docker instead. In /etc/docker/daemon.json file as it should be."},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"We lose option to set \u0027runtime directory\u0027 but it was done using"},{"line_number":17,"context_line":"\u0027--graph\u0027 option which does not exist in 18.09 version."},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"Also no way for setting custom Docker options. If someone used that at"},{"line_number":20,"context_line":"all."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":11,"id":"7faddb67_dfbd35b1","line":17,"range":{"start_line":16,"start_character":0,"end_line":17,"end_character":55},"updated":"2019-08-06 17:20:26.000000000","message":"Now it\u0027s --data-root: https://docs.docker.com/engine/deprecated/#-g-and---graph-flags-on-dockerd","commit_id":"e1283d0a29e40e12be6f8137ab757c9cd5013bb9"},{"author":{"_account_id":24072,"name":"Marcin Juszkiewicz","email":"mjuszkiewicz@redhat.com","username":"hrw"},"change_message_id":"ce5e646d1b3c70b928b105751e5c15a734b6524f","unresolved":false,"context_lines":[{"line_number":13,"context_line":"So instead of changing Docker daemon command line let\u0027s change config"},{"line_number":14,"context_line":"for Docker instead. In /etc/docker/daemon.json file as it should be."},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"We lose option to set \u0027runtime directory\u0027 but it was done using"},{"line_number":17,"context_line":"\u0027--graph\u0027 option which does not exist in 18.09 version."},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"Also no way for setting custom Docker options. If someone used that at"},{"line_number":20,"context_line":"all."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":11,"id":"7faddb67_a0d7e6ee","line":17,"range":{"start_line":16,"start_character":0,"end_line":17,"end_character":55},"in_reply_to":"7faddb67_dfbd35b1","updated":"2019-08-07 12:11:15.000000000","message":"Done","commit_id":"e1283d0a29e40e12be6f8137ab757c9cd5013bb9"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"be5960de2906a73878c8967093074ef1124b971d","unresolved":false,"context_lines":[{"line_number":17,"context_line":"\u0027--graph\u0027 option which does not exist in 18.09 version."},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"Also no way for setting custom Docker options. If someone used that at"},{"line_number":20,"context_line":"all."},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"CI goes with old way but it is something we do not need to change."},{"line_number":23,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":11,"id":"7faddb67_5fe705e4","line":20,"updated":"2019-08-06 17:20:26.000000000","message":"It was used. We at least need to provide something equivalent for daemon.json.","commit_id":"e1283d0a29e40e12be6f8137ab757c9cd5013bb9"},{"author":{"_account_id":24072,"name":"Marcin Juszkiewicz","email":"mjuszkiewicz@redhat.com","username":"hrw"},"change_message_id":"ce5e646d1b3c70b928b105751e5c15a734b6524f","unresolved":false,"context_lines":[{"line_number":17,"context_line":"\u0027--graph\u0027 option which does not exist in 18.09 version."},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"Also no way for setting custom Docker options. If someone used that at"},{"line_number":20,"context_line":"all."},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"CI goes with old way but it is something we do not need to change."},{"line_number":23,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":11,"id":"7faddb67_60032e78","line":20,"in_reply_to":"7faddb67_5fe705e4","updated":"2019-08-07 12:11:15.000000000","message":"\u0027docker_config\u0027 is now one of Ansible vars. User is free to fill it.","commit_id":"e1283d0a29e40e12be6f8137ab757c9cd5013bb9"}],"ansible/group_vars/all.yml":[{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"5cb6dde88384bbfff0c76a503ff9775ba2123fd0","unresolved":false,"context_lines":[{"line_number":89,"context_line":"####################"},{"line_number":90,"context_line":"# Docker options"},{"line_number":91,"context_line":"####################"},{"line_number":92,"context_line":"docker_config: []"},{"line_number":93,"context_line":"docker_registry_email:"},{"line_number":94,"context_line":"docker_registry:"},{"line_number":95,"context_line":"docker_namespace: \"kolla\""}],"source_content_type":"text/x-yaml","patch_set":17,"id":"7faddb67_5e7124de","line":92,"range":{"start_line":92,"start_character":15,"end_line":92,"end_character":17},"updated":"2019-08-08 09:51:32.000000000","message":"{}","commit_id":"ebfddc42a470864b6b6fac103ced03f1209ccdf6"},{"author":{"_account_id":24072,"name":"Marcin Juszkiewicz","email":"mjuszkiewicz@redhat.com","username":"hrw"},"change_message_id":"2d10abf0ba16f6ab48d8f4ed5a7d7e625a608590","unresolved":false,"context_lines":[{"line_number":89,"context_line":"####################"},{"line_number":90,"context_line":"# Docker options"},{"line_number":91,"context_line":"####################"},{"line_number":92,"context_line":"docker_config: []"},{"line_number":93,"context_line":"docker_registry_email:"},{"line_number":94,"context_line":"docker_registry:"},{"line_number":95,"context_line":"docker_namespace: \"kolla\""}],"source_content_type":"text/x-yaml","patch_set":17,"id":"7faddb67_f145a1b5","line":92,"range":{"start_line":92,"start_character":15,"end_line":92,"end_character":17},"in_reply_to":"7faddb67_5e7124de","updated":"2019-08-08 10:36:34.000000000","message":"Done","commit_id":"ebfddc42a470864b6b6fac103ced03f1209ccdf6"},{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"ed3422ac83765fb61facb59779fecd520d27b15d","unresolved":false,"context_lines":[{"line_number":89,"context_line":"####################"},{"line_number":90,"context_line":"# Docker options"},{"line_number":91,"context_line":"####################"},{"line_number":92,"context_line":"docker_config: {}"},{"line_number":93,"context_line":"docker_registry_email:"},{"line_number":94,"context_line":"docker_registry:"},{"line_number":95,"context_line":"docker_namespace: \"kolla\""}],"source_content_type":"text/x-yaml","patch_set":21,"id":"7faddb67_2d6195d4","line":92,"range":{"start_line":92,"start_character":0,"end_line":92,"end_character":17},"updated":"2019-08-08 15:13:10.000000000","message":"you override it with a fact, why var?","commit_id":"c675d4ff995ff88c3b1f81059227658cfb05ca73"},{"author":{"_account_id":24072,"name":"Marcin Juszkiewicz","email":"mjuszkiewicz@redhat.com","username":"hrw"},"change_message_id":"1e21a1195beac98d2503ba55b918278ad43d1a7a","unresolved":false,"context_lines":[{"line_number":89,"context_line":"####################"},{"line_number":90,"context_line":"# Docker options"},{"line_number":91,"context_line":"####################"},{"line_number":92,"context_line":"docker_config: {}"},{"line_number":93,"context_line":"docker_registry_email:"},{"line_number":94,"context_line":"docker_registry:"},{"line_number":95,"context_line":"docker_namespace: \"kolla\""}],"source_content_type":"text/x-yaml","patch_set":21,"id":"7faddb67_1ed5e143","line":92,"range":{"start_line":92,"start_character":0,"end_line":92,"end_character":17},"in_reply_to":"7faddb67_2d6195d4","updated":"2019-08-08 17:27:21.000000000","message":"looks not needed since \u0027docker_custom_config\u0027\n\nBut then /etc/docker/daemon.json is missing then tasks fail:\n\nTASK [baremetal : setup docker registries] \nfatal: [c4n1.mlab.devplanet.cf]: FAILED! \u003d\u003e {\"msg\": \"|combine expects dictionaries, got Undefined\"}","commit_id":"c675d4ff995ff88c3b1f81059227658cfb05ca73"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"6df9762557521f6a9749ecbf40f82323873e27e3","unresolved":false,"context_lines":[{"line_number":97,"context_line":"docker_registry_insecure: \"{{ \u0027yes\u0027 if docker_registry else \u0027no\u0027 }}\""},{"line_number":98,"context_line":"docker_runtime_directory: \"\""},{"line_number":99,"context_line":"docker_custom_config: {}"},{"line_number":100,"context_line":"docker_custom_config_used: \"{{ \u0027yes\u0027 if docker_custom_config else \u0027no\u0027 }}\""},{"line_number":101,"context_line":""},{"line_number":102,"context_line":"# Retention settings for Docker logs"},{"line_number":103,"context_line":"docker_log_max_file: \"5\""}],"source_content_type":"text/x-yaml","patch_set":22,"id":"7faddb67_5b791d91","line":100,"range":{"start_line":100,"start_character":0,"end_line":100,"end_character":74},"updated":"2019-08-09 09:29:28.000000000","message":"Don\u0027t need this if following my later comments.","commit_id":"0116057d2abe9683fe351e04f2e0aa9461a30e22"},{"author":{"_account_id":24072,"name":"Marcin Juszkiewicz","email":"mjuszkiewicz@redhat.com","username":"hrw"},"change_message_id":"c0c1aa6ed33695b0cc401e5f5d58f3031de16e23","unresolved":false,"context_lines":[{"line_number":97,"context_line":"docker_registry_insecure: \"{{ \u0027yes\u0027 if docker_registry else \u0027no\u0027 }}\""},{"line_number":98,"context_line":"docker_runtime_directory: \"\""},{"line_number":99,"context_line":"docker_custom_config: {}"},{"line_number":100,"context_line":"docker_custom_config_used: \"{{ \u0027yes\u0027 if docker_custom_config else \u0027no\u0027 }}\""},{"line_number":101,"context_line":""},{"line_number":102,"context_line":"# Retention settings for Docker logs"},{"line_number":103,"context_line":"docker_log_max_file: \"5\""}],"source_content_type":"text/x-yaml","patch_set":22,"id":"7faddb67_8c43d9af","line":100,"range":{"start_line":100,"start_character":0,"end_line":100,"end_character":74},"in_reply_to":"7faddb67_5b791d91","updated":"2019-08-09 13:39:28.000000000","message":"Done","commit_id":"0116057d2abe9683fe351e04f2e0aa9461a30e22"},{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"737a3e39e167c179bb75d85b3998c72ef18e09c9","unresolved":false,"context_lines":[{"line_number":89,"context_line":"####################"},{"line_number":90,"context_line":"# Docker options"},{"line_number":91,"context_line":"####################"},{"line_number":92,"context_line":"docker_config: {}"},{"line_number":93,"context_line":"docker_registry_email:"},{"line_number":94,"context_line":"docker_registry:"},{"line_number":95,"context_line":"docker_namespace: \"kolla\""}],"source_content_type":"text/x-yaml","patch_set":24,"id":"7faddb67_1d06f221","line":92,"range":{"start_line":92,"start_character":0,"end_line":92,"end_character":13},"updated":"2019-08-14 11:36:59.000000000","message":"this remove from here, create only in playbook as it is autogenerated each time","commit_id":"043d5657f87bacca0a0032dc70f745797caa9864"},{"author":{"_account_id":24072,"name":"Marcin Juszkiewicz","email":"mjuszkiewicz@redhat.com","username":"hrw"},"change_message_id":"cc338ca95145f46acd23f0c753e09ebf27a028b7","unresolved":false,"context_lines":[{"line_number":89,"context_line":"####################"},{"line_number":90,"context_line":"# Docker options"},{"line_number":91,"context_line":"####################"},{"line_number":92,"context_line":"docker_config: {}"},{"line_number":93,"context_line":"docker_registry_email:"},{"line_number":94,"context_line":"docker_registry:"},{"line_number":95,"context_line":"docker_namespace: \"kolla\""}],"source_content_type":"text/x-yaml","patch_set":24,"id":"7faddb67_20ef01ea","line":92,"range":{"start_line":92,"start_character":0,"end_line":92,"end_character":13},"in_reply_to":"7faddb67_1d06f221","updated":"2019-08-14 12:08:12.000000000","message":"Done","commit_id":"043d5657f87bacca0a0032dc70f745797caa9864"},{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"737a3e39e167c179bb75d85b3998c72ef18e09c9","unresolved":false,"context_lines":[{"line_number":96,"context_line":"docker_registry_username:"},{"line_number":97,"context_line":"docker_registry_insecure: \"{{ \u0027yes\u0027 if docker_registry else \u0027no\u0027 }}\""},{"line_number":98,"context_line":"docker_runtime_directory: \"\""},{"line_number":99,"context_line":"docker_custom_config: {}"},{"line_number":100,"context_line":""},{"line_number":101,"context_line":"# Retention settings for Docker logs"},{"line_number":102,"context_line":"docker_log_max_file: \"5\""}],"source_content_type":"text/x-yaml","patch_set":24,"id":"7faddb67_5d0c6a41","line":99,"range":{"start_line":99,"start_character":0,"end_line":99,"end_character":20},"updated":"2019-08-14 11:36:59.000000000","message":"this to globals.yml as well","commit_id":"043d5657f87bacca0a0032dc70f745797caa9864"},{"author":{"_account_id":24072,"name":"Marcin Juszkiewicz","email":"mjuszkiewicz@redhat.com","username":"hrw"},"change_message_id":"cc338ca95145f46acd23f0c753e09ebf27a028b7","unresolved":false,"context_lines":[{"line_number":96,"context_line":"docker_registry_username:"},{"line_number":97,"context_line":"docker_registry_insecure: \"{{ \u0027yes\u0027 if docker_registry else \u0027no\u0027 }}\""},{"line_number":98,"context_line":"docker_runtime_directory: \"\""},{"line_number":99,"context_line":"docker_custom_config: {}"},{"line_number":100,"context_line":""},{"line_number":101,"context_line":"# Retention settings for Docker logs"},{"line_number":102,"context_line":"docker_log_max_file: \"5\""}],"source_content_type":"text/x-yaml","patch_set":24,"id":"7faddb67_c0e86db4","line":99,"range":{"start_line":99,"start_character":0,"end_line":99,"end_character":20},"in_reply_to":"7faddb67_5d0c6a41","updated":"2019-08-14 12:08:12.000000000","message":"Like \u0027docker_runtime_directory\u0027 it is not provided anywhere now.","commit_id":"043d5657f87bacca0a0032dc70f745797caa9864"},{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"737a3e39e167c179bb75d85b3998c72ef18e09c9","unresolved":false,"context_lines":[{"line_number":99,"context_line":"docker_custom_config: {}"},{"line_number":100,"context_line":""},{"line_number":101,"context_line":"# Retention settings for Docker logs"},{"line_number":102,"context_line":"docker_log_max_file: \"5\""},{"line_number":103,"context_line":"docker_log_max_size: \"50m\""},{"line_number":104,"context_line":""},{"line_number":105,"context_line":"# Valid options are [ no, on-failure, always, unless-stopped ]"},{"line_number":106,"context_line":"docker_restart_policy: \"unless-stopped\""}],"source_content_type":"text/x-yaml","patch_set":24,"id":"7faddb67_e0fd6908","line":103,"range":{"start_line":102,"start_character":0,"end_line":103,"end_character":26},"updated":"2019-08-14 11:36:59.000000000","message":"so these have to change now?","commit_id":"043d5657f87bacca0a0032dc70f745797caa9864"},{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"bb95a4c20177592becf19d298c9f4dd08696edcf","unresolved":false,"context_lines":[{"line_number":99,"context_line":"docker_custom_config: {}"},{"line_number":100,"context_line":""},{"line_number":101,"context_line":"# Retention settings for Docker logs"},{"line_number":102,"context_line":"docker_log_max_file: \"5\""},{"line_number":103,"context_line":"docker_log_max_size: \"50m\""},{"line_number":104,"context_line":""},{"line_number":105,"context_line":"# Valid options are [ no, on-failure, always, unless-stopped ]"},{"line_number":106,"context_line":"docker_restart_policy: \"unless-stopped\""}],"source_content_type":"text/x-yaml","patch_set":24,"id":"7faddb67_8a7a8b21","line":103,"range":{"start_line":102,"start_character":0,"end_line":103,"end_character":26},"in_reply_to":"7faddb67_a05531fc","updated":"2019-08-14 19:01:22.000000000","message":"I see.","commit_id":"043d5657f87bacca0a0032dc70f745797caa9864"},{"author":{"_account_id":24072,"name":"Marcin Juszkiewicz","email":"mjuszkiewicz@redhat.com","username":"hrw"},"change_message_id":"cc338ca95145f46acd23f0c753e09ebf27a028b7","unresolved":false,"context_lines":[{"line_number":99,"context_line":"docker_custom_config: {}"},{"line_number":100,"context_line":""},{"line_number":101,"context_line":"# Retention settings for Docker logs"},{"line_number":102,"context_line":"docker_log_max_file: \"5\""},{"line_number":103,"context_line":"docker_log_max_size: \"50m\""},{"line_number":104,"context_line":""},{"line_number":105,"context_line":"# Valid options are [ no, on-failure, always, unless-stopped ]"},{"line_number":106,"context_line":"docker_restart_policy: \"unless-stopped\""}],"source_content_type":"text/x-yaml","patch_set":24,"id":"7faddb67_a05531fc","line":103,"range":{"start_line":102,"start_character":0,"end_line":103,"end_character":26},"in_reply_to":"7faddb67_e0fd6908","updated":"2019-08-14 12:08:12.000000000","message":"We need them to be strings otherwise generated json will break docker from starting. Previously they were given on dockerd command line.","commit_id":"043d5657f87bacca0a0032dc70f745797caa9864"}],"ansible/roles/baremetal/defaults/main.yml":[{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"737a3e39e167c179bb75d85b3998c72ef18e09c9","unresolved":false,"context_lines":[{"line_number":64,"context_line":""},{"line_number":65,"context_line":"docker_storage_driver: \"\""},{"line_number":66,"context_line":"docker_custom_option: \"\""},{"line_number":67,"context_line":"docker_custom_option_used: \"{{ \u0027yes\u0027 if docker_custom_option else \u0027no\u0027 }}\""},{"line_number":68,"context_line":""},{"line_number":69,"context_line":"# Ubuntu 18+ does not have easy_install available due to"},{"line_number":70,"context_line":"# https://bugs.launchpad.net/ubuntu/+source/python-setuptools/+bug/1774419."}],"source_content_type":"text/x-yaml","patch_set":24,"id":"7faddb67_60117953","line":67,"range":{"start_line":67,"start_character":0,"end_line":67,"end_character":74},"updated":"2019-08-14 11:36:59.000000000","message":"could get away just using the docker_custom_option","commit_id":"043d5657f87bacca0a0032dc70f745797caa9864"},{"author":{"_account_id":24072,"name":"Marcin Juszkiewicz","email":"mjuszkiewicz@redhat.com","username":"hrw"},"change_message_id":"cc338ca95145f46acd23f0c753e09ebf27a028b7","unresolved":false,"context_lines":[{"line_number":64,"context_line":""},{"line_number":65,"context_line":"docker_storage_driver: \"\""},{"line_number":66,"context_line":"docker_custom_option: \"\""},{"line_number":67,"context_line":"docker_custom_option_used: \"{{ \u0027yes\u0027 if docker_custom_option else \u0027no\u0027 }}\""},{"line_number":68,"context_line":""},{"line_number":69,"context_line":"# Ubuntu 18+ does not have easy_install available due to"},{"line_number":70,"context_line":"# https://bugs.launchpad.net/ubuntu/+source/python-setuptools/+bug/1774419."}],"source_content_type":"text/x-yaml","patch_set":24,"id":"7faddb67_60cf3957","line":67,"range":{"start_line":67,"start_character":0,"end_line":67,"end_character":74},"in_reply_to":"7faddb67_60117953","updated":"2019-08-14 12:08:12.000000000","message":"Done","commit_id":"043d5657f87bacca0a0032dc70f745797caa9864"}],"ansible/roles/baremetal/tasks/post-install.yml":[{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"86aafd84cfaab19eef8728e38a9b170d0cdbed74","unresolved":false,"context_lines":[{"line_number":80,"context_line":""},{"line_number":81,"context_line":"- name: Configure docker service"},{"line_number":82,"context_line":"  become: True"},{"line_number":83,"context_line":"  template:"},{"line_number":84,"context_line":"    src: docker_systemd_service.j2"},{"line_number":85,"context_line":"    dest: /etc/systemd/system/docker.service.d/kolla.conf"},{"line_number":86,"context_line":"  register: docker_configured"},{"line_number":87,"context_line":""},{"line_number":88,"context_line":"- name: Reload docker service file"}],"source_content_type":"text/x-yaml","patch_set":11,"id":"7faddb67_e489846e","side":"PARENT","line":85,"range":{"start_line":83,"start_character":0,"end_line":85,"end_character":57},"updated":"2019-08-06 16:20:09.000000000","message":"we should let this file be empty to overwrite its previous content\n\nThis is a point for discussion because it kind of brings back the \"rebootstrap\"-during-upgrade-to-stay-supported issue.","commit_id":"04aa0ee813bfb689c4f8ae290402b23b3128f488"},{"author":{"_account_id":24072,"name":"Marcin Juszkiewicz","email":"mjuszkiewicz@redhat.com","username":"hrw"},"change_message_id":"e35984970e7ba8c0b570dc922065823542d68ad9","unresolved":false,"context_lines":[{"line_number":80,"context_line":""},{"line_number":81,"context_line":"- name: Configure docker service"},{"line_number":82,"context_line":"  become: True"},{"line_number":83,"context_line":"  template:"},{"line_number":84,"context_line":"    src: docker_systemd_service.j2"},{"line_number":85,"context_line":"    dest: /etc/systemd/system/docker.service.d/kolla.conf"},{"line_number":86,"context_line":"  register: docker_configured"},{"line_number":87,"context_line":""},{"line_number":88,"context_line":"- name: Reload docker service file"}],"source_content_type":"text/x-yaml","patch_set":11,"id":"7faddb67_8078aa8f","side":"PARENT","line":85,"range":{"start_line":83,"start_character":0,"end_line":85,"end_character":57},"in_reply_to":"7faddb67_df89b56e","updated":"2019-08-07 11:52:11.000000000","message":"Done","commit_id":"04aa0ee813bfb689c4f8ae290402b23b3128f488"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"be5960de2906a73878c8967093074ef1124b971d","unresolved":false,"context_lines":[{"line_number":80,"context_line":""},{"line_number":81,"context_line":"- name: Configure docker service"},{"line_number":82,"context_line":"  become: True"},{"line_number":83,"context_line":"  template:"},{"line_number":84,"context_line":"    src: docker_systemd_service.j2"},{"line_number":85,"context_line":"    dest: /etc/systemd/system/docker.service.d/kolla.conf"},{"line_number":86,"context_line":"  register: docker_configured"},{"line_number":87,"context_line":""},{"line_number":88,"context_line":"- name: Reload docker service file"}],"source_content_type":"text/x-yaml","patch_set":11,"id":"7faddb67_df89b56e","side":"PARENT","line":85,"range":{"start_line":83,"start_character":0,"end_line":85,"end_character":57},"in_reply_to":"7faddb67_e489846e","updated":"2019-08-06 17:20:26.000000000","message":"use file module with state\u003dabsent to remove it.","commit_id":"04aa0ee813bfb689c4f8ae290402b23b3128f488"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"be5960de2906a73878c8967093074ef1124b971d","unresolved":false,"context_lines":[{"line_number":65,"context_line":"  file:"},{"line_number":66,"context_line":"    path: /etc/docker"},{"line_number":67,"context_line":"    state: directory"},{"line_number":68,"context_line":"    recurse: yes"},{"line_number":69,"context_line":"  become: True"},{"line_number":70,"context_line":""},{"line_number":71,"context_line":"- name: read docker config"}],"source_content_type":"text/x-yaml","patch_set":11,"id":"7faddb67_9f09fddd","line":68,"range":{"start_line":68,"start_character":4,"end_line":68,"end_character":16},"updated":"2019-08-06 17:20:26.000000000","message":"nit: recurse not required","commit_id":"e1283d0a29e40e12be6f8137ab757c9cd5013bb9"},{"author":{"_account_id":24072,"name":"Marcin Juszkiewicz","email":"mjuszkiewicz@redhat.com","username":"hrw"},"change_message_id":"e35984970e7ba8c0b570dc922065823542d68ad9","unresolved":false,"context_lines":[{"line_number":65,"context_line":"  file:"},{"line_number":66,"context_line":"    path: /etc/docker"},{"line_number":67,"context_line":"    state: directory"},{"line_number":68,"context_line":"    recurse: yes"},{"line_number":69,"context_line":"  become: True"},{"line_number":70,"context_line":""},{"line_number":71,"context_line":"- name: read docker config"}],"source_content_type":"text/x-yaml","patch_set":11,"id":"7faddb67_15115e5e","line":68,"range":{"start_line":68,"start_character":4,"end_line":68,"end_character":16},"in_reply_to":"7faddb67_9f09fddd","updated":"2019-08-07 11:52:11.000000000","message":"Done","commit_id":"e1283d0a29e40e12be6f8137ab757c9cd5013bb9"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"be5960de2906a73878c8967093074ef1124b971d","unresolved":false,"context_lines":[{"line_number":71,"context_line":"- name: read docker config"},{"line_number":72,"context_line":"  include_vars:"},{"line_number":73,"context_line":"    file: /etc/docker/daemon.json"},{"line_number":74,"context_line":"    name: docker_config"},{"line_number":75,"context_line":""},{"line_number":76,"context_line":"- name: get configured insecure registries"},{"line_number":77,"context_line":"  vars:"}],"source_content_type":"text/x-yaml","patch_set":11,"id":"7faddb67_5f99456a","line":74,"updated":"2019-08-06 17:20:26.000000000","message":"What happens if this file does not exist?","commit_id":"e1283d0a29e40e12be6f8137ab757c9cd5013bb9"},{"author":{"_account_id":24072,"name":"Marcin Juszkiewicz","email":"mjuszkiewicz@redhat.com","username":"hrw"},"change_message_id":"20ddb4c643ff3f9fed142ab129ddd1750fabc361","unresolved":false,"context_lines":[{"line_number":71,"context_line":"- name: read docker config"},{"line_number":72,"context_line":"  include_vars:"},{"line_number":73,"context_line":"    file: /etc/docker/daemon.json"},{"line_number":74,"context_line":"    name: docker_config"},{"line_number":75,"context_line":""},{"line_number":76,"context_line":"- name: get configured insecure registries"},{"line_number":77,"context_line":"  vars:"}],"source_content_type":"text/x-yaml","patch_set":11,"id":"7faddb67_c0b9c215","line":74,"in_reply_to":"7faddb67_5f99456a","updated":"2019-08-07 11:53:22.000000000","message":"Added check does it exist. And docker_config to variables so if it does not then we are still fine.","commit_id":"e1283d0a29e40e12be6f8137ab757c9cd5013bb9"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"be5960de2906a73878c8967093074ef1124b971d","unresolved":false,"context_lines":[{"line_number":73,"context_line":"    file: /etc/docker/daemon.json"},{"line_number":74,"context_line":"    name: docker_config"},{"line_number":75,"context_line":""},{"line_number":76,"context_line":"- name: get configured insecure registries"},{"line_number":77,"context_line":"  vars:"},{"line_number":78,"context_line":"    registries: [\"{{docker_registry}}\"]"},{"line_number":79,"context_line":"  set_fact:"},{"line_number":80,"context_line":"    registries: \"{{registries + [item]}}\""},{"line_number":81,"context_line":"  with_items: \"{{docker_config[\u0027insecure-registries\u0027]|list}}\""},{"line_number":82,"context_line":"  when: docker_registry is defined and docker_config[\u0027insecure-registries\u0027] is defined"},{"line_number":83,"context_line":""},{"line_number":84,"context_line":"- name: setup docker registries"},{"line_number":85,"context_line":"  set_fact:"}],"source_content_type":"text/x-yaml","patch_set":11,"id":"7faddb67_bf74f936","line":82,"range":{"start_line":76,"start_character":0,"end_line":82,"end_character":86},"updated":"2019-08-06 17:20:26.000000000","message":"The logic here isn\u0027t quite right. We need to only include docker_registry if docker_registry_insecure is true. It will also keep appending to existing each time it is run. How about:\n\n- name: ...\n  vars:\n    registries: [\"{{ docker_registry }}\"]\n  set_fact:\n    docker_config: \"{{ docker_config | combine({\u0027insecure-registries\u0027: registries}) }}\"\n  when: docker_registry_insecure | bool","commit_id":"e1283d0a29e40e12be6f8137ab757c9cd5013bb9"},{"author":{"_account_id":24072,"name":"Marcin Juszkiewicz","email":"mjuszkiewicz@redhat.com","username":"hrw"},"change_message_id":"20ddb4c643ff3f9fed142ab129ddd1750fabc361","unresolved":false,"context_lines":[{"line_number":73,"context_line":"    file: /etc/docker/daemon.json"},{"line_number":74,"context_line":"    name: docker_config"},{"line_number":75,"context_line":""},{"line_number":76,"context_line":"- name: get configured insecure registries"},{"line_number":77,"context_line":"  vars:"},{"line_number":78,"context_line":"    registries: [\"{{docker_registry}}\"]"},{"line_number":79,"context_line":"  set_fact:"},{"line_number":80,"context_line":"    registries: \"{{registries + [item]}}\""},{"line_number":81,"context_line":"  with_items: \"{{docker_config[\u0027insecure-registries\u0027]|list}}\""},{"line_number":82,"context_line":"  when: docker_registry is defined and docker_config[\u0027insecure-registries\u0027] is defined"},{"line_number":83,"context_line":""},{"line_number":84,"context_line":"- name: setup docker registries"},{"line_number":85,"context_line":"  set_fact:"}],"source_content_type":"text/x-yaml","patch_set":11,"id":"7faddb67_40439214","line":82,"range":{"start_line":76,"start_character":0,"end_line":82,"end_character":86},"in_reply_to":"7faddb67_bf74f936","updated":"2019-08-07 11:53:22.000000000","message":"Done","commit_id":"e1283d0a29e40e12be6f8137ab757c9cd5013bb9"},{"author":{"_account_id":24072,"name":"Marcin Juszkiewicz","email":"mjuszkiewicz@redhat.com","username":"hrw"},"change_message_id":"e35984970e7ba8c0b570dc922065823542d68ad9","unresolved":false,"context_lines":[{"line_number":73,"context_line":"    file: /etc/docker/daemon.json"},{"line_number":74,"context_line":"    name: docker_config"},{"line_number":75,"context_line":""},{"line_number":76,"context_line":"- name: get configured insecure registries"},{"line_number":77,"context_line":"  vars:"},{"line_number":78,"context_line":"    registries: [\"{{docker_registry}}\"]"},{"line_number":79,"context_line":"  set_fact:"},{"line_number":80,"context_line":"    registries: \"{{registries + [item]}}\""},{"line_number":81,"context_line":"  with_items: \"{{docker_config[\u0027insecure-registries\u0027]|list}}\""},{"line_number":82,"context_line":"  when: docker_registry is defined and docker_config[\u0027insecure-registries\u0027] is defined"},{"line_number":83,"context_line":""},{"line_number":84,"context_line":"- name: setup docker registries"},{"line_number":85,"context_line":"  set_fact:"}],"source_content_type":"text/x-yaml","patch_set":11,"id":"7faddb67_201f765c","line":82,"range":{"start_line":76,"start_character":0,"end_line":82,"end_character":86},"in_reply_to":"7faddb67_bf74f936","updated":"2019-08-07 11:52:11.000000000","message":"What if system require one already?\n\nBut sure, we may just overwrite.","commit_id":"e1283d0a29e40e12be6f8137ab757c9cd5013bb9"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"be5960de2906a73878c8967093074ef1124b971d","unresolved":false,"context_lines":[{"line_number":89,"context_line":"- name: setup docker storage driver"},{"line_number":90,"context_line":"  set_fact:"},{"line_number":91,"context_line":"    docker_config: \"{{ docker_config | combine({\u0027storage-driver\u0027: docker_storage_driver}) }}\""},{"line_number":92,"context_line":"  when: docker_storage_driver is defined"},{"line_number":93,"context_line":""},{"line_number":94,"context_line":"- name: setup docker logs"},{"line_number":95,"context_line":"  vars:"}],"source_content_type":"text/x-yaml","patch_set":11,"id":"7faddb67_bfa9597c","line":92,"range":{"start_line":92,"start_character":30,"end_line":92,"end_character":40},"updated":"2019-08-06 17:20:26.000000000","message":"remove: variable is always defined","commit_id":"e1283d0a29e40e12be6f8137ab757c9cd5013bb9"},{"author":{"_account_id":24072,"name":"Marcin Juszkiewicz","email":"mjuszkiewicz@redhat.com","username":"hrw"},"change_message_id":"20ddb4c643ff3f9fed142ab129ddd1750fabc361","unresolved":false,"context_lines":[{"line_number":89,"context_line":"- name: setup docker storage driver"},{"line_number":90,"context_line":"  set_fact:"},{"line_number":91,"context_line":"    docker_config: \"{{ docker_config | combine({\u0027storage-driver\u0027: docker_storage_driver}) }}\""},{"line_number":92,"context_line":"  when: docker_storage_driver is defined"},{"line_number":93,"context_line":""},{"line_number":94,"context_line":"- name: setup docker logs"},{"line_number":95,"context_line":"  vars:"}],"source_content_type":"text/x-yaml","patch_set":11,"id":"7faddb67_80398aa4","line":92,"range":{"start_line":92,"start_character":30,"end_line":92,"end_character":40},"in_reply_to":"7faddb67_bfa9597c","updated":"2019-08-07 11:53:22.000000000","message":"Done","commit_id":"e1283d0a29e40e12be6f8137ab757c9cd5013bb9"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"be5960de2906a73878c8967093074ef1124b971d","unresolved":false,"context_lines":[{"line_number":93,"context_line":""},{"line_number":94,"context_line":"- name: setup docker logs"},{"line_number":95,"context_line":"  vars:"},{"line_number":96,"context_line":"    docker_log_opts: { \"max-file\": \"5\", \"max-size\": \"50m\" }"},{"line_number":97,"context_line":"  set_fact:"},{"line_number":98,"context_line":"    docker_config: \"{{ docker_config | combine({\u0027log-opts\u0027: docker_log_opts}) }}\""},{"line_number":99,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":11,"id":"7faddb67_7f076183","line":96,"updated":"2019-08-06 17:20:26.000000000","message":"docker_log_max_file and docker_log_max_size","commit_id":"e1283d0a29e40e12be6f8137ab757c9cd5013bb9"},{"author":{"_account_id":24072,"name":"Marcin Juszkiewicz","email":"mjuszkiewicz@redhat.com","username":"hrw"},"change_message_id":"e35984970e7ba8c0b570dc922065823542d68ad9","unresolved":false,"context_lines":[{"line_number":93,"context_line":""},{"line_number":94,"context_line":"- name: setup docker logs"},{"line_number":95,"context_line":"  vars:"},{"line_number":96,"context_line":"    docker_log_opts: { \"max-file\": \"5\", \"max-size\": \"50m\" }"},{"line_number":97,"context_line":"  set_fact:"},{"line_number":98,"context_line":"    docker_config: \"{{ docker_config | combine({\u0027log-opts\u0027: docker_log_opts}) }}\""},{"line_number":99,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":11,"id":"7faddb67_2006961e","line":96,"in_reply_to":"7faddb67_7f076183","updated":"2019-08-07 11:52:11.000000000","message":"Done","commit_id":"e1283d0a29e40e12be6f8137ab757c9cd5013bb9"},{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"60c40845dd021b966fe4adfc1c9351a92d6af090","unresolved":false,"context_lines":[{"line_number":92,"context_line":""},{"line_number":93,"context_line":"- name: Configure docker service"},{"line_number":94,"context_line":"  become: True"},{"line_number":95,"context_line":"  file:"},{"line_number":96,"context_line":"    src: /etc/systemd/system/docker.service.d/kolla.conf"},{"line_number":97,"context_line":"    state: absent"},{"line_number":98,"context_line":"  copy:"},{"line_number":99,"context_line":"    content: \"{{ docker_config | to_nice_json }}\""},{"line_number":100,"context_line":"    dest: /etc/docker/daemon.json"},{"line_number":101,"context_line":"    mode: 0644"},{"line_number":102,"context_line":"  register: docker_configured"},{"line_number":103,"context_line":""},{"line_number":104,"context_line":"- name: Reload docker service file"}],"source_content_type":"text/x-yaml","patch_set":12,"id":"7faddb67_00f35ae9","line":101,"range":{"start_line":95,"start_character":0,"end_line":101,"end_character":14},"updated":"2019-08-07 11:55:41.000000000","message":"two modules at once?","commit_id":"673a3af0e1745f320d18bce5547ce5a8726e4465"},{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"9575544c93bd0e40ef60ad527d2da691ad1c16a3","unresolved":false,"context_lines":[{"line_number":77,"context_line":"    registries: [\"{{docker_registry}}\"]"},{"line_number":78,"context_line":"  set_fact:"},{"line_number":79,"context_line":"    docker_config: \"{{ docker_config | combine({\u0027insecure-registries\u0027: registries}) }}\""},{"line_number":80,"context_line":"  when: docker_registry_insecure"},{"line_number":81,"context_line":""},{"line_number":82,"context_line":"- name: setup docker storage driver"},{"line_number":83,"context_line":"  set_fact:"}],"source_content_type":"text/x-yaml","patch_set":15,"id":"7faddb67_9078f98f","line":80,"range":{"start_line":80,"start_character":8,"end_line":80,"end_character":32},"updated":"2019-08-07 14:10:18.000000000","message":"| bool","commit_id":"338957d4e1860ae2ead3866b75524319316b3e5c"},{"author":{"_account_id":24072,"name":"Marcin Juszkiewicz","email":"mjuszkiewicz@redhat.com","username":"hrw"},"change_message_id":"992983072c3ebd3a5b1fda2f1009ccd685c6119e","unresolved":false,"context_lines":[{"line_number":77,"context_line":"    registries: [\"{{docker_registry}}\"]"},{"line_number":78,"context_line":"  set_fact:"},{"line_number":79,"context_line":"    docker_config: \"{{ docker_config | combine({\u0027insecure-registries\u0027: registries}) }}\""},{"line_number":80,"context_line":"  when: docker_registry_insecure"},{"line_number":81,"context_line":""},{"line_number":82,"context_line":"- name: setup docker storage driver"},{"line_number":83,"context_line":"  set_fact:"}],"source_content_type":"text/x-yaml","patch_set":15,"id":"7faddb67_b0d735ef","line":80,"range":{"start_line":80,"start_character":8,"end_line":80,"end_character":32},"in_reply_to":"7faddb67_9078f98f","updated":"2019-08-07 14:36:43.000000000","message":"Done","commit_id":"338957d4e1860ae2ead3866b75524319316b3e5c"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"5cb6dde88384bbfff0c76a503ff9775ba2123fd0","unresolved":false,"context_lines":[{"line_number":69,"context_line":"- name: read docker config"},{"line_number":70,"context_line":"  include_vars:"},{"line_number":71,"context_line":"    file: /etc/docker/daemon.json"},{"line_number":72,"context_line":"    name: docker_config"},{"line_number":73,"context_line":"  when: daemon_json.stat.exists"},{"line_number":74,"context_line":""},{"line_number":75,"context_line":"- name: setup docker registries"}],"source_content_type":"text/x-yaml","patch_set":17,"id":"7faddb67_1e540c21","line":72,"range":{"start_line":72,"start_character":10,"end_line":72,"end_character":23},"updated":"2019-08-08 09:51:32.000000000","message":"If a user sets docker_config, it will override this. How about passing in user defined config via docker_custom_config, then \u0027combine\u0027 at the end with docker_config to ensure highest priority of custom config.","commit_id":"ebfddc42a470864b6b6fac103ced03f1209ccdf6"},{"author":{"_account_id":24072,"name":"Marcin Juszkiewicz","email":"mjuszkiewicz@redhat.com","username":"hrw"},"change_message_id":"2d10abf0ba16f6ab48d8f4ed5a7d7e625a608590","unresolved":false,"context_lines":[{"line_number":69,"context_line":"- name: read docker config"},{"line_number":70,"context_line":"  include_vars:"},{"line_number":71,"context_line":"    file: /etc/docker/daemon.json"},{"line_number":72,"context_line":"    name: docker_config"},{"line_number":73,"context_line":"  when: daemon_json.stat.exists"},{"line_number":74,"context_line":""},{"line_number":75,"context_line":"- name: setup docker registries"}],"source_content_type":"text/x-yaml","patch_set":17,"id":"7faddb67_516ef596","line":72,"range":{"start_line":72,"start_character":10,"end_line":72,"end_character":23},"in_reply_to":"7faddb67_1e540c21","updated":"2019-08-08 10:36:34.000000000","message":"Done","commit_id":"ebfddc42a470864b6b6fac103ced03f1209ccdf6"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"5cb6dde88384bbfff0c76a503ff9775ba2123fd0","unresolved":false,"context_lines":[{"line_number":95,"context_line":"  set_fact:"},{"line_number":96,"context_line":"    docker_config: \"{{ docker_config | combine({\u0027log-opts\u0027: docker_log_opts}) }}\""},{"line_number":97,"context_line":""},{"line_number":98,"context_line":"- name: Remove old docker options file"},{"line_number":99,"context_line":"  become: True"},{"line_number":100,"context_line":"  file:"},{"line_number":101,"context_line":"    path: /etc/systemd/system/docker.service.d/kolla.conf"},{"line_number":102,"context_line":"    state: absent"},{"line_number":103,"context_line":""},{"line_number":104,"context_line":"- name: Configure docker service"},{"line_number":105,"context_line":"  become: True"}],"source_content_type":"text/x-yaml","patch_set":17,"id":"7faddb67_3e0b082c","line":102,"range":{"start_line":98,"start_character":0,"end_line":102,"end_character":17},"updated":"2019-08-08 09:51:32.000000000","message":"Will systemd automatically pick up this change, or do we need a daemon-reload if this task changes?","commit_id":"ebfddc42a470864b6b6fac103ced03f1209ccdf6"},{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"c3b5fc4809c5b5302a606e2accd720d770f0e14a","unresolved":false,"context_lines":[{"line_number":95,"context_line":"  set_fact:"},{"line_number":96,"context_line":"    docker_config: \"{{ docker_config | combine({\u0027log-opts\u0027: docker_log_opts}) }}\""},{"line_number":97,"context_line":""},{"line_number":98,"context_line":"- name: Remove old docker options file"},{"line_number":99,"context_line":"  become: True"},{"line_number":100,"context_line":"  file:"},{"line_number":101,"context_line":"    path: /etc/systemd/system/docker.service.d/kolla.conf"},{"line_number":102,"context_line":"    state: absent"},{"line_number":103,"context_line":""},{"line_number":104,"context_line":"- name: Configure docker service"},{"line_number":105,"context_line":"  become: True"}],"source_content_type":"text/x-yaml","patch_set":17,"id":"7faddb67_d19d05bc","line":102,"range":{"start_line":98,"start_character":0,"end_line":102,"end_character":17},"in_reply_to":"7faddb67_3e0b082c","updated":"2019-08-08 09:54:48.000000000","message":"It is reloaded in the task after the next one.","commit_id":"ebfddc42a470864b6b6fac103ced03f1209ccdf6"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"3e13451e7b24c396090f40bc2d68fe22e44f5c94","unresolved":false,"context_lines":[{"line_number":95,"context_line":"  set_fact:"},{"line_number":96,"context_line":"    docker_config: \"{{ docker_config | combine({\u0027log-opts\u0027: docker_log_opts}) }}\""},{"line_number":97,"context_line":""},{"line_number":98,"context_line":"- name: Remove old docker options file"},{"line_number":99,"context_line":"  become: True"},{"line_number":100,"context_line":"  file:"},{"line_number":101,"context_line":"    path: /etc/systemd/system/docker.service.d/kolla.conf"},{"line_number":102,"context_line":"    state: absent"},{"line_number":103,"context_line":""},{"line_number":104,"context_line":"- name: Configure docker service"},{"line_number":105,"context_line":"  become: True"}],"source_content_type":"text/x-yaml","patch_set":17,"id":"7faddb67_b15de9ed","line":102,"range":{"start_line":98,"start_character":0,"end_line":102,"end_character":17},"in_reply_to":"7faddb67_d19d05bc","updated":"2019-08-08 10:08:42.000000000","message":"Thanks","commit_id":"ebfddc42a470864b6b6fac103ced03f1209ccdf6"},{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"ed3422ac83765fb61facb59779fecd520d27b15d","unresolved":false,"context_lines":[{"line_number":61,"context_line":"    state: directory"},{"line_number":62,"context_line":"  become: True"},{"line_number":63,"context_line":""},{"line_number":64,"context_line":"- name: check if docker config file exists"},{"line_number":65,"context_line":"  stat:"},{"line_number":66,"context_line":"    path: /etc/docker/daemon.json"},{"line_number":67,"context_line":"  register: daemon_json"},{"line_number":68,"context_line":""},{"line_number":69,"context_line":"- name: read docker config"},{"line_number":70,"context_line":"  include_vars:"}],"source_content_type":"text/x-yaml","patch_set":21,"id":"7faddb67_adf025ff","line":67,"range":{"start_line":64,"start_character":0,"end_line":67,"end_character":23},"updated":"2019-08-08 15:13:10.000000000","message":"relying on current content may limit our reproducibility and upgradability","commit_id":"c675d4ff995ff88c3b1f81059227658cfb05ca73"},{"author":{"_account_id":24072,"name":"Marcin Juszkiewicz","email":"mjuszkiewicz@redhat.com","username":"hrw"},"change_message_id":"c0c1aa6ed33695b0cc401e5f5d58f3031de16e23","unresolved":false,"context_lines":[{"line_number":61,"context_line":"    state: directory"},{"line_number":62,"context_line":"  become: True"},{"line_number":63,"context_line":""},{"line_number":64,"context_line":"- name: check if docker config file exists"},{"line_number":65,"context_line":"  stat:"},{"line_number":66,"context_line":"    path: /etc/docker/daemon.json"},{"line_number":67,"context_line":"  register: daemon_json"},{"line_number":68,"context_line":""},{"line_number":69,"context_line":"- name: read docker config"},{"line_number":70,"context_line":"  include_vars:"}],"source_content_type":"text/x-yaml","patch_set":21,"id":"7faddb67_acced558","line":67,"range":{"start_line":64,"start_character":0,"end_line":67,"end_character":23},"in_reply_to":"7faddb67_3e053d15","updated":"2019-08-09 13:39:28.000000000","message":"Done","commit_id":"c675d4ff995ff88c3b1f81059227658cfb05ca73"},{"author":{"_account_id":24072,"name":"Marcin Juszkiewicz","email":"mjuszkiewicz@redhat.com","username":"hrw"},"change_message_id":"1e21a1195beac98d2503ba55b918278ad43d1a7a","unresolved":false,"context_lines":[{"line_number":61,"context_line":"    state: directory"},{"line_number":62,"context_line":"  become: True"},{"line_number":63,"context_line":""},{"line_number":64,"context_line":"- name: check if docker config file exists"},{"line_number":65,"context_line":"  stat:"},{"line_number":66,"context_line":"    path: /etc/docker/daemon.json"},{"line_number":67,"context_line":"  register: daemon_json"},{"line_number":68,"context_line":""},{"line_number":69,"context_line":"- name: read docker config"},{"line_number":70,"context_line":"  include_vars:"}],"source_content_type":"text/x-yaml","patch_set":21,"id":"7faddb67_de43c912","line":67,"range":{"start_line":64,"start_character":0,"end_line":67,"end_character":23},"in_reply_to":"7faddb67_adf025ff","updated":"2019-08-08 17:27:21.000000000","message":"Previously we did not even checked what is there. So I think that we follow what was before.","commit_id":"c675d4ff995ff88c3b1f81059227658cfb05ca73"},{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"e7cf0ec9ad4bd9c3f8d5a23d3ff300b1885e1e38","unresolved":false,"context_lines":[{"line_number":61,"context_line":"    state: directory"},{"line_number":62,"context_line":"  become: True"},{"line_number":63,"context_line":""},{"line_number":64,"context_line":"- name: check if docker config file exists"},{"line_number":65,"context_line":"  stat:"},{"line_number":66,"context_line":"    path: /etc/docker/daemon.json"},{"line_number":67,"context_line":"  register: daemon_json"},{"line_number":68,"context_line":""},{"line_number":69,"context_line":"- name: read docker config"},{"line_number":70,"context_line":"  include_vars:"}],"source_content_type":"text/x-yaml","patch_set":21,"id":"7faddb67_3e053d15","line":67,"range":{"start_line":64,"start_character":0,"end_line":67,"end_character":23},"in_reply_to":"7faddb67_de43c912","updated":"2019-08-08 17:50:56.000000000","message":"I think it would be best to just control this file rather than merge with some arbitrary config. We are introducing this feature now.","commit_id":"c675d4ff995ff88c3b1f81059227658cfb05ca73"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"6df9762557521f6a9749ecbf40f82323873e27e3","unresolved":false,"context_lines":[{"line_number":75,"context_line":"- name: merge custom docker config"},{"line_number":76,"context_line":"  set_fact:"},{"line_number":77,"context_line":"    docker_config: \"{{ docker_config | combine(docker_custom_config) }}\""},{"line_number":78,"context_line":"  when: docker_custom_config_used | bool"},{"line_number":79,"context_line":""},{"line_number":80,"context_line":"- name: setup docker registries"},{"line_number":81,"context_line":"  vars:"}],"source_content_type":"text/x-yaml","patch_set":22,"id":"7faddb67_f8380fef","line":78,"range":{"start_line":78,"start_character":2,"end_line":78,"end_character":40},"updated":"2019-08-09 09:29:28.000000000","message":"Condition not necessary - combine with an empty dict works","commit_id":"0116057d2abe9683fe351e04f2e0aa9461a30e22"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"6df9762557521f6a9749ecbf40f82323873e27e3","unresolved":false,"context_lines":[{"line_number":72,"context_line":"    name: docker_config"},{"line_number":73,"context_line":"  when: daemon_json.stat.exists"},{"line_number":74,"context_line":""},{"line_number":75,"context_line":"- name: merge custom docker config"},{"line_number":76,"context_line":"  set_fact:"},{"line_number":77,"context_line":"    docker_config: \"{{ docker_config | combine(docker_custom_config) }}\""},{"line_number":78,"context_line":"  when: docker_custom_config_used | bool"},{"line_number":79,"context_line":""},{"line_number":80,"context_line":"- name: setup docker registries"},{"line_number":81,"context_line":"  vars:"}],"source_content_type":"text/x-yaml","patch_set":22,"id":"7faddb67_98023b0b","line":78,"range":{"start_line":75,"start_character":0,"end_line":78,"end_character":40},"updated":"2019-08-09 09:29:28.000000000","message":"This task should be last to ensure it overrides other options.","commit_id":"0116057d2abe9683fe351e04f2e0aa9461a30e22"},{"author":{"_account_id":24072,"name":"Marcin Juszkiewicz","email":"mjuszkiewicz@redhat.com","username":"hrw"},"change_message_id":"c0c1aa6ed33695b0cc401e5f5d58f3031de16e23","unresolved":false,"context_lines":[{"line_number":72,"context_line":"    name: docker_config"},{"line_number":73,"context_line":"  when: daemon_json.stat.exists"},{"line_number":74,"context_line":""},{"line_number":75,"context_line":"- name: merge custom docker config"},{"line_number":76,"context_line":"  set_fact:"},{"line_number":77,"context_line":"    docker_config: \"{{ docker_config | combine(docker_custom_config) }}\""},{"line_number":78,"context_line":"  when: docker_custom_config_used | bool"},{"line_number":79,"context_line":""},{"line_number":80,"context_line":"- name: setup docker registries"},{"line_number":81,"context_line":"  vars:"}],"source_content_type":"text/x-yaml","patch_set":22,"id":"7faddb67_a75d8e49","line":78,"range":{"start_line":75,"start_character":0,"end_line":78,"end_character":40},"in_reply_to":"7faddb67_98023b0b","updated":"2019-08-09 13:39:28.000000000","message":"Prefer first to encourage users to use docker_* variables","commit_id":"0116057d2abe9683fe351e04f2e0aa9461a30e22"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"84f54d42137cd8ea7cbb497815f4a7d84b38a7d3","unresolved":false,"context_lines":[{"line_number":72,"context_line":"    name: docker_config"},{"line_number":73,"context_line":"  when: daemon_json.stat.exists"},{"line_number":74,"context_line":""},{"line_number":75,"context_line":"- name: merge custom docker config"},{"line_number":76,"context_line":"  set_fact:"},{"line_number":77,"context_line":"    docker_config: \"{{ docker_config | combine(docker_custom_config) }}\""},{"line_number":78,"context_line":"  when: docker_custom_config_used | bool"},{"line_number":79,"context_line":""},{"line_number":80,"context_line":"- name: setup docker registries"},{"line_number":81,"context_line":"  vars:"}],"source_content_type":"text/x-yaml","patch_set":22,"id":"7faddb67_f8977d39","line":78,"range":{"start_line":75,"start_character":0,"end_line":78,"end_character":40},"in_reply_to":"7faddb67_a75d8e49","updated":"2019-08-13 08:55:22.000000000","message":"Users will do what they want. If you put it last, then at least it will work either way. Plus it saves a task - you don\u0027t need to get then set the registries - it\u0027s already quite a few tasks for just one config file.","commit_id":"0116057d2abe9683fe351e04f2e0aa9461a30e22"},{"author":{"_account_id":24072,"name":"Marcin Juszkiewicz","email":"mjuszkiewicz@redhat.com","username":"hrw"},"change_message_id":"c0c1aa6ed33695b0cc401e5f5d58f3031de16e23","unresolved":false,"context_lines":[{"line_number":75,"context_line":"- name: merge custom docker config"},{"line_number":76,"context_line":"  set_fact:"},{"line_number":77,"context_line":"    docker_config: \"{{ docker_config | combine(docker_custom_config) }}\""},{"line_number":78,"context_line":"  when: docker_custom_config_used | bool"},{"line_number":79,"context_line":""},{"line_number":80,"context_line":"- name: setup docker registries"},{"line_number":81,"context_line":"  vars:"}],"source_content_type":"text/x-yaml","patch_set":22,"id":"7faddb67_677eb6b0","line":78,"range":{"start_line":78,"start_character":2,"end_line":78,"end_character":40},"in_reply_to":"7faddb67_f8380fef","updated":"2019-08-09 13:39:28.000000000","message":"Done","commit_id":"0116057d2abe9683fe351e04f2e0aa9461a30e22"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"6df9762557521f6a9749ecbf40f82323873e27e3","unresolved":false,"context_lines":[{"line_number":100,"context_line":"  set_fact:"},{"line_number":101,"context_line":"    docker_config: \"{{ docker_config | combine({\u0027log-opts\u0027: docker_log_opts}) }}\""},{"line_number":102,"context_line":""},{"line_number":103,"context_line":"- name: get insecure registries from docker_custom_config"},{"line_number":104,"context_line":"  set_fact:"},{"line_number":105,"context_line":"    registries: \"{{ registries + [item] }}\""},{"line_number":106,"context_line":"  with_items: \"{{ docker_custom_config[\u0027insecure-registries\u0027] }}\""},{"line_number":107,"context_line":"  when:"},{"line_number":108,"context_line":"    - docker_custom_config_used | bool"},{"line_number":109,"context_line":"    - docker_custom_config[\u0027insecure-registries\u0027] is defined"},{"line_number":110,"context_line":""},{"line_number":111,"context_line":"- name: setup custom docker registries"},{"line_number":112,"context_line":"  set_fact:"},{"line_number":113,"context_line":"    docker_config: \"{{ docker_config | combine({\u0027insecure-registries\u0027: registries}) }}\""},{"line_number":114,"context_line":"  when:"},{"line_number":115,"context_line":"    - docker_custom_config_used | bool"},{"line_number":116,"context_line":"    - docker_custom_config[\u0027insecure-registries\u0027] is defined"},{"line_number":117,"context_line":""},{"line_number":118,"context_line":"- name: Remove old docker options file"},{"line_number":119,"context_line":"  become: True"}],"source_content_type":"text/x-yaml","patch_set":22,"id":"7faddb67_d808b32e","line":116,"range":{"start_line":103,"start_character":0,"end_line":116,"end_character":60},"updated":"2019-08-09 09:29:28.000000000","message":"Isn\u0027t this covered by \"merge custom docker config\"?","commit_id":"0116057d2abe9683fe351e04f2e0aa9461a30e22"},{"author":{"_account_id":24072,"name":"Marcin Juszkiewicz","email":"mjuszkiewicz@redhat.com","username":"hrw"},"change_message_id":"c0c1aa6ed33695b0cc401e5f5d58f3031de16e23","unresolved":false,"context_lines":[{"line_number":100,"context_line":"  set_fact:"},{"line_number":101,"context_line":"    docker_config: \"{{ docker_config | combine({\u0027log-opts\u0027: docker_log_opts}) }}\""},{"line_number":102,"context_line":""},{"line_number":103,"context_line":"- name: get insecure registries from docker_custom_config"},{"line_number":104,"context_line":"  set_fact:"},{"line_number":105,"context_line":"    registries: \"{{ registries + [item] }}\""},{"line_number":106,"context_line":"  with_items: \"{{ docker_custom_config[\u0027insecure-registries\u0027] }}\""},{"line_number":107,"context_line":"  when:"},{"line_number":108,"context_line":"    - docker_custom_config_used | bool"},{"line_number":109,"context_line":"    - docker_custom_config[\u0027insecure-registries\u0027] is defined"},{"line_number":110,"context_line":""},{"line_number":111,"context_line":"- name: setup custom docker registries"},{"line_number":112,"context_line":"  set_fact:"},{"line_number":113,"context_line":"    docker_config: \"{{ docker_config | combine({\u0027insecure-registries\u0027: registries}) }}\""},{"line_number":114,"context_line":"  when:"},{"line_number":115,"context_line":"    - docker_custom_config_used | bool"},{"line_number":116,"context_line":"    - docker_custom_config[\u0027insecure-registries\u0027] is defined"},{"line_number":117,"context_line":""},{"line_number":118,"context_line":"- name: Remove old docker options file"},{"line_number":119,"context_line":"  become: True"}],"source_content_type":"text/x-yaml","patch_set":22,"id":"7faddb67_acf7b58c","line":116,"range":{"start_line":103,"start_character":0,"end_line":116,"end_character":60},"in_reply_to":"7faddb67_d808b32e","updated":"2019-08-09 13:39:28.000000000","message":"We merge config, then overwrite insecure registries, storage driver, runtime directory, logs and then add registries from custom config.","commit_id":"0116057d2abe9683fe351e04f2e0aa9461a30e22"},{"author":{"_account_id":16006,"name":"goldyfruit","email":"gaetan.trellu@incloudus.com","username":"goldyfruit"},"change_message_id":"c5b52df8ab427dd7a262a88ba9b49ea6bb7b8789","unresolved":false,"context_lines":[{"line_number":61,"context_line":"    state: directory"},{"line_number":62,"context_line":"  become: True"},{"line_number":63,"context_line":""},{"line_number":64,"context_line":"- name: merge custom docker config"},{"line_number":65,"context_line":"  set_fact:"},{"line_number":66,"context_line":"    docker_config: \"{{ docker_config | combine(docker_custom_config) }}\""},{"line_number":67,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":24,"id":"7faddb67_5c0337bf","line":64,"updated":"2019-08-12 13:33:06.000000000","message":"To have consistency with the other tasks name maybe you could start with an upper case letter.","commit_id":"043d5657f87bacca0a0032dc70f745797caa9864"},{"author":{"_account_id":24072,"name":"Marcin Juszkiewicz","email":"mjuszkiewicz@redhat.com","username":"hrw"},"change_message_id":"c8615cab3ab8818336ab2864095217c725d90d30","unresolved":false,"context_lines":[{"line_number":61,"context_line":"    state: directory"},{"line_number":62,"context_line":"  become: True"},{"line_number":63,"context_line":""},{"line_number":64,"context_line":"- name: merge custom docker config"},{"line_number":65,"context_line":"  set_fact:"},{"line_number":66,"context_line":"    docker_config: \"{{ docker_config | combine(docker_custom_config) }}\""},{"line_number":67,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":24,"id":"7faddb67_5d878ab7","line":64,"in_reply_to":"7faddb67_5c0337bf","updated":"2019-08-14 11:29:25.000000000","message":"Done","commit_id":"043d5657f87bacca0a0032dc70f745797caa9864"},{"author":{"_account_id":16006,"name":"goldyfruit","email":"gaetan.trellu@incloudus.com","username":"goldyfruit"},"change_message_id":"c5b52df8ab427dd7a262a88ba9b49ea6bb7b8789","unresolved":false,"context_lines":[{"line_number":65,"context_line":"  set_fact:"},{"line_number":66,"context_line":"    docker_config: \"{{ docker_config | combine(docker_custom_config) }}\""},{"line_number":67,"context_line":""},{"line_number":68,"context_line":"- name: setup docker registries"},{"line_number":69,"context_line":"  vars:"},{"line_number":70,"context_line":"    registries: [\"{{ docker_registry }}\"]"},{"line_number":71,"context_line":"  set_fact:"}],"source_content_type":"text/x-yaml","patch_set":24,"id":"7faddb67_dcf647d9","line":68,"updated":"2019-08-12 13:33:06.000000000","message":"Same","commit_id":"043d5657f87bacca0a0032dc70f745797caa9864"},{"author":{"_account_id":24072,"name":"Marcin Juszkiewicz","email":"mjuszkiewicz@redhat.com","username":"hrw"},"change_message_id":"c8615cab3ab8818336ab2864095217c725d90d30","unresolved":false,"context_lines":[{"line_number":65,"context_line":"  set_fact:"},{"line_number":66,"context_line":"    docker_config: \"{{ docker_config | combine(docker_custom_config) }}\""},{"line_number":67,"context_line":""},{"line_number":68,"context_line":"- name: setup docker registries"},{"line_number":69,"context_line":"  vars:"},{"line_number":70,"context_line":"    registries: [\"{{ docker_registry }}\"]"},{"line_number":71,"context_line":"  set_fact:"}],"source_content_type":"text/x-yaml","patch_set":24,"id":"7faddb67_1d9112f2","line":68,"in_reply_to":"7faddb67_dcf647d9","updated":"2019-08-14 11:29:25.000000000","message":"Done","commit_id":"043d5657f87bacca0a0032dc70f745797caa9864"},{"author":{"_account_id":16006,"name":"goldyfruit","email":"gaetan.trellu@incloudus.com","username":"goldyfruit"},"change_message_id":"c5b52df8ab427dd7a262a88ba9b49ea6bb7b8789","unresolved":false,"context_lines":[{"line_number":72,"context_line":"    docker_config: \"{{ docker_config | combine({\u0027insecure-registries\u0027: registries}) }}\""},{"line_number":73,"context_line":"  when: docker_registry_insecure | bool"},{"line_number":74,"context_line":""},{"line_number":75,"context_line":"- name: setup docker storage driver"},{"line_number":76,"context_line":"  set_fact:"},{"line_number":77,"context_line":"    docker_config: \"{{ docker_config | combine({\u0027storage-driver\u0027: docker_storage_driver}) }}\""},{"line_number":78,"context_line":"  when: docker_storage_driver"}],"source_content_type":"text/x-yaml","patch_set":24,"id":"7faddb67_fcf1c3df","line":75,"updated":"2019-08-12 13:33:06.000000000","message":"Same","commit_id":"043d5657f87bacca0a0032dc70f745797caa9864"},{"author":{"_account_id":24072,"name":"Marcin Juszkiewicz","email":"mjuszkiewicz@redhat.com","username":"hrw"},"change_message_id":"c8615cab3ab8818336ab2864095217c725d90d30","unresolved":false,"context_lines":[{"line_number":72,"context_line":"    docker_config: \"{{ docker_config | combine({\u0027insecure-registries\u0027: registries}) }}\""},{"line_number":73,"context_line":"  when: docker_registry_insecure | bool"},{"line_number":74,"context_line":""},{"line_number":75,"context_line":"- name: setup docker storage driver"},{"line_number":76,"context_line":"  set_fact:"},{"line_number":77,"context_line":"    docker_config: \"{{ docker_config | combine({\u0027storage-driver\u0027: docker_storage_driver}) }}\""},{"line_number":78,"context_line":"  when: docker_storage_driver"}],"source_content_type":"text/x-yaml","patch_set":24,"id":"7faddb67_7d8286a7","line":75,"in_reply_to":"7faddb67_fcf1c3df","updated":"2019-08-14 11:29:25.000000000","message":"Done","commit_id":"043d5657f87bacca0a0032dc70f745797caa9864"},{"author":{"_account_id":16006,"name":"goldyfruit","email":"gaetan.trellu@incloudus.com","username":"goldyfruit"},"change_message_id":"c5b52df8ab427dd7a262a88ba9b49ea6bb7b8789","unresolved":false,"context_lines":[{"line_number":77,"context_line":"    docker_config: \"{{ docker_config | combine({\u0027storage-driver\u0027: docker_storage_driver}) }}\""},{"line_number":78,"context_line":"  when: docker_storage_driver"},{"line_number":79,"context_line":""},{"line_number":80,"context_line":"- name: setup docker runtime directory"},{"line_number":81,"context_line":"  set_fact:"},{"line_number":82,"context_line":"    docker_config: \"{{ docker_config | combine({\u0027data-root\u0027: docker_runtime_directory}) }}\""},{"line_number":83,"context_line":"  when: docker_runtime_directory"}],"source_content_type":"text/x-yaml","patch_set":24,"id":"7faddb67_bcfb4bbc","line":80,"updated":"2019-08-12 13:33:06.000000000","message":"Same","commit_id":"043d5657f87bacca0a0032dc70f745797caa9864"},{"author":{"_account_id":24072,"name":"Marcin Juszkiewicz","email":"mjuszkiewicz@redhat.com","username":"hrw"},"change_message_id":"c8615cab3ab8818336ab2864095217c725d90d30","unresolved":false,"context_lines":[{"line_number":77,"context_line":"    docker_config: \"{{ docker_config | combine({\u0027storage-driver\u0027: docker_storage_driver}) }}\""},{"line_number":78,"context_line":"  when: docker_storage_driver"},{"line_number":79,"context_line":""},{"line_number":80,"context_line":"- name: setup docker runtime directory"},{"line_number":81,"context_line":"  set_fact:"},{"line_number":82,"context_line":"    docker_config: \"{{ docker_config | combine({\u0027data-root\u0027: docker_runtime_directory}) }}\""},{"line_number":83,"context_line":"  when: docker_runtime_directory"}],"source_content_type":"text/x-yaml","patch_set":24,"id":"7faddb67_fdbf565d","line":80,"in_reply_to":"7faddb67_bcfb4bbc","updated":"2019-08-14 11:29:25.000000000","message":"Done","commit_id":"043d5657f87bacca0a0032dc70f745797caa9864"},{"author":{"_account_id":16006,"name":"goldyfruit","email":"gaetan.trellu@incloudus.com","username":"goldyfruit"},"change_message_id":"c5b52df8ab427dd7a262a88ba9b49ea6bb7b8789","unresolved":false,"context_lines":[{"line_number":82,"context_line":"    docker_config: \"{{ docker_config | combine({\u0027data-root\u0027: docker_runtime_directory}) }}\""},{"line_number":83,"context_line":"  when: docker_runtime_directory"},{"line_number":84,"context_line":""},{"line_number":85,"context_line":"- name: setup docker logs"},{"line_number":86,"context_line":"  vars:"},{"line_number":87,"context_line":"    docker_log_opts: { \"max-file\": \"{{ docker_log_max_file }}\", \"max-size\": \"{{ docker_log_max_size }}\" }"},{"line_number":88,"context_line":"  set_fact:"}],"source_content_type":"text/x-yaml","patch_set":24,"id":"7faddb67_5c2c9749","line":85,"updated":"2019-08-12 13:33:06.000000000","message":"Same","commit_id":"043d5657f87bacca0a0032dc70f745797caa9864"},{"author":{"_account_id":24072,"name":"Marcin Juszkiewicz","email":"mjuszkiewicz@redhat.com","username":"hrw"},"change_message_id":"c8615cab3ab8818336ab2864095217c725d90d30","unresolved":false,"context_lines":[{"line_number":82,"context_line":"    docker_config: \"{{ docker_config | combine({\u0027data-root\u0027: docker_runtime_directory}) }}\""},{"line_number":83,"context_line":"  when: docker_runtime_directory"},{"line_number":84,"context_line":""},{"line_number":85,"context_line":"- name: setup docker logs"},{"line_number":86,"context_line":"  vars:"},{"line_number":87,"context_line":"    docker_log_opts: { \"max-file\": \"{{ docker_log_max_file }}\", \"max-size\": \"{{ docker_log_max_size }}\" }"},{"line_number":88,"context_line":"  set_fact:"}],"source_content_type":"text/x-yaml","patch_set":24,"id":"7faddb67_ddbcda6d","line":85,"in_reply_to":"7faddb67_5c2c9749","updated":"2019-08-14 11:29:25.000000000","message":"Done","commit_id":"043d5657f87bacca0a0032dc70f745797caa9864"},{"author":{"_account_id":16006,"name":"goldyfruit","email":"gaetan.trellu@incloudus.com","username":"goldyfruit"},"change_message_id":"c5b52df8ab427dd7a262a88ba9b49ea6bb7b8789","unresolved":false,"context_lines":[{"line_number":88,"context_line":"  set_fact:"},{"line_number":89,"context_line":"    docker_config: \"{{ docker_config | combine({\u0027log-opts\u0027: docker_log_opts}) }}\""},{"line_number":90,"context_line":""},{"line_number":91,"context_line":"- name: get insecure registries from docker_custom_config"},{"line_number":92,"context_line":"  set_fact:"},{"line_number":93,"context_line":"    registries: \"{{ registries + [item] }}\""},{"line_number":94,"context_line":"  with_items: \"{{ docker_custom_config[\u0027insecure-registries\u0027] }}\""}],"source_content_type":"text/x-yaml","patch_set":24,"id":"7faddb67_1c261f6a","line":91,"updated":"2019-08-12 13:33:06.000000000","message":"Same","commit_id":"043d5657f87bacca0a0032dc70f745797caa9864"},{"author":{"_account_id":24072,"name":"Marcin Juszkiewicz","email":"mjuszkiewicz@redhat.com","username":"hrw"},"change_message_id":"c8615cab3ab8818336ab2864095217c725d90d30","unresolved":false,"context_lines":[{"line_number":88,"context_line":"  set_fact:"},{"line_number":89,"context_line":"    docker_config: \"{{ docker_config | combine({\u0027log-opts\u0027: docker_log_opts}) }}\""},{"line_number":90,"context_line":""},{"line_number":91,"context_line":"- name: get insecure registries from docker_custom_config"},{"line_number":92,"context_line":"  set_fact:"},{"line_number":93,"context_line":"    registries: \"{{ registries + [item] }}\""},{"line_number":94,"context_line":"  with_items: \"{{ docker_custom_config[\u0027insecure-registries\u0027] }}\""}],"source_content_type":"text/x-yaml","patch_set":24,"id":"7faddb67_5db0ea8b","line":91,"in_reply_to":"7faddb67_1c261f6a","updated":"2019-08-14 11:29:25.000000000","message":"Done","commit_id":"043d5657f87bacca0a0032dc70f745797caa9864"},{"author":{"_account_id":16006,"name":"goldyfruit","email":"gaetan.trellu@incloudus.com","username":"goldyfruit"},"change_message_id":"c5b52df8ab427dd7a262a88ba9b49ea6bb7b8789","unresolved":false,"context_lines":[{"line_number":95,"context_line":"  when:"},{"line_number":96,"context_line":"    - docker_custom_config[\u0027insecure-registries\u0027] is defined"},{"line_number":97,"context_line":""},{"line_number":98,"context_line":"- name: setup custom docker registries"},{"line_number":99,"context_line":"  set_fact:"},{"line_number":100,"context_line":"    docker_config: \"{{ docker_config | combine({\u0027insecure-registries\u0027: registries}) }}\""},{"line_number":101,"context_line":"  when:"}],"source_content_type":"text/x-yaml","patch_set":24,"id":"7faddb67_fc1a2316","line":98,"updated":"2019-08-12 13:33:06.000000000","message":"Same","commit_id":"043d5657f87bacca0a0032dc70f745797caa9864"},{"author":{"_account_id":24072,"name":"Marcin Juszkiewicz","email":"mjuszkiewicz@redhat.com","username":"hrw"},"change_message_id":"c8615cab3ab8818336ab2864095217c725d90d30","unresolved":false,"context_lines":[{"line_number":95,"context_line":"  when:"},{"line_number":96,"context_line":"    - docker_custom_config[\u0027insecure-registries\u0027] is defined"},{"line_number":97,"context_line":""},{"line_number":98,"context_line":"- name: setup custom docker registries"},{"line_number":99,"context_line":"  set_fact:"},{"line_number":100,"context_line":"    docker_config: \"{{ docker_config | combine({\u0027insecure-registries\u0027: registries}) }}\""},{"line_number":101,"context_line":"  when:"}],"source_content_type":"text/x-yaml","patch_set":24,"id":"7faddb67_bdb9de79","line":98,"in_reply_to":"7faddb67_fc1a2316","updated":"2019-08-14 11:29:25.000000000","message":"Done","commit_id":"043d5657f87bacca0a0032dc70f745797caa9864"},{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"737a3e39e167c179bb75d85b3998c72ef18e09c9","unresolved":false,"context_lines":[{"line_number":129,"context_line":"  template:"},{"line_number":130,"context_line":"    src: docker_systemd_service.j2"},{"line_number":131,"context_line":"    dest: /etc/systemd/system/docker.service.d/kolla.conf"},{"line_number":132,"context_line":"  register: docker_custom_option_used"},{"line_number":133,"context_line":""},{"line_number":134,"context_line":"- name: Reload docker service file"},{"line_number":135,"context_line":"  become: True"}],"source_content_type":"text/x-yaml","patch_set":24,"id":"7faddb67_800cb539","line":132,"range":{"start_line":132,"start_character":12,"end_line":132,"end_character":37},"updated":"2019-08-14 11:36:59.000000000","message":"docker_custom_option","commit_id":"043d5657f87bacca0a0032dc70f745797caa9864"},{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"737a3e39e167c179bb75d85b3998c72ef18e09c9","unresolved":false,"context_lines":[{"line_number":129,"context_line":"  template:"},{"line_number":130,"context_line":"    src: docker_systemd_service.j2"},{"line_number":131,"context_line":"    dest: /etc/systemd/system/docker.service.d/kolla.conf"},{"line_number":132,"context_line":"  register: docker_custom_option_used"},{"line_number":133,"context_line":""},{"line_number":134,"context_line":"- name: Reload docker service file"},{"line_number":135,"context_line":"  become: True"}],"source_content_type":"text/x-yaml","patch_set":24,"id":"7faddb67_dd613a13","line":132,"range":{"start_line":132,"start_character":2,"end_line":132,"end_character":10},"updated":"2019-08-14 11:36:59.000000000","message":"when","commit_id":"043d5657f87bacca0a0032dc70f745797caa9864"},{"author":{"_account_id":24072,"name":"Marcin Juszkiewicz","email":"mjuszkiewicz@redhat.com","username":"hrw"},"change_message_id":"cc338ca95145f46acd23f0c753e09ebf27a028b7","unresolved":false,"context_lines":[{"line_number":129,"context_line":"  template:"},{"line_number":130,"context_line":"    src: docker_systemd_service.j2"},{"line_number":131,"context_line":"    dest: /etc/systemd/system/docker.service.d/kolla.conf"},{"line_number":132,"context_line":"  register: docker_custom_option_used"},{"line_number":133,"context_line":""},{"line_number":134,"context_line":"- name: Reload docker service file"},{"line_number":135,"context_line":"  become: True"}],"source_content_type":"text/x-yaml","patch_set":24,"id":"7faddb67_606899b9","line":132,"range":{"start_line":132,"start_character":2,"end_line":132,"end_character":10},"in_reply_to":"7faddb67_dd613a13","updated":"2019-08-14 12:08:12.000000000","message":"Done","commit_id":"043d5657f87bacca0a0032dc70f745797caa9864"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"8ed81b1f538f41ac272643edb3f89a621e3aff8a","unresolved":false,"context_lines":[{"line_number":88,"context_line":"  set_fact:"},{"line_number":89,"context_line":"    docker_config: \"{{ docker_config | combine({\u0027log-opts\u0027: docker_log_opts}) }}\""},{"line_number":90,"context_line":""},{"line_number":91,"context_line":"- name: Get insecure registries from docker_custom_config"},{"line_number":92,"context_line":"  set_fact:"},{"line_number":93,"context_line":"    registries: \"{{ registries + [item] }}\""},{"line_number":94,"context_line":"  with_items: \"{{ docker_custom_config[\u0027insecure-registries\u0027] }}\""},{"line_number":95,"context_line":"  when:"},{"line_number":96,"context_line":"    - docker_custom_config[\u0027insecure-registries\u0027] is defined"},{"line_number":97,"context_line":""},{"line_number":98,"context_line":"- name: Setup custom docker registries"},{"line_number":99,"context_line":"  set_fact:"},{"line_number":100,"context_line":"    docker_config: \"{{ docker_config | combine({\u0027insecure-registries\u0027: registries}) }}\""},{"line_number":101,"context_line":"  when:"},{"line_number":102,"context_line":"    - docker_custom_config[\u0027insecure-registries\u0027] is defined"},{"line_number":103,"context_line":""},{"line_number":104,"context_line":"- name: Write docker config"},{"line_number":105,"context_line":"  become: True"}],"source_content_type":"text/x-yaml","patch_set":26,"id":"7faddb67_45c8cf53","line":102,"range":{"start_line":91,"start_character":0,"end_line":102,"end_character":60},"updated":"2019-08-19 11:23:25.000000000","message":"These tasks are unnecessary if you do the merge last. Plus it will be more consistent - why should custom insecure-registries have precedence but storage-driver not?","commit_id":"6e41b058f93e639833dc093f2e6794d363451d62"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"3dd826b2957da43a41df6869819c453e7f1d50ea","unresolved":false,"context_lines":[{"line_number":109,"context_line":"    mode: 0644"},{"line_number":110,"context_line":"  register: docker_configured"},{"line_number":111,"context_line":""},{"line_number":112,"context_line":"- name: Remove old docker options file"},{"line_number":113,"context_line":"  become: True"},{"line_number":114,"context_line":"  file:"},{"line_number":115,"context_line":"    path: /etc/systemd/system/docker.service.d/kolla.conf"},{"line_number":116,"context_line":"    state: absent"},{"line_number":117,"context_line":""},{"line_number":118,"context_line":"- name: Ensure docker service directory exists"},{"line_number":119,"context_line":"  become: True"}],"source_content_type":"text/x-yaml","patch_set":26,"id":"7faddb67_65e2abd6","line":116,"range":{"start_line":112,"start_character":0,"end_line":116,"end_character":17},"updated":"2019-08-19 11:25:16.000000000","message":"when: not docker_custom_option","commit_id":"6e41b058f93e639833dc093f2e6794d363451d62"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"3717d0198cf1f0a5860be84e9122d1250398861b","unresolved":false,"context_lines":[{"line_number":72,"context_line":"    msg: \u003e"},{"line_number":73,"context_line":"      docker_custom_option, docker_storage_driver and docker_runtime_directory"},{"line_number":74,"context_line":"      are deprecated in favor of docker_custom_config"},{"line_number":75,"context_line":"  when: docker_custom_option or docker_storage_driver or docker_runtime_directory"},{"line_number":76,"context_line":""},{"line_number":77,"context_line":"- name: Setup docker insecure registries"},{"line_number":78,"context_line":"  vars:"}],"source_content_type":"text/x-yaml","patch_set":30,"id":"7faddb67_4b6f8ec3","line":75,"range":{"start_line":75,"start_character":32,"end_line":75,"end_character":81},"updated":"2019-09-03 08:45:21.000000000","message":"Hold up, why are we deprecating these? Storage driver in particular. Without it the user needs to go and lookup docker config.","commit_id":"0fe3c2fe4cba58ea2a1c7c109e4692ef2f85e236"},{"author":{"_account_id":24072,"name":"Marcin Juszkiewicz","email":"mjuszkiewicz@redhat.com","username":"hrw"},"change_message_id":"99983b1957147ded33273c08e0b7f387aa8051f3","unresolved":false,"context_lines":[{"line_number":72,"context_line":"    msg: \u003e"},{"line_number":73,"context_line":"      docker_custom_option, docker_storage_driver and docker_runtime_directory"},{"line_number":74,"context_line":"      are deprecated in favor of docker_custom_config"},{"line_number":75,"context_line":"  when: docker_custom_option or docker_storage_driver or docker_runtime_directory"},{"line_number":76,"context_line":""},{"line_number":77,"context_line":"- name: Setup docker insecure registries"},{"line_number":78,"context_line":"  vars:"}],"source_content_type":"text/x-yaml","patch_set":30,"id":"7faddb67_9d64bee6","line":75,"range":{"start_line":75,"start_character":32,"end_line":75,"end_character":81},"in_reply_to":"7faddb67_4b6f8ec3","updated":"2019-09-05 08:17:36.000000000","message":"Radosław added those. Reverted","commit_id":"0fe3c2fe4cba58ea2a1c7c109e4692ef2f85e236"}],"ansible/roles/baremetal/templates/docker_systemd_service.j2":[{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"84f54d42137cd8ea7cbb497815f4a7d84b38a7d3","unresolved":false,"context_lines":[{"line_number":1,"context_line":"[Service]"},{"line_number":2,"context_line":"ExecStart\u003d"},{"line_number":3,"context_line":"ExecStart\u003d/usr/bin/dockerd -H fd:// --containerd\u003d/run/containerd/containerd.sock  {% if docker_custom_option %} {{ docker_custom_option }}{% endif %}"}],"source_content_type":"text/x-jinja2","patch_set":24,"id":"7faddb67_18b4d9d0","line":3,"range":{"start_line":3,"start_character":10,"end_line":3,"end_character":80},"updated":"2019-08-13 08:55:22.000000000","message":"I assume this is from the docker CE package?","commit_id":"043d5657f87bacca0a0032dc70f745797caa9864"},{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"737a3e39e167c179bb75d85b3998c72ef18e09c9","unresolved":false,"context_lines":[{"line_number":1,"context_line":"[Service]"},{"line_number":2,"context_line":"ExecStart\u003d"},{"line_number":3,"context_line":"ExecStart\u003d/usr/bin/dockerd -H fd:// --containerd\u003d/run/containerd/containerd.sock  {% if docker_custom_option %} {{ docker_custom_option }}{% endif %}"}],"source_content_type":"text/x-jinja2","patch_set":24,"id":"7faddb67_bd3c7ee1","line":3,"range":{"start_line":3,"start_character":80,"end_line":3,"end_character":82},"updated":"2019-08-14 11:36:59.000000000","message":"extra spaces","commit_id":"043d5657f87bacca0a0032dc70f745797caa9864"},{"author":{"_account_id":24072,"name":"Marcin Juszkiewicz","email":"mjuszkiewicz@redhat.com","username":"hrw"},"change_message_id":"c8615cab3ab8818336ab2864095217c725d90d30","unresolved":false,"context_lines":[{"line_number":1,"context_line":"[Service]"},{"line_number":2,"context_line":"ExecStart\u003d"},{"line_number":3,"context_line":"ExecStart\u003d/usr/bin/dockerd -H fd:// --containerd\u003d/run/containerd/containerd.sock  {% if docker_custom_option %} {{ docker_custom_option }}{% endif %}"}],"source_content_type":"text/x-jinja2","patch_set":24,"id":"7faddb67_7dab661d","line":3,"range":{"start_line":3,"start_character":10,"end_line":3,"end_character":80},"in_reply_to":"7faddb67_18b4d9d0","updated":"2019-08-14 11:29:25.000000000","message":"Yes. Same on CentOS/Docker/Ubuntu.","commit_id":"043d5657f87bacca0a0032dc70f745797caa9864"},{"author":{"_account_id":24072,"name":"Marcin Juszkiewicz","email":"mjuszkiewicz@redhat.com","username":"hrw"},"change_message_id":"cc338ca95145f46acd23f0c753e09ebf27a028b7","unresolved":false,"context_lines":[{"line_number":1,"context_line":"[Service]"},{"line_number":2,"context_line":"ExecStart\u003d"},{"line_number":3,"context_line":"ExecStart\u003d/usr/bin/dockerd -H fd:// --containerd\u003d/run/containerd/containerd.sock  {% if docker_custom_option %} {{ docker_custom_option }}{% endif %}"}],"source_content_type":"text/x-jinja2","patch_set":24,"id":"7faddb67_405d5d13","line":3,"range":{"start_line":3,"start_character":80,"end_line":3,"end_character":82},"in_reply_to":"7faddb67_bd3c7ee1","updated":"2019-08-14 12:08:12.000000000","message":"Done","commit_id":"043d5657f87bacca0a0032dc70f745797caa9864"},{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"bb95a4c20177592becf19d298c9f4dd08696edcf","unresolved":false,"context_lines":[{"line_number":1,"context_line":"[Service]"},{"line_number":2,"context_line":"ExecStart\u003d"},{"line_number":3,"context_line":"# ExecStart commandline copied from \u0027docker-ce\u0027 package. Same on CentOS/Debian/Ubuntu systems."},{"line_number":4,"context_line":"ExecStart\u003d/usr/bin/dockerd -H fd:// --containerd\u003d/run/containerd/containerd.sock {% if docker_custom_option %} {{ docker_custom_option }}{% endif %}"}],"source_content_type":"text/x-jinja2","patch_set":26,"id":"7faddb67_2aa83776","line":4,"range":{"start_line":4,"start_character":80,"end_line":4,"end_character":81},"updated":"2019-08-14 19:01:22.000000000","message":"nit: still one extra space - it\u0027s handled inside the \u0027if\u0027","commit_id":"6e41b058f93e639833dc093f2e6794d363451d62"}],"doc/source/reference/deployment-and-bootstrapping/bootstrap-servers.rst":[{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"6df9762557521f6a9749ecbf40f82323873e27e3","unresolved":false,"context_lines":[{"line_number":180,"context_line":"``docker_log_max_size`` variable, which defaults to ``50m``, defines the"},{"line_number":181,"context_line":"maximum size of each rotated log file per container."},{"line_number":182,"context_line":""},{"line_number":183,"context_line":"Additional options for the Docker engine can be passed in ``docker_config``"},{"line_number":184,"context_line":"variable. It will be stored in ``daemon.json`` config file."},{"line_number":185,"context_line":""},{"line_number":186,"context_line":"Disabling firewalls"}],"source_content_type":"text/x-rst","patch_set":22,"id":"7faddb67_bb105151","line":183,"updated":"2019-08-09 09:29:28.000000000","message":"custom","commit_id":"0116057d2abe9683fe351e04f2e0aa9461a30e22"},{"author":{"_account_id":24072,"name":"Marcin Juszkiewicz","email":"mjuszkiewicz@redhat.com","username":"hrw"},"change_message_id":"c0c1aa6ed33695b0cc401e5f5d58f3031de16e23","unresolved":false,"context_lines":[{"line_number":180,"context_line":"``docker_log_max_size`` variable, which defaults to ``50m``, defines the"},{"line_number":181,"context_line":"maximum size of each rotated log file per container."},{"line_number":182,"context_line":""},{"line_number":183,"context_line":"Additional options for the Docker engine can be passed in ``docker_config``"},{"line_number":184,"context_line":"variable. It will be stored in ``daemon.json`` config file."},{"line_number":185,"context_line":""},{"line_number":186,"context_line":"Disabling firewalls"}],"source_content_type":"text/x-rst","patch_set":22,"id":"7faddb67_4c98811a","line":183,"in_reply_to":"7faddb67_bb105151","updated":"2019-08-09 13:39:28.000000000","message":"Done","commit_id":"0116057d2abe9683fe351e04f2e0aa9461a30e22"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"6df9762557521f6a9749ecbf40f82323873e27e3","unresolved":false,"context_lines":[{"line_number":181,"context_line":"maximum size of each rotated log file per container."},{"line_number":182,"context_line":""},{"line_number":183,"context_line":"Additional options for the Docker engine can be passed in ``docker_config``"},{"line_number":184,"context_line":"variable. It will be stored in ``daemon.json`` config file."},{"line_number":185,"context_line":""},{"line_number":186,"context_line":"Disabling firewalls"},{"line_number":187,"context_line":"~~~~~~~~~~~~~~~~~~~"}],"source_content_type":"text/x-rst","patch_set":22,"id":"7faddb67_bb67f1ea","line":184,"updated":"2019-08-09 09:29:28.000000000","message":"An example of using this would be good to show the format. Maybe also a link to the config docs: https://docs.docker.com/engine/reference/commandline/dockerd/#daemon-configuration-file","commit_id":"0116057d2abe9683fe351e04f2e0aa9461a30e22"},{"author":{"_account_id":24072,"name":"Marcin Juszkiewicz","email":"mjuszkiewicz@redhat.com","username":"hrw"},"change_message_id":"c0c1aa6ed33695b0cc401e5f5d58f3031de16e23","unresolved":false,"context_lines":[{"line_number":181,"context_line":"maximum size of each rotated log file per container."},{"line_number":182,"context_line":""},{"line_number":183,"context_line":"Additional options for the Docker engine can be passed in ``docker_config``"},{"line_number":184,"context_line":"variable. It will be stored in ``daemon.json`` config file."},{"line_number":185,"context_line":""},{"line_number":186,"context_line":"Disabling firewalls"},{"line_number":187,"context_line":"~~~~~~~~~~~~~~~~~~~"}],"source_content_type":"text/x-rst","patch_set":22,"id":"7faddb67_87541223","line":184,"in_reply_to":"7faddb67_bb67f1ea","updated":"2019-08-09 13:39:28.000000000","message":"Done","commit_id":"0116057d2abe9683fe351e04f2e0aa9461a30e22"}],"releasenotes/notes/custom_option_docker-f5b810a8edce06fa.yaml":[{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"ed3422ac83765fb61facb59779fecd520d27b15d","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Add custom option for docker daemon by configure the docker service. An operator"}],"source_content_type":"text/x-yaml","patch_set":21,"id":"7faddb67_ca16a756","side":"PARENT","line":1,"updated":"2019-08-08 15:13:10.000000000","message":"since when are we deleting releasenotes? :D","commit_id":"ee5e99fcf5110c6bf96aa9939732ff0d9cbcb337"},{"author":{"_account_id":24072,"name":"Marcin Juszkiewicz","email":"mjuszkiewicz@redhat.com","username":"hrw"},"change_message_id":"c0c1aa6ed33695b0cc401e5f5d58f3031de16e23","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Add custom option for docker daemon by configure the docker service. An operator"}],"source_content_type":"text/x-yaml","patch_set":21,"id":"7faddb67_cccb1148","side":"PARENT","line":1,"in_reply_to":"7faddb67_5e291999","updated":"2019-08-09 13:39:28.000000000","message":"Done","commit_id":"ee5e99fcf5110c6bf96aa9939732ff0d9cbcb337"},{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"e7cf0ec9ad4bd9c3f8d5a23d3ff300b1885e1e38","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Add custom option for docker daemon by configure the docker service. An operator"}],"source_content_type":"text/x-yaml","patch_set":21,"id":"7faddb67_5e291999","side":"PARENT","line":1,"in_reply_to":"7faddb67_be1fed59","updated":"2019-08-08 17:50:56.000000000","message":"Releasenotes are sticky afaik.","commit_id":"ee5e99fcf5110c6bf96aa9939732ff0d9cbcb337"},{"author":{"_account_id":24072,"name":"Marcin Juszkiewicz","email":"mjuszkiewicz@redhat.com","username":"hrw"},"change_message_id":"1e21a1195beac98d2503ba55b918278ad43d1a7a","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Add custom option for docker daemon by configure the docker service. An operator"}],"source_content_type":"text/x-yaml","patch_set":21,"id":"7faddb67_be1fed59","side":"PARENT","line":1,"in_reply_to":"7faddb67_ca16a756","updated":"2019-08-08 17:27:21.000000000","message":"When we remove functionality described in it?","commit_id":"ee5e99fcf5110c6bf96aa9939732ff0d9cbcb337"}],"releasenotes/notes/docker-daemon.json-33d7618aa5a355a8.yaml":[{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"ed3422ac83765fb61facb59779fecd520d27b15d","unresolved":false,"context_lines":[{"line_number":8,"context_line":"  - |"},{"line_number":9,"context_line":"    Docker engine configuration changes are now done in"},{"line_number":10,"context_line":"    \"/etc/docker/daemon.json\" file instead of altering systemd unit (which"},{"line_number":11,"context_line":"    gets removed if present)."}],"source_content_type":"text/x-yaml","patch_set":21,"id":"7faddb67_4a02b70d","line":11,"updated":"2019-08-08 15:13:10.000000000","message":"Mention previous option gone and being replaced by above.","commit_id":"c675d4ff995ff88c3b1f81059227658cfb05ca73"},{"author":{"_account_id":24072,"name":"Marcin Juszkiewicz","email":"mjuszkiewicz@redhat.com","username":"hrw"},"change_message_id":"1e21a1195beac98d2503ba55b918278ad43d1a7a","unresolved":false,"context_lines":[{"line_number":8,"context_line":"  - |"},{"line_number":9,"context_line":"    Docker engine configuration changes are now done in"},{"line_number":10,"context_line":"    \"/etc/docker/daemon.json\" file instead of altering systemd unit (which"},{"line_number":11,"context_line":"    gets removed if present)."}],"source_content_type":"text/x-yaml","patch_set":21,"id":"7faddb67_7ef655db","line":11,"in_reply_to":"7faddb67_4a02b70d","updated":"2019-08-08 17:27:21.000000000","message":"Done","commit_id":"c675d4ff995ff88c3b1f81059227658cfb05ca73"},{"author":{"_account_id":24072,"name":"Marcin Juszkiewicz","email":"mjuszkiewicz@redhat.com","username":"hrw"},"change_message_id":"27426546c113a984b7659a656100023f299637a3","unresolved":false,"context_lines":[{"line_number":13,"context_line":""},{"line_number":14,"context_line":"deprecations:"},{"line_number":15,"context_line":"  - |"},{"line_number":16,"context_line":"\t\tConfiguring Docker daemon by \"docker_custom_option\" (used in systemd unit"},{"line_number":17,"context_line":"\t\tfile) is deprecated in favour of \"docker_custom_config\" variable (stored in"},{"line_number":18,"context_line":"\t\t\"daemon.json\" config file."}],"source_content_type":"text/x-yaml","patch_set":23,"id":"7faddb67_32fd5e08","line":18,"range":{"start_line":16,"start_character":0,"end_line":18,"end_character":28},"updated":"2019-08-09 13:47:27.000000000","message":"will remove tabs in next version","commit_id":"eff205c50f3cd84fd73774da87835e156f5ddc5c"}],"tests/templates/globals-default.j2":[{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"ed3422ac83765fb61facb59779fecd520d27b15d","unresolved":false,"context_lines":[{"line_number":25,"context_line":"# use docker hub images"},{"line_number":26,"context_line":"docker_namespace: \"kolla\""},{"line_number":27,"context_line":"{% if need_build_image and is_previous_release %}"},{"line_number":28,"context_line":"# NOTE(mgoddard): Ensure that the insecure local registry is trusted, since it"},{"line_number":29,"context_line":"# will be the source of images during the upgrade."},{"line_number":30,"context_line":"# NOTE(yoctozepto): this is required here for CI because we run templating"},{"line_number":31,"context_line":"# of docker systemd command only once, using the previous release when upgrading"},{"line_number":32,"context_line":"# also note: atm upgrade would conflict with the zun profile which uses this var"}],"source_content_type":"text/x-jinja2","patch_set":21,"id":"7faddb67_0d2b7982","line":29,"range":{"start_line":28,"start_character":0,"end_line":29,"end_character":50},"updated":"2019-08-08 15:13:10.000000000","message":"this is imprecise now","commit_id":"c675d4ff995ff88c3b1f81059227658cfb05ca73"},{"author":{"_account_id":24072,"name":"Marcin Juszkiewicz","email":"mjuszkiewicz@redhat.com","username":"hrw"},"change_message_id":"1e21a1195beac98d2503ba55b918278ad43d1a7a","unresolved":false,"context_lines":[{"line_number":25,"context_line":"# use docker hub images"},{"line_number":26,"context_line":"docker_namespace: \"kolla\""},{"line_number":27,"context_line":"{% if need_build_image and is_previous_release %}"},{"line_number":28,"context_line":"# NOTE(mgoddard): Ensure that the insecure local registry is trusted, since it"},{"line_number":29,"context_line":"# will be the source of images during the upgrade."},{"line_number":30,"context_line":"# NOTE(yoctozepto): this is required here for CI because we run templating"},{"line_number":31,"context_line":"# of docker systemd command only once, using the previous release when upgrading"},{"line_number":32,"context_line":"# also note: atm upgrade would conflict with the zun profile which uses this var"}],"source_content_type":"text/x-jinja2","patch_set":21,"id":"7faddb67_fe87a511","line":29,"range":{"start_line":28,"start_character":0,"end_line":29,"end_character":50},"in_reply_to":"7faddb67_0d2b7982","updated":"2019-08-08 17:27:21.000000000","message":"it does exactly same thing now","commit_id":"c675d4ff995ff88c3b1f81059227658cfb05ca73"},{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"ed3422ac83765fb61facb59779fecd520d27b15d","unresolved":false,"context_lines":[{"line_number":27,"context_line":"{% if need_build_image and is_previous_release %}"},{"line_number":28,"context_line":"# NOTE(mgoddard): Ensure that the insecure local registry is trusted, since it"},{"line_number":29,"context_line":"# will be the source of images during the upgrade."},{"line_number":30,"context_line":"# NOTE(yoctozepto): this is required here for CI because we run templating"},{"line_number":31,"context_line":"# of docker systemd command only once, using the previous release when upgrading"},{"line_number":32,"context_line":"# also note: atm upgrade would conflict with the zun profile which uses this var"},{"line_number":33,"context_line":"docker_registry: \"{{ api_interface_address }}:4000\""},{"line_number":34,"context_line":"{% endif %}"},{"line_number":35,"context_line":"{% if not is_previous_release %}"}],"source_content_type":"text/x-jinja2","patch_set":21,"id":"7faddb67_ed25bdaf","line":32,"range":{"start_line":30,"start_character":0,"end_line":32,"end_character":80},"updated":"2019-08-08 15:13:10.000000000","message":"this is no longer valid then","commit_id":"c675d4ff995ff88c3b1f81059227658cfb05ca73"},{"author":{"_account_id":24072,"name":"Marcin Juszkiewicz","email":"mjuszkiewicz@redhat.com","username":"hrw"},"change_message_id":"1e21a1195beac98d2503ba55b918278ad43d1a7a","unresolved":false,"context_lines":[{"line_number":27,"context_line":"{% if need_build_image and is_previous_release %}"},{"line_number":28,"context_line":"# NOTE(mgoddard): Ensure that the insecure local registry is trusted, since it"},{"line_number":29,"context_line":"# will be the source of images during the upgrade."},{"line_number":30,"context_line":"# NOTE(yoctozepto): this is required here for CI because we run templating"},{"line_number":31,"context_line":"# of docker systemd command only once, using the previous release when upgrading"},{"line_number":32,"context_line":"# also note: atm upgrade would conflict with the zun profile which uses this var"},{"line_number":33,"context_line":"docker_registry: \"{{ api_interface_address }}:4000\""},{"line_number":34,"context_line":"{% endif %}"},{"line_number":35,"context_line":"{% if not is_previous_release %}"}],"source_content_type":"text/x-jinja2","patch_set":21,"id":"7faddb67_9e78f12b","line":32,"range":{"start_line":30,"start_character":0,"end_line":32,"end_character":80},"in_reply_to":"7faddb67_ed25bdaf","updated":"2019-08-08 17:27:21.000000000","message":"I am open for replacement text.","commit_id":"c675d4ff995ff88c3b1f81059227658cfb05ca73"},{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"ed3422ac83765fb61facb59779fecd520d27b15d","unresolved":false,"context_lines":[{"line_number":30,"context_line":"# NOTE(yoctozepto): this is required here for CI because we run templating"},{"line_number":31,"context_line":"# of docker systemd command only once, using the previous release when upgrading"},{"line_number":32,"context_line":"# also note: atm upgrade would conflict with the zun profile which uses this var"},{"line_number":33,"context_line":"docker_registry: \"{{ api_interface_address }}:4000\""},{"line_number":34,"context_line":"{% endif %}"},{"line_number":35,"context_line":"{% if not is_previous_release %}"},{"line_number":36,"context_line":"openstack_release: \"{{ zuul.branch | basename }}\""}],"source_content_type":"text/x-jinja2","patch_set":21,"id":"7faddb67_8d452918","line":33,"range":{"start_line":33,"start_character":0,"end_line":33,"end_character":51},"updated":"2019-08-08 15:13:10.000000000","message":"I guess this really only works because we source stein\u0027s file for this\nI got bitten by this in the past and Mark had to revert\nThis would break pre-upgrade because it does not have images rebuilt for efficiency reasons","commit_id":"c675d4ff995ff88c3b1f81059227658cfb05ca73"},{"author":{"_account_id":24072,"name":"Marcin Juszkiewicz","email":"mjuszkiewicz@redhat.com","username":"hrw"},"change_message_id":"1e21a1195beac98d2503ba55b918278ad43d1a7a","unresolved":false,"context_lines":[{"line_number":30,"context_line":"# NOTE(yoctozepto): this is required here for CI because we run templating"},{"line_number":31,"context_line":"# of docker systemd command only once, using the previous release when upgrading"},{"line_number":32,"context_line":"# also note: atm upgrade would conflict with the zun profile which uses this var"},{"line_number":33,"context_line":"docker_registry: \"{{ api_interface_address }}:4000\""},{"line_number":34,"context_line":"{% endif %}"},{"line_number":35,"context_line":"{% if not is_previous_release %}"},{"line_number":36,"context_line":"openstack_release: \"{{ zuul.branch | basename }}\""}],"source_content_type":"text/x-jinja2","patch_set":21,"id":"7faddb67_be960d3e","line":33,"range":{"start_line":33,"start_character":0,"end_line":33,"end_character":51},"in_reply_to":"7faddb67_8d452918","updated":"2019-08-08 17:27:21.000000000","message":"Passed CI tests somehow. This is area where I do not have much knowledge :(","commit_id":"c675d4ff995ff88c3b1f81059227658cfb05ca73"},{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"e7cf0ec9ad4bd9c3f8d5a23d3ff300b1885e1e38","unresolved":false,"context_lines":[{"line_number":30,"context_line":"# NOTE(yoctozepto): this is required here for CI because we run templating"},{"line_number":31,"context_line":"# of docker systemd command only once, using the previous release when upgrading"},{"line_number":32,"context_line":"# also note: atm upgrade would conflict with the zun profile which uses this var"},{"line_number":33,"context_line":"docker_registry: \"{{ api_interface_address }}:4000\""},{"line_number":34,"context_line":"{% endif %}"},{"line_number":35,"context_line":"{% if not is_previous_release %}"},{"line_number":36,"context_line":"openstack_release: \"{{ zuul.branch | basename }}\""}],"source_content_type":"text/x-jinja2","patch_set":21,"id":"7faddb67_1e1de172","line":33,"range":{"start_line":33,"start_character":0,"end_line":33,"end_character":51},"in_reply_to":"7faddb67_be960d3e","updated":"2019-08-08 17:50:56.000000000","message":"Passed because used stein. Need to rethink that.","commit_id":"c675d4ff995ff88c3b1f81059227658cfb05ca73"},{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"ed3422ac83765fb61facb59779fecd520d27b15d","unresolved":false,"context_lines":[{"line_number":68,"context_line":"enable_zun: \"yes\""},{"line_number":69,"context_line":"enable_kuryr: \"yes\""},{"line_number":70,"context_line":"enable_etcd: \"yes\""},{"line_number":71,"context_line":"docker_config: [ \"host\": \"unix:///var/run/docker.sock\", \"host\": \"tcp://{{ api_interface_address }}:2375\", \"cluster-store\": \"etcd://{{ api_interface_address }}:2379\", \"cluster-advertise\": \"{{ api_interface_address }}:2375\"]"},{"line_number":72,"context_line":"{% endif %}"},{"line_number":73,"context_line":""},{"line_number":74,"context_line":"{% if scenario \u003d\u003d \"scenario_nfv\" %}"}],"source_content_type":"text/x-jinja2","patch_set":21,"id":"7faddb67_8da9a9de","line":71,"range":{"start_line":71,"start_character":0,"end_line":71,"end_character":13},"updated":"2019-08-08 15:13:10.000000000","message":"docker_custom_config","commit_id":"c675d4ff995ff88c3b1f81059227658cfb05ca73"},{"author":{"_account_id":24072,"name":"Marcin Juszkiewicz","email":"mjuszkiewicz@redhat.com","username":"hrw"},"change_message_id":"1e21a1195beac98d2503ba55b918278ad43d1a7a","unresolved":false,"context_lines":[{"line_number":68,"context_line":"enable_zun: \"yes\""},{"line_number":69,"context_line":"enable_kuryr: \"yes\""},{"line_number":70,"context_line":"enable_etcd: \"yes\""},{"line_number":71,"context_line":"docker_config: [ \"host\": \"unix:///var/run/docker.sock\", \"host\": \"tcp://{{ api_interface_address }}:2375\", \"cluster-store\": \"etcd://{{ api_interface_address }}:2379\", \"cluster-advertise\": \"{{ api_interface_address }}:2375\"]"},{"line_number":72,"context_line":"{% endif %}"},{"line_number":73,"context_line":""},{"line_number":74,"context_line":"{% if scenario \u003d\u003d \"scenario_nfv\" %}"}],"source_content_type":"text/x-jinja2","patch_set":21,"id":"7faddb67_9e9d5159","line":71,"range":{"start_line":71,"start_character":0,"end_line":71,"end_character":13},"in_reply_to":"7faddb67_8da9a9de","updated":"2019-08-08 17:27:21.000000000","message":"Done","commit_id":"c675d4ff995ff88c3b1f81059227658cfb05ca73"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"6df9762557521f6a9749ecbf40f82323873e27e3","unresolved":false,"context_lines":[{"line_number":68,"context_line":"enable_zun: \"yes\""},{"line_number":69,"context_line":"enable_kuryr: \"yes\""},{"line_number":70,"context_line":"enable_etcd: \"yes\""},{"line_number":71,"context_line":"docker_custom_config: [ \"host\": \"unix:///var/run/docker.sock\", \"host\": \"tcp://{{ api_interface_address }}:2375\", \"cluster-store\": \"etcd://{{ api_interface_address }}:2379\", \"cluster-advertise\": \"{{ api_interface_address }}:2375\"]"},{"line_number":72,"context_line":"{% endif %}"},{"line_number":73,"context_line":""},{"line_number":74,"context_line":"{% if scenario \u003d\u003d \"scenario_nfv\" %}"}],"source_content_type":"text/x-jinja2","patch_set":22,"id":"7faddb67_9b30f5ea","line":71,"updated":"2019-08-09 09:29:28.000000000","message":"This should be a dict rather than a list.\n\nAlso, probably easier to read in YAML format:\n\ndocker_custom_config:\n  hosts:\n    - \u003chost1\u003e\n    - \u003chost2\u003e\n  cluster-store: ...\n  cluster-advertise: ...","commit_id":"0116057d2abe9683fe351e04f2e0aa9461a30e22"},{"author":{"_account_id":24072,"name":"Marcin Juszkiewicz","email":"mjuszkiewicz@redhat.com","username":"hrw"},"change_message_id":"c0c1aa6ed33695b0cc401e5f5d58f3031de16e23","unresolved":false,"context_lines":[{"line_number":68,"context_line":"enable_zun: \"yes\""},{"line_number":69,"context_line":"enable_kuryr: \"yes\""},{"line_number":70,"context_line":"enable_etcd: \"yes\""},{"line_number":71,"context_line":"docker_custom_config: [ \"host\": \"unix:///var/run/docker.sock\", \"host\": \"tcp://{{ api_interface_address }}:2375\", \"cluster-store\": \"etcd://{{ api_interface_address }}:2379\", \"cluster-advertise\": \"{{ api_interface_address }}:2375\"]"},{"line_number":72,"context_line":"{% endif %}"},{"line_number":73,"context_line":""},{"line_number":74,"context_line":"{% if scenario \u003d\u003d \"scenario_nfv\" %}"}],"source_content_type":"text/x-jinja2","patch_set":22,"id":"7faddb67_272f5ea8","line":71,"in_reply_to":"7faddb67_9b30f5ea","updated":"2019-08-09 13:39:28.000000000","message":"Done","commit_id":"0116057d2abe9683fe351e04f2e0aa9461a30e22"},{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"737a3e39e167c179bb75d85b3998c72ef18e09c9","unresolved":false,"context_lines":[{"line_number":30,"context_line":"# NOTE(yoctozepto): this is required here for CI because we run templating"},{"line_number":31,"context_line":"# of docker systemd command only once, using the previous release when upgrading"},{"line_number":32,"context_line":"# also note: atm upgrade would conflict with the zun profile which uses this var"},{"line_number":33,"context_line":"docker_registry: \"{{ api_interface_address }}:4000\""},{"line_number":34,"context_line":"{% endif %}"},{"line_number":35,"context_line":"{% if not is_previous_release %}"},{"line_number":36,"context_line":"openstack_release: \"{{ zuul.branch | basename }}\""}],"source_content_type":"text/x-jinja2","patch_set":24,"id":"7faddb67_3d288e95","line":33,"range":{"start_line":33,"start_character":0,"end_line":33,"end_character":51},"updated":"2019-08-14 11:36:59.000000000","message":"will fail further upgrades because pre-upgrade images are NOT rebuilt","commit_id":"043d5657f87bacca0a0032dc70f745797caa9864"},{"author":{"_account_id":24072,"name":"Marcin Juszkiewicz","email":"mjuszkiewicz@redhat.com","username":"hrw"},"change_message_id":"cc338ca95145f46acd23f0c753e09ebf27a028b7","unresolved":false,"context_lines":[{"line_number":30,"context_line":"# NOTE(yoctozepto): this is required here for CI because we run templating"},{"line_number":31,"context_line":"# of docker systemd command only once, using the previous release when upgrading"},{"line_number":32,"context_line":"# also note: atm upgrade would conflict with the zun profile which uses this var"},{"line_number":33,"context_line":"docker_registry: \"{{ api_interface_address }}:4000\""},{"line_number":34,"context_line":"{% endif %}"},{"line_number":35,"context_line":"{% if not is_previous_release %}"},{"line_number":36,"context_line":"openstack_release: \"{{ zuul.branch | basename }}\""}],"source_content_type":"text/x-jinja2","patch_set":24,"id":"7faddb67_60adf9e8","line":33,"range":{"start_line":33,"start_character":0,"end_line":33,"end_character":51},"in_reply_to":"7faddb67_3d288e95","updated":"2019-08-14 12:08:12.000000000","message":"Can you elaborate? As this is setting same thing just in proper way.","commit_id":"043d5657f87bacca0a0032dc70f745797caa9864"},{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"bb95a4c20177592becf19d298c9f4dd08696edcf","unresolved":false,"context_lines":[{"line_number":30,"context_line":"# NOTE(yoctozepto): this is required here for CI because we run templating"},{"line_number":31,"context_line":"# of docker systemd command only once, using the previous release when upgrading"},{"line_number":32,"context_line":"# also note: atm upgrade would conflict with the zun profile which uses this var"},{"line_number":33,"context_line":"docker_registry: \"{{ api_interface_address }}:4000\""},{"line_number":34,"context_line":"{% endif %}"},{"line_number":35,"context_line":"{% if not is_previous_release %}"},{"line_number":36,"context_line":"openstack_release: \"{{ zuul.branch | basename }}\""}],"source_content_type":"text/x-jinja2","patch_set":24,"id":"7faddb67_6ad06ff8","line":33,"range":{"start_line":33,"start_character":0,"end_line":33,"end_character":51},"in_reply_to":"7faddb67_60adf9e8","updated":"2019-08-14 19:01:22.000000000","message":"Not exactly, this one is actually changing the used registry instead of just allowing to use it later - pre-upgrade from Train to U would fail because images are not rebuilt pre-upgrade and the registry is not passthrough. :-)\nBest use the newly created variable! (then the Zun note will still be relevant but for the new variable now and everything is happy)","commit_id":"043d5657f87bacca0a0032dc70f745797caa9864"},{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"737a3e39e167c179bb75d85b3998c72ef18e09c9","unresolved":false,"context_lines":[{"line_number":69,"context_line":"enable_kuryr: \"yes\""},{"line_number":70,"context_line":"enable_etcd: \"yes\""},{"line_number":71,"context_line":"docker_custom_option: \" -H unix:///var/run/docker.sock -H tcp://{{ api_interface_address }}:2375 \""},{"line_number":72,"context_line":"docker_custom_config:"},{"line_number":73,"context_line":"  \"cluster-store\": \"etcd://{{ api_interface_address }}:2379\""},{"line_number":74,"context_line":"  \"cluster-advertise\": \"{{ api_interface_address }}:2375\""},{"line_number":75,"context_line":"{% endif %}"},{"line_number":76,"context_line":""},{"line_number":77,"context_line":"{% if scenario \u003d\u003d \"scenario_nfv\" %}"}],"source_content_type":"text/x-jinja2","patch_set":24,"id":"7faddb67_dd185a85","line":74,"range":{"start_line":72,"start_character":0,"end_line":74,"end_character":57},"updated":"2019-08-14 11:36:59.000000000","message":"+3 from me","commit_id":"043d5657f87bacca0a0032dc70f745797caa9864"}]}