)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"7dd1f7ce3856da2f50bb316d6fe4cb3adc78ce97","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"On Debian/Ubuntu systems install Docker from distribution"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Both Debian \u0027buster\u0027 and Ubuntu \u0027bionic\u0027 ship Docker 18.09 version."},{"line_number":10,"context_line":"So let just use it instead of checking is newest upstream one works or"},{"line_number":11,"context_line":"not."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Change-Id: I8e12850e8f1cc4aa88f49a8faa6067b9191bf9b4"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"7faddb67_98835ecb","line":11,"range":{"start_line":9,"start_character":0,"end_line":11,"end_character":4},"updated":"2019-08-06 11:43:39.000000000","message":"I\u0027m not sure this is a sound argument for changing this. Why not just test whether the one we have already works?","commit_id":"bcb5c27a475bdc49ae360934f83c0bf1f754ad25"},{"author":{"_account_id":24072,"name":"Marcin Juszkiewicz","email":"mjuszkiewicz@redhat.com","username":"hrw"},"change_message_id":"309ef259ca465dd230495a79cdd870388718ce2c","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"On Debian/Ubuntu systems install Docker from distribution"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Both Debian \u0027buster\u0027 and Ubuntu \u0027bionic\u0027 ship Docker 18.09 version."},{"line_number":10,"context_line":"So let just use it instead of checking is newest upstream one works or"},{"line_number":11,"context_line":"not."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Change-Id: I8e12850e8f1cc4aa88f49a8faa6067b9191bf9b4"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"7faddb67_f3b5d332","line":11,"range":{"start_line":9,"start_character":0,"end_line":11,"end_character":4},"in_reply_to":"7faddb67_98835ecb","updated":"2019-08-06 12:01:26.000000000","message":"Both distributions give us one version for next few cycles.\n\nDocker lacks LTS and likes to change things between versions (like MountFlags in 18.09 for example).\n\nSo this change was to get rid of \u0027let us find out why newer Docker CE broke and how to fix it\u0027.","commit_id":"bcb5c27a475bdc49ae360934f83c0bf1f754ad25"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"b9fc53ecbef238d41154644a2684e22e6b3ba9c5","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"On Debian/Ubuntu systems install Docker from distribution"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Both Debian \u0027buster\u0027 and Ubuntu \u0027bionic\u0027 ship Docker 18.09 version."},{"line_number":10,"context_line":"So let just use it instead of checking is newest upstream one works or"},{"line_number":11,"context_line":"not."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Change-Id: I8e12850e8f1cc4aa88f49a8faa6067b9191bf9b4"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"7faddb67_df145543","line":11,"range":{"start_line":9,"start_character":0,"end_line":11,"end_character":4},"in_reply_to":"7faddb67_f3b5d332","updated":"2019-08-06 16:54:59.000000000","message":"I see, although we\u0027d still need to fix mountflags for docker.io :)\n\nOn Red hat docker will not be updated any more (due to podman), so we\u0027ll never have LTS there. I\u0027d personally rather keep docker CE as the default on all platforms. Generally docker is quite stable now, but if there are compatibility issues we can fix them as we go.","commit_id":"bcb5c27a475bdc49ae360934f83c0bf1f754ad25"}],"ansible/roles/baremetal/defaults/main.yml":[{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"7dd1f7ce3856da2f50bb316d6fe4cb3adc78ce97","unresolved":false,"context_lines":[{"line_number":6,"context_line":"# newer packages at docker.com."},{"line_number":7,"context_line":"docker_legacy_packages: false"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"# Docker APT repository configuration."},{"line_number":10,"context_line":"docker_apt_url: \"{% if docker_legacy_packages | bool %}{{ docker_legacy_apt_url }}{% else %}{{ docker_new_apt_url }}{% endif %}\""},{"line_number":11,"context_line":"docker_apt_repo: \"{% if docker_legacy_packages | bool %}{{ docker_legacy_apt_repo }}{% else %}{{ docker_new_apt_repo }}{% endif %}\""},{"line_number":12,"context_line":"docker_apt_key_file: \"{% if docker_legacy_packages | bool %}{{ docker_legacy_apt_key_file }}{% else %}{{ docker_new_apt_key_file }}{% endif %}\""},{"line_number":13,"context_line":"docker_apt_key_id: \"{% if docker_legacy_packages | bool %}{{ docker_legacy_apt_key_id }}{% else %}{{ docker_new_apt_key_id }}{% endif %}\""},{"line_number":14,"context_line":"docker_apt_package: \"{% if docker_legacy_packages | bool %}{{ docker_legacy_apt_package }}{% else %}{{ docker_new_apt_package }}{% endif %}\""},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"# Docker APT repository configuration when docker_legacy_packages is false."},{"line_number":17,"context_line":"docker_new_apt_url: \"https://download.docker.com/linux/{{ ansible_distribution | lower }}\""},{"line_number":18,"context_line":"docker_new_apt_repo: \"deb {{ docker_new_apt_url }} {{ ansible_lsb.codename }} stable\""},{"line_number":19,"context_line":"docker_new_apt_key_file: \"gpg\""},{"line_number":20,"context_line":"docker_new_apt_key_id: \"0EBFCD88\""},{"line_number":21,"context_line":"docker_new_apt_package: \"docker-ce\""},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"# Docker APT repository configuration when docker_legacy_packages is true."},{"line_number":24,"context_line":"docker_legacy_apt_url: \"{{ \u0027http://obs.linaro.org/ERP:/17.12/Debian_9\u0027 if ansible_architecture \u003d\u003d \u0027aarch64\u0027 else \u0027https://apt.dockerproject.org\u0027 }}\""},{"line_number":25,"context_line":"docker_legacy_apt_repo: \"{{ docker_legacy_apt_repo_aarch64 if ansible_architecture \u003d\u003d \u0027aarch64\u0027 else docker_legacy_apt_repo_x86_64 }}\""},{"line_number":26,"context_line":"docker_legacy_apt_repo_x86_64: \"deb {{ docker_apt_url }}/repo {{ ansible_distribution | lower }}-{{ ansible_distribution_release | lower }} main\""},{"line_number":27,"context_line":"docker_legacy_apt_repo_aarch64: \"deb {{ docker_apt_url }} ./\""},{"line_number":28,"context_line":"docker_legacy_apt_key_file: \"{{ \u0027Release.key\u0027 if ansible_architecture \u003d\u003d \u0027aarch64\u0027 else \u0027gpg\u0027 }}\""},{"line_number":29,"context_line":"docker_legacy_apt_key_id: \"{{ \u0027C32DA102AD89C2BE\u0027 if ansible_architecture \u003d\u003d \u0027aarch64\u0027 else \u0027F76221572C52609D\u0027 }}\""},{"line_number":30,"context_line":"docker_legacy_apt_package: \"{{ \u0027docker-ce\u0027 if ansible_architecture \u003d\u003d \u0027aarch64\u0027 else \u0027docker-engine\u003d1.12.*\u0027 }}\""},{"line_number":31,"context_line":""},{"line_number":32,"context_line":"# Docker Yum repository configuration."},{"line_number":33,"context_line":"docker_yum_url: \"{% if docker_legacy_packages | bool %}{{ docker_legacy_yum_url }}{% else %}{{ docker_new_yum_url }}{% endif %}\""}],"source_content_type":"text/x-yaml","patch_set":2,"id":"7faddb67_3857ca5a","side":"PARENT","line":30,"range":{"start_line":9,"start_character":0,"end_line":30,"end_character":111},"updated":"2019-08-06 11:43:39.000000000","message":"Removing all of this could break deployments that rely on changing it. These variables are documented here: https://docs.openstack.org/kolla-ansible/latest/reference/deployment-and-bootstrapping/bootstrap-servers.html#package-repositories.\n\nAn alternative approach using local globals.yml configuration to do what you\u0027re attempting here is:\n\nenable_docker_repo: false\ndocker_apt_package: docker.io\n\nIf we find that docker CE really doesn\u0027t work in some case, we could detect that case and apply the above automatically.","commit_id":"2b78c831fdc0ed06b9126875a559f992cdbf78bc"}],"ansible/roles/baremetal/tasks/pre-install.yml":[{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"32236627a9213447c2eba14648190bd1f54cf1a3","unresolved":false,"context_lines":[{"line_number":83,"context_line":"            repo: \"{{ docker_apt_repo }}\""},{"line_number":84,"context_line":"            filename: docker"},{"line_number":85,"context_line":"          become: True"},{"line_number":86,"context_line":"      when: ansible_os_family \u003d\u003d \u0027Debian\u0027"},{"line_number":87,"context_line":""},{"line_number":88,"context_line":"    - block:"},{"line_number":89,"context_line":"        - name: Ensure yum repos directory exists"},{"line_number":90,"context_line":"          file:"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"7faddb67_593221f4","side":"PARENT","line":87,"range":{"start_line":86,"start_character":0,"end_line":87,"end_character":0},"updated":"2019-07-31 09:48:15.000000000","message":"this block-level condition is important, let\u0027s keep it","commit_id":"2b78c831fdc0ed06b9126875a559f992cdbf78bc"}]}