)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"fc60031a85f77caa85fab2982937e6e3130d22cc","unresolved":false,"context_lines":[{"line_number":17,"context_line":"engine daemon. In Docker Engine 18.09, containerd is managed by systemd."},{"line_number":18,"context_line":"Since containerd is managed by systemd, any custom configuration to the"},{"line_number":19,"context_line":"docker.service systemd configuration which changes mount settings (for"},{"line_number":20,"context_line":"example, MountFlags\u003dslave) breaks interactions between the Docker Engine"},{"line_number":21,"context_line":"daemon and containerd, and you will not be able to start containers."},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"Run the following command to get the current value of the MountFlags"},{"line_number":24,"context_line":"property for the docker.service:"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"7faddb67_a49f0cb2","line":21,"range":{"start_line":20,"start_character":27,"end_line":21,"end_character":68},"updated":"2019-08-06 16:17:40.000000000","message":"I just verified this is false, even for Debian. At least for docker-ce versions.\n\nStill, I think we can and should get rid of this flag as it seems like some badly documented workaround.","commit_id":"04aa0ee813bfb689c4f8ae290402b23b3128f488"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"03e80f12e33b2bcbd68150a5f4b1a0e15b591e94","unresolved":false,"context_lines":[{"line_number":17,"context_line":"engine daemon. In Docker Engine 18.09, containerd is managed by systemd."},{"line_number":18,"context_line":"Since containerd is managed by systemd, any custom configuration to the"},{"line_number":19,"context_line":"docker.service systemd configuration which changes mount settings (for"},{"line_number":20,"context_line":"example, MountFlags\u003dslave) breaks interactions between the Docker Engine"},{"line_number":21,"context_line":"daemon and containerd, and you will not be able to start containers."},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"Run the following command to get the current value of the MountFlags"},{"line_number":24,"context_line":"property for the docker.service:"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"7faddb67_84de900e","line":21,"range":{"start_line":20,"start_character":27,"end_line":21,"end_character":68},"in_reply_to":"7faddb67_a49f0cb2","updated":"2019-08-06 16:40:57.000000000","message":"From ocata docs https://docs.openstack.org/kolla-ansible/ocata/user/quickstart.html:\n\n\"If you do not set the MountFlags option correctly then kolla-ansible will fail to deploy the neutron-dhcp-agent container and throws APIError/HTTPError\"\n\nSo we at least know what we\u0027re looking for.","commit_id":"04aa0ee813bfb689c4f8ae290402b23b3128f488"}],"ansible/roles/baremetal/templates/docker_systemd_service.j2":[{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"eb8be45966f956689b4aa7903f7aba8bf18d0dab","unresolved":false,"context_lines":[{"line_number":1,"context_line":"[Service]"},{"line_number":2,"context_line":"ExecStart\u003d"},{"line_number":3,"context_line":"ExecStart\u003d/usr/bin/{{ docker_binary_name|default(\"docker daemon\", true) }}{% if docker_registry_insecure | bool %} --insecure-registry {{ docker_registry }}{% endif %}{% if docker_storage_driver %} --storage-driver {{ docker_storage_driver }}{% endif %}{% if docker_runtime_directory %} --graph {{ docker_runtime_directory }}{% endif %}{% if docker_custom_option %} {{ docker_custom_option }}{% endif %} --log-opt max-file\u003d{{ docker_log_max_file }} --log-opt max-size\u003d{{ docker_log_max_size }}"}],"source_content_type":"text/x-jinja2","patch_set":2,"id":"7faddb67_40add299","line":3,"updated":"2019-08-07 12:03:13.000000000","message":"If the only thing we needed a ,,special\u0027\u0027 systemd unit for docker was MountFlags - why not move all other settings to /etc/docker/daemon.json and stop fiddling with systemd units?","commit_id":"35941738d59002f8bbf55d25b3468619983dcea6"},{"author":{"_account_id":24072,"name":"Marcin Juszkiewicz","email":"mjuszkiewicz@redhat.com","username":"hrw"},"change_message_id":"fd10609c043d8f1ec8448236a590567ba0c231c4","unresolved":false,"context_lines":[{"line_number":1,"context_line":"[Service]"},{"line_number":2,"context_line":"ExecStart\u003d"},{"line_number":3,"context_line":"ExecStart\u003d/usr/bin/{{ docker_binary_name|default(\"docker daemon\", true) }}{% if docker_registry_insecure | bool %} --insecure-registry {{ docker_registry }}{% endif %}{% if docker_storage_driver %} --storage-driver {{ docker_storage_driver }}{% endif %}{% if docker_runtime_directory %} --graph {{ docker_runtime_directory }}{% endif %}{% if docker_custom_option %} {{ docker_custom_option }}{% endif %} --log-opt max-file\u003d{{ docker_log_max_file }} --log-opt max-size\u003d{{ docker_log_max_size }}"}],"source_content_type":"text/x-jinja2","patch_set":2,"id":"7faddb67_5b038777","line":3,"in_reply_to":"7faddb67_40add299","updated":"2019-08-07 13:00:25.000000000","message":"daemon.json: https://review.opendev.org/#/c/672700","commit_id":"35941738d59002f8bbf55d25b3468619983dcea6"}]}