)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"8a909afec3b98a6470dd2352f103687736828fcc","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Use Docker healthchecks for core services"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This change enables the use of Docker healthchecks"},{"line_number":10,"context_line":"for core services that kolla-ansible always deploys."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Implements: blueprint container-health-check"},{"line_number":13,"context_line":"Change-Id: I79c6b11511ce8af70f77e2f6a490b59b477fefbb"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":53,"id":"bf51134e_1e5129da","line":10,"range":{"start_line":10,"start_character":37,"end_line":10,"end_character":51},"updated":"2020-07-10 14:22:23.000000000","message":"could we forget chrony then? :-)","commit_id":"827f1d8183c8784b3781bf020bfafe7dacea9935"},{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"4efc85720a8d40702111a3963edb17ddf0a3b5eb","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Use Docker healthchecks for core services"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This change enables the use of Docker healthchecks"},{"line_number":10,"context_line":"for core services that kolla-ansible always deploys."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Implements: blueprint container-health-check"},{"line_number":13,"context_line":"Change-Id: I79c6b11511ce8af70f77e2f6a490b59b477fefbb"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":53,"id":"bf51134e_626e952f","line":10,"range":{"start_line":10,"start_character":37,"end_line":10,"end_character":51},"in_reply_to":"bf51134e_1e5129da","updated":"2020-07-15 07:06:29.000000000","message":"oh boy, let me add something for this :)","commit_id":"827f1d8183c8784b3781bf020bfafe7dacea9935"}],"ansible/group_vars/all.yml":[{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"be0bc121cdefd8c19a21c2ec18dca55c50c13a39","unresolved":false,"context_lines":[{"line_number":287,"context_line":"glance_external_fqdn: \"{{ kolla_external_fqdn }}\""},{"line_number":288,"context_line":"glance_api_port: \"9292\""},{"line_number":289,"context_line":"glance_api_listen_port: \"{{ glance_api_port }}\""},{"line_number":290,"context_line":"glance_tls_proxy_stats_port: \"9293\""},{"line_number":291,"context_line":""},{"line_number":292,"context_line":"gnocchi_internal_fqdn: \"{{ kolla_internal_fqdn }}\""},{"line_number":293,"context_line":"gnocchi_external_fqdn: \"{{ kolla_external_fqdn }}\""}],"source_content_type":"text/x-yaml","patch_set":96,"id":"9f560f44_5c4168a6","line":290,"updated":"2020-09-30 14:24:00.000000000","message":"mixed in","commit_id":"550e9ec8b8e8616cee0e81098d4b61b90a9833bb"},{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"81e9e5a768977569895e7ac6013bc15abeb0df37","unresolved":false,"context_lines":[{"line_number":287,"context_line":"glance_external_fqdn: \"{{ kolla_external_fqdn }}\""},{"line_number":288,"context_line":"glance_api_port: \"9292\""},{"line_number":289,"context_line":"glance_api_listen_port: \"{{ glance_api_port }}\""},{"line_number":290,"context_line":"glance_tls_proxy_stats_port: \"9293\""},{"line_number":291,"context_line":""},{"line_number":292,"context_line":"gnocchi_internal_fqdn: \"{{ kolla_internal_fqdn }}\""},{"line_number":293,"context_line":"gnocchi_external_fqdn: \"{{ kolla_external_fqdn }}\""}],"source_content_type":"text/x-yaml","patch_set":96,"id":"9f560f44_34364053","line":290,"in_reply_to":"9f560f44_50514963","updated":"2020-10-01 10:27:45.000000000","message":"\u003e Meaning? It should be somewhere else?\n\nSorry, it was a draft. I mean it is surprising to see \u0027healthchecks\u0027 add new variables to glance_tls_proxy but might bet that\u0027s just how life works. :-)","commit_id":"550e9ec8b8e8616cee0e81098d4b61b90a9833bb"},{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"41a8013f2630552cd849512cd5115347849b1546","unresolved":false,"context_lines":[{"line_number":287,"context_line":"glance_external_fqdn: \"{{ kolla_external_fqdn }}\""},{"line_number":288,"context_line":"glance_api_port: \"9292\""},{"line_number":289,"context_line":"glance_api_listen_port: \"{{ glance_api_port }}\""},{"line_number":290,"context_line":"glance_tls_proxy_stats_port: \"9293\""},{"line_number":291,"context_line":""},{"line_number":292,"context_line":"gnocchi_internal_fqdn: \"{{ kolla_internal_fqdn }}\""},{"line_number":293,"context_line":"gnocchi_external_fqdn: \"{{ kolla_external_fqdn }}\""}],"source_content_type":"text/x-yaml","patch_set":96,"id":"9f560f44_50514963","line":290,"in_reply_to":"9f560f44_5c4168a6","updated":"2020-09-30 17:56:12.000000000","message":"Meaning? It should be somewhere else?","commit_id":"550e9ec8b8e8616cee0e81098d4b61b90a9833bb"}],"ansible/library/kolla_docker.py":[{"author":{"_account_id":24072,"name":"Marcin Juszkiewicz","email":"mjuszkiewicz@redhat.com","username":"hrw"},"change_message_id":"c793c4183923e25e4109c3da4d321e4730d56218","unresolved":false,"context_lines":[{"line_number":587,"context_line":"                                \u0027Expected an integer\".\u0027"},{"line_number":588,"context_line":"                                .format(new_healthcheck[key1])"},{"line_number":589,"context_line":"                            )"},{"line_number":590,"context_line":"                        if (new_healthcheck[key1] * 1000000000) !\u003d \\"},{"line_number":591,"context_line":"                                current_healthcheck[key2]:"},{"line_number":592,"context_line":"                            return True"},{"line_number":593,"context_line":"                elif current_healthcheck[key2]:"}],"source_content_type":"text/x-python","patch_set":44,"id":"3fa7e38b_ee2989f1","line":590,"range":{"start_line":590,"start_character":52,"end_line":590,"end_character":62},"updated":"2019-12-11 10:09:11.000000000","message":"1e9 does not require counting zeros\n\nand NOTE why it is here will be nice","commit_id":"56b09a806293737ac9e31e460bcbc7aa2f157c54"},{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"c423c0f8836ce8d94092f680f25f4e04d151b95e","unresolved":false,"context_lines":[{"line_number":587,"context_line":"                                \u0027Expected an integer\".\u0027"},{"line_number":588,"context_line":"                                .format(new_healthcheck[key1])"},{"line_number":589,"context_line":"                            )"},{"line_number":590,"context_line":"                        if (new_healthcheck[key1] * 1000000000) !\u003d \\"},{"line_number":591,"context_line":"                                current_healthcheck[key2]:"},{"line_number":592,"context_line":"                            return True"},{"line_number":593,"context_line":"                elif current_healthcheck[key2]:"}],"source_content_type":"text/x-python","patch_set":44,"id":"3fa7e38b_948262a4","line":590,"range":{"start_line":590,"start_character":52,"end_line":590,"end_character":62},"in_reply_to":"3fa7e38b_ee2989f1","updated":"2019-12-11 12:25:11.000000000","message":"Done","commit_id":"56b09a806293737ac9e31e460bcbc7aa2f157c54"},{"author":{"_account_id":24072,"name":"Marcin Juszkiewicz","email":"mjuszkiewicz@redhat.com","username":"hrw"},"change_message_id":"c793c4183923e25e4109c3da4d321e4730d56218","unresolved":false,"context_lines":[{"line_number":940,"context_line":""},{"line_number":941,"context_line":"        if result[\u0027test\u0027] \u003d\u003d [\u0027NONE\u0027]:"},{"line_number":942,"context_line":"            # If the user explicitly disables the healthcheck, return None"},{"line_number":943,"context_line":"            # as the healthcheck object, and set disable_healthcheck to True"},{"line_number":944,"context_line":"            return None"},{"line_number":945,"context_line":"        return result"},{"line_number":946,"context_line":""}],"source_content_type":"text/x-python","patch_set":44,"id":"3fa7e38b_ae7dd1e6","line":943,"range":{"start_line":943,"start_character":49,"end_line":943,"end_character":68},"updated":"2019-12-11 10:09:11.000000000","message":"leftover variable?","commit_id":"56b09a806293737ac9e31e460bcbc7aa2f157c54"},{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"c423c0f8836ce8d94092f680f25f4e04d151b95e","unresolved":false,"context_lines":[{"line_number":940,"context_line":""},{"line_number":941,"context_line":"        if result[\u0027test\u0027] \u003d\u003d [\u0027NONE\u0027]:"},{"line_number":942,"context_line":"            # If the user explicitly disables the healthcheck, return None"},{"line_number":943,"context_line":"            # as the healthcheck object, and set disable_healthcheck to True"},{"line_number":944,"context_line":"            return None"},{"line_number":945,"context_line":"        return result"},{"line_number":946,"context_line":""}],"source_content_type":"text/x-python","patch_set":44,"id":"3fa7e38b_348daed3","line":943,"range":{"start_line":943,"start_character":49,"end_line":943,"end_character":68},"in_reply_to":"3fa7e38b_ae7dd1e6","updated":"2019-12-11 12:25:11.000000000","message":"yup, removed.","commit_id":"56b09a806293737ac9e31e460bcbc7aa2f157c54"},{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"2c18565c8f3187288fbbb6170d4173ebe95149d7","unresolved":false,"context_lines":[{"line_number":211,"context_line":"    description:"},{"line_number":212,"context_line":"      - Container healthcheck configuration"},{"line_number":213,"context_line":"    required: False"},{"line_number":214,"context_line":"    default: False"},{"line_number":215,"context_line":"    type: list"},{"line_number":216,"context_line":"author: Sam Yaple"},{"line_number":217,"context_line":"\u0027\u0027\u0027"}],"source_content_type":"text/x-python","patch_set":45,"id":"3fa7e38b_0a1b2284","line":214,"range":{"start_line":214,"start_character":13,"end_line":214,"end_character":18},"updated":"2019-12-20 12:51:23.000000000","message":"huh?","commit_id":"0cf4106b0ad90fb3d2a83bcb338486403c9d63fa"},{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"c49f0786f1776a3ea5135bd37dc6fbb4262579b3","unresolved":false,"context_lines":[{"line_number":211,"context_line":"    description:"},{"line_number":212,"context_line":"      - Container healthcheck configuration"},{"line_number":213,"context_line":"    required: False"},{"line_number":214,"context_line":"    default: False"},{"line_number":215,"context_line":"    type: list"},{"line_number":216,"context_line":"author: Sam Yaple"},{"line_number":217,"context_line":"\u0027\u0027\u0027"}],"source_content_type":"text/x-python","patch_set":45,"id":"3fa7e38b_90db111f","line":214,"range":{"start_line":214,"start_character":13,"end_line":214,"end_character":18},"in_reply_to":"3fa7e38b_0a1b2284","updated":"2020-01-13 18:12:56.000000000","message":"There is no default value for health check, what\u0027s wrong with that? Should I write empty dict?","commit_id":"0cf4106b0ad90fb3d2a83bcb338486403c9d63fa"},{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"2d02dad3e8af33c8f5ac0d40969ae84e7391e3f0","unresolved":false,"context_lines":[{"line_number":211,"context_line":"    description:"},{"line_number":212,"context_line":"      - Container healthcheck configuration"},{"line_number":213,"context_line":"    required: False"},{"line_number":214,"context_line":"    default: False"},{"line_number":215,"context_line":"    type: list"},{"line_number":216,"context_line":"author: Sam Yaple"},{"line_number":217,"context_line":"\u0027\u0027\u0027"}],"source_content_type":"text/x-python","patch_set":45,"id":"3fa7e38b_778981c5","line":214,"range":{"start_line":214,"start_character":13,"end_line":214,"end_character":18},"in_reply_to":"3fa7e38b_3107b521","updated":"2020-01-15 16:35:03.000000000","message":"Done!","commit_id":"0cf4106b0ad90fb3d2a83bcb338486403c9d63fa"},{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"9187960161fcb73101a7549f453ef117c52e12d0","unresolved":false,"context_lines":[{"line_number":211,"context_line":"    description:"},{"line_number":212,"context_line":"      - Container healthcheck configuration"},{"line_number":213,"context_line":"    required: False"},{"line_number":214,"context_line":"    default: False"},{"line_number":215,"context_line":"    type: list"},{"line_number":216,"context_line":"author: Sam Yaple"},{"line_number":217,"context_line":"\u0027\u0027\u0027"}],"source_content_type":"text/x-python","patch_set":45,"id":"3fa7e38b_3107b521","line":214,"range":{"start_line":214,"start_character":13,"end_line":214,"end_character":18},"in_reply_to":"3fa7e38b_90db111f","updated":"2020-01-14 12:35:19.000000000","message":"empty dict!","commit_id":"0cf4106b0ad90fb3d2a83bcb338486403c9d63fa"},{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"2c18565c8f3187288fbbb6170d4173ebe95149d7","unresolved":false,"context_lines":[{"line_number":212,"context_line":"      - Container healthcheck configuration"},{"line_number":213,"context_line":"    required: False"},{"line_number":214,"context_line":"    default: False"},{"line_number":215,"context_line":"    type: list"},{"line_number":216,"context_line":"author: Sam Yaple"},{"line_number":217,"context_line":"\u0027\u0027\u0027"},{"line_number":218,"context_line":""}],"source_content_type":"text/x-python","patch_set":45,"id":"3fa7e38b_aa29ae9c","line":215,"range":{"start_line":215,"start_character":10,"end_line":215,"end_character":14},"updated":"2019-12-20 12:51:23.000000000","message":"huh^2?","commit_id":"0cf4106b0ad90fb3d2a83bcb338486403c9d63fa"},{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"c49f0786f1776a3ea5135bd37dc6fbb4262579b3","unresolved":false,"context_lines":[{"line_number":212,"context_line":"      - Container healthcheck configuration"},{"line_number":213,"context_line":"    required: False"},{"line_number":214,"context_line":"    default: False"},{"line_number":215,"context_line":"    type: list"},{"line_number":216,"context_line":"author: Sam Yaple"},{"line_number":217,"context_line":"\u0027\u0027\u0027"},{"line_number":218,"context_line":""}],"source_content_type":"text/x-python","patch_set":45,"id":"3fa7e38b_b0d3ad02","line":215,"range":{"start_line":215,"start_character":10,"end_line":215,"end_character":14},"in_reply_to":"3fa7e38b_aa29ae9c","updated":"2020-01-13 18:12:56.000000000","message":"Changed to dict, as in the definition on the bottom.","commit_id":"0cf4106b0ad90fb3d2a83bcb338486403c9d63fa"},{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"2c18565c8f3187288fbbb6170d4173ebe95149d7","unresolved":false,"context_lines":[{"line_number":257,"context_line":"        self.module \u003d module"},{"line_number":258,"context_line":"        self.params \u003d self.module.params"},{"line_number":259,"context_line":"        self.changed \u003d False"},{"line_number":260,"context_line":"        self.timeout \u003d 600"},{"line_number":261,"context_line":"        # Use this to store arguments to pass to exit_json()."},{"line_number":262,"context_line":"        self.result \u003d {}"},{"line_number":263,"context_line":""}],"source_content_type":"text/x-python","patch_set":45,"id":"3fa7e38b_ca242ac6","line":260,"range":{"start_line":260,"start_character":8,"end_line":260,"end_character":26},"updated":"2019-12-20 12:51:23.000000000","message":"does it belong here?","commit_id":"0cf4106b0ad90fb3d2a83bcb338486403c9d63fa"},{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"c49f0786f1776a3ea5135bd37dc6fbb4262579b3","unresolved":false,"context_lines":[{"line_number":257,"context_line":"        self.module \u003d module"},{"line_number":258,"context_line":"        self.params \u003d self.module.params"},{"line_number":259,"context_line":"        self.changed \u003d False"},{"line_number":260,"context_line":"        self.timeout \u003d 600"},{"line_number":261,"context_line":"        # Use this to store arguments to pass to exit_json()."},{"line_number":262,"context_line":"        self.result \u003d {}"},{"line_number":263,"context_line":""}],"source_content_type":"text/x-python","patch_set":45,"id":"3fa7e38b_9004717f","line":260,"range":{"start_line":260,"start_character":8,"end_line":260,"end_character":26},"in_reply_to":"3fa7e38b_ca242ac6","updated":"2020-01-13 18:12:56.000000000","message":"Nah, removed.","commit_id":"0cf4106b0ad90fb3d2a83bcb338486403c9d63fa"},{"author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"tag":"autogenerated:zuul:check","change_message_id":"3199a61ea4a1b66dfba99496aa37685f1e33dbad","unresolved":false,"context_lines":[{"line_number":596,"context_line":"                elif current_healthcheck[key2]:"},{"line_number":597,"context_line":"                    return True"},{"line_number":598,"context_line":"        else:"},{"line_number":599,"context_line":"                return True"},{"line_number":600,"context_line":""},{"line_number":601,"context_line":"    def parse_image(self):"},{"line_number":602,"context_line":"        full_image \u003d self.params.get(\u0027image\u0027)"}],"source_content_type":"text/x-python","patch_set":51,"id":"bf51134e_d5785df9","line":599,"updated":"2020-07-08 11:19:19.000000000","message":"linters: E117 over-indented","commit_id":"ff46894717b61b0267ad8582ed63d62878cd3e46"},{"author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"tag":"autogenerated:zuul:check","change_message_id":"3199a61ea4a1b66dfba99496aa37685f1e33dbad","unresolved":false,"context_lines":[{"line_number":596,"context_line":"                elif current_healthcheck[key2]:"},{"line_number":597,"context_line":"                    return True"},{"line_number":598,"context_line":"        else:"},{"line_number":599,"context_line":"                return True"},{"line_number":600,"context_line":""},{"line_number":601,"context_line":"    def parse_image(self):"},{"line_number":602,"context_line":"        full_image \u003d self.params.get(\u0027image\u0027)"}],"source_content_type":"text/x-python","patch_set":51,"id":"bf51134e_b57b29f2","line":599,"updated":"2020-07-08 11:19:19.000000000","message":"pep8: E117 over-indented","commit_id":"ff46894717b61b0267ad8582ed63d62878cd3e46"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"c69e9f5a13c9bf65fe24499294156b850e3a14a2","unresolved":false,"context_lines":[{"line_number":543,"context_line":"                    new_args !\u003d container_info[\u0027Args\u0027]):"},{"line_number":544,"context_line":"                return True"},{"line_number":545,"context_line":""},{"line_number":546,"context_line":"    def compare_healthcheck(self, container_info):"},{"line_number":547,"context_line":"        new_healthcheck \u003d self.params.get(\u0027healthcheck\u0027)"},{"line_number":548,"context_line":"        current_healthcheck \u003d container_info[\u0027Config\u0027].get(\u0027Healthcheck\u0027)"},{"line_number":549,"context_line":""}],"source_content_type":"text/x-python","patch_set":63,"id":"9f560f44_9ed4f9ea","line":546,"updated":"2020-08-06 11:38:31.000000000","message":"Shouldn\u0027t this be in the previous patch?","commit_id":"e3643ba4f22cb5123c3776b16215151ecd31b26e"},{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"362e17e5b6e699b47288f0893c4cc69d16ef5852","unresolved":false,"context_lines":[{"line_number":543,"context_line":"                    new_args !\u003d container_info[\u0027Args\u0027]):"},{"line_number":544,"context_line":"                return True"},{"line_number":545,"context_line":""},{"line_number":546,"context_line":"    def compare_healthcheck(self, container_info):"},{"line_number":547,"context_line":"        new_healthcheck \u003d self.params.get(\u0027healthcheck\u0027)"},{"line_number":548,"context_line":"        current_healthcheck \u003d container_info[\u0027Config\u0027].get(\u0027Healthcheck\u0027)"},{"line_number":549,"context_line":""}],"source_content_type":"text/x-python","patch_set":63,"id":"9f560f44_dec311ec","line":546,"in_reply_to":"9f560f44_9ed4f9ea","updated":"2020-08-06 11:52:40.000000000","message":"Yes, forgot to rebase, done.","commit_id":"e3643ba4f22cb5123c3776b16215151ecd31b26e"}],"ansible/roles/chrony/defaults/main.yml":[{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"8b896a759a269b429a987fcb973fef533ed34baf","unresolved":false,"context_lines":[{"line_number":27,"context_line":"chrony_healthcheck_interval: \"{{ default_container_healthcheck_interval }}\""},{"line_number":28,"context_line":"chrony_healthcheck_timeout: \"{{ default_container_healthcheck_timeout }}\""},{"line_number":29,"context_line":"chrony_healthcheck_retries: \"{{ default_container_healthcheck_retries }}\""},{"line_number":30,"context_line":"chrony_healthcheck_test: [\"CMD-SHELL\", \"chronyc sources\"]"},{"line_number":31,"context_line":"chrony_healthcheck_start_period: \"{{ default_container_healthcheck_start_period }}\""},{"line_number":32,"context_line":""},{"line_number":33,"context_line":"chrony_healthcheck:"}],"source_content_type":"text/x-yaml","patch_set":76,"id":"9f560f44_d917f853","line":30,"range":{"start_line":30,"start_character":40,"end_line":30,"end_character":55},"updated":"2020-09-21 09:36:54.000000000","message":"What would cause this to fail?","commit_id":"b88777c50c831f7ee7740df168ffd24baf66cb99"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"f81e08cd7a3653ad0e7e13c9188f1c24919dbc4d","unresolved":false,"context_lines":[{"line_number":27,"context_line":"chrony_healthcheck_interval: \"{{ default_container_healthcheck_interval }}\""},{"line_number":28,"context_line":"chrony_healthcheck_timeout: \"{{ default_container_healthcheck_timeout }}\""},{"line_number":29,"context_line":"chrony_healthcheck_retries: \"{{ default_container_healthcheck_retries }}\""},{"line_number":30,"context_line":"chrony_healthcheck_test: [\"CMD-SHELL\", \"chronyc sources\"]"},{"line_number":31,"context_line":"chrony_healthcheck_start_period: \"{{ default_container_healthcheck_start_period }}\""},{"line_number":32,"context_line":""},{"line_number":33,"context_line":"chrony_healthcheck:"}],"source_content_type":"text/x-yaml","patch_set":76,"id":"9f560f44_5ec6e14a","line":30,"range":{"start_line":30,"start_character":40,"end_line":30,"end_character":55},"in_reply_to":"9f560f44_6da1af95","updated":"2020-09-24 09:48:11.000000000","message":"How quickly does chrony sync if the time is way out? We need to be careful about overdiagnosing health issues, if the service is just trying to do its job.","commit_id":"b88777c50c831f7ee7740df168ffd24baf66cb99"},{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"f173f25958465c321e67fdf26bcb69b8e218cf18","unresolved":false,"context_lines":[{"line_number":27,"context_line":"chrony_healthcheck_interval: \"{{ default_container_healthcheck_interval }}\""},{"line_number":28,"context_line":"chrony_healthcheck_timeout: \"{{ default_container_healthcheck_timeout }}\""},{"line_number":29,"context_line":"chrony_healthcheck_retries: \"{{ default_container_healthcheck_retries }}\""},{"line_number":30,"context_line":"chrony_healthcheck_test: [\"CMD-SHELL\", \"chronyc sources\"]"},{"line_number":31,"context_line":"chrony_healthcheck_start_period: \"{{ default_container_healthcheck_start_period }}\""},{"line_number":32,"context_line":""},{"line_number":33,"context_line":"chrony_healthcheck:"}],"source_content_type":"text/x-yaml","patch_set":76,"id":"9f560f44_6da1af95","line":30,"range":{"start_line":30,"start_character":40,"end_line":30,"end_character":55},"in_reply_to":"9f560f44_d917f853","updated":"2020-09-23 15:55:54.000000000","message":"Right, changed to chronyc waitsync 1 (will check for sync status once and wait 10 seconds to achieve that status)","commit_id":"b88777c50c831f7ee7740df168ffd24baf66cb99"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"8b896a759a269b429a987fcb973fef533ed34baf","unresolved":false,"context_lines":[{"line_number":31,"context_line":"chrony_healthcheck_start_period: \"{{ default_container_healthcheck_start_period }}\""},{"line_number":32,"context_line":""},{"line_number":33,"context_line":"chrony_healthcheck:"},{"line_number":34,"context_line":"  test: \"{% if enable_container_healthchecks | bool %}{{ chrony_healthcheck_test }}{% else %}NONE{% endif %}\""},{"line_number":35,"context_line":"  interval: \"{{ chrony_healthcheck_interval }}\""},{"line_number":36,"context_line":"  timeout: \"{{ chrony_healthcheck_timeout }}\""},{"line_number":37,"context_line":"  retries: \"{{ chrony_healthcheck_retries }}\""}],"source_content_type":"text/x-yaml","patch_set":76,"id":"9f560f44_2c34f4de","line":34,"range":{"start_line":34,"start_character":15,"end_line":34,"end_character":44},"updated":"2020-09-21 09:36:54.000000000","message":"I can imagine that if a healthcheck is found to be unreliable, the most common thing people are going to want to tweak on a per-service basis is to disable a healthcheck.\n\nchrony_enable_healthcheck?","commit_id":"b88777c50c831f7ee7740df168ffd24baf66cb99"},{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"f173f25958465c321e67fdf26bcb69b8e218cf18","unresolved":false,"context_lines":[{"line_number":31,"context_line":"chrony_healthcheck_start_period: \"{{ default_container_healthcheck_start_period }}\""},{"line_number":32,"context_line":""},{"line_number":33,"context_line":"chrony_healthcheck:"},{"line_number":34,"context_line":"  test: \"{% if enable_container_healthchecks | bool %}{{ chrony_healthcheck_test }}{% else %}NONE{% endif %}\""},{"line_number":35,"context_line":"  interval: \"{{ chrony_healthcheck_interval }}\""},{"line_number":36,"context_line":"  timeout: \"{{ chrony_healthcheck_timeout }}\""},{"line_number":37,"context_line":"  retries: \"{{ chrony_healthcheck_retries }}\""}],"source_content_type":"text/x-yaml","patch_set":76,"id":"9f560f44_4dc78b46","line":34,"range":{"start_line":34,"start_character":15,"end_line":34,"end_character":44},"in_reply_to":"9f560f44_2c34f4de","updated":"2020-09-23 15:55:54.000000000","message":"Done","commit_id":"b88777c50c831f7ee7740df168ffd24baf66cb99"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"f81e08cd7a3653ad0e7e13c9188f1c24919dbc4d","unresolved":false,"context_lines":[{"line_number":32,"context_line":"chrony_healthcheck_start_period: \"{{ default_container_healthcheck_start_period }}\""},{"line_number":33,"context_line":""},{"line_number":34,"context_line":"chrony_healthcheck:"},{"line_number":35,"context_line":"  test: \"{% if chrony_enable_healthchecks | bool %}{{ chrony_healthcheck_test }}{% else %}NONE{% endif %}\""},{"line_number":36,"context_line":"  interval: \"{{ chrony_healthcheck_interval }}\""},{"line_number":37,"context_line":"  timeout: \"{{ chrony_healthcheck_timeout }}\""},{"line_number":38,"context_line":"  retries: \"{{ chrony_healthcheck_retries }}\""}],"source_content_type":"text/x-yaml","patch_set":85,"id":"9f560f44_3e584d88","line":35,"range":{"start_line":35,"start_character":90,"end_line":35,"end_character":94},"updated":"2020-09-24 09:48:11.000000000","message":"The kolla_docker module checks for [\"NONE\"], here we pass \"NONE\". Suggest the module is updated.","commit_id":"6b139bfbdea3a51e68ab5e44120ecb1e0da77c14"}],"ansible/roles/common/defaults/main.yml":[{"author":{"_account_id":24072,"name":"Marcin Juszkiewicz","email":"mjuszkiewicz@redhat.com","username":"hrw"},"change_message_id":"c793c4183923e25e4109c3da4d321e4730d56218","unresolved":false,"context_lines":[{"line_number":35,"context_line":"      DUMMY_ENVIRONMENT: kolla_useless_env"},{"line_number":36,"context_line":"    volumes: \"{{ cron_default_volumes + cron_extra_volumes }}\""},{"line_number":37,"context_line":"    dimensions: \"{{ cron_dimensions }}\""},{"line_number":38,"context_line":"    healthcheck: \"{{ kolla_toolbox_healthcheck }}\""},{"line_number":39,"context_line":""},{"line_number":40,"context_line":"#######################"},{"line_number":41,"context_line":"# TLS and authenication"}],"source_content_type":"text/x-yaml","patch_set":44,"id":"3fa7e38b_2e71e10d","line":38,"range":{"start_line":38,"start_character":21,"end_line":38,"end_character":46},"updated":"2019-12-11 10:09:11.000000000","message":"cron_healthcheck you mean?","commit_id":"56b09a806293737ac9e31e460bcbc7aa2f157c54"},{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"c423c0f8836ce8d94092f680f25f4e04d151b95e","unresolved":false,"context_lines":[{"line_number":35,"context_line":"      DUMMY_ENVIRONMENT: kolla_useless_env"},{"line_number":36,"context_line":"    volumes: \"{{ cron_default_volumes + cron_extra_volumes }}\""},{"line_number":37,"context_line":"    dimensions: \"{{ cron_dimensions }}\""},{"line_number":38,"context_line":"    healthcheck: \"{{ kolla_toolbox_healthcheck }}\""},{"line_number":39,"context_line":""},{"line_number":40,"context_line":"#######################"},{"line_number":41,"context_line":"# TLS and authenication"}],"source_content_type":"text/x-yaml","patch_set":44,"id":"3fa7e38b_54886ac1","line":38,"range":{"start_line":38,"start_character":21,"end_line":38,"end_character":46},"in_reply_to":"3fa7e38b_2e71e10d","updated":"2019-12-11 12:25:11.000000000","message":"Done","commit_id":"56b09a806293737ac9e31e460bcbc7aa2f157c54"},{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"e01547e67f700ff3e749e0d8cf7996cdc0516556","unresolved":false,"context_lines":[{"line_number":25,"context_line":"    privileged: True"},{"line_number":26,"context_line":"    volumes: \"{{ kolla_toolbox_default_volumes + kolla_toolbox_extra_volumes }}\""},{"line_number":27,"context_line":"    dimensions: \"{{ kolla_toolbox_dimensions }}\""},{"line_number":28,"context_line":"    healthcheck: \"{{ kolla_toolbox_healthcheck | default({}) }}\""},{"line_number":29,"context_line":"  # DUMMY_ENVIRONMENT is needed because empty environment is not supported"},{"line_number":30,"context_line":"  cron:"},{"line_number":31,"context_line":"    container_name: cron"}],"source_content_type":"text/x-yaml","patch_set":45,"id":"3fa7e38b_ea5a464f","line":28,"updated":"2019-12-20 12:49:08.000000000","message":"why set at all?","commit_id":"0cf4106b0ad90fb3d2a83bcb338486403c9d63fa"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"f81e08cd7a3653ad0e7e13c9188f1c24919dbc4d","unresolved":false,"context_lines":[{"line_number":60,"context_line":"fluentd_healthcheck_interval: \"{{ default_container_healthcheck_interval }}\""},{"line_number":61,"context_line":"fluentd_healthcheck_retries: \"{{ default_container_healthcheck_retries }}\""},{"line_number":62,"context_line":"fluentd_healthcheck_start_period: \"{{ default_container_healthcheck_start_period }}\""},{"line_number":63,"context_line":"fluentd_healthcheck_test: [\"CMD-SHELL\", \"healthcheck_filemod /var/run/{{ fluentd_binary }}/mariadb.pos 3600\"]"},{"line_number":64,"context_line":"fluentd_healthcheck_timeout: \"{{ default_container_healthcheck_timeout }}\""},{"line_number":65,"context_line":""},{"line_number":66,"context_line":"fluentd_healthcheck:"}],"source_content_type":"text/x-yaml","patch_set":85,"id":"9f560f44_3ee32dda","line":63,"range":{"start_line":63,"start_character":91,"end_line":63,"end_character":98},"updated":"2020-09-24 09:48:11.000000000","message":"mariadb might not be enabled, or logging.\n\nWhat about something like https://github.com/k63207/fluent-plugin-http-healthcheck","commit_id":"6b139bfbdea3a51e68ab5e44120ecb1e0da77c14"}],"ansible/roles/glance/defaults/main.yml":[{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"8b896a759a269b429a987fcb973fef533ed34baf","unresolved":false,"context_lines":[{"line_number":135,"context_line":"glance_api_healthcheck_interval: \"{{ default_container_healthcheck_interval }}\""},{"line_number":136,"context_line":"glance_api_healthcheck_retries: \"{{ default_container_healthcheck_retries }}\""},{"line_number":137,"context_line":"glance_api_healthcheck_start_period: \"{{ default_container_healthcheck_start_period }}\""},{"line_number":138,"context_line":"glance_api_healthcheck_test: [\"CMD-SHELL\", \"{% if glance_enable_tls_backend | bool %}curl {{ internal_protocol }}://127.0.0.1:{{ glance_api_port }}{% else %}curl {{ internal_protocol }}://{{ api_interface_address }}:{{ glance_api_port }}{% endif %}\"]"},{"line_number":139,"context_line":"glance_api_healthcheck_timeout: \"{{ default_container_healthcheck_timeout }}\""},{"line_number":140,"context_line":"glance_api_healthcheck:"},{"line_number":141,"context_line":"  interval: \"{{ glance_api_healthcheck_interval }}\""}],"source_content_type":"text/x-yaml","patch_set":76,"id":"9f560f44_ac7644a2","line":138,"range":{"start_line":138,"start_character":47,"end_line":138,"end_character":82},"updated":"2020-09-21 09:36:54.000000000","message":"Would be a bit more DRY if it just covered the IP.","commit_id":"b88777c50c831f7ee7740df168ffd24baf66cb99"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"8b896a759a269b429a987fcb973fef533ed34baf","unresolved":false,"context_lines":[{"line_number":135,"context_line":"glance_api_healthcheck_interval: \"{{ default_container_healthcheck_interval }}\""},{"line_number":136,"context_line":"glance_api_healthcheck_retries: \"{{ default_container_healthcheck_retries }}\""},{"line_number":137,"context_line":"glance_api_healthcheck_start_period: \"{{ default_container_healthcheck_start_period }}\""},{"line_number":138,"context_line":"glance_api_healthcheck_test: [\"CMD-SHELL\", \"{% if glance_enable_tls_backend | bool %}curl {{ internal_protocol }}://127.0.0.1:{{ glance_api_port }}{% else %}curl {{ internal_protocol }}://{{ api_interface_address }}:{{ glance_api_port }}{% endif %}\"]"},{"line_number":139,"context_line":"glance_api_healthcheck_timeout: \"{{ default_container_healthcheck_timeout }}\""},{"line_number":140,"context_line":"glance_api_healthcheck:"},{"line_number":141,"context_line":"  interval: \"{{ glance_api_healthcheck_interval }}\""}],"source_content_type":"text/x-yaml","patch_set":76,"id":"9f560f44_4ca04892","line":138,"range":{"start_line":138,"start_character":219,"end_line":138,"end_character":234},"updated":"2020-09-21 09:36:54.000000000","message":"glance_api_listen_port (and for other APIS)","commit_id":"b88777c50c831f7ee7740df168ffd24baf66cb99"},{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"f173f25958465c321e67fdf26bcb69b8e218cf18","unresolved":false,"context_lines":[{"line_number":135,"context_line":"glance_api_healthcheck_interval: \"{{ default_container_healthcheck_interval }}\""},{"line_number":136,"context_line":"glance_api_healthcheck_retries: \"{{ default_container_healthcheck_retries }}\""},{"line_number":137,"context_line":"glance_api_healthcheck_start_period: \"{{ default_container_healthcheck_start_period }}\""},{"line_number":138,"context_line":"glance_api_healthcheck_test: [\"CMD-SHELL\", \"{% if glance_enable_tls_backend | bool %}curl {{ internal_protocol }}://127.0.0.1:{{ glance_api_port }}{% else %}curl {{ internal_protocol }}://{{ api_interface_address }}:{{ glance_api_port }}{% endif %}\"]"},{"line_number":139,"context_line":"glance_api_healthcheck_timeout: \"{{ default_container_healthcheck_timeout }}\""},{"line_number":140,"context_line":"glance_api_healthcheck:"},{"line_number":141,"context_line":"  interval: \"{{ glance_api_healthcheck_interval }}\""}],"source_content_type":"text/x-yaml","patch_set":76,"id":"9f560f44_8dffe300","line":138,"range":{"start_line":138,"start_character":47,"end_line":138,"end_character":82},"in_reply_to":"9f560f44_ac7644a2","updated":"2020-09-23 15:55:54.000000000","message":"Done","commit_id":"b88777c50c831f7ee7740df168ffd24baf66cb99"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"8b896a759a269b429a987fcb973fef533ed34baf","unresolved":false,"context_lines":[{"line_number":147,"context_line":"glance_tls_proxy_healthcheck_interval: \"{{ default_container_healthcheck_interval }}\""},{"line_number":148,"context_line":"glance_tls_proxy_healthcheck_retries: \"{{ default_container_healthcheck_retries }}\""},{"line_number":149,"context_line":"glance_tls_proxy_healthcheck_start_period: \"{{ default_container_healthcheck_start_period }}\""},{"line_number":150,"context_line":"glance_tls_proxy_healthcheck_test: [\"CMD-SHELL\", \"curl {{ internal_protocol }}://{{ api_interface_address }}:{{ glance_api_port }}\"]"},{"line_number":151,"context_line":"glance_tls_proxy_healthcheck_timeout: \"{{ default_container_healthcheck_timeout }}\""},{"line_number":152,"context_line":"glance_tls_proxy_healthcheck:"},{"line_number":153,"context_line":"  interval: \"{{ glance_tls_proxy_healthcheck_interval }}\""}],"source_content_type":"text/x-yaml","patch_set":76,"id":"9f560f44_2ca7d40b","line":150,"updated":"2020-09-21 09:36:54.000000000","message":"What about certificates? Backend TLS Normally only HAProxy requires the CA certificate for backend TLS. We could skip CA validation. healthcheck_curl does that.","commit_id":"b88777c50c831f7ee7740df168ffd24baf66cb99"},{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"f173f25958465c321e67fdf26bcb69b8e218cf18","unresolved":false,"context_lines":[{"line_number":147,"context_line":"glance_tls_proxy_healthcheck_interval: \"{{ default_container_healthcheck_interval }}\""},{"line_number":148,"context_line":"glance_tls_proxy_healthcheck_retries: \"{{ default_container_healthcheck_retries }}\""},{"line_number":149,"context_line":"glance_tls_proxy_healthcheck_start_period: \"{{ default_container_healthcheck_start_period }}\""},{"line_number":150,"context_line":"glance_tls_proxy_healthcheck_test: [\"CMD-SHELL\", \"curl {{ internal_protocol }}://{{ api_interface_address }}:{{ glance_api_port }}\"]"},{"line_number":151,"context_line":"glance_tls_proxy_healthcheck_timeout: \"{{ default_container_healthcheck_timeout }}\""},{"line_number":152,"context_line":"glance_tls_proxy_healthcheck:"},{"line_number":153,"context_line":"  interval: \"{{ glance_tls_proxy_healthcheck_interval }}\""}],"source_content_type":"text/x-yaml","patch_set":76,"id":"9f560f44_ed601f38","line":150,"in_reply_to":"9f560f44_2ca7d40b","updated":"2020-09-23 15:55:54.000000000","message":"Done","commit_id":"b88777c50c831f7ee7740df168ffd24baf66cb99"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"5d34864f7a79f83786cbbc3f66fec559f9ad1cbb","unresolved":false,"context_lines":[{"line_number":136,"context_line":"glance_api_healthcheck_interval: \"{{ default_container_healthcheck_interval }}\""},{"line_number":137,"context_line":"glance_api_healthcheck_retries: \"{{ default_container_healthcheck_retries }}\""},{"line_number":138,"context_line":"glance_api_healthcheck_start_period: \"{{ default_container_healthcheck_start_period }}\""},{"line_number":139,"context_line":"glance_api_healthcheck_test: [\"CMD-SHELL\", \"healthcheck_curl {{ internal_protocol }}://{{ api_interface_address }}:{{ glance_api_listen_port }}\"]"},{"line_number":140,"context_line":"glance_api_healthcheck_timeout: \"{{ default_container_healthcheck_timeout }}\""},{"line_number":141,"context_line":"glance_api_healthcheck:"},{"line_number":142,"context_line":"  interval: \"{{ glance_api_healthcheck_interval }}\""}],"source_content_type":"text/x-yaml","patch_set":85,"id":"9f560f44_e9baa1bd","line":139,"range":{"start_line":139,"start_character":90,"end_line":139,"end_character":111},"updated":"2020-09-24 09:49:49.000000000","message":"I think we do need to check localhost if backend TLS is in use.","commit_id":"6b139bfbdea3a51e68ab5e44120ecb1e0da77c14"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"f81e08cd7a3653ad0e7e13c9188f1c24919dbc4d","unresolved":false,"context_lines":[{"line_number":149,"context_line":"glance_tls_proxy_healthcheck_interval: \"{{ default_container_healthcheck_interval }}\""},{"line_number":150,"context_line":"glance_tls_proxy_healthcheck_retries: \"{{ default_container_healthcheck_retries }}\""},{"line_number":151,"context_line":"glance_tls_proxy_healthcheck_start_period: \"{{ default_container_healthcheck_start_period }}\""},{"line_number":152,"context_line":"glance_tls_proxy_healthcheck_test: [\"CMD-SHELL\", \"echo show info | socat unix-connect:/var/lib/kolla/haproxy/haproxy.sock stdio \u003e /dev/null\"]"},{"line_number":153,"context_line":"glance_tls_proxy_healthcheck_timeout: \"{{ default_container_healthcheck_timeout }}\""},{"line_number":154,"context_line":"glance_tls_proxy_healthcheck:"},{"line_number":155,"context_line":"  interval: \"{{ glance_tls_proxy_healthcheck_interval }}\""}],"source_content_type":"text/x-yaml","patch_set":85,"id":"9f560f44_dec95125","line":152,"updated":"2020-09-24 09:48:11.000000000","message":"Any reason not to use glance_api_healthcheck_test? healthcheck_curl should skip CA validation.","commit_id":"6b139bfbdea3a51e68ab5e44120ecb1e0da77c14"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"05b25bad03d056ffd41eb104fd45696c2843c934","unresolved":false,"context_lines":[{"line_number":136,"context_line":"glance_api_healthcheck_interval: \"{{ default_container_healthcheck_interval }}\""},{"line_number":137,"context_line":"glance_api_healthcheck_retries: \"{{ default_container_healthcheck_retries }}\""},{"line_number":138,"context_line":"glance_api_healthcheck_start_period: \"{{ default_container_healthcheck_start_period }}\""},{"line_number":139,"context_line":"glance_api_healthcheck_test: [\"CMD-SHELL\", \"healthcheck_curl {% if glance_enable_tls_backend | bool %}http://localhost{% else %}{{ internal_protocol }}://{{ api_interface_address }}{% endif %}:{{ glance_api_listen_port }}\"]"},{"line_number":140,"context_line":"glance_api_healthcheck_timeout: \"{{ default_container_healthcheck_timeout }}\""},{"line_number":141,"context_line":"glance_api_healthcheck:"},{"line_number":142,"context_line":"  interval: \"{{ glance_api_healthcheck_interval }}\""}],"source_content_type":"text/x-yaml","patch_set":101,"id":"9f560f44_b87cfab6","line":139,"range":{"start_line":139,"start_character":128,"end_line":139,"end_character":151},"updated":"2020-10-01 18:26:00.000000000","message":"http","commit_id":"f2280560db8ad8c6b19fdd2dbb2566df3c97d0ff"}],"ansible/roles/glance/handlers/main.yml":[{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"c69e9f5a13c9bf65fe24499294156b850e3a14a2","unresolved":false,"context_lines":[{"line_number":28,"context_line":"    name: \"{{ service.container_name }}\""},{"line_number":29,"context_line":"    image: \"{{ service.image }}\""},{"line_number":30,"context_line":"    volumes: \"{{ service.volumes|reject(\u0027equalto\u0027, \u0027\u0027)|list }}\""},{"line_number":31,"context_line":"    dimensions: \"{{ service.dimensions | default(omit) }}\""},{"line_number":32,"context_line":"  when:"},{"line_number":33,"context_line":"    - kolla_action !\u003d \"config\""}],"source_content_type":"text/x-yaml","patch_set":56,"id":"9f560f44_1ee909b6","line":31,"range":{"start_line":31,"start_character":39,"end_line":31,"end_character":54},"updated":"2020-08-06 11:38:31.000000000","message":"why?","commit_id":"3dd5f300b5f83512222761e9f31fcd9b75384c4d"},{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"362e17e5b6e699b47288f0893c4cc69d16ef5852","unresolved":false,"context_lines":[{"line_number":28,"context_line":"    name: \"{{ service.container_name }}\""},{"line_number":29,"context_line":"    image: \"{{ service.image }}\""},{"line_number":30,"context_line":"    volumes: \"{{ service.volumes|reject(\u0027equalto\u0027, \u0027\u0027)|list }}\""},{"line_number":31,"context_line":"    dimensions: \"{{ service.dimensions | default(omit) }}\""},{"line_number":32,"context_line":"  when:"},{"line_number":33,"context_line":"    - kolla_action !\u003d \"config\""}],"source_content_type":"text/x-yaml","patch_set":56,"id":"9f560f44_1ebaa96c","line":31,"range":{"start_line":31,"start_character":39,"end_line":31,"end_character":54},"in_reply_to":"9f560f44_1ee909b6","updated":"2020-08-06 11:52:40.000000000","message":"Actually it\u0027s not needed, it would be only needed in generic case - will rework it.","commit_id":"3dd5f300b5f83512222761e9f31fcd9b75384c4d"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"c69e9f5a13c9bf65fe24499294156b850e3a14a2","unresolved":false,"context_lines":[{"line_number":28,"context_line":"    name: \"{{ service.container_name }}\""},{"line_number":29,"context_line":"    image: \"{{ service.image }}\""},{"line_number":30,"context_line":"    volumes: \"{{ service.volumes|reject(\u0027equalto\u0027, \u0027\u0027)|list }}\""},{"line_number":31,"context_line":"    dimensions: \"{{ service.dimensions | default(omit) }}\""},{"line_number":32,"context_line":"    healthcheck: \"{{ service.healthcheck | default(omit) }}\""},{"line_number":33,"context_line":"  when:"},{"line_number":34,"context_line":"    - kolla_action !\u003d \"config\""}],"source_content_type":"text/x-yaml","patch_set":63,"id":"9f560f44_bef29d98","line":31,"range":{"start_line":31,"start_character":39,"end_line":31,"end_character":54},"updated":"2020-08-06 11:38:31.000000000","message":"why?","commit_id":"e3643ba4f22cb5123c3776b16215151ecd31b26e"},{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"e29e1a367b419be73b96e9be538d058784cf7a7e","unresolved":false,"context_lines":[{"line_number":28,"context_line":"    name: \"{{ service.container_name }}\""},{"line_number":29,"context_line":"    image: \"{{ service.image }}\""},{"line_number":30,"context_line":"    volumes: \"{{ service.volumes|reject(\u0027equalto\u0027, \u0027\u0027)|list }}\""},{"line_number":31,"context_line":"    dimensions: \"{{ service.dimensions | default(omit) }}\""},{"line_number":32,"context_line":"    healthcheck: \"{{ service.healthcheck | default(omit) }}\""},{"line_number":33,"context_line":"  when:"},{"line_number":34,"context_line":"    - kolla_action !\u003d \"config\""}],"source_content_type":"text/x-yaml","patch_set":63,"id":"9f560f44_fe65351f","line":31,"range":{"start_line":31,"start_character":39,"end_line":31,"end_character":54},"in_reply_to":"9f560f44_bef29d98","updated":"2020-08-06 11:53:11.000000000","message":"seems added in wrong line :)","commit_id":"e3643ba4f22cb5123c3776b16215151ecd31b26e"}],"ansible/roles/glance/templates/glance-tls-proxy.cfg.j2":[{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"b524b474c1a10730b104bd5634cf864ba656197d","unresolved":false,"context_lines":[{"line_number":7,"context_line":"    log {{ syslog_server }}:{{ syslog_udp_port }} {{ syslog_glance_tls_proxy_facility }}"},{"line_number":8,"context_line":"    maxconn {{ glance_tls_proxy_max_connections }}"},{"line_number":9,"context_line":"    nbproc {{ glance_tls_proxy_processes }}"},{"line_number":10,"context_line":"    stats socket /var/lib/kolla/haproxy/haproxy.sock group kolla mode 660"},{"line_number":11,"context_line":"    {% if (glance_tls_proxy_processes | int \u003e 1) and (glance_tls_proxy_process_cpu_map | bool) %}"},{"line_number":12,"context_line":"        {% for cpu_idx in range(0, glance_tls_proxy_processes) %}"},{"line_number":13,"context_line":"    cpu-map {{ cpu_idx + 1 }} {{ cpu_idx }}"}],"source_content_type":"text/x-jinja2","patch_set":99,"id":"9f560f44_b4f6d05c","line":10,"range":{"start_line":10,"start_character":4,"end_line":10,"end_character":73},"updated":"2020-10-01 10:47:16.000000000","message":"nit: required?","commit_id":"d27ecfcae6b2c3dbcfb2e221cbc46e67f29ec53f"},{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"6870bbcc8218ae21807ae5b88fbbb5c179f25a24","unresolved":false,"context_lines":[{"line_number":7,"context_line":"    log {{ syslog_server }}:{{ syslog_udp_port }} {{ syslog_glance_tls_proxy_facility }}"},{"line_number":8,"context_line":"    maxconn {{ glance_tls_proxy_max_connections }}"},{"line_number":9,"context_line":"    nbproc {{ glance_tls_proxy_processes }}"},{"line_number":10,"context_line":"    stats socket /var/lib/kolla/haproxy/haproxy.sock group kolla mode 660"},{"line_number":11,"context_line":"    {% if (glance_tls_proxy_processes | int \u003e 1) and (glance_tls_proxy_process_cpu_map | bool) %}"},{"line_number":12,"context_line":"        {% for cpu_idx in range(0, glance_tls_proxy_processes) %}"},{"line_number":13,"context_line":"    cpu-map {{ cpu_idx + 1 }} {{ cpu_idx }}"}],"source_content_type":"text/x-jinja2","patch_set":99,"id":"9f560f44_bfd34901","line":10,"range":{"start_line":10,"start_character":4,"end_line":10,"end_character":73},"in_reply_to":"9f560f44_b4f6d05c","updated":"2020-10-01 11:31:39.000000000","message":"Actually no, removed.","commit_id":"d27ecfcae6b2c3dbcfb2e221cbc46e67f29ec53f"}],"ansible/roles/haproxy/defaults/main.yml":[{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"f81e08cd7a3653ad0e7e13c9188f1c24919dbc4d","unresolved":false,"context_lines":[{"line_number":53,"context_line":"haproxy_healthcheck_interval: \"{{ default_container_healthcheck_interval }}\""},{"line_number":54,"context_line":"haproxy_healthcheck_retries: \"{{ default_container_healthcheck_retries }}\""},{"line_number":55,"context_line":"haproxy_healthcheck_start_period: \"{{ default_container_healthcheck_start_period }}\""},{"line_number":56,"context_line":"haproxy_healthcheck_test: [\"CMD-SHELL\", \"healthcheck_curl {{ api_interface_address }}:{{ haproxy_stats_port }}\"]"},{"line_number":57,"context_line":"haproxy_healthcheck_timeout: \"{{ default_container_healthcheck_timeout }}\""},{"line_number":58,"context_line":"haproxy_healthcheck:"},{"line_number":59,"context_line":"  interval: \"{{ haproxy_healthcheck_interval }}\""}],"source_content_type":"text/x-yaml","patch_set":76,"id":"9f560f44_9e50792e","line":56,"range":{"start_line":56,"start_character":41,"end_line":56,"end_character":110},"updated":"2020-09-24 09:48:11.000000000","message":"Did this not work?","commit_id":"b88777c50c831f7ee7740df168ffd24baf66cb99"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"8b896a759a269b429a987fcb973fef533ed34baf","unresolved":false,"context_lines":[{"line_number":65,"context_line":"keepalived_healthcheck_interval: \"{{ default_container_healthcheck_interval }}\""},{"line_number":66,"context_line":"keepalived_healthcheck_retries: \"{{ default_container_healthcheck_retries }}\""},{"line_number":67,"context_line":"keepalived_healthcheck_start_period: \"{{ default_container_healthcheck_start_period }}\""},{"line_number":68,"context_line":"keepalived_healthcheck_test: [\"CMD\", \"/check_alive.sh\"]"},{"line_number":69,"context_line":"keepalived_healthcheck_timeout: \"{{ default_container_healthcheck_timeout }}\""},{"line_number":70,"context_line":"keepalived_healthcheck:"},{"line_number":71,"context_line":"  interval: \"{{ keepalived_healthcheck_interval }}\""}],"source_content_type":"text/x-yaml","patch_set":76,"id":"9f560f44_ec415c0c","line":68,"range":{"start_line":68,"start_character":39,"end_line":68,"end_character":53},"updated":"2020-09-21 09:36:54.000000000","message":"This is more about haproxy","commit_id":"b88777c50c831f7ee7740df168ffd24baf66cb99"},{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"f173f25958465c321e67fdf26bcb69b8e218cf18","unresolved":false,"context_lines":[{"line_number":65,"context_line":"keepalived_healthcheck_interval: \"{{ default_container_healthcheck_interval }}\""},{"line_number":66,"context_line":"keepalived_healthcheck_retries: \"{{ default_container_healthcheck_retries }}\""},{"line_number":67,"context_line":"keepalived_healthcheck_start_period: \"{{ default_container_healthcheck_start_period }}\""},{"line_number":68,"context_line":"keepalived_healthcheck_test: [\"CMD\", \"/check_alive.sh\"]"},{"line_number":69,"context_line":"keepalived_healthcheck_timeout: \"{{ default_container_healthcheck_timeout }}\""},{"line_number":70,"context_line":"keepalived_healthcheck:"},{"line_number":71,"context_line":"  interval: \"{{ keepalived_healthcheck_interval }}\""}],"source_content_type":"text/x-yaml","patch_set":76,"id":"9f560f44_08f3c10a","line":68,"range":{"start_line":68,"start_character":39,"end_line":68,"end_character":53},"in_reply_to":"9f560f44_ec415c0c","updated":"2020-09-23 15:55:54.000000000","message":"Done","commit_id":"b88777c50c831f7ee7740df168ffd24baf66cb99"}],"ansible/roles/heat/defaults/main.yml":[{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"8b896a759a269b429a987fcb973fef533ed34baf","unresolved":false,"context_lines":[{"line_number":114,"context_line":"heat_engine_healthcheck_interval: \"{{ default_container_healthcheck_interval }}\""},{"line_number":115,"context_line":"heat_engine_healthcheck_retries: \"{{ default_container_healthcheck_retries }}\""},{"line_number":116,"context_line":"heat_engine_healthcheck_start_period: \"{{ default_container_healthcheck_start_period }}\""},{"line_number":117,"context_line":"heat_engine_healthcheck_test: [\"CMD-SHELL\", \"healthcheck_port heat-engine {{ rabbitmq_port }}\"]"},{"line_number":118,"context_line":"heat_engine_healthcheck_timeout: \"{{ default_container_healthcheck_timeout }}\""},{"line_number":119,"context_line":"heat_engine_healthcheck:"},{"line_number":120,"context_line":"  interval: \"{{ heat_engine_healthcheck_interval }}\""}],"source_content_type":"text/x-yaml","patch_set":76,"id":"9f560f44_2c6cf49b","line":117,"range":{"start_line":117,"start_character":77,"end_line":117,"end_character":90},"updated":"2020-09-21 09:36:54.000000000","message":"om_rpc_port is more accurate","commit_id":"b88777c50c831f7ee7740df168ffd24baf66cb99"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"f81e08cd7a3653ad0e7e13c9188f1c24919dbc4d","unresolved":false,"context_lines":[{"line_number":91,"context_line":"heat_api_healthcheck_interval: \"{{ default_container_healthcheck_interval }}\""},{"line_number":92,"context_line":"heat_api_healthcheck_retries: \"{{ default_container_healthcheck_retries }}\""},{"line_number":93,"context_line":"heat_api_healthcheck_start_period: \"{{ default_container_healthcheck_start_period }}\""},{"line_number":94,"context_line":"heat_api_healthcheck_test: [\"CMD-SHELL\", \"healthcheck_curl {{ internal_protocol }}://{{ api_interface_address }}:{{ heat_api_port }}\"]"},{"line_number":95,"context_line":"heat_api_healthcheck_timeout: \"{{ default_container_healthcheck_timeout }}\""},{"line_number":96,"context_line":"heat_api_healthcheck:"},{"line_number":97,"context_line":"  interval: \"{{ heat_api_healthcheck_interval }}\""}],"source_content_type":"text/x-yaml","patch_set":85,"id":"9f560f44_e9ebc10e","line":94,"range":{"start_line":94,"start_character":116,"end_line":94,"end_character":129},"updated":"2020-09-24 09:48:11.000000000","message":"listen","commit_id":"6b139bfbdea3a51e68ab5e44120ecb1e0da77c14"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"f81e08cd7a3653ad0e7e13c9188f1c24919dbc4d","unresolved":false,"context_lines":[{"line_number":104,"context_line":"heat_api_cfn_healthcheck_interval: \"{{ default_container_healthcheck_interval }}\""},{"line_number":105,"context_line":"heat_api_cfn_healthcheck_retries: \"{{ default_container_healthcheck_retries }}\""},{"line_number":106,"context_line":"heat_api_cfn_healthcheck_start_period: \"{{ default_container_healthcheck_start_period }}\""},{"line_number":107,"context_line":"heat_api_cfn_healthcheck_test: [\"CMD-SHELL\", \"healthcheck_curl {{ internal_protocol }}://{{ api_interface_address }}:{{ heat_api_cfn_port }}\"]"},{"line_number":108,"context_line":"heat_api_cfn_healthcheck_timeout: \"{{ default_container_healthcheck_timeout }}\""},{"line_number":109,"context_line":"heat_api_cfn_healthcheck:"},{"line_number":110,"context_line":"  interval: \"{{ heat_api_cfn_healthcheck_interval }}\""}],"source_content_type":"text/x-yaml","patch_set":85,"id":"9f560f44_49ef4d1c","line":107,"range":{"start_line":107,"start_character":120,"end_line":107,"end_character":137},"updated":"2020-09-24 09:48:11.000000000","message":"listen","commit_id":"6b139bfbdea3a51e68ab5e44120ecb1e0da77c14"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"b524b474c1a10730b104bd5634cf864ba656197d","unresolved":false,"context_lines":[{"line_number":91,"context_line":"heat_api_healthcheck_interval: \"{{ default_container_healthcheck_interval }}\""},{"line_number":92,"context_line":"heat_api_healthcheck_retries: \"{{ default_container_healthcheck_retries }}\""},{"line_number":93,"context_line":"heat_api_healthcheck_start_period: \"{{ default_container_healthcheck_start_period }}\""},{"line_number":94,"context_line":"heat_api_healthcheck_test: [\"CMD-SHELL\", \"healthcheck_curl {{ internal_protocol }}://{{ api_interface_address }}:{{ heat_api_listen_port }}\"]"},{"line_number":95,"context_line":"heat_api_healthcheck_timeout: \"{{ default_container_healthcheck_timeout }}\""},{"line_number":96,"context_line":"heat_api_healthcheck:"},{"line_number":97,"context_line":"  interval: \"{{ heat_api_healthcheck_interval }}\""}],"source_content_type":"text/x-yaml","patch_set":99,"id":"9f560f44_b48b70be","line":94,"range":{"start_line":94,"start_character":62,"end_line":94,"end_character":79},"updated":"2020-10-01 10:47:16.000000000","message":"\u0027https\u0027 if heat_enable_tls_backend | bool else \u0027http\u0027","commit_id":"d27ecfcae6b2c3dbcfb2e221cbc46e67f29ec53f"},{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"6870bbcc8218ae21807ae5b88fbbb5c179f25a24","unresolved":false,"context_lines":[{"line_number":91,"context_line":"heat_api_healthcheck_interval: \"{{ default_container_healthcheck_interval }}\""},{"line_number":92,"context_line":"heat_api_healthcheck_retries: \"{{ default_container_healthcheck_retries }}\""},{"line_number":93,"context_line":"heat_api_healthcheck_start_period: \"{{ default_container_healthcheck_start_period }}\""},{"line_number":94,"context_line":"heat_api_healthcheck_test: [\"CMD-SHELL\", \"healthcheck_curl {{ internal_protocol }}://{{ api_interface_address }}:{{ heat_api_listen_port }}\"]"},{"line_number":95,"context_line":"heat_api_healthcheck_timeout: \"{{ default_container_healthcheck_timeout }}\""},{"line_number":96,"context_line":"heat_api_healthcheck:"},{"line_number":97,"context_line":"  interval: \"{{ heat_api_healthcheck_interval }}\""}],"source_content_type":"text/x-yaml","patch_set":99,"id":"9f560f44_7f4ed1c2","line":94,"range":{"start_line":94,"start_character":62,"end_line":94,"end_character":79},"in_reply_to":"9f560f44_b48b70be","updated":"2020-10-01 11:31:39.000000000","message":"Done","commit_id":"d27ecfcae6b2c3dbcfb2e221cbc46e67f29ec53f"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"739163c5cf2ebbe8b8a9194708c1b7b92de5c76b","unresolved":false,"context_lines":[{"line_number":91,"context_line":"heat_api_healthcheck_interval: \"{{ default_container_healthcheck_interval }}\""},{"line_number":92,"context_line":"heat_api_healthcheck_retries: \"{{ default_container_healthcheck_retries }}\""},{"line_number":93,"context_line":"heat_api_healthcheck_start_period: \"{{ default_container_healthcheck_start_period }}\""},{"line_number":94,"context_line":"heat_api_healthcheck_test: [\"CMD-SHELL\", \"healthcheck_curl \u0027https\u0027 if heat_enable_tls_backend | bool else \u0027http\u0027://{{ api_interface_address }}:{{ heat_api_listen_port }}\"]"},{"line_number":95,"context_line":"heat_api_healthcheck_timeout: \"{{ default_container_healthcheck_timeout }}\""},{"line_number":96,"context_line":"heat_api_healthcheck:"},{"line_number":97,"context_line":"  interval: \"{{ heat_api_healthcheck_interval }}\""}],"source_content_type":"text/x-yaml","patch_set":100,"id":"9f560f44_91511967","line":94,"range":{"start_line":94,"start_character":59,"end_line":94,"end_character":112},"updated":"2020-10-01 14:02:11.000000000","message":"{{ }}","commit_id":"d29ffac3a8ecbe0b9cb07d2118e963ff00805162"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"05b25bad03d056ffd41eb104fd45696c2843c934","unresolved":false,"context_lines":[{"line_number":104,"context_line":"heat_api_cfn_healthcheck_interval: \"{{ default_container_healthcheck_interval }}\""},{"line_number":105,"context_line":"heat_api_cfn_healthcheck_retries: \"{{ default_container_healthcheck_retries }}\""},{"line_number":106,"context_line":"heat_api_cfn_healthcheck_start_period: \"{{ default_container_healthcheck_start_period }}\""},{"line_number":107,"context_line":"heat_api_cfn_healthcheck_test: [\"CMD-SHELL\", \"healthcheck_curl {{ internal_protocol }}://{{ api_interface_address }}:{{ heat_api_cfn_listen_port }}\"]"},{"line_number":108,"context_line":"heat_api_cfn_healthcheck_timeout: \"{{ default_container_healthcheck_timeout }}\""},{"line_number":109,"context_line":"heat_api_cfn_healthcheck:"},{"line_number":110,"context_line":"  interval: \"{{ heat_api_cfn_healthcheck_interval }}\""}],"source_content_type":"text/x-yaml","patch_set":101,"id":"9f560f44_987936c7","line":107,"range":{"start_line":107,"start_character":66,"end_line":107,"end_character":83},"updated":"2020-10-01 18:26:00.000000000","message":"\u0027https\u0027 if heat_enable_tls_backend | bool else \u0027http\u0027","commit_id":"f2280560db8ad8c6b19fdd2dbb2566df3c97d0ff"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"77319a904f060950d760031b7d540162d01146cc","unresolved":false,"context_lines":[{"line_number":91,"context_line":"heat_api_healthcheck_interval: \"{{ default_container_healthcheck_interval }}\""},{"line_number":92,"context_line":"heat_api_healthcheck_retries: \"{{ default_container_healthcheck_retries }}\""},{"line_number":93,"context_line":"heat_api_healthcheck_start_period: \"{{ default_container_healthcheck_start_period }}\""},{"line_number":94,"context_line":"heat_api_healthcheck_test: [\"CMD-SHELL\", \"healthcheck_curl {{ \u0027https\u0027 if heat_enable_tls_backend | bool else \u0027http\u0027 }}://[{{ api_interface_address }}]:{{ heat_api_listen_port }}\"]"},{"line_number":95,"context_line":"heat_api_healthcheck_timeout: \"{{ default_container_healthcheck_timeout }}\""},{"line_number":96,"context_line":"heat_api_healthcheck:"},{"line_number":97,"context_line":"  interval: \"{{ heat_api_healthcheck_interval }}\""}],"source_content_type":"text/x-yaml","patch_set":104,"id":"9f560f44_6e7280b2","line":94,"range":{"start_line":94,"start_character":125,"end_line":94,"end_character":146},"updated":"2020-10-05 08:26:04.000000000","message":"I don\u0027t think this will be valid for IPv4. Doesn\u0027t it need a put_address_in_context(\u0027url\u0027) filter?","commit_id":"746da0371efbd7a8d619add819330fdb4d5e4918"}],"ansible/roles/horizon/defaults/main.yml":[{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"f81e08cd7a3653ad0e7e13c9188f1c24919dbc4d","unresolved":false,"context_lines":[{"line_number":92,"context_line":"horizon_healthcheck_interval: \"{{ default_container_healthcheck_interval }}\""},{"line_number":93,"context_line":"horizon_healthcheck_retries: \"{{ default_container_healthcheck_retries }}\""},{"line_number":94,"context_line":"horizon_healthcheck_start_period: \"{{ default_container_healthcheck_start_period }}\""},{"line_number":95,"context_line":"horizon_healthcheck_test: [\"CMD-SHELL\", \"healthcheck_curl {{ internal_protocol }}://{{ api_interface_address }}:{{ horizon_port }}\"]"},{"line_number":96,"context_line":"horizon_healthcheck_timeout: \"{{ default_container_healthcheck_timeout }}\""},{"line_number":97,"context_line":"horizon_healthcheck:"},{"line_number":98,"context_line":"  interval: \"{{ horizon_healthcheck_interval }}\""}],"source_content_type":"text/x-yaml","patch_set":85,"id":"9f560f44_a9b6e923","line":95,"range":{"start_line":95,"start_character":115,"end_line":95,"end_character":127},"updated":"2020-09-24 09:48:11.000000000","message":"listen","commit_id":"6b139bfbdea3a51e68ab5e44120ecb1e0da77c14"}],"ansible/roles/keystone/defaults/main.yml":[{"author":{"_account_id":24072,"name":"Marcin Juszkiewicz","email":"mjuszkiewicz@redhat.com","username":"hrw"},"change_message_id":"c793c4183923e25e4109c3da4d321e4730d56218","unresolved":false,"context_lines":[{"line_number":53,"context_line":"      - \"keystone_fernet_tokens:/etc/keystone/fernet-keys\""},{"line_number":54,"context_line":"    dimensions: \"{{ keystone_fernet_dimensions }}\""},{"line_number":55,"context_line":"    healthcheck: \"{{ keystone_fernet_healthcheck }}\""},{"line_number":56,"context_line":""},{"line_number":57,"context_line":"####################"},{"line_number":58,"context_line":"# Database"},{"line_number":59,"context_line":"####################"}],"source_content_type":"text/x-yaml","patch_set":44,"id":"3fa7e38b_8ed495bc","line":56,"updated":"2019-12-11 10:09:11.000000000","message":"\"|default: {}\" as it is not set to anything below?","commit_id":"56b09a806293737ac9e31e460bcbc7aa2f157c54"},{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"c423c0f8836ce8d94092f680f25f4e04d151b95e","unresolved":false,"context_lines":[{"line_number":53,"context_line":"      - \"keystone_fernet_tokens:/etc/keystone/fernet-keys\""},{"line_number":54,"context_line":"    dimensions: \"{{ keystone_fernet_dimensions }}\""},{"line_number":55,"context_line":"    healthcheck: \"{{ keystone_fernet_healthcheck }}\""},{"line_number":56,"context_line":""},{"line_number":57,"context_line":"####################"},{"line_number":58,"context_line":"# Database"},{"line_number":59,"context_line":"####################"}],"source_content_type":"text/x-yaml","patch_set":44,"id":"3fa7e38b_b4b2fe94","line":56,"in_reply_to":"3fa7e38b_8ed495bc","updated":"2019-12-11 12:25:11.000000000","message":"ok, reworked other services that were set as {}","commit_id":"56b09a806293737ac9e31e460bcbc7aa2f157c54"},{"author":{"_account_id":24072,"name":"Marcin Juszkiewicz","email":"mjuszkiewicz@redhat.com","username":"hrw"},"change_message_id":"693f1579007b4e2847237dad37a0527103f693a5","unresolved":false,"context_lines":[{"line_number":52,"context_line":"      - \"kolla_logs:/var/log/kolla/\""},{"line_number":53,"context_line":"      - \"keystone_fernet_tokens:/etc/keystone/fernet-keys\""},{"line_number":54,"context_line":"    dimensions: \"{{ keystone_fernet_dimensions }}\""},{"line_number":55,"context_line":"    healthcheck: \"{{ keystone_fernet_healthcheck | default({}) }}\""},{"line_number":56,"context_line":""},{"line_number":57,"context_line":"####################"},{"line_number":58,"context_line":"# Database"}],"source_content_type":"text/x-yaml","patch_set":49,"id":"1fa4df85_336758ba","line":55,"range":{"start_line":55,"start_character":21,"end_line":55,"end_character":48},"updated":"2020-03-19 10:31:34.000000000","message":"not defined","commit_id":"7b8800507307e90a50dc7916092626dafbc1ac5f"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"f81e08cd7a3653ad0e7e13c9188f1c24919dbc4d","unresolved":false,"context_lines":[{"line_number":99,"context_line":"keystone_healthcheck_interval: \"{{ default_container_healthcheck_interval }}\""},{"line_number":100,"context_line":"keystone_healthcheck_retries: \"{{ default_container_healthcheck_retries }}\""},{"line_number":101,"context_line":"keystone_healthcheck_start_period: \"{{ default_container_healthcheck_start_period }}\""},{"line_number":102,"context_line":"keystone_healthcheck_test: [\"CMD-SHELL\", \"healthcheck_curl {{ internal_protocol }}://{{ api_interface_address }}:{{ keystone_public_port }}\"]"},{"line_number":103,"context_line":"keystone_healthcheck_timeout: \"{{ default_container_healthcheck_timeout }}\""},{"line_number":104,"context_line":"keystone_healthcheck:"},{"line_number":105,"context_line":"  interval: \"{{ keystone_healthcheck_interval }}\""}],"source_content_type":"text/x-yaml","patch_set":85,"id":"9f560f44_29401906","line":102,"range":{"start_line":102,"start_character":116,"end_line":102,"end_character":136},"updated":"2020-09-24 09:48:11.000000000","message":"listen","commit_id":"6b139bfbdea3a51e68ab5e44120ecb1e0da77c14"}],"ansible/roles/keystone/handlers/main.yml":[{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"b524b474c1a10730b104bd5634cf864ba656197d","unresolved":false,"context_lines":[{"line_number":21,"context_line":"    restart_policy: no"},{"line_number":22,"context_line":"    volumes: \"{{ service.volumes|reject(\u0027equalto\u0027, \u0027\u0027)|list }}\""},{"line_number":23,"context_line":"    dimensions: \"{{ service.dimensions }}\""},{"line_number":24,"context_line":"    healthcheck: \"{{ service.healthcheck | default(omit) }}\""},{"line_number":25,"context_line":"  run_once: True"},{"line_number":26,"context_line":"  when:"},{"line_number":27,"context_line":"    - kolla_action \u003d\u003d \"upgrade\""}],"source_content_type":"text/x-yaml","patch_set":99,"id":"9f560f44_f4632818","line":24,"updated":"2020-10-01 10:47:16.000000000","message":"Do we want a healthcheck for DB upgrades?","commit_id":"d27ecfcae6b2c3dbcfb2e221cbc46e67f29ec53f"},{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"6870bbcc8218ae21807ae5b88fbbb5c179f25a24","unresolved":false,"context_lines":[{"line_number":21,"context_line":"    restart_policy: no"},{"line_number":22,"context_line":"    volumes: \"{{ service.volumes|reject(\u0027equalto\u0027, \u0027\u0027)|list }}\""},{"line_number":23,"context_line":"    dimensions: \"{{ service.dimensions }}\""},{"line_number":24,"context_line":"    healthcheck: \"{{ service.healthcheck | default(omit) }}\""},{"line_number":25,"context_line":"  run_once: True"},{"line_number":26,"context_line":"  when:"},{"line_number":27,"context_line":"    - kolla_action \u003d\u003d \"upgrade\""}],"source_content_type":"text/x-yaml","patch_set":99,"id":"9f560f44_7ff2519d","line":24,"in_reply_to":"9f560f44_f4632818","updated":"2020-10-01 11:31:39.000000000","message":"Not necessarily ;-)","commit_id":"d27ecfcae6b2c3dbcfb2e221cbc46e67f29ec53f"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"b524b474c1a10730b104bd5634cf864ba656197d","unresolved":false,"context_lines":[{"line_number":94,"context_line":"    restart_policy: no"},{"line_number":95,"context_line":"    volumes: \"{{ service.volumes|reject(\u0027equalto\u0027, \u0027\u0027)|list }}\""},{"line_number":96,"context_line":"    dimensions: \"{{ service.dimensions }}\""},{"line_number":97,"context_line":"    healthcheck: \"{{ service.healthcheck | default(omit) }}\""},{"line_number":98,"context_line":"  run_once: True"},{"line_number":99,"context_line":"  when:"},{"line_number":100,"context_line":"    - kolla_action \u003d\u003d \"upgrade\""}],"source_content_type":"text/x-yaml","patch_set":99,"id":"9f560f44_9472ace3","line":97,"updated":"2020-10-01 10:47:16.000000000","message":"ditto","commit_id":"d27ecfcae6b2c3dbcfb2e221cbc46e67f29ec53f"},{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"6870bbcc8218ae21807ae5b88fbbb5c179f25a24","unresolved":false,"context_lines":[{"line_number":94,"context_line":"    restart_policy: no"},{"line_number":95,"context_line":"    volumes: \"{{ service.volumes|reject(\u0027equalto\u0027, \u0027\u0027)|list }}\""},{"line_number":96,"context_line":"    dimensions: \"{{ service.dimensions }}\""},{"line_number":97,"context_line":"    healthcheck: \"{{ service.healthcheck | default(omit) }}\""},{"line_number":98,"context_line":"  run_once: True"},{"line_number":99,"context_line":"  when:"},{"line_number":100,"context_line":"    - kolla_action \u003d\u003d \"upgrade\""}],"source_content_type":"text/x-yaml","patch_set":99,"id":"9f560f44_1f27d520","line":97,"in_reply_to":"9f560f44_9472ace3","updated":"2020-10-01 11:31:39.000000000","message":"Done","commit_id":"d27ecfcae6b2c3dbcfb2e221cbc46e67f29ec53f"}],"ansible/roles/memcached/defaults/main.yml":[{"author":{"_account_id":24072,"name":"Marcin Juszkiewicz","email":"mjuszkiewicz@redhat.com","username":"hrw"},"change_message_id":"693f1579007b4e2847237dad37a0527103f693a5","unresolved":false,"context_lines":[{"line_number":39,"context_line":"memcached_healthcheck_interval: \"{{ default_container_healthcheck_interval }}\""},{"line_number":40,"context_line":"memcached_healthcheck_retries: \"{{ default_container_healthcheck_retries }}\""},{"line_number":41,"context_line":"memcached_healthcheck_start_period: \"{{ default_container_healthcheck_start_period }}\""},{"line_number":42,"context_line":"memcachedtool_path: \"{% if kolla_base_distro \u003d\u003d \u0027centos\u0027 %}memcached-tool{% else %}/usr/share/memcached/scripts/memcached-tool{% endif %}\""},{"line_number":43,"context_line":"memcached_healthcheck_test: [\"CMD-SHELL\", \"{{ memcachedtool_path }} {{ api_interface_address }}:{{ memcached_port }}\"]"},{"line_number":44,"context_line":"memcached_healthcheck_timeout: \"{{ default_container_healthcheck_timeout }}\""},{"line_number":45,"context_line":"memcached_healthcheck:"}],"source_content_type":"text/x-yaml","patch_set":49,"id":"1fa4df85_d305a4c3","line":42,"range":{"start_line":42,"start_character":0,"end_line":42,"end_character":18},"updated":"2020-03-19 10:31:34.000000000","message":"_path suggests fullpath rather binary name","commit_id":"7b8800507307e90a50dc7916092626dafbc1ac5f"}],"ansible/roles/neutron/defaults/main.yml":[{"author":{"_account_id":24072,"name":"Marcin Juszkiewicz","email":"mjuszkiewicz@redhat.com","username":"hrw"},"change_message_id":"693f1579007b4e2847237dad37a0527103f693a5","unresolved":false,"context_lines":[{"line_number":140,"context_line":"    host_in_groups: \"{{ inventory_hostname in groups[\u0027neutron-bgp-dragent\u0027] }}\""},{"line_number":141,"context_line":"    volumes: \"{{ neutron_bgp_dragent_default_volumes + neutron_bgp_dragent_extra_volumes }}\""},{"line_number":142,"context_line":"    dimensions: \"{{ neutron_bgp_dragent_dimensions }}\""},{"line_number":143,"context_line":"    healthcheck: \"{{ neutron_bgp_dragent_healthcheck | default({}) }}\""},{"line_number":144,"context_line":"  neutron-infoblox-ipam-agent:"},{"line_number":145,"context_line":"    container_name: \"neutron_infoblox_ipam_agent\""},{"line_number":146,"context_line":"    image: \"{{ neutron_infoblox_ipam_agent_image_full }}\""}],"source_content_type":"text/x-yaml","patch_set":49,"id":"1fa4df85_331518e6","line":143,"range":{"start_line":143,"start_character":21,"end_line":143,"end_character":52},"updated":"2020-03-19 10:31:34.000000000","message":"where it is defined?","commit_id":"7b8800507307e90a50dc7916092626dafbc1ac5f"},{"author":{"_account_id":24072,"name":"Marcin Juszkiewicz","email":"mjuszkiewicz@redhat.com","username":"hrw"},"change_message_id":"693f1579007b4e2847237dad37a0527103f693a5","unresolved":false,"context_lines":[{"line_number":150,"context_line":"    host_in_groups: \"{{ inventory_hostname in groups[\u0027neutron-infoblox-ipam-agent\u0027] }}\""},{"line_number":151,"context_line":"    volumes: \"{{ neutron_infoblox_ipam_agent_default_volumes + neutron_infoblox_ipam_agent_extra_volumes }}\""},{"line_number":152,"context_line":"    dimensions: \"{{ neutron_infoblox_ipam_agent_dimensions }}\""},{"line_number":153,"context_line":"    healthcheck: \"{{ neutron_infoblox_ipam_agent_healthcheck | default({}) }}\""},{"line_number":154,"context_line":"  neutron-metering-agent:"},{"line_number":155,"context_line":"    container_name: \"neutron_metering_agent\""},{"line_number":156,"context_line":"    image: \"{{ neutron_metering_agent_image_full }}\""}],"source_content_type":"text/x-yaml","patch_set":49,"id":"1fa4df85_53221454","line":153,"range":{"start_line":153,"start_character":21,"end_line":153,"end_character":60},"updated":"2020-03-19 10:31:34.000000000","message":"where it is defined?","commit_id":"7b8800507307e90a50dc7916092626dafbc1ac5f"},{"author":{"_account_id":24072,"name":"Marcin Juszkiewicz","email":"mjuszkiewicz@redhat.com","username":"hrw"},"change_message_id":"693f1579007b4e2847237dad37a0527103f693a5","unresolved":false,"context_lines":[{"line_number":160,"context_line":"    host_in_groups: \"{{ inventory_hostname in groups[\u0027neutron-metering-agent\u0027] }}\""},{"line_number":161,"context_line":"    volumes: \"{{ neutron_metering_agent_default_volumes + neutron_metering_agent_extra_volumes }}\""},{"line_number":162,"context_line":"    dimensions: \"{{ neutron_metering_agent_dimensions }}\""},{"line_number":163,"context_line":"    healthcheck: \"{{ neutron_metering_agent_healthcheck | default({}) }}\""},{"line_number":164,"context_line":"  ironic-neutron-agent:"},{"line_number":165,"context_line":"    container_name: \"ironic_neutron_agent\""},{"line_number":166,"context_line":"    image: \"{{ ironic_neutron_agent_image_full }}\""}],"source_content_type":"text/x-yaml","patch_set":49,"id":"1fa4df85_b3dee83b","line":163,"range":{"start_line":163,"start_character":21,"end_line":163,"end_character":55},"updated":"2020-03-19 10:31:34.000000000","message":"where it is defined?","commit_id":"7b8800507307e90a50dc7916092626dafbc1ac5f"},{"author":{"_account_id":24072,"name":"Marcin Juszkiewicz","email":"mjuszkiewicz@redhat.com","username":"hrw"},"change_message_id":"693f1579007b4e2847237dad37a0527103f693a5","unresolved":false,"context_lines":[{"line_number":170,"context_line":"    host_in_groups: \"{{ inventory_hostname in groups[\u0027ironic-neutron-agent\u0027] }}\""},{"line_number":171,"context_line":"    volumes: \"{{ ironic_neutron_agent_default_volumes + ironic_neutron_agent_extra_volumes }}\""},{"line_number":172,"context_line":"    dimensions: \"{{ ironic_neutron_agent_dimensions }}\""},{"line_number":173,"context_line":"    healthcheck: \"{{ ironic_neutron_agent_healthcheck  | default({}) }}\""},{"line_number":174,"context_line":""},{"line_number":175,"context_line":"####################"},{"line_number":176,"context_line":"# Database"}],"source_content_type":"text/x-yaml","patch_set":49,"id":"1fa4df85_33c3d859","line":173,"range":{"start_line":173,"start_character":21,"end_line":173,"end_character":53},"updated":"2020-03-19 10:31:34.000000000","message":"where it is defined?","commit_id":"7b8800507307e90a50dc7916092626dafbc1ac5f"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"8b896a759a269b429a987fcb973fef533ed34baf","unresolved":false,"context_lines":[{"line_number":127,"context_line":"      or (inventory_hostname in groups[\u0027compute\u0027] and neutron_plugin_agent \u003d\u003d \u0027openvswitch\u0027 and enable_neutron_dvr | bool)"},{"line_number":128,"context_line":"      }}"},{"line_number":129,"context_line":"    volumes: \"{{ neutron_metadata_agent_default_volumes + neutron_metadata_agent_extra_volumes }}\""},{"line_number":130,"context_line":"    dimensions: \"{{ neutron_metadata_agent_dimensions }}\""},{"line_number":131,"context_line":"  neutron-ovn-metadata-agent:"},{"line_number":132,"context_line":"    container_name: \"neutron_ovn_metadata_agent\""},{"line_number":133,"context_line":"    image: \"{{ neutron_ovn_metadata_agent_image_full }}\""}],"source_content_type":"text/x-yaml","patch_set":76,"id":"9f560f44_8c9c206b","line":130,"updated":"2020-09-21 09:36:54.000000000","message":"none here","commit_id":"b88777c50c831f7ee7740df168ffd24baf66cb99"},{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"f173f25958465c321e67fdf26bcb69b8e218cf18","unresolved":false,"context_lines":[{"line_number":127,"context_line":"      or (inventory_hostname in groups[\u0027compute\u0027] and neutron_plugin_agent \u003d\u003d \u0027openvswitch\u0027 and enable_neutron_dvr | bool)"},{"line_number":128,"context_line":"      }}"},{"line_number":129,"context_line":"    volumes: \"{{ neutron_metadata_agent_default_volumes + neutron_metadata_agent_extra_volumes }}\""},{"line_number":130,"context_line":"    dimensions: \"{{ neutron_metadata_agent_dimensions }}\""},{"line_number":131,"context_line":"  neutron-ovn-metadata-agent:"},{"line_number":132,"context_line":"    container_name: \"neutron_ovn_metadata_agent\""},{"line_number":133,"context_line":"    image: \"{{ neutron_ovn_metadata_agent_image_full }}\""}],"source_content_type":"text/x-yaml","patch_set":76,"id":"9f560f44_e8880d23","line":130,"in_reply_to":"9f560f44_8c9c206b","updated":"2020-09-23 15:55:54.000000000","message":"Done","commit_id":"b88777c50c831f7ee7740df168ffd24baf66cb99"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"f81e08cd7a3653ad0e7e13c9188f1c24919dbc4d","unresolved":false,"context_lines":[{"line_number":127,"context_line":"      or (inventory_hostname in groups[\u0027compute\u0027] and neutron_plugin_agent \u003d\u003d \u0027openvswitch\u0027 and enable_neutron_dvr | bool)"},{"line_number":128,"context_line":"      }}"},{"line_number":129,"context_line":"    volumes: \"{{ neutron_metadata_agent_default_volumes + neutron_metadata_agent_extra_volumes }}\""},{"line_number":130,"context_line":"    dimensions: \"{{ neutron_metadata_agent_dimensions }}\""},{"line_number":131,"context_line":"  neutron-ovn-metadata-agent:"},{"line_number":132,"context_line":"    container_name: \"neutron_ovn_metadata_agent\""},{"line_number":133,"context_line":"    image: \"{{ neutron_ovn_metadata_agent_image_full }}\""}],"source_content_type":"text/x-yaml","patch_set":76,"id":"9f560f44_a94b8925","line":130,"in_reply_to":"9f560f44_e8880d23","updated":"2020-09-24 09:48:11.000000000","message":"Not done :)","commit_id":"b88777c50c831f7ee7740df168ffd24baf66cb99"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"8b896a759a269b429a987fcb973fef533ed34baf","unresolved":false,"context_lines":[{"line_number":136,"context_line":"    host_in_groups: \"{{ inventory_hostname in groups[\u0027neutron-ovn-metadata-agent\u0027] }}\""},{"line_number":137,"context_line":"    volumes: \"{{ neutron_ovn_metadata_agent_default_volumes + neutron_ovn_metadata_agent_extra_volumes }}\""},{"line_number":138,"context_line":"    dimensions: \"{{ neutron_ovn_metadata_agent_dimensions }}\""},{"line_number":139,"context_line":"    healthcheck: \"{{ neutron_metadata_agent_healthcheck }}\""},{"line_number":140,"context_line":"  neutron-bgp-dragent:"},{"line_number":141,"context_line":"    container_name: \"neutron_bgp_dragent\""},{"line_number":142,"context_line":"    image: \"{{ neutron_bgp_dragent_image_full }}\""}],"source_content_type":"text/x-yaml","patch_set":76,"id":"9f560f44_ccb9f8ec","line":139,"updated":"2020-09-21 09:36:54.000000000","message":"This is OVN agent.","commit_id":"b88777c50c831f7ee7740df168ffd24baf66cb99"},{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"f173f25958465c321e67fdf26bcb69b8e218cf18","unresolved":false,"context_lines":[{"line_number":136,"context_line":"    host_in_groups: \"{{ inventory_hostname in groups[\u0027neutron-ovn-metadata-agent\u0027] }}\""},{"line_number":137,"context_line":"    volumes: \"{{ neutron_ovn_metadata_agent_default_volumes + neutron_ovn_metadata_agent_extra_volumes }}\""},{"line_number":138,"context_line":"    dimensions: \"{{ neutron_ovn_metadata_agent_dimensions }}\""},{"line_number":139,"context_line":"    healthcheck: \"{{ neutron_metadata_agent_healthcheck }}\""},{"line_number":140,"context_line":"  neutron-bgp-dragent:"},{"line_number":141,"context_line":"    container_name: \"neutron_bgp_dragent\""},{"line_number":142,"context_line":"    image: \"{{ neutron_bgp_dragent_image_full }}\""}],"source_content_type":"text/x-yaml","patch_set":76,"id":"9f560f44_8896b148","line":139,"in_reply_to":"9f560f44_ccb9f8ec","updated":"2020-09-23 15:55:54.000000000","message":"Done","commit_id":"b88777c50c831f7ee7740df168ffd24baf66cb99"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"8b896a759a269b429a987fcb973fef533ed34baf","unresolved":false,"context_lines":[{"line_number":322,"context_line":"  timeout: \"{{ neutron_openvswitch_agent_healthcheck_timeout }}\""},{"line_number":323,"context_line":""},{"line_number":324,"context_line":"neutron_openvswitch_agent_xenapi_healthcheck_interval: \"{{ default_container_healthcheck_interval }}\""},{"line_number":325,"context_line":"neutron_openvswitch_agent_xenapi_healthcheck_retries: \"{{ default_container_healthcheck_retries }}\""},{"line_number":326,"context_line":"neutron_openvswitch_agent_xenapi_healthcheck_start_period: \"{{ default_container_healthcheck_start_period }}\""},{"line_number":327,"context_line":"neutron_openvswitch_agent_xenapi_healthcheck_test: [\"CMD-SHELL\", \"healthcheck_port neutron-openvswitch-agent {{ rabbitmq_port }}\"]"},{"line_number":328,"context_line":"neutron_openvswitch_agent_xenapi_healthcheck_timeout: \"{{ default_container_healthcheck_timeout }}\""},{"line_number":329,"context_line":"neutron_openvswitch_agent_xenapi_healthcheck:"},{"line_number":330,"context_line":"  interval: \"{{ neutron_openvswitch_agent_xenapi_healthcheck_interval }}\""},{"line_number":331,"context_line":"  retries: \"{{ neutron_openvswitch_agent_xenapi_healthcheck_retries }}\""},{"line_number":332,"context_line":"  start_period: \"{{ neutron_openvswitch_agent_xenapi_healthcheck_start_period }}\""},{"line_number":333,"context_line":"  test: \"{% if enable_container_healthchecks | bool %}{{ neutron_openvswitch_agent_xenapi_healthcheck_test }}{% else %}NONE{% endif %}\""},{"line_number":334,"context_line":"  timeout: \"{{ neutron_openvswitch_agent_xenapi_healthcheck_timeout }}\""},{"line_number":335,"context_line":""},{"line_number":336,"context_line":"neutron_server_healthcheck_interval: \"{{ default_container_healthcheck_interval }}\""},{"line_number":337,"context_line":"neutron_server_healthcheck_retries: \"{{ default_container_healthcheck_retries }}\""}],"source_content_type":"text/x-yaml","patch_set":76,"id":"9f560f44_2cc87473","line":334,"range":{"start_line":325,"start_character":0,"end_line":334,"end_character":71},"updated":"2020-09-21 09:36:54.000000000","message":"xen is gone","commit_id":"b88777c50c831f7ee7740df168ffd24baf66cb99"},{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"f173f25958465c321e67fdf26bcb69b8e218cf18","unresolved":false,"context_lines":[{"line_number":322,"context_line":"  timeout: \"{{ neutron_openvswitch_agent_healthcheck_timeout }}\""},{"line_number":323,"context_line":""},{"line_number":324,"context_line":"neutron_openvswitch_agent_xenapi_healthcheck_interval: \"{{ default_container_healthcheck_interval }}\""},{"line_number":325,"context_line":"neutron_openvswitch_agent_xenapi_healthcheck_retries: \"{{ default_container_healthcheck_retries }}\""},{"line_number":326,"context_line":"neutron_openvswitch_agent_xenapi_healthcheck_start_period: \"{{ default_container_healthcheck_start_period }}\""},{"line_number":327,"context_line":"neutron_openvswitch_agent_xenapi_healthcheck_test: [\"CMD-SHELL\", \"healthcheck_port neutron-openvswitch-agent {{ rabbitmq_port }}\"]"},{"line_number":328,"context_line":"neutron_openvswitch_agent_xenapi_healthcheck_timeout: \"{{ default_container_healthcheck_timeout }}\""},{"line_number":329,"context_line":"neutron_openvswitch_agent_xenapi_healthcheck:"},{"line_number":330,"context_line":"  interval: \"{{ neutron_openvswitch_agent_xenapi_healthcheck_interval }}\""},{"line_number":331,"context_line":"  retries: \"{{ neutron_openvswitch_agent_xenapi_healthcheck_retries }}\""},{"line_number":332,"context_line":"  start_period: \"{{ neutron_openvswitch_agent_xenapi_healthcheck_start_period }}\""},{"line_number":333,"context_line":"  test: \"{% if enable_container_healthchecks | bool %}{{ neutron_openvswitch_agent_xenapi_healthcheck_test }}{% else %}NONE{% endif %}\""},{"line_number":334,"context_line":"  timeout: \"{{ neutron_openvswitch_agent_xenapi_healthcheck_timeout }}\""},{"line_number":335,"context_line":""},{"line_number":336,"context_line":"neutron_server_healthcheck_interval: \"{{ default_container_healthcheck_interval }}\""},{"line_number":337,"context_line":"neutron_server_healthcheck_retries: \"{{ default_container_healthcheck_retries }}\""}],"source_content_type":"text/x-yaml","patch_set":76,"id":"9f560f44_4890194f","line":334,"range":{"start_line":325,"start_character":0,"end_line":334,"end_character":71},"in_reply_to":"9f560f44_2cc87473","updated":"2020-09-23 15:55:54.000000000","message":"Done","commit_id":"b88777c50c831f7ee7740df168ffd24baf66cb99"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"b524b474c1a10730b104bd5634cf864ba656197d","unresolved":false,"context_lines":[{"line_number":127,"context_line":"      or (inventory_hostname in groups[\u0027compute\u0027] and neutron_plugin_agent \u003d\u003d \u0027openvswitch\u0027 and enable_neutron_dvr | bool)"},{"line_number":128,"context_line":"      }}"},{"line_number":129,"context_line":"    volumes: \"{{ neutron_metadata_agent_default_volumes + neutron_metadata_agent_extra_volumes }}\""},{"line_number":130,"context_line":"    dimensions: \"{{ neutron_metadata_agent_dimensions }}\""},{"line_number":131,"context_line":"  neutron-ovn-metadata-agent:"},{"line_number":132,"context_line":"    container_name: \"neutron_ovn_metadata_agent\""},{"line_number":133,"context_line":"    image: \"{{ neutron_ovn_metadata_agent_image_full }}\""}],"source_content_type":"text/x-yaml","patch_set":99,"id":"9f560f44_5442d469","line":130,"updated":"2020-10-01 10:47:16.000000000","message":"still no healthcheck for metadata agent!","commit_id":"d27ecfcae6b2c3dbcfb2e221cbc46e67f29ec53f"},{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"6870bbcc8218ae21807ae5b88fbbb5c179f25a24","unresolved":false,"context_lines":[{"line_number":127,"context_line":"      or (inventory_hostname in groups[\u0027compute\u0027] and neutron_plugin_agent \u003d\u003d \u0027openvswitch\u0027 and enable_neutron_dvr | bool)"},{"line_number":128,"context_line":"      }}"},{"line_number":129,"context_line":"    volumes: \"{{ neutron_metadata_agent_default_volumes + neutron_metadata_agent_extra_volumes }}\""},{"line_number":130,"context_line":"    dimensions: \"{{ neutron_metadata_agent_dimensions }}\""},{"line_number":131,"context_line":"  neutron-ovn-metadata-agent:"},{"line_number":132,"context_line":"    container_name: \"neutron_ovn_metadata_agent\""},{"line_number":133,"context_line":"    image: \"{{ neutron_ovn_metadata_agent_image_full }}\""}],"source_content_type":"text/x-yaml","patch_set":99,"id":"9f560f44_1f1075ab","line":130,"in_reply_to":"9f560f44_5442d469","updated":"2020-10-01 11:31:39.000000000","message":"Done","commit_id":"d27ecfcae6b2c3dbcfb2e221cbc46e67f29ec53f"}],"ansible/roles/nova-cell/defaults/main.yml":[{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"8b896a759a269b429a987fcb973fef533ed34baf","unresolved":false,"context_lines":[{"line_number":269,"context_line":"nova_novncproxy_healthcheck_interval: \"{{ default_container_healthcheck_interval }}\""},{"line_number":270,"context_line":"nova_novncproxy_healthcheck_retries: \"{{ default_container_healthcheck_retries }}\""},{"line_number":271,"context_line":"nova_novncproxy_healthcheck_start_period: \"{{ default_container_healthcheck_start_period }}\""},{"line_number":272,"context_line":"nova_novncproxy_healthcheck_test: [\"CMD-SHELL\", \"healthcheck_curl {{ public_protocol }}://{{ nova_novncproxy_fqdn | put_address_in_context(\u0027url\u0027) }}:{{ nova_novncproxy_port }}/vnc_auto.html\"]"},{"line_number":273,"context_line":"nova_novncproxy_healthcheck_timeout: \"{{ default_container_healthcheck_timeout }}\""},{"line_number":274,"context_line":"nova_novncproxy_healthcheck:"},{"line_number":275,"context_line":"  interval: \"{{ nova_novncproxy_healthcheck_interval }}\""}],"source_content_type":"text/x-yaml","patch_set":76,"id":"9f560f44_ccb578d2","line":272,"updated":"2020-09-21 09:36:54.000000000","message":"fqdn?","commit_id":"b88777c50c831f7ee7740df168ffd24baf66cb99"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"f81e08cd7a3653ad0e7e13c9188f1c24919dbc4d","unresolved":false,"context_lines":[{"line_number":272,"context_line":"nova_novncproxy_healthcheck_interval: \"{{ default_container_healthcheck_interval }}\""},{"line_number":273,"context_line":"nova_novncproxy_healthcheck_retries: \"{{ default_container_healthcheck_retries }}\""},{"line_number":274,"context_line":"nova_novncproxy_healthcheck_start_period: \"{{ default_container_healthcheck_start_period }}\""},{"line_number":275,"context_line":"nova_novncproxy_healthcheck_test: [\"CMD-SHELL\", \"healthcheck_curl {{ public_protocol }}://{{ nova_novncproxy_fqdn | put_address_in_context(\u0027url\u0027) }}:{{ nova_novncproxy_port }}/vnc_auto.html\"]"},{"line_number":276,"context_line":"nova_novncproxy_healthcheck_timeout: \"{{ default_container_healthcheck_timeout }}\""},{"line_number":277,"context_line":"nova_novncproxy_healthcheck:"},{"line_number":278,"context_line":"  interval: \"{{ nova_novncproxy_healthcheck_interval }}\""}],"source_content_type":"text/x-yaml","patch_set":85,"id":"9f560f44_691cd112","line":275,"range":{"start_line":275,"start_character":152,"end_line":275,"end_character":172},"updated":"2020-09-24 09:48:11.000000000","message":"listen","commit_id":"6b139bfbdea3a51e68ab5e44120ecb1e0da77c14"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"f81e08cd7a3653ad0e7e13c9188f1c24919dbc4d","unresolved":false,"context_lines":[{"line_number":272,"context_line":"nova_novncproxy_healthcheck_interval: \"{{ default_container_healthcheck_interval }}\""},{"line_number":273,"context_line":"nova_novncproxy_healthcheck_retries: \"{{ default_container_healthcheck_retries }}\""},{"line_number":274,"context_line":"nova_novncproxy_healthcheck_start_period: \"{{ default_container_healthcheck_start_period }}\""},{"line_number":275,"context_line":"nova_novncproxy_healthcheck_test: [\"CMD-SHELL\", \"healthcheck_curl {{ public_protocol }}://{{ nova_novncproxy_fqdn | put_address_in_context(\u0027url\u0027) }}:{{ nova_novncproxy_port }}/vnc_auto.html\"]"},{"line_number":276,"context_line":"nova_novncproxy_healthcheck_timeout: \"{{ default_container_healthcheck_timeout }}\""},{"line_number":277,"context_line":"nova_novncproxy_healthcheck:"},{"line_number":278,"context_line":"  interval: \"{{ nova_novncproxy_healthcheck_interval }}\""}],"source_content_type":"text/x-yaml","patch_set":85,"id":"9f560f44_69e171fc","line":275,"range":{"start_line":275,"start_character":66,"end_line":275,"end_character":148},"updated":"2020-09-24 09:48:11.000000000","message":"should use internal \u0026  api_interface_address","commit_id":"6b139bfbdea3a51e68ab5e44120ecb1e0da77c14"}],"ansible/roles/nova-cell/handlers/main.yml":[{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"8b896a759a269b429a987fcb973fef533ed34baf","unresolved":false,"context_lines":[{"line_number":121,"context_line":"    action: \"recreate_or_restart_container\""},{"line_number":122,"context_line":"    common_options: \"{{ docker_common_options }}\""},{"line_number":123,"context_line":"    name: \"{{ service.container_name }}\""},{"line_number":124,"context_line":"    environment: \"{{ service.environment }}\""},{"line_number":125,"context_line":"    image: \"{{ service.image }}\""},{"line_number":126,"context_line":"    privileged: \"{{ service.privileged | default(False) }}\""},{"line_number":127,"context_line":"    ipc_mode: \"{{ service.ipc_mode }}\""},{"line_number":128,"context_line":"    volumes: \"{{ service.volumes|reject(\u0027equalto\u0027, \u0027\u0027)|list }}\""},{"line_number":129,"context_line":"    dimensions: \"{{ service.dimensions }}\""},{"line_number":130,"context_line":"    healthcheck: \"{{ service.healthcheck | default(omit) }}\""}],"source_content_type":"text/x-yaml","patch_set":76,"id":"9f560f44_acdda414","line":127,"range":{"start_line":124,"start_character":0,"end_line":127,"end_character":38},"updated":"2020-09-21 09:36:54.000000000","message":"seems unrelated","commit_id":"b88777c50c831f7ee7740df168ffd24baf66cb99"}],"ansible/roles/nova/defaults/main.yml":[{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"f81e08cd7a3653ad0e7e13c9188f1c24919dbc4d","unresolved":false,"context_lines":[{"line_number":100,"context_line":"nova_api_healthcheck_interval: \"{{ default_container_healthcheck_interval }}\""},{"line_number":101,"context_line":"nova_api_healthcheck_retries: \"{{ default_container_healthcheck_retries }}\""},{"line_number":102,"context_line":"nova_api_healthcheck_start_period: \"{{ default_container_healthcheck_start_period }}\""},{"line_number":103,"context_line":"nova_api_healthcheck_test: [\"CMD-SHELL\", \"healthcheck_curl {{ internal_protocol }}://{{ api_interface_address }}:{{ nova_api_port}} \"]"},{"line_number":104,"context_line":"nova_api_healthcheck_timeout: \"{{ default_container_healthcheck_timeout }}\""},{"line_number":105,"context_line":"nova_api_healthcheck:"},{"line_number":106,"context_line":"  interval: \"{{ nova_api_healthcheck_interval }}\""}],"source_content_type":"text/x-yaml","patch_set":85,"id":"9f560f44_09bc35da","line":103,"range":{"start_line":103,"start_character":116,"end_line":103,"end_character":129},"updated":"2020-09-24 09:48:11.000000000","message":"listen","commit_id":"6b139bfbdea3a51e68ab5e44120ecb1e0da77c14"}],"ansible/roles/ovs-dpdk/defaults/main.yml":[{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"8b896a759a269b429a987fcb973fef533ed34baf","unresolved":false,"context_lines":[{"line_number":78,"context_line":"ovsdpdk_db_dimensions: \"{{ default_container_dimensions }}\""},{"line_number":79,"context_line":"ovsdpdk_vswitchd_dimensions: \"{{ default_container_dimensions }}\""},{"line_number":80,"context_line":""},{"line_number":81,"context_line":"ovsdpdk_db_healthcheck: \"{{ default_container_healthcheck }}\""},{"line_number":82,"context_line":"ovsdpdk_vswitchd_healthcheck: \"{{ default_container_healthcheck }}\""},{"line_number":83,"context_line":""},{"line_number":84,"context_line":"ovsdpdk_db_default_volumes:"},{"line_number":85,"context_line":"  - \"{{ node_config_directory }}/ovsdpdk-db/:{{ container_config_directory }}/:ro\""}],"source_content_type":"text/x-yaml","patch_set":76,"id":"9f560f44_cc03b875","line":82,"range":{"start_line":81,"start_character":0,"end_line":82,"end_character":67},"updated":"2020-09-21 09:36:54.000000000","message":"?","commit_id":"b88777c50c831f7ee7740df168ffd24baf66cb99"}],"ansible/roles/placement/defaults/main.yml":[{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"8b896a759a269b429a987fcb973fef533ed34baf","unresolved":false,"context_lines":[{"line_number":48,"context_line":"placement_api_healthcheck_interval: \"{{ default_container_healthcheck_interval }}\""},{"line_number":49,"context_line":"placement_api_healthcheck_retries: \"{{ default_container_healthcheck_retries }}\""},{"line_number":50,"context_line":"placement_api_healthcheck_start_period: \"{{ default_container_healthcheck_start_period }}\""},{"line_number":51,"context_line":"placement_api_healthcheck_test: [\"CMD-SHELL\", \"curl {{ internal_protocol }}://{{ api_interface_address }}:{{ placement_api_port }}\"]"},{"line_number":52,"context_line":"placement_api_healthcheck_timeout: \"{{ default_container_healthcheck_timeout }}\""},{"line_number":53,"context_line":"placement_api_healthcheck:"},{"line_number":54,"context_line":"  interval: \"{{ placement_api_healthcheck_interval }}\""}],"source_content_type":"text/x-yaml","patch_set":76,"id":"9f560f44_0cfe506a","line":51,"range":{"start_line":51,"start_character":47,"end_line":51,"end_character":51},"updated":"2020-09-21 09:36:54.000000000","message":"healthcheck_curl?","commit_id":"b88777c50c831f7ee7740df168ffd24baf66cb99"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"f81e08cd7a3653ad0e7e13c9188f1c24919dbc4d","unresolved":false,"context_lines":[{"line_number":49,"context_line":"placement_api_healthcheck_interval: \"{{ default_container_healthcheck_interval }}\""},{"line_number":50,"context_line":"placement_api_healthcheck_retries: \"{{ default_container_healthcheck_retries }}\""},{"line_number":51,"context_line":"placement_api_healthcheck_start_period: \"{{ default_container_healthcheck_start_period }}\""},{"line_number":52,"context_line":"placement_api_healthcheck_test: [\"CMD-SHELL\", \"curl http://{{ api_interface_address }}:{{ placement_api_listen_port }}\"]"},{"line_number":53,"context_line":"placement_api_healthcheck_timeout: \"{{ default_container_healthcheck_timeout }}\""},{"line_number":54,"context_line":"placement_api_healthcheck:"},{"line_number":55,"context_line":"  interval: \"{{ placement_api_healthcheck_interval }}\""}],"source_content_type":"text/x-yaml","patch_set":85,"id":"9f560f44_89cfa57d","line":52,"range":{"start_line":52,"start_character":47,"end_line":52,"end_character":51},"updated":"2020-09-24 09:48:11.000000000","message":"healthcheck_curl","commit_id":"6b139bfbdea3a51e68ab5e44120ecb1e0da77c14"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"f81e08cd7a3653ad0e7e13c9188f1c24919dbc4d","unresolved":false,"context_lines":[{"line_number":49,"context_line":"placement_api_healthcheck_interval: \"{{ default_container_healthcheck_interval }}\""},{"line_number":50,"context_line":"placement_api_healthcheck_retries: \"{{ default_container_healthcheck_retries }}\""},{"line_number":51,"context_line":"placement_api_healthcheck_start_period: \"{{ default_container_healthcheck_start_period }}\""},{"line_number":52,"context_line":"placement_api_healthcheck_test: [\"CMD-SHELL\", \"curl http://{{ api_interface_address }}:{{ placement_api_listen_port }}\"]"},{"line_number":53,"context_line":"placement_api_healthcheck_timeout: \"{{ default_container_healthcheck_timeout }}\""},{"line_number":54,"context_line":"placement_api_healthcheck:"},{"line_number":55,"context_line":"  interval: \"{{ placement_api_healthcheck_interval }}\""}],"source_content_type":"text/x-yaml","patch_set":85,"id":"9f560f44_e9be21d2","line":52,"range":{"start_line":52,"start_character":52,"end_line":52,"end_character":56},"updated":"2020-09-24 09:48:11.000000000","message":"internal_protocol","commit_id":"6b139bfbdea3a51e68ab5e44120ecb1e0da77c14"}],"ansible/roles/rabbitmq/defaults/main.yml":[{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"8b896a759a269b429a987fcb973fef533ed34baf","unresolved":false,"context_lines":[{"line_number":59,"context_line":"rabbitmq_healthcheck_interval: \"{{ default_container_healthcheck_interval }}\""},{"line_number":60,"context_line":"rabbitmq_healthcheck_retries: \"{{ default_container_healthcheck_retries }}\""},{"line_number":61,"context_line":"rabbitmq_healthcheck_start_period: \"{{ default_container_healthcheck_start_period }}\""},{"line_number":62,"context_line":"rabbitmq_healthcheck_test: [\"CMD-SHELL\", \"rabbitmqctl cluster_status\"]"},{"line_number":63,"context_line":"rabbitmq_healthcheck_timeout: \"{{ default_container_healthcheck_timeout }}\""},{"line_number":64,"context_line":"rabbitmq_healthcheck:"},{"line_number":65,"context_line":"  interval: \"{{ rabbitmq_healthcheck_interval }}\""}],"source_content_type":"text/x-yaml","patch_set":76,"id":"9f560f44_0c33f063","line":62,"range":{"start_line":62,"start_character":42,"end_line":62,"end_character":68},"updated":"2020-09-21 09:36:54.000000000","message":"Does it fail if the cluster is broken? Could we do more harm than good if we have machines with non-overlapping exponential backoffs?","commit_id":"b88777c50c831f7ee7740df168ffd24baf66cb99"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"f81e08cd7a3653ad0e7e13c9188f1c24919dbc4d","unresolved":false,"context_lines":[{"line_number":59,"context_line":"rabbitmq_healthcheck_interval: \"{{ default_container_healthcheck_interval }}\""},{"line_number":60,"context_line":"rabbitmq_healthcheck_retries: \"{{ default_container_healthcheck_retries }}\""},{"line_number":61,"context_line":"rabbitmq_healthcheck_start_period: \"{{ default_container_healthcheck_start_period }}\""},{"line_number":62,"context_line":"rabbitmq_healthcheck_test: [\"CMD-SHELL\", \"rabbitmqctl cluster_status\"]"},{"line_number":63,"context_line":"rabbitmq_healthcheck_timeout: \"{{ default_container_healthcheck_timeout }}\""},{"line_number":64,"context_line":"rabbitmq_healthcheck:"},{"line_number":65,"context_line":"  interval: \"{{ rabbitmq_healthcheck_interval }}\""}],"source_content_type":"text/x-yaml","patch_set":76,"id":"9f560f44_49a74dbd","line":62,"range":{"start_line":62,"start_character":42,"end_line":62,"end_character":68},"in_reply_to":"9f560f44_0c33f063","updated":"2020-09-24 09:48:11.000000000","message":"Bump","commit_id":"b88777c50c831f7ee7740df168ffd24baf66cb99"}],"releasenotes/notes/implement-docker-healthchecks-feb3ce7fdbf8c2b6.yaml":[{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"be0bc121cdefd8c19a21c2ec18dca55c50c13a39","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Implement container healthchecks for core OpenStack services. Docker"},{"line_number":5,"context_line":"    healthchecks are periodically called scripts that check health of a"},{"line_number":6,"context_line":"    running service that expose health information in ``docker ps`` output"},{"line_number":7,"context_line":"    and trigger a ``health_status event``."}],"source_content_type":"text/x-yaml","patch_set":96,"id":"9f560f44_3cc75449","line":4,"range":{"start_line":4,"start_character":4,"end_line":4,"end_character":13},"updated":"2020-09-30 14:24:00.000000000","message":"nit: Implements","commit_id":"550e9ec8b8e8616cee0e81098d4b61b90a9833bb"},{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"be0bc121cdefd8c19a21c2ec18dca55c50c13a39","unresolved":false,"context_lines":[{"line_number":4,"context_line":"    Implement container healthchecks for core OpenStack services. Docker"},{"line_number":5,"context_line":"    healthchecks are periodically called scripts that check health of a"},{"line_number":6,"context_line":"    running service that expose health information in ``docker ps`` output"},{"line_number":7,"context_line":"    and trigger a ``health_status event``."}],"source_content_type":"text/x-yaml","patch_set":96,"id":"9f560f44_bcd88424","line":7,"updated":"2020-09-30 14:24:00.000000000","message":"add a quick info that this is now the default and how to disable","commit_id":"550e9ec8b8e8616cee0e81098d4b61b90a9833bb"}],"tests/check-failure.sh":[{"author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"tag":"autogenerated:zuul:check","change_message_id":"b764474c8f12b061b507b6d76f9843225d61f944","unresolved":false,"context_lines":[{"line_number":18,"context_line":"        --filter status\u003drestarting \\"},{"line_number":19,"context_line":"        --filter status\u003dpaused \\"},{"line_number":20,"context_line":"        --filter status\u003dexited \\"},{"line_number":21,"context_line":"\t--filter status\u003ddead)"},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"    unhealthy_containers\u003d$(sudo docker ps -a --format \"{{.Names}}\" \\"},{"line_number":24,"context_line":"\t--filter health\u003dunhealthy)"}],"source_content_type":"text/x-sh","patch_set":81,"id":"9f560f44_7667a525","line":21,"updated":"2020-09-23 13:51:07.000000000","message":"linters: E002 Tab indents","commit_id":"9a674d044ad640b86a9a7b9741306dac091d66dc"},{"author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"tag":"autogenerated:zuul:check","change_message_id":"b764474c8f12b061b507b6d76f9843225d61f944","unresolved":false,"context_lines":[{"line_number":18,"context_line":"        --filter status\u003drestarting \\"},{"line_number":19,"context_line":"        --filter status\u003dpaused \\"},{"line_number":20,"context_line":"        --filter status\u003dexited \\"},{"line_number":21,"context_line":"\t--filter status\u003ddead)"},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"    unhealthy_containers\u003d$(sudo docker ps -a --format \"{{.Names}}\" \\"},{"line_number":24,"context_line":"\t--filter health\u003dunhealthy)"}],"source_content_type":"text/x-sh","patch_set":81,"id":"9f560f44_566c2106","line":21,"updated":"2020-09-23 13:51:07.000000000","message":"linters: E003 Indent not multiple of 4","commit_id":"9a674d044ad640b86a9a7b9741306dac091d66dc"},{"author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"tag":"autogenerated:zuul:check","change_message_id":"b764474c8f12b061b507b6d76f9843225d61f944","unresolved":false,"context_lines":[{"line_number":21,"context_line":"\t--filter status\u003ddead)"},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"    unhealthy_containers\u003d$(sudo docker ps -a --format \"{{.Names}}\" \\"},{"line_number":24,"context_line":"\t--filter health\u003dunhealthy)"},{"line_number":25,"context_line":""},{"line_number":26,"context_line":"    if [[ -n \"$failed_containers\" ]]; then"},{"line_number":27,"context_line":"        exit 1;"}],"source_content_type":"text/x-sh","patch_set":81,"id":"9f560f44_b6749dd1","line":24,"updated":"2020-09-23 13:51:07.000000000","message":"linters: E002 Tab indents","commit_id":"9a674d044ad640b86a9a7b9741306dac091d66dc"},{"author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"tag":"autogenerated:zuul:check","change_message_id":"b764474c8f12b061b507b6d76f9843225d61f944","unresolved":false,"context_lines":[{"line_number":21,"context_line":"\t--filter status\u003ddead)"},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"    unhealthy_containers\u003d$(sudo docker ps -a --format \"{{.Names}}\" \\"},{"line_number":24,"context_line":"\t--filter health\u003dunhealthy)"},{"line_number":25,"context_line":""},{"line_number":26,"context_line":"    if [[ -n \"$failed_containers\" ]]; then"},{"line_number":27,"context_line":"        exit 1;"}],"source_content_type":"text/x-sh","patch_set":81,"id":"9f560f44_967199e1","line":24,"updated":"2020-09-23 13:51:07.000000000","message":"linters: E003 Indent not multiple of 4","commit_id":"9a674d044ad640b86a9a7b9741306dac091d66dc"},{"author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"tag":"autogenerated:zuul:check","change_message_id":"b764474c8f12b061b507b6d76f9843225d61f944","unresolved":false,"context_lines":[{"line_number":28,"context_line":"    fi"},{"line_number":29,"context_line":""},{"line_number":30,"context_line":"    if [[ -n \"$unhealthy_containers\" ]]; then"},{"line_number":31,"context_line":"\texit 1;"},{"line_number":32,"context_line":"    fi"},{"line_number":33,"context_line":"}"},{"line_number":34,"context_line":""}],"source_content_type":"text/x-sh","patch_set":81,"id":"9f560f44_f67a95b8","line":31,"updated":"2020-09-23 13:51:07.000000000","message":"linters: E002 Tab indents","commit_id":"9a674d044ad640b86a9a7b9741306dac091d66dc"},{"author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"tag":"autogenerated:zuul:check","change_message_id":"b764474c8f12b061b507b6d76f9843225d61f944","unresolved":false,"context_lines":[{"line_number":28,"context_line":"    fi"},{"line_number":29,"context_line":""},{"line_number":30,"context_line":"    if [[ -n \"$unhealthy_containers\" ]]; then"},{"line_number":31,"context_line":"\texit 1;"},{"line_number":32,"context_line":"    fi"},{"line_number":33,"context_line":"}"},{"line_number":34,"context_line":""}],"source_content_type":"text/x-sh","patch_set":81,"id":"9f560f44_d67791d0","line":31,"updated":"2020-09-23 13:51:07.000000000","message":"linters: E003 Indent not multiple of 4","commit_id":"9a674d044ad640b86a9a7b9741306dac091d66dc"}],"tests/test_kolla_docker.py":[{"author":{"_account_id":24072,"name":"Marcin Juszkiewicz","email":"mjuszkiewicz@redhat.com","username":"hrw"},"change_message_id":"c793c4183923e25e4109c3da4d321e4730d56218","unresolved":false,"context_lines":[{"line_number":295,"context_line":"            failed\u003dTrue, msg\u003drepr(\"Unsupported dimensions\"),"},{"line_number":296,"context_line":"            unsupported_dimensions\u003dset([\u0027random\u0027]))"},{"line_number":297,"context_line":""},{"line_number":298,"context_line":"    def test_create_container_without_healthcheck(self):"},{"line_number":299,"context_line":"        self.dw \u003d get_DockerWorker(self.fake_data[\u0027params\u0027])"},{"line_number":300,"context_line":"        self.dw.dc.create_host_config \u003d mock.MagicMock("},{"line_number":301,"context_line":"            return_value\u003dself.fake_data[\u0027params\u0027][\u0027host_config\u0027])"}],"source_content_type":"text/x-python","patch_set":44,"id":"3fa7e38b_6eb0398c","line":298,"range":{"start_line":298,"start_character":8,"end_line":298,"end_character":49},"updated":"2019-12-11 10:09:11.000000000","message":"without or with defaults?","commit_id":"56b09a806293737ac9e31e460bcbc7aa2f157c54"},{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"c423c0f8836ce8d94092f680f25f4e04d151b95e","unresolved":false,"context_lines":[{"line_number":295,"context_line":"            failed\u003dTrue, msg\u003drepr(\"Unsupported dimensions\"),"},{"line_number":296,"context_line":"            unsupported_dimensions\u003dset([\u0027random\u0027]))"},{"line_number":297,"context_line":""},{"line_number":298,"context_line":"    def test_create_container_without_healthcheck(self):"},{"line_number":299,"context_line":"        self.dw \u003d get_DockerWorker(self.fake_data[\u0027params\u0027])"},{"line_number":300,"context_line":"        self.dw.dc.create_host_config \u003d mock.MagicMock("},{"line_number":301,"context_line":"            return_value\u003dself.fake_data[\u0027params\u0027][\u0027host_config\u0027])"}],"source_content_type":"text/x-python","patch_set":44,"id":"3fa7e38b_74b0068c","line":298,"range":{"start_line":298,"start_character":8,"end_line":298,"end_character":49},"in_reply_to":"3fa7e38b_6eb0398c","updated":"2019-12-11 12:25:11.000000000","message":"renamed","commit_id":"56b09a806293737ac9e31e460bcbc7aa2f157c54"},{"author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"tag":"autogenerated:zuul:check","change_message_id":"3199a61ea4a1b66dfba99496aa37685f1e33dbad","unresolved":false,"context_lines":[{"line_number":94,"context_line":"            tty\u003ddict(required\u003dFalse, type\u003d\u0027bool\u0027, default\u003dFalse),"},{"line_number":95,"context_line":"            client_timeout\u003ddict(required\u003dFalse, type\u003d\u0027int\u0027, default\u003d120),"},{"line_number":96,"context_line":"            healthcheck\u003ddict(required\u003dFalse, type\u003d\u0027dict\u0027, default\u003ddict())"},{"line_number":97,"context_line":"            )"},{"line_number":98,"context_line":"        required_if \u003d ["},{"line_number":99,"context_line":"            [\u0027action\u0027, \u0027pull_image\u0027, [\u0027image\u0027]],"},{"line_number":100,"context_line":"            [\u0027action\u0027, \u0027start_container\u0027, [\u0027image\u0027, \u0027name\u0027]],"}],"source_content_type":"text/x-python","patch_set":51,"id":"bf51134e_1583f5cd","line":97,"updated":"2020-07-08 11:19:19.000000000","message":"linters: E123 closing bracket does not match indentation of opening bracket\u0027s line","commit_id":"ff46894717b61b0267ad8582ed63d62878cd3e46"},{"author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"tag":"autogenerated:zuul:check","change_message_id":"3199a61ea4a1b66dfba99496aa37685f1e33dbad","unresolved":false,"context_lines":[{"line_number":94,"context_line":"            tty\u003ddict(required\u003dFalse, type\u003d\u0027bool\u0027, default\u003dFalse),"},{"line_number":95,"context_line":"            client_timeout\u003ddict(required\u003dFalse, type\u003d\u0027int\u0027, default\u003d120),"},{"line_number":96,"context_line":"            healthcheck\u003ddict(required\u003dFalse, type\u003d\u0027dict\u0027, default\u003ddict())"},{"line_number":97,"context_line":"            )"},{"line_number":98,"context_line":"        required_if \u003d ["},{"line_number":99,"context_line":"            [\u0027action\u0027, \u0027pull_image\u0027, [\u0027image\u0027]],"},{"line_number":100,"context_line":"            [\u0027action\u0027, \u0027start_container\u0027, [\u0027image\u0027, \u0027name\u0027]],"}],"source_content_type":"text/x-python","patch_set":51,"id":"bf51134e_f585a1d0","line":97,"updated":"2020-07-08 11:19:19.000000000","message":"pep8: E123 closing bracket does not match indentation of opening bracket\u0027s line","commit_id":"ff46894717b61b0267ad8582ed63d62878cd3e46"}]}