)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"f8c0b189519c72f19996b8b51b75646dcbd5e18c","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Use fluentd image labels"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"In order to orchestrate smooth transition to fluentd 1.4.2"},{"line_number":10,"context_line":"from td-agent repository - use image labels (fluentd_version"},{"line_number":11,"context_line":"and fluentd_binary)."},{"line_number":12,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":16,"id":"7faddb67_57f93ac5","line":9,"range":{"start_line":9,"start_character":53,"end_line":9,"end_character":58},"updated":"2019-08-21 08:42:46.000000000","message":"0.14?","commit_id":"1fdd47da827a2d3d68097ad6d217a23a7c9740ba"}],"ansible/library/kolla_docker.py":[{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"4a8180c8ef21ca1d5f2988f699ebf38339b229d9","unresolved":false,"context_lines":[{"line_number":898,"context_line":"    argument_spec \u003d dict("},{"line_number":899,"context_line":"        common_options\u003ddict(required\u003dFalse, type\u003d\u0027dict\u0027, default\u003ddict()),"},{"line_number":900,"context_line":"        action\u003ddict(required\u003dTrue, type\u003d\u0027str\u0027,"},{"line_number":901,"context_line":"                    choices\u003d[\u0027compare_container\u0027, \u0027compare_image\u0027,"},{"line_number":902,"context_line":"                             \u0027create_volume\u0027, \u0027ensure_image\u0027,"},{"line_number":903,"context_line":"                             \u0027get_container_env\u0027, \u0027get_container_state\u0027,"},{"line_number":904,"context_line":"                             \u0027pull_image\u0027, \u0027recreate_or_restart_container\u0027"},{"line_number":905,"context_line":"                             \u0027remove_container\u0027, \u0027remove_image\u0027,"},{"line_number":906,"context_line":"                             \u0027remove_volume\u0027, \u0027restart_container\u0027,"},{"line_number":907,"context_line":"                             \u0027start_container\u0027, \u0027stop_container\u0027,"},{"line_number":908,"context_line":"                             \u0027stop_and_remove_container\u0027]),"},{"line_number":909,"context_line":"        api_version\u003ddict(required\u003dFalse, type\u003d\u0027str\u0027, default\u003d\u0027auto\u0027),"},{"line_number":910,"context_line":"        auth_email\u003ddict(required\u003dFalse, type\u003d\u0027str\u0027),"},{"line_number":911,"context_line":"        auth_password\u003ddict(required\u003dFalse, type\u003d\u0027str\u0027, no_log\u003dTrue),"}],"source_content_type":"text/x-python","patch_set":18,"id":"7faddb67_465c12f0","line":908,"range":{"start_line":901,"start_character":20,"end_line":908,"end_character":59},"updated":"2019-08-22 09:19:11.000000000","message":"nit: at this point it probably would be better off at the top level with one entry per line","commit_id":"d5db3cc178b358b22e7151f04e0f03bdfbc51969"}],"ansible/roles/common/tasks/config.yml":[{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"56dfa22f58e178a2f679c633047b58394422d665","unresolved":false,"context_lines":[{"line_number":18,"context_line":"    service: \"{{ common_services[service_name] }}\""},{"line_number":19,"context_line":"  docker_image_facts:"},{"line_number":20,"context_line":"    name: \"{{ service.image }}\""},{"line_number":21,"context_line":"  register: fluentd_labels"},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"- name: Ensuring fluentd config directories exist"},{"line_number":24,"context_line":"  file:"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"7faddb67_114ed9c0","line":21,"updated":"2019-08-14 14:25:00.000000000","message":"To provide a smooth transition to using labels, we should fall back to the old logic :D (not joking)","commit_id":"59900edc766f652d2aaf084d9d3095c9046b6b96"},{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"ea375dfd526dc05b6d2cc8057da27f778960ee7d","unresolved":false,"context_lines":[{"line_number":18,"context_line":"    service: \"{{ common_services[service_name] }}\""},{"line_number":19,"context_line":"  docker_image_facts:"},{"line_number":20,"context_line":"    name: \"{{ service.image }}\""},{"line_number":21,"context_line":"  register: fluentd_labels"},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"- name: Ensuring fluentd config directories exist"},{"line_number":24,"context_line":"  file:"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"7faddb67_fcc0b152","line":21,"in_reply_to":"7faddb67_114ed9c0","updated":"2019-08-14 16:49:04.000000000","message":"Yeah, will default the variables using hated set_fact module :)","commit_id":"59900edc766f652d2aaf084d9d3095c9046b6b96"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"c312ba222e6b661a0d3b78e66f30e83d75cd2a11","unresolved":false,"context_lines":[{"line_number":197,"context_line":""},{"line_number":198,"context_line":"- name: Copying over fluentd filter config files"},{"line_number":199,"context_line":"  vars:"},{"line_number":200,"context_line":"    fluentd_version: \"{{ fluentd_labels.images.0.ContainerConfig.Labels.fluentd_version | default(\u00270.12\u0027) }}\""},{"line_number":201,"context_line":"  template:"},{"line_number":202,"context_line":"    src: \"conf/filter/{{ item.src }}.conf.j2\""},{"line_number":203,"context_line":"    dest: \"{{ node_config_directory }}/fluentd/filter/{{ item.dest }}.conf\""}],"source_content_type":"text/x-yaml","patch_set":5,"id":"7faddb67_046e84ff","line":200,"updated":"2019-08-15 11:25:29.000000000","message":"Don\u0027t we need to apply this to everywhere there are fluentd vs td-agent differences?","commit_id":"3ea5360a9a56059b029cbe1d82dc96a8a147292b"},{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"f09cc809a8181a305015b33e15d4fb0c8c1f38be","unresolved":false,"context_lines":[{"line_number":197,"context_line":""},{"line_number":198,"context_line":"- name: Copying over fluentd filter config files"},{"line_number":199,"context_line":"  vars:"},{"line_number":200,"context_line":"    fluentd_version: \"{{ fluentd_labels.images.0.ContainerConfig.Labels.fluentd_version | default(\u00270.12\u0027) }}\""},{"line_number":201,"context_line":"  template:"},{"line_number":202,"context_line":"    src: \"conf/filter/{{ item.src }}.conf.j2\""},{"line_number":203,"context_line":"    dest: \"{{ node_config_directory }}/fluentd/filter/{{ item.dest }}.conf\""}],"source_content_type":"text/x-yaml","patch_set":5,"id":"7faddb67_3d27f114","line":200,"in_reply_to":"7faddb67_046e84ff","updated":"2019-08-19 07:33:01.000000000","message":"For now it\u0027s the only place that we need to use Fluentd-version - but yes, it makes sense to rework other places too (like config.json)","commit_id":"3ea5360a9a56059b029cbe1d82dc96a8a147292b"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"a8ee5e34df7db433102bddb8f60c0b40b58ddf32","unresolved":false,"context_lines":[{"line_number":197,"context_line":""},{"line_number":198,"context_line":"- name: Copying over fluentd filter config files"},{"line_number":199,"context_line":"  vars:"},{"line_number":200,"context_line":"    fluentd_version: \"{{ fluentd_labels.images.0.ContainerConfig.Labels.fluentd_version | default(\u00270.12\u0027) }}\""},{"line_number":201,"context_line":"  template:"},{"line_number":202,"context_line":"    src: \"conf/filter/{{ item.src }}.conf.j2\""},{"line_number":203,"context_line":"    dest: \"{{ node_config_directory }}/fluentd/filter/{{ item.dest }}.conf\""}],"source_content_type":"text/x-yaml","patch_set":5,"id":"7faddb67_7e223ca5","line":200,"in_reply_to":"7faddb67_3d27f114","updated":"2019-08-19 14:08:20.000000000","message":"Don\u0027t we also need to check fluentd_binary though?","commit_id":"3ea5360a9a56059b029cbe1d82dc96a8a147292b"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"7e929daac1c2f47c8453a3eade815a3f5653f5ad","unresolved":false,"context_lines":[{"line_number":12,"context_line":"    - \"cron\""},{"line_number":13,"context_line":"    - \"cron/logrotate\""},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"- name: Pull fluentd image for label check"},{"line_number":16,"context_line":"  vars:"},{"line_number":17,"context_line":"    service_name: \"fluentd\""},{"line_number":18,"context_line":"    service: \"{{ common_services[service_name] }}\""}],"source_content_type":"text/x-yaml","patch_set":13,"id":"7faddb67_80cbfc6f","line":15,"updated":"2019-08-20 13:30:00.000000000","message":"These three tasks need to be behind when: enable_fluentd | bool","commit_id":"ed5933c20765fb9a5d40f7cf26a7aa8d3a5b6f41"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"7e929daac1c2f47c8453a3eade815a3f5653f5ad","unresolved":false,"context_lines":[{"line_number":33,"context_line":""},{"line_number":34,"context_line":"- name: Set fluentd facts"},{"line_number":35,"context_line":"  set_fact:"},{"line_number":36,"context_line":"    fluentd_binary: \"{% if fluentd_facts.images.0.ContainerConfig.Labels.fluentd_binary is not defined %}{% if kolla_base_distro in \u0027ubuntu\u0027 and ansible_architecture \u003d\u003d \u0027x86_64\u0027 %}td-agent{% else %}fluentd{% endif %}{% else %}{{ fluentd_facts.images.0.ContainerConfig.Labels.fluentd_binary }}{% endif %}\""},{"line_number":37,"context_line":""},{"line_number":38,"context_line":"- name: Ensuring fluentd config directories exist"},{"line_number":39,"context_line":"  file:"}],"source_content_type":"text/x-yaml","patch_set":13,"id":"7faddb67_e0bc30dd","line":36,"updated":"2019-08-20 13:30:00.000000000","message":"Line could be a bit shorter if you define the default as a task variable.","commit_id":"ed5933c20765fb9a5d40f7cf26a7aa8d3a5b6f41"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"7e929daac1c2f47c8453a3eade815a3f5653f5ad","unresolved":false,"context_lines":[{"line_number":33,"context_line":""},{"line_number":34,"context_line":"- name: Set fluentd facts"},{"line_number":35,"context_line":"  set_fact:"},{"line_number":36,"context_line":"    fluentd_binary: \"{% if fluentd_facts.images.0.ContainerConfig.Labels.fluentd_binary is not defined %}{% if kolla_base_distro in \u0027ubuntu\u0027 and ansible_architecture \u003d\u003d \u0027x86_64\u0027 %}td-agent{% else %}fluentd{% endif %}{% else %}{{ fluentd_facts.images.0.ContainerConfig.Labels.fluentd_binary }}{% endif %}\""},{"line_number":37,"context_line":""},{"line_number":38,"context_line":"- name: Ensuring fluentd config directories exist"},{"line_number":39,"context_line":"  file:"}],"source_content_type":"text/x-yaml","patch_set":13,"id":"7faddb67_e0a190aa","line":36,"range":{"start_line":36,"start_character":35,"end_line":36,"end_character":40},"updated":"2019-08-20 13:30:00.000000000","message":"labels","commit_id":"ed5933c20765fb9a5d40f7cf26a7aa8d3a5b6f41"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"7e929daac1c2f47c8453a3eade815a3f5653f5ad","unresolved":false,"context_lines":[{"line_number":51,"context_line":""},{"line_number":52,"context_line":"- name: Copying over config.json files for services"},{"line_number":53,"context_line":"  vars:"},{"line_number":54,"context_line":"    fluentd_binary: \"{{ fluentd_labels.images.0.ContainerConfig.Labels.fluentd_binary | default(\u0027\u0027) }}\""},{"line_number":55,"context_line":"  template:"},{"line_number":56,"context_line":"    src: \"{{ item.key }}.json.j2\""},{"line_number":57,"context_line":"    dest: \"{{ node_config_directory }}/{{ item.key }}/config.json\""}],"source_content_type":"text/x-yaml","patch_set":13,"id":"7faddb67_a0a718bc","line":54,"range":{"start_line":54,"start_character":4,"end_line":54,"end_character":18},"updated":"2019-08-20 13:30:00.000000000","message":"not required","commit_id":"ed5933c20765fb9a5d40f7cf26a7aa8d3a5b6f41"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"f8c0b189519c72f19996b8b51b75646dcbd5e18c","unresolved":false,"context_lines":[{"line_number":26,"context_line":"    - \"fluentd/filter\""},{"line_number":27,"context_line":"  when: enable_fluentd | bool"},{"line_number":28,"context_line":""},{"line_number":29,"context_line":"- name: Pull fluentd image for label check"},{"line_number":30,"context_line":"  vars:"},{"line_number":31,"context_line":"    service_name: \"fluentd\""},{"line_number":32,"context_line":"    service: \"{{ common_services[service_name] }}\""},{"line_number":33,"context_line":"  become: true"},{"line_number":34,"context_line":"  kolla_docker:"},{"line_number":35,"context_line":"    action: \"pull_image\""},{"line_number":36,"context_line":"    common_options: \"{{ docker_common_options }}\""},{"line_number":37,"context_line":"    image: \"{{ service.image }}\""},{"line_number":38,"context_line":""},{"line_number":39,"context_line":"- name: Fetch fluentd image labels"},{"line_number":40,"context_line":"  vars:"},{"line_number":41,"context_line":"    service_name: \"fluentd\""},{"line_number":42,"context_line":"    service: \"{{ common_services[service_name] }}\""},{"line_number":43,"context_line":"  become: true"},{"line_number":44,"context_line":"  docker_image_facts:"},{"line_number":45,"context_line":"    name: \"{{ service.image }}\""},{"line_number":46,"context_line":"  register: fluentd_labels"},{"line_number":47,"context_line":""},{"line_number":48,"context_line":"- name: Set fluentd facts"},{"line_number":49,"context_line":"  set_fact:"},{"line_number":50,"context_line":"    fluentd_binary: \"{% if fluentd_labels.images.0.ContainerConfig.Labels.fluentd_binary is not defined %}{% if kolla_base_distro in \u0027ubuntu\u0027 and ansible_architecture \u003d\u003d \u0027x86_64\u0027 %}td-agent{% else %}fluentd{% endif %}{% else %}{{ fluentd_labels.images.0.ContainerConfig.Labels.fluentd_binary }}{% endif %}\""},{"line_number":51,"context_line":""},{"line_number":52,"context_line":"- name: Copying over config.json files for services"},{"line_number":53,"context_line":"  template:"}],"source_content_type":"text/x-yaml","patch_set":16,"id":"7faddb67_97249261","line":50,"range":{"start_line":29,"start_character":0,"end_line":50,"end_character":306},"updated":"2019-08-21 08:42:46.000000000","message":"when: enable_fluentd | bool","commit_id":"1fdd47da827a2d3d68097ad6d217a23a7c9740ba"},{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"17d4aea4c6e0760d2cc98499c1557911eb185730","unresolved":false,"context_lines":[{"line_number":26,"context_line":"    - \"fluentd/filter\""},{"line_number":27,"context_line":"  when: enable_fluentd | bool"},{"line_number":28,"context_line":""},{"line_number":29,"context_line":"- name: Pull fluentd image for label check"},{"line_number":30,"context_line":"  vars:"},{"line_number":31,"context_line":"    service_name: \"fluentd\""},{"line_number":32,"context_line":"    service: \"{{ common_services[service_name] }}\""}],"source_content_type":"text/x-yaml","patch_set":17,"id":"7faddb67_26423969","line":29,"range":{"start_line":29,"start_character":8,"end_line":29,"end_character":42},"updated":"2019-08-22 07:48:26.000000000","message":"unfortunately this would change the semantics of deploy which did *not* repull automatically\n\ncan we check the local image for existence and run this only if it is missing?","commit_id":"2c5f0201c531ce6bbf4c0bf30bb3844530a7aeed"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"fc020baaeac5582e9d5ecb5b7b0548357db021b7","unresolved":false,"context_lines":[{"line_number":26,"context_line":"    - \"fluentd/filter\""},{"line_number":27,"context_line":"  when: enable_fluentd | bool"},{"line_number":28,"context_line":""},{"line_number":29,"context_line":"- name: Pull fluentd image for label check"},{"line_number":30,"context_line":"  vars:"},{"line_number":31,"context_line":"    service_name: \"fluentd\""},{"line_number":32,"context_line":"    service: \"{{ common_services[service_name] }}\""}],"source_content_type":"text/x-yaml","patch_set":17,"id":"7faddb67_a1d613f1","line":29,"range":{"start_line":29,"start_character":8,"end_line":29,"end_character":42},"in_reply_to":"7faddb67_26423969","updated":"2019-08-22 08:15:58.000000000","message":"we could do with an ensure_image action for kolla_docker.","commit_id":"2c5f0201c531ce6bbf4c0bf30bb3844530a7aeed"},{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"96a48fb39503dccd1c9df8ffd0031d82a56d539d","unresolved":false,"context_lines":[{"line_number":26,"context_line":"    - \"fluentd/filter\""},{"line_number":27,"context_line":"  when: enable_fluentd | bool"},{"line_number":28,"context_line":""},{"line_number":29,"context_line":"- name: Pull fluentd image for label check"},{"line_number":30,"context_line":"  vars:"},{"line_number":31,"context_line":"    service_name: \"fluentd\""},{"line_number":32,"context_line":"    service: \"{{ common_services[service_name] }}\""}],"source_content_type":"text/x-yaml","patch_set":17,"id":"7faddb67_9cfee0ac","line":29,"range":{"start_line":29,"start_character":8,"end_line":29,"end_character":42},"in_reply_to":"7faddb67_a1d613f1","updated":"2019-08-22 08:44:42.000000000","message":"and then \"Ensure fluentd image is present for label check\"","commit_id":"2c5f0201c531ce6bbf4c0bf30bb3844530a7aeed"}]}