)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"a22e032cc7e162fa7cc0cc82d27db8f8e2cca41d","unresolved":false,"context_lines":[{"line_number":7,"context_line":"docs: ceph-ansible usage, add note around ceph keys"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"ceph-ansible by default generates what we call nova.keyring as"},{"line_number":10,"context_line":"openstack.keyring - adding a note to not confuse users."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Change-Id: I3992a037ab8e7947e35521b5c721a89bd954fdcd"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"7faddb67_c3fb09bc","line":10,"range":{"start_line":10,"start_character":0,"end_line":10,"end_character":9},"updated":"2019-08-22 16:30:45.000000000","message":"should this be cinder?","commit_id":"dd3d3366e7d84d28799557197da4e3c0442941f2"}],"doc/source/reference/storage/external-ceph-guide.rst":[{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"239e6b1ac374a756babccd9f3158125c628fbb24","unresolved":false,"context_lines":[{"line_number":207,"context_line":"Put ceph.conf, nova client keyring file and cinder client keyring file into"},{"line_number":208,"context_line":"``/etc/kolla/config/nova``:"},{"line_number":209,"context_line":""},{"line_number":210,"context_line":".. warning:: "},{"line_number":211,"context_line":""},{"line_number":212,"context_line":"   If you are using ceph-ansible - by default it generates a key called"},{"line_number":213,"context_line":"   ceph.client.openstack.keyring."}],"source_content_type":"text/x-rst","patch_set":1,"id":"7faddb67_dccbf84f","line":210,"range":{"start_line":210,"start_character":12,"end_line":210,"end_character":13},"updated":"2019-08-22 08:53:55.000000000","message":"space","commit_id":"d687e84012556bd8da890ea53e90126c96e1d95f"},{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"239e6b1ac374a756babccd9f3158125c628fbb24","unresolved":false,"context_lines":[{"line_number":210,"context_line":".. warning:: "},{"line_number":211,"context_line":""},{"line_number":212,"context_line":"   If you are using ceph-ansible - by default it generates a key called"},{"line_number":213,"context_line":"   ceph.client.openstack.keyring."},{"line_number":214,"context_line":"   Please adjust the default variable openstack_keys or copy openstack.keyring"},{"line_number":215,"context_line":"   as /etc/kolla/config/nova/ceph.client.nova.keyring"},{"line_number":216,"context_line":""}],"source_content_type":"text/x-rst","patch_set":1,"id":"7faddb67_7ce0c4cc","line":213,"range":{"start_line":213,"start_character":15,"end_line":213,"end_character":24},"updated":"2019-08-22 08:53:55.000000000","message":"Last time we discussed it we agreed that cinder was to be used with nova. Now it\u0027s openstack? ;o","commit_id":"d687e84012556bd8da890ea53e90126c96e1d95f"},{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"85086b5a9fa0cd53da52ee06bc278cde2ebafe20","unresolved":false,"context_lines":[{"line_number":210,"context_line":".. warning:: "},{"line_number":211,"context_line":""},{"line_number":212,"context_line":"   If you are using ceph-ansible - by default it generates a key called"},{"line_number":213,"context_line":"   ceph.client.openstack.keyring."},{"line_number":214,"context_line":"   Please adjust the default variable openstack_keys or copy openstack.keyring"},{"line_number":215,"context_line":"   as /etc/kolla/config/nova/ceph.client.nova.keyring"},{"line_number":216,"context_line":""}],"source_content_type":"text/x-rst","patch_set":1,"id":"7faddb67_c99ed554","line":213,"range":{"start_line":213,"start_character":15,"end_line":213,"end_character":24},"in_reply_to":"7faddb67_7ce0c4cc","updated":"2019-08-22 10:24:34.000000000","message":"Actually we can, or I can add a section with example configuration of openstack_keys variable, so we also generate a nova user/key with the same rights as the cinder one.","commit_id":"d687e84012556bd8da890ea53e90126c96e1d95f"},{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"5b198dce777d7a8dc904039f119ab7a0715987e8","unresolved":false,"context_lines":[{"line_number":210,"context_line":".. warning:: "},{"line_number":211,"context_line":""},{"line_number":212,"context_line":"   If you are using ceph-ansible - by default it generates a key called"},{"line_number":213,"context_line":"   ceph.client.openstack.keyring."},{"line_number":214,"context_line":"   Please adjust the default variable openstack_keys or copy openstack.keyring"},{"line_number":215,"context_line":"   as /etc/kolla/config/nova/ceph.client.nova.keyring"},{"line_number":216,"context_line":""}],"source_content_type":"text/x-rst","patch_set":1,"id":"7faddb67_293c49e0","line":213,"range":{"start_line":213,"start_character":15,"end_line":213,"end_character":24},"in_reply_to":"7faddb67_c99ed554","updated":"2019-08-22 10:47:45.000000000","message":"In my deployment I have separate keys for nova and cinder as their configs allow this. Anyways, \"openstack\" user does not make much sense near \"glance\" and \"cinder\". Is it some kind of superuser?","commit_id":"d687e84012556bd8da890ea53e90126c96e1d95f"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"4d6b73ee27c938581fc2042b853c94fb865c2854","unresolved":false,"context_lines":[{"line_number":23,"context_line":"-------------------------"},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"If you are using ceph-ansible to deploy your cluster, please set this"},{"line_number":26,"context_line":"in your group_vars/all.yml:"},{"line_number":27,"context_line":""},{"line_number":28,"context_line":".. code-block:: yaml"},{"line_number":29,"context_line":""}],"source_content_type":"text/x-rst","patch_set":2,"id":"7faddb67_7af1a16a","line":26,"updated":"2019-08-22 13:06:33.000000000","message":"clarify this is group_vars/all.yml for ceph-ansible?","commit_id":"dd3d3366e7d84d28799557197da4e3c0442941f2"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"4d6b73ee27c938581fc2042b853c94fb865c2854","unresolved":false,"context_lines":[{"line_number":36,"context_line":"   - { name: client.openstack, caps: { mon: \"profile rbd\", osd: \"profile rbd pool\u003d{{ openstack_glance_pool.name }}, profile rbd pool\u003d{{ openstack_nova_pool.name }}, profile rbd pool\u003d{{ openstack_cinder_pool.name }}, profile rbd pool\u003d{{ openstack_cinder_backup_pool.name }}, osd blacklist\"}, mode: \"0600\" }"},{"line_number":37,"context_line":""},{"line_number":38,"context_line":"It adds client.nova to the openstack_keys list which is required for Nova"},{"line_number":39,"context_line":"integration."},{"line_number":40,"context_line":""},{"line_number":41,"context_line":"Enabling External Ceph"},{"line_number":42,"context_line":"~~~~~~~~~~~~~~~~~~~~~~"}],"source_content_type":"text/x-rst","patch_set":2,"id":"7faddb67_3aeb2979","line":39,"updated":"2019-08-22 13:06:33.000000000","message":"Is a ceph-ansible fix required here?","commit_id":"dd3d3366e7d84d28799557197da4e3c0442941f2"},{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"5c849c12d9ed6b892666e48b450818f4b6fc44a3","unresolved":false,"context_lines":[{"line_number":36,"context_line":"   - { name: client.openstack, caps: { mon: \"profile rbd\", osd: \"profile rbd pool\u003d{{ openstack_glance_pool.name }}, profile rbd pool\u003d{{ openstack_nova_pool.name }}, profile rbd pool\u003d{{ openstack_cinder_pool.name }}, profile rbd pool\u003d{{ openstack_cinder_backup_pool.name }}, osd blacklist\"}, mode: \"0600\" }"},{"line_number":37,"context_line":""},{"line_number":38,"context_line":"It adds client.nova to the openstack_keys list which is required for Nova"},{"line_number":39,"context_line":"integration."},{"line_number":40,"context_line":""},{"line_number":41,"context_line":"Enabling External Ceph"},{"line_number":42,"context_line":"~~~~~~~~~~~~~~~~~~~~~~"}],"source_content_type":"text/x-rst","patch_set":2,"id":"7faddb67_9a2a5d8f","line":39,"in_reply_to":"7faddb67_3aeb2979","updated":"2019-08-22 13:11:33.000000000","message":"No, it\u0027s normal ceph-ansible functionality and works always :-)","commit_id":"dd3d3366e7d84d28799557197da4e3c0442941f2"},{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"ceb871096e7dbc843abb168bbb44ac659edf251e","unresolved":false,"context_lines":[{"line_number":36,"context_line":"   - { name: client.openstack, caps: { mon: \"profile rbd\", osd: \"profile rbd pool\u003d{{ openstack_glance_pool.name }}, profile rbd pool\u003d{{ openstack_nova_pool.name }}, profile rbd pool\u003d{{ openstack_cinder_pool.name }}, profile rbd pool\u003d{{ openstack_cinder_backup_pool.name }}, osd blacklist\"}, mode: \"0600\" }"},{"line_number":37,"context_line":""},{"line_number":38,"context_line":"It adds client.nova to the openstack_keys list which is required for Nova"},{"line_number":39,"context_line":"integration."},{"line_number":40,"context_line":""},{"line_number":41,"context_line":"Enabling External Ceph"},{"line_number":42,"context_line":"~~~~~~~~~~~~~~~~~~~~~~"}],"source_content_type":"text/x-rst","patch_set":2,"id":"7faddb67_e33725e4","line":39,"in_reply_to":"7faddb67_5b494764","updated":"2019-08-22 16:19:03.000000000","message":"By default openstack_keys variable in ceph-ansible doesn\u0027t include client.nova - I can try to highlight the client.nova line, that it\u0027s an addition - or just rewrite that section to ask the user to add the client.nova line to openstack_keys variable. Will that add more clarity?","commit_id":"dd3d3366e7d84d28799557197da4e3c0442941f2"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"3ba87bc12694abfa803378801596922932c73d59","unresolved":false,"context_lines":[{"line_number":36,"context_line":"   - { name: client.openstack, caps: { mon: \"profile rbd\", osd: \"profile rbd pool\u003d{{ openstack_glance_pool.name }}, profile rbd pool\u003d{{ openstack_nova_pool.name }}, profile rbd pool\u003d{{ openstack_cinder_pool.name }}, profile rbd pool\u003d{{ openstack_cinder_backup_pool.name }}, osd blacklist\"}, mode: \"0600\" }"},{"line_number":37,"context_line":""},{"line_number":38,"context_line":"It adds client.nova to the openstack_keys list which is required for Nova"},{"line_number":39,"context_line":"integration."},{"line_number":40,"context_line":""},{"line_number":41,"context_line":"Enabling External Ceph"},{"line_number":42,"context_line":"~~~~~~~~~~~~~~~~~~~~~~"}],"source_content_type":"text/x-rst","patch_set":2,"id":"7faddb67_5b494764","line":39,"in_reply_to":"7faddb67_9a2a5d8f","updated":"2019-08-22 14:31:46.000000000","message":"What are we doing differently then?","commit_id":"dd3d3366e7d84d28799557197da4e3c0442941f2"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"a22e032cc7e162fa7cc0cc82d27db8f8e2cca41d","unresolved":false,"context_lines":[{"line_number":36,"context_line":"   - { name: client.openstack, caps: { mon: \"profile rbd\", osd: \"profile rbd pool\u003d{{ openstack_glance_pool.name }}, profile rbd pool\u003d{{ openstack_nova_pool.name }}, profile rbd pool\u003d{{ openstack_cinder_pool.name }}, profile rbd pool\u003d{{ openstack_cinder_backup_pool.name }}, osd blacklist\"}, mode: \"0600\" }"},{"line_number":37,"context_line":""},{"line_number":38,"context_line":"It adds client.nova to the openstack_keys list which is required for Nova"},{"line_number":39,"context_line":"integration."},{"line_number":40,"context_line":""},{"line_number":41,"context_line":"Enabling External Ceph"},{"line_number":42,"context_line":"~~~~~~~~~~~~~~~~~~~~~~"}],"source_content_type":"text/x-rst","patch_set":2,"id":"7faddb67_c3b8e912","line":39,"in_reply_to":"7faddb67_e33725e4","updated":"2019-08-22 16:30:45.000000000","message":"What I mean is, why don\u0027t they have a nova key?\n\nI just reread your commit message, and it looks like they call it client.openstack. That is slightly different from client.nova above though, so it\u0027s not just named differently. Actually client.cinder looks the same though as client.nova though.\n\nThe caps are quite fiddly so I\u0027d rather use their defaults than provide some overrides here that could go stale.\n\nThere are two ways to do that I can see:\n\n1. modify ceph-ansible to use the create keys by default.\n2. modify our code to make the keyring name configurable, and accept client.openstack.","commit_id":"dd3d3366e7d84d28799557197da4e3c0442941f2"}]}