)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":15197,"name":"Pierre Riteau","email":"pierre@stackhpc.com","username":"priteau","status":"StackHPC"},"change_message_id":"3ca369749e3d3d9677c20ef4ce7920edc029952e","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Ondrej Duchon \u003condrej.duchon@ultimum.io\u003e"},{"line_number":5,"context_line":"CommitDate: 2019-08-26 15:06:07 +0200"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Corrected notificaions for auditing."},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Audit notifying for Cinder, Glance, Heat, Nova and Neutron API. Enabled"},{"line_number":10,"context_line":"if enable_audit_middleware_notifications is set to \"yes\". E.g. for rabbitmq"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"7faddb67_9d9217fc","line":7,"range":{"start_line":7,"start_character":10,"end_line":7,"end_character":22},"updated":"2019-08-27 07:02:01.000000000","message":"Typo: notifications","commit_id":"8d74f335f3af22aa0833912ebf0fa2b3ac491e1f"},{"author":{"_account_id":15197,"name":"Pierre Riteau","email":"pierre@stackhpc.com","username":"priteau","status":"StackHPC"},"change_message_id":"3ca369749e3d3d9677c20ef4ce7920edc029952e","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Corrected notificaions for auditing."},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Audit notifying for Cinder, Glance, Heat, Nova and Neutron API. Enabled"},{"line_number":10,"context_line":"if enable_audit_middleware_notifications is set to \"yes\". E.g. for rabbitmq"},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Change-Id: I51740d62db2c5346b25f4d6e8ccef71b77213566"},{"line_number":13,"context_line":"Closes-Bug: #1837416"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"7faddb67_5d9c9f0d","line":10,"range":{"start_line":10,"start_character":58,"end_line":10,"end_character":75},"updated":"2019-08-27 07:02:01.000000000","message":"Nit: wrap to 72 characters","commit_id":"8d74f335f3af22aa0833912ebf0fa2b3ac491e1f"},{"author":{"_account_id":15197,"name":"Pierre Riteau","email":"pierre@stackhpc.com","username":"priteau","status":"StackHPC"},"change_message_id":"652ec9a119544db6be3d5948609ddc77439ef937","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Ondrej Duchon \u003condrej.duchon@ultimum.io\u003e"},{"line_number":5,"context_line":"CommitDate: 2019-09-02 14:42:04 +0200"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Corrected notificaions for auditing."},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Audit notifying for Cinder, Glance, Heat, Nova and Neutron API. Enabled"},{"line_number":10,"context_line":"if enable_audit_middleware_notifications is set to \"yes\"."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":11,"id":"7faddb67_949930d1","line":7,"range":{"start_line":7,"start_character":10,"end_line":7,"end_character":22},"updated":"2019-09-02 14:51:46.000000000","message":"typo: notifications","commit_id":"a2491c68cd0dac8aa7b351c6ab6a42dc4720fb25"}],"ansible/roles/cinder/tasks/config.yml":[{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"7b46af018dd06fbd64812bc603848cd50fb5dfab","unresolved":false,"context_lines":[{"line_number":95,"context_line":"  notify:"},{"line_number":96,"context_line":"    - \"Restart {{ item.key }} container\""},{"line_number":97,"context_line":""},{"line_number":98,"context_line":"- name: api-paste.ini file merge"},{"line_number":99,"context_line":"  merge_configs:"},{"line_number":100,"context_line":"    sources:"},{"line_number":101,"context_line":"      - \"{{ node_custom_config }}/cinder/api-paste.ini\""}],"source_content_type":"text/x-yaml","patch_set":6,"id":"7faddb67_5afb13bd","line":98,"range":{"start_line":98,"start_character":6,"end_line":98,"end_character":32},"updated":"2019-08-29 12:06:43.000000000","message":"Why is this being merged? We control the file {{ node_config_directory }}/cinder-api/api-paste.ini\n\nThe previous approach should have worked fine.","commit_id":"b9fb6f824ec2c94c1067703cae663c25e9e049c6"}],"ansible/roles/cinder/templates/cinder-api-paste.ini.j2":[{"author":{"_account_id":19316,"name":"Eduardo Gonzalez","email":"dabarren@gmail.com","username":"egonzalez90"},"change_message_id":"a68f7af67904bb581636e4c2b7cf67f1311f5546","unresolved":false,"context_lines":[{"line_number":1,"context_line":"#############"},{"line_number":2,"context_line":"# OpenStack #"},{"line_number":3,"context_line":"#############"},{"line_number":4,"context_line":""}],"source_content_type":"text/x-jinja2","patch_set":12,"id":"3fa7e38b_510c1540","line":1,"updated":"2019-09-26 08:52:39.000000000","message":"we\u0027ve always tried to avoid api-paste.ini in any service due the difficult to maintain and not keep it outdate, I\u0027d prefer keep the default file and if a user wants to change it allows to push its own config file or add only the required lines to the existing file.","commit_id":"0638af9d46639c55fc898a456b92da72884a5597"}],"ansible/roles/cinder/templates/cinder.conf.j2":[{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"c95709fa2ca8db4716c25125138976501e94e2a7","unresolved":false,"context_lines":[{"line_number":68,"context_line":"driver \u003d noop"},{"line_number":69,"context_line":"{% endif %}"},{"line_number":70,"context_line":""},{"line_number":71,"context_line":"{% if enable_audit_middleware_notifications $}"},{"line_number":72,"context_line":"[audit_middleware_notifications]"},{"line_number":73,"context_line":"transport_url \u003d {{ notify_transport_url }}"},{"line_number":74,"context_line":"driver \u003d messagingv2"},{"line_number":75,"context_line":"topics \u003d notifications"},{"line_number":76,"context_line":"{% endif %}"},{"line_number":77,"context_line":""},{"line_number":78,"context_line":"[oslo_middleware]"},{"line_number":79,"context_line":"enable_proxy_headers_parsing \u003d True"}],"source_content_type":"text/x-jinja2","patch_set":1,"id":"7faddb67_15b83b0f","line":76,"range":{"start_line":71,"start_character":0,"end_line":76,"end_character":11},"updated":"2019-08-27 10:04:00.000000000","message":"As I stated in the previous review (https://review.opendev.org/#/c/674579/), the audit middleware will default to using the oslo_messaging_notification configuration section.\n\nBut you didn\u0027t respond to any of my comments in that review.","commit_id":"8d74f335f3af22aa0833912ebf0fa2b3ac491e1f"}]}