)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"b1d9984cf993a1b17b6a79d349832dfa956d564d","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Added support for custom logging.conf"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Adds template of logging.conf to be able to merge with custom"},{"line_number":10,"context_line":"logging.conf file located in custom config folder. So we will be able"},{"line_number":11,"context_line":"to modify logging.conf and use e.g. FluentFormatter a FluentHandler."},{"line_number":12,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"3fa7e38b_4adbfe7a","line":9,"range":{"start_line":9,"start_character":0,"end_line":9,"end_character":29},"updated":"2019-09-26 10:16:24.000000000","message":"Needs updating to match current behaviour.","commit_id":"a403f7321b4bed814ce585f3a4e3bec7592a1c09"}],"ansible/group_vars/all.yml":[{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"b1d9984cf993a1b17b6a79d349832dfa956d564d","unresolved":false,"context_lines":[{"line_number":241,"context_line":"etcd_peer_port: \"2380\""},{"line_number":242,"context_line":""},{"line_number":243,"context_line":"fluentd_syslog_port: \"5140\""},{"line_number":244,"context_line":"fluent_monitoring_port: \"24224\""},{"line_number":245,"context_line":"fluent_node_address: \"127.0.0.1\""},{"line_number":246,"context_line":""},{"line_number":247,"context_line":"freezer_api_port: \"9090\""},{"line_number":248,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":2,"id":"3fa7e38b_aa8b921c","line":245,"range":{"start_line":244,"start_character":0,"end_line":245,"end_character":32},"updated":"2019-09-26 10:16:24.000000000","message":"Not necessary","commit_id":"a403f7321b4bed814ce585f3a4e3bec7592a1c09"}],"ansible/roles/aodh/tasks/config.yml":[{"author":{"_account_id":26285,"name":"wu.chunyang","email":"wchy1001@gmail.com","username":"wu.chunyang"},"change_message_id":"393b0c974d45336b167ca14c0544a6ef3759678d","unresolved":false,"context_lines":[{"line_number":47,"context_line":"- name: Set aodh logging conf file"},{"line_number":48,"context_line":"  set_fact:"},{"line_number":49,"context_line":"    aodh_logging_file: \"{{ aodh_logging.results.0.stat.path | basename }}\""},{"line_number":50,"context_line":"    aodh_logging_file_path: \"{{ aodh_logging.results.0.stat.path }}\""},{"line_number":51,"context_line":"  when:"},{"line_number":52,"context_line":"    - aodh_logging.results"},{"line_number":53,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":24,"id":"9f560f44_7fa50803","line":50,"range":{"start_line":50,"start_character":4,"end_line":50,"end_character":26},"updated":"2020-09-18 08:52:57.000000000","message":"i don\u0027t see this variable used anywhere.","commit_id":"26247378fb60b2fe469e7fc4c8b7381853b62aab"},{"author":{"_account_id":26285,"name":"wu.chunyang","email":"wchy1001@gmail.com","username":"wu.chunyang"},"change_message_id":"fd71fbaf0942477cb7b0908377e571b40357b51a","unresolved":false,"context_lines":[{"line_number":47,"context_line":"- name: Set aodh logging conf file"},{"line_number":48,"context_line":"  set_fact:"},{"line_number":49,"context_line":"    aodh_logging_file: \"{{ aodh_logging.results.0.stat.path | basename }}\""},{"line_number":50,"context_line":"    aodh_logging_file_path: \"{{ aodh_logging.results.0.stat.path }}\""},{"line_number":51,"context_line":"  when:"},{"line_number":52,"context_line":"    - aodh_logging.results"},{"line_number":53,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":24,"id":"9f560f44_01b3c0ea","line":50,"range":{"start_line":50,"start_character":4,"end_line":50,"end_character":26},"in_reply_to":"9f560f44_5d62c2da","updated":"2020-09-20 11:23:05.000000000","message":"thanks","commit_id":"26247378fb60b2fe469e7fc4c8b7381853b62aab"},{"author":{"_account_id":27339,"name":"Michal Arbet","email":"michal.arbet@ultimum.io","username":"michalarbet"},"change_message_id":"f3f87aac7709fe9be3c3ab2af187b1e0910f5c01","unresolved":false,"context_lines":[{"line_number":47,"context_line":"- name: Set aodh logging conf file"},{"line_number":48,"context_line":"  set_fact:"},{"line_number":49,"context_line":"    aodh_logging_file: \"{{ aodh_logging.results.0.stat.path | basename }}\""},{"line_number":50,"context_line":"    aodh_logging_file_path: \"{{ aodh_logging.results.0.stat.path }}\""},{"line_number":51,"context_line":"  when:"},{"line_number":52,"context_line":"    - aodh_logging.results"},{"line_number":53,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":24,"id":"9f560f44_5d62c2da","line":50,"range":{"start_line":50,"start_character":4,"end_line":50,"end_character":26},"in_reply_to":"9f560f44_7fa50803","updated":"2020-09-18 19:36:36.000000000","message":"It is used on line 70, task \"Copying aodh custom logging.conf file\". It is written as tasks around policy copying.","commit_id":"26247378fb60b2fe469e7fc4c8b7381853b62aab"}],"ansible/roles/glance/defaults/main.yml":[{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"45432c9762eff06cbd10a702665da05cc8518899","unresolved":false,"context_lines":[{"line_number":189,"context_line":""},{"line_number":190,"context_line":"openstack_glance_auth: \"{{ openstack_auth }}\""},{"line_number":191,"context_line":""},{"line_number":192,"context_line":"glance_services_supports_custom_logging:"},{"line_number":193,"context_line":"  - glance-api"},{"line_number":194,"context_line":""},{"line_number":195,"context_line":"###################"}],"source_content_type":"text/x-yaml","patch_set":28,"id":"9f560f44_d50946dc","line":192,"range":{"start_line":192,"start_character":16,"end_line":192,"end_character":39},"updated":"2020-09-23 14:45:53.000000000","message":"with_logging_conf_support","commit_id":"158e1459da8fd6fffaa00c3bde35cd6c629f8a65"},{"author":{"_account_id":27339,"name":"Michal Arbet","email":"michal.arbet@ultimum.io","username":"michalarbet"},"change_message_id":"6dd5555086578762ace6180ca4f1593c280fd985","unresolved":false,"context_lines":[{"line_number":189,"context_line":""},{"line_number":190,"context_line":"openstack_glance_auth: \"{{ openstack_auth }}\""},{"line_number":191,"context_line":""},{"line_number":192,"context_line":"glance_services_supports_custom_logging:"},{"line_number":193,"context_line":"  - glance-api"},{"line_number":194,"context_line":""},{"line_number":195,"context_line":"###################"}],"source_content_type":"text/x-yaml","patch_set":28,"id":"9f560f44_745acf1d","line":192,"range":{"start_line":192,"start_character":16,"end_line":192,"end_character":39},"in_reply_to":"9f560f44_d50946dc","updated":"2020-09-25 08:51:44.000000000","message":"Done","commit_id":"158e1459da8fd6fffaa00c3bde35cd6c629f8a65"}],"ansible/roles/glance/tasks/config.yml":[{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"45432c9762eff06cbd10a702665da05cc8518899","unresolved":false,"context_lines":[{"line_number":129,"context_line":"- name: Copying over glance-swift.conf for glance_api"},{"line_number":130,"context_line":"  vars:"},{"line_number":131,"context_line":"    glance_api: \"{{ glance_services[\u0027glance-api\u0027] }}\""},{"line_number":132,"context_line":"    service_name: \"glance-api\""},{"line_number":133,"context_line":"  merge_configs:"},{"line_number":134,"context_line":"    sources:"},{"line_number":135,"context_line":"      - \"{{ role_path }}/templates/glance-swift.conf.j2\""}],"source_content_type":"text/x-yaml","patch_set":28,"id":"9f560f44_955eaee6","line":132,"updated":"2020-09-23 14:45:53.000000000","message":"^ all these extras should not be needed","commit_id":"158e1459da8fd6fffaa00c3bde35cd6c629f8a65"},{"author":{"_account_id":27339,"name":"Michal Arbet","email":"michal.arbet@ultimum.io","username":"michalarbet"},"change_message_id":"6dd5555086578762ace6180ca4f1593c280fd985","unresolved":false,"context_lines":[{"line_number":129,"context_line":"- name: Copying over glance-swift.conf for glance_api"},{"line_number":130,"context_line":"  vars:"},{"line_number":131,"context_line":"    glance_api: \"{{ glance_services[\u0027glance-api\u0027] }}\""},{"line_number":132,"context_line":"    service_name: \"glance-api\""},{"line_number":133,"context_line":"  merge_configs:"},{"line_number":134,"context_line":"    sources:"},{"line_number":135,"context_line":"      - \"{{ role_path }}/templates/glance-swift.conf.j2\""}],"source_content_type":"text/x-yaml","patch_set":28,"id":"9f560f44_b4862764","line":132,"in_reply_to":"9f560f44_955eaee6","updated":"2020-09-25 08:51:44.000000000","message":"Done","commit_id":"158e1459da8fd6fffaa00c3bde35cd6c629f8a65"}],"ansible/roles/glance/templates/glance-api.conf.j2":[{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"45432c9762eff06cbd10a702665da05cc8518899","unresolved":false,"context_lines":[{"line_number":3,"context_line":""},{"line_number":4,"context_line":"# NOTE(elemoine) log_dir alone does not work for Glance"},{"line_number":5,"context_line":"log_file \u003d /var/log/kolla/glance/glance-api.log"},{"line_number":6,"context_line":"{% if service_name in glance_services_supports_custom_logging and glance_logging_file is defined %}"},{"line_number":7,"context_line":"log_config_append \u003d  /etc/glance/{{ glance_logging_file }}"},{"line_number":8,"context_line":"{% endif %}"},{"line_number":9,"context_line":"use_forwarded_for \u003d true"}],"source_content_type":"text/x-jinja2","patch_set":28,"id":"9f560f44_75631ab2","line":6,"range":{"start_line":6,"start_character":22,"end_line":6,"end_character":61},"updated":"2020-09-23 14:45:53.000000000","message":"services not supporting custom logging do not normally use this kind of ini file anyway, so no need to check","commit_id":"158e1459da8fd6fffaa00c3bde35cd6c629f8a65"},{"author":{"_account_id":27339,"name":"Michal Arbet","email":"michal.arbet@ultimum.io","username":"michalarbet"},"change_message_id":"6dd5555086578762ace6180ca4f1593c280fd985","unresolved":false,"context_lines":[{"line_number":3,"context_line":""},{"line_number":4,"context_line":"# NOTE(elemoine) log_dir alone does not work for Glance"},{"line_number":5,"context_line":"log_file \u003d /var/log/kolla/glance/glance-api.log"},{"line_number":6,"context_line":"{% if service_name in glance_services_supports_custom_logging and glance_logging_file is defined %}"},{"line_number":7,"context_line":"log_config_append \u003d  /etc/glance/{{ glance_logging_file }}"},{"line_number":8,"context_line":"{% endif %}"},{"line_number":9,"context_line":"use_forwarded_for \u003d true"}],"source_content_type":"text/x-jinja2","patch_set":28,"id":"9f560f44_b49d87bc","line":6,"range":{"start_line":6,"start_character":22,"end_line":6,"end_character":61},"in_reply_to":"9f560f44_75631ab2","updated":"2020-09-25 08:51:44.000000000","message":"Done","commit_id":"158e1459da8fd6fffaa00c3bde35cd6c629f8a65"}],"ansible/roles/nova/tasks/config.yml":[{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"b1d9984cf993a1b17b6a79d349832dfa956d564d","unresolved":false,"context_lines":[{"line_number":39,"context_line":"    - not enable_ceph | bool and (nova_backend \u003d\u003d \"rbd\" or cinder_backend_ceph | bool)"},{"line_number":40,"context_line":"    - inventory_hostname in groups[\u0027compute\u0027]"},{"line_number":41,"context_line":""},{"line_number":42,"context_line":"- name: Check if custom logger_conf is present"},{"line_number":43,"context_line":"  local_action: stat path\u003d\"{{ item }}\""},{"line_number":44,"context_line":"  run_once: True"},{"line_number":45,"context_line":"  register: nova_logger_conf"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"3fa7e38b_4a7c5e1e","line":42,"range":{"start_line":42,"start_character":24,"end_line":42,"end_character":35},"updated":"2019-09-26 10:16:24.000000000","message":"logging.conf","commit_id":"a403f7321b4bed814ce585f3a4e3bec7592a1c09"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"b1d9984cf993a1b17b6a79d349832dfa956d564d","unresolved":false,"context_lines":[{"line_number":45,"context_line":"  register: nova_logger_conf"},{"line_number":46,"context_line":"  with_first_found:"},{"line_number":47,"context_line":"    - files:"},{"line_number":48,"context_line":"        - \"logger.j2\""},{"line_number":49,"context_line":"      paths:"},{"line_number":50,"context_line":"        - \"{{ node_custom_config }}/nova/\""},{"line_number":51,"context_line":"      skip: true"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"3fa7e38b_8a86d612","line":48,"range":{"start_line":48,"start_character":11,"end_line":48,"end_character":20},"updated":"2019-09-26 10:16:24.000000000","message":"logging.conf","commit_id":"a403f7321b4bed814ce585f3a4e3bec7592a1c09"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"b1d9984cf993a1b17b6a79d349832dfa956d564d","unresolved":false,"context_lines":[{"line_number":50,"context_line":"        - \"{{ node_custom_config }}/nova/\""},{"line_number":51,"context_line":"      skip: true"},{"line_number":52,"context_line":""},{"line_number":53,"context_line":"- name: Set nova logger_conf file"},{"line_number":54,"context_line":"  set_fact:"},{"line_number":55,"context_line":"    nova_logger_conf_file: \"{{ nova_logger_conf.results.0.stat.path | basename }}\""},{"line_number":56,"context_line":"    nova_logger_conf_file_path: \"{{ nova_logger_conf.results.0.stat.path }}\""}],"source_content_type":"text/x-yaml","patch_set":2,"id":"3fa7e38b_2a7fa215","line":53,"range":{"start_line":53,"start_character":17,"end_line":53,"end_character":28},"updated":"2019-09-26 10:16:24.000000000","message":"logging.conf","commit_id":"a403f7321b4bed814ce585f3a4e3bec7592a1c09"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"b1d9984cf993a1b17b6a79d349832dfa956d564d","unresolved":false,"context_lines":[{"line_number":52,"context_line":""},{"line_number":53,"context_line":"- name: Set nova logger_conf file"},{"line_number":54,"context_line":"  set_fact:"},{"line_number":55,"context_line":"    nova_logger_conf_file: \"{{ nova_logger_conf.results.0.stat.path | basename }}\""},{"line_number":56,"context_line":"    nova_logger_conf_file_path: \"{{ nova_logger_conf.results.0.stat.path }}\""},{"line_number":57,"context_line":"  when:"},{"line_number":58,"context_line":"    - nova_logger_conf.results"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"3fa7e38b_6aafda7c","line":55,"range":{"start_line":55,"start_character":9,"end_line":55,"end_character":15},"updated":"2019-09-26 10:16:24.000000000","message":"logging, and elsewhere","commit_id":"a403f7321b4bed814ce585f3a4e3bec7592a1c09"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"b1d9984cf993a1b17b6a79d349832dfa956d564d","unresolved":false,"context_lines":[{"line_number":57,"context_line":"  when:"},{"line_number":58,"context_line":"    - nova_logger_conf.results"},{"line_number":59,"context_line":""},{"line_number":60,"context_line":"- name: Copying over existing loggger_conf file"},{"line_number":61,"context_line":"  become: true"},{"line_number":62,"context_line":"  template:"},{"line_number":63,"context_line":"    src: \"{{ nova_logger_conf_file_path }}\""}],"source_content_type":"text/x-yaml","patch_set":2,"id":"3fa7e38b_eaa98a7b","line":60,"range":{"start_line":60,"start_character":30,"end_line":60,"end_character":42},"updated":"2019-09-26 10:16:24.000000000","message":"logging.conf","commit_id":"a403f7321b4bed814ce585f3a4e3bec7592a1c09"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"b1d9984cf993a1b17b6a79d349832dfa956d564d","unresolved":false,"context_lines":[{"line_number":63,"context_line":"    src: \"{{ nova_logger_conf_file_path }}\""},{"line_number":64,"context_line":"    dest: \"{{ node_config_directory }}/nova-api/logging.conf\""},{"line_number":65,"context_line":"    mode: \"0660\""},{"line_number":66,"context_line":"  register: nova_logger_conf_overwriting"},{"line_number":67,"context_line":"  when:"},{"line_number":68,"context_line":"    - nova_logger_conf_file is defined"},{"line_number":69,"context_line":"    - inventory_hostname in groups[\u0027nova-api\u0027]"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"3fa7e38b_2aa482a5","line":66,"range":{"start_line":66,"start_character":1,"end_line":66,"end_character":40},"updated":"2019-09-26 10:16:24.000000000","message":"not necessary","commit_id":"a403f7321b4bed814ce585f3a4e3bec7592a1c09"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"b1d9984cf993a1b17b6a79d349832dfa956d564d","unresolved":false,"context_lines":[{"line_number":67,"context_line":"  when:"},{"line_number":68,"context_line":"    - nova_logger_conf_file is defined"},{"line_number":69,"context_line":"    - inventory_hostname in groups[\u0027nova-api\u0027]"},{"line_number":70,"context_line":"  with_dict: \"{{ nova_services[\u0027nova-api\u0027] }}\""},{"line_number":71,"context_line":"  notify:"},{"line_number":72,"context_line":"    - \"Restart nova-api container\""},{"line_number":73,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":2,"id":"3fa7e38b_8a9b3664","line":70,"updated":"2019-09-26 10:16:24.000000000","message":"Remove with_dict","commit_id":"a403f7321b4bed814ce585f3a4e3bec7592a1c09"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"f50446b2bd6e596263729beae3ede61fa49e5c02","unresolved":false,"context_lines":[{"line_number":67,"context_line":"    - nova_logging_conf_file is defined"},{"line_number":68,"context_line":"    - inventory_hostname in groups[\u0027nova-api\u0027]"},{"line_number":69,"context_line":"  notify:"},{"line_number":70,"context_line":"    - \"Restart nova-api container\""},{"line_number":71,"context_line":""},{"line_number":72,"context_line":"- name: Check if policies shall be overwritten"},{"line_number":73,"context_line":"  local_action: stat path\u003d\"{{ item }}\""}],"source_content_type":"text/x-yaml","patch_set":3,"id":"3fa7e38b_a2b17249","line":70,"range":{"start_line":70,"start_character":15,"end_line":70,"end_character":23},"updated":"2019-09-26 15:07:34.000000000","message":"Is there a reason why we would not do it for all nova services?","commit_id":"559e83e6ddbba6021a0f7d15dd2ad953ca1b4b30"}],"ansible/roles/nova/templates/nova-logging.conf.j2":[{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"94e1119b82826d9d606c2f1a7a3b57d70df35423","unresolved":false,"context_lines":[{"line_number":67,"context_line":"formatter \u003d default"},{"line_number":68,"context_line":"args \u003d ()"},{"line_number":69,"context_line":""},{"line_number":70,"context_line":"[handler_fluent]"},{"line_number":71,"context_line":"class \u003d fluent.handler.FluentHandler"},{"line_number":72,"context_line":"args \u003d (\u0027{{ service.container_name }}\u0027, \u0027{{ fluent_node_address }}\u0027, {{ fluent_monitoring_port }})"},{"line_number":73,"context_line":"formatter \u003d fluent"},{"line_number":74,"context_line":""},{"line_number":75,"context_line":"[handler_file]"},{"line_number":76,"context_line":"class \u003d handlers.WatchedFileHandler"},{"line_number":77,"context_line":"level \u003d WARNING"},{"line_number":78,"context_line":"formatter \u003d normal"},{"line_number":79,"context_line":"args \u003d (\u0027/var/log/kolla/{{ nova_services[service_name] }}/{{ service.container_name }}.log\u0027, \u0027a\u0027)"},{"line_number":80,"context_line":""},{"line_number":81,"context_line":"[formatter_context]"},{"line_number":82,"context_line":"class \u003d oslo_log.formatters.ContextFormatter"}],"source_content_type":"text/x-jinja2","patch_set":1,"id":"5faad753_4b7e27e5","line":79,"range":{"start_line":70,"start_character":0,"end_line":79,"end_character":97},"updated":"2019-09-09 15:45:53.000000000","message":"It\u0027s quite unintuitive that adding a custom log file pulls in this logging.conf which modifies the logging config from the defaults.","commit_id":"95656d11b25a96df791ace36d07b82b599f82d5e"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"b1d9984cf993a1b17b6a79d349832dfa956d564d","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"3fa7e38b_ea9bca6f","updated":"2019-09-26 10:16:24.000000000","message":"This file can be removed","commit_id":"a403f7321b4bed814ce585f3a4e3bec7592a1c09"}]}