)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"51273993b4d26318d57601ebe102b6aa3e556c31","unresolved":false,"context_lines":[{"line_number":9,"context_line":"The output from `nova-manage cell_v2 list_cells --verbose` contains"},{"line_number":10,"context_line":"an extra column, stating whether the cell is enabled or not. This means"},{"line_number":11,"context_line":"that the regex never matches, so existing_cells is always empty."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"This fix updates the regex by adding a match group for this field which"},{"line_number":14,"context_line":"may be used in a later change."},{"line_number":15,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"7faddb67_6f784c7d","line":12,"updated":"2019-09-03 17:05:04.000000000","message":"What\u0027s the consequence of this? Does it fail if run a second time?","commit_id":"201e4bfa3a8c8df0483f732d2ef77ab912d953c7"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"51273993b4d26318d57601ebe102b6aa3e556c31","unresolved":false,"context_lines":[{"line_number":16,"context_line":"Unfortuately the CLI doesn\u0027t output in JSON format, which would make"},{"line_number":17,"context_line":"this a lot less messy."},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"Change-Id: Ib6400b33785f3ef674bffc9329feb3e33bd3f9a3"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"7faddb67_6f9fecb2","line":19,"updated":"2019-09-03 17:05:04.000000000","message":"Could use a bug report.","commit_id":"201e4bfa3a8c8df0483f732d2ef77ab912d953c7"}],"ansible/roles/nova/tasks/create_cells.yml":[{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"51273993b4d26318d57601ebe102b6aa3e556c31","unresolved":false,"context_lines":[{"line_number":58,"context_line":"    # | None | 68a3f49e-27ec-422f-9e2e-2a4e5dc8291b | rabbit://openstack:password@1.2.3.4:5672 | mysql+pymysql://nova:password@1.2.3.4:3306/nova |  False   |"},{"line_number":59,"context_line":"    #"},{"line_number":60,"context_line":"    # NOTE(priteau): regexp doesn\u0027t support passwords containing spaces"},{"line_number":61,"context_line":"    regexp: \u0027\\| +(?!00000000-0000-0000-0000-000000000000)([0-9a-f\\-]+) +\\| +([^ ]+) +\\| +([^ ]+) +\\| +([^ ]+) +\\|$\u0027"},{"line_number":62,"context_line":"  set_fact:"},{"line_number":63,"context_line":"    existing_cells: \"{{ existing_cells_list.stdout | regex_findall(regexp, multiline\u003dTrue) }}\""},{"line_number":64,"context_line":"  run_once: True"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"7faddb67_8f7d886e","line":61,"updated":"2019-09-03 17:05:04.000000000","message":"Would a custom Jinja filter help make this less brittle? I was thinking an ansible module would be nice, but difficult as we\u0027d need to execute inside a container to get nova-manage.","commit_id":"201e4bfa3a8c8df0483f732d2ef77ab912d953c7"},{"author":{"_account_id":17669,"name":"Doug Szumski","email":"doug@stackhpc.com","username":"DougSzumski"},"change_message_id":"e296c5e65a72e8c669fe77cff6ec102c640b539e","unresolved":false,"context_lines":[{"line_number":58,"context_line":"    # | None | 68a3f49e-27ec-422f-9e2e-2a4e5dc8291b | rabbit://openstack:password@1.2.3.4:5672 | mysql+pymysql://nova:password@1.2.3.4:3306/nova |  False   |"},{"line_number":59,"context_line":"    #"},{"line_number":60,"context_line":"    # NOTE(priteau): regexp doesn\u0027t support passwords containing spaces"},{"line_number":61,"context_line":"    regexp: \u0027\\| +(?!00000000-0000-0000-0000-000000000000)([0-9a-f\\-]+) +\\| +([^ ]+) +\\| +([^ ]+) +\\| +([^ ]+) +\\|$\u0027"},{"line_number":62,"context_line":"  set_fact:"},{"line_number":63,"context_line":"    existing_cells: \"{{ existing_cells_list.stdout | regex_findall(regexp, multiline\u003dTrue) }}\""},{"line_number":64,"context_line":"  run_once: True"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"7faddb67_4f1d500d","line":61,"in_reply_to":"7faddb67_8f7d886e","updated":"2019-09-03 17:16:09.000000000","message":"Yeah, similar thoughts about the ansible module. I need to modify this for registering multiple cells, so I could consider making it more robust in a later patch?","commit_id":"201e4bfa3a8c8df0483f732d2ef77ab912d953c7"}]}
