)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"4cec712f458b630b468a93ad74b3482fe0c39307","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Hongbin Lu \u003chongbin034@gmail.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2019-09-08 02:56:54 +0000"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Fix Zun CI job"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"After the integration with placement [1], we need to configure how"},{"line_number":10,"context_line":"zun-compute is going to work with nova-compute."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"5faad753_b29e4205","line":7,"range":{"start_line":7,"start_character":0,"end_line":7,"end_character":14},"updated":"2019-09-08 07:34:29.000000000","message":"This is more general than that.\nI propose: \"Configure Zun for Placement (Train+)\"","commit_id":"ea52146a3095a6481248a303bd5d174eb6ccbb13"},{"author":{"_account_id":11536,"name":"hongbin","email":"hongbin034@gmail.com","username":"hongbin"},"change_message_id":"fae478351f788950d948f75f5b36910aa1346d5d","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Hongbin Lu \u003chongbin034@gmail.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2019-09-08 02:56:54 +0000"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Fix Zun CI job"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"After the integration with placement [1], we need to configure how"},{"line_number":10,"context_line":"zun-compute is going to work with nova-compute."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"5faad753_5297c991","line":7,"range":{"start_line":7,"start_character":0,"end_line":7,"end_character":14},"in_reply_to":"5faad753_b29e4205","updated":"2019-09-09 03:06:03.000000000","message":"Done","commit_id":"ea52146a3095a6481248a303bd5d174eb6ccbb13"},{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"4cec712f458b630b468a93ad74b3482fe0c39307","unresolved":false,"context_lines":[{"line_number":9,"context_line":"After the integration with placement [1], we need to configure how"},{"line_number":10,"context_line":"zun-compute is going to work with nova-compute."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"* If zun-compute and nova-compute run in the same compute node,"},{"line_number":13,"context_line":"  we need to set \u0027host_shared_with_nova\u0027 as true so that Zun"},{"line_number":14,"context_line":"  will use the resource provider (compute node) created by nova."},{"line_number":15,"context_line":"  In this mode, containers and VMs could claim allocations againest"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"5faad753_d2a3be4e","line":12,"range":{"start_line":12,"start_character":38,"end_line":12,"end_character":40},"updated":"2019-09-08 07:34:29.000000000","message":"nit: on","commit_id":"ea52146a3095a6481248a303bd5d174eb6ccbb13"},{"author":{"_account_id":11536,"name":"hongbin","email":"hongbin034@gmail.com","username":"hongbin"},"change_message_id":"fae478351f788950d948f75f5b36910aa1346d5d","unresolved":false,"context_lines":[{"line_number":9,"context_line":"After the integration with placement [1], we need to configure how"},{"line_number":10,"context_line":"zun-compute is going to work with nova-compute."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"* If zun-compute and nova-compute run in the same compute node,"},{"line_number":13,"context_line":"  we need to set \u0027host_shared_with_nova\u0027 as true so that Zun"},{"line_number":14,"context_line":"  will use the resource provider (compute node) created by nova."},{"line_number":15,"context_line":"  In this mode, containers and VMs could claim allocations againest"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"5faad753_7294458c","line":12,"range":{"start_line":12,"start_character":38,"end_line":12,"end_character":40},"in_reply_to":"5faad753_d2a3be4e","updated":"2019-09-09 03:06:03.000000000","message":"Done","commit_id":"ea52146a3095a6481248a303bd5d174eb6ccbb13"},{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"4cec712f458b630b468a93ad74b3482fe0c39307","unresolved":false,"context_lines":[{"line_number":12,"context_line":"* If zun-compute and nova-compute run in the same compute node,"},{"line_number":13,"context_line":"  we need to set \u0027host_shared_with_nova\u0027 as true so that Zun"},{"line_number":14,"context_line":"  will use the resource provider (compute node) created by nova."},{"line_number":15,"context_line":"  In this mode, containers and VMs could claim allocations againest"},{"line_number":16,"context_line":"  the same resource provider."},{"line_number":17,"context_line":"* If zun-compute runs in a node without nova-compute, no extra"},{"line_number":18,"context_line":"  configuration is needed. By default, each zun-compute will create"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"5faad753_7288cac5","line":15,"range":{"start_line":15,"start_character":59,"end_line":15,"end_character":67},"updated":"2019-09-08 07:34:29.000000000","message":"nit: against","commit_id":"ea52146a3095a6481248a303bd5d174eb6ccbb13"},{"author":{"_account_id":11536,"name":"hongbin","email":"hongbin034@gmail.com","username":"hongbin"},"change_message_id":"fae478351f788950d948f75f5b36910aa1346d5d","unresolved":false,"context_lines":[{"line_number":12,"context_line":"* If zun-compute and nova-compute run in the same compute node,"},{"line_number":13,"context_line":"  we need to set \u0027host_shared_with_nova\u0027 as true so that Zun"},{"line_number":14,"context_line":"  will use the resource provider (compute node) created by nova."},{"line_number":15,"context_line":"  In this mode, containers and VMs could claim allocations againest"},{"line_number":16,"context_line":"  the same resource provider."},{"line_number":17,"context_line":"* If zun-compute runs in a node without nova-compute, no extra"},{"line_number":18,"context_line":"  configuration is needed. By default, each zun-compute will create"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"5faad753_1291519a","line":15,"range":{"start_line":15,"start_character":59,"end_line":15,"end_character":67},"in_reply_to":"5faad753_7288cac5","updated":"2019-09-09 03:06:03.000000000","message":"Done","commit_id":"ea52146a3095a6481248a303bd5d174eb6ccbb13"},{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"4cec712f458b630b468a93ad74b3482fe0c39307","unresolved":false,"context_lines":[{"line_number":14,"context_line":"  will use the resource provider (compute node) created by nova."},{"line_number":15,"context_line":"  In this mode, containers and VMs could claim allocations againest"},{"line_number":16,"context_line":"  the same resource provider."},{"line_number":17,"context_line":"* If zun-compute runs in a node without nova-compute, no extra"},{"line_number":18,"context_line":"  configuration is needed. By default, each zun-compute will create"},{"line_number":19,"context_line":"  a resource provider in placement to represent the compute node"},{"line_number":20,"context_line":"  it manages."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"5faad753_928546b0","line":17,"range":{"start_line":17,"start_character":22,"end_line":17,"end_character":24},"updated":"2019-09-08 07:34:29.000000000","message":"nit: on","commit_id":"ea52146a3095a6481248a303bd5d174eb6ccbb13"},{"author":{"_account_id":11536,"name":"hongbin","email":"hongbin034@gmail.com","username":"hongbin"},"change_message_id":"fae478351f788950d948f75f5b36910aa1346d5d","unresolved":false,"context_lines":[{"line_number":14,"context_line":"  will use the resource provider (compute node) created by nova."},{"line_number":15,"context_line":"  In this mode, containers and VMs could claim allocations againest"},{"line_number":16,"context_line":"  the same resource provider."},{"line_number":17,"context_line":"* If zun-compute runs in a node without nova-compute, no extra"},{"line_number":18,"context_line":"  configuration is needed. By default, each zun-compute will create"},{"line_number":19,"context_line":"  a resource provider in placement to represent the compute node"},{"line_number":20,"context_line":"  it manages."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"5faad753_328ecd78","line":17,"range":{"start_line":17,"start_character":22,"end_line":17,"end_character":24},"in_reply_to":"5faad753_928546b0","updated":"2019-09-09 03:06:03.000000000","message":"Done","commit_id":"ea52146a3095a6481248a303bd5d174eb6ccbb13"},{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"4cec712f458b630b468a93ad74b3482fe0c39307","unresolved":false,"context_lines":[{"line_number":18,"context_line":"  configuration is needed. By default, each zun-compute will create"},{"line_number":19,"context_line":"  a resource provider in placement to represent the compute node"},{"line_number":20,"context_line":"  it manages."},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"[1] https://blueprints.launchpad.net/zun/+spec/use-placement-resource-management"},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"Change-Id: I2d85911c4504e541d2994ce3d48e2fbb1090b813"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"5faad753_528fcecb","line":21,"updated":"2019-09-08 07:34:29.000000000","message":"Just curious: What happens if both run on the same node and we forget to set the variable? Do we get duplicates in Placement? Zun and/or Nova errors out? World ends?","commit_id":"ea52146a3095a6481248a303bd5d174eb6ccbb13"},{"author":{"_account_id":11536,"name":"hongbin","email":"hongbin034@gmail.com","username":"hongbin"},"change_message_id":"fae478351f788950d948f75f5b36910aa1346d5d","unresolved":false,"context_lines":[{"line_number":18,"context_line":"  configuration is needed. By default, each zun-compute will create"},{"line_number":19,"context_line":"  a resource provider in placement to represent the compute node"},{"line_number":20,"context_line":"  it manages."},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"[1] https://blueprints.launchpad.net/zun/+spec/use-placement-resource-management"},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"Change-Id: I2d85911c4504e541d2994ce3d48e2fbb1090b813"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"5faad753_b2f71df6","line":21,"in_reply_to":"5faad753_528fcecb","updated":"2019-09-09 03:06:03.000000000","message":"The nova-compute container will start first and create the resource provider. Then, the zun-compute container will create the same resource provider and get an 409 response from placement, thus failing.","commit_id":"ea52146a3095a6481248a303bd5d174eb6ccbb13"},{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"ad8b3e38f9b667755bfac360e98544b58a95e2c1","unresolved":false,"context_lines":[{"line_number":18,"context_line":"  configuration is needed. By default, each zun-compute will create"},{"line_number":19,"context_line":"  a resource provider in placement to represent the compute node"},{"line_number":20,"context_line":"  it manages."},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"[1] https://blueprints.launchpad.net/zun/+spec/use-placement-resource-management"},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"Change-Id: I2d85911c4504e541d2994ce3d48e2fbb1090b813"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"5faad753_f1aa6683","line":21,"in_reply_to":"5faad753_b2f71df6","updated":"2019-09-09 16:49:21.000000000","message":"Thanks, that makes sense (kind of).","commit_id":"ea52146a3095a6481248a303bd5d174eb6ccbb13"}],"ansible/roles/zun/tasks/config.yml":[{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"4cec712f458b630b468a93ad74b3482fe0c39307","unresolved":false,"context_lines":[{"line_number":46,"context_line":"  set_fact:"},{"line_number":47,"context_line":"    host_shared_with_nova: \"true\""},{"line_number":48,"context_line":"  when:"},{"line_number":49,"context_line":"    - inventory_hostname in groups[\u0027zun-compute\u0027]"},{"line_number":50,"context_line":"    - enable_nova | bool"},{"line_number":51,"context_line":""},{"line_number":52,"context_line":"- name: Copying over zun.conf"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"5faad753_9200e636","line":49,"range":{"start_line":49,"start_character":36,"end_line":49,"end_character":47},"updated":"2019-09-08 07:34:29.000000000","message":"compute","commit_id":"ea52146a3095a6481248a303bd5d174eb6ccbb13"},{"author":{"_account_id":11536,"name":"hongbin","email":"hongbin034@gmail.com","username":"hongbin"},"change_message_id":"fae478351f788950d948f75f5b36910aa1346d5d","unresolved":false,"context_lines":[{"line_number":46,"context_line":"  set_fact:"},{"line_number":47,"context_line":"    host_shared_with_nova: \"true\""},{"line_number":48,"context_line":"  when:"},{"line_number":49,"context_line":"    - inventory_hostname in groups[\u0027zun-compute\u0027]"},{"line_number":50,"context_line":"    - enable_nova | bool"},{"line_number":51,"context_line":""},{"line_number":52,"context_line":"- name: Copying over zun.conf"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"5faad753_92cb01a4","line":49,"range":{"start_line":49,"start_character":36,"end_line":49,"end_character":47},"in_reply_to":"5faad753_9200e636","updated":"2019-09-09 03:06:03.000000000","message":"Done","commit_id":"ea52146a3095a6481248a303bd5d174eb6ccbb13"},{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"4cec712f458b630b468a93ad74b3482fe0c39307","unresolved":false,"context_lines":[{"line_number":47,"context_line":"    host_shared_with_nova: \"true\""},{"line_number":48,"context_line":"  when:"},{"line_number":49,"context_line":"    - inventory_hostname in groups[\u0027zun-compute\u0027]"},{"line_number":50,"context_line":"    - enable_nova | bool"},{"line_number":51,"context_line":""},{"line_number":52,"context_line":"- name: Copying over zun.conf"},{"line_number":53,"context_line":"  vars:"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"5faad753_52fa6e42","line":50,"updated":"2019-09-08 07:34:29.000000000","message":"also:\nnot enable_nova_fake | bool","commit_id":"ea52146a3095a6481248a303bd5d174eb6ccbb13"},{"author":{"_account_id":11536,"name":"hongbin","email":"hongbin034@gmail.com","username":"hongbin"},"change_message_id":"fae478351f788950d948f75f5b36910aa1346d5d","unresolved":false,"context_lines":[{"line_number":47,"context_line":"    host_shared_with_nova: \"true\""},{"line_number":48,"context_line":"  when:"},{"line_number":49,"context_line":"    - inventory_hostname in groups[\u0027zun-compute\u0027]"},{"line_number":50,"context_line":"    - enable_nova | bool"},{"line_number":51,"context_line":""},{"line_number":52,"context_line":"- name: Copying over zun.conf"},{"line_number":53,"context_line":"  vars:"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"5faad753_b2d07d52","line":50,"in_reply_to":"5faad753_52fa6e42","updated":"2019-09-09 03:06:03.000000000","message":"Done","commit_id":"ea52146a3095a6481248a303bd5d174eb6ccbb13"},{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"4cec712f458b630b468a93ad74b3482fe0c39307","unresolved":false,"context_lines":[{"line_number":48,"context_line":"  when:"},{"line_number":49,"context_line":"    - inventory_hostname in groups[\u0027zun-compute\u0027]"},{"line_number":50,"context_line":"    - enable_nova | bool"},{"line_number":51,"context_line":""},{"line_number":52,"context_line":"- name: Copying over zun.conf"},{"line_number":53,"context_line":"  vars:"},{"line_number":54,"context_line":"    service_name: \"{{ item.key }}\""}],"source_content_type":"text/x-yaml","patch_set":3,"id":"5faad753_f294baea","line":51,"updated":"2019-09-08 07:34:29.000000000","message":"ideally we should get these conditions from nova role @mgoddard for the rescue","commit_id":"ea52146a3095a6481248a303bd5d174eb6ccbb13"},{"author":{"_account_id":11536,"name":"hongbin","email":"hongbin034@gmail.com","username":"hongbin"},"change_message_id":"fae478351f788950d948f75f5b36910aa1346d5d","unresolved":false,"context_lines":[{"line_number":48,"context_line":"  when:"},{"line_number":49,"context_line":"    - inventory_hostname in groups[\u0027zun-compute\u0027]"},{"line_number":50,"context_line":"    - enable_nova | bool"},{"line_number":51,"context_line":""},{"line_number":52,"context_line":"- name: Copying over zun.conf"},{"line_number":53,"context_line":"  vars:"},{"line_number":54,"context_line":"    service_name: \"{{ item.key }}\""}],"source_content_type":"text/x-yaml","patch_set":3,"id":"5faad753_1254f1c9","line":51,"in_reply_to":"5faad753_f294baea","updated":"2019-09-09 03:06:03.000000000","message":"Not sure exactly what you mean but let me know if anything specific I should do in this patch.","commit_id":"ea52146a3095a6481248a303bd5d174eb6ccbb13"}],"ansible/roles/zun/templates/zun.conf.j2":[{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"4cec712f458b630b468a93ad74b3482fe0c39307","unresolved":false,"context_lines":[{"line_number":81,"context_line":"[cinder_client]"},{"line_number":82,"context_line":"region_name \u003d {{ openstack_region_name }}"},{"line_number":83,"context_line":"endpoint_type \u003d internalURL"},{"line_number":84,"context_line":""},{"line_number":85,"context_line":"{% if enable_osprofiler | bool %}"},{"line_number":86,"context_line":"[profiler]"},{"line_number":87,"context_line":"enabled \u003d true"}],"source_content_type":"text/x-jinja2","patch_set":3,"id":"5faad753_129ab613","line":84,"updated":"2019-09-08 07:34:29.000000000","message":"we should also target configuration for placement now:\nhttps://bugs.launchpad.net/kolla-ansible/+bug/1840573\n(mention in commit message after fixing)","commit_id":"ea52146a3095a6481248a303bd5d174eb6ccbb13"},{"author":{"_account_id":11536,"name":"hongbin","email":"hongbin034@gmail.com","username":"hongbin"},"change_message_id":"fae478351f788950d948f75f5b36910aa1346d5d","unresolved":false,"context_lines":[{"line_number":81,"context_line":"[cinder_client]"},{"line_number":82,"context_line":"region_name \u003d {{ openstack_region_name }}"},{"line_number":83,"context_line":"endpoint_type \u003d internalURL"},{"line_number":84,"context_line":""},{"line_number":85,"context_line":"{% if enable_osprofiler | bool %}"},{"line_number":86,"context_line":"[profiler]"},{"line_number":87,"context_line":"enabled \u003d true"}],"source_content_type":"text/x-jinja2","patch_set":3,"id":"5faad753_b25e3de4","line":84,"in_reply_to":"5faad753_129ab613","updated":"2019-09-09 03:06:03.000000000","message":"Good catch! I saw you self-assigned the bug so I leave this to you, or let me know if you want to incorporate the fix in this patch.","commit_id":"ea52146a3095a6481248a303bd5d174eb6ccbb13"},{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"ad8b3e38f9b667755bfac360e98544b58a95e2c1","unresolved":false,"context_lines":[{"line_number":81,"context_line":"[cinder_client]"},{"line_number":82,"context_line":"region_name \u003d {{ openstack_region_name }}"},{"line_number":83,"context_line":"endpoint_type \u003d internalURL"},{"line_number":84,"context_line":""},{"line_number":85,"context_line":"{% if enable_osprofiler | bool %}"},{"line_number":86,"context_line":"[profiler]"},{"line_number":87,"context_line":"enabled \u003d true"}],"source_content_type":"text/x-jinja2","patch_set":3,"id":"5faad753_d1916a54","line":84,"in_reply_to":"5faad753_b25e3de4","updated":"2019-09-09 16:49:21.000000000","message":"Either way is fine. I assigned it to myself to remember to do it.","commit_id":"ea52146a3095a6481248a303bd5d174eb6ccbb13"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"7d0e4d68a82b4bb2a7238d33f781bedc44c7b922","unresolved":false,"context_lines":[{"line_number":100,"context_line":""},{"line_number":101,"context_line":"{% if host_shared_with_nova is defined %}"},{"line_number":102,"context_line":"[compute]"},{"line_number":103,"context_line":"host_shared_with_nova \u003d {{ host_shared_with_nova }}"},{"line_number":104,"context_line":"{% endif %}"},{"line_number":105,"context_line":""},{"line_number":106,"context_line":"[websocket_proxy]"}],"source_content_type":"text/x-jinja2","patch_set":4,"id":"5faad753_ab1244b0","line":103,"range":{"start_line":103,"start_character":24,"end_line":103,"end_character":51},"updated":"2019-09-09 08:47:12.000000000","message":"Why not this?\n\n{{ inventory_hostname in groups[\u0027compute\u0027] and enable_nova | bool and not enable_nova_fake | bool }}","commit_id":"a743ef953dbea58877bd1a21ba7abdee4fbcbddb"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"1a3a343b627f4a42e73d6e5e8aa1bfd10eddbd2d","unresolved":false,"context_lines":[{"line_number":100,"context_line":""},{"line_number":101,"context_line":"{% if host_shared_with_nova is defined %}"},{"line_number":102,"context_line":"[compute]"},{"line_number":103,"context_line":"host_shared_with_nova \u003d {{ host_shared_with_nova }}"},{"line_number":104,"context_line":"{% endif %}"},{"line_number":105,"context_line":""},{"line_number":106,"context_line":"[websocket_proxy]"}],"source_content_type":"text/x-jinja2","patch_set":4,"id":"5faad753_99178652","line":103,"range":{"start_line":103,"start_character":24,"end_line":103,"end_character":51},"in_reply_to":"5faad753_518fba29","updated":"2019-09-10 12:41:30.000000000","message":"We won\u0027t have access to it from this role.","commit_id":"a743ef953dbea58877bd1a21ba7abdee4fbcbddb"},{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"6feaac6d0658f69c6817eaf448055dc90b1d1de3","unresolved":false,"context_lines":[{"line_number":100,"context_line":""},{"line_number":101,"context_line":"{% if host_shared_with_nova is defined %}"},{"line_number":102,"context_line":"[compute]"},{"line_number":103,"context_line":"host_shared_with_nova \u003d {{ host_shared_with_nova }}"},{"line_number":104,"context_line":"{% endif %}"},{"line_number":105,"context_line":""},{"line_number":106,"context_line":"[websocket_proxy]"}],"source_content_type":"text/x-jinja2","patch_set":4,"id":"5faad753_a176c005","line":103,"range":{"start_line":103,"start_character":24,"end_line":103,"end_character":51},"in_reply_to":"5faad753_99178652","updated":"2019-09-10 16:31:29.000000000","message":"@mgoddard, felt so but could not check myself. Thanks.","commit_id":"a743ef953dbea58877bd1a21ba7abdee4fbcbddb"},{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"ad8b3e38f9b667755bfac360e98544b58a95e2c1","unresolved":false,"context_lines":[{"line_number":100,"context_line":""},{"line_number":101,"context_line":"{% if host_shared_with_nova is defined %}"},{"line_number":102,"context_line":"[compute]"},{"line_number":103,"context_line":"host_shared_with_nova \u003d {{ host_shared_with_nova }}"},{"line_number":104,"context_line":"{% endif %}"},{"line_number":105,"context_line":""},{"line_number":106,"context_line":"[websocket_proxy]"}],"source_content_type":"text/x-jinja2","patch_set":4,"id":"5faad753_518fba29","line":103,"range":{"start_line":103,"start_character":24,"end_line":103,"end_character":51},"in_reply_to":"5faad753_ab1244b0","updated":"2019-09-09 16:49:21.000000000","message":"+1\n\n@mgoddard - or is not it better to lookup the relevant setting from the nova service config dict?","commit_id":"a743ef953dbea58877bd1a21ba7abdee4fbcbddb"},{"author":{"_account_id":11536,"name":"hongbin","email":"hongbin034@gmail.com","username":"hongbin"},"change_message_id":"b5e7cbb3d70dec0f4578d0aef0a75085887df6c4","unresolved":false,"context_lines":[{"line_number":100,"context_line":""},{"line_number":101,"context_line":"{% if host_shared_with_nova is defined %}"},{"line_number":102,"context_line":"[compute]"},{"line_number":103,"context_line":"host_shared_with_nova \u003d {{ host_shared_with_nova }}"},{"line_number":104,"context_line":"{% endif %}"},{"line_number":105,"context_line":""},{"line_number":106,"context_line":"[websocket_proxy]"}],"source_content_type":"text/x-jinja2","patch_set":4,"id":"5faad753_a5c81f55","line":103,"range":{"start_line":103,"start_character":24,"end_line":103,"end_character":51},"in_reply_to":"5faad753_ab1244b0","updated":"2019-09-10 01:48:18.000000000","message":"Done","commit_id":"a743ef953dbea58877bd1a21ba7abdee4fbcbddb"}]}