)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"dd7f384a5dd9d6b90213655f9ea0e29f0fba5d16","unresolved":false,"context_lines":[{"line_number":10,"context_line":"nodename (if different) point to 127.0.1.1. This can break RabbitMQ,"},{"line_number":11,"context_line":"which expects the hostname to resolve to the API network address."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"This change removes these troublesome entries."},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"Change-Id: I53261d0403b983ab419bd44e705b89f7b7a1c316"},{"line_number":16,"context_line":"Closes-Bug: #1837699"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"3fa7e38b_c555f451","line":13,"updated":"2019-10-08 08:37:54.000000000","message":"Commit message needs updating.","commit_id":"e0c73ed2c0a246b71a6d2f4d7f3c05a4feac6811"}],"ansible/roles/baremetal/tasks/pre-install.yml":[{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"6557593aadf7a4c09f7e2c726ce83d7ac268923b","unresolved":false,"context_lines":[{"line_number":20,"context_line":"# hostname and nodename (if different) point to 127.0.1.1. This can break"},{"line_number":21,"context_line":"# RabbitMQ, which expects the hostname to resolve to the API network address."},{"line_number":22,"context_line":"# Remove these troublesome entries."},{"line_number":23,"context_line":"- name: Ensure hostname does not point to localhost in /etc/hosts"},{"line_number":24,"context_line":"  lineinfile:"},{"line_number":25,"context_line":"    dest: /etc/hosts"},{"line_number":26,"context_line":"    regexp: \"^127.\\\\d+.\\\\d+.\\\\d+\\\\s+({{ ansible_nodename }})?\\\\s*{{ ansible_hostname }}$\""}],"source_content_type":"text/x-yaml","patch_set":1,"id":"3fa7e38b_7df6a9d9","line":23,"range":{"start_line":23,"start_character":42,"end_line":23,"end_character":51},"updated":"2019-09-27 12:01:36.000000000","message":"loopback","commit_id":"06406dec6a33da315ca99f3012a0c66324ad7e55"},{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"6557593aadf7a4c09f7e2c726ce83d7ac268923b","unresolved":false,"context_lines":[{"line_number":23,"context_line":"- name: Ensure hostname does not point to localhost in /etc/hosts"},{"line_number":24,"context_line":"  lineinfile:"},{"line_number":25,"context_line":"    dest: /etc/hosts"},{"line_number":26,"context_line":"    regexp: \"^127.\\\\d+.\\\\d+.\\\\d+\\\\s+({{ ansible_nodename }})?\\\\s*{{ ansible_hostname }}$\""},{"line_number":27,"context_line":"    state: absent"},{"line_number":28,"context_line":"  become: True"},{"line_number":29,"context_line":"  when: customize_etc_hosts | bool"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"3fa7e38b_ddd55d1d","line":26,"range":{"start_line":26,"start_character":32,"end_line":26,"end_character":65},"updated":"2019-09-27 12:01:36.000000000","message":"(\\\\s+{{ ansible_nodename }})?\\\\s+","commit_id":"06406dec6a33da315ca99f3012a0c66324ad7e55"},{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"7268bf9f8e48929a84c9443448d146f24a4c2f9e","unresolved":false,"context_lines":[{"line_number":48,"context_line":"      \u0027ansible_\u0027 + hostvars[inventory_hostname][\u0027api_interface\u0027] in hostvars[inventory_hostname]"},{"line_number":49,"context_line":""},{"line_number":50,"context_line":"# NOTE(osmanlicilegi): The distro might use cloud-init and it can break /etc/hosts"},{"line_number":51,"context_line":"# if update_etc_hosts is configured. We should disable it."},{"line_number":52,"context_line":"- name: Ensure /etc/cloud/cloud.cfg exists"},{"line_number":53,"context_line":"  stat:"},{"line_number":54,"context_line":"    path: /etc/cloud/cloud.cfg"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"3fa7e38b_2a81374b","line":51,"updated":"2019-10-08 06:51:57.000000000","message":"for clarity you can put both in a block with the condition on update_...","commit_id":"9572452e388b58e90daaaaed88e688aaf8bf2507"},{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"648af0ae4715ec6dbc29f63c476900e6257273e5","unresolved":false,"context_lines":[{"line_number":49,"context_line":""},{"line_number":50,"context_line":"# NOTE(osmanlicilegi): The distro might use cloud-init and it can break /etc/hosts"},{"line_number":51,"context_line":"# if update_etc_hosts is configured. We should disable it."},{"line_number":52,"context_line":"- name: Ensure /etc/cloud/cloud.cfg exists"},{"line_number":53,"context_line":"  stat:"},{"line_number":54,"context_line":"    path: /etc/cloud/cloud.cfg"},{"line_number":55,"context_line":"    register: cloud_init"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"3fa7e38b_6a796f91","line":52,"updated":"2019-10-08 06:50:39.000000000","message":"become: True","commit_id":"9572452e388b58e90daaaaed88e688aaf8bf2507"},{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"648af0ae4715ec6dbc29f63c476900e6257273e5","unresolved":false,"context_lines":[{"line_number":53,"context_line":"  stat:"},{"line_number":54,"context_line":"    path: /etc/cloud/cloud.cfg"},{"line_number":55,"context_line":"    register: cloud_init"},{"line_number":56,"context_line":"    become: True"},{"line_number":57,"context_line":"    when: customize_etc_hosts | bool"},{"line_number":58,"context_line":""},{"line_number":59,"context_line":"- name: Disable update_etc_hosts for cloud-init"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"3fa7e38b_2a7377b3","line":56,"updated":"2019-10-08 06:50:39.000000000","message":"this one should be gone :-)","commit_id":"9572452e388b58e90daaaaed88e688aaf8bf2507"},{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"648af0ae4715ec6dbc29f63c476900e6257273e5","unresolved":false,"context_lines":[{"line_number":56,"context_line":"    become: True"},{"line_number":57,"context_line":"    when: customize_etc_hosts | bool"},{"line_number":58,"context_line":""},{"line_number":59,"context_line":"- name: Disable update_etc_hosts for cloud-init"},{"line_number":60,"context_line":"  replace:"},{"line_number":61,"context_line":"    dest: /etc/cloud/cloud.cfg"},{"line_number":62,"context_line":"    regexp: \"(.*)update_etc_hosts(.*)\""}],"source_content_type":"text/x-yaml","patch_set":3,"id":"3fa7e38b_aa452745","line":59,"updated":"2019-10-08 06:50:39.000000000","message":"become: True","commit_id":"9572452e388b58e90daaaaed88e688aaf8bf2507"},{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"648af0ae4715ec6dbc29f63c476900e6257273e5","unresolved":false,"context_lines":[{"line_number":61,"context_line":"    dest: /etc/cloud/cloud.cfg"},{"line_number":62,"context_line":"    regexp: \"(.*)update_etc_hosts(.*)\""},{"line_number":63,"context_line":"    replace: \"# update_etc_hosts is disabled by kolla-ansible\""},{"line_number":64,"context_line":"    when: cloud_init.stat.exists and (customize_etc_hosts | bool)"},{"line_number":65,"context_line":""},{"line_number":66,"context_line":"- name: Ensure sudo group is present"},{"line_number":67,"context_line":"  group:"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"3fa7e38b_0aa55b04","line":64,"updated":"2019-10-08 06:50:39.000000000","message":"better use the list notation here","commit_id":"9572452e388b58e90daaaaed88e688aaf8bf2507"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"b7b221281306d41328a2b419330b015e2c611018","unresolved":false,"context_lines":[{"line_number":54,"context_line":"    - name: Ensure /etc/cloud/cloud.cfg exists"},{"line_number":55,"context_line":"      stat:"},{"line_number":56,"context_line":"        path: /etc/cloud/cloud.cfg"},{"line_number":57,"context_line":"        register: cloud_init"},{"line_number":58,"context_line":"      become: True"},{"line_number":59,"context_line":"      when: customize_etc_hosts | bool"},{"line_number":60,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":4,"id":"3fa7e38b_3da64a55","line":57,"range":{"start_line":57,"start_character":8,"end_line":57,"end_character":16},"updated":"2019-10-09 08:15:32.000000000","message":"register should be at same level as name/become.","commit_id":"e0c73ed2c0a246b71a6d2f4d7f3c05a4feac6811"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"dd7f384a5dd9d6b90213655f9ea0e29f0fba5d16","unresolved":false,"context_lines":[{"line_number":55,"context_line":"      stat:"},{"line_number":56,"context_line":"        path: /etc/cloud/cloud.cfg"},{"line_number":57,"context_line":"        register: cloud_init"},{"line_number":58,"context_line":"      become: True"},{"line_number":59,"context_line":"      when: customize_etc_hosts | bool"},{"line_number":60,"context_line":""},{"line_number":61,"context_line":"    - name: Disable update_etc_hosts"},{"line_number":62,"context_line":"      replace:"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"3fa7e38b_65ca001b","line":59,"range":{"start_line":58,"start_character":0,"end_line":59,"end_character":38},"updated":"2019-10-08 08:37:54.000000000","message":"become and when can be added at the block level.","commit_id":"e0c73ed2c0a246b71a6d2f4d7f3c05a4feac6811"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"b7b221281306d41328a2b419330b015e2c611018","unresolved":false,"context_lines":[{"line_number":58,"context_line":"      become: True"},{"line_number":59,"context_line":"      when: customize_etc_hosts | bool"},{"line_number":60,"context_line":""},{"line_number":61,"context_line":"    - name: Disable update_etc_hosts"},{"line_number":62,"context_line":"      replace:"},{"line_number":63,"context_line":"        dest: /etc/cloud/cloud.cfg"},{"line_number":64,"context_line":"        regexp: \"(.*)update_etc_hosts(.*)\""}],"source_content_type":"text/x-yaml","patch_set":4,"id":"3fa7e38b_7dacc234","line":61,"range":{"start_line":61,"start_character":20,"end_line":61,"end_character":36},"updated":"2019-10-09 08:15:32.000000000","message":"cloud-init update_etc_hosts module?","commit_id":"e0c73ed2c0a246b71a6d2f4d7f3c05a4feac6811"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"24693528ad99efcc1c746fbef34e1867ed1566ff","unresolved":false,"context_lines":[{"line_number":56,"context_line":"    - name: Ensure /etc/cloud/cloud.cfg exists"},{"line_number":57,"context_line":"      stat:"},{"line_number":58,"context_line":"        path: /etc/cloud/cloud.cfg"},{"line_number":59,"context_line":"        register: cloud_init"},{"line_number":60,"context_line":""},{"line_number":61,"context_line":"    - name: Disable cloud-init manage_etc_hosts"},{"line_number":62,"context_line":"      copy:"}],"source_content_type":"text/x-yaml","patch_set":5,"id":"3fa7e38b_60c2c036","line":59,"range":{"start_line":59,"start_character":8,"end_line":59,"end_character":16},"updated":"2019-10-10 12:39:39.000000000","message":"still at wrong level","commit_id":"323bbe53fff5ffee8bda99b085041384459c9f01"}]}