)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"52981759e024b5e2e8af4144069568b7982b1520","unresolved":false,"context_lines":[{"line_number":13,"context_line":""},{"line_number":14,"context_line":"but it seems dirty to overwrite stuff installed by the system"},{"line_number":15,"context_line":"package manager, so this change uses a virtualenv and upgrades"},{"line_number":16,"context_line":"pip in there."},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"Change-Id: I4d96f921e025bdea783c8e88682683b25d844ce1"},{"line_number":19,"context_line":"Closes-Bug: #1845963"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"3fa7e38b_8b50ce0c","line":16,"updated":"2019-10-01 16:21:09.000000000","message":"Could just update pip?","commit_id":"18580c1d3330eee9201196e106b47169c715652a"}],"contrib/dev/vagrant/bootstrap.sh":[{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"b93154122477e7b030efe6450385ba5465b80d49","unresolved":false,"context_lines":[{"line_number":33,"context_line":"ADMIN_PROTOCOL\u003d\"http\""},{"line_number":34,"context_line":"VENV_PATH\u003d${VENV_PATH:-/opt/venv-kolla}"},{"line_number":35,"context_line":"KOLLA_CLI\u003d${KOLLA_CLI:-/opt/venv-kolla/bin/kolla-cli}"},{"line_number":36,"context_line":"PIP_ARGS\u003d\"-c https://opendev.org/openstack/requirements/raw/branch/master/upper-constraints.txt\""},{"line_number":37,"context_line":""},{"line_number":38,"context_line":"function _ensure_lsb_release {"},{"line_number":39,"context_line":"    if type lsb_release \u003e/dev/null 2\u003e\u00261; then"}],"source_content_type":"text/x-sh","patch_set":3,"id":"3fa7e38b_03860fba","line":36,"updated":"2019-10-01 08:31:46.000000000","message":"nit: https://releases.openstack.org/constraints/upper/master","commit_id":"6a00267fe13401cca585d3b83d2e2937fb6a7ca5"},{"author":{"_account_id":28048,"name":"Will Szumski","email":"will@stackhpc.com","username":"jovial"},"change_message_id":"e8bcbe6b3b99ced9760823ab0da29ecc400aac2f","unresolved":false,"context_lines":[{"line_number":33,"context_line":"ADMIN_PROTOCOL\u003d\"http\""},{"line_number":34,"context_line":"VENV_PATH\u003d${VENV_PATH:-/opt/venv-kolla}"},{"line_number":35,"context_line":"KOLLA_CLI\u003d${KOLLA_CLI:-/opt/venv-kolla/bin/kolla-cli}"},{"line_number":36,"context_line":"PIP_ARGS\u003d\"-c https://opendev.org/openstack/requirements/raw/branch/master/upper-constraints.txt\""},{"line_number":37,"context_line":""},{"line_number":38,"context_line":"function _ensure_lsb_release {"},{"line_number":39,"context_line":"    if type lsb_release \u003e/dev/null 2\u003e\u00261; then"}],"source_content_type":"text/x-sh","patch_set":3,"id":"3fa7e38b_64ca6a1b","line":36,"in_reply_to":"3fa7e38b_03860fba","updated":"2019-10-01 10:13:13.000000000","message":"Done","commit_id":"6a00267fe13401cca585d3b83d2e2937fb6a7ca5"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"b93154122477e7b030efe6450385ba5465b80d49","unresolved":false,"context_lines":[{"line_number":110,"context_line":"}"},{"line_number":111,"context_line":""},{"line_number":112,"context_line":"# Install and configure a quick\u0026dirty docker daemon."},{"line_number":113,"context_line":"function install_docker {"},{"line_number":114,"context_line":"    if is_centos; then"},{"line_number":115,"context_line":"        cat \u003e/etc/yum.repos.d/docker.repo \u003c\u003c-EOF"},{"line_number":116,"context_line":"[dockerrepo]"}],"source_content_type":"text/x-sh","patch_set":3,"id":"3fa7e38b_23b6ab8b","line":113,"updated":"2019-10-01 08:31:46.000000000","message":"Hmm, I wonder why we\u0027re not using bootstrap-servers here. Nevermind.","commit_id":"6a00267fe13401cca585d3b83d2e2937fb6a7ca5"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"b93154122477e7b030efe6450385ba5465b80d49","unresolved":false,"context_lines":[{"line_number":113,"context_line":"function install_docker {"},{"line_number":114,"context_line":"    if is_centos; then"},{"line_number":115,"context_line":"        cat \u003e/etc/yum.repos.d/docker.repo \u003c\u003c-EOF"},{"line_number":116,"context_line":"[dockerrepo]"},{"line_number":117,"context_line":"name\u003dDocker Repository"},{"line_number":118,"context_line":"baseurl\u003dhttps://yum.dockerproject.org/repo/main/centos/7"},{"line_number":119,"context_line":"enabled\u003d1"},{"line_number":120,"context_line":"gpgcheck\u003d1"},{"line_number":121,"context_line":"gpgkey\u003dhttps://yum.dockerproject.org/gpg"},{"line_number":122,"context_line":"EOF"},{"line_number":123,"context_line":"        # Also upgrade device-mapper here because of:"},{"line_number":124,"context_line":"        # https://github.com/docker/docker/issues/12108"},{"line_number":125,"context_line":"        # Upgrade lvm2 to get device-mapper installed"}],"source_content_type":"text/x-sh","patch_set":3,"id":"3fa7e38b_e3b3b396","line":122,"range":{"start_line":116,"start_character":0,"end_line":122,"end_character":3},"updated":"2019-10-01 08:31:46.000000000","message":"This is the old docker... Sometimes best not to look :)","commit_id":"6a00267fe13401cca585d3b83d2e2937fb6a7ca5"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"b93154122477e7b030efe6450385ba5465b80d49","unresolved":false,"context_lines":[{"line_number":288,"context_line":""},{"line_number":289,"context_line":"    # Add executables to path to mimic behaviour prior to using"},{"line_number":290,"context_line":"    # a virtualenv."},{"line_number":291,"context_line":"    ln -s /opt/venv-kolla/bin/kolla-* /usr/local/bin/ || true"},{"line_number":292,"context_line":"}"},{"line_number":293,"context_line":""},{"line_number":294,"context_line":"prep_work"}],"source_content_type":"text/x-sh","patch_set":3,"id":"3fa7e38b_c379d7c4","line":291,"range":{"start_line":291,"start_character":4,"end_line":291,"end_character":61},"updated":"2019-10-01 08:31:46.000000000","message":"This is a bit weird, is it really necessary? Is it so that we can access kolla-cli outside the virtualenv?","commit_id":"6a00267fe13401cca585d3b83d2e2937fb6a7ca5"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"fd9667dc50ace62393d6a45a3e33498ce01ff732","unresolved":false,"context_lines":[{"line_number":288,"context_line":""},{"line_number":289,"context_line":"    # Add executables to path to mimic behaviour prior to using"},{"line_number":290,"context_line":"    # a virtualenv."},{"line_number":291,"context_line":"    ln -s /opt/venv-kolla/bin/kolla-* /usr/local/bin/ || true"},{"line_number":292,"context_line":"}"},{"line_number":293,"context_line":""},{"line_number":294,"context_line":"prep_work"}],"source_content_type":"text/x-sh","patch_set":3,"id":"3fa7e38b_1eb0a4dc","line":291,"range":{"start_line":291,"start_character":10,"end_line":291,"end_character":25},"updated":"2019-10-01 09:09:57.000000000","message":"VENV_PATH?","commit_id":"6a00267fe13401cca585d3b83d2e2937fb6a7ca5"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"fd9667dc50ace62393d6a45a3e33498ce01ff732","unresolved":false,"context_lines":[{"line_number":288,"context_line":""},{"line_number":289,"context_line":"    # Add executables to path to mimic behaviour prior to using"},{"line_number":290,"context_line":"    # a virtualenv."},{"line_number":291,"context_line":"    ln -s /opt/venv-kolla/bin/kolla-* /usr/local/bin/ || true"},{"line_number":292,"context_line":"}"},{"line_number":293,"context_line":""},{"line_number":294,"context_line":"prep_work"}],"source_content_type":"text/x-sh","patch_set":3,"id":"3fa7e38b_7ebd18b5","line":291,"range":{"start_line":291,"start_character":4,"end_line":291,"end_character":61},"in_reply_to":"3fa7e38b_3e856007","updated":"2019-10-01 09:09:57.000000000","message":"I guess it\u0027s fine like this.","commit_id":"6a00267fe13401cca585d3b83d2e2937fb6a7ca5"},{"author":{"_account_id":28048,"name":"Will Szumski","email":"will@stackhpc.com","username":"jovial"},"change_message_id":"e8bcbe6b3b99ced9760823ab0da29ecc400aac2f","unresolved":false,"context_lines":[{"line_number":288,"context_line":""},{"line_number":289,"context_line":"    # Add executables to path to mimic behaviour prior to using"},{"line_number":290,"context_line":"    # a virtualenv."},{"line_number":291,"context_line":"    ln -s /opt/venv-kolla/bin/kolla-* /usr/local/bin/ || true"},{"line_number":292,"context_line":"}"},{"line_number":293,"context_line":""},{"line_number":294,"context_line":"prep_work"}],"source_content_type":"text/x-sh","patch_set":3,"id":"3fa7e38b_04cff629","line":291,"range":{"start_line":291,"start_character":4,"end_line":291,"end_character":61},"in_reply_to":"3fa7e38b_7ebd18b5","updated":"2019-10-01 10:13:13.000000000","message":"Done","commit_id":"6a00267fe13401cca585d3b83d2e2937fb6a7ca5"},{"author":{"_account_id":28048,"name":"Will Szumski","email":"will@stackhpc.com","username":"jovial"},"change_message_id":"9c7761a240aa3a21254957aebf85f2c9384363e3","unresolved":false,"context_lines":[{"line_number":288,"context_line":""},{"line_number":289,"context_line":"    # Add executables to path to mimic behaviour prior to using"},{"line_number":290,"context_line":"    # a virtualenv."},{"line_number":291,"context_line":"    ln -s /opt/venv-kolla/bin/kolla-* /usr/local/bin/ || true"},{"line_number":292,"context_line":"}"},{"line_number":293,"context_line":""},{"line_number":294,"context_line":"prep_work"}],"source_content_type":"text/x-sh","patch_set":3,"id":"3fa7e38b_3e856007","line":291,"range":{"start_line":291,"start_character":4,"end_line":291,"end_character":61},"in_reply_to":"3fa7e38b_c379d7c4","updated":"2019-10-01 09:08:55.000000000","message":"Yeah, that was the intention. The documentation refers to running the command `kolla-build`, etc. I could update that to include a line to activate the virtualenv. What would you suggest?","commit_id":"6a00267fe13401cca585d3b83d2e2937fb6a7ca5"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"c3f180084ae8ba9b0152ef573217290886443200","unresolved":false,"context_lines":[{"line_number":91,"context_line":"        exit 1"},{"line_number":92,"context_line":"    fi"},{"line_number":93,"context_line":"    pip install -U pip $PIP_ARGS"},{"line_number":94,"context_line":"    pip install --upgrade docker $PIP_ARGS"},{"line_number":95,"context_line":"}"},{"line_number":96,"context_line":""},{"line_number":97,"context_line":"# Do some cleanup after the installation of kolla"}],"source_content_type":"text/x-sh","patch_set":5,"id":"3fa7e38b_b93ab995","line":94,"range":{"start_line":94,"start_character":4,"end_line":94,"end_character":42},"updated":"2019-10-02 08:51:52.000000000","message":"This is probably what broke the deploy, since it\u0027s necessary outside of the virtualenv if you don\u0027t set ansible_python_interpreter.","commit_id":"c38154fcc66197cacd753898d26d560089e73193"}]}