)]}'
{"ansible/roles/horizon/templates/horizon.conf.j2":[{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"7f710e31d6635ff7945507a1bc1e10fe4c92fff3","unresolved":false,"context_lines":[{"line_number":16,"context_line":"    WSGIDaemonProcess horizon-http processes\u003d{{ horizon_wsgi_processes }} threads\u003d{{ horizon_wsgi_threads }} user\u003dhorizon group\u003dhorizon display-name\u003d%{GROUP} python-path\u003d{{ python_path }}"},{"line_number":17,"context_line":"    WSGIProcessGroup horizon-http"},{"line_number":18,"context_line":"{% if kolla_base_distro in [\u0027debian\u0027] and horizon_install_type \u003d\u003d \u0027binary\u0027 %}"},{"line_number":19,"context_line":"    WSGIScriptAlias / {{ python_path }}/wsgi.py"},{"line_number":20,"context_line":"{% else %}"},{"line_number":21,"context_line":"    WSGIScriptAlias / {{ python_path }}/openstack_dashboard/wsgi/django.wsgi"},{"line_number":22,"context_line":"{% endif %}"}],"source_content_type":"text/x-jinja2","patch_set":2,"id":"3fa7e38b_1ce5fb0a","line":19,"range":{"start_line":19,"start_character":4,"end_line":19,"end_character":47},"updated":"2019-10-02 10:03:02.000000000","message":"fixing paths can also fix this","commit_id":"7d441e5d3611205e71feb3e1a26c8607c0939274"},{"author":{"_account_id":27339,"name":"Michal Arbet","email":"michal.arbet@ultimum.io","username":"michalarbet"},"change_message_id":"b6d299c3a7fdd903db8dd820df5b0942d51a87e1","unresolved":false,"context_lines":[{"line_number":16,"context_line":"    WSGIDaemonProcess horizon-http processes\u003d{{ horizon_wsgi_processes }} threads\u003d{{ horizon_wsgi_threads }} user\u003dhorizon group\u003dhorizon display-name\u003d%{GROUP} python-path\u003d{{ python_path }}"},{"line_number":17,"context_line":"    WSGIProcessGroup horizon-http"},{"line_number":18,"context_line":"{% if kolla_base_distro in [\u0027debian\u0027] and horizon_install_type \u003d\u003d \u0027binary\u0027 %}"},{"line_number":19,"context_line":"    WSGIScriptAlias / {{ python_path }}/wsgi.py"},{"line_number":20,"context_line":"{% else %}"},{"line_number":21,"context_line":"    WSGIScriptAlias / {{ python_path }}/openstack_dashboard/wsgi/django.wsgi"},{"line_number":22,"context_line":"{% endif %}"}],"source_content_type":"text/x-jinja2","patch_set":2,"id":"3fa7e38b_1ff72dd7","line":19,"range":{"start_line":19,"start_character":4,"end_line":19,"end_character":47},"in_reply_to":"3fa7e38b_1ce5fb0a","updated":"2019-10-02 11:11:12.000000000","message":"Radoslaw, check the comment what I\u0027ve written to Mark.\nI don\u0027t see any strong argument to change the paths in image.\nAs debian developer of horizon I will not change the paths.\nYou are reviewing kolla installed by binary packages , please, respect that installed binary way paths are as they are, so they are different.","commit_id":"7d441e5d3611205e71feb3e1a26c8607c0939274"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"a9d33f7ce93917fc3404c99f03114b4051545091","unresolved":false,"context_lines":[{"line_number":16,"context_line":"    WSGIDaemonProcess horizon-http processes\u003d{{ horizon_wsgi_processes }} threads\u003d{{ horizon_wsgi_threads }} user\u003dhorizon group\u003dhorizon display-name\u003d%{GROUP} python-path\u003d{{ python_path }}"},{"line_number":17,"context_line":"    WSGIProcessGroup horizon-http"},{"line_number":18,"context_line":"{% if kolla_base_distro in [\u0027debian\u0027] and horizon_install_type \u003d\u003d \u0027binary\u0027 %}"},{"line_number":19,"context_line":"    WSGIScriptAlias / {{ python_path }}/wsgi.py"},{"line_number":20,"context_line":"{% else %}"},{"line_number":21,"context_line":"    WSGIScriptAlias / {{ python_path }}/openstack_dashboard/wsgi/django.wsgi"},{"line_number":22,"context_line":"{% endif %}"}],"source_content_type":"text/x-jinja2","patch_set":2,"id":"3fa7e38b_bfd61927","line":19,"range":{"start_line":19,"start_character":4,"end_line":19,"end_character":47},"in_reply_to":"3fa7e38b_1ce5fb0a","updated":"2019-10-02 11:17:21.000000000","message":"We actually get a warning in horizon logs that we should be using wsgi.py instead of django.wsgi. Perhaps we should fix it for everyone.\n\ne.g. CentOS binary has /usr/share/openstack-dashboard/openstack_dashboard/wsgi.py.","commit_id":"7d441e5d3611205e71feb3e1a26c8607c0939274"},{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"b1c9330a82c269106fac8b80224a9361be58c2f6","unresolved":false,"context_lines":[{"line_number":16,"context_line":"    WSGIDaemonProcess horizon-http processes\u003d{{ horizon_wsgi_processes }} threads\u003d{{ horizon_wsgi_threads }} user\u003dhorizon group\u003dhorizon display-name\u003d%{GROUP} python-path\u003d{{ python_path }}"},{"line_number":17,"context_line":"    WSGIProcessGroup horizon-http"},{"line_number":18,"context_line":"{% if kolla_base_distro in [\u0027debian\u0027] and horizon_install_type \u003d\u003d \u0027binary\u0027 %}"},{"line_number":19,"context_line":"    WSGIScriptAlias / {{ python_path }}/wsgi.py"},{"line_number":20,"context_line":"{% else %}"},{"line_number":21,"context_line":"    WSGIScriptAlias / {{ python_path }}/openstack_dashboard/wsgi/django.wsgi"},{"line_number":22,"context_line":"{% endif %}"}],"source_content_type":"text/x-jinja2","patch_set":2,"id":"3fa7e38b_1c3ba99c","line":19,"range":{"start_line":19,"start_character":4,"end_line":19,"end_character":47},"in_reply_to":"3fa7e38b_1ff72dd7","updated":"2019-10-03 06:09:28.000000000","message":"Sure, Michal, symlinking would be ugly here.","commit_id":"7d441e5d3611205e71feb3e1a26c8607c0939274"}],"ansible/roles/horizon/templates/local_settings.j2":[{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"8597c0225e089f4bcfff0e54a9d9b026a70e2931","unresolved":false,"context_lines":[{"line_number":473,"context_line":"# target installation."},{"line_number":474,"context_line":""},{"line_number":475,"context_line":"# Path to directory containing policy.json files"},{"line_number":476,"context_line":"{% if horizon_install_type \u003d\u003d \u0027binary\u0027 and kolla_base_distro \u003d\u003d \u0027debian\u0027 %}"},{"line_number":477,"context_line":"POLICY_FILES_PATH \u003d \u0027/etc/openstack-dashboard/policy\u0027"},{"line_number":478,"context_line":"{% else %}"},{"line_number":479,"context_line":"POLICY_FILES_PATH \u003d \u0027/etc/openstack-dashboard\u0027"},{"line_number":480,"context_line":"{% endif %}"},{"line_number":481,"context_line":""},{"line_number":482,"context_line":"# Map of local copy of service policy files."},{"line_number":483,"context_line":"# Please insure that your identity policy file matches the one being used on"}],"source_content_type":"text/x-jinja2","patch_set":2,"id":"3fa7e38b_599dc508","line":480,"range":{"start_line":476,"start_character":0,"end_line":480,"end_character":11},"updated":"2019-10-02 09:22:41.000000000","message":"I\u0027d prefer us to fix up the paths in the image, rather than special case here.","commit_id":"7d441e5d3611205e71feb3e1a26c8607c0939274"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"a9d33f7ce93917fc3404c99f03114b4051545091","unresolved":false,"context_lines":[{"line_number":473,"context_line":"# target installation."},{"line_number":474,"context_line":""},{"line_number":475,"context_line":"# Path to directory containing policy.json files"},{"line_number":476,"context_line":"{% if horizon_install_type \u003d\u003d \u0027binary\u0027 and kolla_base_distro \u003d\u003d \u0027debian\u0027 %}"},{"line_number":477,"context_line":"POLICY_FILES_PATH \u003d \u0027/etc/openstack-dashboard/policy\u0027"},{"line_number":478,"context_line":"{% else %}"},{"line_number":479,"context_line":"POLICY_FILES_PATH \u003d \u0027/etc/openstack-dashboard\u0027"},{"line_number":480,"context_line":"{% endif %}"},{"line_number":481,"context_line":""},{"line_number":482,"context_line":"# Map of local copy of service policy files."},{"line_number":483,"context_line":"# Please insure that your identity policy file matches the one being used on"}],"source_content_type":"text/x-jinja2","patch_set":2,"id":"3fa7e38b_5fa9258e","line":480,"range":{"start_line":476,"start_character":0,"end_line":480,"end_character":11},"in_reply_to":"3fa7e38b_1f72cd7d","updated":"2019-10-02 11:17:21.000000000","message":"I don\u0027t suggest changing the package, only the image. We do it already for other distros. I don\u0027t feel as strongly about this one, the merge block was really about the custom_local_settings issue.","commit_id":"7d441e5d3611205e71feb3e1a26c8607c0939274"},{"author":{"_account_id":27339,"name":"Michal Arbet","email":"michal.arbet@ultimum.io","username":"michalarbet"},"change_message_id":"b6d299c3a7fdd903db8dd820df5b0942d51a87e1","unresolved":false,"context_lines":[{"line_number":473,"context_line":"# target installation."},{"line_number":474,"context_line":""},{"line_number":475,"context_line":"# Path to directory containing policy.json files"},{"line_number":476,"context_line":"{% if horizon_install_type \u003d\u003d \u0027binary\u0027 and kolla_base_distro \u003d\u003d \u0027debian\u0027 %}"},{"line_number":477,"context_line":"POLICY_FILES_PATH \u003d \u0027/etc/openstack-dashboard/policy\u0027"},{"line_number":478,"context_line":"{% else %}"},{"line_number":479,"context_line":"POLICY_FILES_PATH \u003d \u0027/etc/openstack-dashboard\u0027"},{"line_number":480,"context_line":"{% endif %}"},{"line_number":481,"context_line":""},{"line_number":482,"context_line":"# Map of local copy of service policy files."},{"line_number":483,"context_line":"# Please insure that your identity policy file matches the one being used on"}],"source_content_type":"text/x-jinja2","patch_set":2,"id":"3fa7e38b_1f72cd7d","line":480,"range":{"start_line":476,"start_character":0,"end_line":480,"end_character":11},"in_reply_to":"3fa7e38b_599dc508","updated":"2019-10-02 11:11:12.000000000","message":"Mark, don\u0027t agree, why this should be fixed in image ? Do you want to say that debian package should be reworked (again) only because kolla ? That makes no sense. As debian developer I reworked horizon in debian to be more nice, intuitive and more functional as it has been (now definitively better as in ubuntu). There were a lot  of changes and change paths was the part of this big change. Now in debian package you can find local_settings.py , local_settings.d , policy, enabled in /etc which is super nice.   If you compare ubuntu package and debian package , you will see the difference and i think you will like it. Do you have some strong arguments to not merge this change ?","commit_id":"7d441e5d3611205e71feb3e1a26c8607c0939274"},{"author":{"_account_id":27339,"name":"Michal Arbet","email":"michal.arbet@ultimum.io","username":"michalarbet"},"change_message_id":"158158ec714f34153c2b5cf91468913ac17cdffc","unresolved":false,"context_lines":[{"line_number":473,"context_line":"# target installation."},{"line_number":474,"context_line":""},{"line_number":475,"context_line":"# Path to directory containing policy.json files"},{"line_number":476,"context_line":"{% if horizon_install_type \u003d\u003d \u0027binary\u0027 and kolla_base_distro \u003d\u003d \u0027debian\u0027 %}"},{"line_number":477,"context_line":"POLICY_FILES_PATH \u003d \u0027/etc/openstack-dashboard/policy\u0027"},{"line_number":478,"context_line":"{% else %}"},{"line_number":479,"context_line":"POLICY_FILES_PATH \u003d \u0027/etc/openstack-dashboard\u0027"},{"line_number":480,"context_line":"{% endif %}"},{"line_number":481,"context_line":""},{"line_number":482,"context_line":"# Map of local copy of service policy files."},{"line_number":483,"context_line":"# Please insure that your identity policy file matches the one being used on"}],"source_content_type":"text/x-jinja2","patch_set":2,"id":"3fa7e38b_1f75edcc","line":480,"range":{"start_line":476,"start_character":0,"end_line":480,"end_character":11},"in_reply_to":"3fa7e38b_5fa9258e","updated":"2019-10-02 11:39:14.000000000","message":"I\u0027ve checked it and in debian package it is like below : \n\nroot@openstack-controller:/home/debian# ls -la /usr/lib/python3/dist-packages/openstack_dashboard/ | grep conf\nlrwxrwxrwx   1 root root    31 Oct  2 10:53 conf -\u003e /etc/openstack-dashboard/policy\n\nSo, i think POLICY_FILES_PATH can be dropped because it is a symlink\n\nViktor, could you please drop it from kolla-ansible and test it ? Let us know","commit_id":"7d441e5d3611205e71feb3e1a26c8607c0939274"},{"author":{"_account_id":27339,"name":"Michal Arbet","email":"michal.arbet@ultimum.io","username":"michalarbet"},"change_message_id":"d733ab1de460861ecaa9ad6b07a8698ea85c0355","unresolved":false,"context_lines":[{"line_number":473,"context_line":"# target installation."},{"line_number":474,"context_line":""},{"line_number":475,"context_line":"# Path to directory containing policy.json files"},{"line_number":476,"context_line":"{% if horizon_install_type \u003d\u003d \u0027binary\u0027 and kolla_base_distro \u003d\u003d \u0027debian\u0027 %}"},{"line_number":477,"context_line":"POLICY_FILES_PATH \u003d \u0027/etc/openstack-dashboard/policy\u0027"},{"line_number":478,"context_line":"{% else %}"},{"line_number":479,"context_line":"POLICY_FILES_PATH \u003d \u0027/etc/openstack-dashboard\u0027"},{"line_number":480,"context_line":"{% endif %}"},{"line_number":481,"context_line":""},{"line_number":482,"context_line":"# Map of local copy of service policy files."},{"line_number":483,"context_line":"# Please insure that your identity policy file matches the one being used on"}],"source_content_type":"text/x-jinja2","patch_set":2,"id":"3fa7e38b_7f03c174","line":480,"range":{"start_line":476,"start_character":0,"end_line":480,"end_character":11},"in_reply_to":"3fa7e38b_5fa9258e","updated":"2019-10-02 11:20:54.000000000","message":"going to check","commit_id":"7d441e5d3611205e71feb3e1a26c8607c0939274"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"8597c0225e089f4bcfff0e54a9d9b026a70e2931","unresolved":false,"context_lines":[{"line_number":851,"context_line":"{% endif %}"},{"line_number":852,"context_line":""},{"line_number":853,"context_line":"# Allow operators to overwrite variables (LP: #1769970)."},{"line_number":854,"context_line":"try:"},{"line_number":855,"context_line":"    from .custom_local_settings import *"},{"line_number":856,"context_line":"except:"},{"line_number":857,"context_line":"    pass"}],"source_content_type":"text/x-jinja2","patch_set":2,"id":"3fa7e38b_398489b1","line":857,"range":{"start_line":854,"start_character":0,"end_line":857,"end_character":8},"updated":"2019-10-02 09:22:41.000000000","message":"This should not be required. If you can\u0027t import custom_local_settings, it means it\u0027s broken.","commit_id":"7d441e5d3611205e71feb3e1a26c8607c0939274"}]}