)]}'
{"ansible/roles/prometheus/tasks/config.yml":[{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"460fa74826ca23eafbb12481084e8ae0d7ce4a8a","unresolved":false,"context_lines":[{"line_number":56,"context_line":"  notify:"},{"line_number":57,"context_line":"    - Restart prometheus-server container"},{"line_number":58,"context_line":""},{"line_number":59,"context_line":"- name: Determine most specific config file"},{"line_number":60,"context_line":"  set_fact:"},{"line_number":61,"context_line":"    prometheus_config_file: \"{{ item }}\""},{"line_number":62,"context_line":"  become: true"}],"source_content_type":"text/x-yaml","patch_set":9,"id":"1f493fa4_1e4645c1","line":59,"updated":"2020-04-28 10:38:58.000000000","message":"Is this task required? L90 uses with_first found.","commit_id":"faecb71287110459abee09d53a4634245fca734f"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"460fa74826ca23eafbb12481084e8ae0d7ce4a8a","unresolved":false,"context_lines":[{"line_number":59,"context_line":"- name: Determine most specific config file"},{"line_number":60,"context_line":"  set_fact:"},{"line_number":61,"context_line":"    prometheus_config_file: \"{{ item }}\""},{"line_number":62,"context_line":"  become: true"},{"line_number":63,"context_line":"  run_once: true"},{"line_number":64,"context_line":"  with_first_found:"},{"line_number":65,"context_line":"    - \"{{ node_custom_config }}/prometheus/{{ inventory_hostname }}/prometheus.yml\""}],"source_content_type":"text/x-yaml","patch_set":9,"id":"1f493fa4_3e31815b","line":62,"range":{"start_line":62,"start_character":2,"end_line":62,"end_character":14},"updated":"2020-04-28 10:38:58.000000000","message":"should not be required","commit_id":"faecb71287110459abee09d53a4634245fca734f"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"460fa74826ca23eafbb12481084e8ae0d7ce4a8a","unresolved":false,"context_lines":[{"line_number":69,"context_line":"- name: Determine most specific overrides"},{"line_number":70,"context_line":"  set_fact:"},{"line_number":71,"context_line":"    prometheus_config_overrides_parent: \"{{ item }}\""},{"line_number":72,"context_line":"  become: true"},{"line_number":73,"context_line":"  run_once: true"},{"line_number":74,"context_line":"  with_first_found:"},{"line_number":75,"context_line":"    - files:"}],"source_content_type":"text/x-yaml","patch_set":9,"id":"1f493fa4_9e32555d","line":72,"updated":"2020-04-28 10:38:58.000000000","message":"should not be required","commit_id":"faecb71287110459abee09d53a4634245fca734f"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"460fa74826ca23eafbb12481084e8ae0d7ce4a8a","unresolved":false,"context_lines":[{"line_number":74,"context_line":"  with_first_found:"},{"line_number":75,"context_line":"    - files:"},{"line_number":76,"context_line":"        - \"{{ node_custom_config }}/prometheus/{{ inventory_hostname }}/prometheus.yml.d\""},{"line_number":77,"context_line":"        - \"{{ node_custom_config }}/prometheus/prometheus.yml.d\""},{"line_number":78,"context_line":"      skip: true"},{"line_number":79,"context_line":""},{"line_number":80,"context_line":"- name: Find prometheus config overrides"}],"source_content_type":"text/x-yaml","patch_set":9,"id":"1f493fa4_7e1029a9","line":77,"updated":"2020-04-28 10:38:58.000000000","message":"What should the behaviour be here if I put a file in each directory? I might expect to use both.","commit_id":"faecb71287110459abee09d53a4634245fca734f"},{"author":{"_account_id":28048,"name":"Will Szumski","email":"will@stackhpc.com","username":"jovial"},"change_message_id":"a6b6e799ebf7bb24aa8b8c4789c79681624d69a8","unresolved":false,"context_lines":[{"line_number":74,"context_line":"  with_first_found:"},{"line_number":75,"context_line":"    - files:"},{"line_number":76,"context_line":"        - \"{{ node_custom_config }}/prometheus/{{ inventory_hostname }}/prometheus.yml.d\""},{"line_number":77,"context_line":"        - \"{{ node_custom_config }}/prometheus/prometheus.yml.d\""},{"line_number":78,"context_line":"      skip: true"},{"line_number":79,"context_line":""},{"line_number":80,"context_line":"- name: Find prometheus config overrides"}],"source_content_type":"text/x-yaml","patch_set":9,"id":"1f493fa4_449dedb9","line":77,"in_reply_to":"1f493fa4_36f7aa5b","updated":"2020-05-07 10:24:25.000000000","message":"I\u0027ve gone with your suggestion - thanks.","commit_id":"faecb71287110459abee09d53a4634245fca734f"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"78fc8380a257fcb4514ede8e22986cd14c17d14c","unresolved":false,"context_lines":[{"line_number":74,"context_line":"  with_first_found:"},{"line_number":75,"context_line":"    - files:"},{"line_number":76,"context_line":"        - \"{{ node_custom_config }}/prometheus/{{ inventory_hostname }}/prometheus.yml.d\""},{"line_number":77,"context_line":"        - \"{{ node_custom_config }}/prometheus/prometheus.yml.d\""},{"line_number":78,"context_line":"      skip: true"},{"line_number":79,"context_line":""},{"line_number":80,"context_line":"- name: Find prometheus config overrides"}],"source_content_type":"text/x-yaml","patch_set":9,"id":"1f493fa4_36f7aa5b","line":77,"in_reply_to":"1f493fa4_6fcdf483","updated":"2020-04-30 14:50:56.000000000","message":"Any time you want an \u0027override\u0027 behaviour for a particular list item it would need to be in a per-host file only. But you could have one item in a global file, and another that varies per-host.\n\nThere are probably gotchas with either approach.","commit_id":"faecb71287110459abee09d53a4634245fca734f"},{"author":{"_account_id":28048,"name":"Will Szumski","email":"will@stackhpc.com","username":"jovial"},"change_message_id":"8dbf10c1a151bd1d04047c386430197ffdf23244","unresolved":false,"context_lines":[{"line_number":74,"context_line":"  with_first_found:"},{"line_number":75,"context_line":"    - files:"},{"line_number":76,"context_line":"        - \"{{ node_custom_config }}/prometheus/{{ inventory_hostname }}/prometheus.yml.d\""},{"line_number":77,"context_line":"        - \"{{ node_custom_config }}/prometheus/prometheus.yml.d\""},{"line_number":78,"context_line":"      skip: true"},{"line_number":79,"context_line":""},{"line_number":80,"context_line":"- name: Find prometheus config overrides"}],"source_content_type":"text/x-yaml","patch_set":9,"id":"1f493fa4_6fcdf483","line":77,"in_reply_to":"1f493fa4_7e1029a9","updated":"2020-04-29 14:32:00.000000000","message":"Hard to support that with the current implementation of extend lists as you may want to completely override the scrape targets on one particular host. One workaround to prevent duplication would be to symlink files from the less specific directory into the more specific one. \n\nAnother option would be to use a meta-key to do merging on a case by case basis. Here is what that could look like:\n\n  _kolla_ansible_extend_list: [\"scrape_config\"]\n\n  scape_config:\n    - item1\n\n  nested:\n    _kolla_ansible_extend_list: [\"key1\"]\n    key1:\n      - item1\n    key2:\n      - item1\n\nThe default behaviour would be to replace. The meta-key would be stripped from the final output.\n\nThoughts anyone?","commit_id":"faecb71287110459abee09d53a4634245fca734f"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"460fa74826ca23eafbb12481084e8ae0d7ce4a8a","unresolved":false,"context_lines":[{"line_number":78,"context_line":"      skip: true"},{"line_number":79,"context_line":""},{"line_number":80,"context_line":"- name: Find prometheus config overrides"},{"line_number":81,"context_line":"  become: true"},{"line_number":82,"context_line":"  find:"},{"line_number":83,"context_line":"    paths: \"{{ prometheus_config_overrides_parent }}\""},{"line_number":84,"context_line":"    patterns: \"*.yml\""}],"source_content_type":"text/x-yaml","patch_set":9,"id":"1f493fa4_7e37894e","line":81,"updated":"2020-04-28 10:38:58.000000000","message":"should not be required","commit_id":"faecb71287110459abee09d53a4634245fca734f"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"460fa74826ca23eafbb12481084e8ae0d7ce4a8a","unresolved":false,"context_lines":[{"line_number":80,"context_line":"- name: Find prometheus config overrides"},{"line_number":81,"context_line":"  become: true"},{"line_number":82,"context_line":"  find:"},{"line_number":83,"context_line":"    paths: \"{{ prometheus_config_overrides_parent }}\""},{"line_number":84,"context_line":"    patterns: \"*.yml\""},{"line_number":85,"context_line":"  delegate_to: localhost"},{"line_number":86,"context_line":"  register: prometheus_config_overrides_result"}],"source_content_type":"text/x-yaml","patch_set":9,"id":"1f493fa4_be25910b","line":83,"updated":"2020-04-28 10:38:58.000000000","message":"Could use both paths in a list here? Not sure what find does if paths don\u0027t exist.","commit_id":"faecb71287110459abee09d53a4634245fca734f"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"460fa74826ca23eafbb12481084e8ae0d7ce4a8a","unresolved":false,"context_lines":[{"line_number":93,"context_line":"    service: \"{{ prometheus_services[\u0027prometheus-server\u0027] }}\""},{"line_number":94,"context_line":"    overrides: \"{{ prometheus_config_overrides_result.files | default([]) | map(attribute\u003d\u0027path\u0027) | list }}\""},{"line_number":95,"context_line":"  merge_yaml:"},{"line_number":96,"context_line":"    sources: \"{{ [prometheus_config_file] + overrides }}\""},{"line_number":97,"context_line":"    dest: \"{{ node_config_directory }}/prometheus-server/prometheus.yml\""},{"line_number":98,"context_line":"    mode: \"0660\""},{"line_number":99,"context_line":"    extend: true"}],"source_content_type":"text/x-yaml","patch_set":9,"id":"1f493fa4_fe4279aa","line":96,"range":{"start_line":96,"start_character":18,"end_line":96,"end_character":40},"updated":"2020-04-28 10:38:58.000000000","message":"item?","commit_id":"faecb71287110459abee09d53a4634245fca734f"}]}