)]}'
{"ansible/group_vars/all.yml":[{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"5b6e47e67a0db2ed25a92b3ed462d0bf41dcd9b0","unresolved":false,"context_lines":[{"line_number":98,"context_line":"docker_runtime_directory: \"\""},{"line_number":99,"context_line":""},{"line_number":100,"context_line":"# Docker networking options"},{"line_number":101,"context_line":"docker_disable_bridge: \"no\""},{"line_number":102,"context_line":""},{"line_number":103,"context_line":"# Retention settings for Docker logs"},{"line_number":104,"context_line":"docker_log_max_file: \"5\""}],"source_content_type":"text/x-yaml","patch_set":2,"id":"3fa7e38b_cf9d4358","line":101,"range":{"start_line":101,"start_character":0,"end_line":101,"end_character":21},"updated":"2019-10-22 06:28:00.000000000","message":"more like \"docker_disable_default_network\" ?","commit_id":"3e3bd2b9e347838df19625f7c816fd4c9ce71039"},{"author":{"_account_id":30523,"name":"Dincer Celik","email":"hello@dincercelik.com","username":"osmanlicilegi"},"change_message_id":"2b504e8543ffb79d73897c3c23f02c70c1ec9fe1","unresolved":false,"context_lines":[{"line_number":98,"context_line":"docker_runtime_directory: \"\""},{"line_number":99,"context_line":""},{"line_number":100,"context_line":"# Docker networking options"},{"line_number":101,"context_line":"docker_disable_bridge: \"no\""},{"line_number":102,"context_line":""},{"line_number":103,"context_line":"# Retention settings for Docker logs"},{"line_number":104,"context_line":"docker_log_max_file: \"5\""}],"source_content_type":"text/x-yaml","patch_set":2,"id":"3fa7e38b_e1da9349","line":101,"range":{"start_line":101,"start_character":0,"end_line":101,"end_character":21},"in_reply_to":"3fa7e38b_cf9d4358","updated":"2019-10-22 16:02:24.000000000","message":"Done","commit_id":"3e3bd2b9e347838df19625f7c816fd4c9ce71039"},{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"1724ae5f52bb66e2d735b5fa3b7df2865d3740de","unresolved":false,"context_lines":[{"line_number":98,"context_line":"docker_runtime_directory: \"\""},{"line_number":99,"context_line":""},{"line_number":100,"context_line":"# Docker networking options"},{"line_number":101,"context_line":"docker_disable_default_network: \"no\""},{"line_number":102,"context_line":""},{"line_number":103,"context_line":"# Retention settings for Docker logs"},{"line_number":104,"context_line":"docker_log_max_file: \"5\""}],"source_content_type":"text/x-yaml","patch_set":4,"id":"3fa7e38b_c108b72e","line":101,"range":{"start_line":101,"start_character":33,"end_line":101,"end_character":35},"updated":"2019-10-22 08:13:19.000000000","message":"may we set it to \"yes\" for testing?","commit_id":"187a656c6c91b7f5554c1818923e145a68412bc4"},{"author":{"_account_id":30523,"name":"Dincer Celik","email":"hello@dincercelik.com","username":"osmanlicilegi"},"change_message_id":"2b504e8543ffb79d73897c3c23f02c70c1ec9fe1","unresolved":false,"context_lines":[{"line_number":98,"context_line":"docker_runtime_directory: \"\""},{"line_number":99,"context_line":""},{"line_number":100,"context_line":"# Docker networking options"},{"line_number":101,"context_line":"docker_disable_default_network: \"no\""},{"line_number":102,"context_line":""},{"line_number":103,"context_line":"# Retention settings for Docker logs"},{"line_number":104,"context_line":"docker_log_max_file: \"5\""}],"source_content_type":"text/x-yaml","patch_set":4,"id":"3fa7e38b_84a72da8","line":101,"range":{"start_line":101,"start_character":33,"end_line":101,"end_character":35},"in_reply_to":"3fa7e38b_c108b72e","updated":"2019-10-22 16:02:24.000000000","message":"Done","commit_id":"187a656c6c91b7f5554c1818923e145a68412bc4"},{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"e06c890190d8c841bfc21095fb86b689037c0a6c","unresolved":false,"context_lines":[{"line_number":98,"context_line":""},{"line_number":99,"context_line":"# Docker networking options"},{"line_number":100,"context_line":"docker_disable_default_iptables_rules: \"no\""},{"line_number":101,"context_line":"docker_disable_default_network: \"{{ docker_disable_default_iptables_rules }}\""},{"line_number":102,"context_line":""},{"line_number":103,"context_line":"# Retention settings for Docker logs"},{"line_number":104,"context_line":"docker_log_max_file: \"5\""}],"source_content_type":"text/x-yaml","patch_set":16,"id":"9f560f44_eaad2a33","line":101,"range":{"start_line":101,"start_character":36,"end_line":101,"end_character":73},"updated":"2020-09-14 16:43:37.000000000","message":"does not feel wrong but not good either","commit_id":"e45c5afc10a6af0381fa446c76d96ff19bc2bfef"}],"ansible/roles/baremetal/tasks/post-install.yml":[{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"ea9a248065adabc69b70a1380628fb75ca26b2ba","unresolved":true,"context_lines":[{"line_number":107,"context_line":"  debug:"},{"line_number":108,"context_line":"    msg: \u003e-"},{"line_number":109,"context_line":"      Docker default network on docker0 will be disabled by default from the"},{"line_number":110,"context_line":"      Victoria 11.0.0 release. If you have any non-Kolla containers that need"},{"line_number":111,"context_line":"      this functionality, you should plan a migration for this change, or set"},{"line_number":112,"context_line":"      docker_disable_default_network to false."},{"line_number":113,"context_line":"  when: not docker_disable_default_network | bool"}],"source_content_type":"text/x-yaml","patch_set":17,"id":"ee7490ad_4f34e4e3","line":110,"range":{"start_line":110,"start_character":6,"end_line":110,"end_character":14},"updated":"2021-03-11 17:57:59.000000000","message":"Wallaby","commit_id":"65494702a958c0ce47da4a5337c3711ad513a3fc"},{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"6fa0c5b270dee163b04ff911a95bc049dbcea3fd","unresolved":true,"context_lines":[{"line_number":93,"context_line":"- name: Warn about docker default iptables"},{"line_number":94,"context_line":"  debug:"},{"line_number":95,"context_line":"    msg: \u003e-"},{"line_number":96,"context_line":"      Docker default iptables rules will be disabled by default from the Wallaby 12.0.0"},{"line_number":97,"context_line":"      release. If you have any non-Kolla containers that need this functionality, you should"},{"line_number":98,"context_line":"      plan a migration for this change, or set docker_disable_default_iptables_rules to false."},{"line_number":99,"context_line":"  when: not docker_disable_default_iptables_rules | bool"}],"source_content_type":"text/x-yaml","patch_set":18,"id":"423c0c26_9ef8dc10","line":96,"range":{"start_line":96,"start_character":73,"end_line":96,"end_character":87},"updated":"2021-03-17 15:22:47.000000000","message":"need to backport this I guess, heh","commit_id":"4053a0afdb3d0a230557883453b89b06cf4d7057"}],"ansible/roles/baremetal/templates/docker_systemd_service.j2":[{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"5b6e47e67a0db2ed25a92b3ed462d0bf41dcd9b0","unresolved":false,"context_lines":[{"line_number":1,"context_line":"[Service]"},{"line_number":2,"context_line":"ExecStart\u003d"},{"line_number":3,"context_line":"# ExecStart commandline copied from \u0027docker-ce\u0027 package. Same on CentOS/Debian/Ubuntu systems."},{"line_number":4,"context_line":"ExecStart\u003d/usr/bin/dockerd -H fd:// --containerd\u003d/run/containerd/containerd.sock{% if docker_disable_bridge %} --bridge\u003dnone{% endif %}{% if docker_custom_option %} {{ docker_custom_option }}{% endif %}{% if docker_configure_for_zun|bool %} {{ docker_zun_options }}{% endif %}"}],"source_content_type":"text/x-jinja2","patch_set":2,"id":"3fa7e38b_8f998b7a","line":4,"updated":"2019-10-22 06:28:00.000000000","message":"can\u0027t this be done via json?","commit_id":"3e3bd2b9e347838df19625f7c816fd4c9ce71039"},{"author":{"_account_id":30523,"name":"Dincer Celik","email":"hello@dincercelik.com","username":"osmanlicilegi"},"change_message_id":"2b504e8543ffb79d73897c3c23f02c70c1ec9fe1","unresolved":false,"context_lines":[{"line_number":1,"context_line":"[Service]"},{"line_number":2,"context_line":"ExecStart\u003d"},{"line_number":3,"context_line":"# ExecStart commandline copied from \u0027docker-ce\u0027 package. Same on CentOS/Debian/Ubuntu systems."},{"line_number":4,"context_line":"ExecStart\u003d/usr/bin/dockerd -H fd:// --containerd\u003d/run/containerd/containerd.sock{% if docker_disable_bridge %} --bridge\u003dnone{% endif %}{% if docker_custom_option %} {{ docker_custom_option }}{% endif %}{% if docker_configure_for_zun|bool %} {{ docker_zun_options }}{% endif %}"}],"source_content_type":"text/x-jinja2","patch_set":2,"id":"3fa7e38b_e18053c2","line":4,"in_reply_to":"3fa7e38b_8f998b7a","updated":"2019-10-22 16:02:24.000000000","message":"Done","commit_id":"3e3bd2b9e347838df19625f7c816fd4c9ce71039"}],"releasenotes/notes/docker-disable-bridge-14df8b7fddbd5000.yaml":[{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"5b6e47e67a0db2ed25a92b3ed462d0bf41dcd9b0","unresolved":false,"context_lines":[{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Adds a new flag, ``docker_disable_bridge``, which defaults to ``no``."},{"line_number":5,"context_line":"  - |"},{"line_number":6,"context_line":"    Docker is using 172.17.0.0/16 by default for bridge networking on docker0,"},{"line_number":7,"context_line":"    and this might cause problems for tenant networks. Setting this flag to yes"},{"line_number":8,"context_line":"    will disable Docker bridge networking."}],"source_content_type":"text/x-yaml","patch_set":2,"id":"3fa7e38b_2f889720","line":5,"updated":"2019-10-22 06:28:00.000000000","message":"these should not be 3 separate notes","commit_id":"3e3bd2b9e347838df19625f7c816fd4c9ce71039"},{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"5b6e47e67a0db2ed25a92b3ed462d0bf41dcd9b0","unresolved":false,"context_lines":[{"line_number":4,"context_line":"    Adds a new flag, ``docker_disable_bridge``, which defaults to ``no``."},{"line_number":5,"context_line":"  - |"},{"line_number":6,"context_line":"    Docker is using 172.17.0.0/16 by default for bridge networking on docker0,"},{"line_number":7,"context_line":"    and this might cause problems for tenant networks. Setting this flag to yes"},{"line_number":8,"context_line":"    will disable Docker bridge networking."},{"line_number":9,"context_line":"  - |"},{"line_number":10,"context_line":"    When this flag is set to ``yes``, kolla image builds should be run with"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"3fa7e38b_2f8df729","line":7,"range":{"start_line":7,"start_character":38,"end_line":7,"end_character":44},"updated":"2019-10-22 06:28:00.000000000","message":"more likely operator networks, tenant networks usually end up in separate namespaces","commit_id":"3e3bd2b9e347838df19625f7c816fd4c9ce71039"},{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"1724ae5f52bb66e2d735b5fa3b7df2865d3740de","unresolved":false,"context_lines":[{"line_number":4,"context_line":"    Adds a new flag, ``docker_disable_default_network``, which defaults to"},{"line_number":5,"context_line":"    ``no``. Docker is using 172.17.0.0/16 by default for bridge networking on"},{"line_number":6,"context_line":"    docker0, and this might cause routing problems for operator networks."},{"line_number":7,"context_line":"    Setting this flag to yes will disable docker bridge networking. When this"},{"line_number":8,"context_line":"    flag is set to ``yes``, kolla image builds should be run with"},{"line_number":9,"context_line":"    ``--network_mode host``."}],"source_content_type":"text/x-yaml","patch_set":4,"id":"3fa7e38b_a10b3b29","line":9,"range":{"start_line":7,"start_character":68,"end_line":9,"end_character":28},"updated":"2019-10-22 08:13:19.000000000","message":"I think this is irrelevant to k-a though.","commit_id":"187a656c6c91b7f5554c1818923e145a68412bc4"},{"author":{"_account_id":30523,"name":"Dincer Celik","email":"hello@dincercelik.com","username":"osmanlicilegi"},"change_message_id":"2b504e8543ffb79d73897c3c23f02c70c1ec9fe1","unresolved":false,"context_lines":[{"line_number":4,"context_line":"    Adds a new flag, ``docker_disable_default_network``, which defaults to"},{"line_number":5,"context_line":"    ``no``. Docker is using 172.17.0.0/16 by default for bridge networking on"},{"line_number":6,"context_line":"    docker0, and this might cause routing problems for operator networks."},{"line_number":7,"context_line":"    Setting this flag to yes will disable docker bridge networking. When this"},{"line_number":8,"context_line":"    flag is set to ``yes``, kolla image builds should be run with"},{"line_number":9,"context_line":"    ``--network_mode host``."}],"source_content_type":"text/x-yaml","patch_set":4,"id":"3fa7e38b_244bd95f","line":9,"range":{"start_line":7,"start_character":68,"end_line":9,"end_character":28},"in_reply_to":"3fa7e38b_a10b3b29","updated":"2019-10-22 16:02:24.000000000","message":"Done","commit_id":"187a656c6c91b7f5554c1818923e145a68412bc4"},{"author":{"_account_id":24072,"name":"Marcin Juszkiewicz","email":"mjuszkiewicz@redhat.com","username":"hrw"},"change_message_id":"5573e11342e5b4318a4328e9a026b33c572b0982","unresolved":false,"context_lines":[{"line_number":4,"context_line":"    Adds a new flag, ``docker_disable_default_network``, which defaults"},{"line_number":5,"context_line":"    to ``no``. Docker is using 172.17.0.0/16 by default for bridge"},{"line_number":6,"context_line":"    networking on docker0, and this might cause routing problems for"},{"line_number":7,"context_line":"    operator networks. Setting this flag to yes will disable docker"},{"line_number":8,"context_line":"    bridge networking."}],"source_content_type":"text/x-yaml","patch_set":9,"id":"3fa7e38b_84140deb","line":7,"range":{"start_line":7,"start_character":44,"end_line":7,"end_character":47},"updated":"2019-11-29 16:44:04.000000000","message":"``yes``","commit_id":"944aab52b09e010addf4f725e440cf6b858f212b"}]}