)]}'
{"ansible/roles/nova-cell/tasks/loadbalancer.yml":[{"author":{"_account_id":17669,"name":"Doug Szumski","email":"doug@stackhpc.com","username":"DougSzumski"},"change_message_id":"aa83233f758e193243ec2a026ab3fe83d5c38f09","unresolved":false,"context_lines":[{"line_number":21,"context_line":"- import_tasks: proxy_loadbalancer.yml"},{"line_number":22,"context_line":"  vars:"},{"line_number":23,"context_line":"    cell_proxy_groups: \u003e-"},{"line_number":24,"context_line":"      {{ groups[\u0027nova-novncproxy\u0027] | default ({}) |"},{"line_number":25,"context_line":"         map(\u0027extract\u0027, hostvars, \u0027nova_cell_novncproxy_group\u0027) |"},{"line_number":26,"context_line":"         unique |"},{"line_number":27,"context_line":"         list }}"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"3fa7e38b_c7ec2ebd","line":24,"updated":"2019-10-23 13:49:40.000000000","message":"This removes the following warning when the group isn\u0027t defined, eg:\n\n`[WARNING]: Falling back to Ansible unique filter as Jinja2 one failed: \u0027dict object\u0027 has no attribute \u0027nova-novncproxy\u0027`","commit_id":"870550a8009064ded7ec58396a27ba5db7b30f6e"},{"author":{"_account_id":17669,"name":"Doug Szumski","email":"doug@stackhpc.com","username":"DougSzumski"},"change_message_id":"22d255a733eaaae800f72b70875192b9b250afa3","unresolved":false,"context_lines":[{"line_number":21,"context_line":"- import_tasks: proxy_loadbalancer.yml"},{"line_number":22,"context_line":"  vars:"},{"line_number":23,"context_line":"    cell_proxy_groups: \u003e-"},{"line_number":24,"context_line":"      {{ groups[\u0027nova-novncproxy\u0027] | default ({}) |"},{"line_number":25,"context_line":"         map(\u0027extract\u0027, hostvars, \u0027nova_cell_novncproxy_group\u0027) |"},{"line_number":26,"context_line":"         unique |"},{"line_number":27,"context_line":"         list }}"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"3fa7e38b_72297687","line":24,"in_reply_to":"3fa7e38b_07ab261e","updated":"2019-10-23 14:12:17.000000000","message":"Argh, yes, good spot. I meant to change that, and then got distracted and forgot.","commit_id":"870550a8009064ded7ec58396a27ba5db7b30f6e"},{"author":{"_account_id":17669,"name":"Doug Szumski","email":"doug@stackhpc.com","username":"DougSzumski"},"change_message_id":"64659a8a2b2d0a2c64cccd8a60657eabc9f23f73","unresolved":false,"context_lines":[{"line_number":21,"context_line":"- import_tasks: proxy_loadbalancer.yml"},{"line_number":22,"context_line":"  vars:"},{"line_number":23,"context_line":"    cell_proxy_groups: \u003e-"},{"line_number":24,"context_line":"      {{ groups[\u0027nova-novncproxy\u0027] | default ({}) |"},{"line_number":25,"context_line":"         map(\u0027extract\u0027, hostvars, \u0027nova_cell_novncproxy_group\u0027) |"},{"line_number":26,"context_line":"         unique |"},{"line_number":27,"context_line":"         list }}"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"3fa7e38b_938f5474","line":24,"in_reply_to":"3fa7e38b_5877bb09","updated":"2019-10-23 16:24:56.000000000","message":"Even if `nova_novncproxy.enabled` is false?","commit_id":"870550a8009064ded7ec58396a27ba5db7b30f6e"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"21ca7adea1df1cd55c4daa4ea18f5d4f0aa1e949","unresolved":false,"context_lines":[{"line_number":21,"context_line":"- import_tasks: proxy_loadbalancer.yml"},{"line_number":22,"context_line":"  vars:"},{"line_number":23,"context_line":"    cell_proxy_groups: \u003e-"},{"line_number":24,"context_line":"      {{ groups[\u0027nova-novncproxy\u0027] | default ({}) |"},{"line_number":25,"context_line":"         map(\u0027extract\u0027, hostvars, \u0027nova_cell_novncproxy_group\u0027) |"},{"line_number":26,"context_line":"         unique |"},{"line_number":27,"context_line":"         list }}"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"3fa7e38b_5877bb09","line":24,"in_reply_to":"3fa7e38b_72297687","updated":"2019-10-23 16:07:41.000000000","message":"That group should always be defined.","commit_id":"870550a8009064ded7ec58396a27ba5db7b30f6e"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"b63c9a653046a8b0060e44cfa15b34dd9a541705","unresolved":false,"context_lines":[{"line_number":21,"context_line":"- import_tasks: proxy_loadbalancer.yml"},{"line_number":22,"context_line":"  vars:"},{"line_number":23,"context_line":"    cell_proxy_groups: \u003e-"},{"line_number":24,"context_line":"      {{ groups[\u0027nova-novncproxy\u0027] | default ({}) |"},{"line_number":25,"context_line":"         map(\u0027extract\u0027, hostvars, \u0027nova_cell_novncproxy_group\u0027) |"},{"line_number":26,"context_line":"         unique |"},{"line_number":27,"context_line":"         list }}"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"3fa7e38b_9300b4ad","line":24,"in_reply_to":"3fa7e38b_938f5474","updated":"2019-10-23 16:39:11.000000000","message":"Yes, we generally assume all groups are present in the inventory.","commit_id":"870550a8009064ded7ec58396a27ba5db7b30f6e"},{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"97d62f447d459d6e33759b0b251ada0e3d0a6761","unresolved":false,"context_lines":[{"line_number":21,"context_line":"- import_tasks: proxy_loadbalancer.yml"},{"line_number":22,"context_line":"  vars:"},{"line_number":23,"context_line":"    cell_proxy_groups: \u003e-"},{"line_number":24,"context_line":"      {{ groups[\u0027nova-novncproxy\u0027] | default ({}) |"},{"line_number":25,"context_line":"         map(\u0027extract\u0027, hostvars, \u0027nova_cell_novncproxy_group\u0027) |"},{"line_number":26,"context_line":"         unique |"},{"line_number":27,"context_line":"         list }}"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"3fa7e38b_07ab261e","line":24,"in_reply_to":"3fa7e38b_c7ec2ebd","updated":"2019-10-23 14:01:29.000000000","message":"Should not it be a list instead of a dict?","commit_id":"870550a8009064ded7ec58396a27ba5db7b30f6e"}],"tests/templates/inventory.j2":[{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"14c6affeaa57787d351e17599ecbf4c9324c89dd","unresolved":false,"context_lines":[{"line_number":292,"context_line":"# Deploy novncproxy in each cell"},{"line_number":293,"context_line":"{% for host in hostvars %}"},{"line_number":294,"context_line":"{% set cell_name \u003d \u0027cell\u0027 ~ loop.index %}"},{"line_number":295,"context_line":"{{ cell_name }}"},{"line_number":296,"context_line":"{% endfor %}"},{"line_number":297,"context_line":"{% else %}"},{"line_number":298,"context_line":"nova"}],"source_content_type":"text/x-jinja2","patch_set":4,"id":"3fa7e38b_f8d307d2","line":295,"updated":"2019-10-23 16:10:15.000000000","message":"Shouldn\u0027t be necessary, since all hosts are in the nova group.","commit_id":"1cebd8f24efbe165341ee63acedd1cfe40abec5b"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"14c6affeaa57787d351e17599ecbf4c9324c89dd","unresolved":false,"context_lines":[{"line_number":301,"context_line":"[nova-scheduler:children]"},{"line_number":302,"context_line":"nova"},{"line_number":303,"context_line":""},{"line_number":304,"context_line":"# In the cells test we choose to deploy the novncproxy and not this"},{"line_number":305,"context_line":"{% if scenario !\u003d \u0027cells\u0027 %}"},{"line_number":306,"context_line":"[nova-spicehtml5proxy:children]"},{"line_number":307,"context_line":"nova"},{"line_number":308,"context_line":"{% endif %}"}],"source_content_type":"text/x-jinja2","patch_set":4,"id":"3fa7e38b_58c57b09","line":305,"range":{"start_line":304,"start_character":0,"end_line":305,"end_character":28},"updated":"2019-10-23 16:10:15.000000000","message":"Shouldn\u0027t be necessary","commit_id":"1cebd8f24efbe165341ee63acedd1cfe40abec5b"},{"author":{"_account_id":17669,"name":"Doug Szumski","email":"doug@stackhpc.com","username":"DougSzumski"},"change_message_id":"f8ec6dd7caa8f04f9b44884bdc3b43af469b7115","unresolved":false,"context_lines":[{"line_number":301,"context_line":"[nova-scheduler:children]"},{"line_number":302,"context_line":"nova"},{"line_number":303,"context_line":""},{"line_number":304,"context_line":"# In the cells test we choose to deploy the novncproxy and not this"},{"line_number":305,"context_line":"{% if scenario !\u003d \u0027cells\u0027 %}"},{"line_number":306,"context_line":"[nova-spicehtml5proxy:children]"},{"line_number":307,"context_line":"nova"},{"line_number":308,"context_line":"{% endif %}"}],"source_content_type":"text/x-jinja2","patch_set":4,"id":"3fa7e38b_98053317","line":305,"range":{"start_line":304,"start_character":0,"end_line":305,"end_character":28},"in_reply_to":"3fa7e38b_58c57b09","updated":"2019-10-23 16:18:52.000000000","message":"The problem I saw is that this will return a host for the novncproxy group and then it will fail with:\n\n`The conditional check \u0027groups[cell_proxy_group] | length \u003e 0\u0027 failed. The error was: error while evaluating conditional (groups[cell_proxy_group] | length \u003e 0): \u0027dict object\u0027 has no attribute u\u0027cell3-control\u0027`\n\nSince we aren\u0027t using the default group names.","commit_id":"1cebd8f24efbe165341ee63acedd1cfe40abec5b"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"b63c9a653046a8b0060e44cfa15b34dd9a541705","unresolved":false,"context_lines":[{"line_number":301,"context_line":"[nova-scheduler:children]"},{"line_number":302,"context_line":"nova"},{"line_number":303,"context_line":""},{"line_number":304,"context_line":"# In the cells test we choose to deploy the novncproxy and not this"},{"line_number":305,"context_line":"{% if scenario !\u003d \u0027cells\u0027 %}"},{"line_number":306,"context_line":"[nova-spicehtml5proxy:children]"},{"line_number":307,"context_line":"nova"},{"line_number":308,"context_line":"{% endif %}"}],"source_content_type":"text/x-jinja2","patch_set":4,"id":"3fa7e38b_b3e930e4","line":305,"range":{"start_line":304,"start_character":0,"end_line":305,"end_character":28},"in_reply_to":"3fa7e38b_98053317","updated":"2019-10-23 16:39:11.000000000","message":"Let\u0027s switch to use the default group names in CI.\n\nI suppose there could be a case when a console type is disabled, and the default group is not present? i.e. you customise novncproxy_group but not spicehtml5proxy_group.\n\nWe might need to fix ansible/roles/nova-cell/tasks/proxy_loadbalancer.yml to check that the cell_proxy_group exists?","commit_id":"1cebd8f24efbe165341ee63acedd1cfe40abec5b"}]}