)]}'
{"ansible/roles/nova/tasks/refresh_scheduler_cell_cache.yml":[{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"113231db08ec6707aeea6a829983f15e2268392f","unresolved":false,"context_lines":[{"line_number":10,"context_line":"  kolla_docker:"},{"line_number":11,"context_line":"    action: \"restart_container\""},{"line_number":12,"context_line":"    common_options: \"{{ docker_common_options }}\""},{"line_number":13,"context_line":"    name: \"{{ service.container_name }}\""},{"line_number":14,"context_line":"  changed_when: False"},{"line_number":15,"context_line":"  when:"},{"line_number":16,"context_line":"    - inventory_hostname in groups[\u0027nova-scheduler\u0027]"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"3fa7e38b_820cbd39","line":13,"range":{"start_line":13,"start_character":14,"end_line":13,"end_character":36},"updated":"2019-10-25 07:46:24.000000000","message":"not gonna happen :-)","commit_id":"1d509622ba46d28b34c9be073cecf2762efeb861"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"913a7c62bad707cdd8bf604fa6a3fabdc92a73b2","unresolved":false,"context_lines":[{"line_number":10,"context_line":"  kolla_docker:"},{"line_number":11,"context_line":"    action: \"restart_container\""},{"line_number":12,"context_line":"    common_options: \"{{ docker_common_options }}\""},{"line_number":13,"context_line":"    name: \"{{ service.container_name }}\""},{"line_number":14,"context_line":"  changed_when: False"},{"line_number":15,"context_line":"  when:"},{"line_number":16,"context_line":"    - inventory_hostname in groups[\u0027nova-scheduler\u0027]"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"3fa7e38b_c2b715f5","line":13,"range":{"start_line":13,"start_character":14,"end_line":13,"end_character":36},"in_reply_to":"3fa7e38b_820cbd39","updated":"2019-10-25 08:18:28.000000000","message":"doh","commit_id":"1d509622ba46d28b34c9be073cecf2762efeb861"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"661d6f852810b16d3930b516fd94c50cdb7d045a","unresolved":false,"context_lines":[{"line_number":7,"context_line":"  # Docker bug (https://github.com/moby/moby/issues/11065), this might cause the"},{"line_number":8,"context_line":"  # container to be stopped if we restart Docker or reboot the server as we"},{"line_number":9,"context_line":"  # use the \u0027unless-stopped\u0027 restart policy by default."},{"line_number":10,"context_line":"  shell: \"kill -SIGHUP `docker inspect -f \u0027{% raw %}{{.State.Pid}}{% endraw %}\u0027 nova_scheduler`\""},{"line_number":11,"context_line":"  when:"},{"line_number":12,"context_line":"    - inventory_hostname in groups[\u0027nova-scheduler\u0027]"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"3fa7e38b_828efd2f","line":10,"updated":"2019-10-25 08:21:41.000000000","message":"I thought about doing it this way, but didn\u0027t because of the other issues surrounding oslo.service and SIGHUP. I don\u0027t know for sure whether they affect nova-scheduler, but thought it might be safest to go for a restart.\n\nIf we\u0027re doing it this way, then this might be more idiomatic:\n\ndocker exec nova_scheduler kill -HUP 1","commit_id":"8cd6745858587338374fcd6cf200cceadc37ebd0"},{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"d6d1bcfcd680d4fd9ff5363d492df2af40ddbde9","unresolved":false,"context_lines":[{"line_number":7,"context_line":"  # Docker bug (https://github.com/moby/moby/issues/11065), this might cause the"},{"line_number":8,"context_line":"  # container to be stopped if we restart Docker or reboot the server as we"},{"line_number":9,"context_line":"  # use the \u0027unless-stopped\u0027 restart policy by default."},{"line_number":10,"context_line":"  shell: \"kill -SIGHUP `docker inspect -f \u0027{% raw %}{{.State.Pid}}{% endraw %}\u0027 nova_scheduler`\""},{"line_number":11,"context_line":"  when:"},{"line_number":12,"context_line":"    - inventory_hostname in groups[\u0027nova-scheduler\u0027]"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"3fa7e38b_bd231aa7","line":10,"in_reply_to":"3fa7e38b_828efd2f","updated":"2019-10-25 09:04:42.000000000","message":"I tried to limit the interaction with Docker to the minimum. PS: Idiomatic would be to just use Docker to do it :D\n\nRegarding restart, so far it worked pretty well, so I would stick to it. If oslo has issues, oslo should fix them. BTW, can you point me to the issues you mention? I think I saw them somewhere but could not find them now.","commit_id":"8cd6745858587338374fcd6cf200cceadc37ebd0"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"845210951579a54970ecfed5e8cd09863fa3405d","unresolved":false,"context_lines":[{"line_number":7,"context_line":"  # Docker bug (https://github.com/moby/moby/issues/11065), this might cause the"},{"line_number":8,"context_line":"  # container to be stopped if we restart Docker or reboot the server as we"},{"line_number":9,"context_line":"  # use the \u0027unless-stopped\u0027 restart policy by default."},{"line_number":10,"context_line":"  shell: \"kill -SIGHUP `docker inspect -f \u0027{% raw %}{{.State.Pid}}{% endraw %}\u0027 nova_scheduler`\""},{"line_number":11,"context_line":"  when:"},{"line_number":12,"context_line":"    - inventory_hostname in groups[\u0027nova-scheduler\u0027]"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"3fa7e38b_dde7f645","line":10,"in_reply_to":"3fa7e38b_bd231aa7","updated":"2019-10-25 09:14:49.000000000","message":"Well yes oslo.service should fix them, but they\u0027ve been around for a long time, with several patches proposed but no solution yet. Perhaps it has changed since I last looked.\n\nMany comments on this in ansible/roles/nova-cell/tasks/reload.yml.","commit_id":"8cd6745858587338374fcd6cf200cceadc37ebd0"}]}