)]}'
{"ansible/group_vars/all.yml":[{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"3a1a570a535b2ae01ad66fc26a31a3931682a62e","unresolved":false,"context_lines":[{"line_number":53,"context_line":"kolla_source_version: \"master\""},{"line_number":54,"context_line":""},{"line_number":55,"context_line":"# Proxy settings for bootstrap-server on baremetal node"},{"line_number":56,"context_line":"http_proxy: \"\""},{"line_number":57,"context_line":"https_proxy: \"\""},{"line_number":58,"context_line":"no_proxy: \"\""},{"line_number":59,"context_line":""},{"line_number":60,"context_line":"proxy_env:"},{"line_number":61,"context_line":"  http_proxy: \"{{ http_proxy }}\""},{"line_number":62,"context_line":"  HTTP_PROXY: \"{{ http_proxy }}\""},{"line_number":63,"context_line":"  https_proxy: \"{{ https_proxy }}\""}],"source_content_type":"text/x-yaml","patch_set":3,"id":"3fa7e38b_b810daf5","line":60,"range":{"start_line":56,"start_character":0,"end_line":60,"end_character":10},"updated":"2020-01-06 09:28:13.000000000","message":"I would prefix all these with \u0027host_\u0027 to keep it better organized (analogically to container_* ones)","commit_id":"732f913a37bc703368f32520fc0ae4b521bf9a9c"},{"author":{"_account_id":26970,"name":"Yang Youseok","email":"ileixe@gmail.com","username":"ileixe"},"change_message_id":"958ce480af105d1fe705ebaf093b805cc85145f1","unresolved":false,"context_lines":[{"line_number":53,"context_line":"kolla_source_version: \"master\""},{"line_number":54,"context_line":""},{"line_number":55,"context_line":"# Proxy settings for bootstrap-server on baremetal node"},{"line_number":56,"context_line":"http_proxy: \"\""},{"line_number":57,"context_line":"https_proxy: \"\""},{"line_number":58,"context_line":"no_proxy: \"\""},{"line_number":59,"context_line":""},{"line_number":60,"context_line":"proxy_env:"},{"line_number":61,"context_line":"  http_proxy: \"{{ http_proxy }}\""},{"line_number":62,"context_line":"  HTTP_PROXY: \"{{ http_proxy }}\""},{"line_number":63,"context_line":"  https_proxy: \"{{ https_proxy }}\""}],"source_content_type":"text/x-yaml","patch_set":3,"id":"3fa7e38b_587526ff","line":60,"range":{"start_line":56,"start_character":0,"end_line":60,"end_character":10},"in_reply_to":"3fa7e38b_b810daf5","updated":"2020-01-06 09:58:19.000000000","message":"Fixed. Thanks","commit_id":"732f913a37bc703368f32520fc0ae4b521bf9a9c"},{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"3a1a570a535b2ae01ad66fc26a31a3931682a62e","unresolved":false,"context_lines":[{"line_number":58,"context_line":"no_proxy: \"\""},{"line_number":59,"context_line":""},{"line_number":60,"context_line":"proxy_env:"},{"line_number":61,"context_line":"  http_proxy: \"{{ http_proxy }}\""},{"line_number":62,"context_line":"  HTTP_PROXY: \"{{ http_proxy }}\""},{"line_number":63,"context_line":"  https_proxy: \"{{ https_proxy }}\""},{"line_number":64,"context_line":"  HTTPS_PROXY: \"{{ https_proxy }}\""},{"line_number":65,"context_line":"  no_proxy: \"{{ no_proxy }}\""},{"line_number":66,"context_line":"  NO_PROXY: \"{{ no_proxy }}\""},{"line_number":67,"context_line":""},{"line_number":68,"context_line":"# Proxy settings for containers such as magnum that need internet access"},{"line_number":69,"context_line":"container_http_proxy: \"\""}],"source_content_type":"text/x-yaml","patch_set":3,"id":"3fa7e38b_3825ca5b","line":66,"range":{"start_line":61,"start_character":0,"end_line":66,"end_character":28},"updated":"2020-01-06 09:28:13.000000000","message":"need \"| default(omit)\" on each entry to avoid overriding environment present via other means, e.g. people already configured their servers to use proxy and k-a defaults suddenly disable it :-)","commit_id":"732f913a37bc703368f32520fc0ae4b521bf9a9c"},{"author":{"_account_id":26970,"name":"Yang Youseok","email":"ileixe@gmail.com","username":"ileixe"},"change_message_id":"958ce480af105d1fe705ebaf093b805cc85145f1","unresolved":false,"context_lines":[{"line_number":58,"context_line":"no_proxy: \"\""},{"line_number":59,"context_line":""},{"line_number":60,"context_line":"proxy_env:"},{"line_number":61,"context_line":"  http_proxy: \"{{ http_proxy }}\""},{"line_number":62,"context_line":"  HTTP_PROXY: \"{{ http_proxy }}\""},{"line_number":63,"context_line":"  https_proxy: \"{{ https_proxy }}\""},{"line_number":64,"context_line":"  HTTPS_PROXY: \"{{ https_proxy }}\""},{"line_number":65,"context_line":"  no_proxy: \"{{ no_proxy }}\""},{"line_number":66,"context_line":"  NO_PROXY: \"{{ no_proxy }}\""},{"line_number":67,"context_line":""},{"line_number":68,"context_line":"# Proxy settings for containers such as magnum that need internet access"},{"line_number":69,"context_line":"container_http_proxy: \"\""}],"source_content_type":"text/x-yaml","patch_set":3,"id":"3fa7e38b_787a62f0","line":66,"range":{"start_line":61,"start_character":0,"end_line":66,"end_character":28},"in_reply_to":"3fa7e38b_18dfae0b","updated":"2020-01-06 09:58:19.000000000","message":"Did not know the filter. Thanks. Fixed.","commit_id":"732f913a37bc703368f32520fc0ae4b521bf9a9c"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"2112e07db251bd8867770abc53d05e04a420044d","unresolved":false,"context_lines":[{"line_number":58,"context_line":"no_proxy: \"\""},{"line_number":59,"context_line":""},{"line_number":60,"context_line":"proxy_env:"},{"line_number":61,"context_line":"  http_proxy: \"{{ http_proxy }}\""},{"line_number":62,"context_line":"  HTTP_PROXY: \"{{ http_proxy }}\""},{"line_number":63,"context_line":"  https_proxy: \"{{ https_proxy }}\""},{"line_number":64,"context_line":"  HTTPS_PROXY: \"{{ https_proxy }}\""},{"line_number":65,"context_line":"  no_proxy: \"{{ no_proxy }}\""},{"line_number":66,"context_line":"  NO_PROXY: \"{{ no_proxy }}\""},{"line_number":67,"context_line":""},{"line_number":68,"context_line":"# Proxy settings for containers such as magnum that need internet access"},{"line_number":69,"context_line":"container_http_proxy: \"\""}],"source_content_type":"text/x-yaml","patch_set":3,"id":"3fa7e38b_18dfae0b","line":66,"range":{"start_line":61,"start_character":0,"end_line":66,"end_character":28},"in_reply_to":"3fa7e38b_3825ca5b","updated":"2020-01-06 09:50:11.000000000","message":"| default(omit, true)","commit_id":"732f913a37bc703368f32520fc0ae4b521bf9a9c"}],"ansible/roles/baremetal/tasks/pre-install.yml":[{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"3a1a570a535b2ae01ad66fc26a31a3931682a62e","unresolved":false,"context_lines":[{"line_number":10,"context_line":"    - http_proxy is defined"},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"- name: Add http_proxy to /etc/apt/apt.conf if http_proxy is not empty"},{"line_number":13,"context_line":"  raw: echo \u0027Acquire::http::proxy \"{{ http_proxy }}\";\u0027 \u003e\u003e /etc/apt/apt.conf"},{"line_number":14,"context_line":"  become: true"},{"line_number":15,"context_line":"  environment: {}"},{"line_number":16,"context_line":"  when:"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"3fa7e38b_f8f172df","line":13,"range":{"start_line":13,"start_character":58,"end_line":13,"end_character":75},"updated":"2020-01-06 09:28:13.000000000","message":"is not there a directory for drop-ins?","commit_id":"732f913a37bc703368f32520fc0ae4b521bf9a9c"},{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"91ca841353a1933008fdf829b5a8a9802d65dcfe","unresolved":false,"context_lines":[{"line_number":10,"context_line":"    - http_proxy is defined"},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"- name: Add http_proxy to /etc/apt/apt.conf if http_proxy is not empty"},{"line_number":13,"context_line":"  raw: echo \u0027Acquire::http::proxy \"{{ http_proxy }}\";\u0027 \u003e\u003e /etc/apt/apt.conf"},{"line_number":14,"context_line":"  become: true"},{"line_number":15,"context_line":"  environment: {}"},{"line_number":16,"context_line":"  when:"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"3fa7e38b_73492364","line":13,"range":{"start_line":13,"start_character":58,"end_line":13,"end_character":75},"in_reply_to":"3fa7e38b_d8683623","updated":"2020-01-06 10:20:39.000000000","message":"something like apt.conf.d ? I believe apt also has directory-based config. This way it\u0027s easier to keep kolla config separate.","commit_id":"732f913a37bc703368f32520fc0ae4b521bf9a9c"},{"author":{"_account_id":26970,"name":"Yang Youseok","email":"ileixe@gmail.com","username":"ileixe"},"change_message_id":"1e19265052a26064fcd4eed2bdf35906528a0941","unresolved":false,"context_lines":[{"line_number":10,"context_line":"    - http_proxy is defined"},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"- name: Add http_proxy to /etc/apt/apt.conf if http_proxy is not empty"},{"line_number":13,"context_line":"  raw: echo \u0027Acquire::http::proxy \"{{ http_proxy }}\";\u0027 \u003e\u003e /etc/apt/apt.conf"},{"line_number":14,"context_line":"  become: true"},{"line_number":15,"context_line":"  environment: {}"},{"line_number":16,"context_line":"  when:"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"3fa7e38b_d8683623","line":13,"range":{"start_line":13,"start_character":58,"end_line":13,"end_character":75},"in_reply_to":"3fa7e38b_f8f172df","updated":"2020-01-06 09:59:02.000000000","message":"Sorry, what do you mean?","commit_id":"732f913a37bc703368f32520fc0ae4b521bf9a9c"},{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"504887a3e9af8d000e3516600c5cb2944d687e47","unresolved":false,"context_lines":[{"line_number":9,"context_line":"  when:"},{"line_number":10,"context_line":"    - host_http_proxy is defined"},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"- name: Add host_http_proxy to /etc/apt/apt.conf.d/proxy.conf if host_http_proxy is not empty"},{"line_number":13,"context_line":"  raw: echo \u0027Acquire::http::proxy \"{{ host_http_proxy }}\";\u0027 \u003e\u003e /etc/apt/apt.conf.d/proxy.conf"},{"line_number":14,"context_line":"  become: true"},{"line_number":15,"context_line":"  environment: {}"}],"source_content_type":"text/x-yaml","patch_set":5,"id":"3fa7e38b_6a911a45","line":12,"updated":"2020-01-07 08:34:40.000000000","message":"good practice is to prefix with kolla-","commit_id":"38c731553c90df32ddd5c4f4eef2773e0812157e"},{"author":{"_account_id":26970,"name":"Yang Youseok","email":"ileixe@gmail.com","username":"ileixe"},"change_message_id":"af386871f994ffcd19c070b8346a17aecb376bc9","unresolved":false,"context_lines":[{"line_number":9,"context_line":"  when:"},{"line_number":10,"context_line":"    - host_http_proxy is defined"},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"- name: Add host_http_proxy to /etc/apt/apt.conf.d/proxy.conf if host_http_proxy is not empty"},{"line_number":13,"context_line":"  raw: echo \u0027Acquire::http::proxy \"{{ host_http_proxy }}\";\u0027 \u003e\u003e /etc/apt/apt.conf.d/proxy.conf"},{"line_number":14,"context_line":"  become: true"},{"line_number":15,"context_line":"  environment: {}"}],"source_content_type":"text/x-yaml","patch_set":5,"id":"3fa7e38b_4af3fe9f","line":12,"in_reply_to":"3fa7e38b_6a911a45","updated":"2020-01-07 08:41:03.000000000","message":"Thanks. fixed","commit_id":"38c731553c90df32ddd5c4f4eef2773e0812157e"},{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"1c5dc5c63f46c713542a594f41e37eb2a7c9322d","unresolved":false,"context_lines":[{"line_number":10,"context_line":"    - host_http_proxy is defined"},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"- name: Add host_http_proxy to /etc/apt/apt.conf.d/kolla-proxy.conf if host_http_proxy is not empty"},{"line_number":13,"context_line":"  raw: echo \u0027Acquire::http::proxy \"{{ host_http_proxy }}\";\u0027 \u003e\u003e /etc/apt/apt.conf.d/proxy.conf"},{"line_number":14,"context_line":"  become: true"},{"line_number":15,"context_line":"  environment: {}"},{"line_number":16,"context_line":"  when:"}],"source_content_type":"text/x-yaml","patch_set":6,"id":"3fa7e38b_0a4f468c","line":13,"range":{"start_line":13,"start_character":83,"end_line":13,"end_character":88},"updated":"2020-01-07 09:06:36.000000000","message":"and here, sir :-)","commit_id":"6e58168f7aeb1751d853261c8baf6afa79a76c46"},{"author":{"_account_id":26970,"name":"Yang Youseok","email":"ileixe@gmail.com","username":"ileixe"},"change_message_id":"f96da24aeccebc1d4217e214027e6051fd98a7e7","unresolved":false,"context_lines":[{"line_number":10,"context_line":"    - host_http_proxy is defined"},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"- name: Add host_http_proxy to /etc/apt/apt.conf.d/kolla-proxy.conf if host_http_proxy is not empty"},{"line_number":13,"context_line":"  raw: echo \u0027Acquire::http::proxy \"{{ host_http_proxy }}\";\u0027 \u003e\u003e /etc/apt/apt.conf.d/proxy.conf"},{"line_number":14,"context_line":"  become: true"},{"line_number":15,"context_line":"  environment: {}"},{"line_number":16,"context_line":"  when:"}],"source_content_type":"text/x-yaml","patch_set":6,"id":"3fa7e38b_e5421b3c","line":13,"range":{"start_line":13,"start_character":83,"end_line":13,"end_character":88},"in_reply_to":"3fa7e38b_0a4f468c","updated":"2020-01-07 09:20:54.000000000","message":"T_T sorry","commit_id":"6e58168f7aeb1751d853261c8baf6afa79a76c46"}],"ansible/roles/baremetal/templates/http-proxy.conf.j2":[{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"91ca841353a1933008fdf829b5a8a9802d65dcfe","unresolved":false,"context_lines":[{"line_number":1,"context_line":"[Service]"},{"line_number":2,"context_line":"Environment\u003d{% if host_http_proxy | length \u003e 0 %}\"HTTP_PROXY\u003d{{ host_http_proxy }}\"{% endif %} {% if host_https_proxy | length \u003e 0 %}\"HTTPS_PROXY\u003d{{ host_https_proxy }}\"{% endif %} {% if host_no_proxy | length \u003e 0"},{"line_number":3,"context_line":"%}\"NO_PROXY\u003d{{ host_no_proxy }}\"{% endif %}"}],"source_content_type":"text/x-jinja2","patch_set":4,"id":"3fa7e38b_934e1f6c","line":3,"updated":"2020-01-06 10:20:39.000000000","message":"line break","commit_id":"4ad1a6792435a3faf33c57a203d3f741b66ff2ac"}]}
