)]}'
{"ansible/roles/nova/handlers/main.yml":[{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"14d4089a68a321cd96314d516e81ab2a01996cd8","unresolved":false,"context_lines":[{"line_number":409,"context_line":"    - kolla_action \u003d\u003d \u0027upgrade\u0027"},{"line_number":410,"context_line":"  run_once: true"},{"line_number":411,"context_line":"  delegate_to: \"{{item[1]}}\""},{"line_number":412,"context_line":"  loop: \"{{service_list_in_restart_order }}\""},{"line_number":413,"context_line":"  listen:"},{"line_number":414,"context_line":"    - Restart nova-compute container"},{"line_number":415,"context_line":"    - Restart nova-compute-ironic container"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"3fa7e38b_432ff987","line":412,"range":{"start_line":412,"start_character":11,"end_line":412,"end_character":40},"updated":"2019-11-08 10:23:53.000000000","message":"As I commented in the bug report:\n\nI think it will take a long time to execute, because of the loop/delegate_to.\n\nHow about considering a partial revert of this change: https://review.opendev.org/#/c/665660/. We could keep the delay handler ( Wait for nova-compute services to update service versions), but remove the restart (Restart nova services to remove RPC version cap), and do the restart in reload.yml - use restart_container rather than SIGHUP though.","commit_id":"54e4cf80ef0a4a489fd290752b364ed7639d07e2"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"b9c2bc01450322e099f1c8f5921508d4b2610c5d","unresolved":false,"context_lines":[{"line_number":358,"context_line":"    - Restart nova-compute-ironic container"},{"line_number":359,"context_line":"    - Restart nova-compute-fake containers"},{"line_number":360,"context_line":""},{"line_number":361,"context_line":"# NOTE(mgoddard): Currently (just prior to Stein release), sending SIGHUP to"},{"line_number":362,"context_line":"# nova compute services leaves them in a broken state in which they cannot"},{"line_number":363,"context_line":"# start new instances. The following error is seen in the logs:"},{"line_number":364,"context_line":"# \"In shutdown, no new events can be scheduled\""},{"line_number":365,"context_line":"# To work around this we restart the nova-compute services."},{"line_number":366,"context_line":"# Speaking to the nova team, this seems to be an issue in oslo.service,"},{"line_number":367,"context_line":"# with a fix proposed here: https://review.openstack.org/#/c/641907."},{"line_number":368,"context_line":"# This issue also seems to affect the proxy services, which exit non-zero in"},{"line_number":369,"context_line":"# reponse to a SIGHUP, so restart those too."},{"line_number":370,"context_line":"# The issue actually affects all nova services, since they remain with RPC"},{"line_number":371,"context_line":"# version pinned to the previous release:"},{"line_number":372,"context_line":"# https://bugs.launchpad.net/kolla-ansible/+bug/1833069."},{"line_number":373,"context_line":"# TODO(mgoddard): Use SIGHUP when this bug has been fixed."}],"source_content_type":"text/x-yaml","patch_set":4,"id":"3fa7e38b_cd967a3f","line":373,"range":{"start_line":361,"start_character":0,"end_line":373,"end_character":58},"updated":"2019-11-14 10:29:55.000000000","message":"Please also remove this comment.","commit_id":"897b44f064b45566d9395da787973f7249c5a2ca"},{"author":{"_account_id":31246,"name":"Zdenek Dvorak","email":"z.dvorak@partner.samsung.com","username":"zdenek_dvorak"},"change_message_id":"f0a19f097264c86ba3930cda8a09ac46f4c15bbb","unresolved":false,"context_lines":[{"line_number":358,"context_line":"    - Restart nova-compute-ironic container"},{"line_number":359,"context_line":"    - Restart nova-compute-fake containers"},{"line_number":360,"context_line":""},{"line_number":361,"context_line":"# NOTE(mgoddard): Currently (just prior to Stein release), sending SIGHUP to"},{"line_number":362,"context_line":"# nova compute services leaves them in a broken state in which they cannot"},{"line_number":363,"context_line":"# start new instances. The following error is seen in the logs:"},{"line_number":364,"context_line":"# \"In shutdown, no new events can be scheduled\""},{"line_number":365,"context_line":"# To work around this we restart the nova-compute services."},{"line_number":366,"context_line":"# Speaking to the nova team, this seems to be an issue in oslo.service,"},{"line_number":367,"context_line":"# with a fix proposed here: https://review.openstack.org/#/c/641907."},{"line_number":368,"context_line":"# This issue also seems to affect the proxy services, which exit non-zero in"},{"line_number":369,"context_line":"# reponse to a SIGHUP, so restart those too."},{"line_number":370,"context_line":"# The issue actually affects all nova services, since they remain with RPC"},{"line_number":371,"context_line":"# version pinned to the previous release:"},{"line_number":372,"context_line":"# https://bugs.launchpad.net/kolla-ansible/+bug/1833069."},{"line_number":373,"context_line":"# TODO(mgoddard): Use SIGHUP when this bug has been fixed."}],"source_content_type":"text/x-yaml","patch_set":4,"id":"3fa7e38b_0bb9da77","line":373,"range":{"start_line":361,"start_character":0,"end_line":373,"end_character":58},"in_reply_to":"3fa7e38b_cd967a3f","updated":"2019-11-14 12:21:43.000000000","message":"OK I will remove this comment.","commit_id":"897b44f064b45566d9395da787973f7249c5a2ca"}],"ansible/roles/nova/tasks/reload.yml":[{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"b9c2bc01450322e099f1c8f5921508d4b2610c5d","unresolved":false,"context_lines":[{"line_number":16,"context_line":""},{"line_number":17,"context_line":"    when:"},{"line_number":18,"context_line":"      - kolla_action \u003d\u003d \u0027upgrade\u0027"},{"line_number":19,"context_line":"      - item in nova_services"},{"line_number":20,"context_line":"      - inventory_hostname in groups[nova_services[item].group]"},{"line_number":21,"context_line":"      - item !\u003d \u0027placement-api\u0027"},{"line_number":22,"context_line":"      - nova_services[item].enabled | bool"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"3fa7e38b_cde43ae3","line":19,"range":{"start_line":19,"start_character":8,"end_line":19,"end_character":29},"updated":"2019-11-14 10:29:55.000000000","message":"nit: always true","commit_id":"897b44f064b45566d9395da787973f7249c5a2ca"},{"author":{"_account_id":31246,"name":"Zdenek Dvorak","email":"z.dvorak@partner.samsung.com","username":"zdenek_dvorak"},"change_message_id":"f0a19f097264c86ba3930cda8a09ac46f4c15bbb","unresolved":false,"context_lines":[{"line_number":16,"context_line":""},{"line_number":17,"context_line":"    when:"},{"line_number":18,"context_line":"      - kolla_action \u003d\u003d \u0027upgrade\u0027"},{"line_number":19,"context_line":"      - item in nova_services"},{"line_number":20,"context_line":"      - inventory_hostname in groups[nova_services[item].group]"},{"line_number":21,"context_line":"      - item !\u003d \u0027placement-api\u0027"},{"line_number":22,"context_line":"      - nova_services[item].enabled | bool"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"3fa7e38b_2bc5b60a","line":19,"range":{"start_line":19,"start_character":8,"end_line":19,"end_character":29},"in_reply_to":"3fa7e38b_cde43ae3","updated":"2019-11-14 12:21:43.000000000","message":"OK: I will remove this line.\nWe trust correctness of  nova_services_require_nova_conf.","commit_id":"897b44f064b45566d9395da787973f7249c5a2ca"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"b9c2bc01450322e099f1c8f5921508d4b2610c5d","unresolved":false,"context_lines":[{"line_number":20,"context_line":"      - inventory_hostname in groups[nova_services[item].group]"},{"line_number":21,"context_line":"      - item !\u003d \u0027placement-api\u0027"},{"line_number":22,"context_line":"      - nova_services[item].enabled | bool"},{"line_number":23,"context_line":"    loop: \"{{ nova_services_require_nova_conf | difference([\u0027nova-compute\u0027]) }}\""},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"  - name: Restart nova-compute service"},{"line_number":26,"context_line":"    kolla_docker:"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"3fa7e38b_6da5069f","line":23,"range":{"start_line":23,"start_character":4,"end_line":23,"end_character":8},"updated":"2019-11-14 10:29:55.000000000","message":"Please use with_items, since Rocky needs to support Ansible 2.4.","commit_id":"897b44f064b45566d9395da787973f7249c5a2ca"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"b9c2bc01450322e099f1c8f5921508d4b2610c5d","unresolved":false,"context_lines":[{"line_number":20,"context_line":"      - inventory_hostname in groups[nova_services[item].group]"},{"line_number":21,"context_line":"      - item !\u003d \u0027placement-api\u0027"},{"line_number":22,"context_line":"      - nova_services[item].enabled | bool"},{"line_number":23,"context_line":"    loop: \"{{ nova_services_require_nova_conf | difference([\u0027nova-compute\u0027]) }}\""},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"  - name: Restart nova-compute service"},{"line_number":26,"context_line":"    kolla_docker:"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"3fa7e38b_0d1252b5","line":23,"range":{"start_line":23,"start_character":61,"end_line":23,"end_character":73},"updated":"2019-11-14 10:29:55.000000000","message":"This needs to include nova-compute-ironic also.","commit_id":"897b44f064b45566d9395da787973f7249c5a2ca"},{"author":{"_account_id":31246,"name":"Zdenek Dvorak","email":"z.dvorak@partner.samsung.com","username":"zdenek_dvorak"},"change_message_id":"f0a19f097264c86ba3930cda8a09ac46f4c15bbb","unresolved":false,"context_lines":[{"line_number":20,"context_line":"      - inventory_hostname in groups[nova_services[item].group]"},{"line_number":21,"context_line":"      - item !\u003d \u0027placement-api\u0027"},{"line_number":22,"context_line":"      - nova_services[item].enabled | bool"},{"line_number":23,"context_line":"    loop: \"{{ nova_services_require_nova_conf | difference([\u0027nova-compute\u0027]) }}\""},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"  - name: Restart nova-compute service"},{"line_number":26,"context_line":"    kolla_docker:"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"3fa7e38b_ab8686b9","line":23,"range":{"start_line":23,"start_character":61,"end_line":23,"end_character":73},"in_reply_to":"3fa7e38b_0d1252b5","updated":"2019-11-14 12:21:43.000000000","message":"OK. I do not have nova-compute-ironic in my test lab. So I missed it.","commit_id":"897b44f064b45566d9395da787973f7249c5a2ca"},{"author":{"_account_id":31246,"name":"Zdenek Dvorak","email":"z.dvorak@partner.samsung.com","username":"zdenek_dvorak"},"change_message_id":"f0a19f097264c86ba3930cda8a09ac46f4c15bbb","unresolved":false,"context_lines":[{"line_number":20,"context_line":"      - inventory_hostname in groups[nova_services[item].group]"},{"line_number":21,"context_line":"      - item !\u003d \u0027placement-api\u0027"},{"line_number":22,"context_line":"      - nova_services[item].enabled | bool"},{"line_number":23,"context_line":"    loop: \"{{ nova_services_require_nova_conf | difference([\u0027nova-compute\u0027]) }}\""},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"  - name: Restart nova-compute service"},{"line_number":26,"context_line":"    kolla_docker:"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"3fa7e38b_2bbcd66a","line":23,"range":{"start_line":23,"start_character":4,"end_line":23,"end_character":8},"in_reply_to":"3fa7e38b_6da5069f","updated":"2019-11-14 12:21:43.000000000","message":"OK. I will change it","commit_id":"897b44f064b45566d9395da787973f7249c5a2ca"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"b9c2bc01450322e099f1c8f5921508d4b2610c5d","unresolved":false,"context_lines":[{"line_number":22,"context_line":"      - nova_services[item].enabled | bool"},{"line_number":23,"context_line":"    loop: \"{{ nova_services_require_nova_conf | difference([\u0027nova-compute\u0027]) }}\""},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"  - name: Restart nova-compute service"},{"line_number":26,"context_line":"    kolla_docker:"},{"line_number":27,"context_line":"      action: \"restart_container\""},{"line_number":28,"context_line":"      common_options: \"{{ docker_common_options }}\""}],"source_content_type":"text/x-yaml","patch_set":4,"id":"3fa7e38b_2d15ce9b","line":25,"updated":"2019-11-14 10:29:55.000000000","message":"And we need to include nova-compute-ironic here too.","commit_id":"897b44f064b45566d9395da787973f7249c5a2ca"},{"author":{"_account_id":31246,"name":"Zdenek Dvorak","email":"z.dvorak@partner.samsung.com","username":"zdenek_dvorak"},"change_message_id":"f0a19f097264c86ba3930cda8a09ac46f4c15bbb","unresolved":false,"context_lines":[{"line_number":22,"context_line":"      - nova_services[item].enabled | bool"},{"line_number":23,"context_line":"    loop: \"{{ nova_services_require_nova_conf | difference([\u0027nova-compute\u0027]) }}\""},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"  - name: Restart nova-compute service"},{"line_number":26,"context_line":"    kolla_docker:"},{"line_number":27,"context_line":"      action: \"restart_container\""},{"line_number":28,"context_line":"      common_options: \"{{ docker_common_options }}\""}],"source_content_type":"text/x-yaml","patch_set":4,"id":"3fa7e38b_6b908eee","line":25,"in_reply_to":"3fa7e38b_2d15ce9b","updated":"2019-11-14 12:21:43.000000000","message":"OK. I do not have nova-compute-ironic in my test lab. So I missed it.","commit_id":"897b44f064b45566d9395da787973f7249c5a2ca"}]}