)]}'
{"ansible/roles/baremetal/defaults/main.yml":[{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"8959742323be7dec073ee9cfda201facf3d19bfa","unresolved":false,"context_lines":[{"line_number":49,"context_line":"debian_pkg_install:"},{"line_number":50,"context_line":" - \"{{ docker_apt_package }}\""},{"line_number":51,"context_line":" - git"},{"line_number":52,"context_line":" - \"{% if not easy_install_available %}python-pip{% endif %}\""},{"line_number":53,"context_line":" - python-setuptools"},{"line_number":54,"context_line":" - \"{% if enable_host_ntp | bool %}ntp{% endif %}\""},{"line_number":55,"context_line":" - \"{% if enable_ceph_nfs|bool %}rpcbind{% endif %}\""}],"source_content_type":"text/x-yaml","patch_set":16,"id":"3fa7e38b_57b56531","line":52,"range":{"start_line":52,"start_character":39,"end_line":52,"end_character":49},"updated":"2019-11-11 10:32:07.000000000","message":"Might need an equivalent for C8.","commit_id":"e1e613867737d488d497cc7b60cfa31c51398dd9"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"60e721c7836cdee7fae13eec2423950ac7c08d38","unresolved":false,"context_lines":[{"line_number":49,"context_line":"debian_pkg_install:"},{"line_number":50,"context_line":" - \"{{ docker_apt_package }}\""},{"line_number":51,"context_line":" - git"},{"line_number":52,"context_line":" - \"{% if not easy_install_available %}python-pip{% endif %}\""},{"line_number":53,"context_line":" - python-setuptools"},{"line_number":54,"context_line":" - \"{% if enable_host_ntp | bool %}ntp{% endif %}\""},{"line_number":55,"context_line":" - \"{% if enable_ceph_nfs|bool %}rpcbind{% endif %}\""}],"source_content_type":"text/x-yaml","patch_set":16,"id":"3fa7e38b_d0c92dac","line":52,"range":{"start_line":52,"start_character":39,"end_line":52,"end_character":49},"in_reply_to":"3fa7e38b_3520daf8","updated":"2019-11-14 10:59:16.000000000","message":"Yes - because previously RH had easy_install. If it no longer does, then we need to ensure pip is installed.","commit_id":"e1e613867737d488d497cc7b60cfa31c51398dd9"},{"author":{"_account_id":24072,"name":"Marcin Juszkiewicz","email":"mjuszkiewicz@redhat.com","username":"hrw"},"change_message_id":"2be9ca05e371f4efc6495f5c9b0a59ae85115f74","unresolved":false,"context_lines":[{"line_number":49,"context_line":"debian_pkg_install:"},{"line_number":50,"context_line":" - \"{{ docker_apt_package }}\""},{"line_number":51,"context_line":" - git"},{"line_number":52,"context_line":" - \"{% if not easy_install_available %}python-pip{% endif %}\""},{"line_number":53,"context_line":" - python-setuptools"},{"line_number":54,"context_line":" - \"{% if enable_host_ntp | bool %}ntp{% endif %}\""},{"line_number":55,"context_line":" - \"{% if enable_ceph_nfs|bool %}rpcbind{% endif %}\""}],"source_content_type":"text/x-yaml","patch_set":16,"id":"3fa7e38b_3520daf8","line":52,"range":{"start_line":52,"start_character":39,"end_line":52,"end_character":49},"in_reply_to":"3fa7e38b_57b56531","updated":"2019-11-12 08:19:09.000000000","message":"C8 has python3-pip\n\nBut note that this is Debian list part. Red Hat list is below and does not have pip at all.","commit_id":"e1e613867737d488d497cc7b60cfa31c51398dd9"}],"ansible/roles/baremetal/tasks/install.yml":[{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"8959742323be7dec073ee9cfda201facf3d19bfa","unresolved":false,"context_lines":[{"line_number":64,"context_line":"  become: True"},{"line_number":65,"context_line":"  when: ansible_os_family \u003d\u003d \u0027RedHat\u0027"},{"line_number":66,"context_line":""},{"line_number":67,"context_line":"- name: Install yum packages"},{"line_number":68,"context_line":"  package:"},{"line_number":69,"context_line":"    name: \"{{ (redhat_pkg_install | join(\u0027 \u0027)).split() }}\""},{"line_number":70,"context_line":"    state: present"}],"source_content_type":"text/x-yaml","patch_set":16,"id":"3fa7e38b_3778e98d","line":67,"range":{"start_line":67,"start_character":16,"end_line":67,"end_character":19},"updated":"2019-11-11 10:32:07.000000000","message":"RPM","commit_id":"e1e613867737d488d497cc7b60cfa31c51398dd9"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"8959742323be7dec073ee9cfda201facf3d19bfa","unresolved":false,"context_lines":[{"line_number":71,"context_line":"    update_cache: yes"},{"line_number":72,"context_line":"  become: True"},{"line_number":73,"context_line":"  when: ansible_os_family \u003d\u003d \u0027RedHat\u0027"},{"line_number":74,"context_line":"  register: yum_install_result"},{"line_number":75,"context_line":""},{"line_number":76,"context_line":"# If any packages were updated, and any containers were running, wait for the"},{"line_number":77,"context_line":"# daemon to come up and start all previously running containers."}],"source_content_type":"text/x-yaml","patch_set":16,"id":"3fa7e38b_d76cf5d1","line":74,"range":{"start_line":74,"start_character":12,"end_line":74,"end_character":15},"updated":"2019-11-11 10:32:07.000000000","message":"rpm","commit_id":"e1e613867737d488d497cc7b60cfa31c51398dd9"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"8959742323be7dec073ee9cfda201facf3d19bfa","unresolved":false,"context_lines":[{"line_number":98,"context_line":""},{"line_number":99,"context_line":"- name: Install virtualenv packages"},{"line_number":100,"context_line":"  package:"},{"line_number":101,"context_line":"    name: python-virtualenv"},{"line_number":102,"context_line":"    state: present"},{"line_number":103,"context_line":"  become: True"},{"line_number":104,"context_line":"  when: virtualenv is not none"}],"source_content_type":"text/x-yaml","patch_set":16,"id":"3fa7e38b_f7a6d10f","line":101,"range":{"start_line":101,"start_character":10,"end_line":101,"end_character":27},"updated":"2019-11-11 10:32:07.000000000","message":"Not for CentOS 8","commit_id":"e1e613867737d488d497cc7b60cfa31c51398dd9"},{"author":{"_account_id":24072,"name":"Marcin Juszkiewicz","email":"mjuszkiewicz@redhat.com","username":"hrw"},"change_message_id":"2be9ca05e371f4efc6495f5c9b0a59ae85115f74","unresolved":false,"context_lines":[{"line_number":98,"context_line":""},{"line_number":99,"context_line":"- name: Install virtualenv packages"},{"line_number":100,"context_line":"  package:"},{"line_number":101,"context_line":"    name: python-virtualenv"},{"line_number":102,"context_line":"    state: present"},{"line_number":103,"context_line":"  become: True"},{"line_number":104,"context_line":"  when: virtualenv is not none"}],"source_content_type":"text/x-yaml","patch_set":16,"id":"3fa7e38b_5580f6bf","line":101,"range":{"start_line":101,"start_character":10,"end_line":101,"end_character":27},"in_reply_to":"3fa7e38b_f7a6d10f","updated":"2019-11-12 08:19:09.000000000","message":"C8 has python3-virtualenv","commit_id":"e1e613867737d488d497cc7b60cfa31c51398dd9"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"8959742323be7dec073ee9cfda201facf3d19bfa","unresolved":false,"context_lines":[{"line_number":115,"context_line":"    virtualenv: \"{{ virtualenv is none | ternary(omit, virtualenv) }}\""},{"line_number":116,"context_line":"    virtualenv_site_packages: \"{{ virtualenv is none | ternary(omit, virtualenv_site_packages) }}\""},{"line_number":117,"context_line":"  become: True"},{"line_number":118,"context_line":"  when: which_easy_install.rc \u003d\u003d 0"},{"line_number":119,"context_line":""},{"line_number":120,"context_line":"- name: Install latest pip in the virtualenv"},{"line_number":121,"context_line":"  pip:"}],"source_content_type":"text/x-yaml","patch_set":16,"id":"3fa7e38b_d7a155f9","line":118,"updated":"2019-11-11 10:32:07.000000000","message":"I think only CentOS 7 is left with easy_install, so we could add that to the condition.","commit_id":"e1e613867737d488d497cc7b60cfa31c51398dd9"}],"ansible/roles/baremetal/tasks/pre-install.yml":[{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"8959742323be7dec073ee9cfda201facf3d19bfa","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"# NOTE: raw install is required to support cloud images which do not have python installed"},{"line_number":3,"context_line":"- name: \"Install python2\""},{"line_number":4,"context_line":"  become: True"},{"line_number":5,"context_line":"  raw: \"yum install -y python || (apt-get update \u0026\u0026 apt-get install -y python2.7)\""},{"line_number":6,"context_line":"  when:"}],"source_content_type":"text/x-yaml","patch_set":16,"id":"3fa7e38b_17812d4e","line":3,"updated":"2019-11-11 10:32:07.000000000","message":"Does C8 come with py3?","commit_id":"e1e613867737d488d497cc7b60cfa31c51398dd9"},{"author":{"_account_id":24072,"name":"Marcin Juszkiewicz","email":"mjuszkiewicz@redhat.com","username":"hrw"},"change_message_id":"2be9ca05e371f4efc6495f5c9b0a59ae85115f74","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"# NOTE: raw install is required to support cloud images which do not have python installed"},{"line_number":3,"context_line":"- name: \"Install python2\""},{"line_number":4,"context_line":"  become: True"},{"line_number":5,"context_line":"  raw: \"yum install -y python || (apt-get update \u0026\u0026 apt-get install -y python2.7)\""},{"line_number":6,"context_line":"  when:"}],"source_content_type":"text/x-yaml","patch_set":16,"id":"3fa7e38b_955f4e74","line":3,"in_reply_to":"3fa7e38b_17812d4e","updated":"2019-11-12 08:19:09.000000000","message":"Base image comes without Python at all.\n\npython3 package is provided in repository","commit_id":"e1e613867737d488d497cc7b60cfa31c51398dd9"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"60e721c7836cdee7fae13eec2423950ac7c08d38","unresolved":false,"context_lines":[{"line_number":2,"context_line":"# NOTE: raw install is required to support cloud images which do not have python installed"},{"line_number":3,"context_line":"- name: \"Install python2\""},{"line_number":4,"context_line":"  become: True"},{"line_number":5,"context_line":"  raw: \"yum install -y python || (apt-get update \u0026\u0026 apt-get install -y python2.7)\""},{"line_number":6,"context_line":"  when:"},{"line_number":7,"context_line":"    - ansible_distribution !\u003d \u0027CentOS\u0027 or ansible_distribution_major_version !\u003d \u00278\u0027"},{"line_number":8,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":16,"id":"3fa7e38b_50bd3d00","line":5,"range":{"start_line":5,"start_character":23,"end_line":5,"end_character":29},"updated":"2019-11-14 10:59:16.000000000","message":"So this needs to be python3.\n\nI do wonder how we would get here without python though as we gather facts before this point.","commit_id":"e1e613867737d488d497cc7b60cfa31c51398dd9"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"8959742323be7dec073ee9cfda201facf3d19bfa","unresolved":false,"context_lines":[{"line_number":122,"context_line":"    - block:"},{"line_number":123,"context_line":"        - name: Ensure yum repos directory exists"},{"line_number":124,"context_line":"          file:"},{"line_number":125,"context_line":"            path: /etc/yum.repos.d/"},{"line_number":126,"context_line":"            state: directory"},{"line_number":127,"context_line":"            recurse: yes"},{"line_number":128,"context_line":"          become: True"}],"source_content_type":"text/x-yaml","patch_set":16,"id":"3fa7e38b_3786a967","line":125,"range":{"start_line":125,"start_character":22,"end_line":125,"end_character":35},"updated":"2019-11-11 10:32:07.000000000","message":"C7 only?","commit_id":"e1e613867737d488d497cc7b60cfa31c51398dd9"},{"author":{"_account_id":24072,"name":"Marcin Juszkiewicz","email":"mjuszkiewicz@redhat.com","username":"hrw"},"change_message_id":"2be9ca05e371f4efc6495f5c9b0a59ae85115f74","unresolved":false,"context_lines":[{"line_number":122,"context_line":"    - block:"},{"line_number":123,"context_line":"        - name: Ensure yum repos directory exists"},{"line_number":124,"context_line":"          file:"},{"line_number":125,"context_line":"            path: /etc/yum.repos.d/"},{"line_number":126,"context_line":"            state: directory"},{"line_number":127,"context_line":"            recurse: yes"},{"line_number":128,"context_line":"          become: True"}],"source_content_type":"text/x-yaml","patch_set":16,"id":"3fa7e38b_5559d68b","line":125,"range":{"start_line":125,"start_character":22,"end_line":125,"end_character":35},"in_reply_to":"3fa7e38b_3786a967","updated":"2019-11-12 08:19:09.000000000","message":"/etc/yum.repos.d/ directory is used in all versions of RHEL/Fedora systems. Nevermind is it using yum or dnf as package manager.","commit_id":"e1e613867737d488d497cc7b60cfa31c51398dd9"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"8959742323be7dec073ee9cfda201facf3d19bfa","unresolved":false,"context_lines":[{"line_number":128,"context_line":"          become: True"},{"line_number":129,"context_line":""},{"line_number":130,"context_line":"        - name: Enable docker yum repository"},{"line_number":131,"context_line":"          yum_repository:"},{"line_number":132,"context_line":"            name: docker"},{"line_number":133,"context_line":"            description: Docker main Repository"},{"line_number":134,"context_line":"            baseurl: \"{{ docker_yum_baseurl }}\""}],"source_content_type":"text/x-yaml","patch_set":16,"id":"3fa7e38b_97943d8e","line":131,"range":{"start_line":131,"start_character":10,"end_line":131,"end_character":24},"updated":"2019-11-11 10:32:07.000000000","message":"Does this still work for DNF?","commit_id":"e1e613867737d488d497cc7b60cfa31c51398dd9"},{"author":{"_account_id":24072,"name":"Marcin Juszkiewicz","email":"mjuszkiewicz@redhat.com","username":"hrw"},"change_message_id":"2be9ca05e371f4efc6495f5c9b0a59ae85115f74","unresolved":false,"context_lines":[{"line_number":128,"context_line":"          become: True"},{"line_number":129,"context_line":""},{"line_number":130,"context_line":"        - name: Enable docker yum repository"},{"line_number":131,"context_line":"          yum_repository:"},{"line_number":132,"context_line":"            name: docker"},{"line_number":133,"context_line":"            description: Docker main Repository"},{"line_number":134,"context_line":"            baseurl: \"{{ docker_yum_baseurl }}\""}],"source_content_type":"text/x-yaml","patch_set":16,"id":"3fa7e38b_b5c7ea11","line":131,"range":{"start_line":131,"start_character":10,"end_line":131,"end_character":24},"in_reply_to":"3fa7e38b_97943d8e","updated":"2019-11-12 08:19:09.000000000","message":"It does. Syntax of repo files is the same.","commit_id":"e1e613867737d488d497cc7b60cfa31c51398dd9"}],"tests/run.yml":[{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"8959742323be7dec073ee9cfda201facf3d19bfa","unresolved":false,"context_lines":[{"line_number":187,"context_line":"        need_build_image"},{"line_number":188,"context_line":"      become: true"},{"line_number":189,"context_line":""},{"line_number":190,"context_line":"    - name: ensure python with pip is linked"},{"line_number":191,"context_line":"      file:"},{"line_number":192,"context_line":"        src: \"/usr/bin/{{ item }}3\""},{"line_number":193,"context_line":"        dest: \"/usr/bin/{{ item }}\""}],"source_content_type":"text/x-yaml","patch_set":16,"id":"3fa7e38b_d7ef151b","line":190,"updated":"2019-11-11 10:32:07.000000000","message":"There was an email on openstack-discuss about explicitly not assuming a versionless interpreter exists: http://lists.openstack.org/pipermail/openstack-discuss/2019-October/010146.html","commit_id":"e1e613867737d488d497cc7b60cfa31c51398dd9"}],"tests/templates/globals-default.j2":[{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"c2fc2160584c27693335b4a11662cf9ad132eee0","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"# Force the use of python2 on Ubuntu/Debian and CentOS7 remote hosts. This is"},{"line_number":3,"context_line":"# necessary for delegate_to: localhost, which will otherwise use the local"},{"line_number":4,"context_line":"# python interpreter (python3).  On CentOS 7, that fails due to a lack of"},{"line_number":5,"context_line":"# python3 bindings for SELinux.  https://bugs.centos.org/view.php?id\u003d16389"}],"source_content_type":"text/x-jinja2","patch_set":37,"id":"3fa7e38b_18aaf56c","line":2,"range":{"start_line":2,"start_character":30,"end_line":2,"end_character":43},"updated":"2020-01-30 08:30:16.000000000","message":"well, that\u0027s not really getting rid of python2 :-)","commit_id":"b189a7d4b9c3d0e0af9ecd3820cbffc8869eef4d"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"c214b6b397ec0cbf9009d2909098cfbe96619180","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"# Force the use of python2 on Ubuntu/Debian and CentOS7 remote hosts. This is"},{"line_number":3,"context_line":"# necessary for delegate_to: localhost, which will otherwise use the local"},{"line_number":4,"context_line":"# python interpreter (python3).  On CentOS 7, that fails due to a lack of"},{"line_number":5,"context_line":"# python3 bindings for SELinux.  https://bugs.centos.org/view.php?id\u003d16389"}],"source_content_type":"text/x-jinja2","patch_set":37,"id":"3fa7e38b_99fa67b9","line":2,"range":{"start_line":2,"start_character":30,"end_line":2,"end_character":43},"in_reply_to":"3fa7e38b_18aaf56c","updated":"2020-01-30 11:35:27.000000000","message":"all in good time.","commit_id":"b189a7d4b9c3d0e0af9ecd3820cbffc8869eef4d"}],"zuul.d/jobs.yaml":[{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"8959742323be7dec073ee9cfda201facf3d19bfa","unresolved":false,"context_lines":[{"line_number":109,"context_line":"      scenario: ceph"},{"line_number":110,"context_line":"    host-vars:"},{"line_number":111,"context_line":"      primary:"},{"line_number":112,"context_line":"        ceph_osd_storetype: bluestore"},{"line_number":113,"context_line":"      secondary1:"},{"line_number":114,"context_line":"        ceph_osd_storetype: bluestore"},{"line_number":115,"context_line":"      secondary2:"}],"source_content_type":"text/x-yaml","patch_set":16,"id":"3fa7e38b_b7d61953","line":112,"range":{"start_line":112,"start_character":28,"end_line":112,"end_character":37},"updated":"2019-11-11 10:32:07.000000000","message":"no filestore?","commit_id":"e1e613867737d488d497cc7b60cfa31c51398dd9"},{"author":{"_account_id":24072,"name":"Marcin Juszkiewicz","email":"mjuszkiewicz@redhat.com","username":"hrw"},"change_message_id":"2be9ca05e371f4efc6495f5c9b0a59ae85115f74","unresolved":false,"context_lines":[{"line_number":109,"context_line":"      scenario: ceph"},{"line_number":110,"context_line":"    host-vars:"},{"line_number":111,"context_line":"      primary:"},{"line_number":112,"context_line":"        ceph_osd_storetype: bluestore"},{"line_number":113,"context_line":"      secondary1:"},{"line_number":114,"context_line":"        ceph_osd_storetype: bluestore"},{"line_number":115,"context_line":"      secondary2:"}],"source_content_type":"text/x-yaml","patch_set":16,"id":"3fa7e38b_d5e1469d","line":112,"range":{"start_line":112,"start_character":28,"end_line":112,"end_character":37},"in_reply_to":"3fa7e38b_b7d61953","updated":"2019-11-12 08:19:09.000000000","message":"filestore is past","commit_id":"e1e613867737d488d497cc7b60cfa31c51398dd9"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"60e721c7836cdee7fae13eec2423950ac7c08d38","unresolved":false,"context_lines":[{"line_number":109,"context_line":"      scenario: ceph"},{"line_number":110,"context_line":"    host-vars:"},{"line_number":111,"context_line":"      primary:"},{"line_number":112,"context_line":"        ceph_osd_storetype: bluestore"},{"line_number":113,"context_line":"      secondary1:"},{"line_number":114,"context_line":"        ceph_osd_storetype: bluestore"},{"line_number":115,"context_line":"      secondary2:"}],"source_content_type":"text/x-yaml","patch_set":16,"id":"3fa7e38b_704dd939","line":112,"range":{"start_line":112,"start_character":28,"end_line":112,"end_character":37},"in_reply_to":"3fa7e38b_d5e1469d","updated":"2019-11-14 10:59:16.000000000","message":"Fair, but seems like a separate thing to stop testing it, and therefore stop supporting it.","commit_id":"e1e613867737d488d497cc7b60cfa31c51398dd9"}]}