)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"1159294542c0bcc9b8f7a726c8a21c046963f99c","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Default to etcd3gw driver for etcd-based coordination"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"To fix instability and availability issues."},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"Change-Id: I430bab735da204fc81696130b17931a89214c876"},{"line_number":12,"context_line":"Closes-bug: #1852086"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"3fa7e38b_0e98ef18","line":9,"updated":"2019-12-05 16:45:06.000000000","message":"Let\u0027s add a bit more detail here now that we know it. Here\u0027s the initial etcd3+http commit: https://github.com/openstack/tooz/commit/6ec73a0bed7382790819151a0a84db2a8a464438#diff-b052398e2327d2c582bf329576598641","commit_id":"31119adae35a2bc2454262ad4eeac01933d329f9"}],"ansible/group_vars/all.yml":[{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"402a3d2e8c93b13e6c42257a679bd8680702c2a6","unresolved":false,"context_lines":[{"line_number":864,"context_line":"cinder_target_helper: \"tgtadm\""},{"line_number":865,"context_line":"# Valid options are [ \u0027\u0027, redis, etcd3 ]"},{"line_number":866,"context_line":"# etcd3 coordination backend support not available in binary images"},{"line_number":867,"context_line":"cinder_coordination_backend: \"\""},{"line_number":868,"context_line":""},{"line_number":869,"context_line":"# Valid options are [ nfs, swift, ceph ]"},{"line_number":870,"context_line":"cinder_backup_driver: \"ceph\""}],"source_content_type":"text/x-yaml","patch_set":3,"id":"3fa7e38b_26ca446d","line":867,"range":{"start_line":867,"start_character":0,"end_line":867,"end_character":27},"updated":"2019-11-25 15:53:49.000000000","message":"We already backported this to Stein, so this would be a behaviour change.","commit_id":"0f604be1f6ad16b0a2c52eebf0472987278cde74"},{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"730624da1887b5153dbf44ae3068f2905b22dd36","unresolved":false,"context_lines":[{"line_number":864,"context_line":"cinder_target_helper: \"tgtadm\""},{"line_number":865,"context_line":"# Valid options are [ \u0027\u0027, redis, etcd3 ]"},{"line_number":866,"context_line":"# etcd3 coordination backend support not available in binary images"},{"line_number":867,"context_line":"cinder_coordination_backend: \"\""},{"line_number":868,"context_line":""},{"line_number":869,"context_line":"# Valid options are [ nfs, swift, ceph ]"},{"line_number":870,"context_line":"cinder_backup_driver: \"ceph\""}],"source_content_type":"text/x-yaml","patch_set":3,"id":"3fa7e38b_610ca692","line":867,"range":{"start_line":867,"start_character":0,"end_line":867,"end_character":27},"in_reply_to":"3fa7e38b_26ca446d","updated":"2019-11-25 16:43:50.000000000","message":"Look at my comment on the last file.","commit_id":"0f604be1f6ad16b0a2c52eebf0472987278cde74"}],"ansible/roles/cinder/templates/cinder.conf.j2":[{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"a0f64a01da1ab20a0d8428eb7dca0aad9f1a1c23","unresolved":false,"context_lines":[{"line_number":209,"context_line":"{% if cinder_coordination_backend \u003d\u003d \u0027redis\u0027 %}"},{"line_number":210,"context_line":"backend_url \u003d {{ redis_connection_string }}"},{"line_number":211,"context_line":"{% elif cinder_coordination_backend \u003d\u003d \u0027etcd\u0027 %}"},{"line_number":212,"context_line":"# NOTE(yoctozepto): etcd3gw does not support multiple endpoints here"},{"line_number":213,"context_line":"backend_url \u003d etcd3+http://{{ \u0027api\u0027 | kolla_address(groups[\u0027etcd\u0027][0]) | put_address_in_context(\u0027url\u0027) }}:{{ etcd_client_port }}"},{"line_number":214,"context_line":"{% endif %}"}],"source_content_type":"text/x-jinja2","patch_set":4,"id":"3fa7e38b_5189b86c","line":212,"range":{"start_line":212,"start_character":0,"end_line":212,"end_character":68},"updated":"2019-12-04 17:28:55.000000000","message":"Should we use haproxy then? Depending on a single etcd node seems wrong.","commit_id":"31119adae35a2bc2454262ad4eeac01933d329f9"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"1159294542c0bcc9b8f7a726c8a21c046963f99c","unresolved":false,"context_lines":[{"line_number":209,"context_line":"{% if cinder_coordination_backend \u003d\u003d \u0027redis\u0027 %}"},{"line_number":210,"context_line":"backend_url \u003d {{ redis_connection_string }}"},{"line_number":211,"context_line":"{% elif cinder_coordination_backend \u003d\u003d \u0027etcd\u0027 %}"},{"line_number":212,"context_line":"# NOTE(yoctozepto): etcd3gw does not support multiple endpoints here"},{"line_number":213,"context_line":"backend_url \u003d etcd3+http://{{ \u0027api\u0027 | kolla_address(groups[\u0027etcd\u0027][0]) | put_address_in_context(\u0027url\u0027) }}:{{ etcd_client_port }}"},{"line_number":214,"context_line":"{% endif %}"}],"source_content_type":"text/x-jinja2","patch_set":4,"id":"3fa7e38b_4ea26741","line":212,"range":{"start_line":212,"start_character":0,"end_line":212,"end_character":68},"in_reply_to":"3fa7e38b_31fafc42","updated":"2019-12-05 16:45:06.000000000","message":"Let\u0027s add a comment here with justification for etcd3+http","commit_id":"31119adae35a2bc2454262ad4eeac01933d329f9"},{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"d7f311564fc7f864d9e8e4e1b12b8cab21a4e8ec","unresolved":false,"context_lines":[{"line_number":209,"context_line":"{% if cinder_coordination_backend \u003d\u003d \u0027redis\u0027 %}"},{"line_number":210,"context_line":"backend_url \u003d {{ redis_connection_string }}"},{"line_number":211,"context_line":"{% elif cinder_coordination_backend \u003d\u003d \u0027etcd\u0027 %}"},{"line_number":212,"context_line":"# NOTE(yoctozepto): etcd3gw does not support multiple endpoints here"},{"line_number":213,"context_line":"backend_url \u003d etcd3+http://{{ \u0027api\u0027 | kolla_address(groups[\u0027etcd\u0027][0]) | put_address_in_context(\u0027url\u0027) }}:{{ etcd_client_port }}"},{"line_number":214,"context_line":"{% endif %}"}],"source_content_type":"text/x-jinja2","patch_set":4,"id":"3fa7e38b_31fafc42","line":212,"range":{"start_line":212,"start_character":0,"end_line":212,"end_character":68},"in_reply_to":"3fa7e38b_5189b86c","updated":"2019-12-04 17:44:20.000000000","message":"Good idea but unrelated to this particular issue. The behavior remains unchanged.","commit_id":"31119adae35a2bc2454262ad4eeac01933d329f9"}],"ansible/roles/designate/templates/designate.conf.j2":[{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"1159294542c0bcc9b8f7a726c8a21c046963f99c","unresolved":false,"context_lines":[{"line_number":104,"context_line":"backend_url \u003d {{ redis_connection_string }}"},{"line_number":105,"context_line":"{% elif designate_coordination_backend \u003d\u003d \u0027etcd\u0027 %}"},{"line_number":106,"context_line":"# NOTE(yoctozepto): etcd3gw does not support multiple endpoints here"},{"line_number":107,"context_line":"backend_url \u003d etcd3+http://{{ \u0027api\u0027 | kolla_address(groups[\u0027etcd\u0027][0]) | put_address_in_context(\u0027url\u0027) }}:{{ etcd_client_port }}"},{"line_number":108,"context_line":"{% endif %}"}],"source_content_type":"text/x-jinja2","patch_set":4,"id":"3fa7e38b_ee60f30f","line":107,"updated":"2019-12-05 16:45:06.000000000","message":"and here","commit_id":"31119adae35a2bc2454262ad4eeac01933d329f9"}],"doc/source/reference/networking/designate-guide.rst":[{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"402a3d2e8c93b13e6c42257a679bd8680702c2a6","unresolved":false,"context_lines":[{"line_number":39,"context_line":""},{"line_number":40,"context_line":".. important::"},{"line_number":41,"context_line":""},{"line_number":42,"context_line":"   If multiple nodes are assigned to be Designate workers then you must"},{"line_number":43,"context_line":"   enable a supported coordination backend, currently either \u0027redis\u0027 or"},{"line_number":44,"context_line":"   \u0027etcd3\u0027. The backend must be set by the"},{"line_number":45,"context_line":"   ``designate_coordination_backend`` variable."},{"line_number":46,"context_line":""},{"line_number":47,"context_line":"The following additional variables are required depending on which backend you"},{"line_number":48,"context_line":"intend to use:"}],"source_content_type":"text/x-rst","patch_set":3,"id":"3fa7e38b_46942036","line":45,"range":{"start_line":42,"start_character":0,"end_line":45,"end_character":47},"updated":"2019-11-25 15:53:49.000000000","message":"Do we need some equivalent docs for cinder?","commit_id":"0f604be1f6ad16b0a2c52eebf0472987278cde74"},{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"730624da1887b5153dbf44ae3068f2905b22dd36","unresolved":false,"context_lines":[{"line_number":39,"context_line":""},{"line_number":40,"context_line":".. important::"},{"line_number":41,"context_line":""},{"line_number":42,"context_line":"   If multiple nodes are assigned to be Designate workers then you must"},{"line_number":43,"context_line":"   enable a supported coordination backend, currently either \u0027redis\u0027 or"},{"line_number":44,"context_line":"   \u0027etcd3\u0027. The backend must be set by the"},{"line_number":45,"context_line":"   ``designate_coordination_backend`` variable."},{"line_number":46,"context_line":""},{"line_number":47,"context_line":"The following additional variables are required depending on which backend you"},{"line_number":48,"context_line":"intend to use:"}],"source_content_type":"text/x-rst","patch_set":3,"id":"3fa7e38b_8113e2b7","line":45,"range":{"start_line":42,"start_character":0,"end_line":45,"end_character":47},"in_reply_to":"3fa7e38b_46942036","updated":"2019-11-25 16:43:50.000000000","message":"Mhm, this is missing from them.","commit_id":"0f604be1f6ad16b0a2c52eebf0472987278cde74"}],"etc/kolla/globals.yml":[{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"402a3d2e8c93b13e6c42257a679bd8680702c2a6","unresolved":false,"context_lines":[{"line_number":487,"context_line":"# Valid options are [ bind9 ]"},{"line_number":488,"context_line":"#designate_backend: \"bind9\""},{"line_number":489,"context_line":"#designate_ns_record: \"sample.openstack.org\""},{"line_number":490,"context_line":"# Valid options are [ \u0027\u0027, redis, 3 ]"},{"line_number":491,"context_line":"# etcd3 coordination backend support not available in binary images"},{"line_number":492,"context_line":"#designate_coordination_backend: \"\""},{"line_number":493,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":3,"id":"3fa7e38b_269d6456","line":490,"range":{"start_line":490,"start_character":33,"end_line":490,"end_character":34},"updated":"2019-11-25 15:53:49.000000000","message":"etcd3","commit_id":"0f604be1f6ad16b0a2c52eebf0472987278cde74"},{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"730624da1887b5153dbf44ae3068f2905b22dd36","unresolved":false,"context_lines":[{"line_number":487,"context_line":"# Valid options are [ bind9 ]"},{"line_number":488,"context_line":"#designate_backend: \"bind9\""},{"line_number":489,"context_line":"#designate_ns_record: \"sample.openstack.org\""},{"line_number":490,"context_line":"# Valid options are [ \u0027\u0027, redis, 3 ]"},{"line_number":491,"context_line":"# etcd3 coordination backend support not available in binary images"},{"line_number":492,"context_line":"#designate_coordination_backend: \"\""},{"line_number":493,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":3,"id":"3fa7e38b_a1ba9ebc","line":490,"range":{"start_line":490,"start_character":33,"end_line":490,"end_character":34},"in_reply_to":"3fa7e38b_269d6456","updated":"2019-11-25 16:43:50.000000000","message":"haha, good one","commit_id":"0f604be1f6ad16b0a2c52eebf0472987278cde74"}],"releasenotes/notes/coordination-backend-no-default-8a58a2f5eddd1f57.yaml":[{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"402a3d2e8c93b13e6c42257a679bd8680702c2a6","unresolved":false,"context_lines":[{"line_number":5,"context_line":"    denoting no coordination. This has been changed to fix default deploys"},{"line_number":6,"context_line":"    with binary images which do not provide etcd3 python module required"},{"line_number":7,"context_line":"    by coordination automatically when etcd was enabled (for example for Zun)."},{"line_number":8,"context_line":"    Additionally it removes the surprise vector when enabling independent service"},{"line_number":9,"context_line":"    changes config in not obvious ways."},{"line_number":10,"context_line":"    See `bug 1852086"},{"line_number":11,"context_line":"    \u003chttps://bugs.launchpad.net/kolla-ansible/+bug/1852086\u003e`__ for details."},{"line_number":12,"context_line":"  - |"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"3fa7e38b_c6c0102e","line":9,"range":{"start_line":8,"start_character":4,"end_line":9,"end_character":39},"updated":"2019-11-25 15:53:49.000000000","message":"I\u0027m not sure about this argument. We do it a lot to make things work out of the box without providing every config option.","commit_id":"0f604be1f6ad16b0a2c52eebf0472987278cde74"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"8dd3631c2834d42044b460fe021da251dd8c9219","unresolved":false,"context_lines":[{"line_number":5,"context_line":"    denoting no coordination. This has been changed to fix default deploys"},{"line_number":6,"context_line":"    with binary images which do not provide etcd3 python module required"},{"line_number":7,"context_line":"    by coordination automatically when etcd was enabled (for example for Zun)."},{"line_number":8,"context_line":"    Additionally it removes the surprise vector when enabling independent service"},{"line_number":9,"context_line":"    changes config in not obvious ways."},{"line_number":10,"context_line":"    See `bug 1852086"},{"line_number":11,"context_line":"    \u003chttps://bugs.launchpad.net/kolla-ansible/+bug/1852086\u003e`__ for details."},{"line_number":12,"context_line":"  - |"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"3fa7e38b_2d0f75e1","line":9,"range":{"start_line":8,"start_character":4,"end_line":9,"end_character":39},"in_reply_to":"3fa7e38b_21c6ae4a","updated":"2019-11-26 12:06:12.000000000","message":"Yes, although etcd is now a \u0027base\u0027 service for OpenStack.","commit_id":"0f604be1f6ad16b0a2c52eebf0472987278cde74"},{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"dfb6e0e3b44b867a21c1c9fb6055cc9a09173a36","unresolved":false,"context_lines":[{"line_number":5,"context_line":"    denoting no coordination. This has been changed to fix default deploys"},{"line_number":6,"context_line":"    with binary images which do not provide etcd3 python module required"},{"line_number":7,"context_line":"    by coordination automatically when etcd was enabled (for example for Zun)."},{"line_number":8,"context_line":"    Additionally it removes the surprise vector when enabling independent service"},{"line_number":9,"context_line":"    changes config in not obvious ways."},{"line_number":10,"context_line":"    See `bug 1852086"},{"line_number":11,"context_line":"    \u003chttps://bugs.launchpad.net/kolla-ansible/+bug/1852086\u003e`__ for details."},{"line_number":12,"context_line":"  - |"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"3fa7e38b_c7c78311","line":9,"range":{"start_line":8,"start_character":4,"end_line":9,"end_character":39},"in_reply_to":"3fa7e38b_2d0f75e1","updated":"2019-11-27 19:17:22.000000000","message":"Yeah, etcd is but not etcd3 driver it seems... No idea how to best approach this issue.","commit_id":"0f604be1f6ad16b0a2c52eebf0472987278cde74"},{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"730624da1887b5153dbf44ae3068f2905b22dd36","unresolved":false,"context_lines":[{"line_number":5,"context_line":"    denoting no coordination. This has been changed to fix default deploys"},{"line_number":6,"context_line":"    with binary images which do not provide etcd3 python module required"},{"line_number":7,"context_line":"    by coordination automatically when etcd was enabled (for example for Zun)."},{"line_number":8,"context_line":"    Additionally it removes the surprise vector when enabling independent service"},{"line_number":9,"context_line":"    changes config in not obvious ways."},{"line_number":10,"context_line":"    See `bug 1852086"},{"line_number":11,"context_line":"    \u003chttps://bugs.launchpad.net/kolla-ansible/+bug/1852086\u003e`__ for details."},{"line_number":12,"context_line":"  - |"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"3fa7e38b_21c6ae4a","line":9,"range":{"start_line":8,"start_character":4,"end_line":9,"end_character":39},"in_reply_to":"3fa7e38b_c6c0102e","updated":"2019-11-25 16:43:50.000000000","message":"Hmm, looking at it again, the minimum viable variant would be to keep redis but not etcd in here as \"default\". As redis is actually more supported...","commit_id":"0f604be1f6ad16b0a2c52eebf0472987278cde74"}]}