)]}'
{"tests/deploy.sh":[{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"28fe1d348b95094203ec93ce201f88c97cf3b743","unresolved":false,"context_lines":[{"line_number":23,"context_line":"    tools/kolla-ansible -i ${RAW_INVENTORY} -vvv post-deploy \u0026\u003e /tmp/logs/ansible/post-deploy"},{"line_number":24,"context_line":"    tools/kolla-ansible -i ${RAW_INVENTORY} -vvv check \u0026\u003e /tmp/logs/ansible/check-deploy"},{"line_number":25,"context_line":""},{"line_number":26,"context_line":"    if [[ ${OS_CORE_ENABLED} \u003d\u003d \"True\" ]]; then"},{"line_number":27,"context_line":"        init_runonce"},{"line_number":28,"context_line":"    fi"},{"line_number":29,"context_line":"}"},{"line_number":30,"context_line":""},{"line_number":31,"context_line":"function init_runonce {"}],"source_content_type":"text/x-sh","patch_set":8,"id":"3fa7e38b_99fe2404","line":28,"range":{"start_line":26,"start_character":0,"end_line":28,"end_character":6},"updated":"2019-11-21 16:00:09.000000000","message":"Or a new script?","commit_id":"a724fc52d2e361298583534e6813abd9cb8fc06b"},{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"d4f2a2e5ab2cc2031c2d6eecc3fcd89a96e3e9f3","unresolved":false,"context_lines":[{"line_number":23,"context_line":"    tools/kolla-ansible -i ${RAW_INVENTORY} -vvv post-deploy \u0026\u003e /tmp/logs/ansible/post-deploy"},{"line_number":24,"context_line":"    tools/kolla-ansible -i ${RAW_INVENTORY} -vvv check \u0026\u003e /tmp/logs/ansible/check-deploy"},{"line_number":25,"context_line":""},{"line_number":26,"context_line":"    if [[ ${OS_CORE_ENABLED} \u003d\u003d \"True\" ]]; then"},{"line_number":27,"context_line":"        init_runonce"},{"line_number":28,"context_line":"    fi"},{"line_number":29,"context_line":"}"},{"line_number":30,"context_line":""},{"line_number":31,"context_line":"function init_runonce {"}],"source_content_type":"text/x-sh","patch_set":8,"id":"3fa7e38b_1c130267","line":28,"range":{"start_line":26,"start_character":0,"end_line":28,"end_character":6},"in_reply_to":"3fa7e38b_99fe2404","updated":"2019-11-21 16:37:20.000000000","message":"New script sounds good. I did the other one already. Just that the thought came later than this.","commit_id":"a724fc52d2e361298583534e6813abd9cb8fc06b"}],"tests/run.yml":[{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"28fe1d348b95094203ec93ce201f88c97cf3b743","unresolved":false,"context_lines":[{"line_number":214,"context_line":"            chdir: \"{{ kolla_ansible_src_dir }}\""},{"line_number":215,"context_line":"          environment:"},{"line_number":216,"context_line":"            ACTION: \"{{ scenario }}\""},{"line_number":217,"context_line":"          when: scenario not in [\u0027ironic\u0027, \u0027mariadb\u0027, \u0027scenario_nfv\u0027, \u0027qinling\u0027]"},{"line_number":218,"context_line":""},{"line_number":219,"context_line":"        - name: Run test-dashboard.sh script"},{"line_number":220,"context_line":"          script:"}],"source_content_type":"text/x-yaml","patch_set":8,"id":"3fa7e38b_193a34e5","line":217,"range":{"start_line":217,"start_character":10,"end_line":217,"end_character":14},"updated":"2019-11-21 16:00:09.000000000","message":"maybe a little more future proof:\n\n- openstack_core_enabled\n- scenario not in [\u0027ironic\u0027, \u0027scenario_nfv\u0027]","commit_id":"a724fc52d2e361298583534e6813abd9cb8fc06b"},{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"d4f2a2e5ab2cc2031c2d6eecc3fcd89a96e3e9f3","unresolved":false,"context_lines":[{"line_number":214,"context_line":"            chdir: \"{{ kolla_ansible_src_dir }}\""},{"line_number":215,"context_line":"          environment:"},{"line_number":216,"context_line":"            ACTION: \"{{ scenario }}\""},{"line_number":217,"context_line":"          when: scenario not in [\u0027ironic\u0027, \u0027mariadb\u0027, \u0027scenario_nfv\u0027, \u0027qinling\u0027]"},{"line_number":218,"context_line":""},{"line_number":219,"context_line":"        - name: Run test-dashboard.sh script"},{"line_number":220,"context_line":"          script:"}],"source_content_type":"text/x-yaml","patch_set":8,"id":"3fa7e38b_370e17e4","line":217,"range":{"start_line":217,"start_character":10,"end_line":217,"end_character":14},"in_reply_to":"3fa7e38b_193a34e5","updated":"2019-11-21 16:37:20.000000000","message":"Good idea, thanks.","commit_id":"a724fc52d2e361298583534e6813abd9cb8fc06b"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"28fe1d348b95094203ec93ce201f88c97cf3b743","unresolved":false,"context_lines":[{"line_number":223,"context_line":"            chdir: \"{{ kolla_ansible_src_dir }}\""},{"line_number":224,"context_line":"          environment:"},{"line_number":225,"context_line":"            ACTION: \"{{ scenario }}\""},{"line_number":226,"context_line":"          when: scenario not in [\u0027ironic\u0027, \u0027mariadb\u0027, \u0027scenario_nfv\u0027]"},{"line_number":227,"context_line":""},{"line_number":228,"context_line":"        - name: Run test-zun.sh script"},{"line_number":229,"context_line":"          script:"}],"source_content_type":"text/x-yaml","patch_set":8,"id":"3fa7e38b_391a907c","line":226,"range":{"start_line":226,"start_character":34,"end_line":226,"end_character":40},"updated":"2019-11-21 16:00:09.000000000","message":"Could argue we get some minimal coverage of dashboard with ironic-ui installed. Same with NFV. Maybe one for another time.","commit_id":"a724fc52d2e361298583534e6813abd9cb8fc06b"},{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"d4f2a2e5ab2cc2031c2d6eecc3fcd89a96e3e9f3","unresolved":false,"context_lines":[{"line_number":223,"context_line":"            chdir: \"{{ kolla_ansible_src_dir }}\""},{"line_number":224,"context_line":"          environment:"},{"line_number":225,"context_line":"            ACTION: \"{{ scenario }}\""},{"line_number":226,"context_line":"          when: scenario not in [\u0027ironic\u0027, \u0027mariadb\u0027, \u0027scenario_nfv\u0027]"},{"line_number":227,"context_line":""},{"line_number":228,"context_line":"        - name: Run test-zun.sh script"},{"line_number":229,"context_line":"          script:"}],"source_content_type":"text/x-yaml","patch_set":8,"id":"3fa7e38b_77024f0b","line":226,"range":{"start_line":226,"start_character":34,"end_line":226,"end_character":40},"in_reply_to":"3fa7e38b_391a907c","updated":"2019-11-21 16:37:20.000000000","message":"Yeah, I wanted to keep the original behavior but you are right.","commit_id":"a724fc52d2e361298583534e6813abd9cb8fc06b"},{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"27eef441ef31d6cfb2de90436175faa9ebfe6e84","unresolved":false,"context_lines":[{"line_number":10,"context_line":"    - name: set facts for commonly used variables"},{"line_number":11,"context_line":"      vars:"},{"line_number":12,"context_line":"        # NOTE(yoctozepto): needed here to use in other facts too"},{"line_number":13,"context_line":"        openstack_core_enabled: \"{{ scenario not in [\u0027bifrost\u0027, \u0027mariadb\u0027, \u0027qinling\u0027] }}\""},{"line_number":14,"context_line":"      set_fact:"},{"line_number":15,"context_line":"        kolla_inventory_path: \"/etc/kolla/inventory\""},{"line_number":16,"context_line":"        logs_dir: \"/tmp/logs\""}],"source_content_type":"text/x-yaml","patch_set":10,"id":"3fa7e38b_98da90e6","line":13,"range":{"start_line":13,"start_character":45,"end_line":13,"end_character":51},"updated":"2019-11-22 10:02:31.000000000","message":"I have a bit of worry when using negative approach - scenario not in, with a big amount of scenarios we end up with maintaining longer list of scenarios that it doesn\u0027t run in, and takes longer time to understand if in particular scenario this should do something or not...","commit_id":"afacc7754542bf2ad9884305ede013741c0e4a9c"},{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"302c19da26d2e97e88e772924e7390d0939711d5","unresolved":false,"context_lines":[{"line_number":10,"context_line":"    - name: set facts for commonly used variables"},{"line_number":11,"context_line":"      vars:"},{"line_number":12,"context_line":"        # NOTE(yoctozepto): needed here to use in other facts too"},{"line_number":13,"context_line":"        openstack_core_enabled: \"{{ scenario not in [\u0027bifrost\u0027, \u0027mariadb\u0027, \u0027qinling\u0027] }}\""},{"line_number":14,"context_line":"      set_fact:"},{"line_number":15,"context_line":"        kolla_inventory_path: \"/etc/kolla/inventory\""},{"line_number":16,"context_line":"        logs_dir: \"/tmp/logs\""}],"source_content_type":"text/x-yaml","patch_set":10,"id":"3fa7e38b_cb5594c3","line":13,"range":{"start_line":13,"start_character":45,"end_line":13,"end_character":51},"in_reply_to":"3fa7e38b_98da90e6","updated":"2019-11-22 10:45:38.000000000","message":"That\u0027s my worry too. We had this negative statements all around. I would opt for some trait-based approach where you declaratively specify scenario parts but it needs some more thought yet.","commit_id":"afacc7754542bf2ad9884305ede013741c0e4a9c"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"3f33fffe60fd2b778bcf9968ae1cf24417cd2e68","unresolved":false,"context_lines":[{"line_number":241,"context_line":"          when:"},{"line_number":242,"context_line":"            - openstack_core_enabled"},{"line_number":243,"context_line":"            # NOTE(yoctozepto): not interesting in the scenarios below"},{"line_number":244,"context_line":"            - scenario not in [\u0027ironic\u0027, \u0027scenario_nfv\u0027]"},{"line_number":245,"context_line":""},{"line_number":246,"context_line":"        - name: Run test-zun.sh script"},{"line_number":247,"context_line":"          script:"}],"source_content_type":"text/x-yaml","patch_set":10,"id":"3fa7e38b_182b00eb","line":244,"updated":"2019-11-22 09:58:29.000000000","message":"Should probably add zun and masakari here too.","commit_id":"afacc7754542bf2ad9884305ede013741c0e4a9c"},{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"302c19da26d2e97e88e772924e7390d0939711d5","unresolved":false,"context_lines":[{"line_number":241,"context_line":"          when:"},{"line_number":242,"context_line":"            - openstack_core_enabled"},{"line_number":243,"context_line":"            # NOTE(yoctozepto): not interesting in the scenarios below"},{"line_number":244,"context_line":"            - scenario not in [\u0027ironic\u0027, \u0027scenario_nfv\u0027]"},{"line_number":245,"context_line":""},{"line_number":246,"context_line":"        - name: Run test-zun.sh script"},{"line_number":247,"context_line":"          script:"}],"source_content_type":"text/x-yaml","patch_set":10,"id":"3fa7e38b_ab45b816","line":244,"in_reply_to":"3fa7e38b_182b00eb","updated":"2019-11-22 10:45:38.000000000","message":"+1 for zun, not sure how much masakari does for it...\n\nIn fact, one could argue that we don\u0027t really need full init-runonce in all scenarios either, only for some (still, we would need it for ironic, but not e.g. for qinling). Decisions, decisions...","commit_id":"afacc7754542bf2ad9884305ede013741c0e4a9c"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"6f34257b4a6814e9ff5d3a19ced67570529912f9","unresolved":false,"context_lines":[{"line_number":185,"context_line":"    # job)."},{"line_number":186,"context_line":"    - name: Run setup_gate.sh script"},{"line_number":187,"context_line":"      script:"},{"line_number":188,"context_line":"        cmd: ../tests/setup_gate.sh"},{"line_number":189,"context_line":"        executable: /bin/bash"},{"line_number":190,"context_line":"        chdir: \"{{ kolla_ansible_src_dir }}\""},{"line_number":191,"context_line":"      environment:"}],"source_content_type":"text/x-yaml","patch_set":21,"id":"3fa7e38b_0d94f935","line":188,"range":{"start_line":188,"start_character":13,"end_line":188,"end_character":22},"updated":"2019-11-26 12:29:17.000000000","message":"nit: ../tests/ not required","commit_id":"c336a17d7ea7c23e69ef13dbc4e21cd6113d68fc"},{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"566c9190945d4373147348a632d59ed67e2dfcaa","unresolved":false,"context_lines":[{"line_number":185,"context_line":"    # job)."},{"line_number":186,"context_line":"    - name: Run setup_gate.sh script"},{"line_number":187,"context_line":"      script:"},{"line_number":188,"context_line":"        cmd: ../tests/setup_gate.sh"},{"line_number":189,"context_line":"        executable: /bin/bash"},{"line_number":190,"context_line":"        chdir: \"{{ kolla_ansible_src_dir }}\""},{"line_number":191,"context_line":"      environment:"}],"source_content_type":"text/x-yaml","patch_set":21,"id":"3fa7e38b_79052bc1","line":188,"range":{"start_line":188,"start_character":13,"end_line":188,"end_character":22},"in_reply_to":"3fa7e38b_0d94f935","updated":"2019-11-26 15:45:46.000000000","message":"hah, right","commit_id":"c336a17d7ea7c23e69ef13dbc4e21cd6113d68fc"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"6f34257b4a6814e9ff5d3a19ced67570529912f9","unresolved":false,"context_lines":[{"line_number":419,"context_line":"- hosts: all"},{"line_number":420,"context_line":"  any_errors_fatal: true"},{"line_number":421,"context_line":"  tasks:"},{"line_number":422,"context_line":"    - name: Post-deploy/upgrade sanity checks"},{"line_number":423,"context_line":"      block:"},{"line_number":424,"context_line":"        - name: Run check-failure.sh script"},{"line_number":425,"context_line":"          shell:"},{"line_number":426,"context_line":"            cmd: tests/check-failure.sh"}],"source_content_type":"text/x-yaml","patch_set":21,"id":"3fa7e38b_0dfb997b","line":423,"range":{"start_line":422,"start_character":0,"end_line":423,"end_character":12},"updated":"2019-11-26 12:29:17.000000000","message":"Should there be some condition applied here? is_upgrade?","commit_id":"c336a17d7ea7c23e69ef13dbc4e21cd6113d68fc"},{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"566c9190945d4373147348a632d59ed67e2dfcaa","unresolved":false,"context_lines":[{"line_number":419,"context_line":"- hosts: all"},{"line_number":420,"context_line":"  any_errors_fatal: true"},{"line_number":421,"context_line":"  tasks:"},{"line_number":422,"context_line":"    - name: Post-deploy/upgrade sanity checks"},{"line_number":423,"context_line":"      block:"},{"line_number":424,"context_line":"        - name: Run check-failure.sh script"},{"line_number":425,"context_line":"          shell:"},{"line_number":426,"context_line":"            cmd: tests/check-failure.sh"}],"source_content_type":"text/x-yaml","patch_set":21,"id":"3fa7e38b_d9f3ffe7","line":423,"range":{"start_line":422,"start_character":0,"end_line":423,"end_character":12},"in_reply_to":"3fa7e38b_0dfb997b","updated":"2019-11-26 15:45:46.000000000","message":"nope, just to name it","commit_id":"c336a17d7ea7c23e69ef13dbc4e21cd6113d68fc"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"6f34257b4a6814e9ff5d3a19ced67570529912f9","unresolved":false,"context_lines":[{"line_number":474,"context_line":"            cmd: tests/check-logs.sh"},{"line_number":475,"context_line":"            executable: /bin/bash"},{"line_number":476,"context_line":"            chdir: \"{{ kolla_ansible_src_dir }}\""},{"line_number":477,"context_line":"      when: not is_upgrade"}],"source_content_type":"text/x-yaml","patch_set":21,"id":"3fa7e38b_8dc46962","line":477,"range":{"start_line":477,"start_character":12,"end_line":477,"end_character":26},"updated":"2019-11-26 12:29:17.000000000","message":"also scenario !\u003d \"bifrost\"","commit_id":"c336a17d7ea7c23e69ef13dbc4e21cd6113d68fc"},{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"566c9190945d4373147348a632d59ed67e2dfcaa","unresolved":false,"context_lines":[{"line_number":474,"context_line":"            cmd: tests/check-logs.sh"},{"line_number":475,"context_line":"            executable: /bin/bash"},{"line_number":476,"context_line":"            chdir: \"{{ kolla_ansible_src_dir }}\""},{"line_number":477,"context_line":"      when: not is_upgrade"}],"source_content_type":"text/x-yaml","patch_set":21,"id":"3fa7e38b_59294f38","line":477,"range":{"start_line":477,"start_character":12,"end_line":477,"end_character":26},"in_reply_to":"3fa7e38b_8dc46962","updated":"2019-11-26 15:45:46.000000000","message":"right you are","commit_id":"c336a17d7ea7c23e69ef13dbc4e21cd6113d68fc"}],"tests/test-dashboard.sh":[{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"3f33fffe60fd2b778bcf9968ae1cf24417cd2e68","unresolved":false,"context_lines":[{"line_number":49,"context_line":"    test_dashboard_logged \u003e $log_file 2\u003e\u00261"},{"line_number":50,"context_line":"    result\u003d$?"},{"line_number":51,"context_line":"    if [[ $result !\u003d 0 ]]; then"},{"line_number":52,"context_line":"        echo \"Testing dashboard failed. See ansible/test-dashboard for details\""},{"line_number":53,"context_line":"    else"},{"line_number":54,"context_line":"        echo \"Successfully tested dashboard. See ansible/test-dashboard for details\""},{"line_number":55,"context_line":"    fi"}],"source_content_type":"text/x-sh","patch_set":10,"id":"3fa7e38b_b822ecff","line":52,"range":{"start_line":52,"start_character":44,"end_line":52,"end_character":66},"updated":"2019-11-22 09:58:29.000000000","message":"This should really use $log_file. Although ansible/test-dashboard is better than /tmp/logs/ansible/test-dashboard from a CI debugger\u0027s perspective.","commit_id":"afacc7754542bf2ad9884305ede013741c0e4a9c"},{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"302c19da26d2e97e88e772924e7390d0939711d5","unresolved":false,"context_lines":[{"line_number":49,"context_line":"    test_dashboard_logged \u003e $log_file 2\u003e\u00261"},{"line_number":50,"context_line":"    result\u003d$?"},{"line_number":51,"context_line":"    if [[ $result !\u003d 0 ]]; then"},{"line_number":52,"context_line":"        echo \"Testing dashboard failed. See ansible/test-dashboard for details\""},{"line_number":53,"context_line":"    else"},{"line_number":54,"context_line":"        echo \"Successfully tested dashboard. See ansible/test-dashboard for details\""},{"line_number":55,"context_line":"    fi"}],"source_content_type":"text/x-sh","patch_set":10,"id":"3fa7e38b_4be20432","line":52,"range":{"start_line":52,"start_character":44,"end_line":52,"end_character":66},"in_reply_to":"3fa7e38b_b822ecff","updated":"2019-11-22 10:45:38.000000000","message":"It\u0027s the same we have everywhere else. Not that important.","commit_id":"afacc7754542bf2ad9884305ede013741c0e4a9c"}],"tests/test-openstack.sh":[{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"3f33fffe60fd2b778bcf9968ae1cf24417cd2e68","unresolved":false,"context_lines":[{"line_number":91,"context_line":"    test_openstack_logged \u003e $log_file 2\u003e\u00261"},{"line_number":92,"context_line":"    result\u003d$?"},{"line_number":93,"context_line":"    if [[ $result !\u003d 0 ]]; then"},{"line_number":94,"context_line":"        echo \"Testing OpenStack failed. See ansible/test-openstack for details\""},{"line_number":95,"context_line":"    else"},{"line_number":96,"context_line":"        echo \"Successfully tested OpenStack. See ansible/test-openstack for details\""},{"line_number":97,"context_line":"    fi"}],"source_content_type":"text/x-sh","patch_set":10,"id":"3fa7e38b_b8674c51","line":94,"range":{"start_line":94,"start_character":44,"end_line":94,"end_character":66},"updated":"2019-11-22 09:58:29.000000000","message":"same issue, probably elsewhere too","commit_id":"afacc7754542bf2ad9884305ede013741c0e4a9c"}],"tools/setup_gate.sh":[{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"6c90f296bb7ff00e0b1ee902c3f78315e10e21ef","unresolved":false,"context_lines":[{"line_number":14,"context_line":"    ~/openstackclient-venv/bin/pip install -U pip"},{"line_number":15,"context_line":"    ~/openstackclient-venv/bin/pip install python-openstackclient"},{"line_number":16,"context_line":"    ~/openstackclient-venv/bin/pip install python-heatclient"},{"line_number":17,"context_line":"    if [[ $SCENARIO \u003d\u003d zun ]]; then"},{"line_number":18,"context_line":"        ~/openstackclient-venv/bin/pip install python-zunclient"},{"line_number":19,"context_line":"    fi"},{"line_number":20,"context_line":"    if [[ $SCENARIO \u003d\u003d ironic ]]; then"}],"source_content_type":"text/x-sh","patch_set":23,"id":"3fa7e38b_d66097a7","line":17,"updated":"2019-11-27 18:50:28.000000000","message":"Is it a huge overhead to install all those clients everytime? let\u0027s just add it in one command and be gone with all those if\u0027s","commit_id":"a2fc684164cb5169492d6e0c007ad006f814492c"},{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"d057b99c9e1dd1477002fc081ff5298771b4924b","unresolved":false,"context_lines":[{"line_number":14,"context_line":"    ~/openstackclient-venv/bin/pip install -U pip"},{"line_number":15,"context_line":"    ~/openstackclient-venv/bin/pip install python-openstackclient"},{"line_number":16,"context_line":"    ~/openstackclient-venv/bin/pip install python-heatclient"},{"line_number":17,"context_line":"    if [[ $SCENARIO \u003d\u003d zun ]]; then"},{"line_number":18,"context_line":"        ~/openstackclient-venv/bin/pip install python-zunclient"},{"line_number":19,"context_line":"    fi"},{"line_number":20,"context_line":"    if [[ $SCENARIO \u003d\u003d ironic ]]; then"}],"source_content_type":"text/x-sh","patch_set":23,"id":"3fa7e38b_a7012770","line":17,"in_reply_to":"3fa7e38b_07c27b54","updated":"2019-11-27 19:07:11.000000000","message":"If it will fail, it will fail on python-openstackclient or pip upgrade :D","commit_id":"a2fc684164cb5169492d6e0c007ad006f814492c"},{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"898d74f273444b2cc6851e2c14f382828106aa3f","unresolved":false,"context_lines":[{"line_number":14,"context_line":"    ~/openstackclient-venv/bin/pip install -U pip"},{"line_number":15,"context_line":"    ~/openstackclient-venv/bin/pip install python-openstackclient"},{"line_number":16,"context_line":"    ~/openstackclient-venv/bin/pip install python-heatclient"},{"line_number":17,"context_line":"    if [[ $SCENARIO \u003d\u003d zun ]]; then"},{"line_number":18,"context_line":"        ~/openstackclient-venv/bin/pip install python-zunclient"},{"line_number":19,"context_line":"    fi"},{"line_number":20,"context_line":"    if [[ $SCENARIO \u003d\u003d ironic ]]; then"}],"source_content_type":"text/x-sh","patch_set":23,"id":"3fa7e38b_426f01fa","line":17,"in_reply_to":"3fa7e38b_a7012770","updated":"2019-11-27 20:31:28.000000000","message":"One can easily imagine zun or masakari clients becoming b0rken and breaking all jobs instead of just theirs.","commit_id":"a2fc684164cb5169492d6e0c007ad006f814492c"},{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"bb98fdab83815670f62e52eb97d29d25e1b6f313","unresolved":false,"context_lines":[{"line_number":14,"context_line":"    ~/openstackclient-venv/bin/pip install -U pip"},{"line_number":15,"context_line":"    ~/openstackclient-venv/bin/pip install python-openstackclient"},{"line_number":16,"context_line":"    ~/openstackclient-venv/bin/pip install python-heatclient"},{"line_number":17,"context_line":"    if [[ $SCENARIO \u003d\u003d zun ]]; then"},{"line_number":18,"context_line":"        ~/openstackclient-venv/bin/pip install python-zunclient"},{"line_number":19,"context_line":"    fi"},{"line_number":20,"context_line":"    if [[ $SCENARIO \u003d\u003d ironic ]]; then"}],"source_content_type":"text/x-sh","patch_set":23,"id":"3fa7e38b_07c27b54","line":17,"in_reply_to":"3fa7e38b_d66097a7","updated":"2019-11-27 18:58:01.000000000","message":"The reasoning is not to affect builds if their install fails. ;-)","commit_id":"a2fc684164cb5169492d6e0c007ad006f814492c"},{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"6c90f296bb7ff00e0b1ee902c3f78315e10e21ef","unresolved":false,"context_lines":[{"line_number":26,"context_line":"}"},{"line_number":27,"context_line":""},{"line_number":28,"context_line":"function setup_config {"},{"line_number":29,"context_line":"    if [[ $SCENARIO !\u003d \"bifrost\" ]]; then"},{"line_number":30,"context_line":"        GATE_IMAGES\u003d\"cron,fluentd,glance,haproxy,keepalived,keystone,kolla-toolbox,mariadb,memcached,neutron,nova,openvswitch,rabbitmq,horizon,chrony,heat,placement\""},{"line_number":31,"context_line":"    else"},{"line_number":32,"context_line":"        GATE_IMAGES\u003d\"bifrost\""}],"source_content_type":"text/x-sh","patch_set":23,"id":"3fa7e38b_a75b67f7","line":29,"updated":"2019-11-27 18:50:28.000000000","message":"Can we clean it up in some way, while we\u0027re at it? e.g. set base_gate_images and then do a case statement sorted alphabetically?","commit_id":"a2fc684164cb5169492d6e0c007ad006f814492c"},{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"d057b99c9e1dd1477002fc081ff5298771b4924b","unresolved":false,"context_lines":[{"line_number":26,"context_line":"}"},{"line_number":27,"context_line":""},{"line_number":28,"context_line":"function setup_config {"},{"line_number":29,"context_line":"    if [[ $SCENARIO !\u003d \"bifrost\" ]]; then"},{"line_number":30,"context_line":"        GATE_IMAGES\u003d\"cron,fluentd,glance,haproxy,keepalived,keystone,kolla-toolbox,mariadb,memcached,neutron,nova,openvswitch,rabbitmq,horizon,chrony,heat,placement\""},{"line_number":31,"context_line":"    else"},{"line_number":32,"context_line":"        GATE_IMAGES\u003d\"bifrost\""}],"source_content_type":"text/x-sh","patch_set":23,"id":"3fa7e38b_8700ab68","line":29,"in_reply_to":"3fa7e38b_2790d74f","updated":"2019-11-27 19:07:11.000000000","message":"Sure, just asking - this change could be split into several changes - but let\u0027s not be grumpy :-)","commit_id":"a2fc684164cb5169492d6e0c007ad006f814492c"},{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"bb98fdab83815670f62e52eb97d29d25e1b6f313","unresolved":false,"context_lines":[{"line_number":26,"context_line":"}"},{"line_number":27,"context_line":""},{"line_number":28,"context_line":"function setup_config {"},{"line_number":29,"context_line":"    if [[ $SCENARIO !\u003d \"bifrost\" ]]; then"},{"line_number":30,"context_line":"        GATE_IMAGES\u003d\"cron,fluentd,glance,haproxy,keepalived,keystone,kolla-toolbox,mariadb,memcached,neutron,nova,openvswitch,rabbitmq,horizon,chrony,heat,placement\""},{"line_number":31,"context_line":"    else"},{"line_number":32,"context_line":"        GATE_IMAGES\u003d\"bifrost\""}],"source_content_type":"text/x-sh","patch_set":23,"id":"3fa7e38b_2790d74f","line":29,"in_reply_to":"3fa7e38b_a75b67f7","updated":"2019-11-27 18:58:01.000000000","message":"I would prefer this in a separate change. Already basing Qinling and Swift on it and hrw is grumpy. :-)","commit_id":"a2fc684164cb5169492d6e0c007ad006f814492c"}],"zuul.d/base.yaml":[{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"3f33fffe60fd2b778bcf9968ae1cf24417cd2e68","unresolved":false,"context_lines":[{"line_number":82,"context_line":"    voting: false"},{"line_number":83,"context_line":"    files:"},{"line_number":84,"context_line":"      - ^ansible/roles/qinling/"},{"line_number":85,"context_line":"      - ^tests/test-qinling.sh"},{"line_number":86,"context_line":"    vars:"},{"line_number":87,"context_line":"      scenario: qinling"}],"source_content_type":"text/x-yaml","patch_set":10,"id":"3fa7e38b_38659c45","line":85,"range":{"start_line":85,"start_character":8,"end_line":85,"end_character":30},"updated":"2019-11-22 09:58:29.000000000","message":"\u0026 dashboard","commit_id":"afacc7754542bf2ad9884305ede013741c0e4a9c"},{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"302c19da26d2e97e88e772924e7390d0939711d5","unresolved":false,"context_lines":[{"line_number":82,"context_line":"    voting: false"},{"line_number":83,"context_line":"    files:"},{"line_number":84,"context_line":"      - ^ansible/roles/qinling/"},{"line_number":85,"context_line":"      - ^tests/test-qinling.sh"},{"line_number":86,"context_line":"    vars:"},{"line_number":87,"context_line":"      scenario: qinling"}],"source_content_type":"text/x-yaml","patch_set":10,"id":"3fa7e38b_6bdd806b","line":85,"range":{"start_line":85,"start_character":8,"end_line":85,"end_character":30},"in_reply_to":"3fa7e38b_38659c45","updated":"2019-11-22 10:45:38.000000000","message":"\u0026 in many other places, yeah","commit_id":"afacc7754542bf2ad9884305ede013741c0e4a9c"}],"zuul.d/project.yaml":[{"author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"tag":"autogenerated:zuul:check","change_message_id":"e40f63f11e93a8bdc5be63e820b5a092d8d491f5","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"- project:"},{"line_number":3,"context_line":"    check:"},{"line_number":4,"context_line":"      jobs:"},{"line_number":5,"context_line":"        - kolla-ansible-centos-source-qinling"},{"line_number":6,"context_line":"        - kolla-ansible-ubuntu-source-qinling"},{"line_number":7,"context_line":"    gate:"},{"line_number":8,"context_line":"      queue: kolla"},{"line_number":9,"context_line":"      jobs:"},{"line_number":10,"context_line":"        - kolla-ansible-centos-source"},{"line_number":11,"context_line":"        - kolla-ansible-ubuntu-source"},{"line_number":12,"context_line":"        - kolla-ansible-centos-source-upgrade"},{"line_number":13,"context_line":"        - kolla-ansible-ubuntu-source-upgrade"},{"line_number":14,"context_line":"    periodic:"},{"line_number":15,"context_line":"      jobs:"},{"line_number":16,"context_line":"        - kolla-ansible-bifrost-centos-source"},{"line_number":17,"context_line":"        - kolla-ansible-centos-source-zun"},{"line_number":18,"context_line":"        - kolla-ansible-ubuntu-source-zun"},{"line_number":19,"context_line":"        - kolla-ansible-ubuntu-source-masakari"},{"line_number":20,"context_line":"        - kolla-ansible-centos-source-masakari"},{"line_number":21,"context_line":"        - kolla-ansible-centos-source-scenario-nfv"},{"line_number":22,"context_line":"        - kolla-ansible-ubuntu-source-cinder-lvm"},{"line_number":23,"context_line":"        - kolla-ansible-centos-source-cinder-lvm"},{"line_number":24,"context_line":"        - kolla-ansible-centos-source-ironic"},{"line_number":25,"context_line":"        - kolla-ansible-centos-binary-ironic"},{"line_number":26,"context_line":"        - kolla-ansible-ubuntu-source-ironic"},{"line_number":27,"context_line":"        - kolla-ansible-centos-source-upgrade"},{"line_number":28,"context_line":"        - kolla-ansible-ubuntu-source-upgrade"},{"line_number":29,"context_line":"        - kolla-ansible-centos-source-upgrade-ceph"},{"line_number":30,"context_line":"        - kolla-ansible-ubuntu-source-upgrade-ceph"},{"line_number":31,"context_line":"        - kolla-ansible-centos-source-mariadb"},{"line_number":32,"context_line":"        - kolla-ansible-ubuntu-source-mariadb"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"3fa7e38b_be60bb36","line":32,"range":{"start_line":2,"start_character":2,"end_line":32,"end_character":0},"updated":"2019-11-20 13:26:11.000000000","message":"Job kolla-ansible-centos-source-qinling not defined","commit_id":"1be493dbb276ddff9702f5befe0d896d6192aed6"}]}