)]}'
{"ansible/roles/baremetal/tasks/pre-install.yml":[{"author":{"_account_id":15197,"name":"Pierre Riteau","email":"pierre@stackhpc.com","username":"priteau","status":"StackHPC"},"change_message_id":"cc087343b4adb663b108a10c9314295a0d4c544a","unresolved":false,"context_lines":[{"line_number":33,"context_line":"    - name: Remove the existing host entries"},{"line_number":34,"context_line":"      lineinfile:"},{"line_number":35,"context_line":"        dest: /etc/hosts"},{"line_number":36,"context_line":"        regexp: \".*{{ item }}\""},{"line_number":37,"context_line":"        state: absent"},{"line_number":38,"context_line":"      with_items: \"{{ groups[\u0027baremetal\u0027] }}\""},{"line_number":39,"context_line":"      when: item not in groups[\u0027bifrost\u0027]"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"3fa7e38b_c7e1e0ff","line":36,"range":{"start_line":36,"start_character":17,"end_line":36,"end_character":29},"updated":"2019-11-26 10:00:32.000000000","message":"I am not a fan of removing hostnames that we are not managing. \n\nAnyway this regexp is not strict enough. Say item \u003d \"cloudnode1\", the regexp will match any line containing \"cloudnode1\", i.e. all four below:\n\n10.0.0.1 cloudnode1-bmc\n10.0.0.100 cloudnode100-bmc\n192.168.0.1 cloudnode1\n192.168.0.100 cloudnode100","commit_id":"1af105acd13b44e27756fb0f190115fd01b014d9"},{"author":{"_account_id":19779,"name":"Chason Chan","display_name":"chenxing","email":"chason.chan@foxmail.com","username":"chenxing"},"change_message_id":"beac504435dffaf50f1e5450b3d3a89d42b6a0c3","unresolved":false,"context_lines":[{"line_number":33,"context_line":"    - name: Remove the existing host entries"},{"line_number":34,"context_line":"      lineinfile:"},{"line_number":35,"context_line":"        dest: /etc/hosts"},{"line_number":36,"context_line":"        regexp: \".*{{ item }}\""},{"line_number":37,"context_line":"        state: absent"},{"line_number":38,"context_line":"      with_items: \"{{ groups[\u0027baremetal\u0027] }}\""},{"line_number":39,"context_line":"      when: item not in groups[\u0027bifrost\u0027]"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"3fa7e38b_99d81d25","line":36,"range":{"start_line":36,"start_character":17,"end_line":36,"end_character":29},"in_reply_to":"3fa7e38b_c7e1e0ff","updated":"2019-11-27 04:57:42.000000000","message":"Done","commit_id":"1af105acd13b44e27756fb0f190115fd01b014d9"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"3147eafde7817114fa6b11609185482646d91718","unresolved":false,"context_lines":[{"line_number":33,"context_line":"    - name: Remove the existing host entries"},{"line_number":34,"context_line":"      lineinfile:"},{"line_number":35,"context_line":"        dest: /etc/hosts"},{"line_number":36,"context_line":"        regexp: \".*{{ item }}\""},{"line_number":37,"context_line":"        state: absent"},{"line_number":38,"context_line":"      with_items: \"{{ groups[\u0027baremetal\u0027] }}\""},{"line_number":39,"context_line":"      when: item not in groups[\u0027bifrost\u0027]"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"3fa7e38b_45e2b6d6","line":36,"range":{"start_line":36,"start_character":17,"end_line":36,"end_character":29},"in_reply_to":"3fa7e38b_c7e1e0ff","updated":"2019-11-27 10:54:50.000000000","message":"I tend to agree. I raised the point in the bug report but we just went ahead anyway.","commit_id":"1af105acd13b44e27756fb0f190115fd01b014d9"},{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"67e0f2e14ab26dbdedeff7eaf4badc8b1f40fc36","unresolved":false,"context_lines":[{"line_number":33,"context_line":"    - name: Remove the existing host entries"},{"line_number":34,"context_line":"      lineinfile:"},{"line_number":35,"context_line":"        dest: /etc/hosts"},{"line_number":36,"context_line":"        regexp: \".*{{ item }}$\""},{"line_number":37,"context_line":"        backup: yes"},{"line_number":38,"context_line":"        state: absent"},{"line_number":39,"context_line":"      with_items: \"{{ groups[\u0027baremetal\u0027] }}\""}],"source_content_type":"text/x-yaml","patch_set":2,"id":"3fa7e38b_4dbd4666","line":36,"range":{"start_line":36,"start_character":29,"end_line":36,"end_character":30},"updated":"2019-12-11 07:50:25.000000000","message":"Either this or \\s too.","commit_id":"eb55770536424d31203292e920df1bc6e9f0252b"},{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"67e0f2e14ab26dbdedeff7eaf4badc8b1f40fc36","unresolved":false,"context_lines":[{"line_number":33,"context_line":"    - name: Remove the existing host entries"},{"line_number":34,"context_line":"      lineinfile:"},{"line_number":35,"context_line":"        dest: /etc/hosts"},{"line_number":36,"context_line":"        regexp: \".*{{ item }}$\""},{"line_number":37,"context_line":"        backup: yes"},{"line_number":38,"context_line":"        state: absent"},{"line_number":39,"context_line":"      with_items: \"{{ groups[\u0027baremetal\u0027] }}\""}],"source_content_type":"text/x-yaml","patch_set":2,"id":"3fa7e38b_ad887ac2","line":36,"range":{"start_line":36,"start_character":17,"end_line":36,"end_character":19},"updated":"2019-12-11 07:50:25.000000000","message":"I would go for \\s if it is supported.","commit_id":"eb55770536424d31203292e920df1bc6e9f0252b"},{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"67e0f2e14ab26dbdedeff7eaf4badc8b1f40fc36","unresolved":false,"context_lines":[{"line_number":33,"context_line":"    - name: Remove the existing host entries"},{"line_number":34,"context_line":"      lineinfile:"},{"line_number":35,"context_line":"        dest: /etc/hosts"},{"line_number":36,"context_line":"        regexp: \".*{{ item }}$\""},{"line_number":37,"context_line":"        backup: yes"},{"line_number":38,"context_line":"        state: absent"},{"line_number":39,"context_line":"      with_items: \"{{ groups[\u0027baremetal\u0027] }}\""}],"source_content_type":"text/x-yaml","patch_set":2,"id":"3fa7e38b_2db6ca8a","line":36,"range":{"start_line":36,"start_character":22,"end_line":36,"end_character":26},"updated":"2019-12-11 07:50:25.000000000","message":"Should be from ansible_hostname, not inventory_hostname.","commit_id":"eb55770536424d31203292e920df1bc6e9f0252b"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"3147eafde7817114fa6b11609185482646d91718","unresolved":false,"context_lines":[{"line_number":36,"context_line":"        regexp: \".*{{ item }}$\""},{"line_number":37,"context_line":"        backup: yes"},{"line_number":38,"context_line":"        state: absent"},{"line_number":39,"context_line":"      with_items: \"{{ groups[\u0027baremetal\u0027] }}\""},{"line_number":40,"context_line":"      when: item not in groups[\u0027bifrost\u0027]"},{"line_number":41,"context_line":"            or \u0027ansible_\u0027 + hostvars[item][\u0027api_interface\u0027] in hostvars[item]"},{"line_number":42,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":2,"id":"3fa7e38b_0af4cdcf","line":39,"range":{"start_line":39,"start_character":6,"end_line":39,"end_character":16},"updated":"2019-11-27 10:54:50.000000000","message":"I\u0027m concerned that this will not scale well.","commit_id":"eb55770536424d31203292e920df1bc6e9f0252b"},{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"67e0f2e14ab26dbdedeff7eaf4badc8b1f40fc36","unresolved":false,"context_lines":[{"line_number":36,"context_line":"        regexp: \".*{{ item }}$\""},{"line_number":37,"context_line":"        backup: yes"},{"line_number":38,"context_line":"        state: absent"},{"line_number":39,"context_line":"      with_items: \"{{ groups[\u0027baremetal\u0027] }}\""},{"line_number":40,"context_line":"      when: item not in groups[\u0027bifrost\u0027]"},{"line_number":41,"context_line":"            or \u0027ansible_\u0027 + hostvars[item][\u0027api_interface\u0027] in hostvars[item]"},{"line_number":42,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":2,"id":"3fa7e38b_ed82f2a4","line":39,"range":{"start_line":39,"start_character":6,"end_line":39,"end_character":16},"in_reply_to":"3fa7e38b_0af4cdcf","updated":"2019-12-11 07:50:25.000000000","message":"Yeah, it won\u0027t, but for scale you should really deploy site-wide internal DNS service, not manage /etc/hosts in the first place. Scanning a large /etc/hosts might be less effective than querying DNS in some circumstances. ;-)\n\nAll that said, we should probably care to remove only the host\u0027s line itself as that is what Ubuntu does - it creates a record for the host itself.","commit_id":"eb55770536424d31203292e920df1bc6e9f0252b"},{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"d30efc1c12b54a42a9c33f2d21556d3d0ab69488","unresolved":false,"context_lines":[{"line_number":36,"context_line":"        regexp: \".*{{ item }}$\""},{"line_number":37,"context_line":"        backup: yes"},{"line_number":38,"context_line":"        state: absent"},{"line_number":39,"context_line":"      with_items: \"{{ groups[\u0027baremetal\u0027] }}\""},{"line_number":40,"context_line":"      when: item not in groups[\u0027bifrost\u0027]"},{"line_number":41,"context_line":"            or \u0027ansible_\u0027 + hostvars[item][\u0027api_interface\u0027] in hostvars[item]"},{"line_number":42,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":2,"id":"3fa7e38b_d56a11b3","line":39,"range":{"start_line":39,"start_character":6,"end_line":39,"end_character":16},"in_reply_to":"3fa7e38b_ed82f2a4","updated":"2019-12-11 16:58:53.000000000","message":"Hmm, seems I was mistaken, MAAS adds entries for all hosts deployed with it: http://paste.openstack.org/show/787463/\nInstead of the one for localhost we (you, mgoddard) fixed with the lines just above here created by single install.","commit_id":"eb55770536424d31203292e920df1bc6e9f0252b"}]}