)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"afbf6c432c56351f1d06b67e66db1dc1129020f4","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Implement OVN Ansible role."},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"blueprint ovn-controller-neutron-ansible"},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Depends-On: https://review.opendev.org/701074/"},{"line_number":14,"context_line":"Change-Id: Icd425dea85d58db49c838839d8f0b864b4a89a78"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":88,"id":"3fa7e38b_dbb83bc2","line":11,"updated":"2020-02-19 18:08:18.000000000","message":"Implements:","commit_id":"63d8bebf731ef9127ce5ff117b7e28634e2e9911"}],"ansible/group_vars/all.yml":[{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"fe200e577209100b76e38ab7c7ed5a128663a034","unresolved":false,"context_lines":[{"line_number":642,"context_line":"enable_nova_ssh: \"yes\""},{"line_number":643,"context_line":"enable_octavia: \"no\""},{"line_number":644,"context_line":"enable_openvswitch: \"{{ enable_neutron | bool and neutron_plugin_agent !\u003d \u0027linuxbridge\u0027 }}\""},{"line_number":645,"context_line":"enable_ovn: \"no\""},{"line_number":646,"context_line":"enable_ovs_dpdk: \"no\""},{"line_number":647,"context_line":"enable_osprofiler: \"no\""},{"line_number":648,"context_line":"enable_panko: \"no\""}],"source_content_type":"text/x-yaml","patch_set":71,"id":"3fa7e38b_bb2bade7","line":645,"updated":"2020-01-10 10:30:22.000000000","message":"I would configure this like the openvswitch above - based on chosen neutron_plugin_agent, and then in all neutron cases check for neutron_plugin_agent value rather than enable_ovn - this way one could use external ovn too (and it looks cleaner).","commit_id":"6543a07da1dce58601d70bb65fadb053c99e4f5a"},{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"ca4cd4772f87b7325ac013e2c76d0fd3dbbdf3b0","unresolved":false,"context_lines":[{"line_number":642,"context_line":"enable_nova_ssh: \"yes\""},{"line_number":643,"context_line":"enable_octavia: \"no\""},{"line_number":644,"context_line":"enable_openvswitch: \"{{ enable_neutron | bool and neutron_plugin_agent !\u003d \u0027linuxbridge\u0027 }}\""},{"line_number":645,"context_line":"enable_ovn: \"no\""},{"line_number":646,"context_line":"enable_ovs_dpdk: \"no\""},{"line_number":647,"context_line":"enable_osprofiler: \"no\""},{"line_number":648,"context_line":"enable_panko: \"no\""}],"source_content_type":"text/x-yaml","patch_set":71,"id":"3fa7e38b_a6b874c6","line":645,"in_reply_to":"3fa7e38b_bb2bade7","updated":"2020-01-10 11:37:29.000000000","message":"Done","commit_id":"6543a07da1dce58601d70bb65fadb053c99e4f5a"},{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"1da608c04abce32d89c6acb4e673d1a36b16d794","unresolved":false,"context_lines":[{"line_number":641,"context_line":"enable_nova_serialconsole_proxy: \"no\""},{"line_number":642,"context_line":"enable_nova_ssh: \"yes\""},{"line_number":643,"context_line":"enable_octavia: \"no\""},{"line_number":644,"context_line":"enable_openvswitch: \"{{ enable_neutron | bool and neutron_plugin_agent !\u003d \u0027linuxbridge\u0027 }}\""},{"line_number":645,"context_line":"enable_ovn: \"{{ enable_neutron | bool and neutron_plugin_agent \u003d\u003d \u0027ovn\u0027 }}\""},{"line_number":646,"context_line":"enable_ovs_dpdk: \"no\""},{"line_number":647,"context_line":"enable_osprofiler: \"no\""}],"source_content_type":"text/x-yaml","patch_set":72,"id":"3fa7e38b_26fc843d","line":644,"updated":"2020-01-10 11:44:55.000000000","message":"sidenote: this might be worth changing into \u0027positive\u0027 conditioning to avoid headaches","commit_id":"c8793f6ec2b4dbee6f0f0f2d4d444aabf5e6b3d4"},{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"bb66ddff94a6ddeb2cd41997fad9aac9bc0576ae","unresolved":false,"context_lines":[{"line_number":641,"context_line":"enable_nova_serialconsole_proxy: \"no\""},{"line_number":642,"context_line":"enable_nova_ssh: \"yes\""},{"line_number":643,"context_line":"enable_octavia: \"no\""},{"line_number":644,"context_line":"enable_openvswitch: \"{{ enable_neutron | bool and neutron_plugin_agent !\u003d \u0027linuxbridge\u0027 }}\""},{"line_number":645,"context_line":"enable_ovn: \"{{ enable_neutron | bool and neutron_plugin_agent \u003d\u003d \u0027ovn\u0027 }}\""},{"line_number":646,"context_line":"enable_ovs_dpdk: \"no\""},{"line_number":647,"context_line":"enable_osprofiler: \"no\""}],"source_content_type":"text/x-yaml","patch_set":72,"id":"3fa7e38b_66691cf5","line":644,"in_reply_to":"3fa7e38b_26fc843d","updated":"2020-01-10 11:45:19.000000000","message":"in a later change, not here","commit_id":"c8793f6ec2b4dbee6f0f0f2d4d444aabf5e6b3d4"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"afbf6c432c56351f1d06b67e66db1dc1129020f4","unresolved":false,"context_lines":[{"line_number":377,"context_line":"ovn_nb_db_port: \"6641\""},{"line_number":378,"context_line":"ovn_sb_db_port: \"6642\""},{"line_number":379,"context_line":"ovn_nb_connection: \"tcp:{% for host in groups[\u0027ovn-nb-db\u0027] %}{{ \u0027api\u0027 | kolla_address(host) }}:{{ ovn_nb_db_port }}{% if not loop.last %},tcp:{% endif %}{% endfor %}\""},{"line_number":380,"context_line":"ovn_sb_connection: \"tcp:{% for host in groups[\u0027ovn-sb-db\u0027] %}{{ \u0027api\u0027 | kolla_address(host) }}:{{ ovn_sb_db_port }}{% if not loop.last %},tcp:{% endif %}{% endfor %}\""},{"line_number":381,"context_line":""},{"line_number":382,"context_line":"outward_rabbitmq_port: \"5674\""},{"line_number":383,"context_line":"outward_rabbitmq_management_port: \"15674\""}],"source_content_type":"text/x-yaml","patch_set":92,"id":"3fa7e38b_4ee6394c","line":380,"range":{"start_line":380,"start_character":60,"end_line":380,"end_character":62},"updated":"2020-02-19 18:08:18.000000000","message":"Why not just put tcp: here instead of twice?","commit_id":"cc297570e75246673c6576c43b12e44f98f646f9"},{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"cab58a4dd51758dad06a8eb0627874b67e6853cf","unresolved":false,"context_lines":[{"line_number":377,"context_line":"ovn_nb_db_port: \"6641\""},{"line_number":378,"context_line":"ovn_sb_db_port: \"6642\""},{"line_number":379,"context_line":"ovn_nb_connection: \"tcp:{% for host in groups[\u0027ovn-nb-db\u0027] %}{{ \u0027api\u0027 | kolla_address(host) }}:{{ ovn_nb_db_port }}{% if not loop.last %},tcp:{% endif %}{% endfor %}\""},{"line_number":380,"context_line":"ovn_sb_connection: \"tcp:{% for host in groups[\u0027ovn-sb-db\u0027] %}{{ \u0027api\u0027 | kolla_address(host) }}:{{ ovn_sb_db_port }}{% if not loop.last %},tcp:{% endif %}{% endfor %}\""},{"line_number":381,"context_line":""},{"line_number":382,"context_line":"outward_rabbitmq_port: \"5674\""},{"line_number":383,"context_line":"outward_rabbitmq_management_port: \"15674\""}],"source_content_type":"text/x-yaml","patch_set":92,"id":"3fa7e38b_b32fff55","line":380,"range":{"start_line":380,"start_character":60,"end_line":380,"end_character":62},"in_reply_to":"3fa7e38b_4ee6394c","updated":"2020-02-20 17:40:38.000000000","message":"Done","commit_id":"cc297570e75246673c6576c43b12e44f98f646f9"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"afbf6c432c56351f1d06b67e66db1dc1129020f4","unresolved":false,"context_lines":[{"line_number":898,"context_line":""},{"line_number":899,"context_line":"# valid values: [\"dvr\", \"dvr_no_external\"]"},{"line_number":900,"context_line":"neutron_compute_dvr_mode: \"dvr\""},{"line_number":901,"context_line":"computes_need_external_bridge: \"{{ ((enable_neutron_dvr | bool or neutron_plugin_agent \u003d\u003d \u0027ovn\u0027) and neutron_compute_dvr_mode \u003d\u003d \u0027dvr\u0027) or enable_neutron_provider_networks | bool }}\""},{"line_number":902,"context_line":""},{"line_number":903,"context_line":"# Default DNS resolvers for virtual networks"},{"line_number":904,"context_line":"neutron_dnsmasq_dns_servers: \"1.1.1.1,8.8.8.8,8.8.4.4\""}],"source_content_type":"text/x-yaml","patch_set":92,"id":"3fa7e38b_ee7b6528","line":901,"range":{"start_line":901,"start_character":101,"end_line":901,"end_character":125},"updated":"2020-02-19 18:08:18.000000000","message":"Is this applicable for OVN?","commit_id":"cc297570e75246673c6576c43b12e44f98f646f9"},{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"2ea7573b912e7b224a752b043e6120230a141073","unresolved":false,"context_lines":[{"line_number":898,"context_line":""},{"line_number":899,"context_line":"# valid values: [\"dvr\", \"dvr_no_external\"]"},{"line_number":900,"context_line":"neutron_compute_dvr_mode: \"dvr\""},{"line_number":901,"context_line":"computes_need_external_bridge: \"{{ ((enable_neutron_dvr | bool or neutron_plugin_agent \u003d\u003d \u0027ovn\u0027) and neutron_compute_dvr_mode \u003d\u003d \u0027dvr\u0027) or enable_neutron_provider_networks | bool }}\""},{"line_number":902,"context_line":""},{"line_number":903,"context_line":"# Default DNS resolvers for virtual networks"},{"line_number":904,"context_line":"neutron_dnsmasq_dns_servers: \"1.1.1.1,8.8.8.8,8.8.4.4\""}],"source_content_type":"text/x-yaml","patch_set":92,"id":"1fa4df85_8dbc3706","line":901,"range":{"start_line":901,"start_character":101,"end_line":901,"end_character":125},"in_reply_to":"1fa4df85_319ee307","updated":"2020-02-27 06:36:02.000000000","message":"Let\u0027s follow the default OVN approach and Computes on external network.","commit_id":"cc297570e75246673c6576c43b12e44f98f646f9"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"f5552e44a7660dcfca2dcbe2a8f45dea6d21a4f3","unresolved":false,"context_lines":[{"line_number":898,"context_line":""},{"line_number":899,"context_line":"# valid values: [\"dvr\", \"dvr_no_external\"]"},{"line_number":900,"context_line":"neutron_compute_dvr_mode: \"dvr\""},{"line_number":901,"context_line":"computes_need_external_bridge: \"{{ ((enable_neutron_dvr | bool or neutron_plugin_agent \u003d\u003d \u0027ovn\u0027) and neutron_compute_dvr_mode \u003d\u003d \u0027dvr\u0027) or enable_neutron_provider_networks | bool }}\""},{"line_number":902,"context_line":""},{"line_number":903,"context_line":"# Default DNS resolvers for virtual networks"},{"line_number":904,"context_line":"neutron_dnsmasq_dns_servers: \"1.1.1.1,8.8.8.8,8.8.4.4\""}],"source_content_type":"text/x-yaml","patch_set":92,"id":"1fa4df85_319ee307","line":901,"range":{"start_line":901,"start_character":101,"end_line":901,"end_character":125},"in_reply_to":"3fa7e38b_935523c4","updated":"2020-02-24 17:04:24.000000000","message":"So what would you expect from the default OVN setup? Computes on the external network? Do we need a separate way to configure that for OVN?","commit_id":"cc297570e75246673c6576c43b12e44f98f646f9"},{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"b9736df7fcc591250394e349b31134f434004176","unresolved":false,"context_lines":[{"line_number":898,"context_line":""},{"line_number":899,"context_line":"# valid values: [\"dvr\", \"dvr_no_external\"]"},{"line_number":900,"context_line":"neutron_compute_dvr_mode: \"dvr\""},{"line_number":901,"context_line":"computes_need_external_bridge: \"{{ ((enable_neutron_dvr | bool or neutron_plugin_agent \u003d\u003d \u0027ovn\u0027) and neutron_compute_dvr_mode \u003d\u003d \u0027dvr\u0027) or enable_neutron_provider_networks | bool }}\""},{"line_number":902,"context_line":""},{"line_number":903,"context_line":"# Default DNS resolvers for virtual networks"},{"line_number":904,"context_line":"neutron_dnsmasq_dns_servers: \"1.1.1.1,8.8.8.8,8.8.4.4\""}],"source_content_type":"text/x-yaml","patch_set":92,"id":"3fa7e38b_f4901244","line":901,"range":{"start_line":901,"start_character":101,"end_line":901,"end_character":125},"in_reply_to":"3fa7e38b_ee7b6528","updated":"2020-02-19 18:48:08.000000000","message":"This is misnamed, surely. But one can imagine OVN controllers capable of external routing and not. Wonder what Michał thinks.","commit_id":"cc297570e75246673c6576c43b12e44f98f646f9"},{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"cab58a4dd51758dad06a8eb0627874b67e6853cf","unresolved":false,"context_lines":[{"line_number":898,"context_line":""},{"line_number":899,"context_line":"# valid values: [\"dvr\", \"dvr_no_external\"]"},{"line_number":900,"context_line":"neutron_compute_dvr_mode: \"dvr\""},{"line_number":901,"context_line":"computes_need_external_bridge: \"{{ ((enable_neutron_dvr | bool or neutron_plugin_agent \u003d\u003d \u0027ovn\u0027) and neutron_compute_dvr_mode \u003d\u003d \u0027dvr\u0027) or enable_neutron_provider_networks | bool }}\""},{"line_number":902,"context_line":""},{"line_number":903,"context_line":"# Default DNS resolvers for virtual networks"},{"line_number":904,"context_line":"neutron_dnsmasq_dns_servers: \"1.1.1.1,8.8.8.8,8.8.4.4\""}],"source_content_type":"text/x-yaml","patch_set":92,"id":"3fa7e38b_935523c4","line":901,"range":{"start_line":901,"start_character":101,"end_line":901,"end_character":125},"in_reply_to":"3fa7e38b_ee7b6528","updated":"2020-02-20 17:40:38.000000000","message":"Well, we can use OVN and have external bridge only on the network nodes - I\u0027ll remove it. Got misguided by the overall OVN philosophy of having external bridges on computes ;-)","commit_id":"cc297570e75246673c6576c43b12e44f98f646f9"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"afbf6c432c56351f1d06b67e66db1dc1129020f4","unresolved":false,"context_lines":[{"line_number":1067,"context_line":"# Configure telegraf to use the docker daemon itself as an input for"},{"line_number":1068,"context_line":"# telemetry data."},{"line_number":1069,"context_line":"telegraf_enable_docker_input: \"no\""},{"line_number":1070,"context_line":""},{"line_number":1071,"context_line":"#####"},{"line_number":1072,"context_line":"# OVN"},{"line_number":1073,"context_line":"#####"},{"line_number":1074,"context_line":"# Configure OVN remote probe interval time in ms"},{"line_number":1075,"context_line":"ovn_remote_probe_interval: \"60000\""}],"source_content_type":"text/x-yaml","patch_set":92,"id":"3fa7e38b_1454cefc","line":1075,"range":{"start_line":1070,"start_character":0,"end_line":1075,"end_character":34},"updated":"2020-02-19 18:08:18.000000000","message":"Is this something you need to change frequently? If not it could just go in role defaults.","commit_id":"cc297570e75246673c6576c43b12e44f98f646f9"},{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"cab58a4dd51758dad06a8eb0627874b67e6853cf","unresolved":false,"context_lines":[{"line_number":1067,"context_line":"# Configure telegraf to use the docker daemon itself as an input for"},{"line_number":1068,"context_line":"# telemetry data."},{"line_number":1069,"context_line":"telegraf_enable_docker_input: \"no\""},{"line_number":1070,"context_line":""},{"line_number":1071,"context_line":"#####"},{"line_number":1072,"context_line":"# OVN"},{"line_number":1073,"context_line":"#####"},{"line_number":1074,"context_line":"# Configure OVN remote probe interval time in ms"},{"line_number":1075,"context_line":"ovn_remote_probe_interval: \"60000\""}],"source_content_type":"text/x-yaml","patch_set":92,"id":"3fa7e38b_f36577b1","line":1075,"range":{"start_line":1070,"start_character":0,"end_line":1075,"end_character":34},"in_reply_to":"3fa7e38b_1454cefc","updated":"2020-02-20 17:40:38.000000000","message":"Done","commit_id":"cc297570e75246673c6576c43b12e44f98f646f9"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"0c0fab1db5974ebe6fbfde16d97481ba697a41f4","unresolved":false,"context_lines":[{"line_number":888,"context_line":"neutron_bgp_router_id: \"1.1.1.1\""},{"line_number":889,"context_line":"neutron_bridge_name: \"{{ \u0027br-dvs\u0027 if neutron_plugin_agent \u003d\u003d \u0027vmware_dvs\u0027 else \u0027br-ex\u0027 }}\""},{"line_number":890,"context_line":"# Comma-separated type of enabled ml2 type drivers"},{"line_number":891,"context_line":"neutron_type_drivers: \"flat,vlan,vxlan\""},{"line_number":892,"context_line":"# Comma-separated types of tenant networks (should be listed in \u0027neutron_type_drivers\u0027)"},{"line_number":893,"context_line":"# NOTE: for ironic this list should also contain \u0027flat\u0027"},{"line_number":894,"context_line":"neutron_tenant_network_types: \"vxlan\""}],"source_content_type":"text/x-yaml","patch_set":120,"id":"df33271e_955814fb","line":891,"range":{"start_line":891,"start_character":23,"end_line":891,"end_character":38},"updated":"2020-04-03 15:50:38.000000000","message":"Should we include geneve if OVN is enabled?","commit_id":"b89944275ed552dc50909cb998987a461325d383"},{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"39455fcedf36f62cc21d27716659c200d0c3f3df","unresolved":false,"context_lines":[{"line_number":888,"context_line":"neutron_bgp_router_id: \"1.1.1.1\""},{"line_number":889,"context_line":"neutron_bridge_name: \"{{ \u0027br-dvs\u0027 if neutron_plugin_agent \u003d\u003d \u0027vmware_dvs\u0027 else \u0027br-ex\u0027 }}\""},{"line_number":890,"context_line":"# Comma-separated type of enabled ml2 type drivers"},{"line_number":891,"context_line":"neutron_type_drivers: \"flat,vlan,vxlan\""},{"line_number":892,"context_line":"# Comma-separated types of tenant networks (should be listed in \u0027neutron_type_drivers\u0027)"},{"line_number":893,"context_line":"# NOTE: for ironic this list should also contain \u0027flat\u0027"},{"line_number":894,"context_line":"neutron_tenant_network_types: \"vxlan\""}],"source_content_type":"text/x-yaml","patch_set":120,"id":"df33271e_aaa32e00","line":891,"range":{"start_line":891,"start_character":23,"end_line":891,"end_character":38},"in_reply_to":"df33271e_955814fb","updated":"2020-04-03 17:27:39.000000000","message":"Probably, otherwise it is quite useless.","commit_id":"b89944275ed552dc50909cb998987a461325d383"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"0c0fab1db5974ebe6fbfde16d97481ba697a41f4","unresolved":false,"context_lines":[{"line_number":891,"context_line":"neutron_type_drivers: \"flat,vlan,vxlan\""},{"line_number":892,"context_line":"# Comma-separated types of tenant networks (should be listed in \u0027neutron_type_drivers\u0027)"},{"line_number":893,"context_line":"# NOTE: for ironic this list should also contain \u0027flat\u0027"},{"line_number":894,"context_line":"neutron_tenant_network_types: \"vxlan\""},{"line_number":895,"context_line":""},{"line_number":896,"context_line":"# valid values: [\"dvr\", \"dvr_no_external\"]"},{"line_number":897,"context_line":"neutron_compute_dvr_mode: \"dvr\""}],"source_content_type":"text/x-yaml","patch_set":120,"id":"df33271e_755d90e8","line":894,"range":{"start_line":894,"start_character":31,"end_line":894,"end_character":36},"updated":"2020-04-03 15:50:38.000000000","message":"ditto","commit_id":"b89944275ed552dc50909cb998987a461325d383"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"0c0fab1db5974ebe6fbfde16d97481ba697a41f4","unresolved":false,"context_lines":[{"line_number":895,"context_line":""},{"line_number":896,"context_line":"# valid values: [\"dvr\", \"dvr_no_external\"]"},{"line_number":897,"context_line":"neutron_compute_dvr_mode: \"dvr\""},{"line_number":898,"context_line":"computes_need_external_bridge: \"{{ (enable_neutron_dvr | bool and neutron_compute_dvr_mode \u003d\u003d \u0027dvr\u0027) or enable_neutron_provider_networks | bool or neutron_plugin_agent \u003d\u003d \u0027ovn\u0027}}\""},{"line_number":899,"context_line":""},{"line_number":900,"context_line":"# Default DNS resolvers for virtual networks"},{"line_number":901,"context_line":"neutron_dnsmasq_dns_servers: \"1.1.1.1,8.8.8.8,8.8.4.4\""}],"source_content_type":"text/x-yaml","patch_set":120,"id":"df33271e_d0390ad9","line":898,"range":{"start_line":898,"start_character":147,"end_line":898,"end_character":176},"updated":"2020-04-03 15:50:38.000000000","message":"I think it\u0027s only required when [ovn] enable_distributed_floating_ip is true in ml2_conf.ini, but it is false by default. Maybe we should expose a flag for that?","commit_id":"b89944275ed552dc50909cb998987a461325d383"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"3b1c80a6a7720c6ade17379bbe24fb4b5d4208c4","unresolved":false,"context_lines":[{"line_number":895,"context_line":""},{"line_number":896,"context_line":"# valid values: [\"dvr\", \"dvr_no_external\"]"},{"line_number":897,"context_line":"neutron_compute_dvr_mode: \"dvr\""},{"line_number":898,"context_line":"computes_need_external_bridge: \"{{ (enable_neutron_dvr | bool and neutron_compute_dvr_mode \u003d\u003d \u0027dvr\u0027) or enable_neutron_provider_networks | bool or neutron_plugin_agent \u003d\u003d \u0027ovn\u0027}}\""},{"line_number":899,"context_line":""},{"line_number":900,"context_line":"# Default DNS resolvers for virtual networks"},{"line_number":901,"context_line":"neutron_dnsmasq_dns_servers: \"1.1.1.1,8.8.8.8,8.8.4.4\""}],"source_content_type":"text/x-yaml","patch_set":120,"id":"df33271e_cf71050f","line":898,"range":{"start_line":898,"start_character":147,"end_line":898,"end_character":176},"in_reply_to":"df33271e_22942744","updated":"2020-04-08 09:25:54.000000000","message":"Probably best to go with OVN default - no.","commit_id":"b89944275ed552dc50909cb998987a461325d383"},{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"181dc6a3a46c7858c7a21afc3a029aabdd1ecff3","unresolved":false,"context_lines":[{"line_number":895,"context_line":""},{"line_number":896,"context_line":"# valid values: [\"dvr\", \"dvr_no_external\"]"},{"line_number":897,"context_line":"neutron_compute_dvr_mode: \"dvr\""},{"line_number":898,"context_line":"computes_need_external_bridge: \"{{ (enable_neutron_dvr | bool and neutron_compute_dvr_mode \u003d\u003d \u0027dvr\u0027) or enable_neutron_provider_networks | bool or neutron_plugin_agent \u003d\u003d \u0027ovn\u0027}}\""},{"line_number":899,"context_line":""},{"line_number":900,"context_line":"# Default DNS resolvers for virtual networks"},{"line_number":901,"context_line":"neutron_dnsmasq_dns_servers: \"1.1.1.1,8.8.8.8,8.8.4.4\""}],"source_content_type":"text/x-yaml","patch_set":120,"id":"df33271e_1e5a0029","line":898,"range":{"start_line":898,"start_character":147,"end_line":898,"end_character":176},"in_reply_to":"df33271e_cf71050f","updated":"2020-04-08 10:27:16.000000000","message":"Done","commit_id":"b89944275ed552dc50909cb998987a461325d383"},{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"39455fcedf36f62cc21d27716659c200d0c3f3df","unresolved":false,"context_lines":[{"line_number":895,"context_line":""},{"line_number":896,"context_line":"# valid values: [\"dvr\", \"dvr_no_external\"]"},{"line_number":897,"context_line":"neutron_compute_dvr_mode: \"dvr\""},{"line_number":898,"context_line":"computes_need_external_bridge: \"{{ (enable_neutron_dvr | bool and neutron_compute_dvr_mode \u003d\u003d \u0027dvr\u0027) or enable_neutron_provider_networks | bool or neutron_plugin_agent \u003d\u003d \u0027ovn\u0027}}\""},{"line_number":899,"context_line":""},{"line_number":900,"context_line":"# Default DNS resolvers for virtual networks"},{"line_number":901,"context_line":"neutron_dnsmasq_dns_servers: \"1.1.1.1,8.8.8.8,8.8.4.4\""}],"source_content_type":"text/x-yaml","patch_set":120,"id":"df33271e_8af62af9","line":898,"range":{"start_line":898,"start_character":147,"end_line":898,"end_character":176},"in_reply_to":"df33271e_d0390ad9","updated":"2020-04-03 17:27:39.000000000","message":"++","commit_id":"b89944275ed552dc50909cb998987a461325d383"},{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"e8eda4c2049e77f3040469a4f506218b5b66d86b","unresolved":false,"context_lines":[{"line_number":895,"context_line":""},{"line_number":896,"context_line":"# valid values: [\"dvr\", \"dvr_no_external\"]"},{"line_number":897,"context_line":"neutron_compute_dvr_mode: \"dvr\""},{"line_number":898,"context_line":"computes_need_external_bridge: \"{{ (enable_neutron_dvr | bool and neutron_compute_dvr_mode \u003d\u003d \u0027dvr\u0027) or enable_neutron_provider_networks | bool or neutron_plugin_agent \u003d\u003d \u0027ovn\u0027}}\""},{"line_number":899,"context_line":""},{"line_number":900,"context_line":"# Default DNS resolvers for virtual networks"},{"line_number":901,"context_line":"neutron_dnsmasq_dns_servers: \"1.1.1.1,8.8.8.8,8.8.4.4\""}],"source_content_type":"text/x-yaml","patch_set":120,"id":"df33271e_22942744","line":898,"range":{"start_line":898,"start_character":147,"end_line":898,"end_character":176},"in_reply_to":"df33271e_d0390ad9","updated":"2020-04-07 13:06:21.000000000","message":"Ok, do we default to \"no\", or \"yes\" for neutron_ovn_distributed_fip?","commit_id":"b89944275ed552dc50909cb998987a461325d383"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"a1164921a20ee6eec7cdbfd9aa689e88ca22218c","unresolved":false,"context_lines":[{"line_number":904,"context_line":"neutron_legacy_iptables: \"no\""},{"line_number":905,"context_line":""},{"line_number":906,"context_line":"# Enable distributed floating ip for OVN deployments"},{"line_number":907,"context_line":"neutron_ovn_distributed_fip: \"no\""},{"line_number":908,"context_line":""},{"line_number":909,"context_line":"#######################"},{"line_number":910,"context_line":"# Nova options"}],"source_content_type":"text/x-yaml","patch_set":129,"id":"df33271e_08763ea5","line":907,"range":{"start_line":907,"start_character":0,"end_line":907,"end_character":27},"updated":"2020-04-08 14:00:25.000000000","message":"Needs to go in etc/kolla/globals.yml. Also needs to be passed through to [ovn] enable_distributed_floating_ip in ml2_conf.ini. Let\u0027s also document it. Finally, have you tried it? Could give it a shot in CI in a DNM patch.","commit_id":"f7785df573de72c8fd890d32fe5512e9b6abbe7a"}],"ansible/inventory/all-in-one":[{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"afbf6c432c56351f1d06b67e66db1dc1129020f4","unresolved":false,"context_lines":[{"line_number":249,"context_line":"[blazar:children]"},{"line_number":250,"context_line":"control"},{"line_number":251,"context_line":""},{"line_number":252,"context_line":"[ovn:children]"},{"line_number":253,"context_line":"network"},{"line_number":254,"context_line":"compute"},{"line_number":255,"context_line":""},{"line_number":256,"context_line":"# Additional control implemented here. These groups allow you to control which"},{"line_number":257,"context_line":"# services run on which hosts at a per-service level."}],"source_content_type":"application/octet-stream","patch_set":88,"id":"3fa7e38b_1bc8134b","line":254,"range":{"start_line":252,"start_character":0,"end_line":254,"end_character":7},"updated":"2020-02-19 18:08:18.000000000","message":"Not used","commit_id":"63d8bebf731ef9127ce5ff117b7e28634e2e9911"},{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"b9736df7fcc591250394e349b31134f434004176","unresolved":false,"context_lines":[{"line_number":249,"context_line":"[blazar:children]"},{"line_number":250,"context_line":"control"},{"line_number":251,"context_line":""},{"line_number":252,"context_line":"[ovn:children]"},{"line_number":253,"context_line":"network"},{"line_number":254,"context_line":"compute"},{"line_number":255,"context_line":""},{"line_number":256,"context_line":"# Additional control implemented here. These groups allow you to control which"},{"line_number":257,"context_line":"# services run on which hosts at a per-service level."}],"source_content_type":"application/octet-stream","patch_set":88,"id":"3fa7e38b_9493de59","line":254,"range":{"start_line":252,"start_character":0,"end_line":254,"end_character":7},"in_reply_to":"3fa7e38b_1bc8134b","updated":"2020-02-19 18:48:08.000000000","message":"used in site.yml","commit_id":"63d8bebf731ef9127ce5ff117b7e28634e2e9911"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"f5552e44a7660dcfca2dcbe2a8f45dea6d21a4f3","unresolved":false,"context_lines":[{"line_number":246,"context_line":"[blazar:children]"},{"line_number":247,"context_line":"control"},{"line_number":248,"context_line":""},{"line_number":249,"context_line":"[ovn:children]"},{"line_number":250,"context_line":"network"},{"line_number":251,"context_line":"compute"},{"line_number":252,"context_line":""},{"line_number":253,"context_line":"# Additional control implemented here. These groups allow you to control which"},{"line_number":254,"context_line":"# services run on which hosts at a per-service level."}],"source_content_type":"application/octet-stream","patch_set":96,"id":"1fa4df85_f187ebb5","line":251,"range":{"start_line":249,"start_character":0,"end_line":251,"end_character":7},"updated":"2020-02-24 17:04:24.000000000","message":"Can be removed.","commit_id":"d260246d723324577e2e1908cc6db8a29dc715af"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"0aa11f254a2860ec73adb2d431a2fc098c602c89","unresolved":false,"context_lines":[{"line_number":764,"context_line":"[ovn-controller-compute:children]"},{"line_number":765,"context_line":"compute"},{"line_number":766,"context_line":""},{"line_number":767,"context_line":"[ovn-controller-network:children]"},{"line_number":768,"context_line":"network"},{"line_number":769,"context_line":""},{"line_number":770,"context_line":"[ovn-northd:children]"}],"source_content_type":"application/octet-stream","patch_set":103,"id":"1fa4df85_4374b968","line":767,"updated":"2020-02-28 17:31:27.000000000","message":"If the default is routing on computes, should we deploy ovn-controller on network hosts?","commit_id":"50ea60e99d7c25435d45cb8908173f2ddbb39fb9"},{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"5bc3672e9a470ff76cb200a58479f16ad5e1457c","unresolved":false,"context_lines":[{"line_number":764,"context_line":"[ovn-controller-compute:children]"},{"line_number":765,"context_line":"compute"},{"line_number":766,"context_line":""},{"line_number":767,"context_line":"[ovn-controller-network:children]"},{"line_number":768,"context_line":"network"},{"line_number":769,"context_line":""},{"line_number":770,"context_line":"[ovn-northd:children]"}],"source_content_type":"application/octet-stream","patch_set":103,"id":"1fa4df85_74165658","line":767,"in_reply_to":"1fa4df85_4374b968","updated":"2020-03-16 09:38:19.000000000","message":"It\u0027s in the reference architecture from networking-ovn - https://docs.openstack.org/networking-ovn/latest/admin/refarch/refarch.html#service-layout - so I think we should keep it there. \nAnd if the reference arch defines using gateway nodes and no distributed FIP - I\u0027ll update the change so it\u0027s the default.","commit_id":"50ea60e99d7c25435d45cb8908173f2ddbb39fb9"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"22c2264a7447c5020b68c375eb9a7878a5d14b5c","unresolved":false,"context_lines":[{"line_number":764,"context_line":"[ovn-controller-compute:children]"},{"line_number":765,"context_line":"compute"},{"line_number":766,"context_line":""},{"line_number":767,"context_line":"[ovn-controller-network:children]"},{"line_number":768,"context_line":"network"},{"line_number":769,"context_line":""},{"line_number":770,"context_line":"[ovn-northd:children]"}],"source_content_type":"application/octet-stream","patch_set":103,"id":"df33271e_4177f209","line":767,"in_reply_to":"1fa4df85_74165658","updated":"2020-04-03 13:02:19.000000000","message":"That document describes both approaches - centralised FIPs \u0026 DVR.","commit_id":"50ea60e99d7c25435d45cb8908173f2ddbb39fb9"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"08ad2bd5e4256daafca65139de8acaa7042d91b7","unresolved":false,"context_lines":[{"line_number":764,"context_line":"[ovn-controller-compute:children]"},{"line_number":765,"context_line":"compute"},{"line_number":766,"context_line":""},{"line_number":767,"context_line":"[ovn-controller-network:children]"},{"line_number":768,"context_line":"network"},{"line_number":769,"context_line":""},{"line_number":770,"context_line":"[ovn-northd:children]"}],"source_content_type":"application/octet-stream","patch_set":103,"id":"df33271e_4429c0f0","line":767,"in_reply_to":"df33271e_4177f209","updated":"2020-04-03 13:41:23.000000000","message":"Looks like it\u0027s controlled by [ovn] enable_distributed_floating_ip in neutron-server ml2_conf.ini, default is false.","commit_id":"50ea60e99d7c25435d45cb8908173f2ddbb39fb9"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"0c0fab1db5974ebe6fbfde16d97481ba697a41f4","unresolved":false,"context_lines":[{"line_number":756,"context_line":""},{"line_number":757,"context_line":"[masakari-monitors:children]"},{"line_number":758,"context_line":"compute"},{"line_number":759,"context_line":""},{"line_number":760,"context_line":"[ovn-controller:children]"},{"line_number":761,"context_line":"ovn-controller-compute"},{"line_number":762,"context_line":"ovn-controller-network"},{"line_number":763,"context_line":""},{"line_number":764,"context_line":"[ovn-controller-compute:children]"},{"line_number":765,"context_line":"compute"},{"line_number":766,"context_line":""},{"line_number":767,"context_line":"[ovn-controller-network:children]"},{"line_number":768,"context_line":"network"},{"line_number":769,"context_line":""},{"line_number":770,"context_line":"[ovn-northd:children]"},{"line_number":771,"context_line":"network"},{"line_number":772,"context_line":""},{"line_number":773,"context_line":"[ovn-nb-db:children]"},{"line_number":774,"context_line":"network"},{"line_number":775,"context_line":""},{"line_number":776,"context_line":"[ovn-sb-db:children]"},{"line_number":777,"context_line":"network"}],"source_content_type":"application/octet-stream","patch_set":120,"id":"df33271e_07585a54","line":777,"range":{"start_line":759,"start_character":0,"end_line":777,"end_character":7},"updated":"2020-04-03 15:50:38.000000000","message":"Looking at the refarch (https://docs.openstack.org/networking-ovn/latest/admin/refarch/refarch.html), it defines these types of nodes:\n\n* Controller: openstack services\n* Database: ovn-northd, ovn-nb-db, ovn-sb-db\n* Compute: ovn-controller, ovs-vswitchd, ovsdb-server, ovn-metadata-agent\n* Gateway: ovn-controller, ovs-vswitchd, ovsdb-server\n\nAnd then: \"For functional evaluation only, you can combine the controller and database nodes.\"\n\nI\u0027d say gateway \u003d\u003d network node.\n\nSo I\u0027m wondering if the database services (ovn-northd, ovn-nb-db, ovn-sb-db) should really live on the controller in this setup?\n\nAlso let\u0027s make a group for neutron-ovn-metadata-agent on the computes rather than reusing the compute group.","commit_id":"b89944275ed552dc50909cb998987a461325d383"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"3b1c80a6a7720c6ade17379bbe24fb4b5d4208c4","unresolved":false,"context_lines":[{"line_number":756,"context_line":""},{"line_number":757,"context_line":"[masakari-monitors:children]"},{"line_number":758,"context_line":"compute"},{"line_number":759,"context_line":""},{"line_number":760,"context_line":"[ovn-controller:children]"},{"line_number":761,"context_line":"ovn-controller-compute"},{"line_number":762,"context_line":"ovn-controller-network"},{"line_number":763,"context_line":""},{"line_number":764,"context_line":"[ovn-controller-compute:children]"},{"line_number":765,"context_line":"compute"},{"line_number":766,"context_line":""},{"line_number":767,"context_line":"[ovn-controller-network:children]"},{"line_number":768,"context_line":"network"},{"line_number":769,"context_line":""},{"line_number":770,"context_line":"[ovn-northd:children]"},{"line_number":771,"context_line":"network"},{"line_number":772,"context_line":""},{"line_number":773,"context_line":"[ovn-nb-db:children]"},{"line_number":774,"context_line":"network"},{"line_number":775,"context_line":""},{"line_number":776,"context_line":"[ovn-sb-db:children]"},{"line_number":777,"context_line":"network"}],"source_content_type":"application/octet-stream","patch_set":120,"id":"df33271e_6f5c397e","line":777,"range":{"start_line":759,"start_character":0,"end_line":777,"end_character":7},"in_reply_to":"df33271e_02780329","updated":"2020-04-08 09:25:54.000000000","message":"neutron-server is control. Only data path services are in the network group.","commit_id":"b89944275ed552dc50909cb998987a461325d383"},{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"39455fcedf36f62cc21d27716659c200d0c3f3df","unresolved":false,"context_lines":[{"line_number":756,"context_line":""},{"line_number":757,"context_line":"[masakari-monitors:children]"},{"line_number":758,"context_line":"compute"},{"line_number":759,"context_line":""},{"line_number":760,"context_line":"[ovn-controller:children]"},{"line_number":761,"context_line":"ovn-controller-compute"},{"line_number":762,"context_line":"ovn-controller-network"},{"line_number":763,"context_line":""},{"line_number":764,"context_line":"[ovn-controller-compute:children]"},{"line_number":765,"context_line":"compute"},{"line_number":766,"context_line":""},{"line_number":767,"context_line":"[ovn-controller-network:children]"},{"line_number":768,"context_line":"network"},{"line_number":769,"context_line":""},{"line_number":770,"context_line":"[ovn-northd:children]"},{"line_number":771,"context_line":"network"},{"line_number":772,"context_line":""},{"line_number":773,"context_line":"[ovn-nb-db:children]"},{"line_number":774,"context_line":"network"},{"line_number":775,"context_line":""},{"line_number":776,"context_line":"[ovn-sb-db:children]"},{"line_number":777,"context_line":"network"}],"source_content_type":"application/octet-stream","patch_set":120,"id":"df33271e_ca45d217","line":777,"range":{"start_line":759,"start_character":0,"end_line":777,"end_character":7},"in_reply_to":"df33271e_07585a54","updated":"2020-04-03 17:27:39.000000000","message":"++ - we could possibly have another major group for \"ovn-database\" defaulting to controller for sake of simplicity (I guess for small scale it does not do any bad)","commit_id":"b89944275ed552dc50909cb998987a461325d383"},{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"181dc6a3a46c7858c7a21afc3a029aabdd1ecff3","unresolved":false,"context_lines":[{"line_number":756,"context_line":""},{"line_number":757,"context_line":"[masakari-monitors:children]"},{"line_number":758,"context_line":"compute"},{"line_number":759,"context_line":""},{"line_number":760,"context_line":"[ovn-controller:children]"},{"line_number":761,"context_line":"ovn-controller-compute"},{"line_number":762,"context_line":"ovn-controller-network"},{"line_number":763,"context_line":""},{"line_number":764,"context_line":"[ovn-controller-compute:children]"},{"line_number":765,"context_line":"compute"},{"line_number":766,"context_line":""},{"line_number":767,"context_line":"[ovn-controller-network:children]"},{"line_number":768,"context_line":"network"},{"line_number":769,"context_line":""},{"line_number":770,"context_line":"[ovn-northd:children]"},{"line_number":771,"context_line":"network"},{"line_number":772,"context_line":""},{"line_number":773,"context_line":"[ovn-nb-db:children]"},{"line_number":774,"context_line":"network"},{"line_number":775,"context_line":""},{"line_number":776,"context_line":"[ovn-sb-db:children]"},{"line_number":777,"context_line":"network"}],"source_content_type":"application/octet-stream","patch_set":120,"id":"df33271e_5e3be8c6","line":777,"range":{"start_line":759,"start_character":0,"end_line":777,"end_character":7},"in_reply_to":"df33271e_6f5c397e","updated":"2020-04-08 10:27:16.000000000","message":"Done","commit_id":"b89944275ed552dc50909cb998987a461325d383"},{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"e8eda4c2049e77f3040469a4f506218b5b66d86b","unresolved":false,"context_lines":[{"line_number":756,"context_line":""},{"line_number":757,"context_line":"[masakari-monitors:children]"},{"line_number":758,"context_line":"compute"},{"line_number":759,"context_line":""},{"line_number":760,"context_line":"[ovn-controller:children]"},{"line_number":761,"context_line":"ovn-controller-compute"},{"line_number":762,"context_line":"ovn-controller-network"},{"line_number":763,"context_line":""},{"line_number":764,"context_line":"[ovn-controller-compute:children]"},{"line_number":765,"context_line":"compute"},{"line_number":766,"context_line":""},{"line_number":767,"context_line":"[ovn-controller-network:children]"},{"line_number":768,"context_line":"network"},{"line_number":769,"context_line":""},{"line_number":770,"context_line":"[ovn-northd:children]"},{"line_number":771,"context_line":"network"},{"line_number":772,"context_line":""},{"line_number":773,"context_line":"[ovn-nb-db:children]"},{"line_number":774,"context_line":"network"},{"line_number":775,"context_line":""},{"line_number":776,"context_line":"[ovn-sb-db:children]"},{"line_number":777,"context_line":"network"}],"source_content_type":"application/octet-stream","patch_set":120,"id":"df33271e_02780329","line":777,"range":{"start_line":759,"start_character":0,"end_line":777,"end_character":7},"in_reply_to":"df33271e_ca45d217","updated":"2020-04-07 13:06:21.000000000","message":"Well, we default Neutron server to network group - so we should collocate it there, but still make a parent group \"ovn-database\" for easy modification.","commit_id":"b89944275ed552dc50909cb998987a461325d383"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"9e83381fcbbb72bc68a6937edc2fca0ff14a26ea","unresolved":false,"context_lines":[{"line_number":768,"context_line":"network"},{"line_number":769,"context_line":""},{"line_number":770,"context_line":"[ovn-database:children]"},{"line_number":771,"context_line":"network"},{"line_number":772,"context_line":""},{"line_number":773,"context_line":"[ovn-northd:children]"},{"line_number":774,"context_line":"ovn-database"}],"source_content_type":"application/octet-stream","patch_set":122,"id":"df33271e_ea54b7cc","line":771,"range":{"start_line":771,"start_character":0,"end_line":771,"end_character":7},"updated":"2020-04-08 09:49:32.000000000","message":"control. These aren\u0027t dataplane.","commit_id":"4f55ccc5a8499be973618fb380487f95eee3478a"},{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"181dc6a3a46c7858c7a21afc3a029aabdd1ecff3","unresolved":false,"context_lines":[{"line_number":768,"context_line":"network"},{"line_number":769,"context_line":""},{"line_number":770,"context_line":"[ovn-database:children]"},{"line_number":771,"context_line":"network"},{"line_number":772,"context_line":""},{"line_number":773,"context_line":"[ovn-northd:children]"},{"line_number":774,"context_line":"ovn-database"}],"source_content_type":"application/octet-stream","patch_set":122,"id":"df33271e_3e70a4a5","line":771,"range":{"start_line":771,"start_character":0,"end_line":771,"end_character":7},"in_reply_to":"df33271e_ea54b7cc","updated":"2020-04-08 10:27:16.000000000","message":"Done","commit_id":"4f55ccc5a8499be973618fb380487f95eee3478a"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"61cf107fe8287f3580dd52d559588950b2b1e635","unresolved":false,"context_lines":[{"line_number":636,"context_line":"octavia"},{"line_number":637,"context_line":""},{"line_number":638,"context_line":"[octavia-housekeeping:children]"},{"line_number":639,"context_line":"octavia"},{"line_number":640,"context_line":""},{"line_number":641,"context_line":"[octavia-worker:children]"},{"line_number":642,"context_line":"octavia"}],"source_content_type":"application/octet-stream","patch_set":126,"id":"df33271e_8df8a0c4","line":639,"range":{"start_line":639,"start_character":0,"end_line":639,"end_character":7},"updated":"2020-04-08 13:27:21.000000000","message":"accident?","commit_id":"b35e6c10c72d42c2e21027bf0d56ce4172b5a6fb"},{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"2fea2b00d7729fc23f8fd392a4e978966be8d5df","unresolved":false,"context_lines":[{"line_number":636,"context_line":"octavia"},{"line_number":637,"context_line":""},{"line_number":638,"context_line":"[octavia-housekeeping:children]"},{"line_number":639,"context_line":"octavia"},{"line_number":640,"context_line":""},{"line_number":641,"context_line":"[octavia-worker:children]"},{"line_number":642,"context_line":"octavia"}],"source_content_type":"application/octet-stream","patch_set":126,"id":"df33271e_ad43e4ae","line":639,"range":{"start_line":639,"start_character":0,"end_line":639,"end_character":7},"in_reply_to":"df33271e_8df8a0c4","updated":"2020-04-08 13:36:56.000000000","message":"a huge accident, fortunately only octavia was the victim...","commit_id":"b35e6c10c72d42c2e21027bf0d56ce4172b5a6fb"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"147f3e342d656bb56a6eeed2e48b2f8a6bfdd113","unresolved":false,"context_lines":[{"line_number":768,"context_line":"network"},{"line_number":769,"context_line":""},{"line_number":770,"context_line":"[ovn-database:children]"},{"line_number":771,"context_line":"controller"},{"line_number":772,"context_line":""},{"line_number":773,"context_line":"[ovn-northd:children]"},{"line_number":774,"context_line":"ovn-database"}],"source_content_type":"application/octet-stream","patch_set":126,"id":"df33271e_edd4cc49","line":771,"range":{"start_line":771,"start_character":0,"end_line":771,"end_character":10},"updated":"2020-04-08 13:25:56.000000000","message":"control","commit_id":"b35e6c10c72d42c2e21027bf0d56ce4172b5a6fb"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"c6204e8a71e15215fd6b70af474737d0550f81d8","unresolved":false,"context_lines":[{"line_number":779,"context_line":"[ovn-sb-db:children]"},{"line_number":780,"context_line":"ovn-database"},{"line_number":781,"context_line":""},{"line_number":782,"context_line":"[neutron-ovn-metadata-agent:children]"},{"line_number":783,"context_line":"compute"}],"source_content_type":"application/octet-stream","patch_set":126,"id":"df33271e_cd63c8db","line":783,"range":{"start_line":782,"start_character":0,"end_line":783,"end_character":7},"updated":"2020-04-08 13:22:30.000000000","message":"nit: next to neutron stuff","commit_id":"b35e6c10c72d42c2e21027bf0d56ce4172b5a6fb"}],"ansible/inventory/multinode":[{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"fe200e577209100b76e38ab7c7ed5a128663a034","unresolved":false,"context_lines":[{"line_number":269,"context_line":"control"},{"line_number":270,"context_line":""},{"line_number":271,"context_line":"[ovn:children]"},{"line_number":272,"context_line":"network"},{"line_number":273,"context_line":""},{"line_number":274,"context_line":"# Additional control implemented here. These groups allow you to control which"},{"line_number":275,"context_line":"# services run on which hosts at a per-service level."}],"source_content_type":"application/octet-stream","patch_set":71,"id":"3fa7e38b_fbb925c4","line":272,"updated":"2020-01-10 10:30:22.000000000","message":"and compute?","commit_id":"6543a07da1dce58601d70bb65fadb053c99e4f5a"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"f5552e44a7660dcfca2dcbe2a8f45dea6d21a4f3","unresolved":false,"context_lines":[{"line_number":265,"context_line":"[blazar:children]"},{"line_number":266,"context_line":"control"},{"line_number":267,"context_line":""},{"line_number":268,"context_line":"[ovn:children]"},{"line_number":269,"context_line":"network"},{"line_number":270,"context_line":"compute"},{"line_number":271,"context_line":""},{"line_number":272,"context_line":"# Additional control implemented here. These groups allow you to control which"},{"line_number":273,"context_line":"# services run on which hosts at a per-service level."}],"source_content_type":"application/octet-stream","patch_set":96,"id":"1fa4df85_b1aad316","line":270,"range":{"start_line":268,"start_character":0,"end_line":270,"end_character":7},"updated":"2020-02-24 17:04:24.000000000","message":"And this","commit_id":"d260246d723324577e2e1908cc6db8a29dc715af"}],"ansible/roles/neutron/defaults/main.yml":[{"author":{"_account_id":19316,"name":"Eduardo Gonzalez","email":"dabarren@gmail.com","username":"egonzalez90"},"change_message_id":"67a913b8e252b00b268dd84dc497ff615133738f","unresolved":false,"context_lines":[{"line_number":450,"context_line":"    enabled: \"{{ enable_neutron_vpnaas | bool }}\""},{"line_number":451,"context_line":"  - name: \"port_forwarding\""},{"line_number":452,"context_line":"    enabled: \"{{ enable_neutron_port_forwarding | bool }}\""},{"line_number":453,"context_line":"  - name: \"networking_ovn.l3.l3_ovn.OVNL3RouterPlugin\""},{"line_number":454,"context_line":"    enabled: \"{{ enable_ovn | bool }}\""},{"line_number":455,"context_line":""},{"line_number":456,"context_line":"neutron_service_plugins: \"{{ service_plugins | selectattr(\u0027enabled\u0027, \u0027equalto\u0027, true) | list }}\""}],"source_content_type":"text/x-yaml","patch_set":21,"id":"3fa7e38b_54f75c8d","line":453,"range":{"start_line":453,"start_character":36,"end_line":453,"end_character":53},"updated":"2019-12-05 10:45:59.000000000","message":"could be just entrypoint name ovn-router rather than python path https://github.com/openstack/networking-ovn/blob/master/setup.cfg#L58 ?","commit_id":"87b8010e3560c691144718ad71677a8c3e5c2397"},{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"9757204f6e2aae1f52945ccc910fcb67ed7d681e","unresolved":false,"context_lines":[{"line_number":450,"context_line":"    enabled: \"{{ enable_neutron_vpnaas | bool }}\""},{"line_number":451,"context_line":"  - name: \"port_forwarding\""},{"line_number":452,"context_line":"    enabled: \"{{ enable_neutron_port_forwarding | bool }}\""},{"line_number":453,"context_line":"  - name: \"networking_ovn.l3.l3_ovn.OVNL3RouterPlugin\""},{"line_number":454,"context_line":"    enabled: \"{{ enable_ovn | bool }}\""},{"line_number":455,"context_line":""},{"line_number":456,"context_line":"neutron_service_plugins: \"{{ service_plugins | selectattr(\u0027enabled\u0027, \u0027equalto\u0027, true) | list }}\""}],"source_content_type":"text/x-yaml","patch_set":21,"id":"3fa7e38b_1ab90d15","line":453,"range":{"start_line":453,"start_character":36,"end_line":453,"end_character":53},"in_reply_to":"3fa7e38b_54f75c8d","updated":"2019-12-06 08:17:14.000000000","message":"I\u0027ll check.","commit_id":"87b8010e3560c691144718ad71677a8c3e5c2397"},{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"fe200e577209100b76e38ab7c7ed5a128663a034","unresolved":false,"context_lines":[{"line_number":355,"context_line":"neutron_l3_agent_host_ipv6_neigh_gc_thresh2: \"{{ neutron_l3_agent_host_ipv4_neigh_gc_thresh2 }}\""},{"line_number":356,"context_line":"neutron_l3_agent_host_ipv6_neigh_gc_thresh3: \"{{ neutron_l3_agent_host_ipv4_neigh_gc_thresh3 }}\""},{"line_number":357,"context_line":""},{"line_number":358,"context_line":"neutron_type_drivers: \"flat,vlan,vxlan,geneve\""},{"line_number":359,"context_line":""},{"line_number":360,"context_line":"tenant_network_types:"},{"line_number":361,"context_line":"  - name: \"vxlan\""}],"source_content_type":"text/x-yaml","patch_set":71,"id":"3fa7e38b_3b201df8","line":358,"range":{"start_line":358,"start_character":39,"end_line":358,"end_character":45},"updated":"2020-01-10 10:30:22.000000000","message":"with this (1)...","commit_id":"6543a07da1dce58601d70bb65fadb053c99e4f5a"},{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"fe200e577209100b76e38ab7c7ed5a128663a034","unresolved":false,"context_lines":[{"line_number":361,"context_line":"  - name: \"vxlan\""},{"line_number":362,"context_line":"    enabled: \"{{ neutron_plugin_agent in [\u0027linuxbridge\u0027,\u0027openvswitch\u0027] }}\""},{"line_number":363,"context_line":"  - name: \"geneve\""},{"line_number":364,"context_line":"    enabled: \"{{ enable_ovn | bool }}\""},{"line_number":365,"context_line":"  - name: \"vlan\""},{"line_number":366,"context_line":"    enabled: \"{{ enable_neutron_provider_networks | bool }}\""},{"line_number":367,"context_line":"  - name: \"flat\""}],"source_content_type":"text/x-yaml","patch_set":71,"id":"3fa7e38b_bbc72d11","line":364,"range":{"start_line":364,"start_character":17,"end_line":364,"end_character":27},"updated":"2020-01-10 10:30:22.000000000","message":"here example what I mean by switching to using neutron_plugin_agent:\n neutron_plugin_agent in [\u0027ovn\u0027]\n\nThis way you make it clear it depends on neutron plugin agent and hence the vxlan above is normally going to go away. Otherwise it is no longer clear.","commit_id":"6543a07da1dce58601d70bb65fadb053c99e4f5a"},{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"ca4cd4772f87b7325ac013e2c76d0fd3dbbdf3b0","unresolved":false,"context_lines":[{"line_number":361,"context_line":"  - name: \"vxlan\""},{"line_number":362,"context_line":"    enabled: \"{{ neutron_plugin_agent in [\u0027linuxbridge\u0027,\u0027openvswitch\u0027] }}\""},{"line_number":363,"context_line":"  - name: \"geneve\""},{"line_number":364,"context_line":"    enabled: \"{{ enable_ovn | bool }}\""},{"line_number":365,"context_line":"  - name: \"vlan\""},{"line_number":366,"context_line":"    enabled: \"{{ enable_neutron_provider_networks | bool }}\""},{"line_number":367,"context_line":"  - name: \"flat\""}],"source_content_type":"text/x-yaml","patch_set":71,"id":"3fa7e38b_a67954fb","line":364,"range":{"start_line":364,"start_character":17,"end_line":364,"end_character":27},"in_reply_to":"3fa7e38b_bbc72d11","updated":"2020-01-10 11:37:29.000000000","message":"Done","commit_id":"6543a07da1dce58601d70bb65fadb053c99e4f5a"},{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"fe200e577209100b76e38ab7c7ed5a128663a034","unresolved":false,"context_lines":[{"line_number":363,"context_line":"  - name: \"geneve\""},{"line_number":364,"context_line":"    enabled: \"{{ enable_ovn | bool }}\""},{"line_number":365,"context_line":"  - name: \"vlan\""},{"line_number":366,"context_line":"    enabled: \"{{ enable_neutron_provider_networks | bool }}\""},{"line_number":367,"context_line":"  - name: \"flat\""},{"line_number":368,"context_line":"    enabled: \"{{ enable_ironic | bool }}\""},{"line_number":369,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":71,"id":"3fa7e38b_bbf08d67","line":366,"range":{"start_line":366,"start_character":17,"end_line":366,"end_character":56},"updated":"2020-01-10 10:30:22.000000000","message":"Not really the case. Provider \u003d/\u003d tenant vlan.","commit_id":"6543a07da1dce58601d70bb65fadb053c99e4f5a"},{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"549eebfd95a851128da9c8d58faa30220136f992","unresolved":false,"context_lines":[{"line_number":363,"context_line":"  - name: \"geneve\""},{"line_number":364,"context_line":"    enabled: \"{{ enable_ovn | bool }}\""},{"line_number":365,"context_line":"  - name: \"vlan\""},{"line_number":366,"context_line":"    enabled: \"{{ enable_neutron_provider_networks | bool }}\""},{"line_number":367,"context_line":"  - name: \"flat\""},{"line_number":368,"context_line":"    enabled: \"{{ enable_ironic | bool }}\""},{"line_number":369,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":71,"id":"3fa7e38b_01713277","line":366,"range":{"start_line":366,"start_character":17,"end_line":366,"end_character":56},"in_reply_to":"3fa7e38b_4698a018","updated":"2020-01-10 12:17:06.000000000","message":"Will do.","commit_id":"6543a07da1dce58601d70bb65fadb053c99e4f5a"},{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"1da608c04abce32d89c6acb4e673d1a36b16d794","unresolved":false,"context_lines":[{"line_number":363,"context_line":"  - name: \"geneve\""},{"line_number":364,"context_line":"    enabled: \"{{ enable_ovn | bool }}\""},{"line_number":365,"context_line":"  - name: \"vlan\""},{"line_number":366,"context_line":"    enabled: \"{{ enable_neutron_provider_networks | bool }}\""},{"line_number":367,"context_line":"  - name: \"flat\""},{"line_number":368,"context_line":"    enabled: \"{{ enable_ironic | bool }}\""},{"line_number":369,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":71,"id":"3fa7e38b_4698a018","line":366,"range":{"start_line":366,"start_character":17,"end_line":366,"end_character":56},"in_reply_to":"3fa7e38b_8676980b","updated":"2020-01-10 11:44:55.000000000","message":"I would drop these simply to retain compatibility (and sanity).","commit_id":"6543a07da1dce58601d70bb65fadb053c99e4f5a"},{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"ca4cd4772f87b7325ac013e2c76d0fd3dbbdf3b0","unresolved":false,"context_lines":[{"line_number":363,"context_line":"  - name: \"geneve\""},{"line_number":364,"context_line":"    enabled: \"{{ enable_ovn | bool }}\""},{"line_number":365,"context_line":"  - name: \"vlan\""},{"line_number":366,"context_line":"    enabled: \"{{ enable_neutron_provider_networks | bool }}\""},{"line_number":367,"context_line":"  - name: \"flat\""},{"line_number":368,"context_line":"    enabled: \"{{ enable_ironic | bool }}\""},{"line_number":369,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":71,"id":"3fa7e38b_8676980b","line":366,"range":{"start_line":366,"start_character":17,"end_line":366,"end_character":56},"in_reply_to":"3fa7e38b_bbf08d67","updated":"2020-01-10 11:37:29.000000000","message":"It\u0027s half the case, but we don\u0027t have a variable enable_tenant_vlan - still a user can override the whole var (or config file).","commit_id":"6543a07da1dce58601d70bb65fadb053c99e4f5a"},{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"fe200e577209100b76e38ab7c7ed5a128663a034","unresolved":false,"context_lines":[{"line_number":364,"context_line":"    enabled: \"{{ enable_ovn | bool }}\""},{"line_number":365,"context_line":"  - name: \"vlan\""},{"line_number":366,"context_line":"    enabled: \"{{ enable_neutron_provider_networks | bool }}\""},{"line_number":367,"context_line":"  - name: \"flat\""},{"line_number":368,"context_line":"    enabled: \"{{ enable_ironic | bool }}\""},{"line_number":369,"context_line":""},{"line_number":370,"context_line":"neutron_tenant_network_types: \"{{ tenant_network_types | selectattr(\u0027enabled\u0027, \u0027equalto\u0027, true) | list }}\""},{"line_number":371,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":71,"id":"3fa7e38b_3bd33dd5","line":368,"range":{"start_line":367,"start_character":0,"end_line":368,"end_character":41},"updated":"2020-01-10 10:30:22.000000000","message":"I see you are helping ironic guys, but it might be the case they are running on vlan instead. To think about it.","commit_id":"6543a07da1dce58601d70bb65fadb053c99e4f5a"},{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"ca4cd4772f87b7325ac013e2c76d0fd3dbbdf3b0","unresolved":false,"context_lines":[{"line_number":364,"context_line":"    enabled: \"{{ enable_ovn | bool }}\""},{"line_number":365,"context_line":"  - name: \"vlan\""},{"line_number":366,"context_line":"    enabled: \"{{ enable_neutron_provider_networks | bool }}\""},{"line_number":367,"context_line":"  - name: \"flat\""},{"line_number":368,"context_line":"    enabled: \"{{ enable_ironic | bool }}\""},{"line_number":369,"context_line":""},{"line_number":370,"context_line":"neutron_tenant_network_types: \"{{ tenant_network_types | selectattr(\u0027enabled\u0027, \u0027equalto\u0027, true) | list }}\""},{"line_number":371,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":71,"id":"3fa7e38b_c61a50c5","line":368,"range":{"start_line":367,"start_character":0,"end_line":368,"end_character":41},"in_reply_to":"3fa7e38b_3bd33dd5","updated":"2020-01-10 11:37:29.000000000","message":"I took this from previous form of this variable and a comment: https://github.com/openstack/kolla-ansible/blob/6dde7ce833472c963610e43073d75b2c0f764fbd/ansible/group_vars/all.yml#L897","commit_id":"6543a07da1dce58601d70bb65fadb053c99e4f5a"},{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"1da608c04abce32d89c6acb4e673d1a36b16d794","unresolved":false,"context_lines":[{"line_number":364,"context_line":"    enabled: \"{{ enable_ovn | bool }}\""},{"line_number":365,"context_line":"  - name: \"vlan\""},{"line_number":366,"context_line":"    enabled: \"{{ enable_neutron_provider_networks | bool }}\""},{"line_number":367,"context_line":"  - name: \"flat\""},{"line_number":368,"context_line":"    enabled: \"{{ enable_ironic | bool }}\""},{"line_number":369,"context_line":""},{"line_number":370,"context_line":"neutron_tenant_network_types: \"{{ tenant_network_types | selectattr(\u0027enabled\u0027, \u0027equalto\u0027, true) | list }}\""},{"line_number":371,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":71,"id":"3fa7e38b_669b5c15","line":368,"range":{"start_line":367,"start_character":0,"end_line":368,"end_character":41},"in_reply_to":"3fa7e38b_c61a50c5","updated":"2020-01-10 11:44:55.000000000","message":"But it only has a comment about it. Ditto above.","commit_id":"6543a07da1dce58601d70bb65fadb053c99e4f5a"},{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"fe200e577209100b76e38ab7c7ed5a128663a034","unresolved":false,"context_lines":[{"line_number":382,"context_line":"  - name: \"baremetal\""},{"line_number":383,"context_line":"    enabled: \"{{ enable_ironic_neutron_agent | bool }}\""},{"line_number":384,"context_line":"  - name: \"l2population\""},{"line_number":385,"context_line":"    enabled: \"{{ not enable_hyperv | bool }} or {{ not enable_ovn | bool }}\""},{"line_number":386,"context_line":"  - name: \"ovn\""},{"line_number":387,"context_line":"    enabled: \"{{ enable_ovn | bool }}\""},{"line_number":388,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":71,"id":"3fa7e38b_5be079cb","line":385,"range":{"start_line":385,"start_character":45,"end_line":385,"end_character":47},"updated":"2020-01-10 10:30:22.000000000","message":"\"and\"?","commit_id":"6543a07da1dce58601d70bb65fadb053c99e4f5a"},{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"1da608c04abce32d89c6acb4e673d1a36b16d794","unresolved":false,"context_lines":[{"line_number":382,"context_line":"  - name: \"baremetal\""},{"line_number":383,"context_line":"    enabled: \"{{ enable_ironic_neutron_agent | bool }}\""},{"line_number":384,"context_line":"  - name: \"l2population\""},{"line_number":385,"context_line":"    enabled: \"{{ not enable_hyperv | bool }} or {{ not enable_ovn | bool }}\""},{"line_number":386,"context_line":"  - name: \"ovn\""},{"line_number":387,"context_line":"    enabled: \"{{ enable_ovn | bool }}\""},{"line_number":388,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":71,"id":"3fa7e38b_c68b30be","line":385,"range":{"start_line":385,"start_character":45,"end_line":385,"end_character":47},"in_reply_to":"3fa7e38b_2676c440","updated":"2020-01-10 11:44:55.000000000","message":"this \u0027or\u0027 is outside the \u0027not\u0027, hence \u0027and\u0027","commit_id":"6543a07da1dce58601d70bb65fadb053c99e4f5a"},{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"ca4cd4772f87b7325ac013e2c76d0fd3dbbdf3b0","unresolved":false,"context_lines":[{"line_number":382,"context_line":"  - name: \"baremetal\""},{"line_number":383,"context_line":"    enabled: \"{{ enable_ironic_neutron_agent | bool }}\""},{"line_number":384,"context_line":"  - name: \"l2population\""},{"line_number":385,"context_line":"    enabled: \"{{ not enable_hyperv | bool }} or {{ not enable_ovn | bool }}\""},{"line_number":386,"context_line":"  - name: \"ovn\""},{"line_number":387,"context_line":"    enabled: \"{{ enable_ovn | bool }}\""},{"line_number":388,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":71,"id":"3fa7e38b_2676c440","line":385,"range":{"start_line":385,"start_character":45,"end_line":385,"end_character":47},"in_reply_to":"3fa7e38b_5be079cb","updated":"2020-01-10 11:37:29.000000000","message":"or - do not enable when HyperV or OVN (not both)","commit_id":"6543a07da1dce58601d70bb65fadb053c99e4f5a"},{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"1da608c04abce32d89c6acb4e673d1a36b16d794","unresolved":false,"context_lines":[{"line_number":355,"context_line":"neutron_l3_agent_host_ipv6_neigh_gc_thresh2: \"{{ neutron_l3_agent_host_ipv4_neigh_gc_thresh2 }}\""},{"line_number":356,"context_line":"neutron_l3_agent_host_ipv6_neigh_gc_thresh3: \"{{ neutron_l3_agent_host_ipv4_neigh_gc_thresh3 }}\""},{"line_number":357,"context_line":""},{"line_number":358,"context_line":"neutron_type_drivers: \"flat,vlan,vxlan{%- if neutron_plugin_agent \u003d\u003d \u0027ovn\u0027 -%},geneve{%- endif -%}\""},{"line_number":359,"context_line":""},{"line_number":360,"context_line":"tenant_network_types:"},{"line_number":361,"context_line":"  - name: \"vxlan\""}],"source_content_type":"text/x-yaml","patch_set":72,"id":"3fa7e38b_e6f18c65","line":358,"updated":"2020-01-10 11:44:55.000000000","message":"oh just do it like for the one below :-)","commit_id":"c8793f6ec2b4dbee6f0f0f2d4d444aabf5e6b3d4"},{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"db0d1a2ab8278fb5aa8b6e060d875b7988892d1d","unresolved":false,"context_lines":[{"line_number":93,"context_line":"    container_name: \"neutron_l3_agent\""},{"line_number":94,"context_line":"    image: \"{{ neutron_l3_agent_image_full }}\""},{"line_number":95,"context_line":"    privileged: True"},{"line_number":96,"context_line":"    enabled: \"{{ neutron_plugin_agent not in [\u0027ovn\u0027, \u0027vmware_nsxv\u0027, \u0027vmware_nsxv3\u0027, \u0027vmware_dvs\u0027] }}\""},{"line_number":97,"context_line":"    environment:"},{"line_number":98,"context_line":"      KOLLA_LEGACY_IPTABLES: \"{{ neutron_legacy_iptables | bool | lower }}\""},{"line_number":99,"context_line":"    host_in_groups: \u003e-"}],"source_content_type":"text/x-yaml","patch_set":85,"id":"3fa7e38b_7b10314d","line":96,"updated":"2020-02-10 10:23:35.000000000","message":"What about bgp and sriov btw? Work/break? OVN/Neutron?","commit_id":"d75cce4a94e853579cd2dcffa25de20b2775afef"},{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"1d075929332a27ccff6a048f3e174feeb3ba623e","unresolved":false,"context_lines":[{"line_number":93,"context_line":"    container_name: \"neutron_l3_agent\""},{"line_number":94,"context_line":"    image: \"{{ neutron_l3_agent_image_full }}\""},{"line_number":95,"context_line":"    privileged: True"},{"line_number":96,"context_line":"    enabled: \"{{ neutron_plugin_agent not in [\u0027ovn\u0027, \u0027vmware_nsxv\u0027, \u0027vmware_nsxv3\u0027, \u0027vmware_dvs\u0027] }}\""},{"line_number":97,"context_line":"    environment:"},{"line_number":98,"context_line":"      KOLLA_LEGACY_IPTABLES: \"{{ neutron_legacy_iptables | bool | lower }}\""},{"line_number":99,"context_line":"    host_in_groups: \u003e-"}],"source_content_type":"text/x-yaml","patch_set":85,"id":"3fa7e38b_7bacb1ea","line":96,"in_reply_to":"3fa7e38b_1b96dda1","updated":"2020-02-10 10:34:37.000000000","message":"Uhm, they are agents... See the agent below. The question is whether OVN supports them natively, breaks totally or depends on Neutron.","commit_id":"d75cce4a94e853579cd2dcffa25de20b2775afef"},{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"4fcd52667d6ffa1d15e4f763f9228ba3848a8970","unresolved":false,"context_lines":[{"line_number":93,"context_line":"    container_name: \"neutron_l3_agent\""},{"line_number":94,"context_line":"    image: \"{{ neutron_l3_agent_image_full }}\""},{"line_number":95,"context_line":"    privileged: True"},{"line_number":96,"context_line":"    enabled: \"{{ neutron_plugin_agent not in [\u0027ovn\u0027, \u0027vmware_nsxv\u0027, \u0027vmware_nsxv3\u0027, \u0027vmware_dvs\u0027] }}\""},{"line_number":97,"context_line":"    environment:"},{"line_number":98,"context_line":"      KOLLA_LEGACY_IPTABLES: \"{{ neutron_legacy_iptables | bool | lower }}\""},{"line_number":99,"context_line":"    host_in_groups: \u003e-"}],"source_content_type":"text/x-yaml","patch_set":85,"id":"3fa7e38b_1b96dda1","line":96,"in_reply_to":"3fa7e38b_7b10314d","updated":"2020-02-10 10:32:17.000000000","message":"First of all, bgp and sriov are never used in our code as values for neutron_plugin_agent - so I\u0027m not breaking anything that is not broken already ;-)","commit_id":"d75cce4a94e853579cd2dcffa25de20b2775afef"},{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"5bba9da7c55c5d7100104501d90a8d3706f4616c","unresolved":false,"context_lines":[{"line_number":93,"context_line":"    container_name: \"neutron_l3_agent\""},{"line_number":94,"context_line":"    image: \"{{ neutron_l3_agent_image_full }}\""},{"line_number":95,"context_line":"    privileged: True"},{"line_number":96,"context_line":"    enabled: \"{{ neutron_plugin_agent not in [\u0027ovn\u0027, \u0027vmware_nsxv\u0027, \u0027vmware_nsxv3\u0027, \u0027vmware_dvs\u0027] }}\""},{"line_number":97,"context_line":"    environment:"},{"line_number":98,"context_line":"      KOLLA_LEGACY_IPTABLES: \"{{ neutron_legacy_iptables | bool | lower }}\""},{"line_number":99,"context_line":"    host_in_groups: \u003e-"}],"source_content_type":"text/x-yaml","patch_set":85,"id":"3fa7e38b_9b6e4d95","line":96,"in_reply_to":"3fa7e38b_7bacb1ea","updated":"2020-02-10 10:43:28.000000000","message":"Right, in case of BGP we need to disable it when OVN is enabled, because it won\u0027t work at all (bgp neutron agent requires l3 agent to work). OVN needs SR-IOV NIC agent to deliver SR-IOV.","commit_id":"d75cce4a94e853579cd2dcffa25de20b2775afef"},{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"c10e9ebeb986c89e9f753ef6c5473c0bd555b100","unresolved":false,"context_lines":[{"line_number":128,"context_line":"    container_name: \"neutron_bgp_dragent\""},{"line_number":129,"context_line":"    image: \"{{ neutron_bgp_dragent_image_full }}\""},{"line_number":130,"context_line":"    privileged: True"},{"line_number":131,"context_line":"    enabled: \"{{ enable_neutron_bgp_dragent | bool and neutron_plugin_agent not in [\u0027vmware_nsxv\u0027, \u0027vmware_nsxv3\u0027, \u0027vmware_dvs\u0027, \u0027ovn\u0027] }}\""},{"line_number":132,"context_line":"    group: \"neutron-bgp-dragent\""},{"line_number":133,"context_line":"    host_in_groups: \"{{ inventory_hostname in groups[\u0027neutron-bgp-dragent\u0027] }}\""},{"line_number":134,"context_line":"    volumes: \"{{ neutron_bgp_dragent_default_volumes + neutron_bgp_dragent_extra_volumes }}\""}],"source_content_type":"text/x-yaml","patch_set":86,"id":"3fa7e38b_4d7fbc68","line":131,"updated":"2020-02-10 11:32:55.000000000","message":"order :-)","commit_id":"3bfb1baedf372e371ee403af07954071985e64ad"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"afbf6c432c56351f1d06b67e66db1dc1129020f4","unresolved":false,"context_lines":[{"line_number":369,"context_line":"  - name: \"baremetal\""},{"line_number":370,"context_line":"    enabled: \"{{ enable_ironic_neutron_agent | bool }}\""},{"line_number":371,"context_line":"  - name: \"l2population\""},{"line_number":372,"context_line":"    enabled: \"{{ not enable_hyperv | bool }} or {{ not neutron_plugin_agent \u003d\u003d \u0027ovn\u0027 }}\""},{"line_number":373,"context_line":"  - name: \"ovn\""},{"line_number":374,"context_line":"    enabled: \"{{ neutron_plugin_agent \u003d\u003d \u0027ovn\u0027 }}\""},{"line_number":375,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":88,"id":"3fa7e38b_5b30cb54","line":372,"range":{"start_line":372,"start_character":51,"end_line":372,"end_character":54},"updated":"2020-02-19 18:08:18.000000000","message":"!\u003d","commit_id":"63d8bebf731ef9127ce5ff117b7e28634e2e9911"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"afbf6c432c56351f1d06b67e66db1dc1129020f4","unresolved":false,"context_lines":[{"line_number":369,"context_line":"  - name: \"baremetal\""},{"line_number":370,"context_line":"    enabled: \"{{ enable_ironic_neutron_agent | bool }}\""},{"line_number":371,"context_line":"  - name: \"l2population\""},{"line_number":372,"context_line":"    enabled: \"{{ not enable_hyperv | bool }} or {{ not neutron_plugin_agent \u003d\u003d \u0027ovn\u0027 }}\""},{"line_number":373,"context_line":"  - name: \"ovn\""},{"line_number":374,"context_line":"    enabled: \"{{ neutron_plugin_agent \u003d\u003d \u0027ovn\u0027 }}\""},{"line_number":375,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":88,"id":"3fa7e38b_3b2b8fe9","line":372,"range":{"start_line":372,"start_character":42,"end_line":372,"end_character":50},"updated":"2020-02-19 18:08:18.000000000","message":"remove brackets","commit_id":"63d8bebf731ef9127ce5ff117b7e28634e2e9911"},{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"cab58a4dd51758dad06a8eb0627874b67e6853cf","unresolved":false,"context_lines":[{"line_number":369,"context_line":"  - name: \"baremetal\""},{"line_number":370,"context_line":"    enabled: \"{{ enable_ironic_neutron_agent | bool }}\""},{"line_number":371,"context_line":"  - name: \"l2population\""},{"line_number":372,"context_line":"    enabled: \"{{ not enable_hyperv | bool }} or {{ not neutron_plugin_agent \u003d\u003d \u0027ovn\u0027 }}\""},{"line_number":373,"context_line":"  - name: \"ovn\""},{"line_number":374,"context_line":"    enabled: \"{{ neutron_plugin_agent \u003d\u003d \u0027ovn\u0027 }}\""},{"line_number":375,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":88,"id":"3fa7e38b_53156be6","line":372,"range":{"start_line":372,"start_character":51,"end_line":372,"end_character":54},"in_reply_to":"3fa7e38b_5b30cb54","updated":"2020-02-20 17:40:38.000000000","message":"Done","commit_id":"63d8bebf731ef9127ce5ff117b7e28634e2e9911"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"f5552e44a7660dcfca2dcbe2a8f45dea6d21a4f3","unresolved":false,"context_lines":[{"line_number":124,"context_line":"      }}"},{"line_number":125,"context_line":"    volumes: \"{{ neutron_metadata_agent_default_volumes + neutron_metadata_agent_extra_volumes }}\""},{"line_number":126,"context_line":"    dimensions: \"{{ neutron_metadata_agent_dimensions }}\""},{"line_number":127,"context_line":"    config_file: \"{% if neutron_plugin_agent \u003d\u003d \u0027ovn\u0027 %}networking_ovn_metadata_agent.ini{% else %}metadata_agent.ini{% endif %}\""},{"line_number":128,"context_line":"  neutron-bgp-dragent:"},{"line_number":129,"context_line":"    container_name: \"neutron_bgp_dragent\""},{"line_number":130,"context_line":"    image: \"{{ neutron_bgp_dragent_image_full }}\""}],"source_content_type":"text/x-yaml","patch_set":96,"id":"1fa4df85_b12df3a9","line":127,"range":{"start_line":127,"start_character":4,"end_line":127,"end_character":15},"updated":"2020-02-24 17:04:24.000000000","message":"We normally use this data for looping over containers - if only one has an attribute it\u0027s probably better as a top level variable (neutron_metadata_agent_config_file)","commit_id":"d260246d723324577e2e1908cc6db8a29dc715af"},{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"2ea7573b912e7b224a752b043e6120230a141073","unresolved":false,"context_lines":[{"line_number":124,"context_line":"      }}"},{"line_number":125,"context_line":"    volumes: \"{{ neutron_metadata_agent_default_volumes + neutron_metadata_agent_extra_volumes }}\""},{"line_number":126,"context_line":"    dimensions: \"{{ neutron_metadata_agent_dimensions }}\""},{"line_number":127,"context_line":"    config_file: \"{% if neutron_plugin_agent \u003d\u003d \u0027ovn\u0027 %}networking_ovn_metadata_agent.ini{% else %}metadata_agent.ini{% endif %}\""},{"line_number":128,"context_line":"  neutron-bgp-dragent:"},{"line_number":129,"context_line":"    container_name: \"neutron_bgp_dragent\""},{"line_number":130,"context_line":"    image: \"{{ neutron_bgp_dragent_image_full }}\""}],"source_content_type":"text/x-yaml","patch_set":96,"id":"1fa4df85_0d14c7f4","line":127,"range":{"start_line":127,"start_character":4,"end_line":127,"end_character":15},"in_reply_to":"1fa4df85_b12df3a9","updated":"2020-02-27 06:36:02.000000000","message":"Done","commit_id":"d260246d723324577e2e1908cc6db8a29dc715af"},{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"5985c1e279cf1023f7103b82ef5f6b55eb0f1a34","unresolved":false,"context_lines":[{"line_number":363,"context_line":"  - name: \"baremetal\""},{"line_number":364,"context_line":"    enabled: \"{{ enable_ironic_neutron_agent | bool }}\""},{"line_number":365,"context_line":"  - name: \"l2population\""},{"line_number":366,"context_line":"    enabled: \"{{ not enable_hyperv | bool or neutron_plugin_agent !\u003d \u0027ovn\u0027 }}\""},{"line_number":367,"context_line":"  - name: \"ovn\""},{"line_number":368,"context_line":"    enabled: \"{{ neutron_plugin_agent \u003d\u003d \u0027ovn\u0027 }}\""},{"line_number":369,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":119,"id":"df33271e_60a027a7","line":366,"range":{"start_line":366,"start_character":42,"end_line":366,"end_character":44},"updated":"2020-03-21 08:56:50.000000000","message":"and","commit_id":"bac4ade03781b40901497a315f6fc6fc0708eaad"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"0c0fab1db5974ebe6fbfde16d97481ba697a41f4","unresolved":false,"context_lines":[{"line_number":108,"context_line":"    host_in_groups: \"{{ inventory_hostname in groups[\u0027compute\u0027] }}\""},{"line_number":109,"context_line":"    volumes: \"{{ neutron_sriov_agent_default_volumes + neutron_sriov_agent_extra_volumes }}\""},{"line_number":110,"context_line":"    dimensions: \"{{ neutron_sriov_agent_dimensions }}\""},{"line_number":111,"context_line":"  neutron-metadata-agent:"},{"line_number":112,"context_line":"    container_name: \"neutron_metadata_agent\""},{"line_number":113,"context_line":"    image: \"{{ neutron_metadata_agent_image_full }}\""},{"line_number":114,"context_line":"    privileged: True"}],"source_content_type":"text/x-yaml","patch_set":120,"id":"df33271e_8aa3cf00","line":111,"range":{"start_line":111,"start_character":2,"end_line":111,"end_character":24},"updated":"2020-04-03 15:50:38.000000000","message":"I think this should be a separate service. It\u0027s a different binary, runs on different hosts, and should have a different name.","commit_id":"b89944275ed552dc50909cb998987a461325d383"},{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"181dc6a3a46c7858c7a21afc3a029aabdd1ecff3","unresolved":false,"context_lines":[{"line_number":108,"context_line":"    host_in_groups: \"{{ inventory_hostname in groups[\u0027compute\u0027] }}\""},{"line_number":109,"context_line":"    volumes: \"{{ neutron_sriov_agent_default_volumes + neutron_sriov_agent_extra_volumes }}\""},{"line_number":110,"context_line":"    dimensions: \"{{ neutron_sriov_agent_dimensions }}\""},{"line_number":111,"context_line":"  neutron-metadata-agent:"},{"line_number":112,"context_line":"    container_name: \"neutron_metadata_agent\""},{"line_number":113,"context_line":"    image: \"{{ neutron_metadata_agent_image_full }}\""},{"line_number":114,"context_line":"    privileged: True"}],"source_content_type":"text/x-yaml","patch_set":120,"id":"df33271e_5e6488e5","line":111,"range":{"start_line":111,"start_character":2,"end_line":111,"end_character":24},"in_reply_to":"df33271e_6a5a67f3","updated":"2020-04-08 10:27:16.000000000","message":"Sorry, forgot - well, Radoslaw pointed out it should be the same - I can add a new entry - no problem - just work out a common decision :-)","commit_id":"b89944275ed552dc50909cb998987a461325d383"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"9e83381fcbbb72bc68a6937edc2fca0ff14a26ea","unresolved":false,"context_lines":[{"line_number":108,"context_line":"    host_in_groups: \"{{ inventory_hostname in groups[\u0027compute\u0027] }}\""},{"line_number":109,"context_line":"    volumes: \"{{ neutron_sriov_agent_default_volumes + neutron_sriov_agent_extra_volumes }}\""},{"line_number":110,"context_line":"    dimensions: \"{{ neutron_sriov_agent_dimensions }}\""},{"line_number":111,"context_line":"  neutron-metadata-agent:"},{"line_number":112,"context_line":"    container_name: \"neutron_metadata_agent\""},{"line_number":113,"context_line":"    image: \"{{ neutron_metadata_agent_image_full }}\""},{"line_number":114,"context_line":"    privileged: True"}],"source_content_type":"text/x-yaml","patch_set":120,"id":"df33271e_6a5a67f3","line":111,"range":{"start_line":111,"start_character":2,"end_line":111,"end_character":24},"in_reply_to":"df33271e_8aa3cf00","updated":"2020-04-08 09:49:32.000000000","message":"No?","commit_id":"b89944275ed552dc50909cb998987a461325d383"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"e43db5836a15be3bec43ae0f595404ad415094c0","unresolved":false,"context_lines":[{"line_number":127,"context_line":"    enabled: \"{{ neutron_plugin_agent \u003d\u003d \u0027ovn\u0027 }}\""},{"line_number":128,"context_line":"    host_in_groups: \u003e-"},{"line_number":129,"context_line":"      {{"},{"line_number":130,"context_line":"      inventory_hostname in groups[\u0027neutron-metadata-agent\u0027]"},{"line_number":131,"context_line":"      or (inventory_hostname in groups[\u0027compute\u0027] and neutron_plugin_agent \u003d\u003d \u0027ovn\u0027)"},{"line_number":132,"context_line":"      }}"},{"line_number":133,"context_line":"    volumes: \"{{ neutron_ovn_metadata_agent_default_volumes + neutron_ovn_metadata_agent_extra_volumes }}\""}],"source_content_type":"text/x-yaml","patch_set":124,"id":"df33271e_f42adde4","line":130,"range":{"start_line":130,"start_character":35,"end_line":130,"end_character":58},"updated":"2020-04-08 11:57:15.000000000","message":"separate group?","commit_id":"5e3e93cd679f08da5721a7a7955d434a0cff6d34"},{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"592e8c929688dcbe1b57f8e259044f846a6a6f8b","unresolved":false,"context_lines":[{"line_number":127,"context_line":"    enabled: \"{{ neutron_plugin_agent \u003d\u003d \u0027ovn\u0027 }}\""},{"line_number":128,"context_line":"    host_in_groups: \u003e-"},{"line_number":129,"context_line":"      {{"},{"line_number":130,"context_line":"      inventory_hostname in groups[\u0027neutron-metadata-agent\u0027]"},{"line_number":131,"context_line":"      or (inventory_hostname in groups[\u0027compute\u0027] and neutron_plugin_agent \u003d\u003d \u0027ovn\u0027)"},{"line_number":132,"context_line":"      }}"},{"line_number":133,"context_line":"    volumes: \"{{ neutron_ovn_metadata_agent_default_volumes + neutron_ovn_metadata_agent_extra_volumes }}\""}],"source_content_type":"text/x-yaml","patch_set":124,"id":"df33271e_f462dd15","line":130,"range":{"start_line":130,"start_character":35,"end_line":130,"end_character":58},"in_reply_to":"df33271e_f42adde4","updated":"2020-04-08 12:05:11.000000000","message":"Done","commit_id":"5e3e93cd679f08da5721a7a7955d434a0cff6d34"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"e43db5836a15be3bec43ae0f595404ad415094c0","unresolved":false,"context_lines":[{"line_number":128,"context_line":"    host_in_groups: \u003e-"},{"line_number":129,"context_line":"      {{"},{"line_number":130,"context_line":"      inventory_hostname in groups[\u0027neutron-metadata-agent\u0027]"},{"line_number":131,"context_line":"      or (inventory_hostname in groups[\u0027compute\u0027] and neutron_plugin_agent \u003d\u003d \u0027ovn\u0027)"},{"line_number":132,"context_line":"      }}"},{"line_number":133,"context_line":"    volumes: \"{{ neutron_ovn_metadata_agent_default_volumes + neutron_ovn_metadata_agent_extra_volumes }}\""},{"line_number":134,"context_line":"    dimensions: \"{{ neutron_ovn_metadata_agent_dimensions }}\""}],"source_content_type":"text/x-yaml","patch_set":124,"id":"df33271e_145f8172","line":131,"range":{"start_line":131,"start_character":50,"end_line":131,"end_character":83},"updated":"2020-04-08 11:57:15.000000000","message":"not required","commit_id":"5e3e93cd679f08da5721a7a7955d434a0cff6d34"},{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"592e8c929688dcbe1b57f8e259044f846a6a6f8b","unresolved":false,"context_lines":[{"line_number":128,"context_line":"    host_in_groups: \u003e-"},{"line_number":129,"context_line":"      {{"},{"line_number":130,"context_line":"      inventory_hostname in groups[\u0027neutron-metadata-agent\u0027]"},{"line_number":131,"context_line":"      or (inventory_hostname in groups[\u0027compute\u0027] and neutron_plugin_agent \u003d\u003d \u0027ovn\u0027)"},{"line_number":132,"context_line":"      }}"},{"line_number":133,"context_line":"    volumes: \"{{ neutron_ovn_metadata_agent_default_volumes + neutron_ovn_metadata_agent_extra_volumes }}\""},{"line_number":134,"context_line":"    dimensions: \"{{ neutron_ovn_metadata_agent_dimensions }}\""}],"source_content_type":"text/x-yaml","patch_set":124,"id":"df33271e_d465191f","line":131,"range":{"start_line":131,"start_character":50,"end_line":131,"end_character":83},"in_reply_to":"df33271e_145f8172","updated":"2020-04-08 12:05:11.000000000","message":"Done","commit_id":"5e3e93cd679f08da5721a7a7955d434a0cff6d34"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"e43db5836a15be3bec43ae0f595404ad415094c0","unresolved":false,"context_lines":[{"line_number":130,"context_line":"      inventory_hostname in groups[\u0027neutron-metadata-agent\u0027]"},{"line_number":131,"context_line":"      or (inventory_hostname in groups[\u0027compute\u0027] and neutron_plugin_agent \u003d\u003d \u0027ovn\u0027)"},{"line_number":132,"context_line":"      }}"},{"line_number":133,"context_line":"    volumes: \"{{ neutron_ovn_metadata_agent_default_volumes + neutron_ovn_metadata_agent_extra_volumes }}\""},{"line_number":134,"context_line":"    dimensions: \"{{ neutron_ovn_metadata_agent_dimensions }}\""},{"line_number":135,"context_line":"  neutron-bgp-dragent:"},{"line_number":136,"context_line":"    container_name: \"neutron_bgp_dragent\""},{"line_number":137,"context_line":"    image: \"{{ neutron_bgp_dragent_image_full }}\""}],"source_content_type":"text/x-yaml","patch_set":124,"id":"df33271e_34aba589","line":134,"range":{"start_line":133,"start_character":0,"end_line":134,"end_character":61},"updated":"2020-04-08 11:57:15.000000000","message":"Needs volumes and dimensions","commit_id":"5e3e93cd679f08da5721a7a7955d434a0cff6d34"},{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"592e8c929688dcbe1b57f8e259044f846a6a6f8b","unresolved":false,"context_lines":[{"line_number":130,"context_line":"      inventory_hostname in groups[\u0027neutron-metadata-agent\u0027]"},{"line_number":131,"context_line":"      or (inventory_hostname in groups[\u0027compute\u0027] and neutron_plugin_agent \u003d\u003d \u0027ovn\u0027)"},{"line_number":132,"context_line":"      }}"},{"line_number":133,"context_line":"    volumes: \"{{ neutron_ovn_metadata_agent_default_volumes + neutron_ovn_metadata_agent_extra_volumes }}\""},{"line_number":134,"context_line":"    dimensions: \"{{ neutron_ovn_metadata_agent_dimensions }}\""},{"line_number":135,"context_line":"  neutron-bgp-dragent:"},{"line_number":136,"context_line":"    container_name: \"neutron_bgp_dragent\""},{"line_number":137,"context_line":"    image: \"{{ neutron_bgp_dragent_image_full }}\""}],"source_content_type":"text/x-yaml","patch_set":124,"id":"df33271e_346d6504","line":134,"range":{"start_line":133,"start_character":0,"end_line":134,"end_character":61},"in_reply_to":"df33271e_34aba589","updated":"2020-04-08 12:05:11.000000000","message":"Done","commit_id":"5e3e93cd679f08da5721a7a7955d434a0cff6d34"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"147f3e342d656bb56a6eeed2e48b2f8a6bfdd113","unresolved":false,"context_lines":[{"line_number":125,"context_line":"    image: \"{{ neutron_ovn_metadata_agent_image_full }}\""},{"line_number":126,"context_line":"    privileged: True"},{"line_number":127,"context_line":"    enabled: \"{{ neutron_plugin_agent \u003d\u003d \u0027ovn\u0027 }}\""},{"line_number":128,"context_line":"    host_in_groups: \u003e-"},{"line_number":129,"context_line":"      {{"},{"line_number":130,"context_line":"      inventory_hostname in groups[\u0027neutron-ovn-metadata-agent\u0027]"},{"line_number":131,"context_line":"      }}"},{"line_number":132,"context_line":"    volumes: \"{{ neutron_ovn_metadata_agent_default_volumes + neutron_ovn_metadata_agent_extra_volumes }}\""},{"line_number":133,"context_line":"    dimensions: \"{{ neutron_ovn_metadata_agent_dimensions }}\""},{"line_number":134,"context_line":"  neutron-bgp-dragent:"}],"source_content_type":"text/x-yaml","patch_set":126,"id":"df33271e_ad4f6432","line":131,"range":{"start_line":128,"start_character":0,"end_line":131,"end_character":8},"updated":"2020-04-08 13:25:56.000000000","message":"nit: one line","commit_id":"b35e6c10c72d42c2e21027bf0d56ce4172b5a6fb"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"c6204e8a71e15215fd6b70af474737d0550f81d8","unresolved":false,"context_lines":[{"line_number":287,"context_line":"  - \"{{ node_config_directory }}/neutron-metadata-agent/:{{ container_config_directory }}/:ro\""},{"line_number":288,"context_line":"  - \"/etc/localtime:/etc/localtime:ro\""},{"line_number":289,"context_line":"  - \"neutron_metadata_socket:/var/lib/neutron/kolla/\""},{"line_number":290,"context_line":"  - \"{% if neutron_plugin_agent \u003d\u003d \u0027ovn\u0027 %}/run/openvswitch:/run/openvswitch:shared{% endif %}\""},{"line_number":291,"context_line":"  - \"{% if neutron_plugin_agent \u003d\u003d \u0027ovn\u0027 %}/run/netns:/run/netns:shared{% endif %}\""},{"line_number":292,"context_line":"  - \"kolla_logs:/var/log/kolla/\""},{"line_number":293,"context_line":"  - \"{{ kolla_dev_repos_directory ~ \u0027/neutron/neutron:/var/lib/kolla/venv/lib/python\u0027 ~ distro_python_version ~ \u0027/site-packages/neutron\u0027 if neutron_dev_mode | bool else \u0027\u0027 }}\""},{"line_number":294,"context_line":"neutron_ovn_metadata_agent_default_volumes:"}],"source_content_type":"text/x-yaml","patch_set":126,"id":"df33271e_4da5f803","line":291,"range":{"start_line":290,"start_character":0,"end_line":291,"end_character":83},"updated":"2020-04-08 13:22:30.000000000","message":"Not required","commit_id":"b35e6c10c72d42c2e21027bf0d56ce4172b5a6fb"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"c6204e8a71e15215fd6b70af474737d0550f81d8","unresolved":false,"context_lines":[{"line_number":292,"context_line":"  - \"kolla_logs:/var/log/kolla/\""},{"line_number":293,"context_line":"  - \"{{ kolla_dev_repos_directory ~ \u0027/neutron/neutron:/var/lib/kolla/venv/lib/python\u0027 ~ distro_python_version ~ \u0027/site-packages/neutron\u0027 if neutron_dev_mode | bool else \u0027\u0027 }}\""},{"line_number":294,"context_line":"neutron_ovn_metadata_agent_default_volumes:"},{"line_number":295,"context_line":"  - \"{{ node_config_directory }}/neutron-metadata-agent/:{{ container_config_directory }}/:ro\""},{"line_number":296,"context_line":"  - \"/etc/localtime:/etc/localtime:ro\""},{"line_number":297,"context_line":"  - \"neutron_metadata_socket:/var/lib/neutron/kolla/\""},{"line_number":298,"context_line":"  - \"/run/openvswitch:/run/openvswitch:shared\""}],"source_content_type":"text/x-yaml","patch_set":126,"id":"df33271e_cdb8e82b","line":295,"range":{"start_line":295,"start_character":33,"end_line":295,"end_character":55},"updated":"2020-04-08 13:22:30.000000000","message":"neutron-ovn-metadata-agent","commit_id":"b35e6c10c72d42c2e21027bf0d56ce4172b5a6fb"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"a1164921a20ee6eec7cdbfd9aa689e88ca22218c","unresolved":false,"context_lines":[{"line_number":368,"context_line":"neutron_l3_agent_host_ipv6_neigh_gc_thresh2: \"{{ neutron_l3_agent_host_ipv4_neigh_gc_thresh2 }}\""},{"line_number":369,"context_line":"neutron_l3_agent_host_ipv6_neigh_gc_thresh3: \"{{ neutron_l3_agent_host_ipv4_neigh_gc_thresh3 }}\""},{"line_number":370,"context_line":""},{"line_number":371,"context_line":"neutron_metadata_agent_config_file: \"{% if neutron_plugin_agent \u003d\u003d \u0027ovn\u0027 %}neutron_ovn_metadata_agent.ini{% else %}metadata_agent.ini{% endif %}\""},{"line_number":372,"context_line":""},{"line_number":373,"context_line":"####################"},{"line_number":374,"context_line":"# Mechanism drivers"}],"source_content_type":"text/x-yaml","patch_set":129,"id":"df33271e_28f6a2fa","line":371,"range":{"start_line":371,"start_character":0,"end_line":371,"end_character":34},"updated":"2020-04-08 14:00:25.000000000","message":"not required","commit_id":"f7785df573de72c8fd890d32fe5512e9b6abbe7a"},{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"38dec3074c89a6cd9782812fb9de1903d7b5bcba","unresolved":false,"context_lines":[{"line_number":199,"context_line":"neutron_metadata_agent_tag: \"{{ neutron_tag }}\""},{"line_number":200,"context_line":"neutron_metadata_agent_image_full: \"{{ neutron_metadata_agent_image }}:{{ neutron_metadata_agent_tag }}\""},{"line_number":201,"context_line":""},{"line_number":202,"context_line":"neutron_ovn_metadata_agent_image: \"{{ docker_registry ~ \u0027/\u0027 if docker_registry else \u0027\u0027 }}{{ docker_namespace }}/{{ kolla_base_distro }}-{{ neutron_install_type }}-neutron-metadata-agent\""},{"line_number":203,"context_line":"neutron_ovn_metadata_agent_tag: \"{{ neutron_tag }}\""},{"line_number":204,"context_line":"neutron_ovn_metadata_agent_image_full: \"{{ neutron_ovn_metadata_agent_image }}:{{ neutron_ovn_metadata_agent_tag }}\""},{"line_number":205,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":134,"id":"df33271e_702fd987","line":202,"range":{"start_line":202,"start_character":163,"end_line":202,"end_character":185},"updated":"2020-04-09 07:42:08.000000000","message":"Since this is a different binary with different behavior - maybe we should still use a separate image? That would avoid the last bastion of confusion. ;-)","commit_id":"8a0740df977916fa5b23117f993cde7282a303bf"},{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"296d21b0f5581ed1c05db9669d9be5092779ec75","unresolved":false,"context_lines":[{"line_number":381,"context_line":"  - name: \"baremetal\""},{"line_number":382,"context_line":"    enabled: \"{{ enable_ironic_neutron_agent | bool }}\""},{"line_number":383,"context_line":"  - name: \"l2population\""},{"line_number":384,"context_line":"    enabled: \"{{ not enable_hyperv | bool or neutron_plugin_agent !\u003d \u0027ovn\u0027 }}\""},{"line_number":385,"context_line":"  - name: \"ovn\""},{"line_number":386,"context_line":"    enabled: \"{{ neutron_plugin_agent \u003d\u003d \u0027ovn\u0027 }}\""},{"line_number":387,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":134,"id":"3f4c43b2_0974b167","line":384,"range":{"start_line":384,"start_character":42,"end_line":384,"end_character":44},"updated":"2020-04-15 17:55:06.000000000","message":"and, now you have l2population enabled! https://9e3c7783c34af633d765-877a0f70cfb612990952d1399a198d7a.ssl.cf2.rackcdn.com/696841/134/check/kolla-ansible-centos8-source-ovn/2ec19a9/primary/logs/kolla_configs/neutron-server/ml2_conf.ini","commit_id":"8a0740df977916fa5b23117f993cde7282a303bf"}],"ansible/roles/neutron/tasks/config.yml":[{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"afbf6c432c56351f1d06b67e66db1dc1129020f4","unresolved":false,"context_lines":[{"line_number":325,"context_line":"    - neutron_plugin_agent not in [\u0027ovn\u0027]"},{"line_number":326,"context_line":"  notify:"},{"line_number":327,"context_line":"    - \"Restart {{ service_name }} container\""},{"line_number":328,"context_line":""},{"line_number":329,"context_line":"- name: Copying over networking_ovn_metadata_agent.ini"},{"line_number":330,"context_line":"  become: true"},{"line_number":331,"context_line":"  vars:"},{"line_number":332,"context_line":"    service_name: \"neutron-metadata-agent\""},{"line_number":333,"context_line":"    neutron_metadata_agent: \"{{ neutron_services[service_name] }}\""},{"line_number":334,"context_line":"  merge_configs:"},{"line_number":335,"context_line":"    sources:"},{"line_number":336,"context_line":"      - \"{{ role_path }}/templates/networking_ovn_metadata_agent.ini.j2\""},{"line_number":337,"context_line":"      - \"{{ node_custom_config }}/neutron/networking_ovn_metadata_agent.ini\""},{"line_number":338,"context_line":"    dest: \"{{ node_config_directory }}/{{ service_name }}/networking_ovn_metadata_agent.ini\""},{"line_number":339,"context_line":"    mode: \"0660\""},{"line_number":340,"context_line":"  when:"},{"line_number":341,"context_line":"    - neutron_metadata_agent.enabled | bool"},{"line_number":342,"context_line":"    - neutron_metadata_agent.host_in_groups | bool"},{"line_number":343,"context_line":"    - neutron_plugin_agent \u003d\u003d \"ovn\""},{"line_number":344,"context_line":"  notify:"},{"line_number":345,"context_line":"    - \"Restart {{ service_name }} container\""},{"line_number":346,"context_line":""},{"line_number":347,"context_line":"- name: Copying over metering_agent.ini"},{"line_number":348,"context_line":"  become: true"}],"source_content_type":"text/x-yaml","patch_set":92,"id":"3fa7e38b_8ed991f2","line":345,"range":{"start_line":328,"start_character":0,"end_line":345,"end_character":44},"updated":"2020-02-19 18:08:18.000000000","message":"We could collapse this into a single task using a variable for the file name that depends on neutron_plugin_agent.","commit_id":"cc297570e75246673c6576c43b12e44f98f646f9"},{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"cab58a4dd51758dad06a8eb0627874b67e6853cf","unresolved":false,"context_lines":[{"line_number":325,"context_line":"    - neutron_plugin_agent not in [\u0027ovn\u0027]"},{"line_number":326,"context_line":"  notify:"},{"line_number":327,"context_line":"    - \"Restart {{ service_name }} container\""},{"line_number":328,"context_line":""},{"line_number":329,"context_line":"- name: Copying over networking_ovn_metadata_agent.ini"},{"line_number":330,"context_line":"  become: true"},{"line_number":331,"context_line":"  vars:"},{"line_number":332,"context_line":"    service_name: \"neutron-metadata-agent\""},{"line_number":333,"context_line":"    neutron_metadata_agent: \"{{ neutron_services[service_name] }}\""},{"line_number":334,"context_line":"  merge_configs:"},{"line_number":335,"context_line":"    sources:"},{"line_number":336,"context_line":"      - \"{{ role_path }}/templates/networking_ovn_metadata_agent.ini.j2\""},{"line_number":337,"context_line":"      - \"{{ node_custom_config }}/neutron/networking_ovn_metadata_agent.ini\""},{"line_number":338,"context_line":"    dest: \"{{ node_config_directory }}/{{ service_name }}/networking_ovn_metadata_agent.ini\""},{"line_number":339,"context_line":"    mode: \"0660\""},{"line_number":340,"context_line":"  when:"},{"line_number":341,"context_line":"    - neutron_metadata_agent.enabled | bool"},{"line_number":342,"context_line":"    - neutron_metadata_agent.host_in_groups | bool"},{"line_number":343,"context_line":"    - neutron_plugin_agent \u003d\u003d \"ovn\""},{"line_number":344,"context_line":"  notify:"},{"line_number":345,"context_line":"    - \"Restart {{ service_name }} container\""},{"line_number":346,"context_line":""},{"line_number":347,"context_line":"- name: Copying over metering_agent.ini"},{"line_number":348,"context_line":"  become: true"}],"source_content_type":"text/x-yaml","patch_set":92,"id":"3fa7e38b_33378f4f","line":345,"range":{"start_line":328,"start_character":0,"end_line":345,"end_character":44},"in_reply_to":"3fa7e38b_8ed991f2","updated":"2020-02-20 17:40:38.000000000","message":"Done","commit_id":"cc297570e75246673c6576c43b12e44f98f646f9"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"e43db5836a15be3bec43ae0f595404ad415094c0","unresolved":false,"context_lines":[{"line_number":292,"context_line":"  merge_configs:"},{"line_number":293,"context_line":"    sources:"},{"line_number":294,"context_line":"      - \"{{ role_path }}/templates/metadata_agent.ini.j2\""},{"line_number":295,"context_line":"      - \"{{ node_custom_config }}/neutron/metadata_agent.ini.j2\""},{"line_number":296,"context_line":"    dest: \"{{ node_config_directory }}/{{ service_name }}/metadata_agent.ini\""},{"line_number":297,"context_line":"    mode: \"0660\""},{"line_number":298,"context_line":"  when:"}],"source_content_type":"text/x-yaml","patch_set":124,"id":"df33271e_54d589b6","line":295,"range":{"start_line":295,"start_character":60,"end_line":295,"end_character":63},"updated":"2020-04-08 11:57:15.000000000","message":"No .j2","commit_id":"5e3e93cd679f08da5721a7a7955d434a0cff6d34"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"e43db5836a15be3bec43ae0f595404ad415094c0","unresolved":false,"context_lines":[{"line_number":309,"context_line":"  merge_configs:"},{"line_number":310,"context_line":"    sources:"},{"line_number":311,"context_line":"      - \"{{ role_path }}/templates/neutron_ovn_metadata_agent.ini.j2\""},{"line_number":312,"context_line":"      - \"{{ node_custom_config }}/neutron/neutron_ovn_metadata_agent.ini.j2\""},{"line_number":313,"context_line":"    dest: \"{{ node_config_directory }}/{{ service_name }}/neutron_ovn_metadata_agent.ini\""},{"line_number":314,"context_line":"    mode: \"0660"},{"line_number":315,"context_line":"  when:"}],"source_content_type":"text/x-yaml","patch_set":124,"id":"df33271e_94df11d5","line":312,"range":{"start_line":312,"start_character":72,"end_line":312,"end_character":75},"updated":"2020-04-08 11:57:15.000000000","message":"ditto","commit_id":"5e3e93cd679f08da5721a7a7955d434a0cff6d34"}],"ansible/roles/neutron/templates/ml2_conf.ini.j2":[{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"fe200e577209100b76e38ab7c7ed5a128663a034","unresolved":false,"context_lines":[{"line_number":30,"context_line":"[ml2_type_vxlan]"},{"line_number":31,"context_line":"vni_ranges \u003d 1:1000"},{"line_number":32,"context_line":""},{"line_number":33,"context_line":"[ml2_type_geneve]"},{"line_number":34,"context_line":"vni_ranges \u003d 1001:2000"},{"line_number":35,"context_line":""},{"line_number":36,"context_line":"{% if enable_ovn | bool %}"},{"line_number":37,"context_line":"[securitygroup]"}],"source_content_type":"text/x-jinja2","patch_set":71,"id":"3fa7e38b_5b55d950","line":34,"range":{"start_line":33,"start_character":0,"end_line":34,"end_character":22},"updated":"2020-01-10 10:30:22.000000000","message":"(1)... and this we break deployments for ppl who expanded the vxlan range. Maybe don\u0027t add the type driver either when not using ovn?","commit_id":"6543a07da1dce58601d70bb65fadb053c99e4f5a"},{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"ca4cd4772f87b7325ac013e2c76d0fd3dbbdf3b0","unresolved":false,"context_lines":[{"line_number":30,"context_line":"[ml2_type_vxlan]"},{"line_number":31,"context_line":"vni_ranges \u003d 1:1000"},{"line_number":32,"context_line":""},{"line_number":33,"context_line":"[ml2_type_geneve]"},{"line_number":34,"context_line":"vni_ranges \u003d 1001:2000"},{"line_number":35,"context_line":""},{"line_number":36,"context_line":"{% if enable_ovn | bool %}"},{"line_number":37,"context_line":"[securitygroup]"}],"source_content_type":"text/x-jinja2","patch_set":71,"id":"3fa7e38b_268d6434","line":34,"range":{"start_line":33,"start_character":0,"end_line":34,"end_character":22},"in_reply_to":"3fa7e38b_5b55d950","updated":"2020-01-10 11:37:29.000000000","message":"Done.","commit_id":"6543a07da1dce58601d70bb65fadb053c99e4f5a"},{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"fe200e577209100b76e38ab7c7ed5a128663a034","unresolved":false,"context_lines":[{"line_number":40,"context_line":"[ovn]"},{"line_number":41,"context_line":"ovn_nb_connection \u003d {{ ovn_nb_connection }}"},{"line_number":42,"context_line":"ovn_sb_connection \u003d {{ ovn_sb_connection }}"},{"line_number":43,"context_line":"ovn_l3_scheduler \u003d leastloaded"},{"line_number":44,"context_line":"{% endif %}"}],"source_content_type":"text/x-jinja2","patch_set":71,"id":"3fa7e38b_fb3cc52d","line":43,"range":{"start_line":43,"start_character":19,"end_line":43,"end_character":30},"updated":"2020-01-10 10:30:22.000000000","message":"best practices? :D","commit_id":"6543a07da1dce58601d70bb65fadb053c99e4f5a"},{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"1da608c04abce32d89c6acb4e673d1a36b16d794","unresolved":false,"context_lines":[{"line_number":40,"context_line":"[ovn]"},{"line_number":41,"context_line":"ovn_nb_connection \u003d {{ ovn_nb_connection }}"},{"line_number":42,"context_line":"ovn_sb_connection \u003d {{ ovn_sb_connection }}"},{"line_number":43,"context_line":"ovn_l3_scheduler \u003d leastloaded"},{"line_number":44,"context_line":"{% endif %}"}],"source_content_type":"text/x-jinja2","patch_set":71,"id":"3fa7e38b_46b18090","line":43,"range":{"start_line":43,"start_character":19,"end_line":43,"end_character":30},"in_reply_to":"3fa7e38b_66a7dcbc","updated":"2020-01-10 11:44:55.000000000","message":"Cool. :-)","commit_id":"6543a07da1dce58601d70bb65fadb053c99e4f5a"},{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"ca4cd4772f87b7325ac013e2c76d0fd3dbbdf3b0","unresolved":false,"context_lines":[{"line_number":40,"context_line":"[ovn]"},{"line_number":41,"context_line":"ovn_nb_connection \u003d {{ ovn_nb_connection }}"},{"line_number":42,"context_line":"ovn_sb_connection \u003d {{ ovn_sb_connection }}"},{"line_number":43,"context_line":"ovn_l3_scheduler \u003d leastloaded"},{"line_number":44,"context_line":"{% endif %}"}],"source_content_type":"text/x-jinja2","patch_set":71,"id":"3fa7e38b_66a7dcbc","line":43,"range":{"start_line":43,"start_character":19,"end_line":43,"end_character":30},"in_reply_to":"3fa7e38b_fb3cc52d","updated":"2020-01-10 11:37:29.000000000","message":"yup, it\u0027s either leastloaded (number of routers per physical node) or chance (as the name suggests - random)","commit_id":"6543a07da1dce58601d70bb65fadb053c99e4f5a"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"afbf6c432c56351f1d06b67e66db1dc1129020f4","unresolved":false,"context_lines":[{"line_number":31,"context_line":"vni_ranges \u003d 1:1000"},{"line_number":32,"context_line":""},{"line_number":33,"context_line":"{% if neutron_plugin_agent \u003d\u003d \u0027ovn\u0027 %}"},{"line_number":34,"context_line":"[ml2_type_geneve]"},{"line_number":35,"context_line":"vni_ranges \u003d 1001:2000"},{"line_number":36,"context_line":""},{"line_number":37,"context_line":"[securitygroup]"},{"line_number":38,"context_line":"enable_security_group \u003d True"}],"source_content_type":"text/x-jinja2","patch_set":88,"id":"3fa7e38b_7b5ca77f","line":35,"range":{"start_line":34,"start_character":0,"end_line":35,"end_character":22},"updated":"2020-02-19 18:08:18.000000000","message":"Why do we have an opinion on this?","commit_id":"63d8bebf731ef9127ce5ff117b7e28634e2e9911"},{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"cab58a4dd51758dad06a8eb0627874b67e6853cf","unresolved":false,"context_lines":[{"line_number":31,"context_line":"vni_ranges \u003d 1:1000"},{"line_number":32,"context_line":""},{"line_number":33,"context_line":"{% if neutron_plugin_agent \u003d\u003d \u0027ovn\u0027 %}"},{"line_number":34,"context_line":"[ml2_type_geneve]"},{"line_number":35,"context_line":"vni_ranges \u003d 1001:2000"},{"line_number":36,"context_line":""},{"line_number":37,"context_line":"[securitygroup]"},{"line_number":38,"context_line":"enable_security_group \u003d True"}],"source_content_type":"text/x-jinja2","patch_set":88,"id":"3fa7e38b_737bc7f2","line":35,"range":{"start_line":34,"start_character":0,"end_line":35,"end_character":22},"in_reply_to":"3fa7e38b_5487a612","updated":"2020-02-20 17:40:38.000000000","message":"We could fine tune it as a variable in a followup, or compute based on existence of vxlan or not - actually with ovn we do not need vxlan, but if somebody wants to do l2gw integration in future - vxlan definition will come in handy.","commit_id":"63d8bebf731ef9127ce5ff117b7e28634e2e9911"},{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"b9736df7fcc591250394e349b31134f434004176","unresolved":false,"context_lines":[{"line_number":31,"context_line":"vni_ranges \u003d 1:1000"},{"line_number":32,"context_line":""},{"line_number":33,"context_line":"{% if neutron_plugin_agent \u003d\u003d \u0027ovn\u0027 %}"},{"line_number":34,"context_line":"[ml2_type_geneve]"},{"line_number":35,"context_line":"vni_ranges \u003d 1001:2000"},{"line_number":36,"context_line":""},{"line_number":37,"context_line":"[securitygroup]"},{"line_number":38,"context_line":"enable_security_group \u003d True"}],"source_content_type":"text/x-jinja2","patch_set":88,"id":"3fa7e38b_5487a612","line":35,"range":{"start_line":34,"start_character":0,"end_line":35,"end_character":22},"in_reply_to":"3fa7e38b_7b5ca77f","updated":"2020-02-19 18:48:08.000000000","message":"as we do for vxlan ;-)","commit_id":"63d8bebf731ef9127ce5ff117b7e28634e2e9911"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"afbf6c432c56351f1d06b67e66db1dc1129020f4","unresolved":false,"context_lines":[{"line_number":34,"context_line":"[ml2_type_geneve]"},{"line_number":35,"context_line":"vni_ranges \u003d 1001:2000"},{"line_number":36,"context_line":""},{"line_number":37,"context_line":"[securitygroup]"},{"line_number":38,"context_line":"enable_security_group \u003d True"},{"line_number":39,"context_line":""},{"line_number":40,"context_line":"[ovn]"},{"line_number":41,"context_line":"ovn_nb_connection \u003d {{ ovn_nb_connection }}"}],"source_content_type":"text/x-jinja2","patch_set":88,"id":"3fa7e38b_5b576b5a","line":38,"range":{"start_line":37,"start_character":0,"end_line":38,"end_character":28},"updated":"2020-02-19 18:08:18.000000000","message":"This is the default","commit_id":"63d8bebf731ef9127ce5ff117b7e28634e2e9911"},{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"cab58a4dd51758dad06a8eb0627874b67e6853cf","unresolved":false,"context_lines":[{"line_number":34,"context_line":"[ml2_type_geneve]"},{"line_number":35,"context_line":"vni_ranges \u003d 1001:2000"},{"line_number":36,"context_line":""},{"line_number":37,"context_line":"[securitygroup]"},{"line_number":38,"context_line":"enable_security_group \u003d True"},{"line_number":39,"context_line":""},{"line_number":40,"context_line":"[ovn]"},{"line_number":41,"context_line":"ovn_nb_connection \u003d {{ ovn_nb_connection }}"}],"source_content_type":"text/x-jinja2","patch_set":88,"id":"3fa7e38b_930f6337","line":38,"range":{"start_line":37,"start_character":0,"end_line":38,"end_character":28},"in_reply_to":"3fa7e38b_5b576b5a","updated":"2020-02-20 17:40:38.000000000","message":"Done","commit_id":"63d8bebf731ef9127ce5ff117b7e28634e2e9911"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"afbf6c432c56351f1d06b67e66db1dc1129020f4","unresolved":false,"context_lines":[{"line_number":40,"context_line":"[ovn]"},{"line_number":41,"context_line":"ovn_nb_connection \u003d {{ ovn_nb_connection }}"},{"line_number":42,"context_line":"ovn_sb_connection \u003d {{ ovn_sb_connection }}"},{"line_number":43,"context_line":"ovn_l3_scheduler \u003d leastloaded"},{"line_number":44,"context_line":"{% endif %}"}],"source_content_type":"text/x-jinja2","patch_set":92,"id":"3fa7e38b_0eb5a17d","line":43,"range":{"start_line":43,"start_character":0,"end_line":43,"end_character":30},"updated":"2020-02-19 18:08:18.000000000","message":"This is the default","commit_id":"cc297570e75246673c6576c43b12e44f98f646f9"},{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"cab58a4dd51758dad06a8eb0627874b67e6853cf","unresolved":false,"context_lines":[{"line_number":40,"context_line":"[ovn]"},{"line_number":41,"context_line":"ovn_nb_connection \u003d {{ ovn_nb_connection }}"},{"line_number":42,"context_line":"ovn_sb_connection \u003d {{ ovn_sb_connection }}"},{"line_number":43,"context_line":"ovn_l3_scheduler \u003d leastloaded"},{"line_number":44,"context_line":"{% endif %}"}],"source_content_type":"text/x-jinja2","patch_set":92,"id":"3fa7e38b_76017503","line":43,"range":{"start_line":43,"start_character":0,"end_line":43,"end_character":30},"in_reply_to":"3fa7e38b_0eb5a17d","updated":"2020-02-20 17:40:38.000000000","message":"Done","commit_id":"cc297570e75246673c6576c43b12e44f98f646f9"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"0c0fab1db5974ebe6fbfde16d97481ba697a41f4","unresolved":false,"context_lines":[{"line_number":33,"context_line":"{% if neutron_plugin_agent \u003d\u003d \u0027ovn\u0027 %}"},{"line_number":34,"context_line":"[ml2_type_geneve]"},{"line_number":35,"context_line":"vni_ranges \u003d 1001:2000"},{"line_number":36,"context_line":"max_header_size \u003d 38"},{"line_number":37,"context_line":""},{"line_number":38,"context_line":"[ovn]"},{"line_number":39,"context_line":"ovn_nb_connection \u003d {{ ovn_nb_connection }}"}],"source_content_type":"text/x-jinja2","patch_set":120,"id":"df33271e_4477000a","line":36,"range":{"start_line":36,"start_character":0,"end_line":36,"end_character":15},"updated":"2020-04-03 15:50:38.000000000","message":"I think this deserves a comment. Does it depend on IPv4 vs 6?","commit_id":"b89944275ed552dc50909cb998987a461325d383"},{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"39455fcedf36f62cc21d27716659c200d0c3f3df","unresolved":false,"context_lines":[{"line_number":33,"context_line":"{% if neutron_plugin_agent \u003d\u003d \u0027ovn\u0027 %}"},{"line_number":34,"context_line":"[ml2_type_geneve]"},{"line_number":35,"context_line":"vni_ranges \u003d 1001:2000"},{"line_number":36,"context_line":"max_header_size \u003d 38"},{"line_number":37,"context_line":""},{"line_number":38,"context_line":"[ovn]"},{"line_number":39,"context_line":"ovn_nb_connection \u003d {{ ovn_nb_connection }}"}],"source_content_type":"text/x-jinja2","patch_set":120,"id":"df33271e_2ab71e3d","line":36,"range":{"start_line":36,"start_character":0,"end_line":36,"end_character":15},"in_reply_to":"df33271e_4477000a","updated":"2020-04-03 17:27:39.000000000","message":"nope, it doesn\u0027t; neutron needed 30, ovn needs 38","commit_id":"b89944275ed552dc50909cb998987a461325d383"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"1ea47a404c10db30f8a683ff829fe73dcbc019dc","unresolved":false,"context_lines":[{"line_number":39,"context_line":"ovn_nb_connection \u003d {{ ovn_nb_connection }}"},{"line_number":40,"context_line":"ovn_sb_connection \u003d {{ ovn_sb_connection }}"},{"line_number":41,"context_line":"ovn_metadata_enabled \u003d True"},{"line_number":42,"context_line":"{% if enable_distributed_floating_ip | bool %}"},{"line_number":43,"context_line":"enable_distributed_floating_ip \u003d true"},{"line_number":44,"context_line":"{% endif %}"},{"line_number":45,"context_line":"enable_distributed_floating_ip \u003d true"},{"line_number":46,"context_line":"{% endif %}"}],"source_content_type":"text/x-jinja2","patch_set":130,"id":"df33271e_232b6530","line":45,"range":{"start_line":42,"start_character":0,"end_line":45,"end_character":37},"updated":"2020-04-08 14:23:15.000000000","message":"enable_distributed_floating_ip \u003d {{ neutron_ovn_distributed_fip | bool }}","commit_id":"79e1a6dcda1730aa97d52f1a0862ceb627d80181"}],"ansible/roles/neutron/templates/networking_ovn_metadata_agent.ini.j2":[{"author":{"_account_id":19316,"name":"Eduardo Gonzalez","email":"dabarren@gmail.com","username":"egonzalez90"},"change_message_id":"67a913b8e252b00b268dd84dc497ff615133738f","unresolved":false,"context_lines":[{"line_number":7,"context_line":"log_dir \u003d /var/log/kolla/neutron"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"[ovs]"},{"line_number":10,"context_line":"ovsdb_connection \u003d tcp:127.0.0.1:6640"},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"[ovn]"},{"line_number":13,"context_line":"ovn_nb_connection \u003d tcp:{% for host in groups[\u0027ovn-nb-db\u0027] %}{{ \u0027api\u0027 | kolla_address(host) }}:{{ ovn_nb_db_port }}{% if not loop.last %},{% endif %}{% endfor %}"}],"source_content_type":"text/x-jinja2","patch_set":21,"id":"3fa7e38b_343f4023","line":10,"range":{"start_line":10,"start_character":33,"end_line":10,"end_character":37},"updated":"2019-12-05 10:45:59.000000000","message":"ovsdb_port","commit_id":"87b8010e3560c691144718ad71677a8c3e5c2397"},{"author":{"_account_id":19316,"name":"Eduardo Gonzalez","email":"dabarren@gmail.com","username":"egonzalez90"},"change_message_id":"67a913b8e252b00b268dd84dc497ff615133738f","unresolved":false,"context_lines":[{"line_number":10,"context_line":"ovsdb_connection \u003d tcp:127.0.0.1:6640"},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"[ovn]"},{"line_number":13,"context_line":"ovn_nb_connection \u003d tcp:{% for host in groups[\u0027ovn-nb-db\u0027] %}{{ \u0027api\u0027 | kolla_address(host) }}:{{ ovn_nb_db_port }}{% if not loop.last %},{% endif %}{% endfor %}"},{"line_number":14,"context_line":"ovn_sb_connection \u003d tcp:{% for host in groups[\u0027ovn-sb-db\u0027] %}{{ \u0027api\u0027 | kolla_address(host) }}:{{ ovn_sb_db_port }}{% if not loop.last %},{% endif %}{% endfor %}"},{"line_number":15,"context_line":"ovn_metadata_enabled \u003d true"}],"source_content_type":"text/x-jinja2","patch_set":21,"id":"3fa7e38b_141b24cb","line":13,"range":{"start_line":13,"start_character":0,"end_line":13,"end_character":17},"updated":"2019-12-05 10:45:59.000000000","message":"can this two connections be in a shared vars file like defaults or something so all the files uses the same address and avoid typos in many places?\nditto in a previous file","commit_id":"87b8010e3560c691144718ad71677a8c3e5c2397"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"0aa11f254a2860ec73adb2d431a2fc098c602c89","unresolved":false,"context_lines":[{"line_number":1,"context_line":"[DEFAULT]"},{"line_number":2,"context_line":"metadata_proxy_socket \u003d /var/lib/neutron/kolla/metadata_proxy"},{"line_number":3,"context_line":"nova_metadata_host \u003d {{ nova_internal_fqdn }}"},{"line_number":4,"context_line":"nova_metadata_port \u003d {{ nova_metadata_port }}"}],"source_content_type":"text/x-jinja2","patch_set":104,"id":"1fa4df85_903ae395","line":1,"updated":"2020-02-28 17:31:27.000000000","message":"We recently added these:\n\nauth_ca_cert \u003d {{ openstack_cacert | default(omit) }}\nnova_metadata_protocol \u003d {{ internal_protocol }}","commit_id":"dfe55d08a36d7422214492cff103060b299ed104"},{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"5bc3672e9a470ff76cb200a58479f16ad5e1457c","unresolved":false,"context_lines":[{"line_number":1,"context_line":"[DEFAULT]"},{"line_number":2,"context_line":"metadata_proxy_socket \u003d /var/lib/neutron/kolla/metadata_proxy"},{"line_number":3,"context_line":"nova_metadata_host \u003d {{ nova_internal_fqdn }}"},{"line_number":4,"context_line":"nova_metadata_port \u003d {{ nova_metadata_port }}"}],"source_content_type":"text/x-jinja2","patch_set":104,"id":"1fa4df85_7f0b8f23","line":1,"in_reply_to":"1fa4df85_903ae395","updated":"2020-03-16 09:38:19.000000000","message":"Done","commit_id":"dfe55d08a36d7422214492cff103060b299ed104"}],"ansible/roles/neutron/templates/neutron_ovn_metadata_agent.ini.j2":[{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"0c0fab1db5974ebe6fbfde16d97481ba697a41f4","unresolved":false,"context_lines":[{"line_number":1,"context_line":"[DEFAULT]"},{"line_number":2,"context_line":"auth_ca_cert \u003d {{ openstack_cacert | default(omit) }}"},{"line_number":3,"context_line":"nova_metadata_protocol \u003d {{ internal_protocol }}"},{"line_number":4,"context_line":"metadata_proxy_socket \u003d /var/lib/neutron/kolla/metadata_proxy"},{"line_number":5,"context_line":"nova_metadata_host \u003d {{ nova_internal_fqdn }}"}],"source_content_type":"text/x-jinja2","patch_set":120,"id":"df33271e_d56a9c19","line":2,"range":{"start_line":2,"start_character":35,"end_line":2,"end_character":50},"updated":"2020-04-03 15:50:38.000000000","message":"nit: it\u0027s not required, I\u0027ve proposed a patch to remove it everywhere else.","commit_id":"b89944275ed552dc50909cb998987a461325d383"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"0c0fab1db5974ebe6fbfde16d97481ba697a41f4","unresolved":false,"context_lines":[{"line_number":5,"context_line":"nova_metadata_host \u003d {{ nova_internal_fqdn }}"},{"line_number":6,"context_line":"nova_metadata_port \u003d {{ nova_metadata_port }}"},{"line_number":7,"context_line":"metadata_proxy_shared_secret \u003d {{ metadata_secret }}"},{"line_number":8,"context_line":"log_file \u003d networking-ovn-metadata-agent.log"},{"line_number":9,"context_line":"log_dir \u003d /var/log/kolla/neutron"},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"[ovs]"}],"source_content_type":"text/x-jinja2","patch_set":120,"id":"df33271e_d0f62ad9","line":8,"range":{"start_line":8,"start_character":11,"end_line":8,"end_character":21},"updated":"2020-04-03 15:50:38.000000000","message":"neutron","commit_id":"b89944275ed552dc50909cb998987a461325d383"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"9e83381fcbbb72bc68a6937edc2fca0ff14a26ea","unresolved":false,"context_lines":[{"line_number":1,"context_line":"[DEFAULT]"},{"line_number":2,"context_line":"auth_ca_cert \u003d {{ openstack_cacert | default(omit) }}"},{"line_number":3,"context_line":"nova_metadata_protocol \u003d {{ internal_protocol }}"},{"line_number":4,"context_line":"metadata_proxy_socket \u003d /var/lib/neutron/kolla/metadata_proxy"},{"line_number":5,"context_line":"nova_metadata_host \u003d {{ nova_internal_fqdn }}"}],"source_content_type":"text/x-jinja2","patch_set":122,"id":"df33271e_8a6ecb93","line":2,"range":{"start_line":2,"start_character":36,"end_line":2,"end_character":50},"updated":"2020-04-08 09:49:32.000000000","message":"Please remove","commit_id":"4f55ccc5a8499be973618fb380487f95eee3478a"}],"ansible/roles/openvswitch/tasks/ensure-ovs-bridge.yml":[{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"fe200e577209100b76e38ab7c7ed5a128663a034","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"- name: Set system-id"},{"line_number":3,"context_line":"  become: true"},{"line_number":4,"context_line":"  command: docker exec openvswitch_vswitchd ovs-vsctl set Open_vSwitch . external_ids:system-id\u003d{{ inventory_hostname_short }}"},{"line_number":5,"context_line":""},{"line_number":6,"context_line":"- name: Ensuring OVS bridge is properly setup"},{"line_number":7,"context_line":"  become: true"}],"source_content_type":"text/x-yaml","patch_set":71,"id":"3fa7e38b_9b9271fb","line":4,"updated":"2020-01-10 10:30:22.000000000","message":"could use a comment!","commit_id":"6543a07da1dce58601d70bb65fadb053c99e4f5a"},{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"ca4cd4772f87b7325ac013e2c76d0fd3dbbdf3b0","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"- name: Set system-id"},{"line_number":3,"context_line":"  become: true"},{"line_number":4,"context_line":"  command: docker exec openvswitch_vswitchd ovs-vsctl set Open_vSwitch . external_ids:system-id\u003d{{ inventory_hostname_short }}"},{"line_number":5,"context_line":""},{"line_number":6,"context_line":"- name: Ensuring OVS bridge is properly setup"},{"line_number":7,"context_line":"  become: true"}],"source_content_type":"text/x-yaml","patch_set":71,"id":"3fa7e38b_46d66028","line":4,"in_reply_to":"3fa7e38b_9b9271fb","updated":"2020-01-10 11:37:29.000000000","message":"Done","commit_id":"6543a07da1dce58601d70bb65fadb053c99e4f5a"},{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"1da608c04abce32d89c6acb4e673d1a36b16d794","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"# NOTE(mnasiadka): external_ids:system-id uniquely identifies a physical system, used by OVN and other orchestrators"},{"line_number":3,"context_line":"- name: Set system-id"},{"line_number":4,"context_line":"  become: true"},{"line_number":5,"context_line":"  command: docker exec openvswitch_vswitchd ovs-vsctl set Open_vSwitch . external_ids:system-id\u003d{{ inventory_hostname_short }}"}],"source_content_type":"text/x-yaml","patch_set":72,"id":"3fa7e38b_06af082b","line":2,"range":{"start_line":2,"start_character":92,"end_line":2,"end_character":116},"updated":"2020-01-10 11:44:55.000000000","message":"wonder what they are!","commit_id":"c8793f6ec2b4dbee6f0f0f2d4d444aabf5e6b3d4"},{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"549eebfd95a851128da9c8d58faa30220136f992","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"# NOTE(mnasiadka): external_ids:system-id uniquely identifies a physical system, used by OVN and other orchestrators"},{"line_number":3,"context_line":"- name: Set system-id"},{"line_number":4,"context_line":"  become: true"},{"line_number":5,"context_line":"  command: docker exec openvswitch_vswitchd ovs-vsctl set Open_vSwitch . external_ids:system-id\u003d{{ inventory_hostname_short }}"}],"source_content_type":"text/x-yaml","patch_set":72,"id":"3fa7e38b_6156e6cf","line":2,"range":{"start_line":2,"start_character":92,"end_line":2,"end_character":116},"in_reply_to":"3fa7e38b_06af082b","updated":"2020-01-10 12:17:06.000000000","message":"for example Faucet ;-) but I\u0027ll reword it to controllers :)","commit_id":"c8793f6ec2b4dbee6f0f0f2d4d444aabf5e6b3d4"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"afbf6c432c56351f1d06b67e66db1dc1129020f4","unresolved":false,"context_lines":[{"line_number":2,"context_line":"# NOTE(mnasiadka): external_ids:system-id uniquely identifies a physical system, used by OVN and other controllers"},{"line_number":3,"context_line":"- name: Set system-id"},{"line_number":4,"context_line":"  become: true"},{"line_number":5,"context_line":"  command: docker exec openvswitch_vswitchd ovs-vsctl set Open_vSwitch . external_ids:system-id\u003d{{ inventory_hostname_short }}"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"- name: Ensuring OVS bridge is properly setup"},{"line_number":8,"context_line":"  become: true"}],"source_content_type":"text/x-yaml","patch_set":92,"id":"3fa7e38b_2945f74a","line":5,"range":{"start_line":5,"start_character":99,"end_line":5,"end_character":123},"updated":"2020-02-19 18:08:18.000000000","message":"Should we make this configurable?\n\nAlso this isn\u0027t really related to ensuring OVS bridges exist.","commit_id":"cc297570e75246673c6576c43b12e44f98f646f9"},{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"2ea7573b912e7b224a752b043e6120230a141073","unresolved":false,"context_lines":[{"line_number":2,"context_line":"# NOTE(mnasiadka): external_ids:system-id uniquely identifies a physical system, used by OVN and other controllers"},{"line_number":3,"context_line":"- name: Set system-id"},{"line_number":4,"context_line":"  become: true"},{"line_number":5,"context_line":"  command: docker exec openvswitch_vswitchd ovs-vsctl set Open_vSwitch . external_ids:system-id\u003d{{ inventory_hostname_short }}"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"- name: Ensuring OVS bridge is properly setup"},{"line_number":8,"context_line":"  become: true"}],"source_content_type":"text/x-yaml","patch_set":92,"id":"1fa4df85_4d339fac","line":5,"range":{"start_line":5,"start_character":99,"end_line":5,"end_character":123},"in_reply_to":"1fa4df85_b1065320","updated":"2020-02-27 06:36:02.000000000","message":"Done","commit_id":"cc297570e75246673c6576c43b12e44f98f646f9"},{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"cab58a4dd51758dad06a8eb0627874b67e6853cf","unresolved":false,"context_lines":[{"line_number":2,"context_line":"# NOTE(mnasiadka): external_ids:system-id uniquely identifies a physical system, used by OVN and other controllers"},{"line_number":3,"context_line":"- name: Set system-id"},{"line_number":4,"context_line":"  become: true"},{"line_number":5,"context_line":"  command: docker exec openvswitch_vswitchd ovs-vsctl set Open_vSwitch . external_ids:system-id\u003d{{ inventory_hostname_short }}"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"- name: Ensuring OVS bridge is properly setup"},{"line_number":8,"context_line":"  become: true"}],"source_content_type":"text/x-yaml","patch_set":92,"id":"3fa7e38b_b66e0dc9","line":5,"range":{"start_line":5,"start_character":99,"end_line":5,"end_character":123},"in_reply_to":"3fa7e38b_2945f74a","updated":"2020-02-20 17:40:38.000000000","message":"Will make configurable - it isn\u0027t related, but that\u0027s the only playbook that gets imported after running handlers (and we need running openvswitch to set system-id).","commit_id":"cc297570e75246673c6576c43b12e44f98f646f9"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"f5552e44a7660dcfca2dcbe2a8f45dea6d21a4f3","unresolved":false,"context_lines":[{"line_number":2,"context_line":"# NOTE(mnasiadka): external_ids:system-id uniquely identifies a physical system, used by OVN and other controllers"},{"line_number":3,"context_line":"- name: Set system-id"},{"line_number":4,"context_line":"  become: true"},{"line_number":5,"context_line":"  command: docker exec openvswitch_vswitchd ovs-vsctl set Open_vSwitch . external_ids:system-id\u003d{{ inventory_hostname_short }}"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"- name: Ensuring OVS bridge is properly setup"},{"line_number":8,"context_line":"  become: true"}],"source_content_type":"text/x-yaml","patch_set":92,"id":"1fa4df85_b1065320","line":5,"range":{"start_line":5,"start_character":99,"end_line":5,"end_character":123},"in_reply_to":"3fa7e38b_b66e0dc9","updated":"2020-02-24 17:04:24.000000000","message":"Could rename it to post-config.yml or similar?","commit_id":"cc297570e75246673c6576c43b12e44f98f646f9"}],"ansible/roles/ovn/defaults/main.yml":[{"author":{"_account_id":19316,"name":"Eduardo Gonzalez","email":"dabarren@gmail.com","username":"egonzalez90"},"change_message_id":"67a913b8e252b00b268dd84dc497ff615133738f","unresolved":false,"context_lines":[{"line_number":70,"context_line":"ovn_controller_default_volumes:"},{"line_number":71,"context_line":"  - \"{{ node_config_directory }}/ovn-controller/:{{ container_config_directory }}/:ro\""},{"line_number":72,"context_line":"  - \"/etc/localtime:/etc/localtime:ro\""},{"line_number":73,"context_line":"  - \"/run:/run:shared\""},{"line_number":74,"context_line":"  - \"openvswitch_db:/var/lib/openvswitch/\""},{"line_number":75,"context_line":"  - \"kolla_logs:/var/log/kolla/\""},{"line_number":76,"context_line":"ovn_northd_default_volumes:"}],"source_content_type":"text/x-yaml","patch_set":21,"id":"3fa7e38b_546afc1a","line":73,"range":{"start_line":73,"start_character":0,"end_line":73,"end_character":22},"updated":"2019-12-05 10:45:59.000000000","message":"no service need privileged or pid host to manage namespaces or whatever ovn does in the host?","commit_id":"87b8010e3560c691144718ad71677a8c3e5c2397"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"afbf6c432c56351f1d06b67e66db1dc1129020f4","unresolved":false,"context_lines":[{"line_number":6,"context_line":"    container_name: ovn_controller"},{"line_number":7,"context_line":"    group: ovn-controller"},{"line_number":8,"context_line":"    enabled: true"},{"line_number":9,"context_line":"    environment:"},{"line_number":10,"context_line":"      KOLLA_CONFIG_STRATEGY: \"{{ config_strategy }}\""},{"line_number":11,"context_line":"    image: \"{{ ovn_controller_image_full }}\""},{"line_number":12,"context_line":"    volumes: \"{{ ovn_controller_default_volumes + ovn_controller_extra_volumes }}\""},{"line_number":13,"context_line":"    dimensions: \"{{ ovn_controller_dimensions }}\""}],"source_content_type":"text/x-yaml","patch_set":92,"id":"3fa7e38b_e9ea7f0b","line":10,"range":{"start_line":9,"start_character":0,"end_line":10,"end_character":52},"updated":"2020-02-19 18:08:18.000000000","message":"We can just use the default from docker_common_options.","commit_id":"cc297570e75246673c6576c43b12e44f98f646f9"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"afbf6c432c56351f1d06b67e66db1dc1129020f4","unresolved":false,"context_lines":[{"line_number":44,"context_line":"# Docker"},{"line_number":45,"context_line":"####################"},{"line_number":46,"context_line":"ovn_install_type: \"{{ kolla_install_type }}\""},{"line_number":47,"context_line":"ovn_tag: \"{{ openstack_release }}\""},{"line_number":48,"context_line":""},{"line_number":49,"context_line":"ovn_controller_image: \"{{ docker_registry ~ \u0027/\u0027 if docker_registry else \u0027\u0027 }}{{ docker_namespace }}/{{ kolla_base_distro }}-{{ ovn_install_type }}-ovn-controller\""},{"line_number":50,"context_line":"ovn_controller_tag: \"{{ ovn_tag }}\""}],"source_content_type":"text/x-yaml","patch_set":92,"id":"3fa7e38b_29cad7a2","line":47,"range":{"start_line":47,"start_character":13,"end_line":47,"end_character":30},"updated":"2020-02-19 18:08:18.000000000","message":"openstack_tag","commit_id":"cc297570e75246673c6576c43b12e44f98f646f9"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"afbf6c432c56351f1d06b67e66db1dc1129020f4","unresolved":false,"context_lines":[{"line_number":70,"context_line":"ovn_controller_default_volumes:"},{"line_number":71,"context_line":"  - \"{{ node_config_directory }}/ovn-controller/:{{ container_config_directory }}/:ro\""},{"line_number":72,"context_line":"  - \"/etc/localtime:/etc/localtime:ro\""},{"line_number":73,"context_line":"  - \"/run:/run:shared\""},{"line_number":74,"context_line":"  - \"kolla_logs:/var/log/kolla/\""},{"line_number":75,"context_line":"ovn_northd_default_volumes:"},{"line_number":76,"context_line":"  - \"{{ node_config_directory }}/ovn-northd/:{{ container_config_directory }}/:ro\""}],"source_content_type":"text/x-yaml","patch_set":92,"id":"3fa7e38b_a942470d","line":73,"range":{"start_line":73,"start_character":0,"end_line":73,"end_character":22},"updated":"2020-02-19 18:08:18.000000000","message":"Can we restrict this based on your testing?","commit_id":"cc297570e75246673c6576c43b12e44f98f646f9"},{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"b9736df7fcc591250394e349b31134f434004176","unresolved":false,"context_lines":[{"line_number":70,"context_line":"ovn_controller_default_volumes:"},{"line_number":71,"context_line":"  - \"{{ node_config_directory }}/ovn-controller/:{{ container_config_directory }}/:ro\""},{"line_number":72,"context_line":"  - \"/etc/localtime:/etc/localtime:ro\""},{"line_number":73,"context_line":"  - \"/run:/run:shared\""},{"line_number":74,"context_line":"  - \"kolla_logs:/var/log/kolla/\""},{"line_number":75,"context_line":"ovn_northd_default_volumes:"},{"line_number":76,"context_line":"  - \"{{ node_config_directory }}/ovn-northd/:{{ container_config_directory }}/:ro\""}],"source_content_type":"text/x-yaml","patch_set":92,"id":"3fa7e38b_f4ded20d","line":73,"range":{"start_line":73,"start_character":0,"end_line":73,"end_character":22},"in_reply_to":"3fa7e38b_a942470d","updated":"2020-02-19 18:48:08.000000000","message":"probably droppable","commit_id":"cc297570e75246673c6576c43b12e44f98f646f9"},{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"cab58a4dd51758dad06a8eb0627874b67e6853cf","unresolved":false,"context_lines":[{"line_number":70,"context_line":"ovn_controller_default_volumes:"},{"line_number":71,"context_line":"  - \"{{ node_config_directory }}/ovn-controller/:{{ container_config_directory }}/:ro\""},{"line_number":72,"context_line":"  - \"/etc/localtime:/etc/localtime:ro\""},{"line_number":73,"context_line":"  - \"/run:/run:shared\""},{"line_number":74,"context_line":"  - \"kolla_logs:/var/log/kolla/\""},{"line_number":75,"context_line":"ovn_northd_default_volumes:"},{"line_number":76,"context_line":"  - \"{{ node_config_directory }}/ovn-northd/:{{ container_config_directory }}/:ro\""}],"source_content_type":"text/x-yaml","patch_set":92,"id":"3fa7e38b_76765595","line":73,"range":{"start_line":73,"start_character":0,"end_line":73,"end_character":22},"in_reply_to":"3fa7e38b_f4ded20d","updated":"2020-02-20 17:40:38.000000000","message":"Can\u0027t drop it, ovn-controller connects to ovn-northd and configures OVS - so yeah, we need to limit it to /run/openvswitch. Done.","commit_id":"cc297570e75246673c6576c43b12e44f98f646f9"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"afbf6c432c56351f1d06b67e66db1dc1129020f4","unresolved":false,"context_lines":[{"line_number":75,"context_line":"ovn_northd_default_volumes:"},{"line_number":76,"context_line":"  - \"{{ node_config_directory }}/ovn-northd/:{{ container_config_directory }}/:ro\""},{"line_number":77,"context_line":"  - \"/etc/localtime:/etc/localtime:ro\""},{"line_number":78,"context_line":"  - \"/run:/run:shared\""},{"line_number":79,"context_line":"  - \"kolla_logs:/var/log/kolla/\""},{"line_number":80,"context_line":"ovn_nb_db_default_volumes:"},{"line_number":81,"context_line":"  - \"{{ node_config_directory }}/ovn-nb-db/:{{ container_config_directory }}/:ro\""}],"source_content_type":"text/x-yaml","patch_set":92,"id":"3fa7e38b_a96b2785","line":78,"range":{"start_line":78,"start_character":0,"end_line":78,"end_character":22},"updated":"2020-02-19 18:08:18.000000000","message":"I\u0027d guess we don\u0027t need this for the control services?","commit_id":"cc297570e75246673c6576c43b12e44f98f646f9"},{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"2ea7573b912e7b224a752b043e6120230a141073","unresolved":false,"context_lines":[{"line_number":75,"context_line":"ovn_northd_default_volumes:"},{"line_number":76,"context_line":"  - \"{{ node_config_directory }}/ovn-northd/:{{ container_config_directory }}/:ro\""},{"line_number":77,"context_line":"  - \"/etc/localtime:/etc/localtime:ro\""},{"line_number":78,"context_line":"  - \"/run:/run:shared\""},{"line_number":79,"context_line":"  - \"kolla_logs:/var/log/kolla/\""},{"line_number":80,"context_line":"ovn_nb_db_default_volumes:"},{"line_number":81,"context_line":"  - \"{{ node_config_directory }}/ovn-nb-db/:{{ container_config_directory }}/:ro\""}],"source_content_type":"text/x-yaml","patch_set":92,"id":"1fa4df85_8d18b71d","line":78,"range":{"start_line":78,"start_character":0,"end_line":78,"end_character":22},"in_reply_to":"1fa4df85_35f56ecc","updated":"2020-02-27 06:36:02.000000000","message":"You mean not collocating ovn-northd with sb/nb dbs? Interesting case, I can try enforcing ovn Northd to use tcp instead of socket - let\u0027s see.","commit_id":"cc297570e75246673c6576c43b12e44f98f646f9"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"0aa11f254a2860ec73adb2d431a2fc098c602c89","unresolved":false,"context_lines":[{"line_number":75,"context_line":"ovn_northd_default_volumes:"},{"line_number":76,"context_line":"  - \"{{ node_config_directory }}/ovn-northd/:{{ container_config_directory }}/:ro\""},{"line_number":77,"context_line":"  - \"/etc/localtime:/etc/localtime:ro\""},{"line_number":78,"context_line":"  - \"/run:/run:shared\""},{"line_number":79,"context_line":"  - \"kolla_logs:/var/log/kolla/\""},{"line_number":80,"context_line":"ovn_nb_db_default_volumes:"},{"line_number":81,"context_line":"  - \"{{ node_config_directory }}/ovn-nb-db/:{{ container_config_directory }}/:ro\""}],"source_content_type":"text/x-yaml","patch_set":92,"id":"1fa4df85_c831a60d","line":78,"range":{"start_line":78,"start_character":0,"end_line":78,"end_character":22},"in_reply_to":"1fa4df85_8d18b71d","updated":"2020-02-28 17:31:27.000000000","message":"I mean in a multi-host setup where there are multiple of each service running. Does northd only communicate with the NB \u0026 SB DBs on the same host?","commit_id":"cc297570e75246673c6576c43b12e44f98f646f9"},{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"5bc3672e9a470ff76cb200a58479f16ad5e1457c","unresolved":false,"context_lines":[{"line_number":75,"context_line":"ovn_northd_default_volumes:"},{"line_number":76,"context_line":"  - \"{{ node_config_directory }}/ovn-northd/:{{ container_config_directory }}/:ro\""},{"line_number":77,"context_line":"  - \"/etc/localtime:/etc/localtime:ro\""},{"line_number":78,"context_line":"  - \"/run:/run:shared\""},{"line_number":79,"context_line":"  - \"kolla_logs:/var/log/kolla/\""},{"line_number":80,"context_line":"ovn_nb_db_default_volumes:"},{"line_number":81,"context_line":"  - \"{{ node_config_directory }}/ovn-nb-db/:{{ container_config_directory }}/:ro\""}],"source_content_type":"text/x-yaml","patch_set":92,"id":"1fa4df85_1f3b7bd1","line":78,"range":{"start_line":78,"start_character":0,"end_line":78,"end_character":22},"in_reply_to":"1fa4df85_c831a60d","updated":"2020-03-16 09:38:19.000000000","message":"No, it works with remote NB \u0026 SB DBs - removed /run bind mount.","commit_id":"cc297570e75246673c6576c43b12e44f98f646f9"},{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"cab58a4dd51758dad06a8eb0627874b67e6853cf","unresolved":false,"context_lines":[{"line_number":75,"context_line":"ovn_northd_default_volumes:"},{"line_number":76,"context_line":"  - \"{{ node_config_directory }}/ovn-northd/:{{ container_config_directory }}/:ro\""},{"line_number":77,"context_line":"  - \"/etc/localtime:/etc/localtime:ro\""},{"line_number":78,"context_line":"  - \"/run:/run:shared\""},{"line_number":79,"context_line":"  - \"kolla_logs:/var/log/kolla/\""},{"line_number":80,"context_line":"ovn_nb_db_default_volumes:"},{"line_number":81,"context_line":"  - \"{{ node_config_directory }}/ovn-nb-db/:{{ container_config_directory }}/:ro\""}],"source_content_type":"text/x-yaml","patch_set":92,"id":"3fa7e38b_f689e56f","line":78,"range":{"start_line":78,"start_character":0,"end_line":78,"end_character":22},"in_reply_to":"3fa7e38b_14e4cede","updated":"2020-02-20 17:40:38.000000000","message":"OVN Northd needs access to southbound and northbound db sockets - so limiting to /run/ovn","commit_id":"cc297570e75246673c6576c43b12e44f98f646f9"},{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"b9736df7fcc591250394e349b31134f434004176","unresolved":false,"context_lines":[{"line_number":75,"context_line":"ovn_northd_default_volumes:"},{"line_number":76,"context_line":"  - \"{{ node_config_directory }}/ovn-northd/:{{ container_config_directory }}/:ro\""},{"line_number":77,"context_line":"  - \"/etc/localtime:/etc/localtime:ro\""},{"line_number":78,"context_line":"  - \"/run:/run:shared\""},{"line_number":79,"context_line":"  - \"kolla_logs:/var/log/kolla/\""},{"line_number":80,"context_line":"ovn_nb_db_default_volumes:"},{"line_number":81,"context_line":"  - \"{{ node_config_directory }}/ovn-nb-db/:{{ container_config_directory }}/:ro\""}],"source_content_type":"text/x-yaml","patch_set":92,"id":"3fa7e38b_14e4cede","line":78,"range":{"start_line":78,"start_character":0,"end_line":78,"end_character":22},"in_reply_to":"3fa7e38b_a96b2785","updated":"2020-02-19 18:48:08.000000000","message":"probably droppable","commit_id":"cc297570e75246673c6576c43b12e44f98f646f9"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"f5552e44a7660dcfca2dcbe2a8f45dea6d21a4f3","unresolved":false,"context_lines":[{"line_number":75,"context_line":"ovn_northd_default_volumes:"},{"line_number":76,"context_line":"  - \"{{ node_config_directory }}/ovn-northd/:{{ container_config_directory }}/:ro\""},{"line_number":77,"context_line":"  - \"/etc/localtime:/etc/localtime:ro\""},{"line_number":78,"context_line":"  - \"/run:/run:shared\""},{"line_number":79,"context_line":"  - \"kolla_logs:/var/log/kolla/\""},{"line_number":80,"context_line":"ovn_nb_db_default_volumes:"},{"line_number":81,"context_line":"  - \"{{ node_config_directory }}/ovn-nb-db/:{{ container_config_directory }}/:ro\""}],"source_content_type":"text/x-yaml","patch_set":92,"id":"1fa4df85_35f56ecc","line":78,"range":{"start_line":78,"start_character":0,"end_line":78,"end_character":22},"in_reply_to":"3fa7e38b_f689e56f","updated":"2020-02-24 17:04:24.000000000","message":"How does that work with multiple hosts?","commit_id":"cc297570e75246673c6576c43b12e44f98f646f9"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"f5552e44a7660dcfca2dcbe2a8f45dea6d21a4f3","unresolved":false,"context_lines":[{"line_number":62,"context_line":"ovn_controller_default_volumes:"},{"line_number":63,"context_line":"  - \"{{ node_config_directory }}/ovn-controller/:{{ container_config_directory }}/:ro\""},{"line_number":64,"context_line":"  - \"/etc/localtime:/etc/localtime:ro\""},{"line_number":65,"context_line":"  - \"/run/openvswitch:/run/openvswitch:shared\""},{"line_number":66,"context_line":"  - \"/run/ovn:/run/ovn:shared\""},{"line_number":67,"context_line":"  - \"kolla_logs:/var/log/kolla/\""},{"line_number":68,"context_line":"ovn_northd_default_volumes:"}],"source_content_type":"text/x-yaml","patch_set":96,"id":"1fa4df85_952d4248","line":65,"range":{"start_line":65,"start_character":4,"end_line":65,"end_character":46},"updated":"2020-02-24 17:04:24.000000000","message":"Surely only ovn-controller needs access to OVS?","commit_id":"d260246d723324577e2e1908cc6db8a29dc715af"},{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"2ea7573b912e7b224a752b043e6120230a141073","unresolved":false,"context_lines":[{"line_number":62,"context_line":"ovn_controller_default_volumes:"},{"line_number":63,"context_line":"  - \"{{ node_config_directory }}/ovn-controller/:{{ container_config_directory }}/:ro\""},{"line_number":64,"context_line":"  - \"/etc/localtime:/etc/localtime:ro\""},{"line_number":65,"context_line":"  - \"/run/openvswitch:/run/openvswitch:shared\""},{"line_number":66,"context_line":"  - \"/run/ovn:/run/ovn:shared\""},{"line_number":67,"context_line":"  - \"kolla_logs:/var/log/kolla/\""},{"line_number":68,"context_line":"ovn_northd_default_volumes:"}],"source_content_type":"text/x-yaml","patch_set":96,"id":"1fa4df85_8ded17f1","line":65,"range":{"start_line":65,"start_character":4,"end_line":65,"end_character":46},"in_reply_to":"1fa4df85_952d4248","updated":"2020-02-27 06:36:02.000000000","message":"I\u0027ll check again if any of those containers needs /run/openvswitch and /run/ovn - because the run flags for them say otherwise...","commit_id":"d260246d723324577e2e1908cc6db8a29dc715af"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"f5552e44a7660dcfca2dcbe2a8f45dea6d21a4f3","unresolved":false,"context_lines":[{"line_number":63,"context_line":"  - \"{{ node_config_directory }}/ovn-controller/:{{ container_config_directory }}/:ro\""},{"line_number":64,"context_line":"  - \"/etc/localtime:/etc/localtime:ro\""},{"line_number":65,"context_line":"  - \"/run/openvswitch:/run/openvswitch:shared\""},{"line_number":66,"context_line":"  - \"/run/ovn:/run/ovn:shared\""},{"line_number":67,"context_line":"  - \"kolla_logs:/var/log/kolla/\""},{"line_number":68,"context_line":"ovn_northd_default_volumes:"},{"line_number":69,"context_line":"  - \"{{ node_config_directory }}/ovn-northd/:{{ container_config_directory }}/:ro\""}],"source_content_type":"text/x-yaml","patch_set":96,"id":"1fa4df85_15cf1280","line":66,"updated":"2020-02-24 17:04:24.000000000","message":"Tripleo has this:\n\n/var/lib/openvswitch/ovn:/run/ovn:shared,z\n\nAny way to just use a TCP connection similarly to neutron?","commit_id":"d260246d723324577e2e1908cc6db8a29dc715af"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"0aa11f254a2860ec73adb2d431a2fc098c602c89","unresolved":false,"context_lines":[{"line_number":61,"context_line":""},{"line_number":62,"context_line":"ovn_controller_default_volumes:"},{"line_number":63,"context_line":"  - \"{{ node_config_directory }}/ovn-controller/:{{ container_config_directory }}/:ro\""},{"line_number":64,"context_line":"  - \"/run/openvswitch:/run/openvswitch:shared\""},{"line_number":65,"context_line":"  - \"/etc/localtime:/etc/localtime:ro\""},{"line_number":66,"context_line":"  - \"kolla_logs:/var/log/kolla/\""},{"line_number":67,"context_line":"ovn_northd_default_volumes:"}],"source_content_type":"text/x-yaml","patch_set":103,"id":"1fa4df85_6393f5a4","line":64,"range":{"start_line":64,"start_character":4,"end_line":64,"end_character":46},"updated":"2020-02-28 17:31:27.000000000","message":"Would be worth running docker diff on a running system to see what has changed and if any of it should be persistent. Tripleo has /run/ovn bind mounted for all.","commit_id":"50ea60e99d7c25435d45cb8908173f2ddbb39fb9"},{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"5bc3672e9a470ff76cb200a58479f16ad5e1457c","unresolved":false,"context_lines":[{"line_number":61,"context_line":""},{"line_number":62,"context_line":"ovn_controller_default_volumes:"},{"line_number":63,"context_line":"  - \"{{ node_config_directory }}/ovn-controller/:{{ container_config_directory }}/:ro\""},{"line_number":64,"context_line":"  - \"/run/openvswitch:/run/openvswitch:shared\""},{"line_number":65,"context_line":"  - \"/etc/localtime:/etc/localtime:ro\""},{"line_number":66,"context_line":"  - \"kolla_logs:/var/log/kolla/\""},{"line_number":67,"context_line":"ovn_northd_default_volumes:"}],"source_content_type":"text/x-yaml","patch_set":103,"id":"1fa4df85_5f56d308","line":64,"range":{"start_line":64,"start_character":4,"end_line":64,"end_character":46},"in_reply_to":"1fa4df85_6393f5a4","updated":"2020-03-16 09:38:19.000000000","message":"oven-controller only saves pid and socket in /run/ovn in our case - and nothing needs to connect to it - so I don\u0027t think we need a bind mount or volume for runtime data.","commit_id":"50ea60e99d7c25435d45cb8908173f2ddbb39fb9"}],"ansible/roles/ovn/handlers/main.yml":[{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"afbf6c432c56351f1d06b67e66db1dc1129020f4","unresolved":false,"context_lines":[{"line_number":35,"context_line":"    port: \"{{ ovn_nb_db_port }}\""},{"line_number":36,"context_line":"    connect_timeout: 1"},{"line_number":37,"context_line":"    timeout: 60"},{"line_number":38,"context_line":"  run_once: True"},{"line_number":39,"context_line":"  register: check_ovn_nb_db_port"},{"line_number":40,"context_line":"  until: check_ovn_nb_db_port is success"},{"line_number":41,"context_line":"  retries: 10"}],"source_content_type":"text/x-yaml","patch_set":92,"id":"3fa7e38b_69fa0fbc","line":38,"range":{"start_line":38,"start_character":2,"end_line":38,"end_character":16},"updated":"2020-02-19 18:08:18.000000000","message":"Shouldn\u0027t we do this on every host?","commit_id":"cc297570e75246673c6576c43b12e44f98f646f9"},{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"cab58a4dd51758dad06a8eb0627874b67e6853cf","unresolved":false,"context_lines":[{"line_number":35,"context_line":"    port: \"{{ ovn_nb_db_port }}\""},{"line_number":36,"context_line":"    connect_timeout: 1"},{"line_number":37,"context_line":"    timeout: 60"},{"line_number":38,"context_line":"  run_once: True"},{"line_number":39,"context_line":"  register: check_ovn_nb_db_port"},{"line_number":40,"context_line":"  until: check_ovn_nb_db_port is success"},{"line_number":41,"context_line":"  retries: 10"}],"source_content_type":"text/x-yaml","patch_set":92,"id":"3fa7e38b_b6ca8da0","line":38,"range":{"start_line":38,"start_character":2,"end_line":38,"end_character":16},"in_reply_to":"3fa7e38b_69fa0fbc","updated":"2020-02-20 17:40:38.000000000","message":"Done","commit_id":"cc297570e75246673c6576c43b12e44f98f646f9"},{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"b9736df7fcc591250394e349b31134f434004176","unresolved":false,"context_lines":[{"line_number":48,"context_line":"    port: \"{{ ovn_sb_db_port }}\""},{"line_number":49,"context_line":"    connect_timeout: 1"},{"line_number":50,"context_line":"    timeout: 60"},{"line_number":51,"context_line":"  run_once: True"},{"line_number":52,"context_line":"  register: check_ovn_sb_db_port"},{"line_number":53,"context_line":"  until: check_ovn_sb_db_port is success"},{"line_number":54,"context_line":"  retries: 10"}],"source_content_type":"text/x-yaml","patch_set":92,"id":"3fa7e38b_74d2e200","line":51,"updated":"2020-02-19 18:48:08.000000000","message":"and this?","commit_id":"cc297570e75246673c6576c43b12e44f98f646f9"},{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"cab58a4dd51758dad06a8eb0627874b67e6853cf","unresolved":false,"context_lines":[{"line_number":48,"context_line":"    port: \"{{ ovn_sb_db_port }}\""},{"line_number":49,"context_line":"    connect_timeout: 1"},{"line_number":50,"context_line":"    timeout: 60"},{"line_number":51,"context_line":"  run_once: True"},{"line_number":52,"context_line":"  register: check_ovn_sb_db_port"},{"line_number":53,"context_line":"  until: check_ovn_sb_db_port is success"},{"line_number":54,"context_line":"  retries: 10"}],"source_content_type":"text/x-yaml","patch_set":92,"id":"3fa7e38b_16da8175","line":51,"in_reply_to":"3fa7e38b_74d2e200","updated":"2020-02-20 17:40:38.000000000","message":"Done","commit_id":"cc297570e75246673c6576c43b12e44f98f646f9"}],"ansible/roles/ovn/tasks/bootstrap.yml":[{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"afbf6c432c56351f1d06b67e66db1dc1129020f4","unresolved":false,"context_lines":[{"line_number":4,"context_line":"  kolla_docker:"},{"line_number":5,"context_line":"    action: \"create_volume\""},{"line_number":6,"context_line":"    common_options: \"{{ docker_common_options }}\""},{"line_number":7,"context_line":"    name: \"ovn_nb_db_server\""},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"- name: Creating OVN Southbound DB volume"},{"line_number":10,"context_line":"  become: true"}],"source_content_type":"text/x-yaml","patch_set":92,"id":"3fa7e38b_09da7b49","line":7,"range":{"start_line":7,"start_character":11,"end_line":7,"end_character":27},"updated":"2020-02-19 18:08:18.000000000","message":"Name in defaults is ovn_nb_db","commit_id":"cc297570e75246673c6576c43b12e44f98f646f9"},{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"b9736df7fcc591250394e349b31134f434004176","unresolved":false,"context_lines":[{"line_number":4,"context_line":"  kolla_docker:"},{"line_number":5,"context_line":"    action: \"create_volume\""},{"line_number":6,"context_line":"    common_options: \"{{ docker_common_options }}\""},{"line_number":7,"context_line":"    name: \"ovn_nb_db_server\""},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"- name: Creating OVN Southbound DB volume"},{"line_number":10,"context_line":"  become: true"}],"source_content_type":"text/x-yaml","patch_set":92,"id":"3fa7e38b_54032676","line":7,"range":{"start_line":7,"start_character":11,"end_line":7,"end_character":27},"in_reply_to":"3fa7e38b_09da7b49","updated":"2020-02-19 18:48:08.000000000","message":"should just use defaults","commit_id":"cc297570e75246673c6576c43b12e44f98f646f9"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"afbf6c432c56351f1d06b67e66db1dc1129020f4","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"- name: Creating OVN Northbound DB volume"},{"line_number":3,"context_line":"  become: true"},{"line_number":4,"context_line":"  kolla_docker:"},{"line_number":5,"context_line":"    action: \"create_volume\""},{"line_number":6,"context_line":"    common_options: \"{{ docker_common_options }}\""},{"line_number":7,"context_line":"    name: \"ovn_nb_db_server\""},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"- name: Creating OVN Southbound DB volume"},{"line_number":10,"context_line":"  become: true"},{"line_number":11,"context_line":"  kolla_docker:"},{"line_number":12,"context_line":"    action: \"create_volume\""},{"line_number":13,"context_line":"    common_options: \"{{ docker_common_options }}\""},{"line_number":14,"context_line":"    name: \"ovn_sb_db_server\""},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"- name: Create br-int bridge on OpenvSwitch"},{"line_number":17,"context_line":"  become: true"}],"source_content_type":"text/x-yaml","patch_set":92,"id":"3fa7e38b_09259b5b","line":14,"range":{"start_line":2,"start_character":0,"end_line":14,"end_character":28},"updated":"2020-02-19 18:08:18.000000000","message":"Any reason why these are created up front rather than automatically as containers are started?","commit_id":"cc297570e75246673c6576c43b12e44f98f646f9"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"afbf6c432c56351f1d06b67e66db1dc1129020f4","unresolved":false,"context_lines":[{"line_number":11,"context_line":"  kolla_docker:"},{"line_number":12,"context_line":"    action: \"create_volume\""},{"line_number":13,"context_line":"    common_options: \"{{ docker_common_options }}\""},{"line_number":14,"context_line":"    name: \"ovn_sb_db_server\""},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"- name: Create br-int bridge on OpenvSwitch"},{"line_number":17,"context_line":"  become: true"}],"source_content_type":"text/x-yaml","patch_set":92,"id":"3fa7e38b_c9db034a","line":14,"range":{"start_line":14,"start_character":11,"end_line":14,"end_character":27},"updated":"2020-02-19 18:08:18.000000000","message":"Name in defaults is ovn_sb_db","commit_id":"cc297570e75246673c6576c43b12e44f98f646f9"},{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"cab58a4dd51758dad06a8eb0627874b67e6853cf","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"- name: Creating OVN Northbound DB volume"},{"line_number":3,"context_line":"  become: true"},{"line_number":4,"context_line":"  kolla_docker:"},{"line_number":5,"context_line":"    action: \"create_volume\""},{"line_number":6,"context_line":"    common_options: \"{{ docker_common_options }}\""},{"line_number":7,"context_line":"    name: \"ovn_nb_db_server\""},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"- name: Creating OVN Southbound DB volume"},{"line_number":10,"context_line":"  become: true"},{"line_number":11,"context_line":"  kolla_docker:"},{"line_number":12,"context_line":"    action: \"create_volume\""},{"line_number":13,"context_line":"    common_options: \"{{ docker_common_options }}\""},{"line_number":14,"context_line":"    name: \"ovn_sb_db_server\""},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"- name: Create br-int bridge on OpenvSwitch"},{"line_number":17,"context_line":"  become: true"}],"source_content_type":"text/x-yaml","patch_set":92,"id":"3fa7e38b_b6584dfc","line":14,"range":{"start_line":2,"start_character":0,"end_line":14,"end_character":28},"in_reply_to":"3fa7e38b_09259b5b","updated":"2020-02-20 17:40:38.000000000","message":"I had no clue these will be created automatically if not existent - that explains now why it works, although volume names in defaults are different. ;-)","commit_id":"cc297570e75246673c6576c43b12e44f98f646f9"},{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"b9736df7fcc591250394e349b31134f434004176","unresolved":false,"context_lines":[{"line_number":11,"context_line":"  kolla_docker:"},{"line_number":12,"context_line":"    action: \"create_volume\""},{"line_number":13,"context_line":"    common_options: \"{{ docker_common_options }}\""},{"line_number":14,"context_line":"    name: \"ovn_sb_db_server\""},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"- name: Create br-int bridge on OpenvSwitch"},{"line_number":17,"context_line":"  become: true"}],"source_content_type":"text/x-yaml","patch_set":92,"id":"3fa7e38b_f4f7b28d","line":14,"range":{"start_line":14,"start_character":11,"end_line":14,"end_character":27},"in_reply_to":"3fa7e38b_c9db034a","updated":"2020-02-19 18:48:08.000000000","message":"ditto","commit_id":"cc297570e75246673c6576c43b12e44f98f646f9"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"afbf6c432c56351f1d06b67e66db1dc1129020f4","unresolved":false,"context_lines":[{"line_number":13,"context_line":"    common_options: \"{{ docker_common_options }}\""},{"line_number":14,"context_line":"    name: \"ovn_sb_db_server\""},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"- name: Create br-int bridge on OpenvSwitch"},{"line_number":17,"context_line":"  become: true"},{"line_number":18,"context_line":"  command: \u003e"},{"line_number":19,"context_line":"    docker exec openvswitch_vswitchd ovs-vsctl --may-exist"}],"source_content_type":"text/x-yaml","patch_set":92,"id":"3fa7e38b_295ad784","line":16,"updated":"2020-02-19 18:08:18.000000000","message":"Should only run these on hosts in ovn-controller group.","commit_id":"cc297570e75246673c6576c43b12e44f98f646f9"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"afbf6c432c56351f1d06b67e66db1dc1129020f4","unresolved":false,"context_lines":[{"line_number":29,"context_line":""},{"line_number":30,"context_line":"- name: Set OVN bridge mappings"},{"line_number":31,"context_line":"  become: true"},{"line_number":32,"context_line":"  command: docker exec openvswitch_vswitchd ovs-vsctl set Open_vSwitch . external_ids:ovn-bridge-mappings\u003dphysnet{{ item.0 + 1 }}:{{ item.1 }}"},{"line_number":33,"context_line":"  when:"},{"line_number":34,"context_line":"    - neutron_plugin_agent \u003d\u003d \u0027ovn\u0027"},{"line_number":35,"context_line":"    - inventory_hostname in groups[\"network\"]"}],"source_content_type":"text/x-yaml","patch_set":92,"id":"3fa7e38b_c94a23ad","line":32,"updated":"2020-02-19 18:08:18.000000000","message":"Does this result in updating a list, or just replacing the value each time? i.e. does it work for multiple physnets?","commit_id":"cc297570e75246673c6576c43b12e44f98f646f9"},{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"2ea7573b912e7b224a752b043e6120230a141073","unresolved":false,"context_lines":[{"line_number":29,"context_line":""},{"line_number":30,"context_line":"- name: Set OVN bridge mappings"},{"line_number":31,"context_line":"  become: true"},{"line_number":32,"context_line":"  command: docker exec openvswitch_vswitchd ovs-vsctl set Open_vSwitch . external_ids:ovn-bridge-mappings\u003dphysnet{{ item.0 + 1 }}:{{ item.1 }}"},{"line_number":33,"context_line":"  when:"},{"line_number":34,"context_line":"    - neutron_plugin_agent \u003d\u003d \u0027ovn\u0027"},{"line_number":35,"context_line":"    - inventory_hostname in groups[\"network\"]"}],"source_content_type":"text/x-yaml","patch_set":92,"id":"1fa4df85_edaa8b83","line":32,"in_reply_to":"1fa4df85_157dd21b","updated":"2020-02-27 06:36:02.000000000","message":"ah right, let me join them.","commit_id":"cc297570e75246673c6576c43b12e44f98f646f9"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"f5552e44a7660dcfca2dcbe2a8f45dea6d21a4f3","unresolved":false,"context_lines":[{"line_number":29,"context_line":""},{"line_number":30,"context_line":"- name: Set OVN bridge mappings"},{"line_number":31,"context_line":"  become: true"},{"line_number":32,"context_line":"  command: docker exec openvswitch_vswitchd ovs-vsctl set Open_vSwitch . external_ids:ovn-bridge-mappings\u003dphysnet{{ item.0 + 1 }}:{{ item.1 }}"},{"line_number":33,"context_line":"  when:"},{"line_number":34,"context_line":"    - neutron_plugin_agent \u003d\u003d \u0027ovn\u0027"},{"line_number":35,"context_line":"    - inventory_hostname in groups[\"network\"]"}],"source_content_type":"text/x-yaml","patch_set":92,"id":"1fa4df85_157dd21b","line":32,"in_reply_to":"3fa7e38b_16484129","updated":"2020-02-24 17:04:24.000000000","message":"Yeah I see the loop, but we\u0027re just replacing the value each time. Docs give this example:\n\nexternal_ids:ovn-bridge-mappings\u003dphysnet1:br-eth0,physnet2:br-eth1","commit_id":"cc297570e75246673c6576c43b12e44f98f646f9"},{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"cab58a4dd51758dad06a8eb0627874b67e6853cf","unresolved":false,"context_lines":[{"line_number":29,"context_line":""},{"line_number":30,"context_line":"- name: Set OVN bridge mappings"},{"line_number":31,"context_line":"  become: true"},{"line_number":32,"context_line":"  command: docker exec openvswitch_vswitchd ovs-vsctl set Open_vSwitch . external_ids:ovn-bridge-mappings\u003dphysnet{{ item.0 + 1 }}:{{ item.1 }}"},{"line_number":33,"context_line":"  when:"},{"line_number":34,"context_line":"    - neutron_plugin_agent \u003d\u003d \u0027ovn\u0027"},{"line_number":35,"context_line":"    - inventory_hostname in groups[\"network\"]"}],"source_content_type":"text/x-yaml","patch_set":92,"id":"3fa7e38b_16484129","line":32,"in_reply_to":"3fa7e38b_c94a23ad","updated":"2020-02-20 17:40:38.000000000","message":"works for multiple physnets, look in the loop:","commit_id":"cc297570e75246673c6576c43b12e44f98f646f9"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"afbf6c432c56351f1d06b67e66db1dc1129020f4","unresolved":false,"context_lines":[{"line_number":32,"context_line":"  command: docker exec openvswitch_vswitchd ovs-vsctl set Open_vSwitch . external_ids:ovn-bridge-mappings\u003dphysnet{{ item.0 + 1 }}:{{ item.1 }}"},{"line_number":33,"context_line":"  when:"},{"line_number":34,"context_line":"    - neutron_plugin_agent \u003d\u003d \u0027ovn\u0027"},{"line_number":35,"context_line":"    - inventory_hostname in groups[\"network\"]"},{"line_number":36,"context_line":"      or (inventory_hostname in groups[\"compute\"] and computes_need_external_bridge | bool)"},{"line_number":37,"context_line":"  loop: \"{{ range(0, neutron_bridge_name.split(\u0027,\u0027) | length) | zip(neutron_bridge_name.split(\u0027,\u0027)) | list }}\""},{"line_number":38,"context_line":""},{"line_number":39,"context_line":"- name: Set OVN remote probe interval"}],"source_content_type":"text/x-yaml","patch_set":92,"id":"3fa7e38b_49c4f30d","line":36,"range":{"start_line":35,"start_character":0,"end_line":36,"end_character":91},"updated":"2020-02-19 18:08:18.000000000","message":"Let\u0027s reference the relevant service.group.","commit_id":"cc297570e75246673c6576c43b12e44f98f646f9"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"0c0fab1db5974ebe6fbfde16d97481ba697a41f4","unresolved":false,"context_lines":[{"line_number":21,"context_line":"  become: true"},{"line_number":22,"context_line":"  command: docker exec openvswitch_vswitchd ovs-vsctl set Open_vSwitch . external_ids:ovn-bridge-mappings\u003d{{ ovn_mappings }}"},{"line_number":23,"context_line":"  when:"},{"line_number":24,"context_line":"    - neutron_plugin_agent \u003d\u003d \u0027ovn\u0027"},{"line_number":25,"context_line":"    - inventory_hostname in groups[\"ovn-controller-network\"]"},{"line_number":26,"context_line":"      or (inventory_hostname in groups[\"ovn-controller-compute\"] and computes_need_external_bridge | bool)"},{"line_number":27,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":120,"id":"df33271e_90b4a2f4","line":24,"range":{"start_line":24,"start_character":4,"end_line":24,"end_character":35},"updated":"2020-04-03 15:50:38.000000000","message":"Would we support OVN without OVN? If not this is redundant.","commit_id":"b89944275ed552dc50909cb998987a461325d383"},{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"e8eda4c2049e77f3040469a4f506218b5b66d86b","unresolved":false,"context_lines":[{"line_number":21,"context_line":"  become: true"},{"line_number":22,"context_line":"  command: docker exec openvswitch_vswitchd ovs-vsctl set Open_vSwitch . external_ids:ovn-bridge-mappings\u003d{{ ovn_mappings }}"},{"line_number":23,"context_line":"  when:"},{"line_number":24,"context_line":"    - neutron_plugin_agent \u003d\u003d \u0027ovn\u0027"},{"line_number":25,"context_line":"    - inventory_hostname in groups[\"ovn-controller-network\"]"},{"line_number":26,"context_line":"      or (inventory_hostname in groups[\"ovn-controller-compute\"] and computes_need_external_bridge | bool)"},{"line_number":27,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":120,"id":"df33271e_a2ef9785","line":24,"range":{"start_line":24,"start_character":4,"end_line":24,"end_character":35},"in_reply_to":"df33271e_90b4a2f4","updated":"2020-04-07 13:06:21.000000000","message":"Done","commit_id":"b89944275ed552dc50909cb998987a461325d383"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"0c0fab1db5974ebe6fbfde16d97481ba697a41f4","unresolved":false,"context_lines":[{"line_number":29,"context_line":"  become: true"},{"line_number":30,"context_line":"  command: docker exec openvswitch_vswitchd ovs-vsctl set Open_vSwitch . external-ids:ovn-cms-options\u003d\"enable-chassis-as-gw\""},{"line_number":31,"context_line":"  when:"},{"line_number":32,"context_line":"    - neutron_plugin_agent \u003d\u003d \u0027ovn\u0027"},{"line_number":33,"context_line":"    - inventory_hostname in groups[\"ovn-controller-network\"]"},{"line_number":34,"context_line":"      or (inventory_hostname in groups[\"ovn-controller-compute\"] and computes_need_external_bridge | bool)"},{"line_number":35,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":120,"id":"df33271e_70b91ee8","line":32,"range":{"start_line":32,"start_character":4,"end_line":32,"end_character":35},"updated":"2020-04-03 15:50:38.000000000","message":"ditto","commit_id":"b89944275ed552dc50909cb998987a461325d383"},{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"e8eda4c2049e77f3040469a4f506218b5b66d86b","unresolved":false,"context_lines":[{"line_number":29,"context_line":"  become: true"},{"line_number":30,"context_line":"  command: docker exec openvswitch_vswitchd ovs-vsctl set Open_vSwitch . external-ids:ovn-cms-options\u003d\"enable-chassis-as-gw\""},{"line_number":31,"context_line":"  when:"},{"line_number":32,"context_line":"    - neutron_plugin_agent \u003d\u003d \u0027ovn\u0027"},{"line_number":33,"context_line":"    - inventory_hostname in groups[\"ovn-controller-network\"]"},{"line_number":34,"context_line":"      or (inventory_hostname in groups[\"ovn-controller-compute\"] and computes_need_external_bridge | bool)"},{"line_number":35,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":120,"id":"df33271e_82f2536e","line":32,"range":{"start_line":32,"start_character":4,"end_line":32,"end_character":35},"in_reply_to":"df33271e_70b91ee8","updated":"2020-04-07 13:06:21.000000000","message":"Done","commit_id":"b89944275ed552dc50909cb998987a461325d383"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"0c0fab1db5974ebe6fbfde16d97481ba697a41f4","unresolved":false,"context_lines":[{"line_number":37,"context_line":"  become: true"},{"line_number":38,"context_line":"  command: \u003e"},{"line_number":39,"context_line":"    docker exec openvswitch_vswitchd ovs-vsctl set Open_vSwitch ."},{"line_number":40,"context_line":"    external_ids:ovn-remote-probe-interval\u003d{{ ovn_remote_probe_interval }}"}],"source_content_type":"text/x-yaml","patch_set":120,"id":"df33271e_f0eb6ed9","line":40,"updated":"2020-04-03 15:50:38.000000000","message":"when: inventory_hostname in groups[\u0027ovn-controller\u0027]","commit_id":"b89944275ed552dc50909cb998987a461325d383"},{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"e8eda4c2049e77f3040469a4f506218b5b66d86b","unresolved":false,"context_lines":[{"line_number":37,"context_line":"  become: true"},{"line_number":38,"context_line":"  command: \u003e"},{"line_number":39,"context_line":"    docker exec openvswitch_vswitchd ovs-vsctl set Open_vSwitch ."},{"line_number":40,"context_line":"    external_ids:ovn-remote-probe-interval\u003d{{ ovn_remote_probe_interval }}"}],"source_content_type":"text/x-yaml","patch_set":120,"id":"df33271e_62fd8f39","line":40,"in_reply_to":"df33271e_f0eb6ed9","updated":"2020-04-07 13:06:21.000000000","message":"Done","commit_id":"b89944275ed552dc50909cb998987a461325d383"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"a1164921a20ee6eec7cdbfd9aa689e88ca22218c","unresolved":false,"context_lines":[{"line_number":29,"context_line":"  command: docker exec openvswitch_vswitchd ovs-vsctl set Open_vSwitch . external-ids:ovn-cms-options\u003d\"enable-chassis-as-gw\""},{"line_number":30,"context_line":"  when:"},{"line_number":31,"context_line":"    - inventory_hostname in groups[\"ovn-controller-network\"]"},{"line_number":32,"context_line":"      or (inventory_hostname in groups[\"ovn-controller-compute\"] and computes_need_external_bridge | bool)"},{"line_number":33,"context_line":""},{"line_number":34,"context_line":"- name: Set OVN remote probe interval"},{"line_number":35,"context_line":"  become: true"}],"source_content_type":"text/x-yaml","patch_set":129,"id":"df33271e_68f38ae8","line":32,"range":{"start_line":32,"start_character":69,"end_line":32,"end_character":98},"updated":"2020-04-08 14:00:25.000000000","message":"Should this be neutron_ovn_distributed_fip? Otherwise it might happen if we enable provider networks.","commit_id":"f7785df573de72c8fd890d32fe5512e9b6abbe7a"}],"ansible/roles/ovn/tasks/check-containers.yml":[{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"afbf6c432c56351f1d06b67e66db1dc1129020f4","unresolved":false,"context_lines":[{"line_number":8,"context_line":"    image: \"{{ item.value.image }}\""},{"line_number":9,"context_line":"    volumes: \"{{ item.value.volumes|reject(\u0027equalto\u0027, \u0027\u0027)|list }}\""},{"line_number":10,"context_line":"    dimensions: \"{{ item.value.dimensions }}\""},{"line_number":11,"context_line":"    environment: \"{{ item.value.environment }}\""},{"line_number":12,"context_line":"  when:"},{"line_number":13,"context_line":"    - inventory_hostname in groups[item.value.group]"},{"line_number":14,"context_line":"    - item.value.enabled | bool"}],"source_content_type":"text/x-yaml","patch_set":92,"id":"3fa7e38b_49edd38b","line":11,"range":{"start_line":11,"start_character":4,"end_line":11,"end_character":47},"updated":"2020-02-19 18:08:18.000000000","message":"Not required","commit_id":"cc297570e75246673c6576c43b12e44f98f646f9"}],"ansible/roles/ovn/tasks/deploy.yml":[{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"afbf6c432c56351f1d06b67e66db1dc1129020f4","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"- include_tasks: config.yml"},{"line_number":3,"context_line":"  when: inventory_hostname in groups[\u0027ovn-controller\u0027] or"},{"line_number":4,"context_line":"        inventory_hostname in groups[\u0027ovn-northd\u0027] or"},{"line_number":5,"context_line":"        inventory_hostname in groups[\u0027ovn-nb-db\u0027] or"},{"line_number":6,"context_line":"        inventory_hostname in groups[\u0027ovn-sb-db\u0027]"},{"line_number":7,"context_line":""},{"line_number":8,"context_line":"- include_tasks: bootstrap.yml"},{"line_number":9,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":92,"id":"3fa7e38b_89f2eb68","line":6,"range":{"start_line":3,"start_character":0,"end_line":6,"end_character":49},"updated":"2020-02-19 18:08:18.000000000","message":"This should always be true.","commit_id":"cc297570e75246673c6576c43b12e44f98f646f9"},{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"cab58a4dd51758dad06a8eb0627874b67e6853cf","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"- include_tasks: config.yml"},{"line_number":3,"context_line":"  when: inventory_hostname in groups[\u0027ovn-controller\u0027] or"},{"line_number":4,"context_line":"        inventory_hostname in groups[\u0027ovn-northd\u0027] or"},{"line_number":5,"context_line":"        inventory_hostname in groups[\u0027ovn-nb-db\u0027] or"},{"line_number":6,"context_line":"        inventory_hostname in groups[\u0027ovn-sb-db\u0027]"},{"line_number":7,"context_line":""},{"line_number":8,"context_line":"- include_tasks: bootstrap.yml"},{"line_number":9,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":92,"id":"3fa7e38b_b6b4cdf5","line":6,"range":{"start_line":3,"start_character":0,"end_line":6,"end_character":49},"in_reply_to":"3fa7e38b_89f2eb68","updated":"2020-02-20 17:40:38.000000000","message":"So removing","commit_id":"cc297570e75246673c6576c43b12e44f98f646f9"}],"ansible/roles/ovn/tasks/upgrade.yml":[{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"0aa11f254a2860ec73adb2d431a2fc098c602c89","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"- include_tasks: config.yml"},{"line_number":3,"context_line":""},{"line_number":4,"context_line":"- include_tasks: bootstrap_service.yml"},{"line_number":5,"context_line":""},{"line_number":6,"context_line":"- name: Flush handlers"},{"line_number":7,"context_line":"  meta: flush_handlers"}],"source_content_type":"text/x-yaml","patch_set":104,"id":"1fa4df85_9008a3d9","line":4,"range":{"start_line":4,"start_character":0,"end_line":4,"end_character":38},"updated":"2020-02-28 17:31:27.000000000","message":"Should we do bootstrap on upgrade?","commit_id":"dfe55d08a36d7422214492cff103060b299ed104"},{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"5bc3672e9a470ff76cb200a58479f16ad5e1457c","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"- include_tasks: config.yml"},{"line_number":3,"context_line":""},{"line_number":4,"context_line":"- include_tasks: bootstrap_service.yml"},{"line_number":5,"context_line":""},{"line_number":6,"context_line":"- name: Flush handlers"},{"line_number":7,"context_line":"  meta: flush_handlers"}],"source_content_type":"text/x-yaml","patch_set":104,"id":"1fa4df85_1f693bbd","line":4,"range":{"start_line":4,"start_character":0,"end_line":4,"end_character":38},"in_reply_to":"1fa4df85_9008a3d9","updated":"2020-03-16 09:38:19.000000000","message":"yeah, we should - bootstrap.yml in this role is setting various OVN settings in the db - if this changes between releases - we\u0027d like it to be consistent.","commit_id":"dfe55d08a36d7422214492cff103060b299ed104"}],"ansible/roles/ovn/templates/ovn-nb-db.json.j2":[{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"afbf6c432c56351f1d06b67e66db1dc1129020f4","unresolved":false,"context_lines":[{"line_number":1,"context_line":"{% set ovnctl_cmd \u003d \u0027/usr/share/ovn/scripts/ovn-ctl\u0027 if kolla_base_distro in [\u0027centos\u0027, \u0027redhat\u0027] else \u0027/usr/share/openvswitch/scripts/ovn-ctl\u0027 %}"},{"line_number":2,"context_line":""},{"line_number":3,"context_line":"{"},{"line_number":4,"context_line":"    \"command\": \"{{ ovnctl_cmd }} run_nb_ovsdb --db-nb-create-insecure-remote\u003dyes --db-nb-addr\u003d{{ api_interface_address }} --db-nb-cluster-local-addr\u003d{{ api_interface_address }} {% if groups[\u0027ovn-nb-db\u0027] | length \u003e 1 and inventory_hostname !\u003d groups[\u0027ovn-nb-db\u0027][0] %} --db-nb-cluster-remote-addr\u003d{{ \u0027api\u0027 | kolla_address(groups[\u0027ovn-nb-db\u0027][0]) }} {% endif %} --db-sock\u003d/run/ovn/ovnnb_db.sock --db-nb-pid\u003d/run/ovn/ovnnb_db.pid --db-nb-file\u003d/var/lib/openvswitch/ovn-nb/ovnnb.db --ovn-nb-logfile\u003d/var/log/kolla/openvswitch/ovn-nb-db.log\","},{"line_number":5,"context_line":"    \"permissions\": ["},{"line_number":6,"context_line":"        {"},{"line_number":7,"context_line":"            \"path\": \"/var/log/kolla/openvswitch\","}],"source_content_type":"text/x-jinja2","patch_set":92,"id":"3fa7e38b_e9afdf2a","line":4,"range":{"start_line":4,"start_character":48,"end_line":4,"end_character":76},"updated":"2020-02-19 18:08:18.000000000","message":"Looks dodgy","commit_id":"cc297570e75246673c6576c43b12e44f98f646f9"},{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"cab58a4dd51758dad06a8eb0627874b67e6853cf","unresolved":false,"context_lines":[{"line_number":1,"context_line":"{% set ovnctl_cmd \u003d \u0027/usr/share/ovn/scripts/ovn-ctl\u0027 if kolla_base_distro in [\u0027centos\u0027, \u0027redhat\u0027] else \u0027/usr/share/openvswitch/scripts/ovn-ctl\u0027 %}"},{"line_number":2,"context_line":""},{"line_number":3,"context_line":"{"},{"line_number":4,"context_line":"    \"command\": \"{{ ovnctl_cmd }} run_nb_ovsdb --db-nb-create-insecure-remote\u003dyes --db-nb-addr\u003d{{ api_interface_address }} --db-nb-cluster-local-addr\u003d{{ api_interface_address }} {% if groups[\u0027ovn-nb-db\u0027] | length \u003e 1 and inventory_hostname !\u003d groups[\u0027ovn-nb-db\u0027][0] %} --db-nb-cluster-remote-addr\u003d{{ \u0027api\u0027 | kolla_address(groups[\u0027ovn-nb-db\u0027][0]) }} {% endif %} --db-sock\u003d/run/ovn/ovnnb_db.sock --db-nb-pid\u003d/run/ovn/ovnnb_db.pid --db-nb-file\u003d/var/lib/openvswitch/ovn-nb/ovnnb.db --ovn-nb-logfile\u003d/var/log/kolla/openvswitch/ovn-nb-db.log\","},{"line_number":5,"context_line":"    \"permissions\": ["},{"line_number":6,"context_line":"        {"},{"line_number":7,"context_line":"            \"path\": \"/var/log/kolla/openvswitch\","}],"source_content_type":"text/x-jinja2","patch_set":92,"id":"3fa7e38b_f6c1e550","line":4,"range":{"start_line":4,"start_character":48,"end_line":4,"end_character":76},"in_reply_to":"3fa7e38b_e9afdf2a","updated":"2020-02-20 17:40:38.000000000","message":"I will change it in a followup when adding ssl support","commit_id":"cc297570e75246673c6576c43b12e44f98f646f9"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"0c0fab1db5974ebe6fbfde16d97481ba697a41f4","unresolved":false,"context_lines":[{"line_number":1,"context_line":"{% set ovnctl_cmd \u003d \u0027/usr/share/ovn/scripts/ovn-ctl\u0027 %}"},{"line_number":2,"context_line":""},{"line_number":3,"context_line":"{"},{"line_number":4,"context_line":"    \"command\": \"{{ ovnctl_cmd }} run_nb_ovsdb --db-nb-create-insecure-remote\u003dyes --db-nb-addr\u003d{{ api_interface_address }} --db-nb-cluster-local-addr\u003d{{ api_interface_address }} {% if groups[\u0027ovn-nb-db\u0027] | length \u003e 1 and inventory_hostname !\u003d groups[\u0027ovn-nb-db\u0027][0] %} --db-nb-cluster-remote-addr\u003d{{ \u0027api\u0027 | kolla_address(groups[\u0027ovn-nb-db\u0027][0]) }} {% endif %} --db-sock\u003d/run/ovn/ovnnb_db.sock --db-nb-pid\u003d/run/ovn/ovnnb_db.pid --db-nb-file\u003d/var/lib/openvswitch/ovn-nb/ovnnb.db --ovn-nb-logfile\u003d/var/log/kolla/openvswitch/ovn-nb-db.log\","},{"line_number":5,"context_line":"    \"permissions\": ["},{"line_number":6,"context_line":"        {"},{"line_number":7,"context_line":"            \"path\": \"/var/log/kolla/openvswitch\","}],"source_content_type":"text/x-jinja2","patch_set":120,"id":"df33271e_3065d646","line":4,"range":{"start_line":4,"start_character":360,"end_line":4,"end_character":392},"updated":"2020-04-03 15:50:38.000000000","message":"Do we need this if using TCP?","commit_id":"b89944275ed552dc50909cb998987a461325d383"},{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"e8eda4c2049e77f3040469a4f506218b5b66d86b","unresolved":false,"context_lines":[{"line_number":1,"context_line":"{% set ovnctl_cmd \u003d \u0027/usr/share/ovn/scripts/ovn-ctl\u0027 %}"},{"line_number":2,"context_line":""},{"line_number":3,"context_line":"{"},{"line_number":4,"context_line":"    \"command\": \"{{ ovnctl_cmd }} run_nb_ovsdb --db-nb-create-insecure-remote\u003dyes --db-nb-addr\u003d{{ api_interface_address }} --db-nb-cluster-local-addr\u003d{{ api_interface_address }} {% if groups[\u0027ovn-nb-db\u0027] | length \u003e 1 and inventory_hostname !\u003d groups[\u0027ovn-nb-db\u0027][0] %} --db-nb-cluster-remote-addr\u003d{{ \u0027api\u0027 | kolla_address(groups[\u0027ovn-nb-db\u0027][0]) }} {% endif %} --db-sock\u003d/run/ovn/ovnnb_db.sock --db-nb-pid\u003d/run/ovn/ovnnb_db.pid --db-nb-file\u003d/var/lib/openvswitch/ovn-nb/ovnnb.db --ovn-nb-logfile\u003d/var/log/kolla/openvswitch/ovn-nb-db.log\","},{"line_number":5,"context_line":"    \"permissions\": ["},{"line_number":6,"context_line":"        {"},{"line_number":7,"context_line":"            \"path\": \"/var/log/kolla/openvswitch\","}],"source_content_type":"text/x-jinja2","patch_set":120,"id":"df33271e_62abcf1c","line":4,"range":{"start_line":4,"start_character":360,"end_line":4,"end_character":392},"in_reply_to":"df33271e_3065d646","updated":"2020-04-07 13:06:21.000000000","message":"It needs to write the sock file somewhere, I prefer this to be controlled than differ between Ubuntu and CentOS.","commit_id":"b89944275ed552dc50909cb998987a461325d383"},{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"296d21b0f5581ed1c05db9669d9be5092779ec75","unresolved":false,"context_lines":[{"line_number":1,"context_line":"{% set ovnctl_cmd \u003d \u0027/usr/share/ovn/scripts/ovn-ctl\u0027 %}"},{"line_number":2,"context_line":""},{"line_number":3,"context_line":"{"},{"line_number":4,"context_line":"    \"command\": \"{{ ovnctl_cmd }} run_nb_ovsdb --db-nb-create-insecure-remote\u003dyes --db-nb-addr\u003d{{ api_interface_address }} --db-nb-cluster-local-addr\u003d{{ api_interface_address }} {% if groups[\u0027ovn-nb-db\u0027] | length \u003e 1 and inventory_hostname !\u003d groups[\u0027ovn-nb-db\u0027][0] %} --db-nb-cluster-remote-addr\u003d{{ \u0027api\u0027 | kolla_address(groups[\u0027ovn-nb-db\u0027][0]) }} {% endif %} --db-sock\u003d/run/ovn/ovnnb_db.sock --db-nb-pid\u003d/run/ovn/ovnnb_db.pid --db-nb-file\u003d/var/lib/openvswitch/ovn-nb/ovnnb.db --ovn-nb-logfile\u003d/var/log/kolla/openvswitch/ovn-nb-db.log\","}],"source_content_type":"text/x-jinja2","patch_set":134,"id":"3f4c43b2_49f199cd","line":1,"updated":"2020-04-15 17:55:06.000000000","message":"\u0027tis weird, why refactored?","commit_id":"8a0740df977916fa5b23117f993cde7282a303bf"}],"ansible/roles/ovn/templates/ovn-northd.json.j2":[{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"0c0fab1db5974ebe6fbfde16d97481ba697a41f4","unresolved":false,"context_lines":[{"line_number":1,"context_line":"{"},{"line_number":2,"context_line":"    \"command\": \"/usr/bin/ovn-northd -vconsole:emer -vsyslog:err -vfile:info --ovnnb-db\u003d{{ ovn_nb_connection }} --ovnsb-db\u003d{{ ovn_sb_connection }} --log-file\u003d/var/log/kolla/openvswitch/ovn-northd.log --pidfile\u003d/run/ovn/ovn-northd.pid --unixctl\u003d/run/ovn/ovn-northd.ctl\","},{"line_number":3,"context_line":"    \"permissions\": ["},{"line_number":4,"context_line":"        {"},{"line_number":5,"context_line":"            \"path\": \"/var/log/kolla/openvswitch\","}],"source_content_type":"text/x-jinja2","patch_set":120,"id":"df33271e_f071ae0e","line":2,"range":{"start_line":2,"start_character":233,"end_line":2,"end_character":266},"updated":"2020-04-03 15:50:38.000000000","message":"Do we need this if using TCP?","commit_id":"b89944275ed552dc50909cb998987a461325d383"}],"ansible/roles/ovn/templates/ovn-sb-db.json.j2":[{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"0c0fab1db5974ebe6fbfde16d97481ba697a41f4","unresolved":false,"context_lines":[{"line_number":1,"context_line":"{% set ovnctl_cmd \u003d \u0027/usr/share/ovn/scripts/ovn-ctl\u0027 %}"},{"line_number":2,"context_line":""},{"line_number":3,"context_line":"{"},{"line_number":4,"context_line":"    \"command\": \"{{ ovnctl_cmd }} run_sb_ovsdb --db-sb-create-insecure-remote\u003dyes --db-sb-addr\u003d{{ api_interface_address }} --db-sb-cluster-local-addr\u003d{{ api_interface_address }} {% if groups[\u0027ovn-sb-db\u0027] | length \u003e 1 and inventory_hostname !\u003d groups[\u0027ovn-sb-db\u0027][0] %} --db-sb-cluster-remote-addr\u003d{{ \u0027api\u0027 | kolla_address(groups[\u0027ovn-sb-db\u0027][0]) }} {% endif %} --db-sock\u003d/run/ovn/ovnsb_db.sock --db-sb-pid\u003d/run/ovn/ovnsb_db.pid --db-sb-file\u003d/var/lib/openvswitch/ovn-sb/ovnsb.db --ovn-sb-logfile\u003d/var/log/kolla/openvswitch/ovn-sb-db.log\","},{"line_number":5,"context_line":"    \"permissions\": ["},{"line_number":6,"context_line":"        {"},{"line_number":7,"context_line":"            \"path\": \"/var/log/kolla/openvswitch\","}],"source_content_type":"text/x-jinja2","patch_set":120,"id":"df33271e_50c5fa09","line":4,"range":{"start_line":4,"start_character":360,"end_line":4,"end_character":392},"updated":"2020-04-03 15:50:38.000000000","message":"Do we need this if using TCP?","commit_id":"b89944275ed552dc50909cb998987a461325d383"},{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"e8eda4c2049e77f3040469a4f506218b5b66d86b","unresolved":false,"context_lines":[{"line_number":1,"context_line":"{% set ovnctl_cmd \u003d \u0027/usr/share/ovn/scripts/ovn-ctl\u0027 %}"},{"line_number":2,"context_line":""},{"line_number":3,"context_line":"{"},{"line_number":4,"context_line":"    \"command\": \"{{ ovnctl_cmd }} run_sb_ovsdb --db-sb-create-insecure-remote\u003dyes --db-sb-addr\u003d{{ api_interface_address }} --db-sb-cluster-local-addr\u003d{{ api_interface_address }} {% if groups[\u0027ovn-sb-db\u0027] | length \u003e 1 and inventory_hostname !\u003d groups[\u0027ovn-sb-db\u0027][0] %} --db-sb-cluster-remote-addr\u003d{{ \u0027api\u0027 | kolla_address(groups[\u0027ovn-sb-db\u0027][0]) }} {% endif %} --db-sock\u003d/run/ovn/ovnsb_db.sock --db-sb-pid\u003d/run/ovn/ovnsb_db.pid --db-sb-file\u003d/var/lib/openvswitch/ovn-sb/ovnsb.db --ovn-sb-logfile\u003d/var/log/kolla/openvswitch/ovn-sb-db.log\","},{"line_number":5,"context_line":"    \"permissions\": ["},{"line_number":6,"context_line":"        {"},{"line_number":7,"context_line":"            \"path\": \"/var/log/kolla/openvswitch\","}],"source_content_type":"text/x-jinja2","patch_set":120,"id":"df33271e_a262f714","line":4,"range":{"start_line":4,"start_character":360,"end_line":4,"end_character":392},"in_reply_to":"df33271e_50c5fa09","updated":"2020-04-07 13:06:21.000000000","message":"same as earlier, prefer it to be in the same spot irrespective of the distro (and what it sets on package building time).","commit_id":"b89944275ed552dc50909cb998987a461325d383"},{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"296d21b0f5581ed1c05db9669d9be5092779ec75","unresolved":false,"context_lines":[{"line_number":1,"context_line":"{% set ovnctl_cmd \u003d \u0027/usr/share/ovn/scripts/ovn-ctl\u0027 %}"},{"line_number":2,"context_line":""},{"line_number":3,"context_line":"{"},{"line_number":4,"context_line":"    \"command\": \"{{ ovnctl_cmd }} run_sb_ovsdb --db-sb-create-insecure-remote\u003dyes --db-sb-addr\u003d{{ api_interface_address }} --db-sb-cluster-local-addr\u003d{{ api_interface_address }} {% if groups[\u0027ovn-sb-db\u0027] | length \u003e 1 and inventory_hostname !\u003d groups[\u0027ovn-sb-db\u0027][0] %} --db-sb-cluster-remote-addr\u003d{{ \u0027api\u0027 | kolla_address(groups[\u0027ovn-sb-db\u0027][0]) }} {% endif %} --db-sock\u003d/run/ovn/ovnsb_db.sock --db-sb-pid\u003d/run/ovn/ovnsb_db.pid --db-sb-file\u003d/var/lib/openvswitch/ovn-sb/ovnsb.db --ovn-sb-logfile\u003d/var/log/kolla/openvswitch/ovn-sb-db.log\","}],"source_content_type":"text/x-jinja2","patch_set":134,"id":"3f4c43b2_69bf35d0","line":1,"updated":"2020-04-15 17:55:06.000000000","message":"ditto, not following","commit_id":"8a0740df977916fa5b23117f993cde7282a303bf"}],"ansible/site.yml":[{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"afbf6c432c56351f1d06b67e66db1dc1129020f4","unresolved":false,"context_lines":[{"line_number":59,"context_line":"        - enable_nova_{{ enable_nova | bool }}"},{"line_number":60,"context_line":"        - enable_octavia_{{ enable_octavia | bool }}"},{"line_number":61,"context_line":"        - enable_openvswitch_{{ enable_openvswitch | bool }}_enable_ovs_dpdk_{{ enable_ovs_dpdk | bool }}"},{"line_number":62,"context_line":"        - enable_ovn_{{ enable_ovn | bool }}"},{"line_number":63,"context_line":"        - enable_outward_rabbitmq_{{ enable_outward_rabbitmq | bool }}"},{"line_number":64,"context_line":"        - enable_panko_{{ enable_panko | bool }}"},{"line_number":65,"context_line":"        - enable_placement_{{ enable_placement | bool }}"}],"source_content_type":"text/x-yaml","patch_set":92,"id":"3fa7e38b_89750bcc","line":62,"updated":"2020-02-19 18:08:18.000000000","message":"nit: ovn after outward","commit_id":"cc297570e75246673c6576c43b12e44f98f646f9"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"afbf6c432c56351f1d06b67e66db1dc1129020f4","unresolved":false,"context_lines":[{"line_number":711,"context_line":"- name: Apply role ovn"},{"line_number":712,"context_line":"  gather_facts: false"},{"line_number":713,"context_line":"  hosts:"},{"line_number":714,"context_line":"    - ovn"},{"line_number":715,"context_line":"    - \u0027\u0026enable_ovn_True\u0027"},{"line_number":716,"context_line":"  serial: \u0027{{ kolla_serial|default(\"0\") }}\u0027"},{"line_number":717,"context_line":"  roles:"}],"source_content_type":"text/x-yaml","patch_set":92,"id":"3fa7e38b_29441776","line":714,"range":{"start_line":714,"start_character":6,"end_line":714,"end_character":9},"updated":"2020-02-19 18:08:18.000000000","message":"Better to list the groups individually.","commit_id":"cc297570e75246673c6576c43b12e44f98f646f9"},{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"cab58a4dd51758dad06a8eb0627874b67e6853cf","unresolved":false,"context_lines":[{"line_number":711,"context_line":"- name: Apply role ovn"},{"line_number":712,"context_line":"  gather_facts: false"},{"line_number":713,"context_line":"  hosts:"},{"line_number":714,"context_line":"    - ovn"},{"line_number":715,"context_line":"    - \u0027\u0026enable_ovn_True\u0027"},{"line_number":716,"context_line":"  serial: \u0027{{ kolla_serial|default(\"0\") }}\u0027"},{"line_number":717,"context_line":"  roles:"}],"source_content_type":"text/x-yaml","patch_set":92,"id":"3fa7e38b_368d3d36","line":714,"range":{"start_line":714,"start_character":6,"end_line":714,"end_character":9},"in_reply_to":"3fa7e38b_29441776","updated":"2020-02-20 17:40:38.000000000","message":"Done","commit_id":"cc297570e75246673c6576c43b12e44f98f646f9"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"a1164921a20ee6eec7cdbfd9aa689e88ca22218c","unresolved":false,"context_lines":[{"line_number":742,"context_line":"    - neutron-dhcp-agent"},{"line_number":743,"context_line":"    - neutron-l3-agent"},{"line_number":744,"context_line":"    - ironic-neutron-agent"},{"line_number":745,"context_line":"    - neutron-metadata-agent"},{"line_number":746,"context_line":"    - neutron-metering-agent"},{"line_number":747,"context_line":"    - compute"},{"line_number":748,"context_line":"    - manila-share"}],"source_content_type":"text/x-yaml","patch_set":129,"id":"df33271e_8821ae50","line":745,"updated":"2020-04-08 14:00:25.000000000","message":"neutron-ovn-metadata-agent","commit_id":"f7785df573de72c8fd890d32fe5512e9b6abbe7a"}],"doc/source/reference/networking/neutron.rst":[{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"fe200e577209100b76e38ab7c7ed5a128663a034","unresolved":false,"context_lines":[{"line_number":63,"context_line":".. path /etc/kolla/globals.yml"},{"line_number":64,"context_line":".. code-block:: yaml"},{"line_number":65,"context_line":""},{"line_number":66,"context_line":"   enable_ovn: \"yes\""},{"line_number":67,"context_line":"   neutron_plugin_agent: \"ovn\""}],"source_content_type":"text/x-rst","patch_set":71,"id":"3fa7e38b_9bbb5173","line":66,"range":{"start_line":66,"start_character":3,"end_line":66,"end_character":20},"updated":"2020-01-10 10:30:22.000000000","message":"and you could also drop this if one configures it all via neutron_plugin_agent :-)","commit_id":"6543a07da1dce58601d70bb65fadb053c99e4f5a"},{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"1da608c04abce32d89c6acb4e673d1a36b16d794","unresolved":false,"context_lines":[{"line_number":63,"context_line":".. path /etc/kolla/globals.yml"},{"line_number":64,"context_line":".. code-block:: yaml"},{"line_number":65,"context_line":""},{"line_number":66,"context_line":"   enable_ovn: \"yes\""},{"line_number":67,"context_line":"   neutron_plugin_agent: \"ovn\""}],"source_content_type":"text/x-rst","patch_set":71,"id":"3fa7e38b_8660d80e","line":66,"range":{"start_line":66,"start_character":3,"end_line":66,"end_character":20},"in_reply_to":"3fa7e38b_9bbb5173","updated":"2020-01-10 11:44:55.000000000","message":"(pending)","commit_id":"6543a07da1dce58601d70bb65fadb053c99e4f5a"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"afbf6c432c56351f1d06b67e66db1dc1129020f4","unresolved":false,"context_lines":[{"line_number":56,"context_line":""},{"line_number":57,"context_line":"   [security_group]"},{"line_number":58,"context_line":"   firewall_driver \u003d openvswitch"},{"line_number":59,"context_line":""},{"line_number":60,"context_line":"In order to use ``OVN`` as mechanism driver for ``neutron``, you need to set"},{"line_number":61,"context_line":"the following:"},{"line_number":62,"context_line":""}],"source_content_type":"text/x-rst","patch_set":92,"id":"3fa7e38b_492e33ab","line":59,"updated":"2020-02-19 18:08:18.000000000","message":"New subtitle?","commit_id":"cc297570e75246673c6576c43b12e44f98f646f9"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"afbf6c432c56351f1d06b67e66db1dc1129020f4","unresolved":false,"context_lines":[{"line_number":67,"context_line":"   neutron_type_drivers: \"flat,vlan,geneve\""},{"line_number":68,"context_line":"   neutron_tenant_network_types: \"geneve\""},{"line_number":69,"context_line":""},{"line_number":70,"context_line":"You can use Kolla-Ansible OVN controller deployment mechanism by setting:"},{"line_number":71,"context_line":""},{"line_number":72,"context_line":".. path /etc/kolla/globals.yml"},{"line_number":73,"context_line":".. code-block:: yaml"},{"line_number":74,"context_line":""},{"line_number":75,"context_line":"   enable_ovn: \"yes\""},{"line_number":76,"context_line":""},{"line_number":77,"context_line":""}],"source_content_type":"text/x-rst","patch_set":92,"id":"3fa7e38b_c9546326","line":76,"range":{"start_line":70,"start_character":0,"end_line":76,"end_character":0},"updated":"2020-02-19 18:08:18.000000000","message":"Doesn\u0027t this happen automatically when neutron_plugin_agent is ovn?","commit_id":"cc297570e75246673c6576c43b12e44f98f646f9"},{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"cab58a4dd51758dad06a8eb0627874b67e6853cf","unresolved":false,"context_lines":[{"line_number":67,"context_line":"   neutron_type_drivers: \"flat,vlan,geneve\""},{"line_number":68,"context_line":"   neutron_tenant_network_types: \"geneve\""},{"line_number":69,"context_line":""},{"line_number":70,"context_line":"You can use Kolla-Ansible OVN controller deployment mechanism by setting:"},{"line_number":71,"context_line":""},{"line_number":72,"context_line":".. path /etc/kolla/globals.yml"},{"line_number":73,"context_line":".. code-block:: yaml"},{"line_number":74,"context_line":""},{"line_number":75,"context_line":"   enable_ovn: \"yes\""},{"line_number":76,"context_line":""},{"line_number":77,"context_line":""}],"source_content_type":"text/x-rst","patch_set":92,"id":"3fa7e38b_f6a485a6","line":76,"range":{"start_line":70,"start_character":0,"end_line":76,"end_character":0},"in_reply_to":"3fa7e38b_3471ca14","updated":"2020-02-20 17:40:38.000000000","message":"Yeah, I\u0027ll test an external OVN and followup with a guide how to use it.","commit_id":"cc297570e75246673c6576c43b12e44f98f646f9"},{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"b9736df7fcc591250394e349b31134f434004176","unresolved":false,"context_lines":[{"line_number":67,"context_line":"   neutron_type_drivers: \"flat,vlan,geneve\""},{"line_number":68,"context_line":"   neutron_tenant_network_types: \"geneve\""},{"line_number":69,"context_line":""},{"line_number":70,"context_line":"You can use Kolla-Ansible OVN controller deployment mechanism by setting:"},{"line_number":71,"context_line":""},{"line_number":72,"context_line":".. path /etc/kolla/globals.yml"},{"line_number":73,"context_line":".. code-block:: yaml"},{"line_number":74,"context_line":""},{"line_number":75,"context_line":"   enable_ovn: \"yes\""},{"line_number":76,"context_line":""},{"line_number":77,"context_line":""}],"source_content_type":"text/x-rst","patch_set":92,"id":"3fa7e38b_3471ca14","line":76,"range":{"start_line":70,"start_character":0,"end_line":76,"end_character":0},"in_reply_to":"3fa7e38b_c9546326","updated":"2020-02-19 18:48:08.000000000","message":"This should probably speak how to disable bultin ovn and roll one\u0027s own (for some odd reason).","commit_id":"cc297570e75246673c6576c43b12e44f98f646f9"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"0c0fab1db5974ebe6fbfde16d97481ba697a41f4","unresolved":false,"context_lines":[{"line_number":73,"context_line":"   neutron_type_drivers: \"flat,vlan,geneve\""},{"line_number":74,"context_line":"   neutron_tenant_network_types: \"geneve\""},{"line_number":75,"context_line":""},{"line_number":76,"context_line":"When using OVN - Kolla-Ansible will enable external bridges on computes"},{"line_number":77,"context_line":"following OVN\u0027s philosophy of DVR and N-S routing on computes. If you prefer"},{"line_number":78,"context_line":"N-S routing on network nodes - please set the following:"},{"line_number":79,"context_line":""},{"line_number":80,"context_line":".. path /etc/kolla/globals.yml"},{"line_number":81,"context_line":".. code-block:: yaml"},{"line_number":82,"context_line":""},{"line_number":83,"context_line":"   computes_need_external_bridge: \"no\""},{"line_number":84,"context_line":""}],"source_content_type":"text/x-rst","patch_set":120,"id":"df33271e_70a2be4d","line":83,"range":{"start_line":76,"start_character":0,"end_line":83,"end_character":38},"updated":"2020-04-03 15:50:38.000000000","message":"As mentioned earlier, this depends on a config option that we aren\u0027t setting.","commit_id":"b89944275ed552dc50909cb998987a461325d383"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"a1164921a20ee6eec7cdbfd9aa689e88ca22218c","unresolved":false,"context_lines":[{"line_number":70,"context_line":".. code-block:: yaml"},{"line_number":71,"context_line":""},{"line_number":72,"context_line":"   neutron_plugin_agent: \"ovn\""},{"line_number":73,"context_line":"   neutron_type_drivers: \"flat,vlan,geneve\""},{"line_number":74,"context_line":"   neutron_tenant_network_types: \"geneve\""},{"line_number":75,"context_line":""},{"line_number":76,"context_line":"When using OVN - Kolla-Ansible will enable external bridges on computes"},{"line_number":77,"context_line":"following OVN\u0027s philosophy of DVR and N-S routing on computes. If you prefer"}],"source_content_type":"text/x-rst","patch_set":129,"id":"df33271e_68e1cafc","line":74,"range":{"start_line":73,"start_character":0,"end_line":74,"end_character":41},"updated":"2020-04-08 14:00:25.000000000","message":"Not required","commit_id":"f7785df573de72c8fd890d32fe5512e9b6abbe7a"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"a1164921a20ee6eec7cdbfd9aa689e88ca22218c","unresolved":false,"context_lines":[{"line_number":73,"context_line":"   neutron_type_drivers: \"flat,vlan,geneve\""},{"line_number":74,"context_line":"   neutron_tenant_network_types: \"geneve\""},{"line_number":75,"context_line":""},{"line_number":76,"context_line":"When using OVN - Kolla-Ansible will enable external bridges on computes"},{"line_number":77,"context_line":"following OVN\u0027s philosophy of DVR and N-S routing on computes. If you prefer"},{"line_number":78,"context_line":"N-S routing on network nodes - please set the following:"},{"line_number":79,"context_line":""},{"line_number":80,"context_line":".. path /etc/kolla/globals.yml"},{"line_number":81,"context_line":".. code-block:: yaml"},{"line_number":82,"context_line":""},{"line_number":83,"context_line":"   computes_need_external_bridge: \"no\""},{"line_number":84,"context_line":""}],"source_content_type":"text/x-rst","patch_set":129,"id":"df33271e_e8be7ad2","line":83,"range":{"start_line":76,"start_character":0,"end_line":83,"end_character":38},"updated":"2020-04-08 14:00:25.000000000","message":"Needs an update, also distributed is off by default.","commit_id":"f7785df573de72c8fd890d32fe5512e9b6abbe7a"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"1ea47a404c10db30f8a683ff829fe73dcbc019dc","unresolved":false,"context_lines":[{"line_number":78,"context_line":".. path /etc/kolla/globals.yml"},{"line_number":79,"context_line":".. code-block:: yaml"},{"line_number":80,"context_line":""},{"line_number":81,"context_line":"   enable_distributed_floating_ip: \"yes\""},{"line_number":82,"context_line":""}],"source_content_type":"text/x-rst","patch_set":130,"id":"df33271e_03bc61da","line":81,"range":{"start_line":81,"start_character":3,"end_line":81,"end_character":33},"updated":"2020-04-08 14:23:15.000000000","message":"neutron_ovn_distributed_fip","commit_id":"79e1a6dcda1730aa97d52f1a0862ceb627d80181"}],"etc/kolla/globals.yml":[{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"afbf6c432c56351f1d06b67e66db1dc1129020f4","unresolved":false,"context_lines":[{"line_number":324,"context_line":"#enable_nova_ssh: \"yes\""},{"line_number":325,"context_line":"#enable_octavia: \"no\""},{"line_number":326,"context_line":"#enable_openvswitch: \"{{ enable_neutron | bool and neutron_plugin_agent !\u003d \u0027linuxbridge\u0027 }}\""},{"line_number":327,"context_line":"#enable_ovn: \"no\""},{"line_number":328,"context_line":"#enable_ovs_dpdk: \"no\""},{"line_number":329,"context_line":"#enable_osprofiler: \"no\""},{"line_number":330,"context_line":"#enable_panko: \"no\""}],"source_content_type":"text/x-yaml","patch_set":92,"id":"3fa7e38b_c919c38b","line":327,"range":{"start_line":327,"start_character":14,"end_line":327,"end_character":16},"updated":"2020-02-19 18:08:18.000000000","message":"Doesn\u0027t match default","commit_id":"cc297570e75246673c6576c43b12e44f98f646f9"},{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"cab58a4dd51758dad06a8eb0627874b67e6853cf","unresolved":false,"context_lines":[{"line_number":324,"context_line":"#enable_nova_ssh: \"yes\""},{"line_number":325,"context_line":"#enable_octavia: \"no\""},{"line_number":326,"context_line":"#enable_openvswitch: \"{{ enable_neutron | bool and neutron_plugin_agent !\u003d \u0027linuxbridge\u0027 }}\""},{"line_number":327,"context_line":"#enable_ovn: \"no\""},{"line_number":328,"context_line":"#enable_ovs_dpdk: \"no\""},{"line_number":329,"context_line":"#enable_osprofiler: \"no\""},{"line_number":330,"context_line":"#enable_panko: \"no\""}],"source_content_type":"text/x-yaml","patch_set":92,"id":"3fa7e38b_96ad1185","line":327,"range":{"start_line":327,"start_character":14,"end_line":327,"end_character":16},"in_reply_to":"3fa7e38b_c919c38b","updated":"2020-02-20 17:40:38.000000000","message":"Done","commit_id":"cc297570e75246673c6576c43b12e44f98f646f9"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"0aa11f254a2860ec73adb2d431a2fc098c602c89","unresolved":false,"context_lines":[{"line_number":660,"context_line":"# Configure telegraf to use the docker daemon itself as an input for"},{"line_number":661,"context_line":"# telemetry data."},{"line_number":662,"context_line":"#telegraf_enable_docker_input: \"no\""},{"line_number":663,"context_line":""},{"line_number":664,"context_line":"#####"},{"line_number":665,"context_line":"# OVN"},{"line_number":666,"context_line":"#####"},{"line_number":667,"context_line":"# Configure OVN remote probe interval time in ms"},{"line_number":668,"context_line":"#ovn_remote_probe_interval: \"60000\""}],"source_content_type":"text/x-yaml","patch_set":104,"id":"1fa4df85_f021d74e","line":668,"range":{"start_line":663,"start_character":0,"end_line":668,"end_character":35},"updated":"2020-02-28 17:31:27.000000000","message":"Not required","commit_id":"dfe55d08a36d7422214492cff103060b299ed104"},{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"5bc3672e9a470ff76cb200a58479f16ad5e1457c","unresolved":false,"context_lines":[{"line_number":660,"context_line":"# Configure telegraf to use the docker daemon itself as an input for"},{"line_number":661,"context_line":"# telemetry data."},{"line_number":662,"context_line":"#telegraf_enable_docker_input: \"no\""},{"line_number":663,"context_line":""},{"line_number":664,"context_line":"#####"},{"line_number":665,"context_line":"# OVN"},{"line_number":666,"context_line":"#####"},{"line_number":667,"context_line":"# Configure OVN remote probe interval time in ms"},{"line_number":668,"context_line":"#ovn_remote_probe_interval: \"60000\""}],"source_content_type":"text/x-yaml","patch_set":104,"id":"1fa4df85_b465ae1f","line":668,"range":{"start_line":663,"start_character":0,"end_line":668,"end_character":35},"in_reply_to":"1fa4df85_f021d74e","updated":"2020-03-16 09:38:19.000000000","message":"Done","commit_id":"dfe55d08a36d7422214492cff103060b299ed104"}],"releasenotes/notes/implement-ovn-80b3a73e6c8a44e7.yaml":[{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"afbf6c432c56351f1d06b67e66db1dc1129020f4","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Implement OVN Ansible role."}],"source_content_type":"text/x-yaml","patch_set":92,"id":"3fa7e38b_8923cbbb","line":4,"updated":"2020-02-19 18:08:18.000000000","message":"We can probably say a bit more. Users don\u0027t care about roles, they care about features.","commit_id":"cc297570e75246673c6576c43b12e44f98f646f9"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"0c0fab1db5974ebe6fbfde16d97481ba697a41f4","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Implement OVN Ansible role."}],"source_content_type":"text/x-yaml","patch_set":120,"id":"df33271e_30c156e6","line":4,"range":{"start_line":4,"start_character":4,"end_line":4,"end_character":31},"updated":"2020-04-03 15:50:38.000000000","message":"We can offer a bit more info than this. For users, they care that we can now deploy OVN, and provide integration with neutron.","commit_id":"b89944275ed552dc50909cb998987a461325d383"},{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"e8eda4c2049e77f3040469a4f506218b5b66d86b","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Implement OVN Ansible role."}],"source_content_type":"text/x-yaml","patch_set":120,"id":"df33271e_c5b8e5e6","line":4,"range":{"start_line":4,"start_character":4,"end_line":4,"end_character":31},"in_reply_to":"df33271e_30c156e6","updated":"2020-04-07 13:06:21.000000000","message":"Done","commit_id":"b89944275ed552dc50909cb998987a461325d383"},{"author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"tag":"autogenerated:zuul:check","change_message_id":"3a7144cce357114f68c8cc065761b1ba68828167","unresolved":false,"context_lines":[{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Implement OVN and integration with Neutron. This includes deployment of:"},{"line_number":5,"context_line":" "},{"line_number":6,"context_line":"    * OVN databases (``ovn-sb-db`` and ``ovn-nb-db``)"},{"line_number":7,"context_line":"    * Southbound and Northbound databases connector (``ovn-northd``)"},{"line_number":8,"context_line":"    * Hypervisor components ``ovn-controller`` and"}],"source_content_type":"text/x-yaml","patch_set":121,"id":"df33271e_47b7b4d9","line":5,"updated":"2020-04-07 16:12:35.000000000","message":"pep8:  D002 Trailing whitespace","commit_id":"73de014a79bb95c60eeac4113f8cfe1660546217"},{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"296d21b0f5581ed1c05db9669d9be5092779ec75","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Implement OVN and integration with Neutron. This includes deployment of:"},{"line_number":5,"context_line":""},{"line_number":6,"context_line":"    * OVN databases (``ovn-sb-db`` and ``ovn-nb-db``)"},{"line_number":7,"context_line":"    * Southbound and Northbound databases connector (``ovn-northd``)"}],"source_content_type":"text/x-yaml","patch_set":134,"id":"3f4c43b2_a9b93dea","line":4,"range":{"start_line":4,"start_character":22,"end_line":4,"end_character":33},"updated":"2020-04-15 17:55:06.000000000","message":"its integration","commit_id":"8a0740df977916fa5b23117f993cde7282a303bf"}],"tests/init-core-openstack.sh":[{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"1ac2ed5601217d9261963ba9f3ac74d9c39f6b05","unresolved":false,"context_lines":[{"line_number":15,"context_line":"    fi"},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"    echo \"Initialising OpenStack resources via init-runonce\""},{"line_number":18,"context_line":"    bash -x tools/init-runonce \u0026\u003e /tmp/logs/ansible/init-runonce"},{"line_number":19,"context_line":"}"},{"line_number":20,"context_line":""},{"line_number":21,"context_line":""}],"source_content_type":"text/x-sh","patch_set":84,"id":"3fa7e38b_c042940d","line":18,"updated":"2020-02-10 09:44:48.000000000","message":"no need if you base on debug patch","commit_id":"e0d8113e79e046b13d94487625ba1d55ff8c1f6c"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"9e83381fcbbb72bc68a6937edc2fca0ff14a26ea","unresolved":false,"context_lines":[{"line_number":12,"context_line":"    . ~/openstackclient-venv/bin/activate"},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"    if [[ $SCENARIO \u003d\u003d \"ovn\" ]]; then"},{"line_number":15,"context_line":"        export PROVIDER_NET_TYPE\u003d\u0027geneve\u0027"},{"line_number":16,"context_line":"    fi"},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"    echo \"Initialising OpenStack resources via init-runonce\""}],"source_content_type":"text/x-sh","patch_set":122,"id":"df33271e_8af36be7","line":15,"range":{"start_line":15,"start_character":15,"end_line":15,"end_character":32},"updated":"2020-04-08 09:49:32.000000000","message":"I think if we put geneve first in the tenant network types list we won\u0027t need this.","commit_id":"4f55ccc5a8499be973618fb380487f95eee3478a"},{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"181dc6a3a46c7858c7a21afc3a029aabdd1ecff3","unresolved":false,"context_lines":[{"line_number":12,"context_line":"    . ~/openstackclient-venv/bin/activate"},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"    if [[ $SCENARIO \u003d\u003d \"ovn\" ]]; then"},{"line_number":15,"context_line":"        export PROVIDER_NET_TYPE\u003d\u0027geneve\u0027"},{"line_number":16,"context_line":"    fi"},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"    echo \"Initialising OpenStack resources via init-runonce\""}],"source_content_type":"text/x-sh","patch_set":122,"id":"df33271e_bec95479","line":15,"range":{"start_line":15,"start_character":15,"end_line":15,"end_character":32},"in_reply_to":"df33271e_8af36be7","updated":"2020-04-08 10:27:16.000000000","message":"True, let\u0027s try.","commit_id":"4f55ccc5a8499be973618fb380487f95eee3478a"}],"tests/run.yml":[{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"fe200e577209100b76e38ab7c7ed5a128663a034","unresolved":false,"context_lines":[{"line_number":287,"context_line":"            cmd: test-core-openstack.sh"},{"line_number":288,"context_line":"            executable: /bin/bash"},{"line_number":289,"context_line":"            chdir: \"{{ kolla_ansible_src_dir }}\""},{"line_number":290,"context_line":"          environment:"},{"line_number":291,"context_line":"            SCENARIO: \"{{ scenario }}\""},{"line_number":292,"context_line":"          when: openstack_core_tested"},{"line_number":293,"context_line":""},{"line_number":294,"context_line":"        - name: Run test-zun.sh script"}],"source_content_type":"text/x-yaml","patch_set":71,"id":"3fa7e38b_7bb45581","side":"PARENT","line":291,"range":{"start_line":290,"start_character":0,"end_line":291,"end_character":38},"updated":"2020-01-10 10:30:22.000000000","message":"WHY?","commit_id":"cf6e157b79659f6985af8e5210f578667ba46c2f"},{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"ca4cd4772f87b7325ac013e2c76d0fd3dbbdf3b0","unresolved":false,"context_lines":[{"line_number":287,"context_line":"            cmd: test-core-openstack.sh"},{"line_number":288,"context_line":"            executable: /bin/bash"},{"line_number":289,"context_line":"            chdir: \"{{ kolla_ansible_src_dir }}\""},{"line_number":290,"context_line":"          environment:"},{"line_number":291,"context_line":"            SCENARIO: \"{{ scenario }}\""},{"line_number":292,"context_line":"          when: openstack_core_tested"},{"line_number":293,"context_line":""},{"line_number":294,"context_line":"        - name: Run test-zun.sh script"}],"source_content_type":"text/x-yaml","patch_set":71,"id":"3fa7e38b_1b0be12a","side":"PARENT","line":291,"range":{"start_line":290,"start_character":0,"end_line":291,"end_character":38},"in_reply_to":"3fa7e38b_7bb45581","updated":"2020-01-10 11:37:29.000000000","message":"Done","commit_id":"cf6e157b79659f6985af8e5210f578667ba46c2f"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"0c0fab1db5974ebe6fbfde16d97481ba697a41f4","unresolved":false,"context_lines":[{"line_number":424,"context_line":"            executable: /bin/bash"},{"line_number":425,"context_line":"            chdir: \"{{ kolla_ansible_src_dir }}\""},{"line_number":426,"context_line":"          environment:"},{"line_number":427,"context_line":"            BASE_DISTRO: \"{{ base_distro }}\""},{"line_number":428,"context_line":"          when: scenario \u003d\u003d \"ovn\""},{"line_number":429,"context_line":""},{"line_number":430,"context_line":"        - name: Run test-mariadb.sh script"}],"source_content_type":"text/x-yaml","patch_set":120,"id":"df33271e_10aa5218","line":427,"range":{"start_line":427,"start_character":12,"end_line":427,"end_character":23},"updated":"2020-04-03 15:50:38.000000000","message":"no longer required","commit_id":"b89944275ed552dc50909cb998987a461325d383"},{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"e8eda4c2049e77f3040469a4f506218b5b66d86b","unresolved":false,"context_lines":[{"line_number":424,"context_line":"            executable: /bin/bash"},{"line_number":425,"context_line":"            chdir: \"{{ kolla_ansible_src_dir }}\""},{"line_number":426,"context_line":"          environment:"},{"line_number":427,"context_line":"            BASE_DISTRO: \"{{ base_distro }}\""},{"line_number":428,"context_line":"          when: scenario \u003d\u003d \"ovn\""},{"line_number":429,"context_line":""},{"line_number":430,"context_line":"        - name: Run test-mariadb.sh script"}],"source_content_type":"text/x-yaml","patch_set":120,"id":"df33271e_e2451f72","line":427,"range":{"start_line":427,"start_character":12,"end_line":427,"end_character":23},"in_reply_to":"df33271e_10aa5218","updated":"2020-04-07 13:06:21.000000000","message":"Done","commit_id":"b89944275ed552dc50909cb998987a461325d383"}],"tests/templates/globals-default.j2":[{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"afbf6c432c56351f1d06b67e66db1dc1129020f4","unresolved":false,"context_lines":[{"line_number":122,"context_line":"{% endif %}"},{"line_number":123,"context_line":""},{"line_number":124,"context_line":"{% if scenario \u003d\u003d \"ovn\" %}"},{"line_number":125,"context_line":"enable_ovn: \"yes\""},{"line_number":126,"context_line":"neutron_plugin_agent: \"ovn\""},{"line_number":127,"context_line":"neutron_type_drivers: \"flat,vlan,geneve\""},{"line_number":128,"context_line":"neutron_tenant_network_types: \"geneve\""}],"source_content_type":"text/x-jinja2","patch_set":92,"id":"3fa7e38b_49171355","line":125,"range":{"start_line":125,"start_character":0,"end_line":125,"end_character":16},"updated":"2020-02-19 18:08:18.000000000","message":"Not required","commit_id":"cc297570e75246673c6576c43b12e44f98f646f9"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"a1164921a20ee6eec7cdbfd9aa689e88ca22218c","unresolved":false,"context_lines":[{"line_number":133,"context_line":""},{"line_number":134,"context_line":"{% if scenario \u003d\u003d \"ovn\" %}"},{"line_number":135,"context_line":"neutron_plugin_agent: \"ovn\""},{"line_number":136,"context_line":"neutron_type_drivers: \"flat,vlan,geneve\""},{"line_number":137,"context_line":"neutron_tenant_network_types: \"geneve\""},{"line_number":138,"context_line":"{% endif %}"}],"source_content_type":"text/x-jinja2","patch_set":129,"id":"df33271e_68ca6a6e","line":137,"range":{"start_line":136,"start_character":0,"end_line":137,"end_character":38},"updated":"2020-04-08 14:00:25.000000000","message":"Not required.","commit_id":"f7785df573de72c8fd890d32fe5512e9b6abbe7a"}],"tests/templates/inventory.j2":[{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"0c0fab1db5974ebe6fbfde16d97481ba697a41f4","unresolved":false,"context_lines":[{"line_number":285,"context_line":"[blazar:children]"},{"line_number":286,"context_line":"control"},{"line_number":287,"context_line":""},{"line_number":288,"context_line":"[ovn:children]"},{"line_number":289,"context_line":"network"},{"line_number":290,"context_line":""},{"line_number":291,"context_line":"# Additional control implemented here. These groups allow you to control which"},{"line_number":292,"context_line":"# services run on which hosts at a per-service level."}],"source_content_type":"text/x-jinja2","patch_set":120,"id":"df33271e_7070fedd","line":289,"range":{"start_line":288,"start_character":0,"end_line":289,"end_character":7},"updated":"2020-04-03 15:50:38.000000000","message":"Not used","commit_id":"b89944275ed552dc50909cb998987a461325d383"},{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"e8eda4c2049e77f3040469a4f506218b5b66d86b","unresolved":false,"context_lines":[{"line_number":285,"context_line":"[blazar:children]"},{"line_number":286,"context_line":"control"},{"line_number":287,"context_line":""},{"line_number":288,"context_line":"[ovn:children]"},{"line_number":289,"context_line":"network"},{"line_number":290,"context_line":""},{"line_number":291,"context_line":"# Additional control implemented here. These groups allow you to control which"},{"line_number":292,"context_line":"# services run on which hosts at a per-service level."}],"source_content_type":"text/x-jinja2","patch_set":120,"id":"df33271e_4254cb21","line":289,"range":{"start_line":288,"start_character":0,"end_line":289,"end_character":7},"in_reply_to":"df33271e_7070fedd","updated":"2020-04-07 13:06:21.000000000","message":"Done","commit_id":"b89944275ed552dc50909cb998987a461325d383"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"9e83381fcbbb72bc68a6937edc2fca0ff14a26ea","unresolved":false,"context_lines":[{"line_number":819,"context_line":"[masakari-monitors:children]"},{"line_number":820,"context_line":"compute"},{"line_number":821,"context_line":""},{"line_number":822,"context_line":"[ovn-controller:children]"},{"line_number":823,"context_line":"ovn-controller-compute"},{"line_number":824,"context_line":"ovn-controller-network"},{"line_number":825,"context_line":""},{"line_number":826,"context_line":"[ovn-controller-compute:children]"},{"line_number":827,"context_line":"compute"},{"line_number":828,"context_line":""},{"line_number":829,"context_line":"[ovn-controller-network:children]"},{"line_number":830,"context_line":"network"},{"line_number":831,"context_line":""},{"line_number":832,"context_line":"[ovn-northd:children]"},{"line_number":833,"context_line":"network"},{"line_number":834,"context_line":""},{"line_number":835,"context_line":"[ovn-nb-db:children]"},{"line_number":836,"context_line":"network"},{"line_number":837,"context_line":""},{"line_number":838,"context_line":"[ovn-sb-db:children]"},{"line_number":839,"context_line":"network"}],"source_content_type":"text/x-jinja2","patch_set":122,"id":"df33271e_cafd73b2","line":839,"range":{"start_line":822,"start_character":0,"end_line":839,"end_character":7},"updated":"2020-04-08 09:49:32.000000000","message":"sync with others","commit_id":"4f55ccc5a8499be973618fb380487f95eee3478a"},{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"181dc6a3a46c7858c7a21afc3a029aabdd1ecff3","unresolved":false,"context_lines":[{"line_number":819,"context_line":"[masakari-monitors:children]"},{"line_number":820,"context_line":"compute"},{"line_number":821,"context_line":""},{"line_number":822,"context_line":"[ovn-controller:children]"},{"line_number":823,"context_line":"ovn-controller-compute"},{"line_number":824,"context_line":"ovn-controller-network"},{"line_number":825,"context_line":""},{"line_number":826,"context_line":"[ovn-controller-compute:children]"},{"line_number":827,"context_line":"compute"},{"line_number":828,"context_line":""},{"line_number":829,"context_line":"[ovn-controller-network:children]"},{"line_number":830,"context_line":"network"},{"line_number":831,"context_line":""},{"line_number":832,"context_line":"[ovn-northd:children]"},{"line_number":833,"context_line":"network"},{"line_number":834,"context_line":""},{"line_number":835,"context_line":"[ovn-nb-db:children]"},{"line_number":836,"context_line":"network"},{"line_number":837,"context_line":""},{"line_number":838,"context_line":"[ovn-sb-db:children]"},{"line_number":839,"context_line":"network"}],"source_content_type":"text/x-jinja2","patch_set":122,"id":"df33271e_3eab8489","line":839,"range":{"start_line":822,"start_character":0,"end_line":839,"end_character":7},"in_reply_to":"df33271e_cafd73b2","updated":"2020-04-08 10:27:16.000000000","message":"Done","commit_id":"4f55ccc5a8499be973618fb380487f95eee3478a"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"a1164921a20ee6eec7cdbfd9aa689e88ca22218c","unresolved":false,"context_lines":[{"line_number":841,"context_line":"[ovn-sb-db:children]"},{"line_number":842,"context_line":"ovn-database"},{"line_number":843,"context_line":""},{"line_number":844,"context_line":"[neutron-ovn-metadata-agent:children]"},{"line_number":845,"context_line":"compute"}],"source_content_type":"text/x-jinja2","patch_set":129,"id":"df33271e_08a11eaa","line":845,"range":{"start_line":844,"start_character":0,"end_line":845,"end_character":7},"updated":"2020-04-08 14:00:25.000000000","message":"move to neutron","commit_id":"f7785df573de72c8fd890d32fe5512e9b6abbe7a"}],"tests/test-ovn.sh":[{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"0c0fab1db5974ebe6fbfde16d97481ba697a41f4","unresolved":false,"context_lines":[{"line_number":8,"context_line":"export PYTHONUNBUFFERED\u003d1"},{"line_number":9,"context_line":""},{"line_number":10,"context_line":"function test_ovn_logged {"},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"    # Source OpenStack credentials"},{"line_number":13,"context_line":"    . /etc/kolla/admin-openrc.sh"},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"    # Activate virtualenv to access OpenStack client"},{"line_number":16,"context_line":"    . ~/openstackclient-venv/bin/activate"},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"    # Test OVSDB cluster state"},{"line_number":19,"context_line":"    sudo docker exec ovn_nb_db ovs-appctl -t /var/run/ovn/ovnnb_db.ctl cluster/status OVN_Northbound"}],"source_content_type":"text/x-sh","patch_set":120,"id":"df33271e_f58d20d4","line":16,"range":{"start_line":11,"start_character":0,"end_line":16,"end_character":41},"updated":"2020-04-03 15:50:38.000000000","message":"nit: not required","commit_id":"b89944275ed552dc50909cb998987a461325d383"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"0c0fab1db5974ebe6fbfde16d97481ba697a41f4","unresolved":false,"context_lines":[{"line_number":17,"context_line":""},{"line_number":18,"context_line":"    # Test OVSDB cluster state"},{"line_number":19,"context_line":"    sudo docker exec ovn_nb_db ovs-appctl -t /var/run/ovn/ovnnb_db.ctl cluster/status OVN_Northbound"},{"line_number":20,"context_line":"    sudo docker exec ovn_sb_db ovs-appctl -t /var/run/ovn/ovnsb_db.ctl cluster/status OVN_Southbound"},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"    # List OVN NB/SB entries"},{"line_number":23,"context_line":"    sudo docker exec ovn_northd ovn-nbctl --db \"tcp:192.0.2.1:6641,tcp:192.0.2.2:6641,tcp:192.0.2.3:6641\" show"}],"source_content_type":"text/x-sh","patch_set":120,"id":"df33271e_504a1a83","line":20,"updated":"2020-04-03 15:50:38.000000000","message":"Is there some output we should be looking for?","commit_id":"b89944275ed552dc50909cb998987a461325d383"},{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"e8eda4c2049e77f3040469a4f506218b5b66d86b","unresolved":false,"context_lines":[{"line_number":17,"context_line":""},{"line_number":18,"context_line":"    # Test OVSDB cluster state"},{"line_number":19,"context_line":"    sudo docker exec ovn_nb_db ovs-appctl -t /var/run/ovn/ovnnb_db.ctl cluster/status OVN_Northbound"},{"line_number":20,"context_line":"    sudo docker exec ovn_sb_db ovs-appctl -t /var/run/ovn/ovnsb_db.ctl cluster/status OVN_Southbound"},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"    # List OVN NB/SB entries"},{"line_number":23,"context_line":"    sudo docker exec ovn_northd ovn-nbctl --db \"tcp:192.0.2.1:6641,tcp:192.0.2.2:6641,tcp:192.0.2.3:6641\" show"}],"source_content_type":"text/x-sh","patch_set":120,"id":"df33271e_c23d7bde","line":20,"in_reply_to":"df33271e_504a1a83","updated":"2020-04-07 13:06:21.000000000","message":"Yes, will add some sanity checks.","commit_id":"b89944275ed552dc50909cb998987a461325d383"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"0c0fab1db5974ebe6fbfde16d97481ba697a41f4","unresolved":false,"context_lines":[{"line_number":22,"context_line":"    # List OVN NB/SB entries"},{"line_number":23,"context_line":"    sudo docker exec ovn_northd ovn-nbctl --db \"tcp:192.0.2.1:6641,tcp:192.0.2.2:6641,tcp:192.0.2.3:6641\" show"},{"line_number":24,"context_line":"    sudo docker exec ovn_northd ovn-sbctl --db \"tcp:192.0.2.1:6642,tcp:192.0.2.2:6642,tcp:192.0.2.3:6642\" show"},{"line_number":25,"context_line":""},{"line_number":26,"context_line":"    # Exit virtualenv"},{"line_number":27,"context_line":"    deactivate"},{"line_number":28,"context_line":"}"},{"line_number":29,"context_line":""},{"line_number":30,"context_line":"function test_ovn {"}],"source_content_type":"text/x-sh","patch_set":120,"id":"df33271e_55bccc6b","line":27,"range":{"start_line":25,"start_character":0,"end_line":27,"end_character":14},"updated":"2020-04-03 15:50:38.000000000","message":"ditto","commit_id":"b89944275ed552dc50909cb998987a461325d383"},{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"296d21b0f5581ed1c05db9669d9be5092779ec75","unresolved":false,"context_lines":[{"line_number":4,"context_line":"set -o errexit"},{"line_number":5,"context_line":"set -o pipefail"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"# Enable unbuffered output for Ansible in Jenkins."},{"line_number":8,"context_line":"export PYTHONUNBUFFERED\u003d1"},{"line_number":9,"context_line":""},{"line_number":10,"context_line":"function test_ovn_logged {"}],"source_content_type":"text/x-sh","patch_set":134,"id":"3f4c43b2_e9ca256c","line":7,"range":{"start_line":7,"start_character":42,"end_line":7,"end_character":49},"updated":"2020-04-15 17:55:06.000000000","message":"I lol every time","commit_id":"8a0740df977916fa5b23117f993cde7282a303bf"}],"tools/setup_gate.sh":[{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"afbf6c432c56351f1d06b67e66db1dc1129020f4","unresolved":false,"context_lines":[{"line_number":61,"context_line":"    fi"},{"line_number":62,"context_line":""},{"line_number":63,"context_line":"    if [[ $SCENARIO \u003d\u003d \"ovn\" ]]; then"},{"line_number":64,"context_line":"        GATE_IMAGES+\u003d\",ovn\""},{"line_number":65,"context_line":"    fi"},{"line_number":66,"context_line":""},{"line_number":67,"context_line":"    if [[ $SCENARIO \u003d\u003d \"mariadb\" ]]; then"}],"source_content_type":"text/x-sh","patch_set":92,"id":"3fa7e38b_f4001202","line":64,"range":{"start_line":64,"start_character":23,"end_line":64,"end_character":26},"updated":"2020-02-19 18:08:18.000000000","message":"^ovn","commit_id":"cc297570e75246673c6576c43b12e44f98f646f9"}],"zuul.d/jobs.yaml":[{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"1ac2ed5601217d9261963ba9f3ac74d9c39f6b05","unresolved":false,"context_lines":[{"line_number":372,"context_line":"    vars:"},{"line_number":373,"context_line":"      base_distro: centos"},{"line_number":374,"context_line":"      install_type: source"},{"line_number":375,"context_line":"      scenario: cells"},{"line_number":376,"context_line":""},{"line_number":377,"context_line":"- job:"},{"line_number":378,"context_line":"    name: kolla-ansible-centos-source-ovn"}],"source_content_type":"text/x-yaml","patch_set":84,"id":"3fa7e38b_c0bdb403","line":375,"updated":"2020-02-10 09:44:48.000000000","message":"no touch!","commit_id":"e0d8113e79e046b13d94487625ba1d55ff8c1f6c"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"afbf6c432c56351f1d06b67e66db1dc1129020f4","unresolved":false,"context_lines":[{"line_number":356,"context_line":"    vars:"},{"line_number":357,"context_line":"      base_distro: centos"},{"line_number":358,"context_line":"      install_type: source"},{"line_number":359,"context_line":""},{"line_number":360,"context_line":"- job:"},{"line_number":361,"context_line":"    name: kolla-ansible-centos-source-ovn"},{"line_number":362,"context_line":"    parent: kolla-ansible-ovn-base"}],"source_content_type":"text/x-yaml","patch_set":92,"id":"3fa7e38b_b40a9a1c","line":359,"updated":"2020-02-19 18:08:18.000000000","message":"CentOS 8 too?","commit_id":"cc297570e75246673c6576c43b12e44f98f646f9"}],"zuul.d/project.yaml":[{"author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"tag":"autogenerated:zuul:check","change_message_id":"71a3c2fe0cc098498bc1b5e35ce30b9aa4f3eb51","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"- project:"},{"line_number":3,"context_line":"    templates:"},{"line_number":4,"context_line":"      #- check-requirements"},{"line_number":5,"context_line":"      #- deploy-guide-jobs"},{"line_number":6,"context_line":"      #- openstack-cover-jobs"},{"line_number":7,"context_line":"      #- openstack-lower-constraints-jobs"},{"line_number":8,"context_line":"      #- openstack-python3-ussuri-jobs"},{"line_number":9,"context_line":"      #- publish-openstack-docs-pti"},{"line_number":10,"context_line":"      #- release-notes-jobs-python3"},{"line_number":11,"context_line":"      #- periodic-stable-jobs"},{"line_number":12,"context_line":"    check:"},{"line_number":13,"context_line":"      jobs:"},{"line_number":14,"context_line":"        #- kolla-ansible-centos-source"},{"line_number":15,"context_line":"        #- kolla-ansible-debian-source"},{"line_number":16,"context_line":"        #- kolla-ansible-ubuntu-source"},{"line_number":17,"context_line":"        #- kolla-ansible-ubuntu-source-multinode-ipv6"},{"line_number":18,"context_line":"        - kolla-ansible-ubuntu-source-ceph"},{"line_number":19,"context_line":"        - kolla-ansible-centos-source-ceph"},{"line_number":20,"context_line":"        #- kolla-ansible-ubuntu-source-cinder-lvm:"},{"line_number":21,"context_line":"        #    files:"},{"line_number":22,"context_line":"        #      - ^ansible/roles/(cinder|iscsi)/"},{"line_number":23,"context_line":"        #      - ^tests/test-core-openstack.sh"},{"line_number":24,"context_line":"        #      - ^tests/test-dashboard.sh"},{"line_number":25,"context_line":"        #- kolla-ansible-centos-source-cinder-lvm:"},{"line_number":26,"context_line":"        #    files:"},{"line_number":27,"context_line":"        #      - ^ansible/roles/(cinder|iscsi)/"},{"line_number":28,"context_line":"        #      - ^tests/test-core-openstack.sh"},{"line_number":29,"context_line":"        #      - ^tests/test-dashboard.sh"},{"line_number":30,"context_line":"        #- kolla-ansible-bifrost-centos-source:"},{"line_number":31,"context_line":"        #    files:"},{"line_number":32,"context_line":"        #      - ^ansible/roles/bifrost/"},{"line_number":33,"context_line":"        #      - ^tests/test-bifrost.sh"},{"line_number":34,"context_line":"        #- kolla-ansible-centos-source-zun"},{"line_number":35,"context_line":"        #- kolla-ansible-ubuntu-source-zun"},{"line_number":36,"context_line":"        #- kolla-ansible-centos-source-scenario-nfv:"},{"line_number":37,"context_line":"        #    files:"},{"line_number":38,"context_line":"        #      - ^ansible/roles/(barbican|heat|mistral|redis|tacker)/"},{"line_number":39,"context_line":"        #      - ^tests/test-scenario-nfv.sh"},{"line_number":40,"context_line":"        #      - ^tests/test-dashboard.sh"},{"line_number":41,"context_line":"        #- kolla-ansible-ubuntu-source-masakari:"},{"line_number":42,"context_line":"        #    files:"},{"line_number":43,"context_line":"        #      - ^ansible/roles/masakari/"},{"line_number":44,"context_line":"        #      - ^tests/test-masakari.sh"},{"line_number":45,"context_line":"        #      - ^tests/test-dashboard.sh"},{"line_number":46,"context_line":"        #- kolla-ansible-centos-source-masakari:"},{"line_number":47,"context_line":"        #    files:"},{"line_number":48,"context_line":"        #      - ^ansible/roles/masakari/"},{"line_number":49,"context_line":"        #      - ^tests/test-masakari.sh"},{"line_number":50,"context_line":"        #      - ^tests/test-dashboard.sh"},{"line_number":51,"context_line":"        #- kolla-ansible-centos-source-ironic"},{"line_number":52,"context_line":"        #- kolla-ansible-centos-binary-ironic"},{"line_number":53,"context_line":"        #- kolla-ansible-ubuntu-source-ironic"},{"line_number":54,"context_line":"        #- kolla-ansible-centos-source-upgrade"},{"line_number":55,"context_line":"        #- kolla-ansible-ubuntu-source-upgrade"},{"line_number":56,"context_line":"        #- kolla-ansible-centos-source-upgrade-ceph"},{"line_number":57,"context_line":"        #- kolla-ansible-ubuntu-source-upgrade-ceph"},{"line_number":58,"context_line":"        #- kolla-ansible-centos-binary"},{"line_number":59,"context_line":"        #- kolla-ansible-ubuntu-binary"},{"line_number":60,"context_line":"        #- kolla-ansible-centos-source-cells"},{"line_number":61,"context_line":"        #- kolla-ansible-centos-source-mariadb:"},{"line_number":62,"context_line":"        #    files:"},{"line_number":63,"context_line":"        #      - ^ansible/roles/mariadb/"},{"line_number":64,"context_line":"        #      - ^tests/test-mariadb.sh"},{"line_number":65,"context_line":"        #- kolla-ansible-ubuntu-source-mariadb:"},{"line_number":66,"context_line":"        #    files:"},{"line_number":67,"context_line":"        #      - ^ansible/roles/mariadb/"},{"line_number":68,"context_line":"        #      - ^tests/test-mariadb.sh"},{"line_number":69,"context_line":"        - kolla-ansible-centos-source-ovn:"},{"line_number":70,"context_line":"            files:"},{"line_number":71,"context_line":"              - ^ansible/roles/(ovn|neutron)/"},{"line_number":72,"context_line":"              - ^tests/test-ovn.sh"},{"line_number":73,"context_line":"    gate:"},{"line_number":74,"context_line":"      queue: kolla"},{"line_number":75,"context_line":"      jobs:"},{"line_number":76,"context_line":"        - kolla-ansible-centos-source"},{"line_number":77,"context_line":"        - kolla-ansible-ubuntu-source"},{"line_number":78,"context_line":"        - kolla-ansible-centos-source-upgrade"},{"line_number":79,"context_line":"        - kolla-ansible-ubuntu-source-upgrade"},{"line_number":80,"context_line":"    periodic:"},{"line_number":81,"context_line":"      jobs:"},{"line_number":82,"context_line":"        - kolla-ansible-bifrost-centos-source"},{"line_number":83,"context_line":"        - kolla-ansible-centos-source-zun"},{"line_number":84,"context_line":"        - kolla-ansible-ubuntu-source-zun"},{"line_number":85,"context_line":"        - kolla-ansible-ubuntu-source-masakari"},{"line_number":86,"context_line":"        - kolla-ansible-centos-source-masakari"},{"line_number":87,"context_line":"        - kolla-ansible-centos-source-scenario-nfv"},{"line_number":88,"context_line":"        - kolla-ansible-ubuntu-source-cinder-lvm"},{"line_number":89,"context_line":"        - kolla-ansible-centos-source-cinder-lvm"},{"line_number":90,"context_line":"        - kolla-ansible-centos-source-ironic"},{"line_number":91,"context_line":"        - kolla-ansible-centos-binary-ironic"},{"line_number":92,"context_line":"        - kolla-ansible-ubuntu-source-ironic"},{"line_number":93,"context_line":"        - kolla-ansible-centos-source-upgrade"},{"line_number":94,"context_line":"        - kolla-ansible-ubuntu-source-upgrade"},{"line_number":95,"context_line":"        - kolla-ansible-centos-source-upgrade-ceph"},{"line_number":96,"context_line":"        - kolla-ansible-ubuntu-source-upgrade-ceph"},{"line_number":97,"context_line":"        - kolla-ansible-centos-source-mariadb"},{"line_number":98,"context_line":"        - kolla-ansible-ubuntu-source-mariadb"}],"source_content_type":"text/x-yaml","patch_set":6,"id":"3fa7e38b_06e816dd","line":98,"range":{"start_line":2,"start_character":2,"end_line":98,"end_character":0},"updated":"2019-12-02 12:31:13.000000000","message":"expected a list for dictionary value @ data[\u0027templates\u0027]","commit_id":"f917f5f4c73ef20a91218ba14d385b16a47ae355"},{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"fe200e577209100b76e38ab7c7ed5a128663a034","unresolved":false,"context_lines":[{"line_number":20,"context_line":"        - kolla-ansible-ubuntu-source-cinder-lvm:"},{"line_number":21,"context_line":"            files:"},{"line_number":22,"context_line":"              - ^ansible/roles/(cinder|iscsi)/"},{"line_number":23,"context_line":"              - ^tests/setup_disks.sh"},{"line_number":24,"context_line":"              - ^tests/test-core-openstack.sh"},{"line_number":25,"context_line":"              - ^tests/test-dashboard.sh"},{"line_number":26,"context_line":"        - kolla-ansible-centos-source-cinder-lvm:"},{"line_number":27,"context_line":"            files:"},{"line_number":28,"context_line":"              - ^ansible/roles/(cinder|iscsi)/"},{"line_number":29,"context_line":"              - ^tests/setup_disks.sh"},{"line_number":30,"context_line":"              - ^tests/test-core-openstack.sh"},{"line_number":31,"context_line":"              - ^tests/test-dashboard.sh"},{"line_number":32,"context_line":"        - kolla-ansible-bifrost-centos-source:"},{"line_number":33,"context_line":"            files:"},{"line_number":34,"context_line":"              - ^ansible/roles/bifrost/"},{"line_number":35,"context_line":"              - ^tests/test-bifrost.sh"},{"line_number":36,"context_line":"        - kolla-ansible-centos-source-zun"},{"line_number":37,"context_line":"        - kolla-ansible-ubuntu-source-zun"},{"line_number":38,"context_line":"        - kolla-ansible-centos-source-swift"},{"line_number":39,"context_line":"        - kolla-ansible-ubuntu-source-swift"},{"line_number":40,"context_line":"        - kolla-ansible-centos-source-scenario-nfv:"},{"line_number":41,"context_line":"            files:"},{"line_number":42,"context_line":"              - ^ansible/roles/(barbican|heat|mistral|redis|tacker)/"}],"source_content_type":"text/x-yaml","patch_set":71,"id":"3fa7e38b_bbbe4d61","side":"PARENT","line":39,"range":{"start_line":23,"start_character":0,"end_line":39,"end_character":43},"updated":"2020-01-10 10:30:22.000000000","message":"why?","commit_id":"cf6e157b79659f6985af8e5210f578667ba46c2f"},{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"ca4cd4772f87b7325ac013e2c76d0fd3dbbdf3b0","unresolved":false,"context_lines":[{"line_number":20,"context_line":"        - kolla-ansible-ubuntu-source-cinder-lvm:"},{"line_number":21,"context_line":"            files:"},{"line_number":22,"context_line":"              - ^ansible/roles/(cinder|iscsi)/"},{"line_number":23,"context_line":"              - ^tests/setup_disks.sh"},{"line_number":24,"context_line":"              - ^tests/test-core-openstack.sh"},{"line_number":25,"context_line":"              - ^tests/test-dashboard.sh"},{"line_number":26,"context_line":"        - kolla-ansible-centos-source-cinder-lvm:"},{"line_number":27,"context_line":"            files:"},{"line_number":28,"context_line":"              - ^ansible/roles/(cinder|iscsi)/"},{"line_number":29,"context_line":"              - ^tests/setup_disks.sh"},{"line_number":30,"context_line":"              - ^tests/test-core-openstack.sh"},{"line_number":31,"context_line":"              - ^tests/test-dashboard.sh"},{"line_number":32,"context_line":"        - kolla-ansible-bifrost-centos-source:"},{"line_number":33,"context_line":"            files:"},{"line_number":34,"context_line":"              - ^ansible/roles/bifrost/"},{"line_number":35,"context_line":"              - ^tests/test-bifrost.sh"},{"line_number":36,"context_line":"        - kolla-ansible-centos-source-zun"},{"line_number":37,"context_line":"        - kolla-ansible-ubuntu-source-zun"},{"line_number":38,"context_line":"        - kolla-ansible-centos-source-swift"},{"line_number":39,"context_line":"        - kolla-ansible-ubuntu-source-swift"},{"line_number":40,"context_line":"        - kolla-ansible-centos-source-scenario-nfv:"},{"line_number":41,"context_line":"            files:"},{"line_number":42,"context_line":"              - ^ansible/roles/(barbican|heat|mistral|redis|tacker)/"}],"source_content_type":"text/x-yaml","patch_set":71,"id":"3fa7e38b_bb1acd78","side":"PARENT","line":39,"range":{"start_line":23,"start_character":0,"end_line":39,"end_character":43},"in_reply_to":"3fa7e38b_bbbe4d61","updated":"2020-01-10 11:37:29.000000000","message":"some weird PEBKAC ;-)","commit_id":"cf6e157b79659f6985af8e5210f578667ba46c2f"},{"author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"tag":"autogenerated:zuul:check-arm64","change_message_id":"6c381a2390ff875dbec60e8ce19e4c4cda09e3b1","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"- project:"},{"line_number":3,"context_line":"    templates:"},{"line_number":4,"context_line":"      - check-requirements"},{"line_number":5,"context_line":"      - deploy-guide-jobs"},{"line_number":6,"context_line":"      - openstack-cover-jobs"},{"line_number":7,"context_line":"      - openstack-lower-constraints-jobs"},{"line_number":8,"context_line":"      - openstack-python3-ussuri-jobs"},{"line_number":9,"context_line":"      - publish-openstack-docs-pti"},{"line_number":10,"context_line":"      - release-notes-jobs-python3"},{"line_number":11,"context_line":"      - periodic-stable-jobs"},{"line_number":12,"context_line":"    check:"},{"line_number":13,"context_line":"      jobs:"},{"line_number":14,"context_line":"        - kolla-ansible-centos-source"},{"line_number":15,"context_line":"        - kolla-ansible-debian-source"},{"line_number":16,"context_line":"        - kolla-ansible-ubuntu-source"},{"line_number":17,"context_line":"        - kolla-ansible-ubuntu-source-multinode-ipv6"},{"line_number":18,"context_line":"        - kolla-ansible-ubuntu-source-ceph"},{"line_number":19,"context_line":"        - kolla-ansible-centos-source-ceph"},{"line_number":20,"context_line":"        - kolla-ansible-ubuntu-source-cinder-lvm"},{"line_number":21,"context_line":"        - kolla-ansible-centos-source-cinder-lvm"},{"line_number":22,"context_line":"        - kolla-ansible-bifrost-centos-source"},{"line_number":23,"context_line":"        - kolla-ansible-centos-source-zun"},{"line_number":24,"context_line":"        - kolla-ansible-ubuntu-source-zun"},{"line_number":25,"context_line":"        - kolla-ansible-centos-source-swift"},{"line_number":26,"context_line":"        - kolla-ansible-ubuntu-source-swift"},{"line_number":27,"context_line":"        - kolla-ansible-centos-source-scenario-nfv"},{"line_number":28,"context_line":"        - kolla-ansible-ubuntu-source-masakari"},{"line_number":29,"context_line":"        - kolla-ansible-centos-source-masakari"},{"line_number":30,"context_line":"        - kolla-ansible-centos-source-ironic"},{"line_number":31,"context_line":"        - kolla-ansible-centos-binary-ironic"},{"line_number":32,"context_line":"        - kolla-ansible-ubuntu-source-ironic"},{"line_number":33,"context_line":"        - kolla-ansible-centos-source-upgrade"},{"line_number":34,"context_line":"        - kolla-ansible-ubuntu-source-upgrade"},{"line_number":35,"context_line":"        - kolla-ansible-centos-source-upgrade-ceph"},{"line_number":36,"context_line":"        - kolla-ansible-ubuntu-source-upgrade-ceph"},{"line_number":37,"context_line":"        - kolla-ansible-centos-binary"},{"line_number":38,"context_line":"        - kolla-ansible-ubuntu-binary"},{"line_number":39,"context_line":"        - kolla-ansible-centos-source-cells"},{"line_number":40,"context_line":"        - kolla-ansible-centos-source-mariadb"},{"line_number":41,"context_line":"        - kolla-ansible-ubuntu-source-mariadb"},{"line_number":42,"context_line":"        - kolla-ansible-centos-source-ceph-ansible"},{"line_number":43,"context_line":"        - kolla-ansible-ubuntu-source-ceph-ansible"},{"line_number":44,"context_line":"        - kolla-ansible-centos-source-mariadb:"},{"line_number":45,"context_line":"        - kolla-ansible-ubuntu-source-mariadb:"},{"line_number":46,"context_line":"        - kolla-ansible-centos-source-ovn:"},{"line_number":47,"context_line":"            files:"},{"line_number":48,"context_line":"              - ^ansible/roles/(ovn|neutron)/"},{"line_number":49,"context_line":"              - ^tests/test-ovn.sh"},{"line_number":50,"context_line":"        - kolla-ansible-ubuntu-source-ovn:"},{"line_number":51,"context_line":"            files:"},{"line_number":52,"context_line":"              - ^ansible/roles/(ovn|neutron)/"},{"line_number":53,"context_line":"              - ^tests/test-ovn.sh"},{"line_number":54,"context_line":"    check-arm64:"},{"line_number":55,"context_line":"      jobs:"},{"line_number":56,"context_line":"        - kolla-ansible-debian-source-aarch64"},{"line_number":57,"context_line":"    gate:"},{"line_number":58,"context_line":"      queue: kolla"},{"line_number":59,"context_line":"      jobs:"},{"line_number":60,"context_line":"        - kolla-ansible-centos-source"},{"line_number":61,"context_line":"        - kolla-ansible-ubuntu-source"},{"line_number":62,"context_line":"        - kolla-ansible-centos-source-upgrade"},{"line_number":63,"context_line":"        - kolla-ansible-ubuntu-source-upgrade"},{"line_number":64,"context_line":"    periodic:"},{"line_number":65,"context_line":"      jobs:"},{"line_number":66,"context_line":"        - kolla-ansible-bifrost-centos-source"},{"line_number":67,"context_line":"        - kolla-ansible-centos-source-zun"},{"line_number":68,"context_line":"        - kolla-ansible-ubuntu-source-zun"},{"line_number":69,"context_line":"        - kolla-ansible-ubuntu-source-masakari"},{"line_number":70,"context_line":"        - kolla-ansible-centos-source-masakari"},{"line_number":71,"context_line":"        - kolla-ansible-centos-source-scenario-nfv"},{"line_number":72,"context_line":"        - kolla-ansible-ubuntu-source-cinder-lvm"},{"line_number":73,"context_line":"        - kolla-ansible-centos-source-cinder-lvm"},{"line_number":74,"context_line":"        - kolla-ansible-centos-source-ironic"},{"line_number":75,"context_line":"        - kolla-ansible-centos-binary-ironic"},{"line_number":76,"context_line":"        - kolla-ansible-ubuntu-source-ironic"},{"line_number":77,"context_line":"        - kolla-ansible-centos-source-upgrade"},{"line_number":78,"context_line":"        - kolla-ansible-ubuntu-source-upgrade"},{"line_number":79,"context_line":"        - kolla-ansible-centos-source-upgrade-ceph"},{"line_number":80,"context_line":"        - kolla-ansible-ubuntu-source-upgrade-ceph"},{"line_number":81,"context_line":"        - kolla-ansible-centos-source-mariadb"},{"line_number":82,"context_line":"        - kolla-ansible-ubuntu-source-mariadb"}],"source_content_type":"text/x-yaml","patch_set":75,"id":"3fa7e38b_756a3d18","line":82,"range":{"start_line":2,"start_character":2,"end_line":82,"end_character":0},"updated":"2020-01-27 20:54:53.000000000","message":"expected str for dictionary value @ data[\u0027check\u0027][\u0027jobs\u0027][30][\u0027kolla-ansible-centos-source-mariadb\u0027]","commit_id":"607a3b3feaf105feabae0904842b2fef171ca898"},{"author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"tag":"autogenerated:zuul:check","change_message_id":"651bc71dda1cc46ee38faac1cbbe553818151056","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"- project:"},{"line_number":3,"context_line":"    templates:"},{"line_number":4,"context_line":"      - check-requirements"},{"line_number":5,"context_line":"      - deploy-guide-jobs"},{"line_number":6,"context_line":"      - openstack-cover-jobs"},{"line_number":7,"context_line":"      - openstack-lower-constraints-jobs"},{"line_number":8,"context_line":"      - openstack-python3-ussuri-jobs"},{"line_number":9,"context_line":"      - publish-openstack-docs-pti"},{"line_number":10,"context_line":"      - release-notes-jobs-python3"},{"line_number":11,"context_line":"      - periodic-stable-jobs"},{"line_number":12,"context_line":"    check:"},{"line_number":13,"context_line":"      jobs:"},{"line_number":14,"context_line":"        - kolla-ansible-centos-source"},{"line_number":15,"context_line":"        - kolla-ansible-debian-source"},{"line_number":16,"context_line":"        - kolla-ansible-ubuntu-source"},{"line_number":17,"context_line":"        - kolla-ansible-ubuntu-source-multinode-ipv6"},{"line_number":18,"context_line":"        - kolla-ansible-ubuntu-source-ceph"},{"line_number":19,"context_line":"        - kolla-ansible-centos-source-ceph"},{"line_number":20,"context_line":"        - kolla-ansible-ubuntu-source-cinder-lvm"},{"line_number":21,"context_line":"        - kolla-ansible-centos-source-cinder-lvm"},{"line_number":22,"context_line":"        - kolla-ansible-bifrost-centos-source"},{"line_number":23,"context_line":"        - kolla-ansible-centos-source-zun"},{"line_number":24,"context_line":"        - kolla-ansible-ubuntu-source-zun"},{"line_number":25,"context_line":"        - kolla-ansible-centos-source-swift"},{"line_number":26,"context_line":"        - kolla-ansible-ubuntu-source-swift"},{"line_number":27,"context_line":"        - kolla-ansible-centos-source-scenario-nfv"},{"line_number":28,"context_line":"        - kolla-ansible-ubuntu-source-masakari"},{"line_number":29,"context_line":"        - kolla-ansible-centos-source-masakari"},{"line_number":30,"context_line":"        - kolla-ansible-centos-source-ironic"},{"line_number":31,"context_line":"        - kolla-ansible-centos-binary-ironic"},{"line_number":32,"context_line":"        - kolla-ansible-ubuntu-source-ironic"},{"line_number":33,"context_line":"        - kolla-ansible-centos-source-upgrade"},{"line_number":34,"context_line":"        - kolla-ansible-ubuntu-source-upgrade"},{"line_number":35,"context_line":"        - kolla-ansible-centos-source-upgrade-ceph"},{"line_number":36,"context_line":"        - kolla-ansible-ubuntu-source-upgrade-ceph"},{"line_number":37,"context_line":"        - kolla-ansible-centos-binary"},{"line_number":38,"context_line":"        - kolla-ansible-ubuntu-binary"},{"line_number":39,"context_line":"        - kolla-ansible-centos-source-cells"},{"line_number":40,"context_line":"        - kolla-ansible-centos-source-mariadb"},{"line_number":41,"context_line":"        - kolla-ansible-ubuntu-source-mariadb"},{"line_number":42,"context_line":"        - kolla-ansible-centos-source-ceph-ansible"},{"line_number":43,"context_line":"        - kolla-ansible-ubuntu-source-ceph-ansible"},{"line_number":44,"context_line":"        - kolla-ansible-centos-source-mariadb:"},{"line_number":45,"context_line":"        - kolla-ansible-ubuntu-source-mariadb:"},{"line_number":46,"context_line":"        - kolla-ansible-centos-source-ovn:"},{"line_number":47,"context_line":"            files:"},{"line_number":48,"context_line":"              - ^ansible/roles/(ovn|neutron)/"},{"line_number":49,"context_line":"              - ^tests/test-ovn.sh"},{"line_number":50,"context_line":"        - kolla-ansible-ubuntu-source-ovn:"},{"line_number":51,"context_line":"            files:"},{"line_number":52,"context_line":"              - ^ansible/roles/(ovn|neutron)/"},{"line_number":53,"context_line":"              - ^tests/test-ovn.sh"},{"line_number":54,"context_line":"    check-arm64:"},{"line_number":55,"context_line":"      jobs:"},{"line_number":56,"context_line":"        - kolla-ansible-debian-source-aarch64"},{"line_number":57,"context_line":"    gate:"},{"line_number":58,"context_line":"      queue: kolla"},{"line_number":59,"context_line":"      jobs:"},{"line_number":60,"context_line":"        - kolla-ansible-centos-source"},{"line_number":61,"context_line":"        - kolla-ansible-ubuntu-source"},{"line_number":62,"context_line":"        - kolla-ansible-centos-source-upgrade"},{"line_number":63,"context_line":"        - kolla-ansible-ubuntu-source-upgrade"},{"line_number":64,"context_line":"    periodic:"},{"line_number":65,"context_line":"      jobs:"},{"line_number":66,"context_line":"        - kolla-ansible-bifrost-centos-source"},{"line_number":67,"context_line":"        - kolla-ansible-centos-source-zun"},{"line_number":68,"context_line":"        - kolla-ansible-ubuntu-source-zun"},{"line_number":69,"context_line":"        - kolla-ansible-ubuntu-source-masakari"},{"line_number":70,"context_line":"        - kolla-ansible-centos-source-masakari"},{"line_number":71,"context_line":"        - kolla-ansible-centos-source-scenario-nfv"},{"line_number":72,"context_line":"        - kolla-ansible-ubuntu-source-cinder-lvm"},{"line_number":73,"context_line":"        - kolla-ansible-centos-source-cinder-lvm"},{"line_number":74,"context_line":"        - kolla-ansible-centos-source-ironic"},{"line_number":75,"context_line":"        - kolla-ansible-centos-binary-ironic"},{"line_number":76,"context_line":"        - kolla-ansible-ubuntu-source-ironic"},{"line_number":77,"context_line":"        - kolla-ansible-centos-source-upgrade"},{"line_number":78,"context_line":"        - kolla-ansible-ubuntu-source-upgrade"},{"line_number":79,"context_line":"        - kolla-ansible-centos-source-upgrade-ceph"},{"line_number":80,"context_line":"        - kolla-ansible-ubuntu-source-upgrade-ceph"},{"line_number":81,"context_line":"        - kolla-ansible-centos-source-mariadb"},{"line_number":82,"context_line":"        - kolla-ansible-ubuntu-source-mariadb"}],"source_content_type":"text/x-yaml","patch_set":75,"id":"3fa7e38b_9569f926","line":82,"range":{"start_line":2,"start_character":2,"end_line":82,"end_character":0},"updated":"2020-01-27 20:54:48.000000000","message":"expected str for dictionary value @ data[\u0027check\u0027][\u0027jobs\u0027][30][\u0027kolla-ansible-centos-source-mariadb\u0027]","commit_id":"607a3b3feaf105feabae0904842b2fef171ca898"},{"author":{"_account_id":19316,"name":"Eduardo Gonzalez","email":"dabarren@gmail.com","username":"egonzalez90"},"change_message_id":"fc57a572d12a20d9d99bb1a07ae0d1e987d6d90e","unresolved":false,"context_lines":[{"line_number":41,"context_line":"        - kolla-ansible-ubuntu-source-mariadb"},{"line_number":42,"context_line":"        - kolla-ansible-centos-source-ceph-ansible"},{"line_number":43,"context_line":"        - kolla-ansible-ubuntu-source-ceph-ansible"},{"line_number":44,"context_line":"        - kolla-ansible-centos-source-mariadb"},{"line_number":45,"context_line":"        - kolla-ansible-ubuntu-source-mariadb"},{"line_number":46,"context_line":"        - kolla-ansible-centos-source-ovn"},{"line_number":47,"context_line":"        - kolla-ansible-ubuntu-source-ovn"},{"line_number":48,"context_line":"    check-arm64:"}],"source_content_type":"text/x-yaml","patch_set":79,"id":"3fa7e38b_7998cbca","line":45,"range":{"start_line":44,"start_character":0,"end_line":45,"end_character":45},"updated":"2020-01-30 11:25:21.000000000","message":"this jobs are not related to this change","commit_id":"44162969b78601ddcbb0db56e89df5ac77d0a5b4"},{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"4f56439145e3a03445d8ff21140d5af0d6652fd6","unresolved":false,"context_lines":[{"line_number":41,"context_line":"        - kolla-ansible-ubuntu-source-mariadb"},{"line_number":42,"context_line":"        - kolla-ansible-centos-source-ceph-ansible"},{"line_number":43,"context_line":"        - kolla-ansible-ubuntu-source-ceph-ansible"},{"line_number":44,"context_line":"        - kolla-ansible-centos-source-mariadb"},{"line_number":45,"context_line":"        - kolla-ansible-ubuntu-source-mariadb"},{"line_number":46,"context_line":"        - kolla-ansible-centos-source-ovn"},{"line_number":47,"context_line":"        - kolla-ansible-ubuntu-source-ovn"},{"line_number":48,"context_line":"    check-arm64:"}],"source_content_type":"text/x-yaml","patch_set":79,"id":"3fa7e38b_d9bd3f05","line":45,"range":{"start_line":44,"start_character":0,"end_line":45,"end_character":45},"in_reply_to":"3fa7e38b_7998cbca","updated":"2020-01-30 11:27:12.000000000","message":"Right, probably overlooked that when solving conflicts. Thanks Eduardo!","commit_id":"44162969b78601ddcbb0db56e89df5ac77d0a5b4"}]}