)]}'
{"ansible/roles/keystone/tasks/precheck.yml":[{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"e4e273c48cc7512079cdbee67410dbebcea19934","unresolved":false,"context_lines":[{"line_number":43,"context_line":"    - keystone_ssh.enabled | bool"},{"line_number":44,"context_line":"    - inventory_hostname in groups[\u0027keystone\u0027]"},{"line_number":45,"context_line":""},{"line_number":46,"context_line":"- name: Checking fernet_token_expiry in globals.yml. Update fernet_token_expiry to allowed value if this task fails"},{"line_number":47,"context_line":"  run_once: true"},{"line_number":48,"context_line":"  command:"},{"line_number":49,"context_line":"    cmd: awk \u0027/^fernet_token_expiry/ { print $2 }\u0027 \"{{ node_config }}/globals.yml\""}],"source_content_type":"text/x-yaml","patch_set":4,"id":"3fa7e38b_9759045c","side":"PARENT","line":46,"updated":"2019-12-11 13:39:39.000000000","message":"I wasn\u0027t aware of this task. It\u0027s quite gross. Surely we can just reference the fernet_token_expiry variable itself?\n\nI\u0027m not even sure if there is a limitation on the allowed values now. We\u0027d need to test in tests/test_fernet_rotate_cron_generator.py if not.","commit_id":"97bbad7c19fed7296bcc022d702c9b0916f53efb"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"cd1deaf399ef62b5c0b350200804324e58e61ef7","unresolved":false,"context_lines":[{"line_number":52,"context_line":"- name: Checking fernet_token_expiry in globals.yml. Update fernet_token_expiry to allowed value if this task fails"},{"line_number":53,"context_line":"  run_once: true"},{"line_number":54,"context_line":"  command:"},{"line_number":55,"context_line":"    cmd: awk \u0027/^fernet_token_expiry/ { print $2 }\u0027 \"{{ node_config }}/globals.yml\""},{"line_number":56,"context_line":"  delegate_to: localhost"},{"line_number":57,"context_line":"  register: result"},{"line_number":58,"context_line":"  changed_when: false"}],"source_content_type":"text/x-yaml","patch_set":8,"id":"ff570b3c_d1aa9883","side":"PARENT","line":55,"range":{"start_line":55,"start_character":4,"end_line":55,"end_character":82},"updated":"2020-05-11 10:45:52.000000000","message":"Interesting way to read a variable","commit_id":"a87780cb96159bded0a176ec62e4c41c25fdcd42"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"cd1deaf399ef62b5c0b350200804324e58e61ef7","unresolved":false,"context_lines":[{"line_number":63,"context_line":"    # The suggested values can be equispaced as they can divide 7 days without"},{"line_number":64,"context_line":"    # remainder."},{"line_number":65,"context_line":"    msg: \u003e-"},{"line_number":66,"context_line":"      fernet_token_expiry must be an integer. You can set this in `globals.yml`."},{"line_number":67,"context_line":"      Suggested values are: 60, 120, 180, 240, 360, 720, 1008, 2016, 2520, 3360"},{"line_number":68,"context_line":"      5040, 10800"},{"line_number":69,"context_line":"  when:"}],"source_content_type":"text/x-yaml","patch_set":8,"id":"ff570b3c_f19ebc52","line":66,"range":{"start_line":66,"start_character":37,"end_line":66,"end_character":44},"updated":"2020-05-11 10:45:52.000000000","message":"up to 10800","commit_id":"9f7ba193e734ac04036bb523262ca27498cec5eb"},{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"8d2561cdf4dbe2c99421705e9daa97e4af25b190","unresolved":false,"context_lines":[{"line_number":65,"context_line":"      set this in `globals.yml`. The value represents the time period, in"},{"line_number":66,"context_line":"      seconds, at which to rotate the fernet keys. Suggested values are: 60,"},{"line_number":67,"context_line":"      120, 240, 480, 720, 1440, 3600, 7200, 10800, 14400, 21600, 43200, 60480,"},{"line_number":68,"context_line":"      120960, 151200, 201600, 302400, 604800. These values can be equispaced as"},{"line_number":69,"context_line":"      they divide 7 days without remainder."},{"line_number":70,"context_line":"  when:"},{"line_number":71,"context_line":"    - keystone_token_provider \u003d\u003d \u0027fernet\u0027"}],"source_content_type":"text/x-yaml","patch_set":10,"id":"ff570b3c_cf74ac9c","line":69,"range":{"start_line":68,"start_character":46,"end_line":69,"end_character":43},"updated":"2020-05-11 13:58:12.000000000","message":"confusing note","commit_id":"7fa997077e7289d1fa6e8d88d29fedd7d364e6d7"},{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"0c118c5443dddb81027c6b5a2ed63a39aa59c4b4","unresolved":false,"context_lines":[{"line_number":65,"context_line":"      set this in `globals.yml`. The value represents the time period, in"},{"line_number":66,"context_line":"      seconds, at which to rotate the fernet keys. Suggested values are: 60,"},{"line_number":67,"context_line":"      120, 240, 480, 720, 1440, 3600, 7200, 10800, 14400, 21600, 43200, 60480,"},{"line_number":68,"context_line":"      120960, 151200, 201600, 302400, 604800. These values can be equispaced as"},{"line_number":69,"context_line":"      they divide 7 days without remainder."},{"line_number":70,"context_line":"  when:"},{"line_number":71,"context_line":"    - keystone_token_provider \u003d\u003d \u0027fernet\u0027"}],"source_content_type":"text/x-yaml","patch_set":10,"id":"ff570b3c_a16a0b7d","line":69,"range":{"start_line":68,"start_character":46,"end_line":69,"end_character":43},"in_reply_to":"ff570b3c_0c833cce","updated":"2020-05-12 17:22:51.000000000","message":"Oh, then you wanted to say \"These values ensure evenly-spaced run schedule as they ...\"\nAnd yeah, I switched \"equispaced\" to \"evenly-spaced\" to sound more common. :-)","commit_id":"7fa997077e7289d1fa6e8d88d29fedd7d364e6d7"},{"author":{"_account_id":28048,"name":"Will Szumski","email":"will@stackhpc.com","username":"jovial"},"change_message_id":"4d71310b8ac361e6b60eee61665b1670d302a4db","unresolved":false,"context_lines":[{"line_number":65,"context_line":"      set this in `globals.yml`. The value represents the time period, in"},{"line_number":66,"context_line":"      seconds, at which to rotate the fernet keys. Suggested values are: 60,"},{"line_number":67,"context_line":"      120, 240, 480, 720, 1440, 3600, 7200, 10800, 14400, 21600, 43200, 60480,"},{"line_number":68,"context_line":"      120960, 151200, 201600, 302400, 604800. These values can be equispaced as"},{"line_number":69,"context_line":"      they divide 7 days without remainder."},{"line_number":70,"context_line":"  when:"},{"line_number":71,"context_line":"    - keystone_token_provider \u003d\u003d \u0027fernet\u0027"}],"source_content_type":"text/x-yaml","patch_set":10,"id":"ff570b3c_0c833cce","line":69,"range":{"start_line":68,"start_character":46,"end_line":69,"end_character":43},"in_reply_to":"ff570b3c_cf74ac9c","updated":"2020-05-12 10:11:19.000000000","message":"Was just trying to stop people choosing values that lead to under-rotation. For example using a period of 2 days generates the cycle:\n\n  sunday -\u003e tuesday -\u003e thursday -\u003e sunday\n\nNOTE: the three days from thursday back to sunday.\n\nIs there a better wording to describe this? Or should I remove the comment?","commit_id":"7fa997077e7289d1fa6e8d88d29fedd7d364e6d7"}]}