)]}'
{"ansible/group_vars/all.yml":[{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"e5128173b179a2748b773200409bef63ae567ee1","unresolved":false,"context_lines":[{"line_number":132,"context_line":"  client_timeout: \"{{ docker_client_timeout }}\""},{"line_number":133,"context_line":""},{"line_number":134,"context_line":"# Image pruning is disabled by default as its an advanced operation."},{"line_number":135,"context_line":"docker_image_prune_enabled: false"},{"line_number":136,"context_line":"docker_image_prune_filters:"},{"line_number":137,"context_line":"  - kolla_version"},{"line_number":138,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":13,"id":"3fa7e38b_c7f04769","line":135,"range":{"start_line":135,"start_character":0,"end_line":135,"end_character":33},"updated":"2020-01-24 09:41:52.000000000","message":"This is a bit odd - in the default configuration you run kolla-ansible prune-images and it says \u0027no!\u0027. Given that it\u0027s the only thing that the command does, can\u0027t we trust the user to know they are doing the right thing?","commit_id":"006ce98b980c67027a7c560094cc7c6542ec12b9"},{"author":{"_account_id":30523,"name":"Dincer Celik","email":"hello@dincercelik.com","username":"osmanlicilegi"},"change_message_id":"1dd672340b76e5a5d75c88b09b64f3f34732fda7","unresolved":false,"context_lines":[{"line_number":132,"context_line":"  client_timeout: \"{{ docker_client_timeout }}\""},{"line_number":133,"context_line":""},{"line_number":134,"context_line":"# Image pruning is disabled by default as its an advanced operation."},{"line_number":135,"context_line":"docker_image_prune_enabled: false"},{"line_number":136,"context_line":"docker_image_prune_filters:"},{"line_number":137,"context_line":"  - kolla_version"},{"line_number":138,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":13,"id":"3fa7e38b_850a4775","line":135,"range":{"start_line":135,"start_character":0,"end_line":135,"end_character":33},"in_reply_to":"3fa7e38b_c7f04769","updated":"2020-01-24 11:28:40.000000000","message":"Seems this is totally my misunderstanding :) Let me refactor it.","commit_id":"006ce98b980c67027a7c560094cc7c6542ec12b9"}],"ansible/prune-images.yml":[{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"47173c0a9137e4f0596f12e03c5b756238bacc4a","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"- name: Apply role prune-images"},{"line_number":3,"context_line":"  hosts: all"},{"line_number":4,"context_line":"  roles:"},{"line_number":5,"context_line":"    - prune-images"}],"source_content_type":"text/x-yaml","patch_set":12,"id":"3fa7e38b_d35e69e7","line":3,"range":{"start_line":3,"start_character":9,"end_line":3,"end_character":12},"updated":"2020-01-14 10:25:00.000000000","message":"I\u0027m a bit concerned about running this against all hosts. We usually specify a group here to allow the scope to be controlled.\n\nWe have the \u0027baremetal\u0027 group which includes all hosts, but if users aren\u0027t using kolla-ansible bootstrap-servers then they might not be using the baremetal group.","commit_id":"58a9a3654577455fd1f3539731ce57667c0a54c3"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"47173c0a9137e4f0596f12e03c5b756238bacc4a","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"- name: Apply role prune-images"},{"line_number":3,"context_line":"  hosts: all"},{"line_number":4,"context_line":"  roles:"},{"line_number":5,"context_line":"    - prune-images"}],"source_content_type":"text/x-yaml","patch_set":12,"id":"3fa7e38b_53bcb906","line":3,"updated":"2020-01-14 10:25:00.000000000","message":"Should we support kolla_serial?","commit_id":"58a9a3654577455fd1f3539731ce57667c0a54c3"},{"author":{"_account_id":30523,"name":"Dincer Celik","email":"hello@dincercelik.com","username":"osmanlicilegi"},"change_message_id":"c08d3d65620089771c8642b3d8b24615572275b9","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"- name: Apply role prune-images"},{"line_number":3,"context_line":"  hosts: all"},{"line_number":4,"context_line":"  roles:"},{"line_number":5,"context_line":"    - prune-images"}],"source_content_type":"text/x-yaml","patch_set":12,"id":"3fa7e38b_a4a18cf8","line":3,"in_reply_to":"3fa7e38b_53bcb906","updated":"2020-01-23 22:59:15.000000000","message":"Done","commit_id":"58a9a3654577455fd1f3539731ce57667c0a54c3"},{"author":{"_account_id":30523,"name":"Dincer Celik","email":"hello@dincercelik.com","username":"osmanlicilegi"},"change_message_id":"c08d3d65620089771c8642b3d8b24615572275b9","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"- name: Apply role prune-images"},{"line_number":3,"context_line":"  hosts: all"},{"line_number":4,"context_line":"  roles:"},{"line_number":5,"context_line":"    - prune-images"}],"source_content_type":"text/x-yaml","patch_set":12,"id":"3fa7e38b_24fcbc0b","line":3,"range":{"start_line":3,"start_character":9,"end_line":3,"end_character":12},"in_reply_to":"3fa7e38b_d35e69e7","updated":"2020-01-23 22:59:15.000000000","message":"In my opinion, this shouldn\u0027t be a problem. We will run it on all hosts by default but the users will be able to use limit. Also, we will disable this feature by default.","commit_id":"58a9a3654577455fd1f3539731ce57667c0a54c3"},{"author":{"_account_id":30523,"name":"Dincer Celik","email":"hello@dincercelik.com","username":"osmanlicilegi"},"change_message_id":"c2e21b92d01a6074c812cccb47dea70015e08fc0","unresolved":false,"context_lines":[{"line_number":2,"context_line":"- import_playbook: gather-facts.yml"},{"line_number":3,"context_line":""},{"line_number":4,"context_line":"- name: Apply role prune-images"},{"line_number":5,"context_line":"  hosts: all"},{"line_number":6,"context_line":"  serial: \u0027{{ kolla_serial|default(\"0\") }}\u0027"},{"line_number":7,"context_line":"  gather_facts: false"},{"line_number":8,"context_line":"  roles:"}],"source_content_type":"text/x-yaml","patch_set":15,"id":"3fa7e38b_b100da36","line":5,"range":{"start_line":5,"start_character":9,"end_line":5,"end_character":12},"updated":"2020-01-25 17:42:32.000000000","message":"Users still will be able to use --limit","commit_id":"41afd14d8f31269393d629cbbdf0f837e3ec6a62"},{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"b9f18801896e6065b6b3a1bf622db5976624ca58","unresolved":false,"context_lines":[{"line_number":2,"context_line":"- import_playbook: gather-facts.yml"},{"line_number":3,"context_line":""},{"line_number":4,"context_line":"- name: Apply role prune-images"},{"line_number":5,"context_line":"  hosts: all"},{"line_number":6,"context_line":"  serial: \u0027{{ kolla_serial|default(\"0\") }}\u0027"},{"line_number":7,"context_line":"  gather_facts: false"},{"line_number":8,"context_line":"  roles:"}],"source_content_type":"text/x-yaml","patch_set":15,"id":"3fa7e38b_5760730d","line":5,"range":{"start_line":5,"start_character":9,"end_line":5,"end_character":12},"in_reply_to":"3fa7e38b_b100da36","updated":"2020-01-27 07:38:55.000000000","message":"Hmm, not baremetal?\nAll includes deployment host, this might not be that obvious but it usually has no users of images so all get pruned.","commit_id":"41afd14d8f31269393d629cbbdf0f837e3ec6a62"}],"ansible/roles/prune-images/defaults/main.yml":[{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"47173c0a9137e4f0596f12e03c5b756238bacc4a","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"docker_image_prune_timeout: 300"}],"source_content_type":"text/x-yaml","patch_set":12,"id":"3fa7e38b_b3272d67","line":2,"range":{"start_line":2,"start_character":0,"end_line":2,"end_character":26},"updated":"2020-01-14 10:25:00.000000000","message":"We have docker_client_timeout. Does this need to be 300 or is the default of docker_client_timeout (120) ok?","commit_id":"58a9a3654577455fd1f3539731ce57667c0a54c3"},{"author":{"_account_id":30523,"name":"Dincer Celik","email":"hello@dincercelik.com","username":"osmanlicilegi"},"change_message_id":"c08d3d65620089771c8642b3d8b24615572275b9","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"docker_image_prune_timeout: 300"}],"source_content_type":"text/x-yaml","patch_set":12,"id":"3fa7e38b_a4a74cbb","line":2,"range":{"start_line":2,"start_character":0,"end_line":2,"end_character":26},"in_reply_to":"3fa7e38b_b3272d67","updated":"2020-01-23 22:59:15.000000000","message":"We shouldn\u0027t use docker_client_timeout here. The remote hosts may have gigabytes of orphaned image data and it will take longer to prune them. I have tested the pruning with an image data between 10G and 20G and 300 seconds seems fine.","commit_id":"58a9a3654577455fd1f3539731ce57667c0a54c3"},{"author":{"_account_id":30523,"name":"Dincer Celik","email":"hello@dincercelik.com","username":"osmanlicilegi"},"change_message_id":"c2e21b92d01a6074c812cccb47dea70015e08fc0","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"docker_image_prune_timeout: 300"}],"source_content_type":"text/x-yaml","patch_set":15,"id":"3fa7e38b_d1fb1645","line":2,"range":{"start_line":2,"start_character":28,"end_line":2,"end_character":31},"updated":"2020-01-25 17:42:32.000000000","message":"This shouldn\u0027t be same with docker_client_timeout as pruning images would take more time.","commit_id":"41afd14d8f31269393d629cbbdf0f837e3ec6a62"}],"ansible/roles/prune-images/tasks/prune_images.yml":[{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"47173c0a9137e4f0596f12e03c5b756238bacc4a","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"- name: Pruning Kolla images"},{"line_number":3,"context_line":"  docker_prune:"},{"line_number":4,"context_line":"    images: yes"},{"line_number":5,"context_line":"    images_filters:"}],"source_content_type":"text/x-yaml","patch_set":12,"id":"3fa7e38b_7353f5df","line":2,"updated":"2020-01-14 10:25:00.000000000","message":"become: true","commit_id":"58a9a3654577455fd1f3539731ce57667c0a54c3"},{"author":{"_account_id":30523,"name":"Dincer Celik","email":"hello@dincercelik.com","username":"osmanlicilegi"},"change_message_id":"c08d3d65620089771c8642b3d8b24615572275b9","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"- name: Pruning Kolla images"},{"line_number":3,"context_line":"  docker_prune:"},{"line_number":4,"context_line":"    images: yes"},{"line_number":5,"context_line":"    images_filters:"}],"source_content_type":"text/x-yaml","patch_set":12,"id":"3fa7e38b_847b3029","line":2,"in_reply_to":"3fa7e38b_7353f5df","updated":"2020-01-23 22:59:15.000000000","message":"Done","commit_id":"58a9a3654577455fd1f3539731ce57667c0a54c3"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"47173c0a9137e4f0596f12e03c5b756238bacc4a","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"- name: Pruning Kolla images"},{"line_number":3,"context_line":"  docker_prune:"},{"line_number":4,"context_line":"    images: yes"},{"line_number":5,"context_line":"    images_filters:"},{"line_number":6,"context_line":"      label: kolla_version"},{"line_number":7,"context_line":"    timeout: \u0027{{ docker_image_prune_timeout }}\u0027"}],"source_content_type":"text/x-yaml","patch_set":12,"id":"3fa7e38b_f314c5ec","line":6,"range":{"start_line":4,"start_character":0,"end_line":6,"end_character":26},"updated":"2020-01-14 10:25:00.000000000","message":"It might be nice to make these configurable by adding variables in defaults (docker_image_prune_enabled, docker_image_prune_filters).","commit_id":"58a9a3654577455fd1f3539731ce57667c0a54c3"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"e5128173b179a2748b773200409bef63ae567ee1","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"- name: Pruning Kolla images"},{"line_number":3,"context_line":"  docker_prune:"},{"line_number":4,"context_line":"    images: yes"},{"line_number":5,"context_line":"    images_filters:"},{"line_number":6,"context_line":"      label: kolla_version"},{"line_number":7,"context_line":"    timeout: \u0027{{ docker_image_prune_timeout }}\u0027"}],"source_content_type":"text/x-yaml","patch_set":12,"id":"3fa7e38b_2ac1e281","line":6,"range":{"start_line":4,"start_character":0,"end_line":6,"end_character":26},"in_reply_to":"3fa7e38b_84901043","updated":"2020-01-24 09:41:52.000000000","message":"I was thinking it would look a bit more like this:\n\n  docker_prune:\n    images: \"{{ docker_image_prune_enabled | bool }}\"\n    images_filters: \"{{ docker_image_prune_filters }}\"\n    timeout: \"{{ docker_image_prune_timeout }}\"\n\nAlthough docker_image_prune_enabled is maybe not so useful if we are only pruning images and not containers or volumes.","commit_id":"58a9a3654577455fd1f3539731ce57667c0a54c3"},{"author":{"_account_id":30523,"name":"Dincer Celik","email":"hello@dincercelik.com","username":"osmanlicilegi"},"change_message_id":"c08d3d65620089771c8642b3d8b24615572275b9","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"- name: Pruning Kolla images"},{"line_number":3,"context_line":"  docker_prune:"},{"line_number":4,"context_line":"    images: yes"},{"line_number":5,"context_line":"    images_filters:"},{"line_number":6,"context_line":"      label: kolla_version"},{"line_number":7,"context_line":"    timeout: \u0027{{ docker_image_prune_timeout }}\u0027"}],"source_content_type":"text/x-yaml","patch_set":12,"id":"3fa7e38b_84901043","line":6,"range":{"start_line":4,"start_character":0,"end_line":6,"end_character":26},"in_reply_to":"3fa7e38b_f314c5ec","updated":"2020-01-23 22:59:15.000000000","message":"Make sense as image pruning is an advanced operation.","commit_id":"58a9a3654577455fd1f3539731ce57667c0a54c3"},{"author":{"_account_id":30523,"name":"Dincer Celik","email":"hello@dincercelik.com","username":"osmanlicilegi"},"change_message_id":"c2e21b92d01a6074c812cccb47dea70015e08fc0","unresolved":false,"context_lines":[{"line_number":2,"context_line":"- name: Pruning Kolla images"},{"line_number":3,"context_line":"  become: true"},{"line_number":4,"context_line":"  docker_prune:"},{"line_number":5,"context_line":"    images: yes"},{"line_number":6,"context_line":"    images_filters:"},{"line_number":7,"context_line":"      label: kolla_version"},{"line_number":8,"context_line":"    timeout: \"{{ docker_image_prune_timeout }}\""}],"source_content_type":"text/x-yaml","patch_set":15,"id":"3fa7e38b_71f6e260","line":5,"range":{"start_line":5,"start_character":12,"end_line":5,"end_character":15},"updated":"2020-01-25 17:42:32.000000000","message":"As we only want to prune images, no need to have a variable to control this.","commit_id":"41afd14d8f31269393d629cbbdf0f837e3ec6a62"},{"author":{"_account_id":30523,"name":"Dincer Celik","email":"hello@dincercelik.com","username":"osmanlicilegi"},"change_message_id":"c2e21b92d01a6074c812cccb47dea70015e08fc0","unresolved":false,"context_lines":[{"line_number":4,"context_line":"  docker_prune:"},{"line_number":5,"context_line":"    images: yes"},{"line_number":6,"context_line":"    images_filters:"},{"line_number":7,"context_line":"      label: kolla_version"},{"line_number":8,"context_line":"    timeout: \"{{ docker_image_prune_timeout }}\""}],"source_content_type":"text/x-yaml","patch_set":15,"id":"3fa7e38b_91f11e67","line":7,"range":{"start_line":7,"start_character":13,"end_line":7,"end_character":26},"updated":"2020-01-25 17:42:32.000000000","message":"We only want to prune images of kolla so this should be static.","commit_id":"41afd14d8f31269393d629cbbdf0f837e3ec6a62"}]}