)]}'
{"tests/templates/globals-default.j2":[{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"d0371249e490b20fe659916cb15864eb629c9dca","unresolved":false,"context_lines":[{"line_number":133,"context_line":"kolla_enable_tls_internal: \"yes\""},{"line_number":134,"context_line":"kolla_verify_internal_ca_certs: \"no\""},{"line_number":135,"context_line":"kolla_copy_ca_into_containers: \"yes\""},{"line_number":136,"context_line":"{% if base_distro \u003d\u003d \"ubuntu\" %}"},{"line_number":137,"context_line":"openstack_cacert: \"/usr/local/share/ca-certificates/kolla-customca-haproxy-internal.crt\""},{"line_number":138,"context_line":"{% endif %}"},{"line_number":139,"context_line":"{% if base_distro \u003d\u003d \"centos\" %}"}],"source_content_type":"text/x-jinja2","patch_set":9,"id":"3fa7e38b_e8574026","line":136,"range":{"start_line":136,"start_character":22,"end_line":136,"end_character":28},"updated":"2020-01-27 12:23:16.000000000","message":"Debian?","commit_id":"442d251769ee501bc811728f33599730adcbd921"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"923e31c630cc13df426694533666e1d183a5834e","unresolved":false,"context_lines":[{"line_number":140,"context_line":"kolla_enable_tls_internal: \"yes\""},{"line_number":141,"context_line":"kolla_verify_internal_ca_certs: \"no\""},{"line_number":142,"context_line":"kolla_copy_ca_into_containers: \"yes\""},{"line_number":143,"context_line":"{% if base_distro \u003d\u003d \"ubuntu\" or base_distro \u003d\u003d \"debian\" %}"},{"line_number":144,"context_line":"openstack_cacert: \"/usr/local/share/ca-certificates/kolla-customca-haproxy-internal.crt\""},{"line_number":145,"context_line":"{% endif %}"},{"line_number":146,"context_line":"{% if base_distro \u003d\u003d \"centos\" %}"},{"line_number":147,"context_line":"openstack_cacert: \"/etc/pki/ca-trust/source/anchors/kolla-customca-haproxy-internal.crt\""},{"line_number":148,"context_line":"{% endif %}"},{"line_number":149,"context_line":"{% endif %}"}],"source_content_type":"text/x-jinja2","patch_set":11,"id":"3fa7e38b_40c89a54","line":148,"range":{"start_line":143,"start_character":0,"end_line":148,"end_character":11},"updated":"2020-01-28 11:02:31.000000000","message":"Unrelated to this change, but do we have these locations documented somewhere?","commit_id":"5cf3874ec75b0cf30293dec5a97fda04174018ce"},{"author":{"_account_id":30810,"name":"James Kirsch","email":"generalfuzz@gmail.com","username":"generalfuzz"},"change_message_id":"471ab42e869ae233c60537a8ce99b7aca23d56f5","unresolved":false,"context_lines":[{"line_number":140,"context_line":"kolla_enable_tls_internal: \"yes\""},{"line_number":141,"context_line":"kolla_verify_internal_ca_certs: \"no\""},{"line_number":142,"context_line":"kolla_copy_ca_into_containers: \"yes\""},{"line_number":143,"context_line":"{% if base_distro \u003d\u003d \"ubuntu\" or base_distro \u003d\u003d \"debian\" %}"},{"line_number":144,"context_line":"openstack_cacert: \"/usr/local/share/ca-certificates/kolla-customca-haproxy-internal.crt\""},{"line_number":145,"context_line":"{% endif %}"},{"line_number":146,"context_line":"{% if base_distro \u003d\u003d \"centos\" %}"},{"line_number":147,"context_line":"openstack_cacert: \"/etc/pki/ca-trust/source/anchors/kolla-customca-haproxy-internal.crt\""},{"line_number":148,"context_line":"{% endif %}"},{"line_number":149,"context_line":"{% endif %}"}],"source_content_type":"text/x-jinja2","patch_set":11,"id":"3fa7e38b_602d8bfa","line":148,"range":{"start_line":143,"start_character":0,"end_line":148,"end_character":11},"in_reply_to":"3fa7e38b_40c89a54","updated":"2020-01-28 20:09:17.000000000","message":"I added in https://review.opendev.org/699888","commit_id":"5cf3874ec75b0cf30293dec5a97fda04174018ce"}],"tests/test-dashboard.sh":[{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"56dfc9a50a614f305fa209f8f7298c7e98ee2583","unresolved":false,"context_lines":[{"line_number":17,"context_line":"        --fail"},{"line_number":18,"context_line":"    )"},{"line_number":19,"context_line":"    if [[ \"$SCENARIO\" \u003d\u003d \"tls\" ]]; then"},{"line_number":20,"context_line":"        args+\u003d(--insecure)"},{"line_number":21,"context_line":"    fi"},{"line_number":22,"context_line":"    if ! curl \"${args[@]}\" $DASHBOARD_URL \u003e $output_path; then"},{"line_number":23,"context_line":"        return 1"}],"source_content_type":"text/x-sh","patch_set":4,"id":"3fa7e38b_67b4b681","line":20,"range":{"start_line":20,"start_character":15,"end_line":20,"end_character":25},"updated":"2020-01-10 15:03:29.000000000","message":"Ideally curl would pick up the CA from the system trust store. If we really can\u0027t get that to work, then --cacert or --capath would be preferable to --insecure.","commit_id":"1bb950ad61904be51de3b12ff70ce90432ca9200"}],"tests/upgrade.sh":[{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"8d021c529779088f97276fc5c1d5df975a471867","unresolved":false,"context_lines":[{"line_number":10,"context_line":"function upgrade {"},{"line_number":11,"context_line":"    RAW_INVENTORY\u003d/etc/kolla/inventory"},{"line_number":12,"context_line":"    # generate self-signed certificates for the optional internal TLS tests"},{"line_number":13,"context_line":"    if [[ $SCENARIO \u003d\u003d \"tls\" ]]; then"},{"line_number":14,"context_line":"        tools/kolla-ansible -i ${RAW_INVENTORY} -vvv certificates \u003e /tmp/logs/ansible/certificates"},{"line_number":15,"context_line":"    fi"},{"line_number":16,"context_line":"    tools/kolla-ansible -i ${RAW_INVENTORY} -vvv prechecks \u0026\u003e /tmp/logs/ansible/upgrade-prechecks"}],"source_content_type":"text/x-sh","patch_set":6,"id":"1fa4df85_12187b1b","line":13,"range":{"start_line":13,"start_character":4,"end_line":13,"end_character":37},"updated":"2020-02-25 08:53:54.000000000","message":"\u0027tis buggy :-)","commit_id":"e347e9081ddcf90bdbba3e29b62e87665068f26f"},{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"0a9dea3f83714d3542d9fca2c6e0bca4ec164d4f","unresolved":false,"context_lines":[{"line_number":10,"context_line":"function upgrade {"},{"line_number":11,"context_line":"    RAW_INVENTORY\u003d/etc/kolla/inventory"},{"line_number":12,"context_line":"    # generate self-signed certificates for the optional internal TLS tests"},{"line_number":13,"context_line":"    if [[ $SCENARIO \u003d\u003d \"tls\" ]]; then"},{"line_number":14,"context_line":"        tools/kolla-ansible -i ${RAW_INVENTORY} -vvv certificates \u003e /tmp/logs/ansible/certificates"},{"line_number":15,"context_line":"    fi"},{"line_number":16,"context_line":"    tools/kolla-ansible -i ${RAW_INVENTORY} -vvv prechecks \u0026\u003e /tmp/logs/ansible/upgrade-prechecks"}],"source_content_type":"text/x-sh","patch_set":12,"id":"1fa4df85_92e1cb01","line":13,"range":{"start_line":13,"start_character":4,"end_line":13,"end_character":37},"updated":"2020-02-25 08:54:18.000000000","message":"I meant this. :-)","commit_id":"6404d0e0315c2ccb68960f0421b69eded31de6cd"},{"author":{"_account_id":30810,"name":"James Kirsch","email":"generalfuzz@gmail.com","username":"generalfuzz"},"change_message_id":"971f8636011888b7bac482a0050fb8dc932f6ec7","unresolved":false,"context_lines":[{"line_number":10,"context_line":"function upgrade {"},{"line_number":11,"context_line":"    RAW_INVENTORY\u003d/etc/kolla/inventory"},{"line_number":12,"context_line":"    # generate self-signed certificates for the optional internal TLS tests"},{"line_number":13,"context_line":"    if [[ $SCENARIO \u003d\u003d \"tls\" ]]; then"},{"line_number":14,"context_line":"        tools/kolla-ansible -i ${RAW_INVENTORY} -vvv certificates \u003e /tmp/logs/ansible/certificates"},{"line_number":15,"context_line":"    fi"},{"line_number":16,"context_line":"    tools/kolla-ansible -i ${RAW_INVENTORY} -vvv prechecks \u0026\u003e /tmp/logs/ansible/upgrade-prechecks"}],"source_content_type":"text/x-sh","patch_set":12,"id":"1fa4df85_5c04bd17","line":13,"range":{"start_line":13,"start_character":4,"end_line":13,"end_character":37},"in_reply_to":"1fa4df85_6776cedb","updated":"2020-02-25 18:09:51.000000000","message":"https://review.opendev.org/#/c/709808/1","commit_id":"6404d0e0315c2ccb68960f0421b69eded31de6cd"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"57bf68a8c8442c1dc5caef4d2223b9b405aebc63","unresolved":false,"context_lines":[{"line_number":10,"context_line":"function upgrade {"},{"line_number":11,"context_line":"    RAW_INVENTORY\u003d/etc/kolla/inventory"},{"line_number":12,"context_line":"    # generate self-signed certificates for the optional internal TLS tests"},{"line_number":13,"context_line":"    if [[ $SCENARIO \u003d\u003d \"tls\" ]]; then"},{"line_number":14,"context_line":"        tools/kolla-ansible -i ${RAW_INVENTORY} -vvv certificates \u003e /tmp/logs/ansible/certificates"},{"line_number":15,"context_line":"    fi"},{"line_number":16,"context_line":"    tools/kolla-ansible -i ${RAW_INVENTORY} -vvv prechecks \u0026\u003e /tmp/logs/ansible/upgrade-prechecks"}],"source_content_type":"text/x-sh","patch_set":12,"id":"1fa4df85_6776cedb","line":13,"range":{"start_line":13,"start_character":4,"end_line":13,"end_character":37},"in_reply_to":"1fa4df85_92e1cb01","updated":"2020-02-25 12:07:48.000000000","message":"James could you push a follow up?","commit_id":"6404d0e0315c2ccb68960f0421b69eded31de6cd"}],"zuul.d/jobs.yaml":[{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"56dfc9a50a614f305fa209f8f7298c7e98ee2583","unresolved":false,"context_lines":[{"line_number":6,"context_line":"    vars:"},{"line_number":7,"context_line":"      base_distro: centos"},{"line_number":8,"context_line":"      install_type: source"},{"line_number":9,"context_line":"      scenario: tls"},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"- job:"},{"line_number":12,"context_line":"    name: kolla-ansible-debian-source"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"3fa7e38b_27fc7e3d","line":9,"range":{"start_line":9,"start_character":6,"end_line":9,"end_character":19},"updated":"2020-01-10 15:03:29.000000000","message":"Let\u0027s keep the scenario the same, but add a new variable (tls_enabled?) that determines whether TLS is in use. That way we will be able to enable TLS for any job we choose.","commit_id":"1bb950ad61904be51de3b12ff70ce90432ca9200"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"d0371249e490b20fe659916cb15864eb629c9dca","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"- job:"},{"line_number":3,"context_line":"    name: kolla-ansible-centos-source"},{"line_number":4,"context_line":"    parent: kolla-ansible-base"},{"line_number":5,"context_line":"    nodeset: kolla-ansible-centos"},{"line_number":6,"context_line":"    vars:"},{"line_number":7,"context_line":"      base_distro: centos"},{"line_number":8,"context_line":"      install_type: source"},{"line_number":9,"context_line":""},{"line_number":10,"context_line":"- job:"},{"line_number":11,"context_line":"    name: kolla-ansible-debian-source-aarch64"}],"source_content_type":"text/x-yaml","patch_set":9,"id":"3fa7e38b_88524c35","line":8,"range":{"start_line":3,"start_character":0,"end_line":8,"end_character":26},"updated":"2020-01-27 12:23:16.000000000","message":"tls_enabled here too?","commit_id":"442d251769ee501bc811728f33599730adcbd921"},{"author":{"_account_id":30810,"name":"James Kirsch","email":"generalfuzz@gmail.com","username":"generalfuzz"},"change_message_id":"5795328f2abd7c0fd8dc6085ef1aedca558233de","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"- job:"},{"line_number":3,"context_line":"    name: kolla-ansible-centos-source"},{"line_number":4,"context_line":"    parent: kolla-ansible-base"},{"line_number":5,"context_line":"    nodeset: kolla-ansible-centos"},{"line_number":6,"context_line":"    vars:"},{"line_number":7,"context_line":"      base_distro: centos"},{"line_number":8,"context_line":"      install_type: source"},{"line_number":9,"context_line":""},{"line_number":10,"context_line":"- job:"},{"line_number":11,"context_line":"    name: kolla-ansible-debian-source-aarch64"}],"source_content_type":"text/x-yaml","patch_set":9,"id":"3fa7e38b_0b172c56","line":8,"range":{"start_line":3,"start_character":0,"end_line":8,"end_character":26},"in_reply_to":"3fa7e38b_88524c35","updated":"2020-01-27 23:53:54.000000000","message":"not until centos 8 is in.","commit_id":"442d251769ee501bc811728f33599730adcbd921"}]}
