)]}'
{"ansible/roles/monasca/tasks/post_config.yml":[{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"74c4cb8798f93e20bde1941e3e2a08d85791b34c","unresolved":false,"context_lines":[{"line_number":41,"context_line":"  uri:"},{"line_number":42,"context_line":"    method: GET"},{"line_number":43,"context_line":"    url: \u003e"},{"line_number":44,"context_line":"      {{ internal_protocol }}://{{ kolla_internal_vip_address | put_address_in_context(\u0027url\u0027) }}:{{ monasca_grafana_server_port }}"},{"line_number":45,"context_line":"      /api/orgs/name/{{ monasca_grafana_control_plane_org }}"},{"line_number":46,"context_line":"    user: \u0027{{ monasca_grafana_admin_username }}\u0027"},{"line_number":47,"context_line":"    password: \u0027{{ monasca_grafana_admin_password }}\u0027"},{"line_number":48,"context_line":"    return_content: true"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"3fa7e38b_48d163f8","line":45,"range":{"start_line":44,"start_character":6,"end_line":45,"end_character":60},"updated":"2020-01-14 15:06:35.000000000","message":"Please see the comments in the original review about this. It will add a space in the URL.","commit_id":"db81ccced46b8d874eb431a0b14fb72a229dda74"},{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"8c02df6f43fb2698ac1c760cc94d8052571e34e6","unresolved":false,"context_lines":[{"line_number":41,"context_line":"  uri:"},{"line_number":42,"context_line":"    method: GET"},{"line_number":43,"context_line":"    url: \u003e"},{"line_number":44,"context_line":"      {{ internal_protocol }}://{{ kolla_internal_vip_address | put_address_in_context(\u0027url\u0027) }}:{{ monasca_grafana_server_port }}"},{"line_number":45,"context_line":"      /api/orgs/name/{{ monasca_grafana_control_plane_org }}"},{"line_number":46,"context_line":"    user: \u0027{{ monasca_grafana_admin_username }}\u0027"},{"line_number":47,"context_line":"    password: \u0027{{ monasca_grafana_admin_password }}\u0027"},{"line_number":48,"context_line":"    return_content: true"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"3fa7e38b_b7f94e83","line":45,"range":{"start_line":44,"start_character":6,"end_line":45,"end_character":60},"in_reply_to":"3fa7e38b_48d163f8","updated":"2020-01-14 18:07:20.000000000","message":"Yeah, we can do three things:\n1) url:\n      \"{{ internal_protocol}}://{{ blah }}\\\n       /index.html\"\n2) set monasca_base_url in defaults and reuse it here\n3) Add # noqa or remove the line length check at all\n\nWhich one do we vote for? ;-)","commit_id":"db81ccced46b8d874eb431a0b14fb72a229dda74"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"cd529ffd0a81406cca20821e25e80a56ec97167f","unresolved":false,"context_lines":[{"line_number":41,"context_line":"  uri:"},{"line_number":42,"context_line":"    method: GET"},{"line_number":43,"context_line":"    url: \u003e"},{"line_number":44,"context_line":"      {{ internal_protocol }}://{{ kolla_internal_vip_address | put_address_in_context(\u0027url\u0027) }}:{{ monasca_grafana_server_port }}"},{"line_number":45,"context_line":"      /api/orgs/name/{{ monasca_grafana_control_plane_org }}"},{"line_number":46,"context_line":"    user: \u0027{{ monasca_grafana_admin_username }}\u0027"},{"line_number":47,"context_line":"    password: \u0027{{ monasca_grafana_admin_password }}\u0027"},{"line_number":48,"context_line":"    return_content: true"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"3fa7e38b_2082ecc8","line":45,"range":{"start_line":44,"start_character":6,"end_line":45,"end_character":60},"in_reply_to":"3fa7e38b_b7f94e83","updated":"2020-01-15 09:32:09.000000000","message":"noqa works for me","commit_id":"db81ccced46b8d874eb431a0b14fb72a229dda74"}],"ansible/roles/nova-cell/tasks/create_cells.yml":[{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"7f6e3397593febdaff3f8b24fa7ec6489c67bd3d","unresolved":false,"context_lines":[{"line_number":28,"context_line":""},{"line_number":29,"context_line":"- name: Update cell"},{"line_number":30,"context_line":"  vars:"},{"line_number":31,"context_line":"    nova_cell_database_url: \u003e-"},{"line_number":32,"context_line":"      mysql+pymysql://{{ nova_cell_database_user }}:{{ nova_cell_database_password }}@{{ nova_cell_database_address | put_address_in_context(\u0027url\u0027) }}:"},{"line_number":33,"context_line":"      {{ nova_cell_database_port }}/{{ nova_cell_database_name }}\""},{"line_number":34,"context_line":"    nova_conductor: \"{{ nova_cell_services[\u0027nova-conductor\u0027] }}\""},{"line_number":35,"context_line":"  become: true"},{"line_number":36,"context_line":"  kolla_docker:"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"3fa7e38b_88cc02bf","line":33,"range":{"start_line":31,"start_character":0,"end_line":33,"end_character":66},"updated":"2020-01-17 09:20:59.000000000","message":"newline","commit_id":"c9ad1fec28b8d9cd70fb8def9a2dafc549ad0623"},{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"6328038e518e30ad4046d51b2e24622f5df1d36a","unresolved":false,"context_lines":[{"line_number":28,"context_line":""},{"line_number":29,"context_line":"- name: Update cell"},{"line_number":30,"context_line":"  vars:"},{"line_number":31,"context_line":"    nova_cell_database_url: \u003e-"},{"line_number":32,"context_line":"      mysql+pymysql://{{ nova_cell_database_user }}:{{ nova_cell_database_password }}@{{ nova_cell_database_address | put_address_in_context(\u0027url\u0027) }}:"},{"line_number":33,"context_line":"      {{ nova_cell_database_port }}/{{ nova_cell_database_name }}\""},{"line_number":34,"context_line":"    nova_conductor: \"{{ nova_cell_services[\u0027nova-conductor\u0027] }}\""},{"line_number":35,"context_line":"  become: true"},{"line_number":36,"context_line":"  kolla_docker:"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"3fa7e38b_d0d2e2fe","line":33,"range":{"start_line":31,"start_character":0,"end_line":33,"end_character":66},"in_reply_to":"3fa7e38b_88cc02bf","updated":"2020-01-31 07:25:25.000000000","message":"Any idea why the cells CI does skip this task?","commit_id":"c9ad1fec28b8d9cd70fb8def9a2dafc549ad0623"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"b2d3e76ff446a6b031ff4a45344b8cb478d18d1b","unresolved":false,"context_lines":[{"line_number":28,"context_line":""},{"line_number":29,"context_line":"- name: Update cell"},{"line_number":30,"context_line":"  vars:"},{"line_number":31,"context_line":"    nova_cell_database_url: \u003e-"},{"line_number":32,"context_line":"      mysql+pymysql://{{ nova_cell_database_user }}:{{ nova_cell_database_password }}@{{ nova_cell_database_address | put_address_in_context(\u0027url\u0027) }}:"},{"line_number":33,"context_line":"      {{ nova_cell_database_port }}/{{ nova_cell_database_name }}\""},{"line_number":34,"context_line":"    nova_conductor: \"{{ nova_cell_services[\u0027nova-conductor\u0027] }}\""},{"line_number":35,"context_line":"  become: true"},{"line_number":36,"context_line":"  kolla_docker:"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"3f4c43b2_153af496","line":33,"range":{"start_line":31,"start_character":0,"end_line":33,"end_character":66},"in_reply_to":"3fa7e38b_d0d2e2fe","updated":"2020-04-16 11:25:51.000000000","message":"The task only runs if the message queue of DB URLs have changed.","commit_id":"c9ad1fec28b8d9cd70fb8def9a2dafc549ad0623"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"c716e4e168540ec844e554e912460ba96f340afa","unresolved":false,"context_lines":[{"line_number":30,"context_line":"  vars:"},{"line_number":31,"context_line":"    nova_cell_database_url: \u003e-"},{"line_number":32,"context_line":"      mysql+pymysql://{{ nova_cell_database_user }}:{{ nova_cell_database_password }}@{{ nova_cell_database_address | put_address_in_context(\u0027url\u0027) }}:"},{"line_number":33,"context_line":"      {{ nova_cell_database_port }}/{{ nova_cell_database_name }}\""},{"line_number":34,"context_line":"    nova_conductor: \"{{ nova_cell_services[\u0027nova-conductor\u0027] }}\""},{"line_number":35,"context_line":"  become: true"},{"line_number":36,"context_line":"  kolla_docker:"}],"source_content_type":"text/x-yaml","patch_set":7,"id":"3f4c43b2_ed3b40ce","line":33,"updated":"2020-04-16 13:41:22.000000000","message":"And this one","commit_id":"44a18b8bf9c80f682f07d3b56467f90294940780"}],"ansible/roles/nova-cell/tasks/external_ceph.yml":[{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"7f6e3397593febdaff3f8b24fa7ec6489c67bd3d","unresolved":false,"context_lines":[{"line_number":85,"context_line":"- name: Extract nova key from file"},{"line_number":86,"context_line":"  set_fact:"},{"line_number":87,"context_line":"    nova_cephx_raw_key:"},{"line_number":88,"context_line":"      \"{{ lookup(\u0027file\u0027, nova_cephx_keyring_file.stat.path) | regex_search(\u0027key\\\\s*\u003d.*$\u0027, multiline\u003dTrue) | regex_replace(\u0027key\\\\s*\u003d\\\\s*(.*)\\\\s*\u0027, \u0027\\\\1\u0027) }}\""},{"line_number":89,"context_line":"  changed_when: false"},{"line_number":90,"context_line":"  run_once: True"},{"line_number":91,"context_line":"  when:"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"3fa7e38b_68c986a9","line":88,"updated":"2020-01-17 09:20:59.000000000","message":"are we sure this doesn\u0027t affect whitespace?","commit_id":"c9ad1fec28b8d9cd70fb8def9a2dafc549ad0623"},{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"a2a78bb9b996d85f9feacbe873f44ef16fa83508","unresolved":false,"context_lines":[{"line_number":85,"context_line":"- name: Extract nova key from file"},{"line_number":86,"context_line":"  set_fact:"},{"line_number":87,"context_line":"    nova_cephx_raw_key:"},{"line_number":88,"context_line":"      \"{{ lookup(\u0027file\u0027, nova_cephx_keyring_file.stat.path) | regex_search(\u0027key\\\\s*\u003d.*$\u0027, multiline\u003dTrue) | regex_replace(\u0027key\\\\s*\u003d\\\\s*(.*)\\\\s*\u0027, \u0027\\\\1\u0027) }}\""},{"line_number":89,"context_line":"  changed_when: false"},{"line_number":90,"context_line":"  run_once: True"},{"line_number":91,"context_line":"  when:"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"3fa7e38b_f0ba7eb8","line":88,"in_reply_to":"3fa7e38b_68c986a9","updated":"2020-01-31 07:24:23.000000000","message":"Seems not - https://zuul.opendev.org/t/openstack/build/7c9f56570883422e8e74e8515bf80975/log/primary/logs/ansible/deploy#79839","commit_id":"c9ad1fec28b8d9cd70fb8def9a2dafc549ad0623"},{"author":{"_account_id":24072,"name":"Marcin Juszkiewicz","email":"mjuszkiewicz@redhat.com","username":"hrw"},"change_message_id":"f6b66f801917818549499f4a534061424761d191","unresolved":false,"context_lines":[{"line_number":97,"context_line":""},{"line_number":98,"context_line":"- name: Extract nova key from file"},{"line_number":99,"context_line":"  set_fact:"},{"line_number":100,"context_line":"    nova_cephx_raw_key: \"{{ lookup(\u0027file\u0027, nova_cephx_keyring_file.stat.path) | regex_search(\u0027key\\\\s*\u003d.*$\u0027, multiline\u003dTrue) | regex_replace(\u0027key\\\\s*\u003d\\\\s*(.*)\\\\s*\u0027, \u0027\\\\1\u0027) }}\"  # noqa 204"},{"line_number":101,"context_line":"  changed_when: false"},{"line_number":102,"context_line":"  run_once: True"},{"line_number":103,"context_line":"  when:"}],"source_content_type":"text/x-yaml","patch_set":6,"id":"3f4c43b2_5570fcdc","line":100,"range":{"start_line":100,"start_character":24,"end_line":100,"end_character":174},"updated":"2020-04-16 11:59:30.000000000","message":"does not fit if moved to next line?","commit_id":"9a60e25514a9088a3089b76e8379ba0f4826c5c3"},{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"6fef7caa3ab3cf8d8296a1c6f9ea41b0dc0283bf","unresolved":false,"context_lines":[{"line_number":97,"context_line":""},{"line_number":98,"context_line":"- name: Extract nova key from file"},{"line_number":99,"context_line":"  set_fact:"},{"line_number":100,"context_line":"    nova_cephx_raw_key: \"{{ lookup(\u0027file\u0027, nova_cephx_keyring_file.stat.path) | regex_search(\u0027key\\\\s*\u003d.*$\u0027, multiline\u003dTrue) | regex_replace(\u0027key\\\\s*\u003d\\\\s*(.*)\\\\s*\u0027, \u0027\\\\1\u0027) }}\"  # noqa 204"},{"line_number":101,"context_line":"  changed_when: false"},{"line_number":102,"context_line":"  run_once: True"},{"line_number":103,"context_line":"  when:"}],"source_content_type":"text/x-yaml","patch_set":6,"id":"3f4c43b2_55491c89","line":100,"range":{"start_line":100,"start_character":24,"end_line":100,"end_character":174},"in_reply_to":"3f4c43b2_5570fcdc","updated":"2020-04-16 12:00:56.000000000","message":"ah, it does - we do it for cinder, let\u0027s be consistent.","commit_id":"9a60e25514a9088a3089b76e8379ba0f4826c5c3"}],"ansible/roles/nova/tasks/map_cell0.yml":[{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"7f6e3397593febdaff3f8b24fa7ec6489c67bd3d","unresolved":false,"context_lines":[{"line_number":3,"context_line":"  vars:"},{"line_number":4,"context_line":"    nova_api: \"{{ nova_services[\u0027nova-api\u0027] }}\""},{"line_number":5,"context_line":"    nova_cell0_connection:"},{"line_number":6,"context_line":"      \"mysql+pymysql://{{ nova_cell0_database_user }}:{{ nova_cell0_database_password }}@{{ nova_cell0_database_address }}/{{ nova_cell0_database_name }}\""},{"line_number":7,"context_line":"  become: true"},{"line_number":8,"context_line":"  kolla_docker:"},{"line_number":9,"context_line":"    action: \"start_container\""}],"source_content_type":"text/x-yaml","patch_set":3,"id":"3fa7e38b_c8b99a16","line":6,"updated":"2020-01-17 09:20:59.000000000","message":"are we sure this doesn\u0027t affect whitespace?","commit_id":"c9ad1fec28b8d9cd70fb8def9a2dafc549ad0623"},{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"a2a78bb9b996d85f9feacbe873f44ef16fa83508","unresolved":false,"context_lines":[{"line_number":3,"context_line":"  vars:"},{"line_number":4,"context_line":"    nova_api: \"{{ nova_services[\u0027nova-api\u0027] }}\""},{"line_number":5,"context_line":"    nova_cell0_connection:"},{"line_number":6,"context_line":"      \"mysql+pymysql://{{ nova_cell0_database_user }}:{{ nova_cell0_database_password }}@{{ nova_cell0_database_address }}/{{ nova_cell0_database_name }}\""},{"line_number":7,"context_line":"  become: true"},{"line_number":8,"context_line":"  kolla_docker:"},{"line_number":9,"context_line":"    action: \"start_container\""}],"source_content_type":"text/x-yaml","patch_set":3,"id":"3fa7e38b_70e44ee0","line":6,"in_reply_to":"3fa7e38b_c8b99a16","updated":"2020-01-31 07:24:23.000000000","message":"Seems not: https://zuul.opendev.org/t/openstack/build/7c9f56570883422e8e74e8515bf80975/log/primary/logs/ansible/deploy#70017","commit_id":"c9ad1fec28b8d9cd70fb8def9a2dafc549ad0623"}]}
