)]}'
{"tools/kolla-ansible":[{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"64c0472b429bac6bfd4be28530ae5c56539ccab9","unresolved":false,"context_lines":[{"line_number":131,"context_line":"EOF"},{"line_number":132,"context_line":"}"},{"line_number":133,"context_line":""},{"line_number":134,"context_line":"[[ ! -v ANSIBLE_DEBUG ]] \u0026\u0026 check_ansible_compatibility"},{"line_number":135,"context_line":""},{"line_number":136,"context_line":"SHORT_OPTS\u003d\"hi:p:t:k:e:v\""},{"line_number":137,"context_line":"LONG_OPTS\u003d\"help,inventory:,playbook:,skip-tags:,tags:,key:,extra:,verbose,configdir:,passwords:,limit:,forks:,vault-id:,ask-vault-pass,vault-password-file:,yes-i-really-really-mean-it,include-images,include-dev:,full,incremental\""}],"source_content_type":"application/x-shellscript","patch_set":1,"id":"3fa7e38b_cced6a8e","line":134,"range":{"start_line":134,"start_character":6,"end_line":134,"end_character":7},"updated":"2020-01-31 16:24:27.000000000","message":"I can\u0027t see this documented anywhere. What does it do?\n\nWhy don\u0027t we just run it with ANSIBLE_DEBUG\u003d0?","commit_id":"8fac5b470a617a19f24a724eac5871279b35573d"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"261cbcd13d1bc91ec638ec7c21f3c6ef8d7a75db","unresolved":false,"context_lines":[{"line_number":131,"context_line":"EOF"},{"line_number":132,"context_line":"}"},{"line_number":133,"context_line":""},{"line_number":134,"context_line":"[[ ! -v ANSIBLE_DEBUG ]] \u0026\u0026 check_ansible_compatibility"},{"line_number":135,"context_line":""},{"line_number":136,"context_line":"SHORT_OPTS\u003d\"hi:p:t:k:e:v\""},{"line_number":137,"context_line":"LONG_OPTS\u003d\"help,inventory:,playbook:,skip-tags:,tags:,key:,extra:,verbose,configdir:,passwords:,limit:,forks:,vault-id:,ask-vault-pass,vault-password-file:,yes-i-really-really-mean-it,include-images,include-dev:,full,incremental\""}],"source_content_type":"application/x-shellscript","patch_set":1,"id":"3fa7e38b_2bb296e9","line":134,"range":{"start_line":134,"start_character":6,"end_line":134,"end_character":7},"in_reply_to":"3fa7e38b_9c1d59c1","updated":"2020-02-06 13:43:03.000000000","message":"+1","commit_id":"8fac5b470a617a19f24a724eac5871279b35573d"},{"author":{"_account_id":30523,"name":"Dincer Celik","email":"hello@dincercelik.com","username":"osmanlicilegi"},"change_message_id":"11c9fca690d7c920198f8429c10efaa9ce8c4bf2","unresolved":false,"context_lines":[{"line_number":131,"context_line":"EOF"},{"line_number":132,"context_line":"}"},{"line_number":133,"context_line":""},{"line_number":134,"context_line":"[[ ! -v ANSIBLE_DEBUG ]] \u0026\u0026 check_ansible_compatibility"},{"line_number":135,"context_line":""},{"line_number":136,"context_line":"SHORT_OPTS\u003d\"hi:p:t:k:e:v\""},{"line_number":137,"context_line":"LONG_OPTS\u003d\"help,inventory:,playbook:,skip-tags:,tags:,key:,extra:,verbose,configdir:,passwords:,limit:,forks:,vault-id:,ask-vault-pass,vault-password-file:,yes-i-really-really-mean-it,include-images,include-dev:,full,incremental\""}],"source_content_type":"application/x-shellscript","patch_set":1,"id":"3fa7e38b_dc32f15d","line":134,"range":{"start_line":134,"start_character":6,"end_line":134,"end_character":7},"in_reply_to":"3fa7e38b_cced6a8e","updated":"2020-02-01 08:14:41.000000000","message":"-v is similar to -z, checks for if a variable has been assigned a value or not.\n\nIf you mean forcing ANSIBLE_DEBUG\u003d0 all the time, I doubt about it because it may break developers behavior. In my opinion, if a user is trying to run k-a with ANSIBLE_DEBUG set, doesn\u0027t matter if it\u0027s 0 or 1, we can skip the check on bash safely because we still have the check on prechecks.","commit_id":"8fac5b470a617a19f24a724eac5871279b35573d"},{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"a48d63884abdbe1f6cf3883fbfc56d747340d2a7","unresolved":false,"context_lines":[{"line_number":131,"context_line":"EOF"},{"line_number":132,"context_line":"}"},{"line_number":133,"context_line":""},{"line_number":134,"context_line":"[[ ! -v ANSIBLE_DEBUG ]] \u0026\u0026 check_ansible_compatibility"},{"line_number":135,"context_line":""},{"line_number":136,"context_line":"SHORT_OPTS\u003d\"hi:p:t:k:e:v\""},{"line_number":137,"context_line":"LONG_OPTS\u003d\"help,inventory:,playbook:,skip-tags:,tags:,key:,extra:,verbose,configdir:,passwords:,limit:,forks:,vault-id:,ask-vault-pass,vault-password-file:,yes-i-really-really-mean-it,include-images,include-dev:,full,incremental\""}],"source_content_type":"application/x-shellscript","patch_set":1,"id":"3fa7e38b_cc17aa53","line":134,"range":{"start_line":134,"start_character":6,"end_line":134,"end_character":7},"in_reply_to":"3fa7e38b_cced6a8e","updated":"2020-01-31 16:35:34.000000000","message":"Good point, no need to debug ansible *here*","commit_id":"8fac5b470a617a19f24a724eac5871279b35573d"},{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"fafa7260a85a8e1d4ae1024fb4f2cd91bf369f8e","unresolved":false,"context_lines":[{"line_number":131,"context_line":"EOF"},{"line_number":132,"context_line":"}"},{"line_number":133,"context_line":""},{"line_number":134,"context_line":"[[ ! -v ANSIBLE_DEBUG ]] \u0026\u0026 check_ansible_compatibility"},{"line_number":135,"context_line":""},{"line_number":136,"context_line":"SHORT_OPTS\u003d\"hi:p:t:k:e:v\""},{"line_number":137,"context_line":"LONG_OPTS\u003d\"help,inventory:,playbook:,skip-tags:,tags:,key:,extra:,verbose,configdir:,passwords:,limit:,forks:,vault-id:,ask-vault-pass,vault-password-file:,yes-i-really-really-mean-it,include-images,include-dev:,full,incremental\""}],"source_content_type":"application/x-shellscript","patch_set":1,"id":"3fa7e38b_9c1d59c1","line":134,"range":{"start_line":134,"start_character":6,"end_line":134,"end_character":7},"in_reply_to":"3fa7e38b_dc32f15d","updated":"2020-02-01 08:23:25.000000000","message":"I think Mark meant to run the ansible version check in that function with ANSIBLE_DEBUG\u003d0 as local env:\ninstead of: ansible --version\nrun: ANSIBLE_DEBUG\u003d0 ansible --version","commit_id":"8fac5b470a617a19f24a724eac5871279b35573d"}]}