)]}'
{"ansible/roles/mariadb/handlers/main.yml":[{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"e5d78c6530457dff3c7d6f92ee9b4cbd5ec27fe0","unresolved":false,"context_lines":[{"line_number":60,"context_line":"    - bootstrap_host \u003d\u003d inventory_hostname"},{"line_number":61,"context_line":"  listen: Bootstrap MariaDB cluster"},{"line_number":62,"context_line":""},{"line_number":63,"context_line":"# NOTE(mgoddard): In Rocky the MariaDB image had an issue where it would not"},{"line_number":64,"context_line":"# stop on demand, and would result in Docker forcibly killing the container."},{"line_number":65,"context_line":"# This could lead to a failed upgrade if the new image is unable to recover"},{"line_number":66,"context_line":"# from the crash. See https://bugs.launchpad.net/kolla-ansible/+bug/1820325."},{"line_number":67,"context_line":"# We need to remove the restart policy from the MariaDB container to ensure"},{"line_number":68,"context_line":"# that it does not start back up after being shut down."},{"line_number":69,"context_line":"# TODO(mgoddard): Remove this task in Train."},{"line_number":70,"context_line":""},{"line_number":71,"context_line":"- name: check if slave mariadb is running"},{"line_number":72,"context_line":"  vars:"},{"line_number":73,"context_line":"    service_name: \"mariadb\""},{"line_number":74,"context_line":"    service: \"{{ mariadb_services[service_name] }}\""},{"line_number":75,"context_line":"  become: true"},{"line_number":76,"context_line":"  kolla_container_facts:"},{"line_number":77,"context_line":"    name:"},{"line_number":78,"context_line":"      - \"{{ service.container_name }}\""},{"line_number":79,"context_line":"  register: initial_mariadb_container_facts"},{"line_number":80,"context_line":"  when:"},{"line_number":81,"context_line":"    - kolla_action !\u003d \"config\""},{"line_number":82,"context_line":"    - has_cluster | bool"},{"line_number":83,"context_line":"    - inventory_hostname !\u003d master_host"},{"line_number":84,"context_line":"    - not mariadb_recover | default(false)"},{"line_number":85,"context_line":"  listen: restart mariadb"},{"line_number":86,"context_line":""},{"line_number":87,"context_line":"- name: remove restart policy from slave mariadb"},{"line_number":88,"context_line":"  vars:"},{"line_number":89,"context_line":"    service_name: \"mariadb\""},{"line_number":90,"context_line":"    service: \"{{ mariadb_services[service_name] }}\""},{"line_number":91,"context_line":"  become: true"},{"line_number":92,"context_line":"  command: \"docker update --restart no {{ service.container_name }}\""},{"line_number":93,"context_line":"  when:"},{"line_number":94,"context_line":"    - kolla_action !\u003d \"config\""},{"line_number":95,"context_line":"    - has_cluster | bool"},{"line_number":96,"context_line":"    - inventory_hostname !\u003d master_host"},{"line_number":97,"context_line":"    - not mariadb_recover | default(false)"},{"line_number":98,"context_line":"    - service.container_name in initial_mariadb_container_facts"},{"line_number":99,"context_line":"  listen: restart mariadb"},{"line_number":100,"context_line":""},{"line_number":101,"context_line":"- name: shutdown slave mariadb"},{"line_number":102,"context_line":"  vars:"},{"line_number":103,"context_line":"    service_name: \"mariadb\""},{"line_number":104,"context_line":"    service: \"{{ mariadb_services[service_name] }}\""},{"line_number":105,"context_line":"  become: true"},{"line_number":106,"context_line":"  kolla_docker:"},{"line_number":107,"context_line":"    action: \"start_container\""},{"line_number":108,"context_line":"    command: \u003e-"},{"line_number":109,"context_line":"      bash -c \u0027"},{"line_number":110,"context_line":"      sudo -E kolla_set_configs \u0026\u0026"},{"line_number":111,"context_line":"      mysqladmin shutdown --host\u003d{{ api_interface_address }} --user\u003droot --password\u003d{{ database_password }}"},{"line_number":112,"context_line":"      \u0027"},{"line_number":113,"context_line":"    common_options: \"{{ docker_common_options }}\""},{"line_number":114,"context_line":"    detach: False"},{"line_number":115,"context_line":"    name: \"mariadb_shutdown\""},{"line_number":116,"context_line":"    image: \"{{ service.image }}\""},{"line_number":117,"context_line":"    volumes: \"{{ service.volumes }}\""},{"line_number":118,"context_line":"    dimensions: \"{{ service.dimensions }}\""},{"line_number":119,"context_line":"    labels:"},{"line_number":120,"context_line":"      UPGRADE:"},{"line_number":121,"context_line":"    restart_policy: \"never\""},{"line_number":122,"context_line":"  no_log: true"},{"line_number":123,"context_line":"  when:"},{"line_number":124,"context_line":"    - kolla_action !\u003d \"config\""},{"line_number":125,"context_line":"    - has_cluster | bool"},{"line_number":126,"context_line":"    - inventory_hostname !\u003d master_host"},{"line_number":127,"context_line":"    - not mariadb_recover | default(false)"},{"line_number":128,"context_line":"    - service.container_name in initial_mariadb_container_facts"},{"line_number":129,"context_line":"  listen: restart mariadb"},{"line_number":130,"context_line":""},{"line_number":131,"context_line":"- name: wait for slave mariadb shutdown"},{"line_number":132,"context_line":"  vars:"},{"line_number":133,"context_line":"    service_name: \"mariadb\""},{"line_number":134,"context_line":"    service: \"{{ mariadb_services[service_name] }}\""},{"line_number":135,"context_line":"  become: true"},{"line_number":136,"context_line":"  kolla_container_facts:"},{"line_number":137,"context_line":"    name:"},{"line_number":138,"context_line":"      - \"{{ service.container_name }}\""},{"line_number":139,"context_line":"  when:"},{"line_number":140,"context_line":"    - kolla_action !\u003d \"config\""},{"line_number":141,"context_line":"    - has_cluster | bool"},{"line_number":142,"context_line":"    - inventory_hostname !\u003d master_host"},{"line_number":143,"context_line":"    - not mariadb_recover | default(false)"},{"line_number":144,"context_line":"    - service.container_name in initial_mariadb_container_facts"},{"line_number":145,"context_line":"  listen: restart mariadb"},{"line_number":146,"context_line":"  register: mariadb_container_facts"},{"line_number":147,"context_line":"  # Don\u0027t fail if the container is still up - we will stop it in the next task."},{"line_number":148,"context_line":"  failed_when: false"},{"line_number":149,"context_line":"  until: service.container_name not in mariadb_container_facts"},{"line_number":150,"context_line":"  retries: 30"},{"line_number":151,"context_line":"  delay: 2"},{"line_number":152,"context_line":""},{"line_number":153,"context_line":"# Sometimes the mariadb service can get into a partially shutdown"},{"line_number":154,"context_line":"# state following a \u0027mysqladmin shutdown\u0027. Stop the container."},{"line_number":155,"context_line":"- name: stop mariadb slave"},{"line_number":156,"context_line":"  vars:"},{"line_number":157,"context_line":"    service_name: \"mariadb\""},{"line_number":158,"context_line":"    service: \"{{ mariadb_services[service_name] }}\""},{"line_number":159,"context_line":"  become: true"},{"line_number":160,"context_line":"  kolla_docker:"},{"line_number":161,"context_line":"    action: \"stop_container\""},{"line_number":162,"context_line":"    common_options: \"{{ docker_common_options }}\""},{"line_number":163,"context_line":"    name: \"{{ mariadb_service.container_name }}\""},{"line_number":164,"context_line":"  when:"},{"line_number":165,"context_line":"    - kolla_action !\u003d \"config\""},{"line_number":166,"context_line":"    - service.container_name in mariadb_container_facts"},{"line_number":167,"context_line":"    - has_cluster | bool"},{"line_number":168,"context_line":"    - inventory_hostname !\u003d master_host"},{"line_number":169,"context_line":"    - not mariadb_recover | default(false)"},{"line_number":170,"context_line":"    - service.container_name in initial_mariadb_container_facts"},{"line_number":171,"context_line":"  listen: restart mariadb"},{"line_number":172,"context_line":""},{"line_number":173,"context_line":"- name: replace restart policy on slave mariadb"},{"line_number":174,"context_line":"  vars:"},{"line_number":175,"context_line":"    service_name: \"mariadb\""},{"line_number":176,"context_line":"    service: \"{{ mariadb_services[service_name] }}\""},{"line_number":177,"context_line":"    restart_policy: \"{{ docker_restart_policy }}{% if docker_restart_policy \u003d\u003d \u0027on-failure\u0027 %}{{ docker_restart_policy_retry }}{% endif %}\""},{"line_number":178,"context_line":"  become: true"},{"line_number":179,"context_line":"  command: \"docker update --restart {{ restart_policy }} {{ service.container_name }}\""},{"line_number":180,"context_line":"  when:"},{"line_number":181,"context_line":"    - kolla_action !\u003d \"config\""},{"line_number":182,"context_line":"    - has_cluster | bool"},{"line_number":183,"context_line":"    - inventory_hostname !\u003d master_host"},{"line_number":184,"context_line":"    - not mariadb_recover | default(false)"},{"line_number":185,"context_line":"    - service.container_name in initial_mariadb_container_facts"},{"line_number":186,"context_line":"  listen: restart mariadb"},{"line_number":187,"context_line":""},{"line_number":188,"context_line":"- name: restart slave mariadb"},{"line_number":189,"context_line":"  vars:"},{"line_number":190,"context_line":"    service_name: \"mariadb\""},{"line_number":191,"context_line":"    service: \"{{ mariadb_services[service_name] }}\""},{"line_number":192,"context_line":"  become: true"},{"line_number":193,"context_line":"  kolla_docker:"},{"line_number":194,"context_line":"    action: \"recreate_or_restart_container\""},{"line_number":195,"context_line":"    common_options: \"{{ docker_common_options }}\""},{"line_number":196,"context_line":"    name: \"{{ service.container_name }}\""},{"line_number":197,"context_line":"    image: \"{{ service.image }}\""},{"line_number":198,"context_line":"    volumes: \"{{ service.volumes }}\""},{"line_number":199,"context_line":"    dimensions: \"{{ service.dimensions }}\""},{"line_number":200,"context_line":"  when:"},{"line_number":201,"context_line":"    - kolla_action !\u003d \"config\""},{"line_number":202,"context_line":"    - inventory_hostname !\u003d master_host"},{"line_number":203,"context_line":"    - not mariadb_recover | default(false)"},{"line_number":204,"context_line":"  listen: restart mariadb"},{"line_number":205,"context_line":""},{"line_number":206,"context_line":"# TODO(jeffrey4l), remove the task check when the wait_for bug is fixed"},{"line_number":207,"context_line":"# https://github.com/ansible/ansible-modules-core/issues/2788"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"3fa7e38b_cd3f5add","side":"PARENT","line":204,"range":{"start_line":63,"start_character":0,"end_line":204,"end_character":25},"updated":"2020-02-06 12:10:08.000000000","message":"You need to go through this dance in restart_services.yml","commit_id":"de2f40e680cf060bf7b3edc6e398ef69a47f9412"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"f41e6f447675e8bc6e24af3a6bd41479bd693760","unresolved":false,"context_lines":[{"line_number":60,"context_line":"    - bootstrap_host \u003d\u003d inventory_hostname"},{"line_number":61,"context_line":"  listen: Bootstrap MariaDB cluster"},{"line_number":62,"context_line":""},{"line_number":63,"context_line":"# NOTE(mgoddard): In Rocky the MariaDB image had an issue where it would not"},{"line_number":64,"context_line":"# stop on demand, and would result in Docker forcibly killing the container."},{"line_number":65,"context_line":"# This could lead to a failed upgrade if the new image is unable to recover"},{"line_number":66,"context_line":"# from the crash. See https://bugs.launchpad.net/kolla-ansible/+bug/1820325."},{"line_number":67,"context_line":"# We need to remove the restart policy from the MariaDB container to ensure"},{"line_number":68,"context_line":"# that it does not start back up after being shut down."},{"line_number":69,"context_line":"# TODO(mgoddard): Remove this task in Train."},{"line_number":70,"context_line":""},{"line_number":71,"context_line":"- name: check if slave mariadb is running"},{"line_number":72,"context_line":"  vars:"},{"line_number":73,"context_line":"    service_name: \"mariadb\""},{"line_number":74,"context_line":"    service: \"{{ mariadb_services[service_name] }}\""},{"line_number":75,"context_line":"  become: true"},{"line_number":76,"context_line":"  kolla_container_facts:"},{"line_number":77,"context_line":"    name:"},{"line_number":78,"context_line":"      - \"{{ service.container_name }}\""},{"line_number":79,"context_line":"  register: initial_mariadb_container_facts"},{"line_number":80,"context_line":"  when:"},{"line_number":81,"context_line":"    - kolla_action !\u003d \"config\""},{"line_number":82,"context_line":"    - has_cluster | bool"},{"line_number":83,"context_line":"    - inventory_hostname !\u003d master_host"},{"line_number":84,"context_line":"    - not mariadb_recover | default(false)"},{"line_number":85,"context_line":"  listen: restart mariadb"},{"line_number":86,"context_line":""},{"line_number":87,"context_line":"- name: remove restart policy from slave mariadb"},{"line_number":88,"context_line":"  vars:"},{"line_number":89,"context_line":"    service_name: \"mariadb\""},{"line_number":90,"context_line":"    service: \"{{ mariadb_services[service_name] }}\""},{"line_number":91,"context_line":"  become: true"},{"line_number":92,"context_line":"  command: \"docker update --restart no {{ service.container_name }}\""},{"line_number":93,"context_line":"  when:"},{"line_number":94,"context_line":"    - kolla_action !\u003d \"config\""},{"line_number":95,"context_line":"    - has_cluster | bool"},{"line_number":96,"context_line":"    - inventory_hostname !\u003d master_host"},{"line_number":97,"context_line":"    - not mariadb_recover | default(false)"},{"line_number":98,"context_line":"    - service.container_name in initial_mariadb_container_facts"},{"line_number":99,"context_line":"  listen: restart mariadb"},{"line_number":100,"context_line":""},{"line_number":101,"context_line":"- name: shutdown slave mariadb"},{"line_number":102,"context_line":"  vars:"},{"line_number":103,"context_line":"    service_name: \"mariadb\""},{"line_number":104,"context_line":"    service: \"{{ mariadb_services[service_name] }}\""},{"line_number":105,"context_line":"  become: true"},{"line_number":106,"context_line":"  kolla_docker:"},{"line_number":107,"context_line":"    action: \"start_container\""},{"line_number":108,"context_line":"    command: \u003e-"},{"line_number":109,"context_line":"      bash -c \u0027"},{"line_number":110,"context_line":"      sudo -E kolla_set_configs \u0026\u0026"},{"line_number":111,"context_line":"      mysqladmin shutdown --host\u003d{{ api_interface_address }} --user\u003droot --password\u003d{{ database_password }}"},{"line_number":112,"context_line":"      \u0027"},{"line_number":113,"context_line":"    common_options: \"{{ docker_common_options }}\""},{"line_number":114,"context_line":"    detach: False"},{"line_number":115,"context_line":"    name: \"mariadb_shutdown\""},{"line_number":116,"context_line":"    image: \"{{ service.image }}\""},{"line_number":117,"context_line":"    volumes: \"{{ service.volumes }}\""},{"line_number":118,"context_line":"    dimensions: \"{{ service.dimensions }}\""},{"line_number":119,"context_line":"    labels:"},{"line_number":120,"context_line":"      UPGRADE:"},{"line_number":121,"context_line":"    restart_policy: \"never\""},{"line_number":122,"context_line":"  no_log: true"},{"line_number":123,"context_line":"  when:"},{"line_number":124,"context_line":"    - kolla_action !\u003d \"config\""},{"line_number":125,"context_line":"    - has_cluster | bool"},{"line_number":126,"context_line":"    - inventory_hostname !\u003d master_host"},{"line_number":127,"context_line":"    - not mariadb_recover | default(false)"},{"line_number":128,"context_line":"    - service.container_name in initial_mariadb_container_facts"},{"line_number":129,"context_line":"  listen: restart mariadb"},{"line_number":130,"context_line":""},{"line_number":131,"context_line":"- name: wait for slave mariadb shutdown"},{"line_number":132,"context_line":"  vars:"},{"line_number":133,"context_line":"    service_name: \"mariadb\""},{"line_number":134,"context_line":"    service: \"{{ mariadb_services[service_name] }}\""},{"line_number":135,"context_line":"  become: true"},{"line_number":136,"context_line":"  kolla_container_facts:"},{"line_number":137,"context_line":"    name:"},{"line_number":138,"context_line":"      - \"{{ service.container_name }}\""},{"line_number":139,"context_line":"  when:"},{"line_number":140,"context_line":"    - kolla_action !\u003d \"config\""},{"line_number":141,"context_line":"    - has_cluster | bool"},{"line_number":142,"context_line":"    - inventory_hostname !\u003d master_host"},{"line_number":143,"context_line":"    - not mariadb_recover | default(false)"},{"line_number":144,"context_line":"    - service.container_name in initial_mariadb_container_facts"},{"line_number":145,"context_line":"  listen: restart mariadb"},{"line_number":146,"context_line":"  register: mariadb_container_facts"},{"line_number":147,"context_line":"  # Don\u0027t fail if the container is still up - we will stop it in the next task."},{"line_number":148,"context_line":"  failed_when: false"},{"line_number":149,"context_line":"  until: service.container_name not in mariadb_container_facts"},{"line_number":150,"context_line":"  retries: 30"},{"line_number":151,"context_line":"  delay: 2"},{"line_number":152,"context_line":""},{"line_number":153,"context_line":"# Sometimes the mariadb service can get into a partially shutdown"},{"line_number":154,"context_line":"# state following a \u0027mysqladmin shutdown\u0027. Stop the container."},{"line_number":155,"context_line":"- name: stop mariadb slave"},{"line_number":156,"context_line":"  vars:"},{"line_number":157,"context_line":"    service_name: \"mariadb\""},{"line_number":158,"context_line":"    service: \"{{ mariadb_services[service_name] }}\""},{"line_number":159,"context_line":"  become: true"},{"line_number":160,"context_line":"  kolla_docker:"},{"line_number":161,"context_line":"    action: \"stop_container\""},{"line_number":162,"context_line":"    common_options: \"{{ docker_common_options }}\""},{"line_number":163,"context_line":"    name: \"{{ mariadb_service.container_name }}\""},{"line_number":164,"context_line":"  when:"},{"line_number":165,"context_line":"    - kolla_action !\u003d \"config\""},{"line_number":166,"context_line":"    - service.container_name in mariadb_container_facts"},{"line_number":167,"context_line":"    - has_cluster | bool"},{"line_number":168,"context_line":"    - inventory_hostname !\u003d master_host"},{"line_number":169,"context_line":"    - not mariadb_recover | default(false)"},{"line_number":170,"context_line":"    - service.container_name in initial_mariadb_container_facts"},{"line_number":171,"context_line":"  listen: restart mariadb"},{"line_number":172,"context_line":""},{"line_number":173,"context_line":"- name: replace restart policy on slave mariadb"},{"line_number":174,"context_line":"  vars:"},{"line_number":175,"context_line":"    service_name: \"mariadb\""},{"line_number":176,"context_line":"    service: \"{{ mariadb_services[service_name] }}\""},{"line_number":177,"context_line":"    restart_policy: \"{{ docker_restart_policy }}{% if docker_restart_policy \u003d\u003d \u0027on-failure\u0027 %}{{ docker_restart_policy_retry }}{% endif %}\""},{"line_number":178,"context_line":"  become: true"},{"line_number":179,"context_line":"  command: \"docker update --restart {{ restart_policy }} {{ service.container_name }}\""},{"line_number":180,"context_line":"  when:"},{"line_number":181,"context_line":"    - kolla_action !\u003d \"config\""},{"line_number":182,"context_line":"    - has_cluster | bool"},{"line_number":183,"context_line":"    - inventory_hostname !\u003d master_host"},{"line_number":184,"context_line":"    - not mariadb_recover | default(false)"},{"line_number":185,"context_line":"    - service.container_name in initial_mariadb_container_facts"},{"line_number":186,"context_line":"  listen: restart mariadb"},{"line_number":187,"context_line":""},{"line_number":188,"context_line":"- name: restart slave mariadb"},{"line_number":189,"context_line":"  vars:"},{"line_number":190,"context_line":"    service_name: \"mariadb\""},{"line_number":191,"context_line":"    service: \"{{ mariadb_services[service_name] }}\""},{"line_number":192,"context_line":"  become: true"},{"line_number":193,"context_line":"  kolla_docker:"},{"line_number":194,"context_line":"    action: \"recreate_or_restart_container\""},{"line_number":195,"context_line":"    common_options: \"{{ docker_common_options }}\""},{"line_number":196,"context_line":"    name: \"{{ service.container_name }}\""},{"line_number":197,"context_line":"    image: \"{{ service.image }}\""},{"line_number":198,"context_line":"    volumes: \"{{ service.volumes }}\""},{"line_number":199,"context_line":"    dimensions: \"{{ service.dimensions }}\""},{"line_number":200,"context_line":"  when:"},{"line_number":201,"context_line":"    - kolla_action !\u003d \"config\""},{"line_number":202,"context_line":"    - inventory_hostname !\u003d master_host"},{"line_number":203,"context_line":"    - not mariadb_recover | default(false)"},{"line_number":204,"context_line":"  listen: restart mariadb"},{"line_number":205,"context_line":""},{"line_number":206,"context_line":"# TODO(jeffrey4l), remove the task check when the wait_for bug is fixed"},{"line_number":207,"context_line":"# https://github.com/ansible/ansible-modules-core/issues/2788"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"3fa7e38b_eb3a3e95","side":"PARENT","line":204,"range":{"start_line":63,"start_character":0,"end_line":204,"end_character":25},"in_reply_to":"3fa7e38b_4d284a97","updated":"2020-02-06 13:31:11.000000000","message":"It works because we fixed the rocky mariadb image dumb-init. We can\u0027t assume users are running the fixed image though.","commit_id":"de2f40e680cf060bf7b3edc6e398ef69a47f9412"},{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"76913d70fa37b7a90175071267165b48d3ce419a","unresolved":false,"context_lines":[{"line_number":60,"context_line":"    - bootstrap_host \u003d\u003d inventory_hostname"},{"line_number":61,"context_line":"  listen: Bootstrap MariaDB cluster"},{"line_number":62,"context_line":""},{"line_number":63,"context_line":"# NOTE(mgoddard): In Rocky the MariaDB image had an issue where it would not"},{"line_number":64,"context_line":"# stop on demand, and would result in Docker forcibly killing the container."},{"line_number":65,"context_line":"# This could lead to a failed upgrade if the new image is unable to recover"},{"line_number":66,"context_line":"# from the crash. See https://bugs.launchpad.net/kolla-ansible/+bug/1820325."},{"line_number":67,"context_line":"# We need to remove the restart policy from the MariaDB container to ensure"},{"line_number":68,"context_line":"# that it does not start back up after being shut down."},{"line_number":69,"context_line":"# TODO(mgoddard): Remove this task in Train."},{"line_number":70,"context_line":""},{"line_number":71,"context_line":"- name: check if slave mariadb is running"},{"line_number":72,"context_line":"  vars:"},{"line_number":73,"context_line":"    service_name: \"mariadb\""},{"line_number":74,"context_line":"    service: \"{{ mariadb_services[service_name] }}\""},{"line_number":75,"context_line":"  become: true"},{"line_number":76,"context_line":"  kolla_container_facts:"},{"line_number":77,"context_line":"    name:"},{"line_number":78,"context_line":"      - \"{{ service.container_name }}\""},{"line_number":79,"context_line":"  register: initial_mariadb_container_facts"},{"line_number":80,"context_line":"  when:"},{"line_number":81,"context_line":"    - kolla_action !\u003d \"config\""},{"line_number":82,"context_line":"    - has_cluster | bool"},{"line_number":83,"context_line":"    - inventory_hostname !\u003d master_host"},{"line_number":84,"context_line":"    - not mariadb_recover | default(false)"},{"line_number":85,"context_line":"  listen: restart mariadb"},{"line_number":86,"context_line":""},{"line_number":87,"context_line":"- name: remove restart policy from slave mariadb"},{"line_number":88,"context_line":"  vars:"},{"line_number":89,"context_line":"    service_name: \"mariadb\""},{"line_number":90,"context_line":"    service: \"{{ mariadb_services[service_name] }}\""},{"line_number":91,"context_line":"  become: true"},{"line_number":92,"context_line":"  command: \"docker update --restart no {{ service.container_name }}\""},{"line_number":93,"context_line":"  when:"},{"line_number":94,"context_line":"    - kolla_action !\u003d \"config\""},{"line_number":95,"context_line":"    - has_cluster | bool"},{"line_number":96,"context_line":"    - inventory_hostname !\u003d master_host"},{"line_number":97,"context_line":"    - not mariadb_recover | default(false)"},{"line_number":98,"context_line":"    - service.container_name in initial_mariadb_container_facts"},{"line_number":99,"context_line":"  listen: restart mariadb"},{"line_number":100,"context_line":""},{"line_number":101,"context_line":"- name: shutdown slave mariadb"},{"line_number":102,"context_line":"  vars:"},{"line_number":103,"context_line":"    service_name: \"mariadb\""},{"line_number":104,"context_line":"    service: \"{{ mariadb_services[service_name] }}\""},{"line_number":105,"context_line":"  become: true"},{"line_number":106,"context_line":"  kolla_docker:"},{"line_number":107,"context_line":"    action: \"start_container\""},{"line_number":108,"context_line":"    command: \u003e-"},{"line_number":109,"context_line":"      bash -c \u0027"},{"line_number":110,"context_line":"      sudo -E kolla_set_configs \u0026\u0026"},{"line_number":111,"context_line":"      mysqladmin shutdown --host\u003d{{ api_interface_address }} --user\u003droot --password\u003d{{ database_password }}"},{"line_number":112,"context_line":"      \u0027"},{"line_number":113,"context_line":"    common_options: \"{{ docker_common_options }}\""},{"line_number":114,"context_line":"    detach: False"},{"line_number":115,"context_line":"    name: \"mariadb_shutdown\""},{"line_number":116,"context_line":"    image: \"{{ service.image }}\""},{"line_number":117,"context_line":"    volumes: \"{{ service.volumes }}\""},{"line_number":118,"context_line":"    dimensions: \"{{ service.dimensions }}\""},{"line_number":119,"context_line":"    labels:"},{"line_number":120,"context_line":"      UPGRADE:"},{"line_number":121,"context_line":"    restart_policy: \"never\""},{"line_number":122,"context_line":"  no_log: true"},{"line_number":123,"context_line":"  when:"},{"line_number":124,"context_line":"    - kolla_action !\u003d \"config\""},{"line_number":125,"context_line":"    - has_cluster | bool"},{"line_number":126,"context_line":"    - inventory_hostname !\u003d master_host"},{"line_number":127,"context_line":"    - not mariadb_recover | default(false)"},{"line_number":128,"context_line":"    - service.container_name in initial_mariadb_container_facts"},{"line_number":129,"context_line":"  listen: restart mariadb"},{"line_number":130,"context_line":""},{"line_number":131,"context_line":"- name: wait for slave mariadb shutdown"},{"line_number":132,"context_line":"  vars:"},{"line_number":133,"context_line":"    service_name: \"mariadb\""},{"line_number":134,"context_line":"    service: \"{{ mariadb_services[service_name] }}\""},{"line_number":135,"context_line":"  become: true"},{"line_number":136,"context_line":"  kolla_container_facts:"},{"line_number":137,"context_line":"    name:"},{"line_number":138,"context_line":"      - \"{{ service.container_name }}\""},{"line_number":139,"context_line":"  when:"},{"line_number":140,"context_line":"    - kolla_action !\u003d \"config\""},{"line_number":141,"context_line":"    - has_cluster | bool"},{"line_number":142,"context_line":"    - inventory_hostname !\u003d master_host"},{"line_number":143,"context_line":"    - not mariadb_recover | default(false)"},{"line_number":144,"context_line":"    - service.container_name in initial_mariadb_container_facts"},{"line_number":145,"context_line":"  listen: restart mariadb"},{"line_number":146,"context_line":"  register: mariadb_container_facts"},{"line_number":147,"context_line":"  # Don\u0027t fail if the container is still up - we will stop it in the next task."},{"line_number":148,"context_line":"  failed_when: false"},{"line_number":149,"context_line":"  until: service.container_name not in mariadb_container_facts"},{"line_number":150,"context_line":"  retries: 30"},{"line_number":151,"context_line":"  delay: 2"},{"line_number":152,"context_line":""},{"line_number":153,"context_line":"# Sometimes the mariadb service can get into a partially shutdown"},{"line_number":154,"context_line":"# state following a \u0027mysqladmin shutdown\u0027. Stop the container."},{"line_number":155,"context_line":"- name: stop mariadb slave"},{"line_number":156,"context_line":"  vars:"},{"line_number":157,"context_line":"    service_name: \"mariadb\""},{"line_number":158,"context_line":"    service: \"{{ mariadb_services[service_name] }}\""},{"line_number":159,"context_line":"  become: true"},{"line_number":160,"context_line":"  kolla_docker:"},{"line_number":161,"context_line":"    action: \"stop_container\""},{"line_number":162,"context_line":"    common_options: \"{{ docker_common_options }}\""},{"line_number":163,"context_line":"    name: \"{{ mariadb_service.container_name }}\""},{"line_number":164,"context_line":"  when:"},{"line_number":165,"context_line":"    - kolla_action !\u003d \"config\""},{"line_number":166,"context_line":"    - service.container_name in mariadb_container_facts"},{"line_number":167,"context_line":"    - has_cluster | bool"},{"line_number":168,"context_line":"    - inventory_hostname !\u003d master_host"},{"line_number":169,"context_line":"    - not mariadb_recover | default(false)"},{"line_number":170,"context_line":"    - service.container_name in initial_mariadb_container_facts"},{"line_number":171,"context_line":"  listen: restart mariadb"},{"line_number":172,"context_line":""},{"line_number":173,"context_line":"- name: replace restart policy on slave mariadb"},{"line_number":174,"context_line":"  vars:"},{"line_number":175,"context_line":"    service_name: \"mariadb\""},{"line_number":176,"context_line":"    service: \"{{ mariadb_services[service_name] }}\""},{"line_number":177,"context_line":"    restart_policy: \"{{ docker_restart_policy }}{% if docker_restart_policy \u003d\u003d \u0027on-failure\u0027 %}{{ docker_restart_policy_retry }}{% endif %}\""},{"line_number":178,"context_line":"  become: true"},{"line_number":179,"context_line":"  command: \"docker update --restart {{ restart_policy }} {{ service.container_name }}\""},{"line_number":180,"context_line":"  when:"},{"line_number":181,"context_line":"    - kolla_action !\u003d \"config\""},{"line_number":182,"context_line":"    - has_cluster | bool"},{"line_number":183,"context_line":"    - inventory_hostname !\u003d master_host"},{"line_number":184,"context_line":"    - not mariadb_recover | default(false)"},{"line_number":185,"context_line":"    - service.container_name in initial_mariadb_container_facts"},{"line_number":186,"context_line":"  listen: restart mariadb"},{"line_number":187,"context_line":""},{"line_number":188,"context_line":"- name: restart slave mariadb"},{"line_number":189,"context_line":"  vars:"},{"line_number":190,"context_line":"    service_name: \"mariadb\""},{"line_number":191,"context_line":"    service: \"{{ mariadb_services[service_name] }}\""},{"line_number":192,"context_line":"  become: true"},{"line_number":193,"context_line":"  kolla_docker:"},{"line_number":194,"context_line":"    action: \"recreate_or_restart_container\""},{"line_number":195,"context_line":"    common_options: \"{{ docker_common_options }}\""},{"line_number":196,"context_line":"    name: \"{{ service.container_name }}\""},{"line_number":197,"context_line":"    image: \"{{ service.image }}\""},{"line_number":198,"context_line":"    volumes: \"{{ service.volumes }}\""},{"line_number":199,"context_line":"    dimensions: \"{{ service.dimensions }}\""},{"line_number":200,"context_line":"  when:"},{"line_number":201,"context_line":"    - kolla_action !\u003d \"config\""},{"line_number":202,"context_line":"    - inventory_hostname !\u003d master_host"},{"line_number":203,"context_line":"    - not mariadb_recover | default(false)"},{"line_number":204,"context_line":"  listen: restart mariadb"},{"line_number":205,"context_line":""},{"line_number":206,"context_line":"# TODO(jeffrey4l), remove the task check when the wait_for bug is fixed"},{"line_number":207,"context_line":"# https://github.com/ansible/ansible-modules-core/issues/2788"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"3fa7e38b_d324c51c","side":"PARENT","line":204,"range":{"start_line":63,"start_character":0,"end_line":204,"end_character":25},"in_reply_to":"3fa7e38b_78a61058","updated":"2020-02-07 12:02:23.000000000","message":"This logic forces crash anyway if shutdown did not complete timely. I\u0027m not sure porting this has much effect on success. Recovery is supposed to recover crashed... How could we simulate the failure?","commit_id":"de2f40e680cf060bf7b3edc6e398ef69a47f9412"},{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"411200a5e6d44da292f302eba33aa223a9531d9f","unresolved":false,"context_lines":[{"line_number":60,"context_line":"    - bootstrap_host \u003d\u003d inventory_hostname"},{"line_number":61,"context_line":"  listen: Bootstrap MariaDB cluster"},{"line_number":62,"context_line":""},{"line_number":63,"context_line":"# NOTE(mgoddard): In Rocky the MariaDB image had an issue where it would not"},{"line_number":64,"context_line":"# stop on demand, and would result in Docker forcibly killing the container."},{"line_number":65,"context_line":"# This could lead to a failed upgrade if the new image is unable to recover"},{"line_number":66,"context_line":"# from the crash. See https://bugs.launchpad.net/kolla-ansible/+bug/1820325."},{"line_number":67,"context_line":"# We need to remove the restart policy from the MariaDB container to ensure"},{"line_number":68,"context_line":"# that it does not start back up after being shut down."},{"line_number":69,"context_line":"# TODO(mgoddard): Remove this task in Train."},{"line_number":70,"context_line":""},{"line_number":71,"context_line":"- name: check if slave mariadb is running"},{"line_number":72,"context_line":"  vars:"},{"line_number":73,"context_line":"    service_name: \"mariadb\""},{"line_number":74,"context_line":"    service: \"{{ mariadb_services[service_name] }}\""},{"line_number":75,"context_line":"  become: true"},{"line_number":76,"context_line":"  kolla_container_facts:"},{"line_number":77,"context_line":"    name:"},{"line_number":78,"context_line":"      - \"{{ service.container_name }}\""},{"line_number":79,"context_line":"  register: initial_mariadb_container_facts"},{"line_number":80,"context_line":"  when:"},{"line_number":81,"context_line":"    - kolla_action !\u003d \"config\""},{"line_number":82,"context_line":"    - has_cluster | bool"},{"line_number":83,"context_line":"    - inventory_hostname !\u003d master_host"},{"line_number":84,"context_line":"    - not mariadb_recover | default(false)"},{"line_number":85,"context_line":"  listen: restart mariadb"},{"line_number":86,"context_line":""},{"line_number":87,"context_line":"- name: remove restart policy from slave mariadb"},{"line_number":88,"context_line":"  vars:"},{"line_number":89,"context_line":"    service_name: \"mariadb\""},{"line_number":90,"context_line":"    service: \"{{ mariadb_services[service_name] }}\""},{"line_number":91,"context_line":"  become: true"},{"line_number":92,"context_line":"  command: \"docker update --restart no {{ service.container_name }}\""},{"line_number":93,"context_line":"  when:"},{"line_number":94,"context_line":"    - kolla_action !\u003d \"config\""},{"line_number":95,"context_line":"    - has_cluster | bool"},{"line_number":96,"context_line":"    - inventory_hostname !\u003d master_host"},{"line_number":97,"context_line":"    - not mariadb_recover | default(false)"},{"line_number":98,"context_line":"    - service.container_name in initial_mariadb_container_facts"},{"line_number":99,"context_line":"  listen: restart mariadb"},{"line_number":100,"context_line":""},{"line_number":101,"context_line":"- name: shutdown slave mariadb"},{"line_number":102,"context_line":"  vars:"},{"line_number":103,"context_line":"    service_name: \"mariadb\""},{"line_number":104,"context_line":"    service: \"{{ mariadb_services[service_name] }}\""},{"line_number":105,"context_line":"  become: true"},{"line_number":106,"context_line":"  kolla_docker:"},{"line_number":107,"context_line":"    action: \"start_container\""},{"line_number":108,"context_line":"    command: \u003e-"},{"line_number":109,"context_line":"      bash -c \u0027"},{"line_number":110,"context_line":"      sudo -E kolla_set_configs \u0026\u0026"},{"line_number":111,"context_line":"      mysqladmin shutdown --host\u003d{{ api_interface_address }} --user\u003droot --password\u003d{{ database_password }}"},{"line_number":112,"context_line":"      \u0027"},{"line_number":113,"context_line":"    common_options: \"{{ docker_common_options }}\""},{"line_number":114,"context_line":"    detach: False"},{"line_number":115,"context_line":"    name: \"mariadb_shutdown\""},{"line_number":116,"context_line":"    image: \"{{ service.image }}\""},{"line_number":117,"context_line":"    volumes: \"{{ service.volumes }}\""},{"line_number":118,"context_line":"    dimensions: \"{{ service.dimensions }}\""},{"line_number":119,"context_line":"    labels:"},{"line_number":120,"context_line":"      UPGRADE:"},{"line_number":121,"context_line":"    restart_policy: \"never\""},{"line_number":122,"context_line":"  no_log: true"},{"line_number":123,"context_line":"  when:"},{"line_number":124,"context_line":"    - kolla_action !\u003d \"config\""},{"line_number":125,"context_line":"    - has_cluster | bool"},{"line_number":126,"context_line":"    - inventory_hostname !\u003d master_host"},{"line_number":127,"context_line":"    - not mariadb_recover | default(false)"},{"line_number":128,"context_line":"    - service.container_name in initial_mariadb_container_facts"},{"line_number":129,"context_line":"  listen: restart mariadb"},{"line_number":130,"context_line":""},{"line_number":131,"context_line":"- name: wait for slave mariadb shutdown"},{"line_number":132,"context_line":"  vars:"},{"line_number":133,"context_line":"    service_name: \"mariadb\""},{"line_number":134,"context_line":"    service: \"{{ mariadb_services[service_name] }}\""},{"line_number":135,"context_line":"  become: true"},{"line_number":136,"context_line":"  kolla_container_facts:"},{"line_number":137,"context_line":"    name:"},{"line_number":138,"context_line":"      - \"{{ service.container_name }}\""},{"line_number":139,"context_line":"  when:"},{"line_number":140,"context_line":"    - kolla_action !\u003d \"config\""},{"line_number":141,"context_line":"    - has_cluster | bool"},{"line_number":142,"context_line":"    - inventory_hostname !\u003d master_host"},{"line_number":143,"context_line":"    - not mariadb_recover | default(false)"},{"line_number":144,"context_line":"    - service.container_name in initial_mariadb_container_facts"},{"line_number":145,"context_line":"  listen: restart mariadb"},{"line_number":146,"context_line":"  register: mariadb_container_facts"},{"line_number":147,"context_line":"  # Don\u0027t fail if the container is still up - we will stop it in the next task."},{"line_number":148,"context_line":"  failed_when: false"},{"line_number":149,"context_line":"  until: service.container_name not in mariadb_container_facts"},{"line_number":150,"context_line":"  retries: 30"},{"line_number":151,"context_line":"  delay: 2"},{"line_number":152,"context_line":""},{"line_number":153,"context_line":"# Sometimes the mariadb service can get into a partially shutdown"},{"line_number":154,"context_line":"# state following a \u0027mysqladmin shutdown\u0027. Stop the container."},{"line_number":155,"context_line":"- name: stop mariadb slave"},{"line_number":156,"context_line":"  vars:"},{"line_number":157,"context_line":"    service_name: \"mariadb\""},{"line_number":158,"context_line":"    service: \"{{ mariadb_services[service_name] }}\""},{"line_number":159,"context_line":"  become: true"},{"line_number":160,"context_line":"  kolla_docker:"},{"line_number":161,"context_line":"    action: \"stop_container\""},{"line_number":162,"context_line":"    common_options: \"{{ docker_common_options }}\""},{"line_number":163,"context_line":"    name: \"{{ mariadb_service.container_name }}\""},{"line_number":164,"context_line":"  when:"},{"line_number":165,"context_line":"    - kolla_action !\u003d \"config\""},{"line_number":166,"context_line":"    - service.container_name in mariadb_container_facts"},{"line_number":167,"context_line":"    - has_cluster | bool"},{"line_number":168,"context_line":"    - inventory_hostname !\u003d master_host"},{"line_number":169,"context_line":"    - not mariadb_recover | default(false)"},{"line_number":170,"context_line":"    - service.container_name in initial_mariadb_container_facts"},{"line_number":171,"context_line":"  listen: restart mariadb"},{"line_number":172,"context_line":""},{"line_number":173,"context_line":"- name: replace restart policy on slave mariadb"},{"line_number":174,"context_line":"  vars:"},{"line_number":175,"context_line":"    service_name: \"mariadb\""},{"line_number":176,"context_line":"    service: \"{{ mariadb_services[service_name] }}\""},{"line_number":177,"context_line":"    restart_policy: \"{{ docker_restart_policy }}{% if docker_restart_policy \u003d\u003d \u0027on-failure\u0027 %}{{ docker_restart_policy_retry }}{% endif %}\""},{"line_number":178,"context_line":"  become: true"},{"line_number":179,"context_line":"  command: \"docker update --restart {{ restart_policy }} {{ service.container_name }}\""},{"line_number":180,"context_line":"  when:"},{"line_number":181,"context_line":"    - kolla_action !\u003d \"config\""},{"line_number":182,"context_line":"    - has_cluster | bool"},{"line_number":183,"context_line":"    - inventory_hostname !\u003d master_host"},{"line_number":184,"context_line":"    - not mariadb_recover | default(false)"},{"line_number":185,"context_line":"    - service.container_name in initial_mariadb_container_facts"},{"line_number":186,"context_line":"  listen: restart mariadb"},{"line_number":187,"context_line":""},{"line_number":188,"context_line":"- name: restart slave mariadb"},{"line_number":189,"context_line":"  vars:"},{"line_number":190,"context_line":"    service_name: \"mariadb\""},{"line_number":191,"context_line":"    service: \"{{ mariadb_services[service_name] }}\""},{"line_number":192,"context_line":"  become: true"},{"line_number":193,"context_line":"  kolla_docker:"},{"line_number":194,"context_line":"    action: \"recreate_or_restart_container\""},{"line_number":195,"context_line":"    common_options: \"{{ docker_common_options }}\""},{"line_number":196,"context_line":"    name: \"{{ service.container_name }}\""},{"line_number":197,"context_line":"    image: \"{{ service.image }}\""},{"line_number":198,"context_line":"    volumes: \"{{ service.volumes }}\""},{"line_number":199,"context_line":"    dimensions: \"{{ service.dimensions }}\""},{"line_number":200,"context_line":"  when:"},{"line_number":201,"context_line":"    - kolla_action !\u003d \"config\""},{"line_number":202,"context_line":"    - inventory_hostname !\u003d master_host"},{"line_number":203,"context_line":"    - not mariadb_recover | default(false)"},{"line_number":204,"context_line":"  listen: restart mariadb"},{"line_number":205,"context_line":""},{"line_number":206,"context_line":"# TODO(jeffrey4l), remove the task check when the wait_for bug is fixed"},{"line_number":207,"context_line":"# https://github.com/ansible/ansible-modules-core/issues/2788"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"3fa7e38b_4d284a97","side":"PARENT","line":204,"range":{"start_line":63,"start_character":0,"end_line":204,"end_character":25},"in_reply_to":"3fa7e38b_cd3f5add","updated":"2020-02-06 12:17:15.000000000","message":"By the looks of the logs, I don\u0027t need it with new logic.","commit_id":"de2f40e680cf060bf7b3edc6e398ef69a47f9412"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"a9aa663b82ec8bd57b73f5a0383f495d2be65ce9","unresolved":false,"context_lines":[{"line_number":60,"context_line":"    - bootstrap_host \u003d\u003d inventory_hostname"},{"line_number":61,"context_line":"  listen: Bootstrap MariaDB cluster"},{"line_number":62,"context_line":""},{"line_number":63,"context_line":"# NOTE(mgoddard): In Rocky the MariaDB image had an issue where it would not"},{"line_number":64,"context_line":"# stop on demand, and would result in Docker forcibly killing the container."},{"line_number":65,"context_line":"# This could lead to a failed upgrade if the new image is unable to recover"},{"line_number":66,"context_line":"# from the crash. See https://bugs.launchpad.net/kolla-ansible/+bug/1820325."},{"line_number":67,"context_line":"# We need to remove the restart policy from the MariaDB container to ensure"},{"line_number":68,"context_line":"# that it does not start back up after being shut down."},{"line_number":69,"context_line":"# TODO(mgoddard): Remove this task in Train."},{"line_number":70,"context_line":""},{"line_number":71,"context_line":"- name: check if slave mariadb is running"},{"line_number":72,"context_line":"  vars:"},{"line_number":73,"context_line":"    service_name: \"mariadb\""},{"line_number":74,"context_line":"    service: \"{{ mariadb_services[service_name] }}\""},{"line_number":75,"context_line":"  become: true"},{"line_number":76,"context_line":"  kolla_container_facts:"},{"line_number":77,"context_line":"    name:"},{"line_number":78,"context_line":"      - \"{{ service.container_name }}\""},{"line_number":79,"context_line":"  register: initial_mariadb_container_facts"},{"line_number":80,"context_line":"  when:"},{"line_number":81,"context_line":"    - kolla_action !\u003d \"config\""},{"line_number":82,"context_line":"    - has_cluster | bool"},{"line_number":83,"context_line":"    - inventory_hostname !\u003d master_host"},{"line_number":84,"context_line":"    - not mariadb_recover | default(false)"},{"line_number":85,"context_line":"  listen: restart mariadb"},{"line_number":86,"context_line":""},{"line_number":87,"context_line":"- name: remove restart policy from slave mariadb"},{"line_number":88,"context_line":"  vars:"},{"line_number":89,"context_line":"    service_name: \"mariadb\""},{"line_number":90,"context_line":"    service: \"{{ mariadb_services[service_name] }}\""},{"line_number":91,"context_line":"  become: true"},{"line_number":92,"context_line":"  command: \"docker update --restart no {{ service.container_name }}\""},{"line_number":93,"context_line":"  when:"},{"line_number":94,"context_line":"    - kolla_action !\u003d \"config\""},{"line_number":95,"context_line":"    - has_cluster | bool"},{"line_number":96,"context_line":"    - inventory_hostname !\u003d master_host"},{"line_number":97,"context_line":"    - not mariadb_recover | default(false)"},{"line_number":98,"context_line":"    - service.container_name in initial_mariadb_container_facts"},{"line_number":99,"context_line":"  listen: restart mariadb"},{"line_number":100,"context_line":""},{"line_number":101,"context_line":"- name: shutdown slave mariadb"},{"line_number":102,"context_line":"  vars:"},{"line_number":103,"context_line":"    service_name: \"mariadb\""},{"line_number":104,"context_line":"    service: \"{{ mariadb_services[service_name] }}\""},{"line_number":105,"context_line":"  become: true"},{"line_number":106,"context_line":"  kolla_docker:"},{"line_number":107,"context_line":"    action: \"start_container\""},{"line_number":108,"context_line":"    command: \u003e-"},{"line_number":109,"context_line":"      bash -c \u0027"},{"line_number":110,"context_line":"      sudo -E kolla_set_configs \u0026\u0026"},{"line_number":111,"context_line":"      mysqladmin shutdown --host\u003d{{ api_interface_address }} --user\u003droot --password\u003d{{ database_password }}"},{"line_number":112,"context_line":"      \u0027"},{"line_number":113,"context_line":"    common_options: \"{{ docker_common_options }}\""},{"line_number":114,"context_line":"    detach: False"},{"line_number":115,"context_line":"    name: \"mariadb_shutdown\""},{"line_number":116,"context_line":"    image: \"{{ service.image }}\""},{"line_number":117,"context_line":"    volumes: \"{{ service.volumes }}\""},{"line_number":118,"context_line":"    dimensions: \"{{ service.dimensions }}\""},{"line_number":119,"context_line":"    labels:"},{"line_number":120,"context_line":"      UPGRADE:"},{"line_number":121,"context_line":"    restart_policy: \"never\""},{"line_number":122,"context_line":"  no_log: true"},{"line_number":123,"context_line":"  when:"},{"line_number":124,"context_line":"    - kolla_action !\u003d \"config\""},{"line_number":125,"context_line":"    - has_cluster | bool"},{"line_number":126,"context_line":"    - inventory_hostname !\u003d master_host"},{"line_number":127,"context_line":"    - not mariadb_recover | default(false)"},{"line_number":128,"context_line":"    - service.container_name in initial_mariadb_container_facts"},{"line_number":129,"context_line":"  listen: restart mariadb"},{"line_number":130,"context_line":""},{"line_number":131,"context_line":"- name: wait for slave mariadb shutdown"},{"line_number":132,"context_line":"  vars:"},{"line_number":133,"context_line":"    service_name: \"mariadb\""},{"line_number":134,"context_line":"    service: \"{{ mariadb_services[service_name] }}\""},{"line_number":135,"context_line":"  become: true"},{"line_number":136,"context_line":"  kolla_container_facts:"},{"line_number":137,"context_line":"    name:"},{"line_number":138,"context_line":"      - \"{{ service.container_name }}\""},{"line_number":139,"context_line":"  when:"},{"line_number":140,"context_line":"    - kolla_action !\u003d \"config\""},{"line_number":141,"context_line":"    - has_cluster | bool"},{"line_number":142,"context_line":"    - inventory_hostname !\u003d master_host"},{"line_number":143,"context_line":"    - not mariadb_recover | default(false)"},{"line_number":144,"context_line":"    - service.container_name in initial_mariadb_container_facts"},{"line_number":145,"context_line":"  listen: restart mariadb"},{"line_number":146,"context_line":"  register: mariadb_container_facts"},{"line_number":147,"context_line":"  # Don\u0027t fail if the container is still up - we will stop it in the next task."},{"line_number":148,"context_line":"  failed_when: false"},{"line_number":149,"context_line":"  until: service.container_name not in mariadb_container_facts"},{"line_number":150,"context_line":"  retries: 30"},{"line_number":151,"context_line":"  delay: 2"},{"line_number":152,"context_line":""},{"line_number":153,"context_line":"# Sometimes the mariadb service can get into a partially shutdown"},{"line_number":154,"context_line":"# state following a \u0027mysqladmin shutdown\u0027. Stop the container."},{"line_number":155,"context_line":"- name: stop mariadb slave"},{"line_number":156,"context_line":"  vars:"},{"line_number":157,"context_line":"    service_name: \"mariadb\""},{"line_number":158,"context_line":"    service: \"{{ mariadb_services[service_name] }}\""},{"line_number":159,"context_line":"  become: true"},{"line_number":160,"context_line":"  kolla_docker:"},{"line_number":161,"context_line":"    action: \"stop_container\""},{"line_number":162,"context_line":"    common_options: \"{{ docker_common_options }}\""},{"line_number":163,"context_line":"    name: \"{{ mariadb_service.container_name }}\""},{"line_number":164,"context_line":"  when:"},{"line_number":165,"context_line":"    - kolla_action !\u003d \"config\""},{"line_number":166,"context_line":"    - service.container_name in mariadb_container_facts"},{"line_number":167,"context_line":"    - has_cluster | bool"},{"line_number":168,"context_line":"    - inventory_hostname !\u003d master_host"},{"line_number":169,"context_line":"    - not mariadb_recover | default(false)"},{"line_number":170,"context_line":"    - service.container_name in initial_mariadb_container_facts"},{"line_number":171,"context_line":"  listen: restart mariadb"},{"line_number":172,"context_line":""},{"line_number":173,"context_line":"- name: replace restart policy on slave mariadb"},{"line_number":174,"context_line":"  vars:"},{"line_number":175,"context_line":"    service_name: \"mariadb\""},{"line_number":176,"context_line":"    service: \"{{ mariadb_services[service_name] }}\""},{"line_number":177,"context_line":"    restart_policy: \"{{ docker_restart_policy }}{% if docker_restart_policy \u003d\u003d \u0027on-failure\u0027 %}{{ docker_restart_policy_retry }}{% endif %}\""},{"line_number":178,"context_line":"  become: true"},{"line_number":179,"context_line":"  command: \"docker update --restart {{ restart_policy }} {{ service.container_name }}\""},{"line_number":180,"context_line":"  when:"},{"line_number":181,"context_line":"    - kolla_action !\u003d \"config\""},{"line_number":182,"context_line":"    - has_cluster | bool"},{"line_number":183,"context_line":"    - inventory_hostname !\u003d master_host"},{"line_number":184,"context_line":"    - not mariadb_recover | default(false)"},{"line_number":185,"context_line":"    - service.container_name in initial_mariadb_container_facts"},{"line_number":186,"context_line":"  listen: restart mariadb"},{"line_number":187,"context_line":""},{"line_number":188,"context_line":"- name: restart slave mariadb"},{"line_number":189,"context_line":"  vars:"},{"line_number":190,"context_line":"    service_name: \"mariadb\""},{"line_number":191,"context_line":"    service: \"{{ mariadb_services[service_name] }}\""},{"line_number":192,"context_line":"  become: true"},{"line_number":193,"context_line":"  kolla_docker:"},{"line_number":194,"context_line":"    action: \"recreate_or_restart_container\""},{"line_number":195,"context_line":"    common_options: \"{{ docker_common_options }}\""},{"line_number":196,"context_line":"    name: \"{{ service.container_name }}\""},{"line_number":197,"context_line":"    image: \"{{ service.image }}\""},{"line_number":198,"context_line":"    volumes: \"{{ service.volumes }}\""},{"line_number":199,"context_line":"    dimensions: \"{{ service.dimensions }}\""},{"line_number":200,"context_line":"  when:"},{"line_number":201,"context_line":"    - kolla_action !\u003d \"config\""},{"line_number":202,"context_line":"    - inventory_hostname !\u003d master_host"},{"line_number":203,"context_line":"    - not mariadb_recover | default(false)"},{"line_number":204,"context_line":"  listen: restart mariadb"},{"line_number":205,"context_line":""},{"line_number":206,"context_line":"# TODO(jeffrey4l), remove the task check when the wait_for bug is fixed"},{"line_number":207,"context_line":"# https://github.com/ansible/ansible-modules-core/issues/2788"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"3fa7e38b_fa3671b3","side":"PARENT","line":204,"range":{"start_line":63,"start_character":0,"end_line":204,"end_character":25},"in_reply_to":"3fa7e38b_d324c51c","updated":"2020-02-07 15:20:26.000000000","message":"You\u0027d need to test upgrading from a rocky image without the dumb-init fix. 45d0ad5041b4b833da48c7842784197660044325","commit_id":"de2f40e680cf060bf7b3edc6e398ef69a47f9412"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"8e97444beef34e0886e6bb255c892f73ae72d6f1","unresolved":false,"context_lines":[{"line_number":60,"context_line":"    - bootstrap_host \u003d\u003d inventory_hostname"},{"line_number":61,"context_line":"  listen: Bootstrap MariaDB cluster"},{"line_number":62,"context_line":""},{"line_number":63,"context_line":"# NOTE(mgoddard): In Rocky the MariaDB image had an issue where it would not"},{"line_number":64,"context_line":"# stop on demand, and would result in Docker forcibly killing the container."},{"line_number":65,"context_line":"# This could lead to a failed upgrade if the new image is unable to recover"},{"line_number":66,"context_line":"# from the crash. See https://bugs.launchpad.net/kolla-ansible/+bug/1820325."},{"line_number":67,"context_line":"# We need to remove the restart policy from the MariaDB container to ensure"},{"line_number":68,"context_line":"# that it does not start back up after being shut down."},{"line_number":69,"context_line":"# TODO(mgoddard): Remove this task in Train."},{"line_number":70,"context_line":""},{"line_number":71,"context_line":"- name: check if slave mariadb is running"},{"line_number":72,"context_line":"  vars:"},{"line_number":73,"context_line":"    service_name: \"mariadb\""},{"line_number":74,"context_line":"    service: \"{{ mariadb_services[service_name] }}\""},{"line_number":75,"context_line":"  become: true"},{"line_number":76,"context_line":"  kolla_container_facts:"},{"line_number":77,"context_line":"    name:"},{"line_number":78,"context_line":"      - \"{{ service.container_name }}\""},{"line_number":79,"context_line":"  register: initial_mariadb_container_facts"},{"line_number":80,"context_line":"  when:"},{"line_number":81,"context_line":"    - kolla_action !\u003d \"config\""},{"line_number":82,"context_line":"    - has_cluster | bool"},{"line_number":83,"context_line":"    - inventory_hostname !\u003d master_host"},{"line_number":84,"context_line":"    - not mariadb_recover | default(false)"},{"line_number":85,"context_line":"  listen: restart mariadb"},{"line_number":86,"context_line":""},{"line_number":87,"context_line":"- name: remove restart policy from slave mariadb"},{"line_number":88,"context_line":"  vars:"},{"line_number":89,"context_line":"    service_name: \"mariadb\""},{"line_number":90,"context_line":"    service: \"{{ mariadb_services[service_name] }}\""},{"line_number":91,"context_line":"  become: true"},{"line_number":92,"context_line":"  command: \"docker update --restart no {{ service.container_name }}\""},{"line_number":93,"context_line":"  when:"},{"line_number":94,"context_line":"    - kolla_action !\u003d \"config\""},{"line_number":95,"context_line":"    - has_cluster | bool"},{"line_number":96,"context_line":"    - inventory_hostname !\u003d master_host"},{"line_number":97,"context_line":"    - not mariadb_recover | default(false)"},{"line_number":98,"context_line":"    - service.container_name in initial_mariadb_container_facts"},{"line_number":99,"context_line":"  listen: restart mariadb"},{"line_number":100,"context_line":""},{"line_number":101,"context_line":"- name: shutdown slave mariadb"},{"line_number":102,"context_line":"  vars:"},{"line_number":103,"context_line":"    service_name: \"mariadb\""},{"line_number":104,"context_line":"    service: \"{{ mariadb_services[service_name] }}\""},{"line_number":105,"context_line":"  become: true"},{"line_number":106,"context_line":"  kolla_docker:"},{"line_number":107,"context_line":"    action: \"start_container\""},{"line_number":108,"context_line":"    command: \u003e-"},{"line_number":109,"context_line":"      bash -c \u0027"},{"line_number":110,"context_line":"      sudo -E kolla_set_configs \u0026\u0026"},{"line_number":111,"context_line":"      mysqladmin shutdown --host\u003d{{ api_interface_address }} --user\u003droot --password\u003d{{ database_password }}"},{"line_number":112,"context_line":"      \u0027"},{"line_number":113,"context_line":"    common_options: \"{{ docker_common_options }}\""},{"line_number":114,"context_line":"    detach: False"},{"line_number":115,"context_line":"    name: \"mariadb_shutdown\""},{"line_number":116,"context_line":"    image: \"{{ service.image }}\""},{"line_number":117,"context_line":"    volumes: \"{{ service.volumes }}\""},{"line_number":118,"context_line":"    dimensions: \"{{ service.dimensions }}\""},{"line_number":119,"context_line":"    labels:"},{"line_number":120,"context_line":"      UPGRADE:"},{"line_number":121,"context_line":"    restart_policy: \"never\""},{"line_number":122,"context_line":"  no_log: true"},{"line_number":123,"context_line":"  when:"},{"line_number":124,"context_line":"    - kolla_action !\u003d \"config\""},{"line_number":125,"context_line":"    - has_cluster | bool"},{"line_number":126,"context_line":"    - inventory_hostname !\u003d master_host"},{"line_number":127,"context_line":"    - not mariadb_recover | default(false)"},{"line_number":128,"context_line":"    - service.container_name in initial_mariadb_container_facts"},{"line_number":129,"context_line":"  listen: restart mariadb"},{"line_number":130,"context_line":""},{"line_number":131,"context_line":"- name: wait for slave mariadb shutdown"},{"line_number":132,"context_line":"  vars:"},{"line_number":133,"context_line":"    service_name: \"mariadb\""},{"line_number":134,"context_line":"    service: \"{{ mariadb_services[service_name] }}\""},{"line_number":135,"context_line":"  become: true"},{"line_number":136,"context_line":"  kolla_container_facts:"},{"line_number":137,"context_line":"    name:"},{"line_number":138,"context_line":"      - \"{{ service.container_name }}\""},{"line_number":139,"context_line":"  when:"},{"line_number":140,"context_line":"    - kolla_action !\u003d \"config\""},{"line_number":141,"context_line":"    - has_cluster | bool"},{"line_number":142,"context_line":"    - inventory_hostname !\u003d master_host"},{"line_number":143,"context_line":"    - not mariadb_recover | default(false)"},{"line_number":144,"context_line":"    - service.container_name in initial_mariadb_container_facts"},{"line_number":145,"context_line":"  listen: restart mariadb"},{"line_number":146,"context_line":"  register: mariadb_container_facts"},{"line_number":147,"context_line":"  # Don\u0027t fail if the container is still up - we will stop it in the next task."},{"line_number":148,"context_line":"  failed_when: false"},{"line_number":149,"context_line":"  until: service.container_name not in mariadb_container_facts"},{"line_number":150,"context_line":"  retries: 30"},{"line_number":151,"context_line":"  delay: 2"},{"line_number":152,"context_line":""},{"line_number":153,"context_line":"# Sometimes the mariadb service can get into a partially shutdown"},{"line_number":154,"context_line":"# state following a \u0027mysqladmin shutdown\u0027. Stop the container."},{"line_number":155,"context_line":"- name: stop mariadb slave"},{"line_number":156,"context_line":"  vars:"},{"line_number":157,"context_line":"    service_name: \"mariadb\""},{"line_number":158,"context_line":"    service: \"{{ mariadb_services[service_name] }}\""},{"line_number":159,"context_line":"  become: true"},{"line_number":160,"context_line":"  kolla_docker:"},{"line_number":161,"context_line":"    action: \"stop_container\""},{"line_number":162,"context_line":"    common_options: \"{{ docker_common_options }}\""},{"line_number":163,"context_line":"    name: \"{{ mariadb_service.container_name }}\""},{"line_number":164,"context_line":"  when:"},{"line_number":165,"context_line":"    - kolla_action !\u003d \"config\""},{"line_number":166,"context_line":"    - service.container_name in mariadb_container_facts"},{"line_number":167,"context_line":"    - has_cluster | bool"},{"line_number":168,"context_line":"    - inventory_hostname !\u003d master_host"},{"line_number":169,"context_line":"    - not mariadb_recover | default(false)"},{"line_number":170,"context_line":"    - service.container_name in initial_mariadb_container_facts"},{"line_number":171,"context_line":"  listen: restart mariadb"},{"line_number":172,"context_line":""},{"line_number":173,"context_line":"- name: replace restart policy on slave mariadb"},{"line_number":174,"context_line":"  vars:"},{"line_number":175,"context_line":"    service_name: \"mariadb\""},{"line_number":176,"context_line":"    service: \"{{ mariadb_services[service_name] }}\""},{"line_number":177,"context_line":"    restart_policy: \"{{ docker_restart_policy }}{% if docker_restart_policy \u003d\u003d \u0027on-failure\u0027 %}{{ docker_restart_policy_retry }}{% endif %}\""},{"line_number":178,"context_line":"  become: true"},{"line_number":179,"context_line":"  command: \"docker update --restart {{ restart_policy }} {{ service.container_name }}\""},{"line_number":180,"context_line":"  when:"},{"line_number":181,"context_line":"    - kolla_action !\u003d \"config\""},{"line_number":182,"context_line":"    - has_cluster | bool"},{"line_number":183,"context_line":"    - inventory_hostname !\u003d master_host"},{"line_number":184,"context_line":"    - not mariadb_recover | default(false)"},{"line_number":185,"context_line":"    - service.container_name in initial_mariadb_container_facts"},{"line_number":186,"context_line":"  listen: restart mariadb"},{"line_number":187,"context_line":""},{"line_number":188,"context_line":"- name: restart slave mariadb"},{"line_number":189,"context_line":"  vars:"},{"line_number":190,"context_line":"    service_name: \"mariadb\""},{"line_number":191,"context_line":"    service: \"{{ mariadb_services[service_name] }}\""},{"line_number":192,"context_line":"  become: true"},{"line_number":193,"context_line":"  kolla_docker:"},{"line_number":194,"context_line":"    action: \"recreate_or_restart_container\""},{"line_number":195,"context_line":"    common_options: \"{{ docker_common_options }}\""},{"line_number":196,"context_line":"    name: \"{{ service.container_name }}\""},{"line_number":197,"context_line":"    image: \"{{ service.image }}\""},{"line_number":198,"context_line":"    volumes: \"{{ service.volumes }}\""},{"line_number":199,"context_line":"    dimensions: \"{{ service.dimensions }}\""},{"line_number":200,"context_line":"  when:"},{"line_number":201,"context_line":"    - kolla_action !\u003d \"config\""},{"line_number":202,"context_line":"    - inventory_hostname !\u003d master_host"},{"line_number":203,"context_line":"    - not mariadb_recover | default(false)"},{"line_number":204,"context_line":"  listen: restart mariadb"},{"line_number":205,"context_line":""},{"line_number":206,"context_line":"# TODO(jeffrey4l), remove the task check when the wait_for bug is fixed"},{"line_number":207,"context_line":"# https://github.com/ansible/ansible-modules-core/issues/2788"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"3fa7e38b_78a61058","side":"PARENT","line":204,"range":{"start_line":63,"start_character":0,"end_line":204,"end_character":25},"in_reply_to":"3fa7e38b_e650330c","updated":"2020-02-07 10:51:06.000000000","message":"They don\u0027t recover because they crash, and the DB format is not recoverable after upgrade. Let\u0027s not undo changes that took a long time to get right.","commit_id":"de2f40e680cf060bf7b3edc6e398ef69a47f9412"},{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"b85f493986bd490a5ef6888177b47508c4bd7a65","unresolved":false,"context_lines":[{"line_number":60,"context_line":"    - bootstrap_host \u003d\u003d inventory_hostname"},{"line_number":61,"context_line":"  listen: Bootstrap MariaDB cluster"},{"line_number":62,"context_line":""},{"line_number":63,"context_line":"# NOTE(mgoddard): In Rocky the MariaDB image had an issue where it would not"},{"line_number":64,"context_line":"# stop on demand, and would result in Docker forcibly killing the container."},{"line_number":65,"context_line":"# This could lead to a failed upgrade if the new image is unable to recover"},{"line_number":66,"context_line":"# from the crash. See https://bugs.launchpad.net/kolla-ansible/+bug/1820325."},{"line_number":67,"context_line":"# We need to remove the restart policy from the MariaDB container to ensure"},{"line_number":68,"context_line":"# that it does not start back up after being shut down."},{"line_number":69,"context_line":"# TODO(mgoddard): Remove this task in Train."},{"line_number":70,"context_line":""},{"line_number":71,"context_line":"- name: check if slave mariadb is running"},{"line_number":72,"context_line":"  vars:"},{"line_number":73,"context_line":"    service_name: \"mariadb\""},{"line_number":74,"context_line":"    service: \"{{ mariadb_services[service_name] }}\""},{"line_number":75,"context_line":"  become: true"},{"line_number":76,"context_line":"  kolla_container_facts:"},{"line_number":77,"context_line":"    name:"},{"line_number":78,"context_line":"      - \"{{ service.container_name }}\""},{"line_number":79,"context_line":"  register: initial_mariadb_container_facts"},{"line_number":80,"context_line":"  when:"},{"line_number":81,"context_line":"    - kolla_action !\u003d \"config\""},{"line_number":82,"context_line":"    - has_cluster | bool"},{"line_number":83,"context_line":"    - inventory_hostname !\u003d master_host"},{"line_number":84,"context_line":"    - not mariadb_recover | default(false)"},{"line_number":85,"context_line":"  listen: restart mariadb"},{"line_number":86,"context_line":""},{"line_number":87,"context_line":"- name: remove restart policy from slave mariadb"},{"line_number":88,"context_line":"  vars:"},{"line_number":89,"context_line":"    service_name: \"mariadb\""},{"line_number":90,"context_line":"    service: \"{{ mariadb_services[service_name] }}\""},{"line_number":91,"context_line":"  become: true"},{"line_number":92,"context_line":"  command: \"docker update --restart no {{ service.container_name }}\""},{"line_number":93,"context_line":"  when:"},{"line_number":94,"context_line":"    - kolla_action !\u003d \"config\""},{"line_number":95,"context_line":"    - has_cluster | bool"},{"line_number":96,"context_line":"    - inventory_hostname !\u003d master_host"},{"line_number":97,"context_line":"    - not mariadb_recover | default(false)"},{"line_number":98,"context_line":"    - service.container_name in initial_mariadb_container_facts"},{"line_number":99,"context_line":"  listen: restart mariadb"},{"line_number":100,"context_line":""},{"line_number":101,"context_line":"- name: shutdown slave mariadb"},{"line_number":102,"context_line":"  vars:"},{"line_number":103,"context_line":"    service_name: \"mariadb\""},{"line_number":104,"context_line":"    service: \"{{ mariadb_services[service_name] }}\""},{"line_number":105,"context_line":"  become: true"},{"line_number":106,"context_line":"  kolla_docker:"},{"line_number":107,"context_line":"    action: \"start_container\""},{"line_number":108,"context_line":"    command: \u003e-"},{"line_number":109,"context_line":"      bash -c \u0027"},{"line_number":110,"context_line":"      sudo -E kolla_set_configs \u0026\u0026"},{"line_number":111,"context_line":"      mysqladmin shutdown --host\u003d{{ api_interface_address }} --user\u003droot --password\u003d{{ database_password }}"},{"line_number":112,"context_line":"      \u0027"},{"line_number":113,"context_line":"    common_options: \"{{ docker_common_options }}\""},{"line_number":114,"context_line":"    detach: False"},{"line_number":115,"context_line":"    name: \"mariadb_shutdown\""},{"line_number":116,"context_line":"    image: \"{{ service.image }}\""},{"line_number":117,"context_line":"    volumes: \"{{ service.volumes }}\""},{"line_number":118,"context_line":"    dimensions: \"{{ service.dimensions }}\""},{"line_number":119,"context_line":"    labels:"},{"line_number":120,"context_line":"      UPGRADE:"},{"line_number":121,"context_line":"    restart_policy: \"never\""},{"line_number":122,"context_line":"  no_log: true"},{"line_number":123,"context_line":"  when:"},{"line_number":124,"context_line":"    - kolla_action !\u003d \"config\""},{"line_number":125,"context_line":"    - has_cluster | bool"},{"line_number":126,"context_line":"    - inventory_hostname !\u003d master_host"},{"line_number":127,"context_line":"    - not mariadb_recover | default(false)"},{"line_number":128,"context_line":"    - service.container_name in initial_mariadb_container_facts"},{"line_number":129,"context_line":"  listen: restart mariadb"},{"line_number":130,"context_line":""},{"line_number":131,"context_line":"- name: wait for slave mariadb shutdown"},{"line_number":132,"context_line":"  vars:"},{"line_number":133,"context_line":"    service_name: \"mariadb\""},{"line_number":134,"context_line":"    service: \"{{ mariadb_services[service_name] }}\""},{"line_number":135,"context_line":"  become: true"},{"line_number":136,"context_line":"  kolla_container_facts:"},{"line_number":137,"context_line":"    name:"},{"line_number":138,"context_line":"      - \"{{ service.container_name }}\""},{"line_number":139,"context_line":"  when:"},{"line_number":140,"context_line":"    - kolla_action !\u003d \"config\""},{"line_number":141,"context_line":"    - has_cluster | bool"},{"line_number":142,"context_line":"    - inventory_hostname !\u003d master_host"},{"line_number":143,"context_line":"    - not mariadb_recover | default(false)"},{"line_number":144,"context_line":"    - service.container_name in initial_mariadb_container_facts"},{"line_number":145,"context_line":"  listen: restart mariadb"},{"line_number":146,"context_line":"  register: mariadb_container_facts"},{"line_number":147,"context_line":"  # Don\u0027t fail if the container is still up - we will stop it in the next task."},{"line_number":148,"context_line":"  failed_when: false"},{"line_number":149,"context_line":"  until: service.container_name not in mariadb_container_facts"},{"line_number":150,"context_line":"  retries: 30"},{"line_number":151,"context_line":"  delay: 2"},{"line_number":152,"context_line":""},{"line_number":153,"context_line":"# Sometimes the mariadb service can get into a partially shutdown"},{"line_number":154,"context_line":"# state following a \u0027mysqladmin shutdown\u0027. Stop the container."},{"line_number":155,"context_line":"- name: stop mariadb slave"},{"line_number":156,"context_line":"  vars:"},{"line_number":157,"context_line":"    service_name: \"mariadb\""},{"line_number":158,"context_line":"    service: \"{{ mariadb_services[service_name] }}\""},{"line_number":159,"context_line":"  become: true"},{"line_number":160,"context_line":"  kolla_docker:"},{"line_number":161,"context_line":"    action: \"stop_container\""},{"line_number":162,"context_line":"    common_options: \"{{ docker_common_options }}\""},{"line_number":163,"context_line":"    name: \"{{ mariadb_service.container_name }}\""},{"line_number":164,"context_line":"  when:"},{"line_number":165,"context_line":"    - kolla_action !\u003d \"config\""},{"line_number":166,"context_line":"    - service.container_name in mariadb_container_facts"},{"line_number":167,"context_line":"    - has_cluster | bool"},{"line_number":168,"context_line":"    - inventory_hostname !\u003d master_host"},{"line_number":169,"context_line":"    - not mariadb_recover | default(false)"},{"line_number":170,"context_line":"    - service.container_name in initial_mariadb_container_facts"},{"line_number":171,"context_line":"  listen: restart mariadb"},{"line_number":172,"context_line":""},{"line_number":173,"context_line":"- name: replace restart policy on slave mariadb"},{"line_number":174,"context_line":"  vars:"},{"line_number":175,"context_line":"    service_name: \"mariadb\""},{"line_number":176,"context_line":"    service: \"{{ mariadb_services[service_name] }}\""},{"line_number":177,"context_line":"    restart_policy: \"{{ docker_restart_policy }}{% if docker_restart_policy \u003d\u003d \u0027on-failure\u0027 %}{{ docker_restart_policy_retry }}{% endif %}\""},{"line_number":178,"context_line":"  become: true"},{"line_number":179,"context_line":"  command: \"docker update --restart {{ restart_policy }} {{ service.container_name }}\""},{"line_number":180,"context_line":"  when:"},{"line_number":181,"context_line":"    - kolla_action !\u003d \"config\""},{"line_number":182,"context_line":"    - has_cluster | bool"},{"line_number":183,"context_line":"    - inventory_hostname !\u003d master_host"},{"line_number":184,"context_line":"    - not mariadb_recover | default(false)"},{"line_number":185,"context_line":"    - service.container_name in initial_mariadb_container_facts"},{"line_number":186,"context_line":"  listen: restart mariadb"},{"line_number":187,"context_line":""},{"line_number":188,"context_line":"- name: restart slave mariadb"},{"line_number":189,"context_line":"  vars:"},{"line_number":190,"context_line":"    service_name: \"mariadb\""},{"line_number":191,"context_line":"    service: \"{{ mariadb_services[service_name] }}\""},{"line_number":192,"context_line":"  become: true"},{"line_number":193,"context_line":"  kolla_docker:"},{"line_number":194,"context_line":"    action: \"recreate_or_restart_container\""},{"line_number":195,"context_line":"    common_options: \"{{ docker_common_options }}\""},{"line_number":196,"context_line":"    name: \"{{ service.container_name }}\""},{"line_number":197,"context_line":"    image: \"{{ service.image }}\""},{"line_number":198,"context_line":"    volumes: \"{{ service.volumes }}\""},{"line_number":199,"context_line":"    dimensions: \"{{ service.dimensions }}\""},{"line_number":200,"context_line":"  when:"},{"line_number":201,"context_line":"    - kolla_action !\u003d \"config\""},{"line_number":202,"context_line":"    - inventory_hostname !\u003d master_host"},{"line_number":203,"context_line":"    - not mariadb_recover | default(false)"},{"line_number":204,"context_line":"  listen: restart mariadb"},{"line_number":205,"context_line":""},{"line_number":206,"context_line":"# TODO(jeffrey4l), remove the task check when the wait_for bug is fixed"},{"line_number":207,"context_line":"# https://github.com/ansible/ansible-modules-core/issues/2788"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"3fa7e38b_e650330c","side":"PARENT","line":204,"range":{"start_line":63,"start_character":0,"end_line":204,"end_character":25},"in_reply_to":"3fa7e38b_eb3a3e95","updated":"2020-02-06 14:16:56.000000000","message":"Ah, indeed. Though timeout will still kill them and recover. I see no bad in this.","commit_id":"de2f40e680cf060bf7b3edc6e398ef69a47f9412"}]}