)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":167,"name":"Christian Berendt","email":"berendt@osism.tech","username":"berendt"},"change_message_id":"29b3e4ad1f28a0eb0c0b7696c9a054b924a0f33f","unresolved":false,"context_lines":[{"line_number":13,"context_line":"Partially-Implements: blueprint add-ssl-internal-network"},{"line_number":14,"context_line":"Change-Id: Ib512ba20724b95e299beb829af493db6e5465797"},{"line_number":15,"context_line":"Signed-off-by: yj.bai \u003cbai.yongjun@99cloud.net\u003e"},{"line_number":16,"context_line":"(cherry picked from commit b8b43366074160a94fecb58114a6986f0b65270f)"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":15,"id":"3fa7e38b_e8860416","line":16,"updated":"2020-02-19 09:47:45.000000000","message":"This makes no sense to me.","commit_id":"555eceb4b2d86b2b1502a5f5568fe4c39aa4f332"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"60fbfc6443a81ff48c0cbdf14640c2d751d94f4f","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Add support for encrypting glance/heat api"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"1. Add tls for glance api and heat api."},{"line_number":10,"context_line":"2. Change heat api container user form heat to root for use httpd."},{"line_number":11,"context_line":"3. Add heat wsgi config file for use httpd."},{"line_number":12,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":33,"id":"1f493fa4_902778b7","line":9,"range":{"start_line":9,"start_character":7,"end_line":9,"end_character":10},"updated":"2020-04-21 11:15:39.000000000","message":"TLS backend","commit_id":"7b1be3e548c63b97ce645bd600a00587762e991b"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"60fbfc6443a81ff48c0cbdf14640c2d751d94f4f","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Add support for encrypting glance/heat api"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"1. Add tls for glance api and heat api."},{"line_number":10,"context_line":"2. Change heat api container user form heat to root for use httpd."},{"line_number":11,"context_line":"3. Add heat wsgi config file for use httpd."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Partially-Implements: blueprint add-ssl-internal-network"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":33,"id":"1f493fa4_702c6c99","line":10,"range":{"start_line":10,"start_character":0,"end_line":10,"end_character":66},"updated":"2020-04-21 11:15:39.000000000","message":"Not doing this","commit_id":"7b1be3e548c63b97ce645bd600a00587762e991b"}],"ansible/group_vars/all.yml":[{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"39cbe641e99a5485a38b07b775f3f159f0c83ed2","unresolved":false,"context_lines":[{"line_number":269,"context_line":"glance_external_fqdn: \"{{ kolla_external_fqdn }}\""},{"line_number":270,"context_line":"glance_api_port: \"9292\""},{"line_number":271,"context_line":"glance_api_listen_port: \"{{ glance_api_port }}\""},{"line_number":272,"context_line":"glance_api_no_proxy_listen_port: \"9293\""},{"line_number":273,"context_line":""},{"line_number":274,"context_line":"gnocchi_internal_fqdn: \"{{ kolla_internal_fqdn }}\""},{"line_number":275,"context_line":"gnocchi_external_fqdn: \"{{ kolla_external_fqdn }}\""}],"source_content_type":"text/x-yaml","patch_set":32,"id":"1f493fa4_a4908850","line":272,"range":{"start_line":272,"start_character":0,"end_line":272,"end_character":39},"updated":"2020-04-20 18:31:44.000000000","message":"Could we just make it listen on localhost?","commit_id":"92564fc73b62d39387744c95e9beb813a1a965a1"}],"ansible/roles/glance/defaults/main.yml":[{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"759390785add35bafe1144ce8f1668d6623c2a05","unresolved":false,"context_lines":[{"line_number":13,"context_line":"    volumes: \"{{ glance_api_default_volumes + glance_api_extra_volumes }}\""},{"line_number":14,"context_line":"    dimensions: \"{{ glance_api_dimensions }}\""},{"line_number":15,"context_line":"    haproxy:"},{"line_number":16,"context_line":"      glance_api:"},{"line_number":17,"context_line":"        enabled: \"{{ enable_glance }}\""},{"line_number":18,"context_line":"        mode: \"http\""},{"line_number":19,"context_line":"        external: false"},{"line_number":20,"context_line":"        port: \"{{ glance_api_port }}\""},{"line_number":21,"context_line":"        frontend_http_extra:"},{"line_number":22,"context_line":"          - \"timeout client {{ haproxy_glance_api_client_timeout }}\""},{"line_number":23,"context_line":"        backend_http_extra:"},{"line_number":24,"context_line":"          - \"timeout server {{ haproxy_glance_api_server_timeout }}\""},{"line_number":25,"context_line":"        custom_member_list: \"{% if kolla_enable_tls_backend | bool %}{{ haproxy_tls_members.split(\u0027;\u0027) }}{% else %}{{ haproxy_members.split(\u0027;\u0027) }}{% endif %}\""},{"line_number":26,"context_line":"      glance_api_external:"},{"line_number":27,"context_line":"        enabled: \"{{ enable_glance }}\""},{"line_number":28,"context_line":"        mode: \"http\""},{"line_number":29,"context_line":"        external: true"},{"line_number":30,"context_line":"        port: \"{{ glance_api_port }}\""},{"line_number":31,"context_line":"        frontend_http_extra:"},{"line_number":32,"context_line":"          - \"timeout client {{ haproxy_glance_api_client_timeout }}\""},{"line_number":33,"context_line":"        backend_http_extra:"},{"line_number":34,"context_line":"          - \"timeout server {{ haproxy_glance_api_server_timeout }}\""},{"line_number":35,"context_line":"        custom_member_list: \"{{ haproxy_members.split(\u0027;\u0027) }}\""},{"line_number":36,"context_line":""},{"line_number":37,"context_line":""},{"line_number":38,"context_line":"####################"}],"source_content_type":"text/x-yaml","patch_set":25,"id":"3f4c43b2_00cc9fba","line":35,"range":{"start_line":16,"start_character":0,"end_line":35,"end_character":62},"updated":"2020-04-14 13:46:11.000000000","message":"Need tls_backend in these two","commit_id":"6607a547cdf5abbeaef785baed5d03d9ffa8220e"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"9d452cbb6582cf6a777555c9386fd417660e5c96","unresolved":false,"context_lines":[{"line_number":39,"context_line":"# HAProxy"},{"line_number":40,"context_line":"####################"},{"line_number":41,"context_line":"haproxy_members: \"{% for host in glance_api_hosts %}server {{ hostvars[host][\u0027ansible_hostname\u0027] }} {{ \u0027api\u0027 | kolla_address(host) }}:{{ glance_api_listen_port }} check inter 2000 rise 2 fall 5;{% endfor %}\""},{"line_number":42,"context_line":"haproxy_tls_members: \"{% for host in glance_api_hosts %}server {{ hostvars[host][\u0027ansible_hostname\u0027] }} {{ \u0027api\u0027 | kolla_address(host) }}:{{ glance_api_listen_port }} check inter 2000 rise 2 fall 5 ssl verify required ca-file {{ kolla_internal_fqdn_cacert }};{% endfor %}\""},{"line_number":43,"context_line":""},{"line_number":44,"context_line":"####################"},{"line_number":45,"context_line":"# Keystone"}],"source_content_type":"text/x-yaml","patch_set":25,"id":"3f4c43b2_bdd23433","line":42,"range":{"start_line":42,"start_character":229,"end_line":42,"end_character":255},"updated":"2020-04-14 13:42:21.000000000","message":"haproxy_backend_cacert","commit_id":"6607a547cdf5abbeaef785baed5d03d9ffa8220e"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"9d452cbb6582cf6a777555c9386fd417660e5c96","unresolved":false,"context_lines":[{"line_number":170,"context_line":"####################"},{"line_number":171,"context_line":"# TLS"},{"line_number":172,"context_line":"####################"},{"line_number":173,"context_line":"glance_tls_backend_enabled: \"{{ kolla_enable_tls_backend }}\""}],"source_content_type":"text/x-yaml","patch_set":25,"id":"3f4c43b2_dde10001","line":173,"range":{"start_line":173,"start_character":0,"end_line":173,"end_character":26},"updated":"2020-04-14 13:42:21.000000000","message":"glance_enable_tls_backend","commit_id":"6607a547cdf5abbeaef785baed5d03d9ffa8220e"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"39cbe641e99a5485a38b07b775f3f159f0c83ed2","unresolved":false,"context_lines":[{"line_number":36,"context_line":"        custom_member_list: \"{{ haproxy_members.split(\u0027;\u0027) }}\""},{"line_number":37,"context_line":"        tls_backend: \"{{ glance_enable_tls_backend }}\""},{"line_number":38,"context_line":"  glance-stunnel:"},{"line_number":39,"context_line":"    container_name: stunnel"},{"line_number":40,"context_line":"    group: glance-api"},{"line_number":41,"context_line":"    enabled: \"{{ glance_enable_tls_backend }}\""},{"line_number":42,"context_line":"    image: \"{{ glance_stunnel_image_full }}\""}],"source_content_type":"text/x-yaml","patch_set":32,"id":"1f493fa4_4489c424","line":39,"range":{"start_line":39,"start_character":20,"end_line":39,"end_character":27},"updated":"2020-04-20 18:31:44.000000000","message":"glance_stunnel","commit_id":"92564fc73b62d39387744c95e9beb813a1a965a1"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"39cbe641e99a5485a38b07b775f3f159f0c83ed2","unresolved":false,"context_lines":[{"line_number":40,"context_line":"    group: glance-api"},{"line_number":41,"context_line":"    enabled: \"{{ glance_enable_tls_backend }}\""},{"line_number":42,"context_line":"    image: \"{{ glance_stunnel_image_full }}\""},{"line_number":43,"context_line":"    volumes: \"{{ glance_stunnel_default_volumes }}\""},{"line_number":44,"context_line":"    dimensions: \"{{ glance_stunnel_dimensions }}\""},{"line_number":45,"context_line":"    host_in_groups: \"{{ inventory_hostname in glance_api_hosts }}\""},{"line_number":46,"context_line":"    privileged: \"{{ enable_cinder | bool and enable_cinder_backend_iscsi | bool }}\""}],"source_content_type":"text/x-yaml","patch_set":32,"id":"1f493fa4_8483cc04","line":43,"range":{"start_line":43,"start_character":17,"end_line":43,"end_character":47},"updated":"2020-04-20 18:31:44.000000000","message":"+ extra","commit_id":"92564fc73b62d39387744c95e9beb813a1a965a1"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"39cbe641e99a5485a38b07b775f3f159f0c83ed2","unresolved":false,"context_lines":[{"line_number":43,"context_line":"    volumes: \"{{ glance_stunnel_default_volumes }}\""},{"line_number":44,"context_line":"    dimensions: \"{{ glance_stunnel_dimensions }}\""},{"line_number":45,"context_line":"    host_in_groups: \"{{ inventory_hostname in glance_api_hosts }}\""},{"line_number":46,"context_line":"    privileged: \"{{ enable_cinder | bool and enable_cinder_backend_iscsi | bool }}\""},{"line_number":47,"context_line":"    environment: \"{{ container_proxy }}\""},{"line_number":48,"context_line":"    tls_backend: \"{{ glance_enable_tls_backend }}\""},{"line_number":49,"context_line":""},{"line_number":50,"context_line":"####################"},{"line_number":51,"context_line":"# HAProxy"}],"source_content_type":"text/x-yaml","patch_set":32,"id":"1f493fa4_0477bc3c","line":48,"range":{"start_line":46,"start_character":0,"end_line":48,"end_character":50},"updated":"2020-04-20 18:31:44.000000000","message":"Not required","commit_id":"92564fc73b62d39387744c95e9beb813a1a965a1"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"39cbe641e99a5485a38b07b775f3f159f0c83ed2","unresolved":false,"context_lines":[{"line_number":117,"context_line":"  - \"{% if enable_cinder | bool and enable_cinder_backend_iscsi | bool %}iscsi_info:/etc/iscsi{% endif %}\""},{"line_number":118,"context_line":"  - \"{% if enable_cinder | bool and enable_cinder_backend_iscsi | bool %}/dev:/dev{% endif %}\""},{"line_number":119,"context_line":""},{"line_number":120,"context_line":"glance_stunnel_image: \"{{ docker_registry ~ \u0027/\u0027 if docker_registry else \u0027\u0027 }}{{ docker_namespace }}/{{ kolla_base_distro }}-{{ glance_install_type }}-stunnel\""},{"line_number":121,"context_line":"glance_stunnel_tag: \"{{ glance_tag }}\""},{"line_number":122,"context_line":"glance_stunnel_image_full: \"{{ glance_stunnel_image }}:{{ glance_stunnel_tag }}\""},{"line_number":123,"context_line":"glance_stunnel_dimensions: \"{{ default_container_dimensions }}\""},{"line_number":124,"context_line":""},{"line_number":125,"context_line":"glance_stunnel_default_volumes:"},{"line_number":126,"context_line":"  - \"{{ node_config_directory }}/glance-stunnel/:{{ container_config_directory }}/:ro\""}],"source_content_type":"text/x-yaml","patch_set":32,"id":"1f493fa4_448ee427","line":123,"range":{"start_line":120,"start_character":0,"end_line":123,"end_character":63},"updated":"2020-04-20 18:31:44.000000000","message":"Normally we group image bits together","commit_id":"92564fc73b62d39387744c95e9beb813a1a965a1"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"39cbe641e99a5485a38b07b775f3f159f0c83ed2","unresolved":false,"context_lines":[{"line_number":125,"context_line":"glance_stunnel_default_volumes:"},{"line_number":126,"context_line":"  - \"{{ node_config_directory }}/glance-stunnel/:{{ container_config_directory }}/:ro\""},{"line_number":127,"context_line":"  - \"/etc/localtime:/etc/localtime:ro\""},{"line_number":128,"context_line":"  - \"{{ kolla_dev_repos_directory ~ \u0027/glance/glance:/var/lib/kolla/venv/lib/python\u0027 ~ distro_python_version ~ \u0027/site-packages/glance\u0027 if glance_dev_mode | bool else \u0027\u0027 }}\""},{"line_number":129,"context_line":"  - \"kolla_logs:/var/log/kolla/\""},{"line_number":130,"context_line":""},{"line_number":131,"context_line":"glance_extra_volumes: \"{{ default_extra_volumes }}\""}],"source_content_type":"text/x-yaml","patch_set":32,"id":"1f493fa4_649de058","line":128,"range":{"start_line":128,"start_character":0,"end_line":128,"end_character":171},"updated":"2020-04-20 18:31:44.000000000","message":"Not required","commit_id":"92564fc73b62d39387744c95e9beb813a1a965a1"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"60fbfc6443a81ff48c0cbdf14640c2d751d94f4f","unresolved":false,"context_lines":[{"line_number":22,"context_line":"          - \"timeout client {{ haproxy_glance_api_client_timeout }}\""},{"line_number":23,"context_line":"        backend_http_extra:"},{"line_number":24,"context_line":"          - \"timeout server {{ haproxy_glance_api_server_timeout }}\""},{"line_number":25,"context_line":"        custom_member_list: \"{% if kolla_enable_tls_backend | bool %}{{ haproxy_tls_members.split(\u0027;\u0027) }}{% else %}{{ haproxy_members.split(\u0027;\u0027) }}{% endif %}\""},{"line_number":26,"context_line":"      glance_api_external:"},{"line_number":27,"context_line":"        enabled: \"{{ enable_glance }}\""},{"line_number":28,"context_line":"        mode: \"http\""}],"source_content_type":"text/x-yaml","patch_set":33,"id":"1f493fa4_b09d545b","line":25,"range":{"start_line":25,"start_character":35,"end_line":25,"end_character":40},"updated":"2020-04-21 11:15:39.000000000","message":"This can always use haproxy_members","commit_id":"7b1be3e548c63b97ce645bd600a00587762e991b"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"60fbfc6443a81ff48c0cbdf14640c2d751d94f4f","unresolved":false,"context_lines":[{"line_number":33,"context_line":"        backend_http_extra:"},{"line_number":34,"context_line":"          - \"timeout server {{ haproxy_glance_api_server_timeout }}\""},{"line_number":35,"context_line":"        custom_member_list: \"{{ haproxy_members.split(\u0027;\u0027) }}\""},{"line_number":36,"context_line":"  glance-stunnel:"},{"line_number":37,"context_line":"    haproxy:"},{"line_number":38,"context_line":"      glance_stunnel:"},{"line_number":39,"context_line":"        enabled: no"}],"source_content_type":"text/x-yaml","patch_set":33,"id":"1f493fa4_f037dce2","line":36,"updated":"2020-04-21 11:15:39.000000000","message":"nit: keep ordering of keys consistent with glance-api","commit_id":"7b1be3e548c63b97ce645bd600a00587762e991b"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"60fbfc6443a81ff48c0cbdf14640c2d751d94f4f","unresolved":false,"context_lines":[{"line_number":36,"context_line":"  glance-stunnel:"},{"line_number":37,"context_line":"    haproxy:"},{"line_number":38,"context_line":"      glance_stunnel:"},{"line_number":39,"context_line":"        enabled: no"},{"line_number":40,"context_line":"        tls_backend: \"{{ glance_enable_tls_backend }}\""},{"line_number":41,"context_line":"    container_name: glance_stunnel"},{"line_number":42,"context_line":"    group: glance-api"},{"line_number":43,"context_line":"    enabled: \"{{ glance_enable_tls_backend }}\""}],"source_content_type":"text/x-yaml","patch_set":33,"id":"1f493fa4_50bfb0fa","line":40,"range":{"start_line":39,"start_character":0,"end_line":40,"end_character":54},"updated":"2020-04-21 11:15:39.000000000","message":"I\u0027d suggest that you copy the original haproxy section from glance-api. Then add this to glance-api.haproxy.*:\n\nenabled: \"{{ enable_glance | bool and not glance_enable_tls_backend | bool }}\"\n\nadd this to glance-api.haproxy.*:\n\nAnd this to glance-stunnel.haproxy.*:\n\nenabled: \"{{ enable_glance | bool and glance_enable_tls_backend | bool }}\"\ncustom_member_list: \"{{ haproxy_tls_members.split(\u0027;\u0027) }}\"\ntls_backend: true","commit_id":"7b1be3e548c63b97ce645bd600a00587762e991b"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"60fbfc6443a81ff48c0cbdf14640c2d751d94f4f","unresolved":false,"context_lines":[{"line_number":100,"context_line":"glance_install_type: \"{{ kolla_install_type }}\""},{"line_number":101,"context_line":"glance_tag: \"{{ openstack_tag }}\""},{"line_number":102,"context_line":""},{"line_number":103,"context_line":"glance_api_image: \"{{ docker_registry ~ \u0027/\u0027 if docker_registry else \u0027\u0027 }}{{ docker_namespace }}/{{ kolla_base_distro }}-{{ glance_install_type }}-glance-api\""},{"line_number":104,"context_line":"glance_stunnel_image: \"{{ docker_registry ~ \u0027/\u0027 if docker_registry else \u0027\u0027 }}{{ docker_namespace }}/{{ kolla_base_distro }}-{{ glance_install_type }}-stunnel\""},{"line_number":105,"context_line":"glance_stunnel_image_full: \"{{ glance_stunnel_image }}:{{ glance_stunnel_tag }}\""},{"line_number":106,"context_line":"glance_api_image_full: \"{{ glance_api_image }}:{{ glance_api_tag }}\""},{"line_number":107,"context_line":""},{"line_number":108,"context_line":"glance_api_tag: \"{{ glance_tag }}\""},{"line_number":109,"context_line":"glance_stunnel_tag: \"{{ glance_tag }}\""},{"line_number":110,"context_line":""},{"line_number":111,"context_line":"glance_api_dimensions: \"{{ default_container_dimensions }}\""},{"line_number":112,"context_line":"glance_stunnel_dimensions: \"{{ default_container_dimensions }}\""}],"source_content_type":"text/x-yaml","patch_set":33,"id":"1f493fa4_8d19238a","line":109,"range":{"start_line":103,"start_character":0,"end_line":109,"end_character":38},"updated":"2020-04-21 11:15:39.000000000","message":"Ordering\u0027s a bit weird. See another service for comparison.","commit_id":"7b1be3e548c63b97ce645bd600a00587762e991b"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"664d1a16727df160510b457a2302be72010a3a3a","unresolved":false,"context_lines":[{"line_number":39,"context_line":"    host_in_groups: \"{{ inventory_hostname in glance_api_hosts }}\""},{"line_number":40,"context_line":"    enabled: \"{{ glance_enable_tls_backend }}\""},{"line_number":41,"context_line":"    image: \"{{ glance_stunnel_image_full }}\""},{"line_number":42,"context_line":"    volumes: \"{{ glance_stunnel_default_volumes + glance_extra_volumes }}\""},{"line_number":43,"context_line":"    dimensions: \"{{ glance_stunnel_dimensions }}\""},{"line_number":44,"context_line":"    haproxy:"},{"line_number":45,"context_line":"      glance_stunnel:"}],"source_content_type":"text/x-yaml","patch_set":36,"id":"1f493fa4_423694e8","line":42,"range":{"start_line":42,"start_character":50,"end_line":42,"end_character":70},"updated":"2020-04-23 10:07:47.000000000","message":"glance_stunnel_extra_volumes","commit_id":"caec94c403c198c937338948146497e5b5aa9bcc"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"664d1a16727df160510b457a2302be72010a3a3a","unresolved":false,"context_lines":[{"line_number":45,"context_line":"      glance_stunnel:"},{"line_number":46,"context_line":"        enabled: \"{{ enable_glance | bool and glance_enable_tls_backend | bool }}\""},{"line_number":47,"context_line":"        mode: \"http\""},{"line_number":48,"context_line":"        external: true"},{"line_number":49,"context_line":"        port: \"{{ glance_api_port }}\""},{"line_number":50,"context_line":"        frontend_http_extra:"},{"line_number":51,"context_line":"          - \"timeout client {{ haproxy_glance_api_client_timeout }}\""}],"source_content_type":"text/x-yaml","patch_set":36,"id":"1f493fa4_a25af826","line":48,"range":{"start_line":48,"start_character":18,"end_line":48,"end_character":22},"updated":"2020-04-23 10:07:47.000000000","message":"false","commit_id":"caec94c403c198c937338948146497e5b5aa9bcc"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"664d1a16727df160510b457a2302be72010a3a3a","unresolved":false,"context_lines":[{"line_number":53,"context_line":"          - \"timeout server {{ haproxy_glance_api_server_timeout }}\""},{"line_number":54,"context_line":"        custom_member_list: \"{{ haproxy_tls_members.split(\u0027;\u0027) }}\""},{"line_number":55,"context_line":"        tls_backend: \"yes\""},{"line_number":56,"context_line":"      glance_stunnel_external:"},{"line_number":57,"context_line":"        enabled: \"{{ enable_glance | bool and glance_enable_tls_backend | bool }}\""},{"line_number":58,"context_line":"        mode: \"http\""},{"line_number":59,"context_line":"        port: \"{{ glance_api_port }}\""}],"source_content_type":"text/x-yaml","patch_set":36,"id":"1f493fa4_e23b60c5","line":56,"range":{"start_line":56,"start_character":6,"end_line":56,"end_character":29},"updated":"2020-04-23 10:07:47.000000000","message":"missing external: true","commit_id":"caec94c403c198c937338948146497e5b5aa9bcc"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"664d1a16727df160510b457a2302be72010a3a3a","unresolved":false,"context_lines":[{"line_number":128,"context_line":"glance_api_dimensions: \"{{ default_container_dimensions }}\""},{"line_number":129,"context_line":"glance_stunnel_dimensions: \"{{ default_container_dimensions }}\""},{"line_number":130,"context_line":""},{"line_number":131,"context_line":"glance_api_default_volumes:"},{"line_number":132,"context_line":"  - \"{{ node_config_directory }}/glance-api/:{{ container_config_directory }}/:ro\""},{"line_number":133,"context_line":"  - \"/etc/localtime:/etc/localtime:ro\""},{"line_number":134,"context_line":"  - \"{{ \u0027/etc/timezone:/etc/timezone:ro\u0027 if kolla_base_distro in [\u0027debian\u0027, \u0027ubuntu\u0027] else \u0027\u0027 }}\""},{"line_number":135,"context_line":"  - \"{{ glance_file_datadir_volume }}:/var/lib/glance/\""},{"line_number":136,"context_line":"  - \"{{ kolla_dev_repos_directory ~ \u0027/glance/glance:/var/lib/kolla/venv/lib/python\u0027 ~ distro_python_version ~ \u0027/site-packages/glance\u0027 if glance_dev_mode | bool else \u0027\u0027 }}\""},{"line_number":137,"context_line":"  - \"kolla_logs:/var/log/kolla/\""},{"line_number":138,"context_line":"  # NOTE(yoctozepto): below to support Cinder iSCSI backends"},{"line_number":139,"context_line":"  - \"{% if enable_cinder | bool and enable_cinder_backend_iscsi | bool %}iscsi_info:/etc/iscsi{% endif %}\""},{"line_number":140,"context_line":"  - \"{% if enable_cinder | bool and enable_cinder_backend_iscsi | bool %}/dev:/dev{% endif %}\""},{"line_number":141,"context_line":""},{"line_number":142,"context_line":"glance_extra_volumes: \"{{ default_extra_volumes }}\""},{"line_number":143,"context_line":"glance_api_extra_volumes: \"{{ glance_extra_volumes }}\""},{"line_number":144,"context_line":"glance_stunnel_default_volumes:"},{"line_number":145,"context_line":"  - \"{{ node_config_directory }}/glance-stunnel/:{{ container_config_directory }}/:ro\""},{"line_number":146,"context_line":"  - \"/etc/localtime:/etc/localtime:ro\""},{"line_number":147,"context_line":"  - \"kolla_logs:/var/log/kolla/\""},{"line_number":148,"context_line":""},{"line_number":149,"context_line":"####################"},{"line_number":150,"context_line":"# Glance"}],"source_content_type":"text/x-yaml","patch_set":36,"id":"1f493fa4_e26400e8","line":147,"range":{"start_line":131,"start_character":0,"end_line":147,"end_character":32},"updated":"2020-04-23 10:07:47.000000000","message":"glance_api_default_volumes:\n  - \"{{ node_config_directory }}/glance-api/:{{ container_config_directory }}/:ro\"\n  - \"/etc/localtime:/etc/localtime:ro\"\n  - \"{{ \u0027/etc/timezone:/etc/timezone:ro\u0027 if kolla_base_distro in [\u0027debian\u0027, \u0027ubuntu\u0027] else \u0027\u0027 }}\"\n  - \"{{ glance_file_datadir_volume }}:/var/lib/glance/\"\n  - \"{{ kolla_dev_repos_directory ~ \u0027/glance/glance:/var/lib/kolla/venv/lib/python\u0027 ~ distro_python_version ~ \u0027/site-packages/glance\u0027 if glance_dev_mode | bool else \u0027\u0027 }}\"\n  - \"kolla_logs:/var/log/kolla/\"\n  # NOTE(yoctozepto): below to support Cinder iSCSI backends\n  - \"{% if enable_cinder | bool and enable_cinder_backend_iscsi | bool %}iscsi_info:/etc/iscsi{% endif %}\"\n  - \"{% if enable_cinder | bool and enable_cinder_backend_iscsi | bool %}/dev:/dev{% endif %}\"\nglance_stunnel_default_volumes:\n  - \"{{ node_config_directory }}/glance-stunnel/:{{ container_config_directory }}/:ro\"\n  - \"/etc/localtime:/etc/localtime:ro\"\n  - \"kolla_logs:/var/log/kolla/\"\n\nglance_extra_volumes: \"{{ default_extra_volumes }}\"\nglance_api_extra_volumes: \"{{ glance_extra_volumes }}\"\nglance_stunnel_extra_volumes: \"{{ glance_extra_volumes }}\"","commit_id":"caec94c403c198c937338948146497e5b5aa9bcc"}],"ansible/roles/glance/handlers/main.yml":[{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"39cbe641e99a5485a38b07b775f3f159f0c83ed2","unresolved":false,"context_lines":[{"line_number":26,"context_line":"    common_options: \"{{ docker_common_options }}\""},{"line_number":27,"context_line":"    name: \"{{ service.container_name }}\""},{"line_number":28,"context_line":"    image: \"{{ service.image }}\""},{"line_number":29,"context_line":"    privileged: \"{{ service.privileged }}\""},{"line_number":30,"context_line":"    environment: \"{{ service.environment }}\""},{"line_number":31,"context_line":"    volumes: \"{{ service.volumes|reject(\u0027equalto\u0027, \u0027\u0027)|list }}\""},{"line_number":32,"context_line":"    dimensions: \"{{ service.dimensions }}\""},{"line_number":33,"context_line":"  when:"}],"source_content_type":"text/x-yaml","patch_set":32,"id":"1f493fa4_24bc78ba","line":30,"range":{"start_line":29,"start_character":0,"end_line":30,"end_character":44},"updated":"2020-04-20 18:31:44.000000000","message":"Not required","commit_id":"92564fc73b62d39387744c95e9beb813a1a965a1"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"39cbe641e99a5485a38b07b775f3f159f0c83ed2","unresolved":false,"context_lines":[{"line_number":32,"context_line":"    dimensions: \"{{ service.dimensions }}\""},{"line_number":33,"context_line":"  when:"},{"line_number":34,"context_line":"    - kolla_action !\u003d \"config\""},{"line_number":35,"context_line":"    - glance_enable_tls_backend | bool"}],"source_content_type":"text/x-yaml","patch_set":32,"id":"1f493fa4_84b10ce5","line":35,"range":{"start_line":35,"start_character":4,"end_line":35,"end_character":38},"updated":"2020-04-20 18:31:44.000000000","message":"Should be covered by service.enabled","commit_id":"92564fc73b62d39387744c95e9beb813a1a965a1"}],"ansible/roles/glance/tasks/config.yml":[{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"9d452cbb6582cf6a777555c9386fd417660e5c96","unresolved":false,"context_lines":[{"line_number":134,"context_line":"  notify:"},{"line_number":135,"context_line":"    - Restart {{ item.key }} container"},{"line_number":136,"context_line":""},{"line_number":137,"context_line":"- include_tasks: copy-certs.yml"},{"line_number":138,"context_line":"  when:"},{"line_number":139,"context_line":"    - kolla_copy_ca_into_containers | bool or glance_tls_backend_enabled | bool"},{"line_number":140,"context_line":""},{"line_number":141,"context_line":"- include_tasks: check-containers.yml"},{"line_number":142,"context_line":"  when: kolla_action !\u003d \"config\""}],"source_content_type":"text/x-yaml","patch_set":25,"id":"3f4c43b2_5da97079","line":139,"range":{"start_line":137,"start_character":0,"end_line":139,"end_character":79},"updated":"2020-04-14 13:42:21.000000000","message":"Please rebase onto https://review.opendev.org/#/c/719104/","commit_id":"6607a547cdf5abbeaef785baed5d03d9ffa8220e"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"fe39f2807e92a40e0c5df30ac0b8c4be0acffd8b","unresolved":false,"context_lines":[{"line_number":37,"context_line":""},{"line_number":38,"context_line":"- include_tasks: copy-certs.yml"},{"line_number":39,"context_line":"  when:"},{"line_number":40,"context_line":"   - kolla_copy_ca_into_containers | bool or glance_enable_tls_backend | bool"},{"line_number":41,"context_line":""},{"line_number":42,"context_line":"- name: Copying over config.json files for services"},{"line_number":43,"context_line":"  template:"}],"source_content_type":"text/x-yaml","patch_set":27,"id":"3f4c43b2_faae69e5","line":40,"updated":"2020-04-15 13:48:44.000000000","message":"Failing pep8 due to indentation","commit_id":"1b85f89a6437f659479dd9ddbf4fee1db3f6ae9e"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"fe39f2807e92a40e0c5df30ac0b8c4be0acffd8b","unresolved":false,"context_lines":[{"line_number":124,"context_line":"  notify:"},{"line_number":125,"context_line":"    - Restart {{ item.key }} container"},{"line_number":126,"context_line":""},{"line_number":127,"context_line":"- include_tasks: copy-certs.yml"},{"line_number":128,"context_line":"  when:"},{"line_number":129,"context_line":"    - kolla_copy_ca_into_containers | bool or glance_tls_backend_enabled | bool"},{"line_number":130,"context_line":""},{"line_number":131,"context_line":"- include_tasks: check-containers.yml"},{"line_number":132,"context_line":"  when: kolla_action !\u003d \"config\""}],"source_content_type":"text/x-yaml","patch_set":27,"id":"3f4c43b2_975f3e71","line":129,"range":{"start_line":127,"start_character":0,"end_line":129,"end_character":79},"updated":"2020-04-15 13:48:44.000000000","message":"This can be removed - present on L38","commit_id":"1b85f89a6437f659479dd9ddbf4fee1db3f6ae9e"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"39cbe641e99a5485a38b07b775f3f159f0c83ed2","unresolved":false,"context_lines":[{"line_number":78,"context_line":"  merge_configs:"},{"line_number":79,"context_line":"    sources:"},{"line_number":80,"context_line":"      - \"{{ role_path }}/templates/stunnel.conf.j2\""},{"line_number":81,"context_line":"      - \"{{ node_custom_config }}/global.conf\""},{"line_number":82,"context_line":"      - \"{{ node_custom_config }}/stunnel.conf\""},{"line_number":83,"context_line":"    dest: \"{{ node_config_directory }}/glance-stunnel/stunnel.conf\""},{"line_number":84,"context_line":"    mode: \"0660\""}],"source_content_type":"text/x-yaml","patch_set":32,"id":"1f493fa4_44dc2418","line":81,"range":{"start_line":81,"start_character":1,"end_line":81,"end_character":46},"updated":"2020-04-20 18:31:44.000000000","message":"Not required","commit_id":"92564fc73b62d39387744c95e9beb813a1a965a1"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"39cbe641e99a5485a38b07b775f3f159f0c83ed2","unresolved":false,"context_lines":[{"line_number":79,"context_line":"    sources:"},{"line_number":80,"context_line":"      - \"{{ role_path }}/templates/stunnel.conf.j2\""},{"line_number":81,"context_line":"      - \"{{ node_custom_config }}/global.conf\""},{"line_number":82,"context_line":"      - \"{{ node_custom_config }}/stunnel.conf\""},{"line_number":83,"context_line":"    dest: \"{{ node_config_directory }}/glance-stunnel/stunnel.conf\""},{"line_number":84,"context_line":"    mode: \"0660\""},{"line_number":85,"context_line":"  become: true"}],"source_content_type":"text/x-yaml","patch_set":32,"id":"1f493fa4_64eb20b0","line":82,"range":{"start_line":82,"start_character":34,"end_line":82,"end_character":46},"updated":"2020-04-20 18:31:44.000000000","message":"glance/stunnel.conf","commit_id":"92564fc73b62d39387744c95e9beb813a1a965a1"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"39cbe641e99a5485a38b07b775f3f159f0c83ed2","unresolved":false,"context_lines":[{"line_number":84,"context_line":"    mode: \"0660\""},{"line_number":85,"context_line":"  become: true"},{"line_number":86,"context_line":"  when:"},{"line_number":87,"context_line":"    - glance_enable_tls_backend | bool"},{"line_number":88,"context_line":"  notify:"},{"line_number":89,"context_line":"    - Restart glance-stunnel container"},{"line_number":90,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":32,"id":"1f493fa4_84346c4c","line":87,"range":{"start_line":87,"start_character":0,"end_line":87,"end_character":38},"updated":"2020-04-20 18:31:44.000000000","message":"- service.enabled | bool\n    - service.host_in_groups | bool","commit_id":"92564fc73b62d39387744c95e9beb813a1a965a1"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"60fbfc6443a81ff48c0cbdf14640c2d751d94f4f","unresolved":false,"context_lines":[{"line_number":68,"context_line":"  when:"},{"line_number":69,"context_line":"    - item.value.enabled | bool"},{"line_number":70,"context_line":"    - item.value.host_in_groups | bool"},{"line_number":71,"context_line":"  with_dict: \"{{ glance_services }}\""},{"line_number":72,"context_line":"  notify:"},{"line_number":73,"context_line":"    - Restart {{ item.key }} container"},{"line_number":74,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":33,"id":"1f493fa4_ad185f81","line":71,"range":{"start_line":71,"start_character":2,"end_line":71,"end_character":36},"updated":"2020-04-21 11:15:39.000000000","message":"Not required for stunnel","commit_id":"7b1be3e548c63b97ce645bd600a00587762e991b"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"60fbfc6443a81ff48c0cbdf14640c2d751d94f4f","unresolved":false,"context_lines":[{"line_number":136,"context_line":"    - glance_policy_file is defined"},{"line_number":137,"context_line":"    - item.value.host_in_groups | bool"},{"line_number":138,"context_line":"    - item.value.enabled | bool"},{"line_number":139,"context_line":"  with_dict: \"{{ glance_services }}\""},{"line_number":140,"context_line":"  notify:"},{"line_number":141,"context_line":"    - Restart {{ item.key }} container"},{"line_number":142,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":33,"id":"1f493fa4_0d0d133e","line":139,"range":{"start_line":139,"start_character":0,"end_line":139,"end_character":36},"updated":"2020-04-21 11:15:39.000000000","message":"Not required for stunnel","commit_id":"7b1be3e548c63b97ce645bd600a00587762e991b"}],"ansible/roles/glance/templates/glance-api.conf.j2":[{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"cf2048ce79d9cd0ba25e734a0ac2c862fb997210","unresolved":false,"context_lines":[{"line_number":22,"context_line":"image_cache_dir \u003d /var/lib/glance/image-cache"},{"line_number":23,"context_line":"{% endif %}"},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"{% if kolla_enable_tls_backend | bool%}"},{"line_number":26,"context_line":"cert_file \u003d  /etc/glance/certs/glance.pem"},{"line_number":27,"context_line":"key_file \u003d  /etc/glance/certs/glance.key"},{"line_number":28,"context_line":"{% endif %}"}],"source_content_type":"text/x-jinja2","patch_set":23,"id":"1fa4df85_22ef5285","line":25,"updated":"2020-02-26 09:56:57.000000000","message":"nit: space","commit_id":"ca76e6cf957a158a12a8957b6c78299f7368b35b"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"9d452cbb6582cf6a777555c9386fd417660e5c96","unresolved":false,"context_lines":[{"line_number":26,"context_line":"image_cache_dir \u003d /var/lib/glance/image-cache"},{"line_number":27,"context_line":"{% endif %}"},{"line_number":28,"context_line":""},{"line_number":29,"context_line":"{% if kolla_enable_tls_backend | bool%}"},{"line_number":30,"context_line":"cert_file \u003d  /etc/glance/certs/glance.pem"},{"line_number":31,"context_line":"key_file \u003d  /etc/glance/certs/glance.key"},{"line_number":32,"context_line":"{% endif %}"}],"source_content_type":"text/x-jinja2","patch_set":25,"id":"3f4c43b2_9d0ad887","line":29,"range":{"start_line":29,"start_character":6,"end_line":29,"end_character":30},"updated":"2020-04-14 13:42:21.000000000","message":"glance_enable_tls_backend","commit_id":"6607a547cdf5abbeaef785baed5d03d9ffa8220e"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"9d452cbb6582cf6a777555c9386fd417660e5c96","unresolved":false,"context_lines":[{"line_number":27,"context_line":"{% endif %}"},{"line_number":28,"context_line":""},{"line_number":29,"context_line":"{% if kolla_enable_tls_backend | bool%}"},{"line_number":30,"context_line":"cert_file \u003d  /etc/glance/certs/glance.pem"},{"line_number":31,"context_line":"key_file \u003d  /etc/glance/certs/glance.key"},{"line_number":32,"context_line":"{% endif %}"},{"line_number":33,"context_line":""}],"source_content_type":"text/x-jinja2","patch_set":25,"id":"3f4c43b2_ddebc0ad","line":30,"range":{"start_line":30,"start_character":31,"end_line":30,"end_character":41},"updated":"2020-04-14 13:42:21.000000000","message":"glance-cert.pem","commit_id":"6607a547cdf5abbeaef785baed5d03d9ffa8220e"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"9d452cbb6582cf6a777555c9386fd417660e5c96","unresolved":false,"context_lines":[{"line_number":28,"context_line":""},{"line_number":29,"context_line":"{% if kolla_enable_tls_backend | bool%}"},{"line_number":30,"context_line":"cert_file \u003d  /etc/glance/certs/glance.pem"},{"line_number":31,"context_line":"key_file \u003d  /etc/glance/certs/glance.key"},{"line_number":32,"context_line":"{% endif %}"},{"line_number":33,"context_line":""},{"line_number":34,"context_line":"[database]"}],"source_content_type":"text/x-jinja2","patch_set":25,"id":"3f4c43b2_5dd7b0ee","line":31,"range":{"start_line":31,"start_character":30,"end_line":31,"end_character":40},"updated":"2020-04-14 13:42:21.000000000","message":"glance-key.pem","commit_id":"6607a547cdf5abbeaef785baed5d03d9ffa8220e"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"fe39f2807e92a40e0c5df30ac0b8c4be0acffd8b","unresolved":false,"context_lines":[{"line_number":28,"context_line":""},{"line_number":29,"context_line":"{% if glance_enable_tls_backend | bool %}"},{"line_number":30,"context_line":"cert_file \u003d  /etc/glance/certs/glance-cert.pem"},{"line_number":31,"context_line":"key_file \u003d  /etc/glance/certs/glance-api.pem"},{"line_number":32,"context_line":"{% endif %}"},{"line_number":33,"context_line":""},{"line_number":34,"context_line":"[database]"}],"source_content_type":"text/x-jinja2","patch_set":27,"id":"3f4c43b2_17a7ae51","line":31,"range":{"start_line":31,"start_character":30,"end_line":31,"end_character":44},"updated":"2020-04-15 13:48:44.000000000","message":"glance-key.pem","commit_id":"1b85f89a6437f659479dd9ddbf4fee1db3f6ae9e"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"39cbe641e99a5485a38b07b775f3f159f0c83ed2","unresolved":false,"context_lines":[{"line_number":10,"context_line":"bind_port \u003d {{ glance_api_no_proxy_listen_port }}"},{"line_number":11,"context_line":"{% else %}"},{"line_number":12,"context_line":"bind_port \u003d {{ glance_api_listen_port }}"},{"line_number":13,"context_line":"{% endif %}"},{"line_number":14,"context_line":"workers \u003d {{ openstack_service_workers }}"},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"{% if glance_store_backends %}"}],"source_content_type":"text/x-jinja2","patch_set":32,"id":"1f493fa4_247d98e7","line":13,"updated":"2020-04-20 18:31:44.000000000","message":"Set bind_host to 127.0.0.1 instead?","commit_id":"92564fc73b62d39387744c95e9beb813a1a965a1"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"60fbfc6443a81ff48c0cbdf14640c2d751d94f4f","unresolved":false,"context_lines":[{"line_number":10,"context_line":"bind_port \u003d {{ glance_api_listen_port }}"},{"line_number":11,"context_line":"{% else %}"},{"line_number":12,"context_line":"bind_host \u003d {{ api_interface_address }}"},{"line_number":13,"context_line":"bind_port \u003d {{ glance_api_listen_port }}"},{"line_number":14,"context_line":"{% endif %}"},{"line_number":15,"context_line":"workers \u003d {{ openstack_service_workers }}"},{"line_number":16,"context_line":""}],"source_content_type":"text/x-jinja2","patch_set":33,"id":"1f493fa4_90fe5803","line":13,"range":{"start_line":13,"start_character":0,"end_line":13,"end_character":40},"updated":"2020-04-21 11:15:39.000000000","message":"Can move outside the if","commit_id":"7b1be3e548c63b97ce645bd600a00587762e991b"}],"ansible/roles/glance/templates/glance-api.json.j2":[{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"9d452cbb6582cf6a777555c9386fd417660e5c96","unresolved":false,"context_lines":[{"line_number":36,"context_line":"            \"dest\": \"/etc/glance/glance-cache.conf\","},{"line_number":37,"context_line":"            \"owner\": \"glance\","},{"line_number":38,"context_line":"            \"perm\": \"0600\""},{"line_number":39,"context_line":"        }{% endif %}{% if glance_tls_backend_enabled | bool %},"},{"line_number":40,"context_line":"        {"},{"line_number":41,"context_line":"            \"source\": \"{{ container_config_directory }}/glance-api.pem\","},{"line_number":42,"context_line":"            \"dest\": \"/etc/glance/certs/glance.pem\","}],"source_content_type":"text/x-jinja2","patch_set":25,"id":"3f4c43b2_fd34bc4c","line":39,"range":{"start_line":39,"start_character":26,"end_line":39,"end_character":52},"updated":"2020-04-14 13:42:21.000000000","message":"glance_enable_tls_backend","commit_id":"6607a547cdf5abbeaef785baed5d03d9ffa8220e"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"9d452cbb6582cf6a777555c9386fd417660e5c96","unresolved":false,"context_lines":[{"line_number":38,"context_line":"            \"perm\": \"0600\""},{"line_number":39,"context_line":"        }{% endif %}{% if glance_tls_backend_enabled | bool %},"},{"line_number":40,"context_line":"        {"},{"line_number":41,"context_line":"            \"source\": \"{{ container_config_directory }}/glance-api.pem\","},{"line_number":42,"context_line":"            \"dest\": \"/etc/glance/certs/glance.pem\","},{"line_number":43,"context_line":"            \"owner\": \"glance\","},{"line_number":44,"context_line":"            \"perm\": \"0600\""}],"source_content_type":"text/x-jinja2","patch_set":25,"id":"3f4c43b2_bd7874f8","line":41,"range":{"start_line":41,"start_character":56,"end_line":41,"end_character":70},"updated":"2020-04-14 13:42:21.000000000","message":"glance-cert.pem","commit_id":"6607a547cdf5abbeaef785baed5d03d9ffa8220e"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"9d452cbb6582cf6a777555c9386fd417660e5c96","unresolved":false,"context_lines":[{"line_number":39,"context_line":"        }{% endif %}{% if glance_tls_backend_enabled | bool %},"},{"line_number":40,"context_line":"        {"},{"line_number":41,"context_line":"            \"source\": \"{{ container_config_directory }}/glance-api.pem\","},{"line_number":42,"context_line":"            \"dest\": \"/etc/glance/certs/glance.pem\","},{"line_number":43,"context_line":"            \"owner\": \"glance\","},{"line_number":44,"context_line":"            \"perm\": \"0600\""},{"line_number":45,"context_line":"        },"}],"source_content_type":"text/x-jinja2","patch_set":25,"id":"3f4c43b2_fd82fcc7","line":42,"range":{"start_line":42,"start_character":38,"end_line":42,"end_character":49},"updated":"2020-04-14 13:42:21.000000000","message":"glance-cert.pem","commit_id":"6607a547cdf5abbeaef785baed5d03d9ffa8220e"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"9d452cbb6582cf6a777555c9386fd417660e5c96","unresolved":false,"context_lines":[{"line_number":44,"context_line":"            \"perm\": \"0600\""},{"line_number":45,"context_line":"        },"},{"line_number":46,"context_line":"        {"},{"line_number":47,"context_line":"            \"source\": \"{{ container_config_directory }}/glance-api.key\","},{"line_number":48,"context_line":"            \"dest\": \"/etc/glance/certs/glance.key\","},{"line_number":49,"context_line":"            \"owner\": \"glance\","},{"line_number":50,"context_line":"            \"perm\": \"0600\""}],"source_content_type":"text/x-jinja2","patch_set":25,"id":"3f4c43b2_5d733016","line":47,"range":{"start_line":47,"start_character":56,"end_line":47,"end_character":70},"updated":"2020-04-14 13:42:21.000000000","message":"glance-key.pem","commit_id":"6607a547cdf5abbeaef785baed5d03d9ffa8220e"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"9d452cbb6582cf6a777555c9386fd417660e5c96","unresolved":false,"context_lines":[{"line_number":45,"context_line":"        },"},{"line_number":46,"context_line":"        {"},{"line_number":47,"context_line":"            \"source\": \"{{ container_config_directory }}/glance-api.key\","},{"line_number":48,"context_line":"            \"dest\": \"/etc/glance/certs/glance.key\","},{"line_number":49,"context_line":"            \"owner\": \"glance\","},{"line_number":50,"context_line":"            \"perm\": \"0600\""},{"line_number":51,"context_line":"        }"}],"source_content_type":"text/x-jinja2","patch_set":25,"id":"3f4c43b2_9d665851","line":48,"range":{"start_line":48,"start_character":39,"end_line":48,"end_character":49},"updated":"2020-04-14 13:42:21.000000000","message":"glance-key.pem","commit_id":"6607a547cdf5abbeaef785baed5d03d9ffa8220e"}],"ansible/roles/glance/templates/glance-stunnel.json.j2":[{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"39cbe641e99a5485a38b07b775f3f159f0c83ed2","unresolved":false,"context_lines":[{"line_number":19,"context_line":"            \"owner\": \"glance\","},{"line_number":20,"context_line":"            \"perm\": \"0600\""},{"line_number":21,"context_line":"        }"},{"line_number":22,"context_line":"    ],"},{"line_number":23,"context_line":"    \"permissions\": ["},{"line_number":24,"context_line":"    ]"},{"line_number":25,"context_line":"}"}],"source_content_type":"text/x-jinja2","patch_set":32,"id":"1f493fa4_04769c07","line":24,"range":{"start_line":22,"start_character":5,"end_line":24,"end_character":5},"updated":"2020-04-20 18:31:44.000000000","message":"nit: unnecessary","commit_id":"92564fc73b62d39387744c95e9beb813a1a965a1"}],"ansible/roles/glance/templates/stunnel.conf.j2":[{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"39cbe641e99a5485a38b07b775f3f159f0c83ed2","unresolved":false,"context_lines":[{"line_number":1,"context_line":"output \u003d /var/log/kolla/glance/stunnel.log"},{"line_number":2,"context_line":"pid \u003d /var/log/kolla/glance/stunnel.pid"},{"line_number":3,"context_line":"foreground \u003d yes"},{"line_number":4,"context_line":"debug \u003d 7"},{"line_number":5,"context_line":"sslVersion \u003d all"}],"source_content_type":"text/x-jinja2","patch_set":32,"id":"1f493fa4_64ee8089","line":2,"range":{"start_line":2,"start_character":6,"end_line":2,"end_character":39},"updated":"2020-04-20 18:31:44.000000000","message":"in /var/log? maybe /var/run would be better?","commit_id":"92564fc73b62d39387744c95e9beb813a1a965a1"}],"ansible/roles/heat/defaults/main.yml":[{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"9d452cbb6582cf6a777555c9386fd417660e5c96","unresolved":false,"context_lines":[{"line_number":174,"context_line":"####################"},{"line_number":175,"context_line":"# TLS"},{"line_number":176,"context_line":"####################"},{"line_number":177,"context_line":"heat_tls_backend_enabled: \"{{ kolla_enable_tls_backend }}\""}],"source_content_type":"text/x-yaml","patch_set":25,"id":"3f4c43b2_bdc6b415","line":177,"range":{"start_line":177,"start_character":0,"end_line":177,"end_character":24},"updated":"2020-04-14 13:42:21.000000000","message":"heat_enable_tls_backend","commit_id":"6607a547cdf5abbeaef785baed5d03d9ffa8220e"}],"ansible/roles/heat/tasks/config.yml":[{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"9d452cbb6582cf6a777555c9386fd417660e5c96","unresolved":false,"context_lines":[{"line_number":120,"context_line":"  notify:"},{"line_number":121,"context_line":"    - Restart heat-api-cfn container"},{"line_number":122,"context_line":""},{"line_number":123,"context_line":"- include_tasks: copy-certs.yml"},{"line_number":124,"context_line":"  when:"},{"line_number":125,"context_line":"    - kolla_copy_ca_into_containers | bool or heat_tls_backend_enabled | bool"},{"line_number":126,"context_line":""},{"line_number":127,"context_line":"- include_tasks: check-containers.yml"},{"line_number":128,"context_line":"  when: kolla_action !\u003d \"config\""}],"source_content_type":"text/x-yaml","patch_set":25,"id":"3f4c43b2_3d03c444","line":125,"range":{"start_line":123,"start_character":0,"end_line":125,"end_character":77},"updated":"2020-04-14 13:42:21.000000000","message":"Please rebase","commit_id":"6607a547cdf5abbeaef785baed5d03d9ffa8220e"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"fe39f2807e92a40e0c5df30ac0b8c4be0acffd8b","unresolved":false,"context_lines":[{"line_number":33,"context_line":""},{"line_number":34,"context_line":"- include_tasks: copy-certs.yml"},{"line_number":35,"context_line":"  when:"},{"line_number":36,"context_line":"    - kolla_copy_ca_into_containers | bool"},{"line_number":37,"context_line":""},{"line_number":38,"context_line":"- name: Copying over config.json files for services"},{"line_number":39,"context_line":"  become: true"}],"source_content_type":"text/x-yaml","patch_set":27,"id":"3f4c43b2_77f0b268","line":36,"updated":"2020-04-15 13:48:44.000000000","message":"or heat_enable_tls_backend | bool","commit_id":"1b85f89a6437f659479dd9ddbf4fee1db3f6ae9e"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"fe39f2807e92a40e0c5df30ac0b8c4be0acffd8b","unresolved":false,"context_lines":[{"line_number":110,"context_line":"  notify:"},{"line_number":111,"context_line":"    - Restart heat-api-cfn container"},{"line_number":112,"context_line":""},{"line_number":113,"context_line":"- include_tasks: copy-certs.yml"},{"line_number":114,"context_line":"  when:"},{"line_number":115,"context_line":"    - kolla_copy_ca_into_containers | bool or heat_enable_tls_backend | bool"},{"line_number":116,"context_line":""},{"line_number":117,"context_line":"- include_tasks: check-containers.yml"},{"line_number":118,"context_line":"  when: kolla_action !\u003d \"config\""}],"source_content_type":"text/x-yaml","patch_set":27,"id":"3f4c43b2_37e58aa9","line":115,"range":{"start_line":113,"start_character":0,"end_line":115,"end_character":76},"updated":"2020-04-15 13:48:44.000000000","message":"Not required - present on L34","commit_id":"1b85f89a6437f659479dd9ddbf4fee1db3f6ae9e"}],"ansible/roles/heat/templates/heat-api-cfn.json.j2":[{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"9d452cbb6582cf6a777555c9386fd417660e5c96","unresolved":false,"context_lines":[{"line_number":19,"context_line":"            \"dest\": \"/etc/heat/{{ heat_policy_file }}\","},{"line_number":20,"context_line":"            \"owner\": \"heat\","},{"line_number":21,"context_line":"            \"perm\": \"0600\""},{"line_number":22,"context_line":"        }{% endif %}{% if heat_tls_backend_enabled | bool %},"},{"line_number":23,"context_line":"        {"},{"line_number":24,"context_line":"            \"source\": \"{{ container_config_directory }}/heat-api.pem\","},{"line_number":25,"context_line":"            \"dest\": \"/etc/heat/certs/heat.pem\","}],"source_content_type":"text/x-jinja2","patch_set":25,"id":"3f4c43b2_5d8fb0cb","line":22,"range":{"start_line":22,"start_character":26,"end_line":22,"end_character":50},"updated":"2020-04-14 13:42:21.000000000","message":"heat_enable_tls_backend","commit_id":"6607a547cdf5abbeaef785baed5d03d9ffa8220e"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"9d452cbb6582cf6a777555c9386fd417660e5c96","unresolved":false,"context_lines":[{"line_number":21,"context_line":"            \"perm\": \"0600\""},{"line_number":22,"context_line":"        }{% endif %}{% if heat_tls_backend_enabled | bool %},"},{"line_number":23,"context_line":"        {"},{"line_number":24,"context_line":"            \"source\": \"{{ container_config_directory }}/heat-api.pem\","},{"line_number":25,"context_line":"            \"dest\": \"/etc/heat/certs/heat.pem\","},{"line_number":26,"context_line":"            \"owner\": \"heat\","},{"line_number":27,"context_line":"            \"perm\": \"0600\""}],"source_content_type":"text/x-jinja2","patch_set":25,"id":"3f4c43b2_9dc2d8e8","line":24,"range":{"start_line":24,"start_character":56,"end_line":24,"end_character":68},"updated":"2020-04-14 13:42:21.000000000","message":"heat-api-cfn-cert.pem","commit_id":"6607a547cdf5abbeaef785baed5d03d9ffa8220e"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"9d452cbb6582cf6a777555c9386fd417660e5c96","unresolved":false,"context_lines":[{"line_number":22,"context_line":"        }{% endif %}{% if heat_tls_backend_enabled | bool %},"},{"line_number":23,"context_line":"        {"},{"line_number":24,"context_line":"            \"source\": \"{{ container_config_directory }}/heat-api.pem\","},{"line_number":25,"context_line":"            \"dest\": \"/etc/heat/certs/heat.pem\","},{"line_number":26,"context_line":"            \"owner\": \"heat\","},{"line_number":27,"context_line":"            \"perm\": \"0600\""},{"line_number":28,"context_line":"        },"}],"source_content_type":"text/x-jinja2","patch_set":25,"id":"3f4c43b2_ddbc606b","line":25,"range":{"start_line":25,"start_character":37,"end_line":25,"end_character":45},"updated":"2020-04-14 13:42:21.000000000","message":"heat-api-cfn-cert.pem","commit_id":"6607a547cdf5abbeaef785baed5d03d9ffa8220e"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"9d452cbb6582cf6a777555c9386fd417660e5c96","unresolved":false,"context_lines":[{"line_number":27,"context_line":"            \"perm\": \"0600\""},{"line_number":28,"context_line":"        },"},{"line_number":29,"context_line":"        {"},{"line_number":30,"context_line":"            \"source\": \"{{ container_config_directory }}/heat-api.key\","},{"line_number":31,"context_line":"            \"dest\": \"/etc/heat/certs/heat.key\","},{"line_number":32,"context_line":"            \"owner\": \"heat\","},{"line_number":33,"context_line":"            \"perm\": \"0600\""}],"source_content_type":"text/x-jinja2","patch_set":25,"id":"3f4c43b2_fd6cbc09","line":30,"range":{"start_line":30,"start_character":56,"end_line":30,"end_character":68},"updated":"2020-04-14 13:42:21.000000000","message":"heat-api-cfn-key.pem","commit_id":"6607a547cdf5abbeaef785baed5d03d9ffa8220e"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"9d452cbb6582cf6a777555c9386fd417660e5c96","unresolved":false,"context_lines":[{"line_number":28,"context_line":"        },"},{"line_number":29,"context_line":"        {"},{"line_number":30,"context_line":"            \"source\": \"{{ container_config_directory }}/heat-api.key\","},{"line_number":31,"context_line":"            \"dest\": \"/etc/heat/certs/heat.key\","},{"line_number":32,"context_line":"            \"owner\": \"heat\","},{"line_number":33,"context_line":"            \"perm\": \"0600\""},{"line_number":34,"context_line":"        }"}],"source_content_type":"text/x-jinja2","patch_set":25,"id":"3f4c43b2_1d7368e9","line":31,"range":{"start_line":31,"start_character":37,"end_line":31,"end_character":45},"updated":"2020-04-14 13:42:21.000000000","message":"heat-api-cfn-key.pem","commit_id":"6607a547cdf5abbeaef785baed5d03d9ffa8220e"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"fe39f2807e92a40e0c5df30ac0b8c4be0acffd8b","unresolved":false,"context_lines":[{"line_number":22,"context_line":"        }{% endif %}{% if heat_enable_tls_backend | bool %},"},{"line_number":23,"context_line":"        {"},{"line_number":24,"context_line":"            \"source\": \"{{ container_config_directory }}/heat-cert.pem\","},{"line_number":25,"context_line":"            \"dest\": \"/etc/heat/certs/heat-api-cfn-cert.pem\","},{"line_number":26,"context_line":"            \"owner\": \"heat\","},{"line_number":27,"context_line":"            \"perm\": \"0600\""},{"line_number":28,"context_line":"        },"}],"source_content_type":"text/x-jinja2","patch_set":27,"id":"3f4c43b2_3793cafc","line":25,"range":{"start_line":25,"start_character":37,"end_line":25,"end_character":54},"updated":"2020-04-15 13:48:44.000000000","message":"Looks like it should just be heat-cert.pem.","commit_id":"1b85f89a6437f659479dd9ddbf4fee1db3f6ae9e"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"fe39f2807e92a40e0c5df30ac0b8c4be0acffd8b","unresolved":false,"context_lines":[{"line_number":28,"context_line":"        },"},{"line_number":29,"context_line":"        {"},{"line_number":30,"context_line":"            \"source\": \"{{ container_config_directory }}/heat-key.pem\","},{"line_number":31,"context_line":"            \"dest\": \"/etc/heat/certs/heat-api-cfn-key.pem\","},{"line_number":32,"context_line":"            \"owner\": \"heat\","},{"line_number":33,"context_line":"            \"perm\": \"0600\""},{"line_number":34,"context_line":"        }"}],"source_content_type":"text/x-jinja2","patch_set":27,"id":"3f4c43b2_97bbbe70","line":31,"range":{"start_line":31,"start_character":37,"end_line":31,"end_character":53},"updated":"2020-04-15 13:48:44.000000000","message":"heat-key.pem","commit_id":"1b85f89a6437f659479dd9ddbf4fee1db3f6ae9e"}],"ansible/roles/heat/templates/heat-api.json.j2":[{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"9d452cbb6582cf6a777555c9386fd417660e5c96","unresolved":false,"context_lines":[{"line_number":19,"context_line":"            \"dest\": \"/etc/heat/{{ heat_policy_file }}\","},{"line_number":20,"context_line":"            \"owner\": \"heat\","},{"line_number":21,"context_line":"            \"perm\": \"0600\""},{"line_number":22,"context_line":"        }{% endif %}{% if heat_tls_backend_enabled | bool %},"},{"line_number":23,"context_line":"        {"},{"line_number":24,"context_line":"            \"source\": \"{{ container_config_directory }}/heat-api.pem\","},{"line_number":25,"context_line":"            \"dest\": \"/etc/heat/certs/heat.pem\","},{"line_number":26,"context_line":"            \"owner\": \"heat\","},{"line_number":27,"context_line":"            \"perm\": \"0600\""},{"line_number":28,"context_line":"        },"},{"line_number":29,"context_line":"        {"},{"line_number":30,"context_line":"            \"source\": \"{{ container_config_directory }}/heat-api.key\","},{"line_number":31,"context_line":"            \"dest\": \"/etc/heat/certs/heat.key\","},{"line_number":32,"context_line":"            \"owner\": \"heat\","},{"line_number":33,"context_line":"            \"perm\": \"0600\""},{"line_number":34,"context_line":"        }"},{"line_number":35,"context_line":"        {% endif %}"},{"line_number":36,"context_line":"    ],"},{"line_number":37,"context_line":"    \"permissions\": ["},{"line_number":38,"context_line":"        {"}],"source_content_type":"text/x-jinja2","patch_set":25,"id":"3f4c43b2_dd4aa07e","line":35,"range":{"start_line":22,"start_character":0,"end_line":35,"end_character":19},"updated":"2020-04-14 13:42:21.000000000","message":"As in previous file","commit_id":"6607a547cdf5abbeaef785baed5d03d9ffa8220e"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"fe39f2807e92a40e0c5df30ac0b8c4be0acffd8b","unresolved":false,"context_lines":[{"line_number":22,"context_line":"        }{% endif %}{% if heat_enable_tls_backend | bool %},"},{"line_number":23,"context_line":"        {"},{"line_number":24,"context_line":"            \"source\": \"{{ container_config_directory }}/heat-cert.pem\","},{"line_number":25,"context_line":"            \"dest\": \"/etc/heat/certs/heat-api-cert.pem\","},{"line_number":26,"context_line":"            \"owner\": \"heat\","},{"line_number":27,"context_line":"            \"perm\": \"0600\""},{"line_number":28,"context_line":"        },"}],"source_content_type":"text/x-jinja2","patch_set":27,"id":"3f4c43b2_9770dede","line":25,"range":{"start_line":25,"start_character":37,"end_line":25,"end_character":54},"updated":"2020-04-15 13:48:44.000000000","message":"heat-cert.pem","commit_id":"1b85f89a6437f659479dd9ddbf4fee1db3f6ae9e"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"fe39f2807e92a40e0c5df30ac0b8c4be0acffd8b","unresolved":false,"context_lines":[{"line_number":28,"context_line":"        },"},{"line_number":29,"context_line":"        {"},{"line_number":30,"context_line":"            \"source\": \"{{ container_config_directory }}/heat-key.pem\","},{"line_number":31,"context_line":"            \"dest\": \"/etc/heat/certs/heat-api-key.pem\","},{"line_number":32,"context_line":"            \"owner\": \"heat\","},{"line_number":33,"context_line":"            \"perm\": \"0600\""},{"line_number":34,"context_line":"        }"}],"source_content_type":"text/x-jinja2","patch_set":27,"id":"3f4c43b2_37810a91","line":31,"range":{"start_line":31,"start_character":37,"end_line":31,"end_character":53},"updated":"2020-04-15 13:48:44.000000000","message":"heat-key.pem","commit_id":"1b85f89a6437f659479dd9ddbf4fee1db3f6ae9e"}],"ansible/roles/heat/templates/wsgi-heat-api-cfn.conf.j2":[{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"cf2048ce79d9cd0ba25e734a0ac2c862fb997210","unresolved":false,"context_lines":[{"line_number":13,"context_line":"ServerSignature Off"},{"line_number":14,"context_line":"ServerTokens Prod"},{"line_number":15,"context_line":"TraceEnable off"},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"\u003cDirectory \"{{ binary_path }}\"\u003e"},{"line_number":18,"context_line":"    \u003cFilesMatch \"heat-wsgi-api-cfn\"\u003e"},{"line_number":19,"context_line":"        AllowOverride None"}],"source_content_type":"text/x-jinja2","patch_set":23,"id":"1fa4df85_e2ae1a2d","line":16,"updated":"2020-02-26 09:56:57.000000000","message":"please add:\nErrorLog \"{{ heat_log_dir }}/apache-error.log\"\n\u003cIfModule log_config_module\u003e\n    CustomLog \"{{ heat_log_dir }}/apache-access.log\" common\n\u003c/IfModule\u003e","commit_id":"ca76e6cf957a158a12a8957b6c78299f7368b35b"},{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"cf2048ce79d9cd0ba25e734a0ac2c862fb997210","unresolved":false,"context_lines":[{"line_number":15,"context_line":"TraceEnable off"},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"\u003cDirectory \"{{ binary_path }}\"\u003e"},{"line_number":18,"context_line":"    \u003cFilesMatch \"heat-wsgi-api-cfn\"\u003e"},{"line_number":19,"context_line":"        AllowOverride None"},{"line_number":20,"context_line":"        Options None"},{"line_number":21,"context_line":"        Require all granted"}],"source_content_type":"text/x-jinja2","patch_set":23,"id":"1fa4df85_a2a8221f","line":18,"updated":"2020-02-26 09:56:57.000000000","message":"^","commit_id":"ca76e6cf957a158a12a8957b6c78299f7368b35b"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"9d452cbb6582cf6a777555c9386fd417660e5c96","unresolved":false,"context_lines":[{"line_number":1,"context_line":"{% set heat_log_dir \u003d \u0027/var/log/kolla/heat\u0027 %}"},{"line_number":2,"context_line":"{% if heat_install_type \u003d\u003d \u0027binary\u0027 %}"},{"line_number":3,"context_line":"{% set python_path \u003d \u0027/usr/lib/python3/dist-packages\u0027 if kolla_base_distro in [\u0027debian\u0027, \u0027ubuntu\u0027] else \u0027/usr/lib/python2.7/site-packages\u0027 %}"},{"line_number":4,"context_line":"{% else %}"},{"line_number":5,"context_line":"{% set python_path \u003d \u0027/var/lib/kolla/venv/lib/python\u0027 + distro_python_version + \u0027/site-packages\u0027 %}"},{"line_number":6,"context_line":"{% endif %}"}],"source_content_type":"text/x-jinja2","patch_set":25,"id":"3f4c43b2_9d35b8fa","line":3,"range":{"start_line":3,"start_character":104,"end_line":3,"end_character":138},"updated":"2020-04-14 13:42:21.000000000","message":"\u0027/usr/lib/python\u0027 ~ distro_python_version ~ \u0027/site-packages\u0027","commit_id":"6607a547cdf5abbeaef785baed5d03d9ffa8220e"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"9d452cbb6582cf6a777555c9386fd417660e5c96","unresolved":false,"context_lines":[{"line_number":5,"context_line":"{% set python_path \u003d \u0027/var/lib/kolla/venv/lib/python\u0027 + distro_python_version + \u0027/site-packages\u0027 %}"},{"line_number":6,"context_line":"{% endif %}"},{"line_number":7,"context_line":"{% set binary_path \u003d \u0027/usr/bin\u0027 if heat_install_type \u003d\u003d \u0027binary\u0027 else \u0027/var/lib/kolla/venv/bin\u0027 %}"},{"line_number":8,"context_line":"{% if heat_tls_backend_enabled | bool %}"},{"line_number":9,"context_line":"LoadModule ssl_module /usr/lib/apache2/modules/mod_ssl.so"},{"line_number":10,"context_line":"{% endif %}"},{"line_number":11,"context_line":"Listen {{ api_interface_address | put_address_in_context(\u0027url\u0027) }}:{{ heat_api_cfn_listen_port }}"}],"source_content_type":"text/x-jinja2","patch_set":25,"id":"3f4c43b2_1d21a8b5","line":8,"range":{"start_line":8,"start_character":6,"end_line":8,"end_character":30},"updated":"2020-04-14 13:42:21.000000000","message":"heat_enable_tls_backend","commit_id":"6607a547cdf5abbeaef785baed5d03d9ffa8220e"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"9d452cbb6582cf6a777555c9386fd417660e5c96","unresolved":false,"context_lines":[{"line_number":35,"context_line":"    ErrorLog \"{{ heat_log_dir }}/heat-api-cfn-error.log\""},{"line_number":36,"context_line":"    LogFormat \"%{X-Forwarded-For}i %l %u %t \\\"%r\\\" %\u003es %b %D \\\"%{Referer}i\\\" \\\"%{User-Agent}i\\\"\" logformat"},{"line_number":37,"context_line":"    CustomLog \"{{ heat_log_dir }}/heat-api-cfn-error.log\" logformat"},{"line_number":38,"context_line":"{% if heat_tls_backend_enabled | bool %}"},{"line_number":39,"context_line":"    SSLEngine On"},{"line_number":40,"context_line":"    SSLCertificateFile /etc/heat/certs/heat.pem"},{"line_number":41,"context_line":"    SSLCertificateKeyFile /etc/heat/certs/heat.key"}],"source_content_type":"text/x-jinja2","patch_set":25,"id":"3f4c43b2_0022dfa4","line":38,"range":{"start_line":38,"start_character":6,"end_line":38,"end_character":30},"updated":"2020-04-14 13:42:21.000000000","message":"heat_enable_tls_backend","commit_id":"6607a547cdf5abbeaef785baed5d03d9ffa8220e"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"9d452cbb6582cf6a777555c9386fd417660e5c96","unresolved":false,"context_lines":[{"line_number":37,"context_line":"    CustomLog \"{{ heat_log_dir }}/heat-api-cfn-error.log\" logformat"},{"line_number":38,"context_line":"{% if heat_tls_backend_enabled | bool %}"},{"line_number":39,"context_line":"    SSLEngine On"},{"line_number":40,"context_line":"    SSLCertificateFile /etc/heat/certs/heat.pem"},{"line_number":41,"context_line":"    SSLCertificateKeyFile /etc/heat/certs/heat.key"},{"line_number":42,"context_line":"{% endif %}"},{"line_number":43,"context_line":"\u003c/VirtualHost\u003e"}],"source_content_type":"text/x-jinja2","patch_set":25,"id":"3f4c43b2_2038bbd1","line":40,"range":{"start_line":40,"start_character":39,"end_line":40,"end_character":47},"updated":"2020-04-14 13:42:21.000000000","message":"heat-api-cfn-cert.pem","commit_id":"6607a547cdf5abbeaef785baed5d03d9ffa8220e"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"9d452cbb6582cf6a777555c9386fd417660e5c96","unresolved":false,"context_lines":[{"line_number":38,"context_line":"{% if heat_tls_backend_enabled | bool %}"},{"line_number":39,"context_line":"    SSLEngine On"},{"line_number":40,"context_line":"    SSLCertificateFile /etc/heat/certs/heat.pem"},{"line_number":41,"context_line":"    SSLCertificateKeyFile /etc/heat/certs/heat.key"},{"line_number":42,"context_line":"{% endif %}"},{"line_number":43,"context_line":"\u003c/VirtualHost\u003e"}],"source_content_type":"text/x-jinja2","patch_set":25,"id":"3f4c43b2_6032c3f3","line":41,"range":{"start_line":41,"start_character":42,"end_line":41,"end_character":50},"updated":"2020-04-14 13:42:21.000000000","message":"heat-api-cfn-key.pem","commit_id":"6607a547cdf5abbeaef785baed5d03d9ffa8220e"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"fe39f2807e92a40e0c5df30ac0b8c4be0acffd8b","unresolved":false,"context_lines":[{"line_number":41,"context_line":"    CustomLog \"{{ heat_log_dir }}/heat-api-cfn-error.log\" logformat"},{"line_number":42,"context_line":"{% if heat_enable_tls_backend | bool %}"},{"line_number":43,"context_line":"    SSLEngine On"},{"line_number":44,"context_line":"    SSLCertificateFile /etc/heat/certs/heat-api-cfn-cert.pem"},{"line_number":45,"context_line":"    SSLCertificateKeyFile /etc/heat/certs/heat-api-cfn-key.pem"},{"line_number":46,"context_line":"{% endif %}"},{"line_number":47,"context_line":"\u003c/VirtualHost\u003e"}],"source_content_type":"text/x-jinja2","patch_set":27,"id":"3f4c43b2_774c329e","line":44,"range":{"start_line":44,"start_character":39,"end_line":44,"end_character":60},"updated":"2020-04-15 13:48:44.000000000","message":"heat-cert.pem","commit_id":"1b85f89a6437f659479dd9ddbf4fee1db3f6ae9e"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"fe39f2807e92a40e0c5df30ac0b8c4be0acffd8b","unresolved":false,"context_lines":[{"line_number":42,"context_line":"{% if heat_enable_tls_backend | bool %}"},{"line_number":43,"context_line":"    SSLEngine On"},{"line_number":44,"context_line":"    SSLCertificateFile /etc/heat/certs/heat-api-cfn-cert.pem"},{"line_number":45,"context_line":"    SSLCertificateKeyFile /etc/heat/certs/heat-api-cfn-key.pem"},{"line_number":46,"context_line":"{% endif %}"},{"line_number":47,"context_line":"\u003c/VirtualHost\u003e"}],"source_content_type":"text/x-jinja2","patch_set":27,"id":"3f4c43b2_b746ba7b","line":45,"range":{"start_line":45,"start_character":42,"end_line":45,"end_character":62},"updated":"2020-04-15 13:48:44.000000000","message":"heat-key.pem","commit_id":"1b85f89a6437f659479dd9ddbf4fee1db3f6ae9e"}],"ansible/roles/heat/templates/wsgi-heat-api.conf.j2":[{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"cf2048ce79d9cd0ba25e734a0ac2c862fb997210","unresolved":false,"context_lines":[{"line_number":13,"context_line":"ServerSignature Off"},{"line_number":14,"context_line":"ServerTokens Prod"},{"line_number":15,"context_line":"TraceEnable off"},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"\u003cDirectory \"{{ binary_path }}\"\u003e"},{"line_number":18,"context_line":"    \u003cFilesMatch \"heat-wsgi-api\"\u003e"},{"line_number":19,"context_line":"        AllowOverride None"}],"source_content_type":"text/x-jinja2","patch_set":23,"id":"1fa4df85_e2737ae6","line":16,"updated":"2020-02-26 09:56:57.000000000","message":"ditto: missing error and access log for main host","commit_id":"ca76e6cf957a158a12a8957b6c78299f7368b35b"},{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"cf2048ce79d9cd0ba25e734a0ac2c862fb997210","unresolved":false,"context_lines":[{"line_number":15,"context_line":"TraceEnable off"},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"\u003cDirectory \"{{ binary_path }}\"\u003e"},{"line_number":18,"context_line":"    \u003cFilesMatch \"heat-wsgi-api\"\u003e"},{"line_number":19,"context_line":"        AllowOverride None"},{"line_number":20,"context_line":"        Options None"},{"line_number":21,"context_line":"        Require all granted"}],"source_content_type":"text/x-jinja2","patch_set":23,"id":"1fa4df85_2272f2e6","line":18,"updated":"2020-02-26 09:56:57.000000000","message":"^","commit_id":"ca76e6cf957a158a12a8957b6c78299f7368b35b"},{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"cf2048ce79d9cd0ba25e734a0ac2c862fb997210","unresolved":false,"context_lines":[{"line_number":39,"context_line":"    SSLEngine On"},{"line_number":40,"context_line":"    SSLCertificateFile /etc/heat/certs/heat.pem"},{"line_number":41,"context_line":"    SSLCertificateKeyFile /etc/heat/certs/heat.key"},{"line_number":42,"context_line":"{% endif %} "},{"line_number":43,"context_line":"\u003c/VirtualHost\u003e"}],"source_content_type":"text/x-jinja2","patch_set":23,"id":"1fa4df85_8280868d","line":42,"range":{"start_line":42,"start_character":11,"end_line":42,"end_character":12},"updated":"2020-02-26 09:56:57.000000000","message":"whitespace","commit_id":"ca76e6cf957a158a12a8957b6c78299f7368b35b"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"9d452cbb6582cf6a777555c9386fd417660e5c96","unresolved":false,"context_lines":[{"line_number":1,"context_line":"{% set heat_log_dir \u003d \u0027/var/log/kolla/heat\u0027 %}"},{"line_number":2,"context_line":"{% if heat_install_type \u003d\u003d \u0027binary\u0027 %}"},{"line_number":3,"context_line":"{% set python_path \u003d \u0027/usr/lib/python3/dist-packages\u0027 if kolla_base_distro in [\u0027debian\u0027, \u0027ubuntu\u0027] else \u0027/usr/lib/python2.7/site-packages\u0027 %}"},{"line_number":4,"context_line":"{% else %}"}],"source_content_type":"text/x-jinja2","patch_set":25,"id":"3f4c43b2_80b8af2a","line":1,"updated":"2020-04-14 13:42:21.000000000","message":"Same comments from previous file apply.","commit_id":"6607a547cdf5abbeaef785baed5d03d9ffa8220e"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"9d452cbb6582cf6a777555c9386fd417660e5c96","unresolved":false,"context_lines":[{"line_number":39,"context_line":"    SSLEngine On"},{"line_number":40,"context_line":"    SSLCertificateFile /etc/heat/certs/heat.pem"},{"line_number":41,"context_line":"    SSLCertificateKeyFile /etc/heat/certs/heat.key"},{"line_number":42,"context_line":"{% endif %} "},{"line_number":43,"context_line":"\u003c/VirtualHost\u003e"}],"source_content_type":"text/x-jinja2","patch_set":25,"id":"3f4c43b2_80638fdc","line":42,"range":{"start_line":42,"start_character":11,"end_line":42,"end_character":12},"updated":"2020-04-14 13:42:21.000000000","message":"nit: extra space","commit_id":"6607a547cdf5abbeaef785baed5d03d9ffa8220e"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"fe39f2807e92a40e0c5df30ac0b8c4be0acffd8b","unresolved":false,"context_lines":[{"line_number":41,"context_line":"    CustomLog \"{{ heat_log_dir }}/heat-api-error.log\" logformat"},{"line_number":42,"context_line":"{% if heat_enable_tls_backend | bool %}"},{"line_number":43,"context_line":"    SSLEngine On"},{"line_number":44,"context_line":"    SSLCertificateFile /etc/heat/certs/heat-api-cert.pem"},{"line_number":45,"context_line":"    SSLCertificateKeyFile /etc/heat/certs/heat-api-key.pem"},{"line_number":46,"context_line":"{% endif %}"},{"line_number":47,"context_line":"\u003c/VirtualHost\u003e"}],"source_content_type":"text/x-jinja2","patch_set":27,"id":"3f4c43b2_d75a664e","line":44,"range":{"start_line":44,"start_character":39,"end_line":44,"end_character":56},"updated":"2020-04-15 13:48:44.000000000","message":"heat-cert.pem","commit_id":"1b85f89a6437f659479dd9ddbf4fee1db3f6ae9e"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"fe39f2807e92a40e0c5df30ac0b8c4be0acffd8b","unresolved":false,"context_lines":[{"line_number":42,"context_line":"{% if heat_enable_tls_backend | bool %}"},{"line_number":43,"context_line":"    SSLEngine On"},{"line_number":44,"context_line":"    SSLCertificateFile /etc/heat/certs/heat-api-cert.pem"},{"line_number":45,"context_line":"    SSLCertificateKeyFile /etc/heat/certs/heat-api-key.pem"},{"line_number":46,"context_line":"{% endif %}"},{"line_number":47,"context_line":"\u003c/VirtualHost\u003e"}],"source_content_type":"text/x-jinja2","patch_set":27,"id":"3f4c43b2_7731d20b","line":45,"range":{"start_line":45,"start_character":42,"end_line":45,"end_character":58},"updated":"2020-04-15 13:48:44.000000000","message":"heat-key.pem","commit_id":"1b85f89a6437f659479dd9ddbf4fee1db3f6ae9e"}],"ansible/roles/service-cert-copy/tasks/main.yml":[{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"39cbe641e99a5485a38b07b775f3f159f0c83ed2","unresolved":false,"context_lines":[{"line_number":25,"context_line":"    mode: \"0644\""},{"line_number":26,"context_line":"  become: true"},{"line_number":27,"context_line":"  when:"},{"line_number":28,"context_line":"    - (item.value.haproxy is defined and item.value.haproxy.values() | selectattr(\u0027enabled\u0027, \u0027defined\u0027) | map(attribute\u003d\u0027enabled\u0027) | map(\u0027bool\u0027) | select | list | length \u003e 0 and item.value.haproxy.values() | selectattr(\u0027tls_backend\u0027, \u0027defined\u0027) | map(attribute\u003d\u0027tls_backend\u0027) | map(\u0027bool\u0027) | select | list | length \u003e 0) or (item.value.tls_backend is defined and item.value.tls_backend | bool)"},{"line_number":29,"context_line":"  with_dict: \"{{ project_services | select_services_enabled_and_mapped_to_host }}\""},{"line_number":30,"context_line":"  notify:"},{"line_number":31,"context_line":"    - \"Restart {{ item.key }} container\""}],"source_content_type":"text/x-yaml","patch_set":32,"id":"1f493fa4_849e2c05","line":28,"updated":"2020-04-20 18:31:44.000000000","message":"line far too long!\n\nI wonder if we should add a haproxy field to the stunnel service, and use it for tls. Disable the glance-api one if tls is enabled. Keeps this core logic neat.","commit_id":"92564fc73b62d39387744c95e9beb813a1a965a1"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"60fbfc6443a81ff48c0cbdf14640c2d751d94f4f","unresolved":false,"context_lines":[{"line_number":26,"context_line":"  become: true"},{"line_number":27,"context_line":"  when:"},{"line_number":28,"context_line":"    - item.value.haproxy is defined"},{"line_number":29,"context_line":"    - item.value.haproxy.values() | selectattr(\u0027tls_backend\u0027, \u0027defined\u0027) | map(attribute\u003d\u0027tls_backend\u0027) | map(\u0027bool\u0027) | select | list | length \u003e 0"},{"line_number":30,"context_line":"  with_dict: \"{{ project_services | select_services_enabled_and_mapped_to_host }}\""},{"line_number":31,"context_line":"  notify:"},{"line_number":32,"context_line":"    - \"Restart {{ item.key }} container\""}],"source_content_type":"text/x-yaml","patch_set":33,"id":"1f493fa4_b00d5439","line":29,"updated":"2020-04-21 11:15:39.000000000","message":"Looks like we lost a line. We don\u0027t need to copy certs if the backend is disabled.","commit_id":"7b1be3e548c63b97ce645bd600a00587762e991b"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"60fbfc6443a81ff48c0cbdf14640c2d751d94f4f","unresolved":false,"context_lines":[{"line_number":45,"context_line":"    mode: \"0600\""},{"line_number":46,"context_line":"  become: true"},{"line_number":47,"context_line":"  when:"},{"line_number":48,"context_line":"   - item.value.haproxy is defined"},{"line_number":49,"context_line":"   - item.value.haproxy.values() | selectattr(\u0027tls_backend\u0027, \u0027defined\u0027) | map(attribute\u003d\u0027tls_backend\u0027) | map(\u0027bool\u0027) | select | list | length \u003e 0"},{"line_number":50,"context_line":"  with_dict: \"{{ project_services | select_services_enabled_and_mapped_to_host }}\""},{"line_number":51,"context_line":"  notify:"}],"source_content_type":"text/x-yaml","patch_set":33,"id":"1f493fa4_10124859","line":48,"updated":"2020-04-21 11:15:39.000000000","message":"ditto","commit_id":"7b1be3e548c63b97ce645bd600a00587762e991b"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"60fbfc6443a81ff48c0cbdf14640c2d751d94f4f","unresolved":false,"context_lines":[{"line_number":46,"context_line":"  become: true"},{"line_number":47,"context_line":"  when:"},{"line_number":48,"context_line":"   - item.value.haproxy is defined"},{"line_number":49,"context_line":"   - item.value.haproxy.values() | selectattr(\u0027tls_backend\u0027, \u0027defined\u0027) | map(attribute\u003d\u0027tls_backend\u0027) | map(\u0027bool\u0027) | select | list | length \u003e 0"},{"line_number":50,"context_line":"  with_dict: \"{{ project_services | select_services_enabled_and_mapped_to_host }}\""},{"line_number":51,"context_line":"  notify:"},{"line_number":52,"context_line":"    - \"Restart {{ item.key }} container\""}],"source_content_type":"text/x-yaml","patch_set":33,"id":"1f493fa4_f00ebc30","line":49,"updated":"2020-04-21 11:15:39.000000000","message":"indentation busted","commit_id":"7b1be3e548c63b97ce645bd600a00587762e991b"}],"releasenotes/notes/encrypt-backend-haproxy-keystone-fb96285d74fb464c.yaml":[{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"60fbfc6443a81ff48c0cbdf14640c2d751d94f4f","unresolved":false,"context_lines":[{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Added configuration options to enable backend TLS encryption from HAProxy"},{"line_number":5,"context_line":"    to the Keystone and cinder service. When used in conjunction with enabling"},{"line_number":6,"context_line":"    TLS for service API endpoints, network communcation will be encrypted end"},{"line_number":7,"context_line":"    to end, from client through HAProxy to the backend service."}],"source_content_type":"text/x-yaml","patch_set":33,"id":"1f493fa4_30194479","side":"PARENT","line":5,"range":{"start_line":5,"start_character":24,"end_line":5,"end_character":30},"updated":"2020-04-21 11:15:39.000000000","message":"cinder merged - need to include it","commit_id":"bb6e23fb2990d5019c8190e5e881bf9fe99d39db"}]}
