)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":17669,"name":"Doug Szumski","email":"doug@stackhpc.com","username":"DougSzumski"},"change_message_id":"20d1c5e4d8da81dfd41237c2c82246832e1c6c2e","unresolved":false,"context_lines":[{"line_number":17,"context_line":"raise exceptions if utilized in 6.x."},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"The upgrade process has been updated to follow 6.x best practices. The"},{"line_number":20,"context_line":"only difference is now ML jobs must be explicitly disabled and"},{"line_number":21,"context_line":"re-enabled after ES finishes its restart. This will add some additional"},{"line_number":22,"context_line":"latency to an upgrade run, as ES takes some time to restart (~30"},{"line_number":23,"context_line":"seconds, I\u0027ve found.)"},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"[1]:"},{"line_number":26,"context_line":"https://www.elastic.co/guide/en/elasticsearch/reference/6.x/settings.html#config-files-location"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"1fa4df85_a13d8ebc","line":23,"range":{"start_line":20,"start_character":1,"end_line":23,"end_character":21},"updated":"2020-02-25 16:37:18.000000000","message":"micronit: We still mention ML.","commit_id":"a09a86ca5cedf94f767e83a0c4be4e055c6c78d1"},{"author":{"_account_id":29100,"name":"Jason Anderson","email":"jasonanderson@uchicago.edu","username":"jasonanderson"},"change_message_id":"1299d7d8e752f2bee7012c727795345faa6e5dd8","unresolved":false,"context_lines":[{"line_number":17,"context_line":"raise exceptions if utilized in 6.x."},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"The upgrade process has been updated to follow 6.x best practices. The"},{"line_number":20,"context_line":"only difference is now ML jobs must be explicitly disabled and"},{"line_number":21,"context_line":"re-enabled after ES finishes its restart. This will add some additional"},{"line_number":22,"context_line":"latency to an upgrade run, as ES takes some time to restart (~30"},{"line_number":23,"context_line":"seconds, I\u0027ve found.)"},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"[1]:"},{"line_number":26,"context_line":"https://www.elastic.co/guide/en/elasticsearch/reference/6.x/settings.html#config-files-location"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"1fa4df85_21d75e4e","line":23,"range":{"start_line":20,"start_character":1,"end_line":23,"end_character":21},"in_reply_to":"1fa4df85_a13d8ebc","updated":"2020-02-25 16:43:32.000000000","message":"Done","commit_id":"a09a86ca5cedf94f767e83a0c4be4e055c6c78d1"},{"author":{"_account_id":17669,"name":"Doug Szumski","email":"doug@stackhpc.com","username":"DougSzumski"},"change_message_id":"20d1c5e4d8da81dfd41237c2c82246832e1c6c2e","unresolved":false,"context_lines":[{"line_number":24,"context_line":""},{"line_number":25,"context_line":"[1]:"},{"line_number":26,"context_line":"https://www.elastic.co/guide/en/elasticsearch/reference/6.x/settings.html#config-files-location"},{"line_number":27,"context_line":""},{"line_number":28,"context_line":"Implements: blueprint elasticsearch-kibana-version-upgrade"},{"line_number":29,"context_line":"Change-Id: I4f74bfe07d4b7ca18953b11e767cf0bb94dfd67e"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"1fa4df85_6147964d","line":27,"updated":"2020-02-25 16:37:18.000000000","message":"Shall we add a depends on to stop this getting merged early by accident?\n\nDepends-On: https://review.opendev.org/#/c/647748/","commit_id":"a09a86ca5cedf94f767e83a0c4be4e055c6c78d1"},{"author":{"_account_id":29100,"name":"Jason Anderson","email":"jasonanderson@uchicago.edu","username":"jasonanderson"},"change_message_id":"1299d7d8e752f2bee7012c727795345faa6e5dd8","unresolved":false,"context_lines":[{"line_number":24,"context_line":""},{"line_number":25,"context_line":"[1]:"},{"line_number":26,"context_line":"https://www.elastic.co/guide/en/elasticsearch/reference/6.x/settings.html#config-files-location"},{"line_number":27,"context_line":""},{"line_number":28,"context_line":"Implements: blueprint elasticsearch-kibana-version-upgrade"},{"line_number":29,"context_line":"Change-Id: I4f74bfe07d4b7ca18953b11e767cf0bb94dfd67e"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"1fa4df85_01d2625d","line":27,"in_reply_to":"1fa4df85_6147964d","updated":"2020-02-25 16:43:32.000000000","message":"Done","commit_id":"a09a86ca5cedf94f767e83a0c4be4e055c6c78d1"}],"ansible/roles/elasticsearch/tasks/upgrade.yml":[{"author":{"_account_id":17669,"name":"Doug Szumski","email":"doug@stackhpc.com","username":"DougSzumski"},"change_message_id":"76ae0633602ca1b59d3f17125ae1856b749d5eca","unresolved":false,"context_lines":[{"line_number":36,"context_line":"  register: result"},{"line_number":37,"context_line":"  until: (\u0027status\u0027 in result) and result.status \u003d\u003d 200"},{"line_number":38,"context_line":""},{"line_number":39,"context_line":"- name: Stop any machine learning jobs that are running"},{"line_number":40,"context_line":"  become: true"},{"line_number":41,"context_line":"  kolla_toolbox:"},{"line_number":42,"context_line":"    module_name: uri"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"1fa4df85_271bf61b","line":39,"updated":"2020-02-25 11:52:35.000000000","message":"Am I correct that this is a paid feature in 5.x? What does the free version of ES 5.x do when you call this?","commit_id":"2030bec6951ca7f3100feb242359282ce6c7faec"},{"author":{"_account_id":29100,"name":"Jason Anderson","email":"jasonanderson@uchicago.edu","username":"jasonanderson"},"change_message_id":"5bebaa977a252fd81b76dc7bd7c49fd565b26a25","unresolved":false,"context_lines":[{"line_number":36,"context_line":"  register: result"},{"line_number":37,"context_line":"  until: (\u0027status\u0027 in result) and result.status \u003d\u003d 200"},{"line_number":38,"context_line":""},{"line_number":39,"context_line":"- name: Stop any machine learning jobs that are running"},{"line_number":40,"context_line":"  become: true"},{"line_number":41,"context_line":"  kolla_toolbox:"},{"line_number":42,"context_line":"    module_name: uri"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"1fa4df85_765f5a41","line":39,"in_reply_to":"1fa4df85_271bf61b","updated":"2020-02-25 16:28:46.000000000","message":"Ah yes, you are correct. It\u0027s also only in paid versions of 6.x+, so we can safely delete it. I had just copied it from the prior release.\n\nFYI in 5.x, this call returns a 400. Adding `status_code: [200, 400]` would make it work for 5.x and 6.x, but as you point out, we can simply remove. Will update.","commit_id":"2030bec6951ca7f3100feb242359282ce6c7faec"},{"author":{"_account_id":17669,"name":"Doug Szumski","email":"doug@stackhpc.com","username":"DougSzumski"},"change_message_id":"76ae0633602ca1b59d3f17125ae1856b749d5eca","unresolved":false,"context_lines":[{"line_number":82,"context_line":"  register: result"},{"line_number":83,"context_line":"  until: (\u0027status\u0027 in result) and result.status \u003d\u003d 200"},{"line_number":84,"context_line":""},{"line_number":85,"context_line":"- name: Restart machine learning jobs"},{"line_number":86,"context_line":"  become: true"},{"line_number":87,"context_line":"  kolla_toolbox:"},{"line_number":88,"context_line":"    module_name: uri"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"1fa4df85_4718721c","line":85,"updated":"2020-02-25 11:52:35.000000000","message":"Same comment as above.","commit_id":"2030bec6951ca7f3100feb242359282ce6c7faec"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"86fc131b0597525329b4a2d307e0f197fa2a4059","unresolved":false,"context_lines":[{"line_number":3,"context_line":"  set_fact:"},{"line_number":4,"context_line":"    elasticsearch_url: \"{{ internal_protocol }}://{{ kolla_internal_vip_address | put_address_in_context(\u0027url\u0027) }}:{{ elasticsearch_port }}\""},{"line_number":5,"context_line":""},{"line_number":6,"context_line":"# The official procedure for upgrade elasticsearch:"},{"line_number":7,"context_line":"# https://www.elastic.co/guide/en/elasticsearch/reference/6.x/restart-upgrade.html"},{"line_number":8,"context_line":"- name: Disable shard allocation"},{"line_number":9,"context_line":"  become: true"},{"line_number":10,"context_line":"  kolla_toolbox:"},{"line_number":11,"context_line":"    module_name: uri"},{"line_number":12,"context_line":"    module_args:"},{"line_number":13,"context_line":"      url: \"{{ elasticsearch_url }}/_cluster/settings\""},{"line_number":14,"context_line":"      method: PUT"},{"line_number":15,"context_line":"      status_code: 200"},{"line_number":16,"context_line":"      return_content: yes"},{"line_number":17,"context_line":"      body: {\"transient\": {\"cluster.routing.allocation.enable\": \"primaries\"}}"},{"line_number":18,"context_line":"      body_format: json"},{"line_number":19,"context_line":"  delegate_to: \"{{ groups[\u0027elasticsearch\u0027][0] }}\""},{"line_number":20,"context_line":"  run_once: true"},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"- name: Perform a synced flush"},{"line_number":23,"context_line":"  become: true"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"1fa4df85_cbf08000","line":20,"range":{"start_line":6,"start_character":0,"end_line":20,"end_character":16},"updated":"2020-03-03 16:53:24.000000000","message":"Upgrade guide suggests we need to enable this again after the upgrade:\n\nPUT _cluster/settings\n{\n  \"persistent\": {\n    \"cluster.routing.allocation.enable\": null\n  }\n}","commit_id":"fd87f62952000852772e2a6a41243720794fd6ef"},{"author":{"_account_id":29100,"name":"Jason Anderson","email":"jasonanderson@uchicago.edu","username":"jasonanderson"},"change_message_id":"da7938b7081aa69eb05111c8f33628ae41d5a86d","unresolved":false,"context_lines":[{"line_number":3,"context_line":"  set_fact:"},{"line_number":4,"context_line":"    elasticsearch_url: \"{{ internal_protocol }}://{{ kolla_internal_vip_address | put_address_in_context(\u0027url\u0027) }}:{{ elasticsearch_port }}\""},{"line_number":5,"context_line":""},{"line_number":6,"context_line":"# The official procedure for upgrade elasticsearch:"},{"line_number":7,"context_line":"# https://www.elastic.co/guide/en/elasticsearch/reference/6.x/restart-upgrade.html"},{"line_number":8,"context_line":"- name: Disable shard allocation"},{"line_number":9,"context_line":"  become: true"},{"line_number":10,"context_line":"  kolla_toolbox:"},{"line_number":11,"context_line":"    module_name: uri"},{"line_number":12,"context_line":"    module_args:"},{"line_number":13,"context_line":"      url: \"{{ elasticsearch_url }}/_cluster/settings\""},{"line_number":14,"context_line":"      method: PUT"},{"line_number":15,"context_line":"      status_code: 200"},{"line_number":16,"context_line":"      return_content: yes"},{"line_number":17,"context_line":"      body: {\"transient\": {\"cluster.routing.allocation.enable\": \"primaries\"}}"},{"line_number":18,"context_line":"      body_format: json"},{"line_number":19,"context_line":"  delegate_to: \"{{ groups[\u0027elasticsearch\u0027][0] }}\""},{"line_number":20,"context_line":"  run_once: true"},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"- name: Perform a synced flush"},{"line_number":23,"context_line":"  become: true"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"1fa4df85_4baa5071","line":20,"range":{"start_line":6,"start_character":0,"end_line":20,"end_character":16},"in_reply_to":"1fa4df85_cbf08000","updated":"2020-03-03 17:04:45.000000000","message":"I also had that thought, and wondered why it was never in place. I think, though, it\u0027s not needed because KA currently sets it as a \"transient\" setting, meaning it will be cleared upon restart. Since the play will ultimately do a full reboot of the ES cluster, I think it\u0027s fine to keep it as a transient setting for simplicity.","commit_id":"fd87f62952000852772e2a6a41243720794fd6ef"}],"ansible/roles/elasticsearch/templates/elasticsearch.yml.j2":[{"author":{"_account_id":17669,"name":"Doug Szumski","email":"doug@stackhpc.com","username":"DougSzumski"},"change_message_id":"76ae0633602ca1b59d3f17125ae1856b749d5eca","unresolved":false,"context_lines":[{"line_number":14,"context_line":"gateway.expected_nodes: {{ num_nodes }}"},{"line_number":15,"context_line":"gateway.recover_after_time: \"5m\""},{"line_number":16,"context_line":"gateway.recover_after_nodes: {{ recover_after_nodes }}"},{"line_number":17,"context_line":"path.conf: \"/etc/elasticsearch\""},{"line_number":18,"context_line":"path.data: \"/var/lib/elasticsearch/data\""},{"line_number":19,"context_line":"path.logs: \"/var/log/kolla/elasticsearch\""},{"line_number":20,"context_line":"path.scripts: \"/etc/elasticsearch/scripts\""}],"source_content_type":"text/x-jinja2","patch_set":1,"id":"1fa4df85_877aea21","side":"PARENT","line":17,"updated":"2020-02-25 11:52:35.000000000","message":"+1 for removing these - I hit this when upgrading to 7.","commit_id":"65b0110ebcb0ccdab68665f0d716eaca8e7d5412"}]}