)]}'
{"ansible/roles/rabbitmq/tasks/config.yml":[{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"7efb5d48bbd02179e072d81707db3cd2de813743","unresolved":false,"context_lines":[{"line_number":15,"context_line":"- name: Reading cluster configuration file"},{"line_number":16,"context_line":"  become: True"},{"line_number":17,"context_line":"  slurp:"},{"line_number":18,"context_line":"    src: /etc/kolla/rabbitmq/rabbitmq-clusterer.config"},{"line_number":19,"context_line":"  register: cluster_config"},{"line_number":20,"context_line":"  failed_when: False"},{"line_number":21,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":1,"id":"1fa4df85_c77175e0","line":18,"range":{"start_line":18,"start_character":9,"end_line":18,"end_character":54},"updated":"2020-03-18 11:43:26.000000000","message":"should be templated like below","commit_id":"c28ffd520cd60a5cc13300581b2cd268afc0bb48"},{"author":{"_account_id":31619,"name":"Grzegorz Sikorski","email":"g.sikorski@samsung.com","username":"gregors"},"change_message_id":"adfb877f3fd748330e2232090d24b17ce7041d60","unresolved":false,"context_lines":[{"line_number":15,"context_line":"- name: Reading cluster configuration file"},{"line_number":16,"context_line":"  become: True"},{"line_number":17,"context_line":"  slurp:"},{"line_number":18,"context_line":"    src: /etc/kolla/rabbitmq/rabbitmq-clusterer.config"},{"line_number":19,"context_line":"  register: cluster_config"},{"line_number":20,"context_line":"  failed_when: False"},{"line_number":21,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":1,"id":"1fa4df85_6759a158","line":18,"range":{"start_line":18,"start_character":9,"end_line":18,"end_character":54},"in_reply_to":"1fa4df85_c77175e0","updated":"2020-03-18 11:46:13.000000000","message":"Good point, I\u0027ll fix it.","commit_id":"c28ffd520cd60a5cc13300581b2cd268afc0bb48"},{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"7efb5d48bbd02179e072d81707db3cd2de813743","unresolved":false,"context_lines":[{"line_number":28,"context_line":""},{"line_number":29,"context_line":"- name: Establishing default cluster version number"},{"line_number":30,"context_line":"  set_fact:"},{"line_number":31,"context_line":"    old_cluster_version: 0"},{"line_number":32,"context_line":"  when: cluster_config[\u0027content\u0027] is not defined"},{"line_number":33,"context_line":""},{"line_number":34,"context_line":"- name: Establishing new cluster version number"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"1fa4df85_4766e52b","line":31,"range":{"start_line":31,"start_character":25,"end_line":31,"end_character":26},"updated":"2020-03-18 11:43:26.000000000","message":"I guess this should be 1 for the starting point","commit_id":"c28ffd520cd60a5cc13300581b2cd268afc0bb48"},{"author":{"_account_id":31619,"name":"Grzegorz Sikorski","email":"g.sikorski@samsung.com","username":"gregors"},"change_message_id":"a1a04e134896fa68d6533f08ae00237fea6e675b","unresolved":false,"context_lines":[{"line_number":28,"context_line":""},{"line_number":29,"context_line":"- name: Establishing default cluster version number"},{"line_number":30,"context_line":"  set_fact:"},{"line_number":31,"context_line":"    old_cluster_version: 0"},{"line_number":32,"context_line":"  when: cluster_config[\u0027content\u0027] is not defined"},{"line_number":33,"context_line":""},{"line_number":34,"context_line":"- name: Establishing new cluster version number"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"1fa4df85_a2730780","line":31,"range":{"start_line":31,"start_character":25,"end_line":31,"end_character":26},"in_reply_to":"1fa4df85_0749cd89","updated":"2020-03-18 12:14:30.000000000","message":"I reworded this bit to be more explicit. Hopefully it is less confusing now.","commit_id":"c28ffd520cd60a5cc13300581b2cd268afc0bb48"},{"author":{"_account_id":31619,"name":"Grzegorz Sikorski","email":"g.sikorski@samsung.com","username":"gregors"},"change_message_id":"adfb877f3fd748330e2232090d24b17ce7041d60","unresolved":false,"context_lines":[{"line_number":28,"context_line":""},{"line_number":29,"context_line":"- name: Establishing default cluster version number"},{"line_number":30,"context_line":"  set_fact:"},{"line_number":31,"context_line":"    old_cluster_version: 0"},{"line_number":32,"context_line":"  when: cluster_config[\u0027content\u0027] is not defined"},{"line_number":33,"context_line":""},{"line_number":34,"context_line":"- name: Establishing new cluster version number"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"1fa4df85_0749cd89","line":31,"range":{"start_line":31,"start_character":25,"end_line":31,"end_character":26},"in_reply_to":"1fa4df85_4766e52b","updated":"2020-03-18 11:46:13.000000000","message":"This is later bumped in line #36, so the first version will always be \u00271\u0027.","commit_id":"c28ffd520cd60a5cc13300581b2cd268afc0bb48"},{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"45815585a36b5ac2875826697cd8eae496c5bbe8","unresolved":false,"context_lines":[{"line_number":82,"context_line":"    mode: \"0660\""},{"line_number":83,"context_line":"  become: true"},{"line_number":84,"context_line":"  when:"},{"line_number":85,"context_line":"    - rabbitmq_confs.changed | bool"},{"line_number":86,"context_line":"  with_items:"},{"line_number":87,"context_line":"    - \"rabbitmq-clusterer.config\""},{"line_number":88,"context_line":"  notify:"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"1fa4df85_fdb43ed3","line":85,"updated":"2020-03-18 13:22:56.000000000","message":"I guess one could imagine getting this undefined, let\u0027s repeat the conditions above. Could also limit on old !\u003d new.","commit_id":"2e3bda61641b5f0f89b869a1ecfc6fc2f28cd0d8"},{"author":{"_account_id":31619,"name":"Grzegorz Sikorski","email":"g.sikorski@samsung.com","username":"gregors"},"change_message_id":"e152179572be7834cf0a7c1c72ba38202fe5ab20","unresolved":false,"context_lines":[{"line_number":82,"context_line":"    mode: \"0660\""},{"line_number":83,"context_line":"  become: true"},{"line_number":84,"context_line":"  when:"},{"line_number":85,"context_line":"    - rabbitmq_confs.changed | bool"},{"line_number":86,"context_line":"  with_items:"},{"line_number":87,"context_line":"    - \"rabbitmq-clusterer.config\""},{"line_number":88,"context_line":"  notify:"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"1fa4df85_21e074cc","line":85,"in_reply_to":"1fa4df85_c1b160e3","updated":"2020-03-18 14:08:21.000000000","message":"Ignore me, just realised this step is not required anyway in case of default.","commit_id":"2e3bda61641b5f0f89b869a1ecfc6fc2f28cd0d8"},{"author":{"_account_id":31619,"name":"Grzegorz Sikorski","email":"g.sikorski@samsung.com","username":"gregors"},"change_message_id":"e10d2ad9eaa633eaa90b6c56f564998e22df9dfc","unresolved":false,"context_lines":[{"line_number":82,"context_line":"    mode: \"0660\""},{"line_number":83,"context_line":"  become: true"},{"line_number":84,"context_line":"  when:"},{"line_number":85,"context_line":"    - rabbitmq_confs.changed | bool"},{"line_number":86,"context_line":"  with_items:"},{"line_number":87,"context_line":"    - \"rabbitmq-clusterer.config\""},{"line_number":88,"context_line":"  notify:"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"1fa4df85_c1b160e3","line":85,"in_reply_to":"1fa4df85_fdb43ed3","updated":"2020-03-18 14:06:58.000000000","message":"Agree on the first part of the comment, but adding condition \"old_cluster_version !\u003d new_cluster_version\" won\u0027t work for default cluster version (see lines #36-37). What would you prefer, keep it as it is or modify default cluster version number?","commit_id":"2e3bda61641b5f0f89b869a1ecfc6fc2f28cd0d8"},{"author":{"_account_id":31739,"name":"Krzysztof Kwiecień","email":"k.kwiecien@samsung.com"},"change_message_id":"808eeb7889d3de9b57a7dc6dfb02222af1ca1659","unresolved":false,"context_lines":[{"line_number":21,"context_line":""},{"line_number":22,"context_line":"- name: Establishing existing cluster version number"},{"line_number":23,"context_line":"  set_fact:"},{"line_number":24,"context_line":"    old_cluster_version: \"{{ cluster_config[\u0027content\u0027] | b64decode | regex_search(regexp,\u0027\\\\1\u0027, multiline\u003dTrue) | first }}\""},{"line_number":25,"context_line":"  vars:"},{"line_number":26,"context_line":"    regexp: \u0027\\{version, (\\d+)\\},\u0027"},{"line_number":27,"context_line":"  when: cluster_config[\u0027content\u0027] is defined"}],"source_content_type":"text/x-yaml","patch_set":6,"id":"1fa4df85_2492c24c","line":24,"range":{"start_line":24,"start_character":4,"end_line":24,"end_character":23},"updated":"2020-03-18 14:50:58.000000000","message":"I think we should use variable name with global meaning, for example rabbitmq_cluster_version.","commit_id":"1d93198ff9cfb6217e2ff15fa51e9f84b05381e2"},{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"81239f53cb94b17fa04801d7c380011f1c94e75a","unresolved":false,"context_lines":[{"line_number":21,"context_line":""},{"line_number":22,"context_line":"- name: Establishing existing cluster version number"},{"line_number":23,"context_line":"  set_fact:"},{"line_number":24,"context_line":"    old_cluster_version: \"{{ cluster_config[\u0027content\u0027] | b64decode | regex_search(regexp,\u0027\\\\1\u0027, multiline\u003dTrue) | first }}\""},{"line_number":25,"context_line":"  vars:"},{"line_number":26,"context_line":"    regexp: \u0027\\{version, (\\d+)\\},\u0027"},{"line_number":27,"context_line":"  when: cluster_config[\u0027content\u0027] is defined"}],"source_content_type":"text/x-yaml","patch_set":6,"id":"1fa4df85_644afaac","line":24,"range":{"start_line":24,"start_character":4,"end_line":24,"end_character":23},"in_reply_to":"1fa4df85_2492c24c","updated":"2020-03-18 15:15:08.000000000","message":"++, always safer","commit_id":"1d93198ff9cfb6217e2ff15fa51e9f84b05381e2"},{"author":{"_account_id":31619,"name":"Grzegorz Sikorski","email":"g.sikorski@samsung.com","username":"gregors"},"change_message_id":"7f0ff61cf929968b54e94a0afcbdba659fa398f7","unresolved":false,"context_lines":[{"line_number":21,"context_line":""},{"line_number":22,"context_line":"- name: Establishing existing cluster version number"},{"line_number":23,"context_line":"  set_fact:"},{"line_number":24,"context_line":"    old_cluster_version: \"{{ cluster_config[\u0027content\u0027] | b64decode | regex_search(regexp,\u0027\\\\1\u0027, multiline\u003dTrue) | first }}\""},{"line_number":25,"context_line":"  vars:"},{"line_number":26,"context_line":"    regexp: \u0027\\{version, (\\d+)\\},\u0027"},{"line_number":27,"context_line":"  when: cluster_config[\u0027content\u0027] is defined"}],"source_content_type":"text/x-yaml","patch_set":6,"id":"1fa4df85_8424d6c7","line":24,"range":{"start_line":24,"start_character":4,"end_line":24,"end_character":23},"in_reply_to":"1fa4df85_2492c24c","updated":"2020-03-18 15:09:52.000000000","message":"OK.","commit_id":"1d93198ff9cfb6217e2ff15fa51e9f84b05381e2"},{"author":{"_account_id":31739,"name":"Krzysztof Kwiecień","email":"k.kwiecien@samsung.com"},"change_message_id":"808eeb7889d3de9b57a7dc6dfb02222af1ca1659","unresolved":false,"context_lines":[{"line_number":26,"context_line":"    regexp: \u0027\\{version, (\\d+)\\},\u0027"},{"line_number":27,"context_line":"  when: cluster_config[\u0027content\u0027] is defined"},{"line_number":28,"context_line":""},{"line_number":29,"context_line":"- name: Establishing new cluster version number"},{"line_number":30,"context_line":"  set_fact:"},{"line_number":31,"context_line":"    new_cluster_version: \"{{ (old_cluster_version | int + 1) | string }}\""},{"line_number":32,"context_line":"  when: cluster_config[\u0027content\u0027] is defined"},{"line_number":33,"context_line":""},{"line_number":34,"context_line":"- name: Establishing default cluster version number"},{"line_number":35,"context_line":"  set_fact:"}],"source_content_type":"text/x-yaml","patch_set":6,"id":"1fa4df85_44025eb6","line":32,"range":{"start_line":29,"start_character":0,"end_line":32,"end_character":44},"updated":"2020-03-18 14:50:58.000000000","message":"I think that this task should be executed before \"Updating cluster version\" task and in condition when rabbitmq-clusterer is changed. Also it should be possible to have just one rabbitmq_cluster_version instead of variables for old and new cluster version.","commit_id":"1d93198ff9cfb6217e2ff15fa51e9f84b05381e2"},{"author":{"_account_id":31619,"name":"Grzegorz Sikorski","email":"g.sikorski@samsung.com","username":"gregors"},"change_message_id":"7f0ff61cf929968b54e94a0afcbdba659fa398f7","unresolved":false,"context_lines":[{"line_number":26,"context_line":"    regexp: \u0027\\{version, (\\d+)\\},\u0027"},{"line_number":27,"context_line":"  when: cluster_config[\u0027content\u0027] is defined"},{"line_number":28,"context_line":""},{"line_number":29,"context_line":"- name: Establishing new cluster version number"},{"line_number":30,"context_line":"  set_fact:"},{"line_number":31,"context_line":"    new_cluster_version: \"{{ (old_cluster_version | int + 1) | string }}\""},{"line_number":32,"context_line":"  when: cluster_config[\u0027content\u0027] is defined"},{"line_number":33,"context_line":""},{"line_number":34,"context_line":"- name: Establishing default cluster version number"},{"line_number":35,"context_line":"  set_fact:"}],"source_content_type":"text/x-yaml","patch_set":6,"id":"1fa4df85_c413ae65","line":32,"range":{"start_line":29,"start_character":0,"end_line":32,"end_character":44},"in_reply_to":"1fa4df85_44025eb6","updated":"2020-03-18 15:09:52.000000000","message":"Good point, it is simplifying the code.","commit_id":"1d93198ff9cfb6217e2ff15fa51e9f84b05381e2"},{"author":{"_account_id":31739,"name":"Krzysztof Kwiecień","email":"k.kwiecien@samsung.com"},"change_message_id":"808eeb7889d3de9b57a7dc6dfb02222af1ca1659","unresolved":false,"context_lines":[{"line_number":85,"context_line":"    - inventory_hostname in groups[service.group]"},{"line_number":86,"context_line":"    - service.enabled | bool"},{"line_number":87,"context_line":"    - rabbitmq_confs.changed | bool"},{"line_number":88,"context_line":"    - old_cluster_version !\u003d new_cluster_version"},{"line_number":89,"context_line":"  with_items:"},{"line_number":90,"context_line":"    - \"rabbitmq-clusterer.config\""},{"line_number":91,"context_line":"  notify:"}],"source_content_type":"text/x-yaml","patch_set":6,"id":"1fa4df85_e486ea13","line":88,"range":{"start_line":88,"start_character":6,"end_line":88,"end_character":48},"updated":"2020-03-18 14:50:58.000000000","message":"currently this is always true due to Establishing new cluster version number task, except the initial config.","commit_id":"1d93198ff9cfb6217e2ff15fa51e9f84b05381e2"},{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"81239f53cb94b17fa04801d7c380011f1c94e75a","unresolved":false,"context_lines":[{"line_number":85,"context_line":"    - inventory_hostname in groups[service.group]"},{"line_number":86,"context_line":"    - service.enabled | bool"},{"line_number":87,"context_line":"    - rabbitmq_confs.changed | bool"},{"line_number":88,"context_line":"    - old_cluster_version !\u003d new_cluster_version"},{"line_number":89,"context_line":"  with_items:"},{"line_number":90,"context_line":"    - \"rabbitmq-clusterer.config\""},{"line_number":91,"context_line":"  notify:"}],"source_content_type":"text/x-yaml","patch_set":6,"id":"1fa4df85_84cb7651","line":88,"range":{"start_line":88,"start_character":6,"end_line":88,"end_character":48},"in_reply_to":"1fa4df85_e486ea13","updated":"2020-03-18 15:15:08.000000000","message":"True, I wanted to eliminate exactly that case.","commit_id":"1d93198ff9cfb6217e2ff15fa51e9f84b05381e2"},{"author":{"_account_id":31739,"name":"Krzysztof Kwiecień","email":"k.kwiecien@samsung.com"},"change_message_id":"b93d756d37e72ab9a60b0b33b3b8a0debc4367c5","unresolved":false,"context_lines":[{"line_number":69,"context_line":"- name: Updating cluster version"},{"line_number":70,"context_line":"  vars:"},{"line_number":71,"context_line":"    service: \"{{ rabbitmq_services[\u0027rabbitmq\u0027] }}\""},{"line_number":72,"context_line":"    cluster_version: \"{{ (rabbitmq_cluster_version | int + 1) | string }}\""},{"line_number":73,"context_line":"  template:"},{"line_number":74,"context_line":"    src: \"{{ item }}.j2\""},{"line_number":75,"context_line":"    dest: \"{{ node_config_directory }}/{{ project_name }}/{{ item }}\""}],"source_content_type":"text/x-yaml","patch_set":7,"id":"1fa4df85_07b8e8c5","line":72,"range":{"start_line":72,"start_character":26,"end_line":72,"end_character":60},"updated":"2020-03-18 15:36:00.000000000","message":"It simplify the code, but from the other point of view its will leave in facts the variable rabbitmq_cluster_version with outdated value. For now there is no other task using this variable, so it\u0027s kind of cosmetic flaw.","commit_id":"0fba84d4df8094ad45af108f201be4eae0571722"},{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"81c6cd3a04675e771e6bba089f4b756235839284","unresolved":false,"context_lines":[{"line_number":69,"context_line":"- name: Updating cluster version"},{"line_number":70,"context_line":"  vars:"},{"line_number":71,"context_line":"    service: \"{{ rabbitmq_services[\u0027rabbitmq\u0027] }}\""},{"line_number":72,"context_line":"    cluster_version: \"{{ (rabbitmq_cluster_version | int + 1) | string }}\""},{"line_number":73,"context_line":"  template:"},{"line_number":74,"context_line":"    src: \"{{ item }}.j2\""},{"line_number":75,"context_line":"    dest: \"{{ node_config_directory }}/{{ project_name }}/{{ item }}\""}],"source_content_type":"text/x-yaml","patch_set":7,"id":"1fa4df85_8797f890","line":72,"range":{"start_line":72,"start_character":62,"end_line":72,"end_character":71},"updated":"2020-03-18 15:18:50.000000000","message":"not needed","commit_id":"0fba84d4df8094ad45af108f201be4eae0571722"},{"author":{"_account_id":31619,"name":"Grzegorz Sikorski","email":"g.sikorski@samsung.com","username":"gregors"},"change_message_id":"c0a9fe9885bbd8783d3973dc82c9c36338fa3894","unresolved":false,"context_lines":[{"line_number":69,"context_line":"- name: Updating cluster version"},{"line_number":70,"context_line":"  vars:"},{"line_number":71,"context_line":"    service: \"{{ rabbitmq_services[\u0027rabbitmq\u0027] }}\""},{"line_number":72,"context_line":"    cluster_version: \"{{ (rabbitmq_cluster_version | int + 1) | string }}\""},{"line_number":73,"context_line":"  template:"},{"line_number":74,"context_line":"    src: \"{{ item }}.j2\""},{"line_number":75,"context_line":"    dest: \"{{ node_config_directory }}/{{ project_name }}/{{ item }}\""}],"source_content_type":"text/x-yaml","patch_set":7,"id":"1fa4df85_d4e82f17","line":72,"range":{"start_line":72,"start_character":26,"end_line":72,"end_character":60},"in_reply_to":"1fa4df85_07b8e8c5","updated":"2020-03-19 08:10:40.000000000","message":"\u003e It simplify the code, but from the other point of view its will\n \u003e leave in facts the variable rabbitmq_cluster_version with outdated\n \u003e value.\n\nTrue. I will leave the task updating the fact separately.","commit_id":"0fba84d4df8094ad45af108f201be4eae0571722"},{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"7c22a33ff8c87ebedbca9f60dc668cadbbebaf8d","unresolved":false,"context_lines":[{"line_number":69,"context_line":"- name: Updating cluster version"},{"line_number":70,"context_line":"  vars:"},{"line_number":71,"context_line":"    service: \"{{ rabbitmq_services[\u0027rabbitmq\u0027] }}\""},{"line_number":72,"context_line":"    cluster_version: \"{{ (rabbitmq_cluster_version | int + 1) | string }}\""},{"line_number":73,"context_line":"  template:"},{"line_number":74,"context_line":"    src: \"{{ item }}.j2\""},{"line_number":75,"context_line":"    dest: \"{{ node_config_directory }}/{{ project_name }}/{{ item }}\""}],"source_content_type":"text/x-yaml","patch_set":7,"id":"1fa4df85_e737cc4c","line":72,"range":{"start_line":72,"start_character":26,"end_line":72,"end_character":60},"in_reply_to":"1fa4df85_07b8e8c5","updated":"2020-03-18 15:40:24.000000000","message":"This is just rocky going EM. I also generally doubt anything except clusterer config ever cared about cluster version.","commit_id":"0fba84d4df8094ad45af108f201be4eae0571722"}]}