)]}'
{"ansible/gather-facts.yml":[{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"408fbc542fa7f3fc8c8704ddef9383a733e50229","unresolved":false,"context_lines":[{"line_number":5,"context_line":"- name: Gather facts for all hosts"},{"line_number":6,"context_line":"  hosts: all"},{"line_number":7,"context_line":"  serial: \u0027{{ kolla_serial|default(\"0\") }}\u0027"},{"line_number":8,"context_line":"  gather_facts: true"},{"line_number":9,"context_line":"  tasks:"},{"line_number":10,"context_line":"    - name: Group hosts to determine when using --limit"},{"line_number":11,"context_line":"      group_by:"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"df33271e_c8cfc326","line":8,"range":{"start_line":8,"start_character":2,"end_line":8,"end_character":20},"updated":"2020-04-02 09:50:05.000000000","message":"You sure? Per docs [1] I think this should just be dropped to get behaviour set by user.\n\n[1] https://docs.ansible.com/ansible/latest/reference_appendices/config.html#default-gathering","commit_id":"ba4b3d536b4df0fb4ccb7de33073390026e5677c"},{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"875e6e3d794774322a409a799e20866114bb0fe7","unresolved":false,"context_lines":[{"line_number":5,"context_line":"- name: Gather facts for all hosts"},{"line_number":6,"context_line":"  hosts: all"},{"line_number":7,"context_line":"  serial: \u0027{{ kolla_serial|default(\"0\") }}\u0027"},{"line_number":8,"context_line":"  gather_facts: true"},{"line_number":9,"context_line":"  tasks:"},{"line_number":10,"context_line":"    - name: Group hosts to determine when using --limit"},{"line_number":11,"context_line":"      group_by:"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"df33271e_f494228d","line":8,"range":{"start_line":8,"start_character":2,"end_line":8,"end_character":20},"in_reply_to":"df33271e_99d4ef49","updated":"2020-04-02 12:20:25.000000000","message":"I think it is worth checking. Did you confirm it does not affect \u0027smart\u0027? Docs are not clear. I read them as \u0027gather_facts\u0027 forcing \u0027setup\u0027 run.","commit_id":"ba4b3d536b4df0fb4ccb7de33073390026e5677c"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"b74f8ba0983657ab04a0935e110440b6c2c4ffc8","unresolved":false,"context_lines":[{"line_number":5,"context_line":"- name: Gather facts for all hosts"},{"line_number":6,"context_line":"  hosts: all"},{"line_number":7,"context_line":"  serial: \u0027{{ kolla_serial|default(\"0\") }}\u0027"},{"line_number":8,"context_line":"  gather_facts: true"},{"line_number":9,"context_line":"  tasks:"},{"line_number":10,"context_line":"    - name: Group hosts to determine when using --limit"},{"line_number":11,"context_line":"      group_by:"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"df33271e_99d4ef49","line":8,"range":{"start_line":8,"start_character":2,"end_line":8,"end_character":20},"in_reply_to":"df33271e_c8cfc326","updated":"2020-04-02 11:39:04.000000000","message":"I think the only case that would change if you removed it is the explicit mode, in which case facts would not be gathered. Would we want that? We would also need some corresponding check in the following play.","commit_id":"ba4b3d536b4df0fb4ccb7de33073390026e5677c"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"b89a8a2458a9f8e34285eed93147dc587a57f892","unresolved":false,"context_lines":[{"line_number":5,"context_line":"- name: Gather facts for all hosts"},{"line_number":6,"context_line":"  hosts: all"},{"line_number":7,"context_line":"  serial: \u0027{{ kolla_serial|default(\"0\") }}\u0027"},{"line_number":8,"context_line":"  gather_facts: true"},{"line_number":9,"context_line":"  tasks:"},{"line_number":10,"context_line":"    - name: Group hosts to determine when using --limit"},{"line_number":11,"context_line":"      group_by:"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"df33271e_d4811ec5","line":8,"range":{"start_line":8,"start_character":2,"end_line":8,"end_character":20},"in_reply_to":"df33271e_f494228d","updated":"2020-04-02 12:39:12.000000000","message":"May I direct you to https://github.com/markgoddard/ansible-experiments/tree/master/08-fact-caching","commit_id":"ba4b3d536b4df0fb4ccb7de33073390026e5677c"},{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"f4c99d937d0171692a795adaf09d1db1d5a57ca1","unresolved":false,"context_lines":[{"line_number":27,"context_line":"    batch_size: \"{{ ansible_play_batch | length }}\""},{"line_number":28,"context_line":"    # Use a python list slice to divide the group up."},{"line_number":29,"context_line":"    # Syntax: [\u003cstart index\u003e:\u003cend index\u003e:\u003cstep size\u003e]"},{"line_number":30,"context_line":"    delegate_hosts: \"{{ groups[\u0027all\u0027][batch_index | int::batch_size | int] }}\""},{"line_number":31,"context_line":"  tasks:"},{"line_number":32,"context_line":"    - name: Gather facts"},{"line_number":33,"context_line":"      setup:"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"df33271e_28010f07","line":30,"range":{"start_line":30,"start_character":20,"end_line":30,"end_character":78},"updated":"2020-04-02 09:53:03.000000000","message":"now that I look at it - should not batch_index be multiplied by batch_size to make this work reasonably? Also, not sure about batch_size being applicable, more like rest size divided by batch size?","commit_id":"ba4b3d536b4df0fb4ccb7de33073390026e5677c"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"b74f8ba0983657ab04a0935e110440b6c2c4ffc8","unresolved":false,"context_lines":[{"line_number":27,"context_line":"    batch_size: \"{{ ansible_play_batch | length }}\""},{"line_number":28,"context_line":"    # Use a python list slice to divide the group up."},{"line_number":29,"context_line":"    # Syntax: [\u003cstart index\u003e:\u003cend index\u003e:\u003cstep size\u003e]"},{"line_number":30,"context_line":"    delegate_hosts: \"{{ groups[\u0027all\u0027][batch_index | int::batch_size | int] }}\""},{"line_number":31,"context_line":"  tasks:"},{"line_number":32,"context_line":"    - name: Gather facts"},{"line_number":33,"context_line":"      setup:"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"df33271e_d93f9784","line":30,"range":{"start_line":30,"start_character":20,"end_line":30,"end_character":78},"in_reply_to":"df33271e_28010f07","updated":"2020-04-02 11:39:04.000000000","message":"[start:end:step size]\n\nExample with 6 hosts, and 2 in limit:\n\nhost1: 0, 2, 4\nhost2: 1, 3, 5","commit_id":"ba4b3d536b4df0fb4ccb7de33073390026e5677c"},{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"875e6e3d794774322a409a799e20866114bb0fe7","unresolved":false,"context_lines":[{"line_number":27,"context_line":"    batch_size: \"{{ ansible_play_batch | length }}\""},{"line_number":28,"context_line":"    # Use a python list slice to divide the group up."},{"line_number":29,"context_line":"    # Syntax: [\u003cstart index\u003e:\u003cend index\u003e:\u003cstep size\u003e]"},{"line_number":30,"context_line":"    delegate_hosts: \"{{ groups[\u0027all\u0027][batch_index | int::batch_size | int] }}\""},{"line_number":31,"context_line":"  tasks:"},{"line_number":32,"context_line":"    - name: Gather facts"},{"line_number":33,"context_line":"      setup:"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"df33271e_397a03b9","line":30,"range":{"start_line":30,"start_character":20,"end_line":30,"end_character":78},"in_reply_to":"df33271e_d93f9784","updated":"2020-04-02 12:20:25.000000000","message":"Ah, it\u0027s step size. No idea why my mind processed that as length. Then it all makes sense again (as it always did).","commit_id":"ba4b3d536b4df0fb4ccb7de33073390026e5677c"},{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"408fbc542fa7f3fc8c8704ddef9383a733e50229","unresolved":false,"context_lines":[{"line_number":36,"context_line":"      with_items: \"{{ delegate_hosts }}\""},{"line_number":37,"context_line":"      # We gathered facts for all hosts in the batch during the first play."},{"line_number":38,"context_line":"      when:"},{"line_number":39,"context_line":"        - item not in ansible_play_batch"},{"line_number":40,"context_line":"        - not hostvars[item].module_setup | default(false)"},{"line_number":41,"context_line":"  tags: always"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"df33271e_e873a7e5","line":40,"range":{"start_line":39,"start_character":8,"end_line":40,"end_character":58},"updated":"2020-04-02 09:50:05.000000000","message":"2nd sounds like sufficient - why keep the first (possibly incomplete)?","commit_id":"ba4b3d536b4df0fb4ccb7de33073390026e5677c"},{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"875e6e3d794774322a409a799e20866114bb0fe7","unresolved":false,"context_lines":[{"line_number":36,"context_line":"      with_items: \"{{ delegate_hosts }}\""},{"line_number":37,"context_line":"      # We gathered facts for all hosts in the batch during the first play."},{"line_number":38,"context_line":"      when:"},{"line_number":39,"context_line":"        - item not in ansible_play_batch"},{"line_number":40,"context_line":"        - not hostvars[item].module_setup | default(false)"},{"line_number":41,"context_line":"  tags: always"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"df33271e_b4f45af2","line":40,"range":{"start_line":39,"start_character":8,"end_line":40,"end_character":58},"in_reply_to":"df33271e_394e8337","updated":"2020-04-02 12:20:25.000000000","message":"Then let\u0027s. :-)","commit_id":"ba4b3d536b4df0fb4ccb7de33073390026e5677c"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"b74f8ba0983657ab04a0935e110440b6c2c4ffc8","unresolved":false,"context_lines":[{"line_number":36,"context_line":"      with_items: \"{{ delegate_hosts }}\""},{"line_number":37,"context_line":"      # We gathered facts for all hosts in the batch during the first play."},{"line_number":38,"context_line":"      when:"},{"line_number":39,"context_line":"        - item not in ansible_play_batch"},{"line_number":40,"context_line":"        - not hostvars[item].module_setup | default(false)"},{"line_number":41,"context_line":"  tags: always"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"df33271e_394e8337","line":40,"range":{"start_line":39,"start_character":8,"end_line":40,"end_character":58},"in_reply_to":"df33271e_e873a7e5","updated":"2020-04-02 11:39:04.000000000","message":"I did consider removing it. It should be fine without.","commit_id":"ba4b3d536b4df0fb4ccb7de33073390026e5677c"}]}