)]}'
{"tests/run.yml":[{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"c0a5899105d73f9feffda183bd6aba9fd7a10fd4","unresolved":false,"context_lines":[{"line_number":116,"context_line":"    # NOTE(hrw): checking will it work"},{"line_number":117,"context_line":"    - name: Set tag suffix for AArch64"},{"line_number":118,"context_line":"      set_fact:"},{"line_number":119,"context_line":"        tag_suffix: \"{{ \u0027-aarch64\u0027 if ansible_architecture \u003d\u003d \u0027aarch64\u0027 else \u0027\u0027 }}\""},{"line_number":120,"context_line":""},{"line_number":121,"context_line":"    - name: Set facts for actions"},{"line_number":122,"context_line":"      set_fact:"}],"source_content_type":"text/x-yaml","patch_set":5,"id":"df33271e_427e2ce4","line":119,"range":{"start_line":119,"start_character":8,"end_line":119,"end_character":18},"updated":"2020-04-10 14:25:03.000000000","message":"docker_image_tag_suffix? (it\u0027s easier to avoid confusion when reading all facts)","commit_id":"46f7972053d53565f039abd0bebf4c7fdb77c4eb"},{"author":{"_account_id":24072,"name":"Marcin Juszkiewicz","email":"mjuszkiewicz@redhat.com","username":"hrw"},"change_message_id":"e6cfa3ccfc3886501ebeacca1f8105146a9d4d46","unresolved":false,"context_lines":[{"line_number":116,"context_line":"    # NOTE(hrw): checking will it work"},{"line_number":117,"context_line":"    - name: Set tag suffix for AArch64"},{"line_number":118,"context_line":"      set_fact:"},{"line_number":119,"context_line":"        tag_suffix: \"{{ \u0027-aarch64\u0027 if ansible_architecture \u003d\u003d \u0027aarch64\u0027 else \u0027\u0027 }}\""},{"line_number":120,"context_line":""},{"line_number":121,"context_line":"    - name: Set facts for actions"},{"line_number":122,"context_line":"      set_fact:"}],"source_content_type":"text/x-yaml","patch_set":5,"id":"3f4c43b2_bc96e193","line":119,"range":{"start_line":119,"start_character":8,"end_line":119,"end_character":18},"in_reply_to":"df33271e_427e2ce4","updated":"2020-04-11 17:04:24.000000000","message":"Done","commit_id":"46f7972053d53565f039abd0bebf4c7fdb77c4eb"},{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"c0a5899105d73f9feffda183bd6aba9fd7a10fd4","unresolved":false,"context_lines":[{"line_number":120,"context_line":""},{"line_number":121,"context_line":"    - name: Set facts for actions"},{"line_number":122,"context_line":"      set_fact:"},{"line_number":123,"context_line":"        # NOTE(yoctozepto): no support for upgrades for now"},{"line_number":124,"context_line":"        docker_image_tag: \"{{ build_image_tag if need_build_image else (zuul.branch | basename) ~ tag_suffix}}\""},{"line_number":125,"context_line":"        docker_image_prefix: \"{{ \u0027primary:4000/lokolla/\u0027 if need_build_image else \u0027kolla/\u0027 }}\""},{"line_number":126,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":5,"id":"df33271e_8284b4d4","line":123,"range":{"start_line":123,"start_character":8,"end_line":123,"end_character":59},"updated":"2020-04-10 14:25:03.000000000","message":"well, that is no longer true then","commit_id":"46f7972053d53565f039abd0bebf4c7fdb77c4eb"},{"author":{"_account_id":24072,"name":"Marcin Juszkiewicz","email":"mjuszkiewicz@redhat.com","username":"hrw"},"change_message_id":"e6cfa3ccfc3886501ebeacca1f8105146a9d4d46","unresolved":false,"context_lines":[{"line_number":120,"context_line":""},{"line_number":121,"context_line":"    - name: Set facts for actions"},{"line_number":122,"context_line":"      set_fact:"},{"line_number":123,"context_line":"        # NOTE(yoctozepto): no support for upgrades for now"},{"line_number":124,"context_line":"        docker_image_tag: \"{{ build_image_tag if need_build_image else (zuul.branch | basename) ~ tag_suffix}}\""},{"line_number":125,"context_line":"        docker_image_prefix: \"{{ \u0027primary:4000/lokolla/\u0027 if need_build_image else \u0027kolla/\u0027 }}\""},{"line_number":126,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":5,"id":"3f4c43b2_dc8dad7c","line":123,"range":{"start_line":123,"start_character":8,"end_line":123,"end_character":59},"in_reply_to":"df33271e_8284b4d4","updated":"2020-04-11 17:04:24.000000000","message":"Done","commit_id":"46f7972053d53565f039abd0bebf4c7fdb77c4eb"},{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"c0a5899105d73f9feffda183bd6aba9fd7a10fd4","unresolved":false,"context_lines":[{"line_number":121,"context_line":"    - name: Set facts for actions"},{"line_number":122,"context_line":"      set_fact:"},{"line_number":123,"context_line":"        # NOTE(yoctozepto): no support for upgrades for now"},{"line_number":124,"context_line":"        docker_image_tag: \"{{ build_image_tag if need_build_image else (zuul.branch | basename) ~ tag_suffix}}\""},{"line_number":125,"context_line":"        docker_image_prefix: \"{{ \u0027primary:4000/lokolla/\u0027 if need_build_image else \u0027kolla/\u0027 }}\""},{"line_number":126,"context_line":""},{"line_number":127,"context_line":"    - name: generate configuration files"},{"line_number":128,"context_line":"      template:"}],"source_content_type":"text/x-yaml","patch_set":5,"id":"df33271e_a258d889","line":125,"range":{"start_line":124,"start_character":8,"end_line":125,"end_character":94},"updated":"2020-04-10 14:25:03.000000000","message":"this will unfortunately break upgrades with kolla dependency; we need support for pre-upgrade images building but that is another story","commit_id":"46f7972053d53565f039abd0bebf4c7fdb77c4eb"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"ef2e2c8b8b8a95e8f1fa29100888cc9b9bd27d1b","unresolved":false,"context_lines":[{"line_number":112,"context_line":"        - nova"},{"line_number":113,"context_line":"        - bifrost"},{"line_number":114,"context_line":"        - swift"},{"line_number":115,"context_line":""},{"line_number":116,"context_line":"    # NOTE(hrw): checking will it work"},{"line_number":117,"context_line":"    - name: Set tag suffix for AArch64"},{"line_number":118,"context_line":"      set_fact:"},{"line_number":119,"context_line":"        docker_image_tag_suffix: \"{{ \u0027-aarch64\u0027 if ansible_architecture \u003d\u003d \u0027aarch64\u0027 else \u0027\u0027 }}\""},{"line_number":120,"context_line":""},{"line_number":121,"context_line":"    - name: Set facts for actions"},{"line_number":122,"context_line":"      set_fact:"},{"line_number":123,"context_line":"        docker_image_tag: \"{{ build_image_tag if need_build_image else (zuul.branch | basename) ~ docker_image_tag_suffix}}\""},{"line_number":124,"context_line":"        docker_image_prefix: \"{{ \u0027primary:4000/lokolla/\u0027 if need_build_image else \u0027kolla/\u0027 }}\""},{"line_number":125,"context_line":""},{"line_number":126,"context_line":"    - name: generate configuration files"},{"line_number":127,"context_line":"      template:"}],"source_content_type":"text/x-yaml","patch_set":8,"id":"3f4c43b2_683d7aba","line":124,"range":{"start_line":115,"start_character":0,"end_line":124,"end_character":94},"updated":"2020-04-15 09:13:28.000000000","message":"Shouldn\u0027t need to do this twice.","commit_id":"ebcd9ebf2f6ae469e30737402997ebfc33e03bb3"},{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"03bfaba26554111d8dd5f91d1d905e3cded6319f","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":""},{"line_number":3,"context_line":"- name: Set tag suffix for AArch64"},{"line_number":4,"context_line":"  set_fact:"},{"line_number":5,"context_line":"    docker_image_tag_suffix: \"{{ \u0027-aarch64\u0027 if ansible_architecture \u003d\u003d \u0027aarch64\u0027 else \u0027\u0027 }}\""},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"- hosts: all"},{"line_number":8,"context_line":"  any_errors_fatal: true"}],"source_content_type":"text/x-yaml","patch_set":9,"id":"3f4c43b2_68ae1a2f","line":5,"range":{"start_line":3,"start_character":0,"end_line":5,"end_character":92},"updated":"2020-04-15 09:43:39.000000000","message":"oh noez, it should be a bit lower, probably included in the \"set facts for commonly...\"","commit_id":"73db2d15653fc530d69fef1301af1f66ace466f6"}],"tests/templates/globals-default.j2":[{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"ef2e2c8b8b8a95e8f1fa29100888cc9b9bd27d1b","unresolved":false,"context_lines":[{"line_number":45,"context_line":"docker_registry: \"primary:4000\""},{"line_number":46,"context_line":"openstack_tag: \"{{ build_image_tag }}\""},{"line_number":47,"context_line":"{% else %}"},{"line_number":48,"context_line":"openstack_tag: \"{{ docker_image_tag }}\""},{"line_number":49,"context_line":"# use docker hub images"},{"line_number":50,"context_line":"docker_namespace: \"kolla\""},{"line_number":51,"context_line":"{% if need_build_image and is_previous_release %}"}],"source_content_type":"text/x-jinja2","patch_set":8,"id":"3f4c43b2_e8518a10","line":48,"range":{"start_line":48,"start_character":0,"end_line":48,"end_character":13},"updated":"2020-04-15 09:13:28.000000000","message":"We have openstack_tag_suffix we could use instead. That would work better with openstack_release which we set below.","commit_id":"ebcd9ebf2f6ae469e30737402997ebfc33e03bb3"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"8e200007e6fec971e80d8ecda5acfce075bd7031","unresolved":false,"context_lines":[{"line_number":45,"context_line":"# see: https://github.com/moby/moby/issues/39033"},{"line_number":46,"context_line":"docker_registry: \"primary:4000\""},{"line_number":47,"context_line":"openstack_tag: \"{{ build_image_tag }}\""},{"line_number":48,"context_line":"{% else %}"},{"line_number":49,"context_line":"# use docker hub images"},{"line_number":50,"context_line":"docker_namespace: \"kolla\""},{"line_number":51,"context_line":"{% if need_build_image and is_previous_release %}"}],"source_content_type":"text/x-jinja2","patch_set":10,"id":"3f4c43b2_fe8e6025","line":48,"updated":"2020-04-15 11:24:55.000000000","message":"I think the new line should go here. For locally built images we\u0027re not adding a suffix.","commit_id":"a7b19fed166e5931bd28bc76e283a85b6ca701c6"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"69f00cb4a99108aaaaee641b79acfd9a5cece113","unresolved":false,"context_lines":[{"line_number":47,"context_line":"{% else %}"},{"line_number":48,"context_line":"# use docker hub images"},{"line_number":49,"context_line":"docker_namespace: \"kolla\""},{"line_number":50,"context_line":"openstack_tag_suffix: \"{{ docker_image_tag_suffix }}\""},{"line_number":51,"context_line":"{% if need_build_image and is_previous_release %}"},{"line_number":52,"context_line":"# NOTE(mgoddard): Ensure that the insecure local registry is trusted, since it"},{"line_number":53,"context_line":"# will be the source of images during the upgrade."}],"source_content_type":"text/x-jinja2","patch_set":11,"id":"3f4c43b2_7a4d3971","line":50,"updated":"2020-04-15 13:44:35.000000000","message":"Hmm, looks like this breaks the Train deployment in the upgrade job, which has a tag suffix of \u0027-centos8\u0027.\n\nWhat would we do for centos8 in train on ARM?","commit_id":"81d84bfc6c794ccd0e8d24cd9182d86fd7682cc1"},{"author":{"_account_id":24072,"name":"Marcin Juszkiewicz","email":"mjuszkiewicz@redhat.com","username":"hrw"},"change_message_id":"db25cbf7122816b2bb30ae9333b791cd8d5ebb39","unresolved":false,"context_lines":[{"line_number":47,"context_line":"{% else %}"},{"line_number":48,"context_line":"# use docker hub images"},{"line_number":49,"context_line":"docker_namespace: \"kolla\""},{"line_number":50,"context_line":"openstack_tag_suffix: \"{{ docker_image_tag_suffix }}\""},{"line_number":51,"context_line":"{% if need_build_image and is_previous_release %}"},{"line_number":52,"context_line":"# NOTE(mgoddard): Ensure that the insecure local registry is trusted, since it"},{"line_number":53,"context_line":"# will be the source of images during the upgrade."}],"source_content_type":"text/x-jinja2","patch_set":11,"id":"3f4c43b2_5a795d91","line":50,"in_reply_to":"3f4c43b2_7a4d3971","updated":"2020-04-15 13:47:00.000000000","message":"I would ignore !Debian on aarch64 in \u003cUssuri.","commit_id":"81d84bfc6c794ccd0e8d24cd9182d86fd7682cc1"}]}