)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":15197,"name":"Pierre Riteau","email":"pierre@stackhpc.com","username":"priteau","status":"StackHPC"},"change_message_id":"bf5752737706d4df813d7db086f002c1bc70bf3f","unresolved":true,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Don\u0027t enforce metadata-api to run on dhcp-agents"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"force_metadata will always run metadata-api on dhcp-agents. This is not the"},{"line_number":10,"context_line":"upstream default and may lead to problems if dhcp-agent fails, f.e."},{"line_number":11,"context_line":"requests may fail or run into timeouts."},{"line_number":12,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"dfd2a31f_109b57e6","line":9,"range":{"start_line":9,"start_character":0,"end_line":9,"end_character":75},"updated":"2023-04-05 16:44:59.000000000","message":"Please wrap lines at 72 characters.","commit_id":"0db152339ce39b86bc1e1eddf5f4e0d20d8129dc"},{"author":{"_account_id":15197,"name":"Pierre Riteau","email":"pierre@stackhpc.com","username":"priteau","status":"StackHPC"},"change_message_id":"bf5752737706d4df813d7db086f002c1bc70bf3f","unresolved":true,"context_lines":[{"line_number":7,"context_line":"Don\u0027t enforce metadata-api to run on dhcp-agents"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"force_metadata will always run metadata-api on dhcp-agents. This is not the"},{"line_number":10,"context_line":"upstream default and may lead to problems if dhcp-agent fails, f.e."},{"line_number":11,"context_line":"requests may fail or run into timeouts."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Instead we should not set force_metadata and just keep"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"c77b76de_184739ee","line":10,"range":{"start_line":10,"start_character":63,"end_line":10,"end_character":67},"updated":"2023-04-05 16:44:59.000000000","message":"Do you mean e.g.?","commit_id":"0db152339ce39b86bc1e1eddf5f4e0d20d8129dc"},{"author":{"_account_id":15197,"name":"Pierre Riteau","email":"pierre@stackhpc.com","username":"priteau","status":"StackHPC"},"change_message_id":"bf5752737706d4df813d7db086f002c1bc70bf3f","unresolved":true,"context_lines":[{"line_number":11,"context_line":"requests may fail or run into timeouts."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Instead we should not set force_metadata and just keep"},{"line_number":14,"context_line":"\"enable_isolated_metadata\", this will switch between metadata-api running on"},{"line_number":15,"context_line":"routers (if available) or dhcp-agent (if there is no router)."},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"Now your metadata-api will failover if you run a l3-ha-router."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"10ad7551_e6820546","line":14,"range":{"start_line":14,"start_character":0,"end_line":14,"end_character":76},"updated":"2023-04-05 16:44:59.000000000","message":"Please wrap lines at 72 characters.","commit_id":"0db152339ce39b86bc1e1eddf5f4e0d20d8129dc"}],"/PATCHSET_LEVEL":[{"author":{"_account_id":22437,"name":"Fabian Zimmermann","email":"dev.faz@googlemail.com","username":"dev.faz"},"change_message_id":"cd30acdd768ea75a9935e8a9e4f0423544ed56dd","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"a2a9017d_95bcd8e9","updated":"2021-12-22 07:45:57.000000000","message":"\n\u003e Hi Fabian, will you add reno for this ? I also like the change.\n\nHi,\n\nwhat do you mean with reno?\n\nBut in the meantime I switched my job and atm no longer work with openstack, so if you can fix/add the \"reno\" yourself you may be a lot faster than me 😊\n\n","commit_id":"549577ee2c7ff6e1687d1297ec08411fdc111b11"},{"author":{"_account_id":612,"name":"Tom Fifield","email":"tom@openstack.org","username":"fifieldt"},"change_message_id":"15fed3b2371d6f2a64c6c46490c81c74c913a4a0","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"3576cc36_4a21eb76","updated":"2023-04-05 09:49:38.000000000","message":"Added reno as requested","commit_id":"5bded78e6bdc4c84ce74fb69556c3b6fa2037f29"},{"author":{"_account_id":14200,"name":"Maksim Malchuk","email":"maksim.malchuk@gmail.com","username":"mmalchuk"},"change_message_id":"eda7c596b8426e01ec2ac9d042e60a7487c58416","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"40256d6b_fca43a34","updated":"2023-04-05 10:34:01.000000000","message":"Ok to set parameter to False by default and leave it configurable by kolla-ansible. There might be configurations where metadata service is needed, for example with provider networks where router is external, or in Ironic deployments.\n","commit_id":"5bded78e6bdc4c84ce74fb69556c3b6fa2037f29"},{"author":{"_account_id":14200,"name":"Maksim Malchuk","email":"maksim.malchuk@gmail.com","username":"mmalchuk"},"change_message_id":"d11f304a92ad58a02c005d2fc63a2b89fb1a8e05","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"55600667_395960e7","updated":"2023-04-05 17:08:15.000000000","message":"as I said before, this should be configurable option.","commit_id":"0db152339ce39b86bc1e1eddf5f4e0d20d8129dc"},{"author":{"_account_id":32553,"name":"Sven Kieske","email":"sven_oss@posteo.de","username":"skieske"},"change_message_id":"701af7ebab1b72ff37b86ca4849ac26a86a6df62","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"49b13176_614c6c59","updated":"2024-03-26 14:23:18.000000000","message":"recheck last CI run is roughly a year old","commit_id":"0db152339ce39b86bc1e1eddf5f4e0d20d8129dc"},{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"3070aab66efe66ad6d4037bcefdde297e6e4f87d","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"2c2e0d82_0614027d","in_reply_to":"55600667_395960e7","updated":"2023-04-05 17:10:22.000000000","message":"I disagree, it\u0027s not necessary - if a user wants to change that setting, he can use a template override. We also agreed two PTGs ago that we don\u0027t own service configuration defaults unless it\u0027s necessary - https://docs.openstack.org/kolla/latest/contributor/kolla-design-philosophy.html#do-not-own-the-deployed-services-config-defaults-unless-necessary","commit_id":"0db152339ce39b86bc1e1eddf5f4e0d20d8129dc"}],"ansible/roles/neutron/templates/dhcp_agent.ini.j2":[{"author":{"_account_id":14200,"name":"Maksim Malchuk","email":"maksim.malchuk@gmail.com","username":"mmalchuk"},"change_message_id":"6942aea7ab1f35129e8eaf5ed4179440111da08b","unresolved":true,"context_lines":[{"line_number":1,"context_line":"# dhcp_agent.ini"},{"line_number":2,"context_line":"[DEFAULT]"},{"line_number":3,"context_line":"dnsmasq_config_file \u003d /etc/neutron/dnsmasq.conf"},{"line_number":4,"context_line":"enable_isolated_metadata \u003d true"},{"line_number":5,"context_line":"force_metadata \u003d true"},{"line_number":6,"context_line":"dnsmasq_dns_servers \u003d {{ neutron_dnsmasq_dns_servers }}"},{"line_number":7,"context_line":""}],"source_content_type":"text/x-jinja2","patch_set":3,"id":"4821b02d_4aa910cf","side":"PARENT","line":4,"range":{"start_line":4,"start_character":0,"end_line":4,"end_character":24},"updated":"2023-04-05 17:18:10.000000000","message":"should we also remove this too?","commit_id":"cee03f4b00b86ef4a7b893e5047506097b5c067f"},{"author":{"_account_id":612,"name":"Tom Fifield","email":"tom@openstack.org","username":"fifieldt"},"change_message_id":"d945e4e8e4c3ab73a078ef7a14c1dd0791a15b51","unresolved":true,"context_lines":[{"line_number":1,"context_line":"# dhcp_agent.ini"},{"line_number":2,"context_line":"[DEFAULT]"},{"line_number":3,"context_line":"dnsmasq_config_file \u003d /etc/neutron/dnsmasq.conf"},{"line_number":4,"context_line":"enable_isolated_metadata \u003d true"},{"line_number":5,"context_line":"force_metadata \u003d true"},{"line_number":6,"context_line":"dnsmasq_dns_servers \u003d {{ neutron_dnsmasq_dns_servers }}"},{"line_number":7,"context_line":""}],"source_content_type":"text/x-jinja2","patch_set":3,"id":"c9a52ddc_35599290","side":"PARENT","line":4,"range":{"start_line":4,"start_character":0,"end_line":4,"end_character":24},"in_reply_to":"4821b02d_4aa910cf","updated":"2023-04-06 01:15:44.000000000","message":"My understanding is that this should stay.\n\nBasically, in a deployment with no neutron routers, this flag will let the neutron dhcp-agent perform the work normally done by the neutron router to make the metadata service work. Without it set to true, the metadata service will not work in that situation. Where there are neutron routers, setting it makes no difference.\n\nHere\u0027s what the neutron config docs say about this flag:\n# The DHCP server can assist with providing metadata support on isolated\n# networks. Setting this value to True will cause the DHCP server to append\n# specific host routes to the DHCP request. The metadata service will only be\n# activated when the subnet does not contain any router port. The guest\n# instance must be configured to request host routes via DHCP (Option 121).","commit_id":"cee03f4b00b86ef4a7b893e5047506097b5c067f"}],"releasenotes/notes/bug/1872960-2d3afbbe083efc72.yaml":[{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"21e3da47665d9eae82ad9af26edc96fcc50583ef","unresolved":true,"context_lines":[{"line_number":16,"context_line":"    lead to problems if dhcp-agent fails, e.g.  requests may fail or run into"},{"line_number":17,"context_line":"    timeouts."},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"    We now don\u0027t set `force_metadata` and just follow the behaviour of "},{"line_number":20,"context_line":"    `enable_isolated_metadata`. This will switch between metadata-api running on"},{"line_number":21,"context_line":"    routers (if available) or dhcp-agent (if there is no router)."}],"source_content_type":"text/x-yaml","patch_set":2,"id":"4d60ab67_83e776cd","line":19,"range":{"start_line":19,"start_character":70,"end_line":19,"end_character":71},"updated":"2023-04-05 09:54:57.000000000","message":"whitespace","commit_id":"5bded78e6bdc4c84ce74fb69556c3b6fa2037f29"},{"author":{"_account_id":32553,"name":"Sven Kieske","email":"sven_oss@posteo.de","username":"skieske"},"change_message_id":"47a3bed39d1593df64d44f4d0919bd60d2ec8293","unresolved":false,"context_lines":[{"line_number":16,"context_line":"    lead to problems if dhcp-agent fails, e.g.  requests may fail or run into"},{"line_number":17,"context_line":"    timeouts."},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"    We now don\u0027t set `force_metadata` and just follow the behaviour of "},{"line_number":20,"context_line":"    `enable_isolated_metadata`. This will switch between metadata-api running on"},{"line_number":21,"context_line":"    routers (if available) or dhcp-agent (if there is no router)."}],"source_content_type":"text/x-yaml","patch_set":2,"id":"0efe47f1_6ebe1f2f","line":19,"range":{"start_line":19,"start_character":70,"end_line":19,"end_character":71},"in_reply_to":"4d60ab67_83e776cd","updated":"2023-04-05 16:18:24.000000000","message":"Done","commit_id":"5bded78e6bdc4c84ce74fb69556c3b6fa2037f29"}]}