)]}'
{"releasenotes/notes/bug-1856346-59d0f01005d56e81.yaml":[{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"749a3878a76f625aeb1521a4da32c294c2d2baf2","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Kolla Ansible checks now that the local Ansible Python environment"}],"source_content_type":"text/x-yaml","patch_set":5,"id":"1f493fa4_9e2c2cad","line":1,"updated":"2020-04-27 14:34:24.000000000","message":"Make your mind up :)","commit_id":"223c1f89df70a0418c9d1f0e92952005cd02c16c"},{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"2bdbc618fc0a88e6345122eaaa743c09be150c67","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Kolla Ansible checks now that the local Ansible Python environment"}],"source_content_type":"text/x-yaml","patch_set":5,"id":"1f493fa4_dd90794d","line":1,"in_reply_to":"1f493fa4_9e2c2cad","updated":"2020-04-27 14:45:23.000000000","message":"I can\u0027t! :D I guess a feature?","commit_id":"223c1f89df70a0418c9d1f0e92952005cd02c16c"}],"tools/kolla-ansible":[{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"6172c8e6b83e59959b34c1721227669e196a4027","unresolved":false,"context_lines":[{"line_number":2,"context_line":"#"},{"line_number":3,"context_line":"# This script can be used to interact with kolla via ansible."},{"line_number":4,"context_line":""},{"line_number":5,"context_line":"function check_environment_coherence {"},{"line_number":6,"context_line":"    local ansible_path"},{"line_number":7,"context_line":"    ansible_path\u003d$(which ansible)"},{"line_number":8,"context_line":""}],"source_content_type":"application/x-shellscript","patch_set":4,"id":"1f493fa4_e9d2fb5b","line":5,"updated":"2020-04-24 20:05:33.000000000","message":"Or:\n\nansible localhost -m command -a \u0027{{ playbook_python_path }} -c \"import kolla_ansibe\"\u0027","commit_id":"6b8c4feda8f5a5951ecebf06b49337d8fd80ab15"},{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"9daa53ba773a56ff10736a3fc9d43d4f5bfd2734","unresolved":false,"context_lines":[{"line_number":2,"context_line":"#"},{"line_number":3,"context_line":"# This script can be used to interact with kolla via ansible."},{"line_number":4,"context_line":""},{"line_number":5,"context_line":"function check_environment_coherence {"},{"line_number":6,"context_line":"    local ansible_path"},{"line_number":7,"context_line":"    ansible_path\u003d$(which ansible)"},{"line_number":8,"context_line":""}],"source_content_type":"application/x-shellscript","patch_set":4,"id":"1f493fa4_586ad3b2","line":5,"in_reply_to":"1f493fa4_e9d2fb5b","updated":"2020-04-25 09:13:05.000000000","message":"Ah, I missed ansible allows to discover the local python it runs with. Thanks.","commit_id":"6b8c4feda8f5a5951ecebf06b49337d8fd80ab15"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"749a3878a76f625aeb1521a4da32c294c2d2baf2","unresolved":false,"context_lines":[{"line_number":20,"context_line":"    fi"},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"    local ansible_python_path"},{"line_number":23,"context_line":"    ansible_python_path\u003d${ansible_shebang_line#\\#\\!}"},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"    if ! \"$ansible_python_path\" --version \u0026\u003e/dev/null; then"},{"line_number":26,"context_line":"        echo \"ERROR: Ansible Python is not functional.\" \u003e\u00262"}],"source_content_type":"application/x-shellscript","patch_set":5,"id":"1f493fa4_19b036dd","line":23,"updated":"2020-04-27 14:34:24.000000000","message":"Are we sure it will never use\n\n#!/usr/bin/env python\n\nThat would break on L25.","commit_id":"223c1f89df70a0418c9d1f0e92952005cd02c16c"},{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"2bdbc618fc0a88e6345122eaaa743c09be150c67","unresolved":false,"context_lines":[{"line_number":20,"context_line":"    fi"},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"    local ansible_python_path"},{"line_number":23,"context_line":"    ansible_python_path\u003d${ansible_shebang_line#\\#\\!}"},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"    if ! \"$ansible_python_path\" --version \u0026\u003e/dev/null; then"},{"line_number":26,"context_line":"        echo \"ERROR: Ansible Python is not functional.\" \u003e\u00262"}],"source_content_type":"application/x-shellscript","patch_set":5,"id":"1f493fa4_7dd16523","line":23,"in_reply_to":"1f493fa4_19b036dd","updated":"2020-04-27 14:45:23.000000000","message":"Hmm, true. I should drop \" from L25, that is the fix.\nFWIW, I never saw Python do this with env, even distro\u0027s.\nThis would more likely break if the line had other arguments to python interpreter. Good catch.","commit_id":"223c1f89df70a0418c9d1f0e92952005cd02c16c"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"749a3878a76f625aeb1521a4da32c294c2d2baf2","unresolved":false,"context_lines":[{"line_number":53,"context_line":"        exit 1"},{"line_number":54,"context_line":"    fi"},{"line_number":55,"context_line":""},{"line_number":56,"context_line":"    # Check for existence of kolla_ansible module using Ansible\u0027s Python."},{"line_number":57,"context_line":"    if ! \"$ansible_python_path\" -c \u0027import kolla_ansible\u0027 \u0026\u003e/dev/null; then"},{"line_number":58,"context_line":"        echo \"ERROR: kolla_ansible has to be available in the Ansible PYTHONPATH.\" \u003e\u00262"},{"line_number":59,"context_line":"        echo \"Please install both in the same (virtual) environment.\" \u003e\u00262"},{"line_number":60,"context_line":"        exit 1"},{"line_number":61,"context_line":"    fi"},{"line_number":62,"context_line":""},{"line_number":63,"context_line":"    local ANSIBLE_VERSION_MIN\u003d2.8"},{"line_number":64,"context_line":"    local ANSIBLE_VERSION_MAX\u003d2.9"}],"source_content_type":"application/x-shellscript","patch_set":5,"id":"1f493fa4_997e06ad","line":61,"range":{"start_line":56,"start_character":0,"end_line":61,"end_character":6},"updated":"2020-04-27 14:34:24.000000000","message":"We\u0027ve done this already","commit_id":"223c1f89df70a0418c9d1f0e92952005cd02c16c"},{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"2bdbc618fc0a88e6345122eaaa743c09be150c67","unresolved":false,"context_lines":[{"line_number":53,"context_line":"        exit 1"},{"line_number":54,"context_line":"    fi"},{"line_number":55,"context_line":""},{"line_number":56,"context_line":"    # Check for existence of kolla_ansible module using Ansible\u0027s Python."},{"line_number":57,"context_line":"    if ! \"$ansible_python_path\" -c \u0027import kolla_ansible\u0027 \u0026\u003e/dev/null; then"},{"line_number":58,"context_line":"        echo \"ERROR: kolla_ansible has to be available in the Ansible PYTHONPATH.\" \u003e\u00262"},{"line_number":59,"context_line":"        echo \"Please install both in the same (virtual) environment.\" \u003e\u00262"},{"line_number":60,"context_line":"        exit 1"},{"line_number":61,"context_line":"    fi"},{"line_number":62,"context_line":""},{"line_number":63,"context_line":"    local ANSIBLE_VERSION_MIN\u003d2.8"},{"line_number":64,"context_line":"    local ANSIBLE_VERSION_MAX\u003d2.9"}],"source_content_type":"application/x-shellscript","patch_set":5,"id":"1f493fa4_3d0d1de8","line":61,"range":{"start_line":56,"start_character":0,"end_line":61,"end_character":6},"in_reply_to":"1f493fa4_997e06ad","updated":"2020-04-27 14:45:23.000000000","message":"BUT MAYBE IT CHANGED :D","commit_id":"223c1f89df70a0418c9d1f0e92952005cd02c16c"},{"author":{"_account_id":22165,"name":"caoyuan","email":"cao.yingjunz@gmail.com","username":"caoyuan"},"change_message_id":"c0cd3f8c95715fd5ac1b59f6202b662a8f208f93","unresolved":false,"context_lines":[{"line_number":1,"context_line":"#!/bin/bash"},{"line_number":2,"context_line":"#"},{"line_number":3,"context_line":"# This script can be used to interact with kolla via ansible."},{"line_number":4,"context_line":""},{"line_number":5,"context_line":"function check_environment_coherence {"},{"line_number":6,"context_line":"    local ansible_path"}],"source_content_type":"application/x-shellscript","patch_set":6,"id":"ff570b3c_452a3b90","line":3,"range":{"start_line":3,"start_character":43,"end_line":3,"end_character":48},"updated":"2020-05-23 15:17:33.000000000","message":"irrelevant, \nkolla-ansible splited from kolla for a long time, here should be kolla-ansible rather than kolla","commit_id":"32fc2599a665e01b47c74588cdc2b547dc208874"},{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"a25ddca735ace6abc676fb36e83f1e43f60869d4","unresolved":false,"context_lines":[{"line_number":1,"context_line":"#!/bin/bash"},{"line_number":2,"context_line":"#"},{"line_number":3,"context_line":"# This script can be used to interact with kolla via ansible."},{"line_number":4,"context_line":""},{"line_number":5,"context_line":"function check_environment_coherence {"},{"line_number":6,"context_line":"    local ansible_path"}],"source_content_type":"application/x-shellscript","patch_set":6,"id":"ff570b3c_283f1eb6","line":3,"range":{"start_line":3,"start_character":43,"end_line":3,"end_character":48},"in_reply_to":"ff570b3c_452a3b90","updated":"2020-05-23 15:32:31.000000000","message":"not touching the comment with this change but yeah it sounds weird, still \"kolla-ansible via ansible\" would be awkward; \"the kolla-ansible script\" is probably the best","commit_id":"32fc2599a665e01b47c74588cdc2b547dc208874"}]}