)]}'
{"ansible/library/kolla_docker.py":[{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"aa9e5033b03425a2ed393452bc4353f37d510cf6","unresolved":false,"context_lines":[{"line_number":833,"context_line":"            graceful_timeout \u003d 10"},{"line_number":834,"context_line":"        container \u003d self.check_container()"},{"line_number":835,"context_line":"        if not container:"},{"line_number":836,"context_line":"            ignore_missing \u003d self.params.get(\u0027ignore_missing\u0027)"},{"line_number":837,"context_line":"            if not ignore_missing:"},{"line_number":838,"context_line":"                self.module.fail_json("},{"line_number":839,"context_line":"                    msg\u003d\"No such container: {} to stop\".format(name))"}],"source_content_type":"text/x-python","patch_set":8,"id":"ff570b3c_2f62cb0a","line":836,"range":{"start_line":836,"start_character":12,"end_line":836,"end_character":62},"updated":"2020-05-20 07:32:10.000000000","message":"I don\u0027t understand this - Ansible is declarative - right? So if it doesn\u0027t exist, it won\u0027t be stopped and we should silently ignore the error?","commit_id":"811a4c3dc07a8ba49bafdd65b98f0cd6f52f4429"},{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"1c2df2a7ebfc244cf248283c011d126cd6c6c93e","unresolved":false,"context_lines":[{"line_number":833,"context_line":"            graceful_timeout \u003d 10"},{"line_number":834,"context_line":"        container \u003d self.check_container()"},{"line_number":835,"context_line":"        if not container:"},{"line_number":836,"context_line":"            ignore_missing \u003d self.params.get(\u0027ignore_missing\u0027)"},{"line_number":837,"context_line":"            if not ignore_missing:"},{"line_number":838,"context_line":"                self.module.fail_json("},{"line_number":839,"context_line":"                    msg\u003d\"No such container: {} to stop\".format(name))"}],"source_content_type":"text/x-python","patch_set":8,"id":"ff570b3c_daa66f0f","line":836,"range":{"start_line":836,"start_character":12,"end_line":836,"end_character":62},"in_reply_to":"ff570b3c_2f62cb0a","updated":"2020-05-20 07:44:38.000000000","message":"Well, at least it tries. ;-) Puppet was really declarative.\n\nIt could be made the default but sometimes you want to be right and fail when not I guess.","commit_id":"811a4c3dc07a8ba49bafdd65b98f0cd6f52f4429"},{"author":{"_account_id":167,"name":"Christian Berendt","email":"berendt@osism.tech","username":"berendt"},"change_message_id":"651b5eac42e86117c5ff93d377beccb25865652c","unresolved":false,"context_lines":[{"line_number":967,"context_line":"        dimensions\u003ddict(required\u003dFalse, type\u003d\u0027dict\u0027, default\u003ddict()),"},{"line_number":968,"context_line":"        tty\u003ddict(required\u003dFalse, type\u003d\u0027bool\u0027, default\u003dFalse),"},{"line_number":969,"context_line":"        client_timeout\u003ddict(required\u003dFalse, type\u003d\u0027int\u0027, default\u003d120),"},{"line_number":970,"context_line":"        ignore_missing\u003ddict(required\u003dFalse, type\u003d\u0027bool\u0027, default\u003dFalse),"},{"line_number":971,"context_line":"    )"},{"line_number":972,"context_line":"    required_if \u003d ["},{"line_number":973,"context_line":"        [\u0027action\u0027, \u0027pull_image\u0027, [\u0027image\u0027]],"}],"source_content_type":"text/x-python","patch_set":8,"id":"1f493fa4_73b728da","line":970,"updated":"2020-05-06 08:12:22.000000000","message":"The name of this parameter is a little bit confusing. A stopped container is stopped and not missing. A missing container is not existent.","commit_id":"811a4c3dc07a8ba49bafdd65b98f0cd6f52f4429"},{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"1fd38e10041357d413641c4f2ef7d1e928895c8c","unresolved":false,"context_lines":[{"line_number":967,"context_line":"        dimensions\u003ddict(required\u003dFalse, type\u003d\u0027dict\u0027, default\u003ddict()),"},{"line_number":968,"context_line":"        tty\u003ddict(required\u003dFalse, type\u003d\u0027bool\u0027, default\u003dFalse),"},{"line_number":969,"context_line":"        client_timeout\u003ddict(required\u003dFalse, type\u003d\u0027int\u0027, default\u003d120),"},{"line_number":970,"context_line":"        ignore_missing\u003ddict(required\u003dFalse, type\u003d\u0027bool\u0027, default\u003dFalse),"},{"line_number":971,"context_line":"    )"},{"line_number":972,"context_line":"    required_if \u003d ["},{"line_number":973,"context_line":"        [\u0027action\u0027, \u0027pull_image\u0027, [\u0027image\u0027]],"}],"source_content_type":"text/x-python","patch_set":8,"id":"1f493fa4_fc4f80bb","line":970,"in_reply_to":"1f493fa4_28eb67dc","updated":"2020-05-06 15:14:28.000000000","message":"Yeah, no problem, they were *always* ignored (treated as OK state).","commit_id":"811a4c3dc07a8ba49bafdd65b98f0cd6f52f4429"},{"author":{"_account_id":167,"name":"Christian Berendt","email":"berendt@osism.tech","username":"berendt"},"change_message_id":"69c85518a3821c17b40d384c8f55405184125315","unresolved":false,"context_lines":[{"line_number":967,"context_line":"        dimensions\u003ddict(required\u003dFalse, type\u003d\u0027dict\u0027, default\u003ddict()),"},{"line_number":968,"context_line":"        tty\u003ddict(required\u003dFalse, type\u003d\u0027bool\u0027, default\u003dFalse),"},{"line_number":969,"context_line":"        client_timeout\u003ddict(required\u003dFalse, type\u003d\u0027int\u0027, default\u003d120),"},{"line_number":970,"context_line":"        ignore_missing\u003ddict(required\u003dFalse, type\u003d\u0027bool\u0027, default\u003dFalse),"},{"line_number":971,"context_line":"    )"},{"line_number":972,"context_line":"    required_if \u003d ["},{"line_number":973,"context_line":"        [\u0027action\u0027, \u0027pull_image\u0027, [\u0027image\u0027]],"}],"source_content_type":"text/x-python","patch_set":8,"id":"1f493fa4_28eb67dc","line":970,"in_reply_to":"1f493fa4_7305687a","updated":"2020-05-06 14:25:19.000000000","message":"Sorry, then I had it wrong. I thought containers that had already been stopped were also ignored.","commit_id":"811a4c3dc07a8ba49bafdd65b98f0cd6f52f4429"},{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"4068ec7f59d97e6a935d9a06dda83443e31123e0","unresolved":false,"context_lines":[{"line_number":967,"context_line":"        dimensions\u003ddict(required\u003dFalse, type\u003d\u0027dict\u0027, default\u003ddict()),"},{"line_number":968,"context_line":"        tty\u003ddict(required\u003dFalse, type\u003d\u0027bool\u0027, default\u003dFalse),"},{"line_number":969,"context_line":"        client_timeout\u003ddict(required\u003dFalse, type\u003d\u0027int\u0027, default\u003d120),"},{"line_number":970,"context_line":"        ignore_missing\u003ddict(required\u003dFalse, type\u003d\u0027bool\u0027, default\u003dFalse),"},{"line_number":971,"context_line":"    )"},{"line_number":972,"context_line":"    required_if \u003d ["},{"line_number":973,"context_line":"        [\u0027action\u0027, \u0027pull_image\u0027, [\u0027image\u0027]],"}],"source_content_type":"text/x-python","patch_set":8,"id":"1f493fa4_7305687a","line":970,"in_reply_to":"1f493fa4_73b728da","updated":"2020-05-06 08:16:03.000000000","message":"Where is the confusion? This works exactly as you wrote.","commit_id":"811a4c3dc07a8ba49bafdd65b98f0cd6f52f4429"}],"ansible/roles/haproxy/handlers/main.yml":[{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"aa9e5033b03425a2ed393452bc4353f37d510cf6","unresolved":false,"context_lines":[{"line_number":5,"context_line":"# Master node is handled specially to let it close down connections and only then"},{"line_number":6,"context_line":"# drop the VIP address by stopping keepalived service."},{"line_number":7,"context_line":""},{"line_number":8,"context_line":"# NOTE(yoctozepto): we need fresh VIP address placement info (facts may be old)"},{"line_number":9,"context_line":"- name: Check IP addresses on the API interface"},{"line_number":10,"context_line":"  vars:"},{"line_number":11,"context_line":"    version: \"{{ \u00276\u0027 if api_address_family \u003d\u003d \u0027ipv6\u0027 else \u00274\u0027 }}\""}],"source_content_type":"text/x-yaml","patch_set":8,"id":"ff570b3c_4f53bf39","line":8,"range":{"start_line":8,"start_character":0,"end_line":8,"end_character":79},"updated":"2020-05-20 07:32:10.000000000","message":"maybe gather fresh facts subset instead of doing that?","commit_id":"811a4c3dc07a8ba49bafdd65b98f0cd6f52f4429"},{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"14f145e57fc7dc2156e44451bdbf52cb98bbfe70","unresolved":false,"context_lines":[{"line_number":5,"context_line":"# Master node is handled specially to let it close down connections and only then"},{"line_number":6,"context_line":"# drop the VIP address by stopping keepalived service."},{"line_number":7,"context_line":""},{"line_number":8,"context_line":"# NOTE(yoctozepto): we need fresh VIP address placement info (facts may be old)"},{"line_number":9,"context_line":"- name: Check IP addresses on the API interface"},{"line_number":10,"context_line":"  vars:"},{"line_number":11,"context_line":"    version: \"{{ \u00276\u0027 if api_address_family \u003d\u003d \u0027ipv6\u0027 else \u00274\u0027 }}\""}],"source_content_type":"text/x-yaml","patch_set":8,"id":"ff570b3c_7ae5a337","line":8,"range":{"start_line":8,"start_character":0,"end_line":8,"end_character":79},"in_reply_to":"ff570b3c_4f53bf39","updated":"2020-05-20 07:49:06.000000000","message":"I might follow-up and see if it looks better. Not touching for now.","commit_id":"811a4c3dc07a8ba49bafdd65b98f0cd6f52f4429"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"225558a702901cba38290c1fd99a8cf1d698be24","unresolved":false,"context_lines":[{"line_number":5,"context_line":"# Master node is handled specially to let it close down connections and only then"},{"line_number":6,"context_line":"# drop the VIP address by stopping keepalived service."},{"line_number":7,"context_line":""},{"line_number":8,"context_line":"# NOTE(yoctozepto): we need fresh VIP address placement info (facts may be old)"},{"line_number":9,"context_line":"- name: Check IP addresses on the API interface"},{"line_number":10,"context_line":"  vars:"},{"line_number":11,"context_line":"    version: \"{{ \u00276\u0027 if api_address_family \u003d\u003d \u0027ipv6\u0027 else \u00274\u0027 }}\""}],"source_content_type":"text/x-yaml","patch_set":8,"id":"ff570b3c_ff4869b3","line":8,"range":{"start_line":8,"start_character":0,"end_line":8,"end_character":79},"in_reply_to":"ff570b3c_7ae5a337","updated":"2020-08-03 10:06:52.000000000","message":"Would prefer not to touch facts to keep fact caching happy.","commit_id":"811a4c3dc07a8ba49bafdd65b98f0cd6f52f4429"},{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"b9c7b38d9ed67b926e57145517826d9327c92c14","unresolved":false,"context_lines":[{"line_number":5,"context_line":"# Master node is handled specially to let it close down connections and only then"},{"line_number":6,"context_line":"# drop the VIP address by stopping keepalived service."},{"line_number":7,"context_line":""},{"line_number":8,"context_line":"# NOTE(yoctozepto): we need fresh VIP address placement info (facts may be old)"},{"line_number":9,"context_line":"- name: Check IP addresses on the API interface"},{"line_number":10,"context_line":"  vars:"},{"line_number":11,"context_line":"    version: \"{{ \u00276\u0027 if api_address_family \u003d\u003d \u0027ipv6\u0027 else \u00274\u0027 }}\""}],"source_content_type":"text/x-yaml","patch_set":8,"id":"9f560f44_c9d3985f","line":8,"range":{"start_line":8,"start_character":0,"end_line":8,"end_character":79},"in_reply_to":"ff570b3c_ff4869b3","updated":"2020-08-03 12:25:17.000000000","message":"++","commit_id":"811a4c3dc07a8ba49bafdd65b98f0cd6f52f4429"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"225558a702901cba38290c1fd99a8cf1d698be24","unresolved":false,"context_lines":[{"line_number":21,"context_line":""},{"line_number":22,"context_line":"- name: Group HA nodes by status"},{"line_number":23,"context_line":"  group_by:"},{"line_number":24,"context_line":"    key: kolla_ha_is_master_{{ ip_addr_output.stdout is regex(\u0027\\b\u0027 + kolla_internal_vip_address + \u0027\\b\u0027) }}"},{"line_number":25,"context_line":"  when:"},{"line_number":26,"context_line":"    - kolla_action !\u003d \"config\""},{"line_number":27,"context_line":"  listen:"}],"source_content_type":"text/x-yaml","patch_set":8,"id":"9f560f44_33544353","line":24,"range":{"start_line":24,"start_character":69,"end_line":24,"end_character":95},"updated":"2020-08-03 10:06:52.000000000","message":"Do the periods need escaping here?","commit_id":"811a4c3dc07a8ba49bafdd65b98f0cd6f52f4429"},{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"b9c7b38d9ed67b926e57145517826d9327c92c14","unresolved":false,"context_lines":[{"line_number":21,"context_line":""},{"line_number":22,"context_line":"- name: Group HA nodes by status"},{"line_number":23,"context_line":"  group_by:"},{"line_number":24,"context_line":"    key: kolla_ha_is_master_{{ ip_addr_output.stdout is regex(\u0027\\b\u0027 + kolla_internal_vip_address + \u0027\\b\u0027) }}"},{"line_number":25,"context_line":"  when:"},{"line_number":26,"context_line":"    - kolla_action !\u003d \"config\""},{"line_number":27,"context_line":"  listen:"}],"source_content_type":"text/x-yaml","patch_set":8,"id":"9f560f44_c906f8ce","line":24,"range":{"start_line":24,"start_character":69,"end_line":24,"end_character":95},"in_reply_to":"9f560f44_33544353","updated":"2020-08-03 12:25:17.000000000","message":"Eagle eye! It probably does not matter much in practice as there is only the chance that somebody named their interfaces very weirdly (as no other ip address would match anyhow), e.g. 192e168t0h1 :-)","commit_id":"811a4c3dc07a8ba49bafdd65b98f0cd6f52f4429"},{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"4aa60051d3cc632f8152e6fdc06d37b8c4fb12e2","unresolved":false,"context_lines":[{"line_number":21,"context_line":""},{"line_number":22,"context_line":"- name: Group HA nodes by status"},{"line_number":23,"context_line":"  group_by:"},{"line_number":24,"context_line":"    key: kolla_ha_is_master_{{ ip_addr_output.stdout is regex(\u0027\\b\u0027 + kolla_internal_vip_address + \u0027\\b\u0027) }}"},{"line_number":25,"context_line":"  when:"},{"line_number":26,"context_line":"    - kolla_action !\u003d \"config\""},{"line_number":27,"context_line":"  listen:"}],"source_content_type":"text/x-yaml","patch_set":8,"id":"9f560f44_55def76c","line":24,"range":{"start_line":24,"start_character":69,"end_line":24,"end_character":95},"in_reply_to":"9f560f44_c906f8ce","updated":"2020-08-03 15:15:33.000000000","message":"Actually just noticed I\u0027m anchoring with \\b so it would match e.g. 111.111.111.111 with 1.1.1.1 (as dots would match the \\b\u0027s). Still, it would be very unfortunate.","commit_id":"811a4c3dc07a8ba49bafdd65b98f0cd6f52f4429"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"225558a702901cba38290c1fd99a8cf1d698be24","unresolved":false,"context_lines":[{"line_number":96,"context_line":"    - Wait for virtual IP to appear"},{"line_number":97,"context_line":""},{"line_number":98,"context_line":"# NOTE(yoctozepto): This is to ensure haproxy can close any open connections"},{"line_number":99,"context_line":"# to the VIP address."},{"line_number":100,"context_line":"- name: Stop master haproxy container"},{"line_number":101,"context_line":"  become: true"},{"line_number":102,"context_line":"  kolla_docker:"}],"source_content_type":"text/x-yaml","patch_set":8,"id":"9f560f44_3302833e","line":99,"updated":"2020-08-03 10:06:52.000000000","message":"Good move. This should lead to a cleaner failover.","commit_id":"811a4c3dc07a8ba49bafdd65b98f0cd6f52f4429"},{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"b9c7b38d9ed67b926e57145517826d9327c92c14","unresolved":false,"context_lines":[{"line_number":96,"context_line":"    - Wait for virtual IP to appear"},{"line_number":97,"context_line":""},{"line_number":98,"context_line":"# NOTE(yoctozepto): This is to ensure haproxy can close any open connections"},{"line_number":99,"context_line":"# to the VIP address."},{"line_number":100,"context_line":"- name: Stop master haproxy container"},{"line_number":101,"context_line":"  become: true"},{"line_number":102,"context_line":"  kolla_docker:"}],"source_content_type":"text/x-yaml","patch_set":8,"id":"9f560f44_a90bc4d3","line":99,"in_reply_to":"9f560f44_3302833e","updated":"2020-08-03 12:25:17.000000000","message":":-)","commit_id":"811a4c3dc07a8ba49bafdd65b98f0cd6f52f4429"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"b831195d42cb62bed130b41b0ae75861c359a361","unresolved":false,"context_lines":[{"line_number":30,"context_line":"    - Restart haproxy container"},{"line_number":31,"context_line":"    - Restart keepalived container"},{"line_number":32,"context_line":""},{"line_number":33,"context_line":"- name: Stop backup keepalived container"},{"line_number":34,"context_line":"  become: true"},{"line_number":35,"context_line":"  kolla_docker:"},{"line_number":36,"context_line":"    action: \"stop_container\""}],"source_content_type":"text/x-yaml","patch_set":10,"id":"9f560f44_037a5bb8","line":33,"updated":"2020-08-24 19:26:26.000000000","message":"drop \u0027Restart haproxy container\u0027?","commit_id":"e6fd7ad2d13eae7edfb9d8c69d3516e4e45dd506"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"13b00ed88feb419054f80adca4e2d03eabb422b9","unresolved":false,"context_lines":[{"line_number":30,"context_line":"    - Restart haproxy container"},{"line_number":31,"context_line":"    - Restart keepalived container"},{"line_number":32,"context_line":""},{"line_number":33,"context_line":"- name: Stop backup keepalived container"},{"line_number":34,"context_line":"  become: true"},{"line_number":35,"context_line":"  kolla_docker:"},{"line_number":36,"context_line":"    action: \"stop_container\""},{"line_number":37,"context_line":"    # NOTE(yoctozepto): backup node might not have keepalived yet - ignore"},{"line_number":38,"context_line":"    ignore_missing: true"},{"line_number":39,"context_line":"    common_options: \"{{ docker_common_options }}\""},{"line_number":40,"context_line":"    name: \"keepalived\""},{"line_number":41,"context_line":"  when:"},{"line_number":42,"context_line":"    - kolla_action !\u003d \"config\""},{"line_number":43,"context_line":"    - groups.kolla_ha_is_master_False is defined"},{"line_number":44,"context_line":"    - inventory_hostname in groups.kolla_ha_is_master_False"},{"line_number":45,"context_line":"  listen:"},{"line_number":46,"context_line":"    - Restart haproxy container"},{"line_number":47,"context_line":"    - Restart keepalived container"},{"line_number":48,"context_line":""},{"line_number":49,"context_line":"- name: Restart backup haproxy container"},{"line_number":50,"context_line":"  vars:"}],"source_content_type":"text/x-yaml","patch_set":10,"id":"9f560f44_4a66d62b","line":47,"range":{"start_line":33,"start_character":0,"end_line":47,"end_character":34},"updated":"2020-08-12 09:57:46.000000000","message":"Wondering why we don\u0027t just do a full restart of keepalived here. If there\u0027s a reason then please add a comment.","commit_id":"e6fd7ad2d13eae7edfb9d8c69d3516e4e45dd506"},{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"0593a6f5f97254c25dd743b2c07bb64cefdb4cfb","unresolved":false,"context_lines":[{"line_number":30,"context_line":"    - Restart haproxy container"},{"line_number":31,"context_line":"    - Restart keepalived container"},{"line_number":32,"context_line":""},{"line_number":33,"context_line":"- name: Stop backup keepalived container"},{"line_number":34,"context_line":"  become: true"},{"line_number":35,"context_line":"  kolla_docker:"},{"line_number":36,"context_line":"    action: \"stop_container\""},{"line_number":37,"context_line":"    # NOTE(yoctozepto): backup node might not have keepalived yet - ignore"},{"line_number":38,"context_line":"    ignore_missing: true"},{"line_number":39,"context_line":"    common_options: \"{{ docker_common_options }}\""},{"line_number":40,"context_line":"    name: \"keepalived\""},{"line_number":41,"context_line":"  when:"},{"line_number":42,"context_line":"    - kolla_action !\u003d \"config\""},{"line_number":43,"context_line":"    - groups.kolla_ha_is_master_False is defined"},{"line_number":44,"context_line":"    - inventory_hostname in groups.kolla_ha_is_master_False"},{"line_number":45,"context_line":"  listen:"},{"line_number":46,"context_line":"    - Restart haproxy container"},{"line_number":47,"context_line":"    - Restart keepalived container"},{"line_number":48,"context_line":""},{"line_number":49,"context_line":"- name: Restart backup haproxy container"},{"line_number":50,"context_line":"  vars:"}],"source_content_type":"text/x-yaml","patch_set":10,"id":"9f560f44_e510bd52","line":47,"range":{"start_line":33,"start_character":0,"end_line":47,"end_character":34},"in_reply_to":"9f560f44_4a66d62b","updated":"2020-08-12 10:01:11.000000000","message":"To avoid a situation where VIP moves to a non-working haproxy.","commit_id":"e6fd7ad2d13eae7edfb9d8c69d3516e4e45dd506"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"4a3a88cd6412d78b516fd3a5f55b9572411e3ced","unresolved":false,"context_lines":[{"line_number":30,"context_line":"    - Restart haproxy container"},{"line_number":31,"context_line":"    - Restart keepalived container"},{"line_number":32,"context_line":""},{"line_number":33,"context_line":"- name: Stop backup keepalived container"},{"line_number":34,"context_line":"  become: true"},{"line_number":35,"context_line":"  kolla_docker:"},{"line_number":36,"context_line":"    action: \"stop_container\""},{"line_number":37,"context_line":"    # NOTE(yoctozepto): backup node might not have keepalived yet - ignore"},{"line_number":38,"context_line":"    ignore_missing: true"},{"line_number":39,"context_line":"    common_options: \"{{ docker_common_options }}\""},{"line_number":40,"context_line":"    name: \"keepalived\""},{"line_number":41,"context_line":"  when:"},{"line_number":42,"context_line":"    - kolla_action !\u003d \"config\""},{"line_number":43,"context_line":"    - groups.kolla_ha_is_master_False is defined"},{"line_number":44,"context_line":"    - inventory_hostname in groups.kolla_ha_is_master_False"},{"line_number":45,"context_line":"  listen:"},{"line_number":46,"context_line":"    - Restart haproxy container"},{"line_number":47,"context_line":"    - Restart keepalived container"},{"line_number":48,"context_line":""},{"line_number":49,"context_line":"- name: Restart backup haproxy container"},{"line_number":50,"context_line":"  vars:"}],"source_content_type":"text/x-yaml","patch_set":10,"id":"9f560f44_6504ad7f","line":47,"range":{"start_line":33,"start_character":0,"end_line":47,"end_character":34},"in_reply_to":"9f560f44_e510bd52","updated":"2020-08-12 10:46:22.000000000","message":"ok, makes sense.","commit_id":"e6fd7ad2d13eae7edfb9d8c69d3516e4e45dd506"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"b831195d42cb62bed130b41b0ae75861c359a361","unresolved":false,"context_lines":[{"line_number":74,"context_line":"    host: \"{{ api_interface_address }}\""},{"line_number":75,"context_line":"    port: \"{{ haproxy_monitor_port }}\""},{"line_number":76,"context_line":""},{"line_number":77,"context_line":"- name: Start backup keepalived container"},{"line_number":78,"context_line":"  vars:"},{"line_number":79,"context_line":"    service_name: \"keepalived\""},{"line_number":80,"context_line":"    service: \"{{ haproxy_services[service_name] }}\""}],"source_content_type":"text/x-yaml","patch_set":10,"id":"9f560f44_634cf79d","line":77,"range":{"start_line":77,"start_character":0,"end_line":77,"end_character":41},"updated":"2020-08-24 19:26:26.000000000","message":"drop \u0027Restart haproxy container\u0027?","commit_id":"e6fd7ad2d13eae7edfb9d8c69d3516e4e45dd506"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"b831195d42cb62bed130b41b0ae75861c359a361","unresolved":false,"context_lines":[{"line_number":99,"context_line":""},{"line_number":100,"context_line":"# NOTE(yoctozepto): This is to ensure haproxy can close any open connections"},{"line_number":101,"context_line":"# to the VIP address."},{"line_number":102,"context_line":"- name: Stop master haproxy container"},{"line_number":103,"context_line":"  become: true"},{"line_number":104,"context_line":"  kolla_docker:"},{"line_number":105,"context_line":"    action: \"stop_container\""}],"source_content_type":"text/x-yaml","patch_set":10,"id":"9f560f44_03537b3a","line":102,"updated":"2020-08-24 19:26:26.000000000","message":"drop \u0027Restart haproxy container\u0027?","commit_id":"e6fd7ad2d13eae7edfb9d8c69d3516e4e45dd506"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"13b00ed88feb419054f80adca4e2d03eabb422b9","unresolved":false,"context_lines":[{"line_number":113,"context_line":"    - Restart haproxy container"},{"line_number":114,"context_line":"    - Restart keepalived container"},{"line_number":115,"context_line":""},{"line_number":116,"context_line":"- name: Stop master keepalived container"},{"line_number":117,"context_line":"  become: true"},{"line_number":118,"context_line":"  kolla_docker:"},{"line_number":119,"context_line":"    action: \"stop_container\""}],"source_content_type":"text/x-yaml","patch_set":10,"id":"9f560f44_8a3e2ed8","line":116,"updated":"2020-08-12 09:57:46.000000000","message":"Again, could just restart here?","commit_id":"e6fd7ad2d13eae7edfb9d8c69d3516e4e45dd506"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"b831195d42cb62bed130b41b0ae75861c359a361","unresolved":false,"context_lines":[{"line_number":113,"context_line":"    - Restart haproxy container"},{"line_number":114,"context_line":"    - Restart keepalived container"},{"line_number":115,"context_line":""},{"line_number":116,"context_line":"- name: Stop master keepalived container"},{"line_number":117,"context_line":"  become: true"},{"line_number":118,"context_line":"  kolla_docker:"},{"line_number":119,"context_line":"    action: \"stop_container\""}],"source_content_type":"text/x-yaml","patch_set":10,"id":"9f560f44_6331970b","line":116,"in_reply_to":"9f560f44_05185173","updated":"2020-08-24 19:26:26.000000000","message":"drop \u0027Restart haproxy container\u0027?","commit_id":"e6fd7ad2d13eae7edfb9d8c69d3516e4e45dd506"},{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"0593a6f5f97254c25dd743b2c07bb64cefdb4cfb","unresolved":false,"context_lines":[{"line_number":113,"context_line":"    - Restart haproxy container"},{"line_number":114,"context_line":"    - Restart keepalived container"},{"line_number":115,"context_line":""},{"line_number":116,"context_line":"- name: Stop master keepalived container"},{"line_number":117,"context_line":"  become: true"},{"line_number":118,"context_line":"  kolla_docker:"},{"line_number":119,"context_line":"    action: \"stop_container\""}],"source_content_type":"text/x-yaml","patch_set":10,"id":"9f560f44_05185173","line":116,"in_reply_to":"9f560f44_8a3e2ed8","updated":"2020-08-12 10:01:11.000000000","message":"Again, no. Need to keep it down until haproxy is really ready to avoid odd flaps.","commit_id":"e6fd7ad2d13eae7edfb9d8c69d3516e4e45dd506"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"b831195d42cb62bed130b41b0ae75861c359a361","unresolved":false,"context_lines":[{"line_number":155,"context_line":"    host: \"{{ api_interface_address }}\""},{"line_number":156,"context_line":"    port: \"{{ haproxy_monitor_port }}\""},{"line_number":157,"context_line":""},{"line_number":158,"context_line":"- name: Start master keepalived container"},{"line_number":159,"context_line":"  vars:"},{"line_number":160,"context_line":"    service_name: \"keepalived\""},{"line_number":161,"context_line":"    service: \"{{ haproxy_services[service_name] }}\""}],"source_content_type":"text/x-yaml","patch_set":10,"id":"9f560f44_833cabe1","line":158,"updated":"2020-08-24 19:26:26.000000000","message":"drop \u0027Restart haproxy container\u0027?","commit_id":"e6fd7ad2d13eae7edfb9d8c69d3516e4e45dd506"}]}