)]}'
{"ansible/group_vars/all.yml":[{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"67f4bf64a852ff66880df593d4fc14d0acd72907","unresolved":false,"context_lines":[{"line_number":758,"context_line":"kolla_verify_tls_backend: \"yes\""},{"line_number":759,"context_line":"haproxy_backend_cacert: \"{{ \u0027ca-certificates.crt\u0027 if kolla_base_distro in [\u0027debian\u0027, \u0027ubuntu\u0027] else \u0027ca-bundle.trust.crt\u0027 }}\""},{"line_number":760,"context_line":"haproxy_backend_cacert_dir: \"/etc/ssl/certs\""},{"line_number":761,"context_line":"kolla_enable_tls_backend: \"no\""},{"line_number":762,"context_line":"kolla_tls_backend_cert: \"{{ kolla_certificates_dir }}/backend-cert.pem\""},{"line_number":763,"context_line":"kolla_tls_backend_key: \"{{ kolla_certificates_dir }}/backend-key.pem\""},{"line_number":764,"context_line":"kolla_httpd_keep_alive: \"60\""},{"line_number":765,"context_line":""},{"line_number":766,"context_line":"####################"},{"line_number":767,"context_line":"# Kibana options"}],"source_content_type":"text/x-yaml","patch_set":29,"id":"9f560f44_7e9ac5b8","line":764,"range":{"start_line":761,"start_character":0,"end_line":764,"end_character":28},"updated":"2020-08-06 11:07:01.000000000","message":"These options are about backends. Let\u0027s add a new section heading - Backend options","commit_id":"5925096b9569939647908ac4c1fc38976c1b1e3c"}],"ansible/roles/haproxy-config/defaults/main.yml":[{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"e39afe926d66291fe0aa539325ac9075660e6c8e","unresolved":false,"context_lines":[{"line_number":13,"context_line":"haproxy_backend_tcp_extra: []"},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"haproxy_health_check: \"check inter 2000 rise 2 fall 5\""},{"line_number":16,"context_line":"haproxy_health_check_ssl: \"check check-ssl inter 2000 rise 2 fall 5\""}],"source_content_type":"text/x-yaml","patch_set":17,"id":"bf51134e_51a11246","side":"PARENT","line":16,"range":{"start_line":16,"start_character":27,"end_line":16,"end_character":32},"updated":"2020-07-23 10:25:47.000000000","message":"Does this part need to be extracted into a separate change?","commit_id":"376988125a8f924f3853c845e12c73ac13b2df74"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"04bf1a1a702cb4ea43d22dbb91e91917d05b4444","unresolved":false,"context_lines":[{"line_number":13,"context_line":"haproxy_backend_tcp_extra: []"},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"haproxy_health_check: \"check inter 2000 rise 2 fall 5\""},{"line_number":16,"context_line":"haproxy_health_check_ssl: \"check check-ssl inter 2000 rise 2 fall 5\""}],"source_content_type":"text/x-yaml","patch_set":17,"id":"bf51134e_51bab26d","side":"PARENT","line":16,"range":{"start_line":16,"start_character":27,"end_line":16,"end_character":32},"in_reply_to":"bf51134e_51a11246","updated":"2020-07-23 10:28:52.000000000","message":"It looks like without including check, health checks will not be enabled?\n\nhttps://cbonte.github.io/haproxy-dconv/1.8/configuration.html#check-ssl","commit_id":"376988125a8f924f3853c845e12c73ac13b2df74"},{"author":{"_account_id":30810,"name":"James Kirsch","email":"generalfuzz@gmail.com","username":"generalfuzz"},"change_message_id":"e554cff86a96e9f730969bf63815357554daf701","unresolved":false,"context_lines":[{"line_number":13,"context_line":"haproxy_backend_tcp_extra: []"},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"haproxy_health_check: \"check inter 2000 rise 2 fall 5\""},{"line_number":16,"context_line":"haproxy_health_check_ssl: \"check check-ssl inter 2000 rise 2 fall 5\""}],"source_content_type":"text/x-yaml","patch_set":17,"id":"bf51134e_5163c8dd","side":"PARENT","line":16,"range":{"start_line":16,"start_character":27,"end_line":16,"end_character":32},"in_reply_to":"bf51134e_51bab26d","updated":"2020-07-23 18:32:14.000000000","message":"You are correct. The health checks seem to not play nicely with default uwsgi config, however that is not a concern with httpd","commit_id":"376988125a8f924f3853c845e12c73ac13b2df74"}],"ansible/roles/heat/templates/wsgi-heat-api.conf.j2":[{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"eef2cf51455b6ae394960dca2eb3a2837fea67e9","unresolved":false,"context_lines":[{"line_number":38,"context_line":"    \u003c/IfVersion\u003e"},{"line_number":39,"context_line":"    ErrorLog \"{{ heat_log_dir }}/heat-api-error.log\""},{"line_number":40,"context_line":"    LogFormat \"%{X-Forwarded-For}i %l %u %t \\\"%r\\\" %\u003es %b %D \\\"%{Referer}i\\\" \\\"%{User-Agent}i\\\"\" logformat"},{"line_number":41,"context_line":"    CustomLog \"{{ heat_log_dir }}/heat-api-access.log\" logformat"},{"line_number":42,"context_line":"{% if heat_enable_tls_backend | bool %}"},{"line_number":43,"context_line":"    SSLEngine On"},{"line_number":44,"context_line":"    SSLCertificateFile /etc/heat/certs/heat-cert.pem"}],"source_content_type":"text/x-jinja2","patch_set":21,"id":"bf51134e_964f20bd","line":41,"updated":"2020-07-23 09:10:45.000000000","message":"This is a bug fix. Can you extract and propose separately?","commit_id":"57c694c9bc6e0891a1b1ae50fbacd50b92c61500"},{"author":{"_account_id":30810,"name":"James Kirsch","email":"generalfuzz@gmail.com","username":"generalfuzz"},"change_message_id":"e554cff86a96e9f730969bf63815357554daf701","unresolved":false,"context_lines":[{"line_number":38,"context_line":"    \u003c/IfVersion\u003e"},{"line_number":39,"context_line":"    ErrorLog \"{{ heat_log_dir }}/heat-api-error.log\""},{"line_number":40,"context_line":"    LogFormat \"%{X-Forwarded-For}i %l %u %t \\\"%r\\\" %\u003es %b %D \\\"%{Referer}i\\\" \\\"%{User-Agent}i\\\"\" logformat"},{"line_number":41,"context_line":"    CustomLog \"{{ heat_log_dir }}/heat-api-access.log\" logformat"},{"line_number":42,"context_line":"{% if heat_enable_tls_backend | bool %}"},{"line_number":43,"context_line":"    SSLEngine On"},{"line_number":44,"context_line":"    SSLCertificateFile /etc/heat/certs/heat-cert.pem"}],"source_content_type":"text/x-jinja2","patch_set":21,"id":"bf51134e_51446819","line":41,"in_reply_to":"bf51134e_964f20bd","updated":"2020-07-23 18:32:14.000000000","message":"this is already merged via separate txn: https://review.opendev.org/727835","commit_id":"57c694c9bc6e0891a1b1ae50fbacd50b92c61500"}],"ansible/roles/keystone/templates/wsgi-keystone.conf.j2":[{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"eef2cf51455b6ae394960dca2eb3a2837fea67e9","unresolved":false,"context_lines":[{"line_number":11,"context_line":"{% else %}"},{"line_number":12,"context_line":"LoadModule ssl_module /usr/lib/apache2/modules/mod_ssl.so"},{"line_number":13,"context_line":"{% endif %}"},{"line_number":14,"context_line":"{% endif %}"},{"line_number":15,"context_line":"Listen {{ api_interface_address | put_address_in_context(\u0027url\u0027) }}:{{ keystone_public_listen_port }}"},{"line_number":16,"context_line":"Listen {{ api_interface_address | put_address_in_context(\u0027url\u0027) }}:{{ keystone_admin_listen_port }}"},{"line_number":17,"context_line":""}],"source_content_type":"text/x-jinja2","patch_set":21,"id":"bf51134e_f64e5cbf","line":14,"updated":"2020-07-23 09:10:45.000000000","message":"ditto","commit_id":"57c694c9bc6e0891a1b1ae50fbacd50b92c61500"},{"author":{"_account_id":30810,"name":"James Kirsch","email":"generalfuzz@gmail.com","username":"generalfuzz"},"change_message_id":"e554cff86a96e9f730969bf63815357554daf701","unresolved":false,"context_lines":[{"line_number":11,"context_line":"{% else %}"},{"line_number":12,"context_line":"LoadModule ssl_module /usr/lib/apache2/modules/mod_ssl.so"},{"line_number":13,"context_line":"{% endif %}"},{"line_number":14,"context_line":"{% endif %}"},{"line_number":15,"context_line":"Listen {{ api_interface_address | put_address_in_context(\u0027url\u0027) }}:{{ keystone_public_listen_port }}"},{"line_number":16,"context_line":"Listen {{ api_interface_address | put_address_in_context(\u0027url\u0027) }}:{{ keystone_admin_listen_port }}"},{"line_number":17,"context_line":""}],"source_content_type":"text/x-jinja2","patch_set":21,"id":"bf51134e_f15e5ce7","line":14,"in_reply_to":"bf51134e_f64e5cbf","updated":"2020-07-23 18:32:14.000000000","message":"same: https://review.opendev.org/#/c/727839/","commit_id":"57c694c9bc6e0891a1b1ae50fbacd50b92c61500"}],"ansible/roles/nova/defaults/main.yml":[{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"752bfa2d7bed62258f9f494ab1a31cb15d6d8a79","unresolved":false,"context_lines":[{"line_number":45,"context_line":"        external: false"},{"line_number":46,"context_line":"        port: \"{{ rdp_port }}\""},{"line_number":47,"context_line":"        host_group: \"hyperv\""},{"line_number":48,"context_line":"        tls_backend: \"{{ nova_enable_tls_backend }}\""},{"line_number":49,"context_line":"  nova-scheduler:"},{"line_number":50,"context_line":"    container_name: \"nova_scheduler\""},{"line_number":51,"context_line":"    group: \"nova-scheduler\""}],"source_content_type":"text/x-yaml","patch_set":1,"id":"1f493fa4_629afd61","line":48,"range":{"start_line":48,"start_character":8,"end_line":48,"end_character":19},"updated":"2020-05-01 14:49:44.000000000","message":"Not really supported","commit_id":"b4eb33bfcaf226cf3728672aa70228b1dccb3a99"}],"ansible/roles/nova/tasks/config.yml":[{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"752bfa2d7bed62258f9f494ab1a31cb15d6d8a79","unresolved":false,"context_lines":[{"line_number":57,"context_line":"  when:"},{"line_number":58,"context_line":"    - inventory_hostname in groups[item.value.group]"},{"line_number":59,"context_line":"    - item.value.enabled | bool"},{"line_number":60,"context_line":"  with_dict: \"{{ nova_services }}\""},{"line_number":61,"context_line":"  notify:"},{"line_number":62,"context_line":"    - \"Restart {{ item.key }} container\""},{"line_number":63,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":1,"id":"1f493fa4_6ea02943","line":60,"range":{"start_line":60,"start_character":2,"end_line":60,"end_character":11},"updated":"2020-05-01 14:49:44.000000000","message":"Only for nova-api","commit_id":"b4eb33bfcaf226cf3728672aa70228b1dccb3a99"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"5aa3d09473c0ed4dede5b8682f031fc8995fb703","unresolved":false,"context_lines":[{"line_number":55,"context_line":"    mode: \"0660\""},{"line_number":56,"context_line":"  become: true"},{"line_number":57,"context_line":"  when:"},{"line_number":58,"context_line":"    - inventory_hostname in groups[item.value.group]"},{"line_number":59,"context_line":"    - item.value.enabled | bool"},{"line_number":60,"context_line":"  notify:"},{"line_number":61,"context_line":"    - \"Restart nova-api container\""}],"source_content_type":"text/x-yaml","patch_set":2,"id":"1f493fa4_9b705074","line":58,"range":{"start_line":58,"start_character":35,"end_line":58,"end_character":39},"updated":"2020-05-01 16:31:04.000000000","message":"no item","commit_id":"d3062a44f0182ef7939d82487d01082574c135ca"}],"ansible/roles/nova/templates/nova-api-wsgi.conf.j2":[{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"752bfa2d7bed62258f9f494ab1a31cb15d6d8a79","unresolved":false,"context_lines":[{"line_number":6,"context_line":"{% endif %}"},{"line_number":7,"context_line":"{% set wsgi_directory \u003d \u0027/usr/bin\u0027 if nova_install_type \u003d\u003d \u0027binary\u0027 else \u0027/var/lib/kolla/venv/bin\u0027 %}"},{"line_number":8,"context_line":"{% if nova_enable_tls_backend | bool %}"},{"line_number":9,"context_line":"LoadModule ssl_module /usr/lib/apache2/modules/mod_ssl.so"},{"line_number":10,"context_line":"{% endif %}"},{"line_number":11,"context_line":"Listen {{ api_interface_address | put_address_in_context(\u0027url\u0027) }}:{{ nova_api_listen_port }}"},{"line_number":12,"context_line":"Listen {{ api_interface_address | put_address_in_context(\u0027url\u0027) }}:{{ nova_metadata_listen_port }}"}],"source_content_type":"text/x-jinja2","patch_set":1,"id":"1f493fa4_4e4e0d97","line":9,"updated":"2020-05-01 14:49:44.000000000","message":"As in others:\n\n{% if kolla_base_distro in [\u0027centos\u0027]  %}  \nLoadModule ssl_module /usr/lib64/httpd/modules/mod_ssl.so\n{% else %}\nLoadModule ssl_module /usr/lib/apache2/modules/mod_ssl.so\n{% endif %}\n\nOne of the other patches at some point fixed this for keystone, but seems it was not merged.","commit_id":"b4eb33bfcaf226cf3728672aa70228b1dccb3a99"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"752bfa2d7bed62258f9f494ab1a31cb15d6d8a79","unresolved":false,"context_lines":[{"line_number":22,"context_line":"        Require all granted"},{"line_number":23,"context_line":"    \u003c/FilesMatch\u003e"},{"line_number":24,"context_line":"\u003c/Directory\u003e"},{"line_number":25,"context_line":""},{"line_number":26,"context_line":"{% if nova_logging_debug | bool %}"},{"line_number":27,"context_line":"LogLevel info"},{"line_number":28,"context_line":"{% endif %}"}],"source_content_type":"text/x-jinja2","patch_set":1,"id":"1f493fa4_a2c24583","line":25,"updated":"2020-05-01 14:49:44.000000000","message":"We also added the following to many other WSGI configs:\n\nErrorLog \"{{ nova_log_dir }}/apache-error.log\"\n\u003cIfModule log_config_module\u003e\n    CustomLog \"{{ nova_log_dir }}/apache-access.log\" common\n\u003c/IfModule\u003e\n\nThis should also go in heat.","commit_id":"b4eb33bfcaf226cf3728672aa70228b1dccb3a99"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"752bfa2d7bed62258f9f494ab1a31cb15d6d8a79","unresolved":false,"context_lines":[{"line_number":33,"context_line":"    WSGIScriptAlias / {{ wsgi_directory }}/nova-api-wsgi"},{"line_number":34,"context_line":"    WSGIApplicationGroup %{GLOBAL}"},{"line_number":35,"context_line":"    WSGIPassAuthorization On"},{"line_number":36,"context_line":"{% if nova_enable_tls_backend | bool %}"},{"line_number":37,"context_line":"    SSLEngine on"},{"line_number":38,"context_line":"    SSLCertificateFile /etc/nova/certs/nova-cert.pem"},{"line_number":39,"context_line":"    SSLCertificateKeyFile /etc/nova/certs/nova-key.pem"},{"line_number":40,"context_line":"{% endif %}"},{"line_number":41,"context_line":"    \u003cIfVersion \u003e\u003d 2.4\u003e"},{"line_number":42,"context_line":"      ErrorLogFormat \"%{cu}t %M\""},{"line_number":43,"context_line":"    \u003c/IfVersion\u003e"}],"source_content_type":"text/x-jinja2","patch_set":1,"id":"1f493fa4_0249795e","line":40,"range":{"start_line":36,"start_character":0,"end_line":40,"end_character":11},"updated":"2020-05-01 14:49:44.000000000","message":"nit: normally at the end of virtualhost section (as it is for metadata)","commit_id":"b4eb33bfcaf226cf3728672aa70228b1dccb3a99"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"752bfa2d7bed62258f9f494ab1a31cb15d6d8a79","unresolved":false,"context_lines":[{"line_number":43,"context_line":"    \u003c/IfVersion\u003e"},{"line_number":44,"context_line":"    ErrorLog \"{{ log_dir }}/nova-api-error.log\""},{"line_number":45,"context_line":"    LogFormat \"%{X-Forwarded-For}i %l %u %t \\\"%r\\\" %\u003es %b %D \\\"%{Referer}i\\\" \\\"%{User-Agent}i\\\"\" logformat"},{"line_number":46,"context_line":"    CustomLog \"{{ log_dir }}/nova-api-error.log\" logformat"},{"line_number":47,"context_line":"\u003c/VirtualHost\u003e"},{"line_number":48,"context_line":""},{"line_number":49,"context_line":"\u003cVirtualHost *:{{ nova_metadata_listen_port }}\u003e"}],"source_content_type":"text/x-jinja2","patch_set":1,"id":"1f493fa4_4286e167","line":46,"range":{"start_line":46,"start_character":38,"end_line":46,"end_character":43},"updated":"2020-05-01 14:49:44.000000000","message":"access\n\nAlso needs fixing for heat.","commit_id":"b4eb33bfcaf226cf3728672aa70228b1dccb3a99"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"752bfa2d7bed62258f9f494ab1a31cb15d6d8a79","unresolved":false,"context_lines":[{"line_number":57,"context_line":"    \u003c/IfVersion\u003e"},{"line_number":58,"context_line":"    ErrorLog \"{{ log_dir }}/nova-metadata-error.log\""},{"line_number":59,"context_line":"    LogFormat \"%{X-Forwarded-For}i %l %u %t \\\"%r\\\" %\u003es %b %D \\\"%{Referer}i\\\" \\\"%{User-Agent}i\\\"\" logformat"},{"line_number":60,"context_line":"    CustomLog \"{{ log_dir }}/nova-metadata-error.log\" logformat"},{"line_number":61,"context_line":"{% if nova_enable_tls_backend | bool %}"},{"line_number":62,"context_line":"    SSLEngine on"},{"line_number":63,"context_line":"    SSLCertificateFile /etc/nova/certs/nova-cert.pem"}],"source_content_type":"text/x-jinja2","patch_set":1,"id":"1f493fa4_42eb8111","line":60,"range":{"start_line":60,"start_character":43,"end_line":60,"end_character":48},"updated":"2020-05-01 14:49:44.000000000","message":"access","commit_id":"b4eb33bfcaf226cf3728672aa70228b1dccb3a99"}],"ansible/roles/nova/templates/nova.conf.j2":[{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"752bfa2d7bed62258f9f494ab1a31cb15d6d8a79","unresolved":false,"context_lines":[{"line_number":147,"context_line":""},{"line_number":148,"context_line":"[guestfs]"},{"line_number":149,"context_line":"debug \u003d {{ nova_logging_debug }}"},{"line_number":150,"context_line":""},{"line_number":151,"context_line":"[wsgi]"},{"line_number":152,"context_line":"api_paste_config \u003d /etc/nova/api-paste.ini"},{"line_number":153,"context_line":"{% if kolla_enable_tls_external | bool or kolla_enable_tls_internal | bool %}"},{"line_number":154,"context_line":"secure_proxy_ssl_header \u003d HTTP_X_FORWARDED_PROTO"},{"line_number":155,"context_line":"{% endif %}"},{"line_number":156,"context_line":""},{"line_number":157,"context_line":"[scheduler]"},{"line_number":158,"context_line":"max_attempts \u003d 10"}],"source_content_type":"text/x-jinja2","patch_set":1,"id":"1f493fa4_02c85971","side":"PARENT","line":155,"range":{"start_line":150,"start_character":0,"end_line":155,"end_character":11},"updated":"2020-05-01 14:49:44.000000000","message":"Why is this removed?","commit_id":"91678f67af4109f969566549682a94c113696ac2"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"752bfa2d7bed62258f9f494ab1a31cb15d6d8a79","unresolved":false,"context_lines":[{"line_number":9,"context_line":""},{"line_number":10,"context_line":"state_path \u003d /var/lib/nova"},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"osapi_compute_listen \u003d {{ api_interface_address }}"},{"line_number":13,"context_line":"osapi_compute_listen_port \u003d {{ nova_api_listen_port }}"},{"line_number":14,"context_line":"osapi_compute_workers \u003d {{ openstack_service_workers }}"},{"line_number":15,"context_line":"metadata_workers \u003d {{ openstack_service_workers }}"},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"metadata_listen \u003d {{ api_interface_address }}"},{"line_number":18,"context_line":"metadata_listen_port \u003d {{ nova_metadata_listen_port }}"},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"allow_resize_to_same_host \u003d true"},{"line_number":21,"context_line":""}],"source_content_type":"text/x-jinja2","patch_set":1,"id":"1f493fa4_c2e831e3","line":18,"range":{"start_line":12,"start_character":0,"end_line":18,"end_character":54},"updated":"2020-05-01 14:49:44.000000000","message":"I think we can remove these.","commit_id":"b4eb33bfcaf226cf3728672aa70228b1dccb3a99"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"752bfa2d7bed62258f9f494ab1a31cb15d6d8a79","unresolved":false,"context_lines":[{"line_number":29,"context_line":""},{"line_number":30,"context_line":"transport_url \u003d {{ rpc_transport_url }}"},{"line_number":31,"context_line":""},{"line_number":32,"context_line":"{% if service_name \u003d\u003d \"nova-api\" and nova_enable_tls_backend | bool %}"},{"line_number":33,"context_line":"enabled_ssl_apis \u003d osapi_compute"},{"line_number":34,"context_line":"{% endif %}"},{"line_number":35,"context_line":""},{"line_number":36,"context_line":"[filter_scheduler]"},{"line_number":37,"context_line":"{% if enable_blazar | bool %}"}],"source_content_type":"text/x-jinja2","patch_set":1,"id":"1f493fa4_4230a19f","line":34,"range":{"start_line":32,"start_character":0,"end_line":34,"end_character":11},"updated":"2020-05-01 14:49:44.000000000","message":"I don\u0027t think it\u0027s required for a WSGI app.","commit_id":"b4eb33bfcaf226cf3728672aa70228b1dccb3a99"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"66183239d3bcfa2725b1776e670586fd52562dec","unresolved":false,"context_lines":[{"line_number":4,"context_line":""},{"line_number":5,"context_line":"log_dir \u003d /var/log/kolla/nova"},{"line_number":6,"context_line":"{% if service_name \u003d\u003d \"nova-super-conductor\" %}"},{"line_number":7,"context_line":"log_file \u003d /var/log/kolla/nova/nova-super-conductor.log"},{"line_number":8,"context_line":"{% endif %}"},{"line_number":9,"context_line":""},{"line_number":10,"context_line":"state_path \u003d /var/lib/nova"}],"source_content_type":"text/x-jinja2","patch_set":9,"id":"ff570b3c_b813355c","line":7,"updated":"2020-05-14 09:42:26.000000000","message":"We should use service_name here, since we now get logs in nova-api-wsgi.log rather than nova-api.log.\n https://storage.bhs.cloud.ovh.net/v1/AUTH_dcaab5e32b234d56b626f72581e3644c/zuul_opendev_logs_b9a/724794/9/check/kolla-ansible-ubuntu-binary/b9ada61/primary/logs/kolla/nova/nova-api-wsgi.txt.","commit_id":"e31089ec180341a86edd3518d609299740506ae0"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"31760125528d4ba0cf62a3794b88d45691bb0e58","unresolved":false,"context_lines":[{"line_number":4,"context_line":""},{"line_number":5,"context_line":"log_dir \u003d /var/log/kolla/nova"},{"line_number":6,"context_line":"{% if service_name \u003d\u003d \"nova-super-conductor\" %}"},{"line_number":7,"context_line":"log_file \u003d /var/log/kolla/nova/nova-super-conductor.log"},{"line_number":8,"context_line":"{% endif %}"},{"line_number":9,"context_line":""},{"line_number":10,"context_line":"state_path \u003d /var/lib/nova"}],"source_content_type":"text/x-jinja2","patch_set":9,"id":"ff570b3c_98d8f17f","line":7,"in_reply_to":"ff570b3c_b813355c","updated":"2020-05-14 09:44:03.000000000","message":"Seems like the same applies to heat.","commit_id":"e31089ec180341a86edd3518d609299740506ae0"}]}