)]}'
{"ansible/roles/barbican/templates/barbican-api.ini.j2":[{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"475d134b852fae9f7b54e6403418d6932711eb52","unresolved":false,"context_lines":[{"line_number":1,"context_line":"[uwsgi]"},{"line_number":2,"context_line":"master \u003d true"},{"line_number":3,"context_line":"{% if barbican_enable_tls_backend | bool %}"},{"line_number":4,"context_line":"https \u003d {{ api_interface_address | put_address_in_context(\u0027url\u0027) }}:{{ barbican_api_listen_port }},/etc/barbican/certs/barbican-cert.pem,/etc/barbican/certs/barbican-key.pem"}],"source_content_type":"text/x-jinja2","patch_set":2,"id":"ff570b3c_fc93335b","line":1,"updated":"2020-05-11 11:34:28.000000000","message":"Looks like most of the original defaults came from https://github.com/openstack/barbican/blob/master/etc/barbican/vassals/barbican-api.ini.\n\nI\u0027d suggest we restrict this to HTTPS, and propose other changes for separate bikeshedding.","commit_id":"3b327a3b7a7e43df8b6a6282d08d05be8f1f56ff"},{"author":{"_account_id":30810,"name":"James Kirsch","email":"generalfuzz@gmail.com","username":"generalfuzz"},"change_message_id":"550c2355e9cc7c05cc83df134d20a9cb05c622a6","unresolved":false,"context_lines":[{"line_number":1,"context_line":"[uwsgi]"},{"line_number":2,"context_line":"master \u003d true"},{"line_number":3,"context_line":"{% if barbican_enable_tls_backend | bool %}"},{"line_number":4,"context_line":"https \u003d {{ api_interface_address | put_address_in_context(\u0027url\u0027) }}:{{ barbican_api_listen_port }},/etc/barbican/certs/barbican-cert.pem,/etc/barbican/certs/barbican-key.pem"},{"line_number":5,"context_line":"{% else %}"}],"source_content_type":"text/x-jinja2","patch_set":2,"id":"1f493fa4_e304d4c8","line":2,"range":{"start_line":2,"start_character":0,"end_line":2,"end_character":13},"updated":"2020-05-08 20:36:01.000000000","message":"allows uwsgi to be more graceful in shutdown - https://serverfault.com/questions/674496/what-does-the-master-option-actually-do-in-uwsgi","commit_id":"3b327a3b7a7e43df8b6a6282d08d05be8f1f56ff"},{"author":{"_account_id":30810,"name":"James Kirsch","email":"generalfuzz@gmail.com","username":"generalfuzz"},"change_message_id":"550c2355e9cc7c05cc83df134d20a9cb05c622a6","unresolved":false,"context_lines":[{"line_number":6,"context_line":"http \u003d {{ api_interface_address | put_address_in_context(\u0027url\u0027) }}:{{ barbican_api_listen_port }}"},{"line_number":7,"context_line":"{% endif %}"},{"line_number":8,"context_line":"processes \u003d {{ openstack_service_workers }}"},{"line_number":9,"context_line":"enable-threads \u003d true"},{"line_number":10,"context_line":"vacuum \u003d true"},{"line_number":11,"context_line":"lazy \u003d true"},{"line_number":12,"context_line":"die-on-term \u003d true"}],"source_content_type":"text/x-jinja2","patch_set":2,"id":"ff570b3c_bd26eb15","line":9,"range":{"start_line":9,"start_character":0,"end_line":9,"end_character":6},"updated":"2020-05-08 20:36:01.000000000","message":"I figured we wanted multi threaded into API. Def not required","commit_id":"3b327a3b7a7e43df8b6a6282d08d05be8f1f56ff"},{"author":{"_account_id":30810,"name":"James Kirsch","email":"generalfuzz@gmail.com","username":"generalfuzz"},"change_message_id":"550c2355e9cc7c05cc83df134d20a9cb05c622a6","unresolved":false,"context_lines":[{"line_number":9,"context_line":"enable-threads \u003d true"},{"line_number":10,"context_line":"vacuum \u003d true"},{"line_number":11,"context_line":"lazy \u003d true"},{"line_number":12,"context_line":"die-on-term \u003d true"},{"line_number":13,"context_line":"no-default-app \u003d true"},{"line_number":14,"context_line":"memory-report \u003d true"},{"line_number":15,"context_line":"wsgi-file \u003d /var/lib/kolla/venv/bin/barbican-wsgi-api"}],"source_content_type":"text/x-jinja2","patch_set":2,"id":"ff570b3c_9d684722","line":12,"range":{"start_line":12,"start_character":0,"end_line":12,"end_character":18},"updated":"2020-05-08 20:36:01.000000000","message":"I can remove this - seemed to nicer to die when stopped.","commit_id":"3b327a3b7a7e43df8b6a6282d08d05be8f1f56ff"},{"author":{"_account_id":30810,"name":"James Kirsch","email":"generalfuzz@gmail.com","username":"generalfuzz"},"change_message_id":"550c2355e9cc7c05cc83df134d20a9cb05c622a6","unresolved":false,"context_lines":[{"line_number":12,"context_line":"die-on-term \u003d true"},{"line_number":13,"context_line":"no-default-app \u003d true"},{"line_number":14,"context_line":"memory-report \u003d true"},{"line_number":15,"context_line":"wsgi-file \u003d /var/lib/kolla/venv/bin/barbican-wsgi-api"},{"line_number":16,"context_line":"buffer-size \u003d 65535"},{"line_number":17,"context_line":"hook-master-start \u003d unix_signal:15 gracefully_kill_them_all"},{"line_number":18,"context_line":"worker-reload-mercy \u003d 90"}],"source_content_type":"text/x-jinja2","patch_set":2,"id":"ff570b3c_7d5bb386","line":15,"range":{"start_line":15,"start_character":0,"end_line":15,"end_character":53},"updated":"2020-05-08 20:36:01.000000000","message":"This is how uwsgi integrates with barbican. Not sure how it worked before this.","commit_id":"3b327a3b7a7e43df8b6a6282d08d05be8f1f56ff"},{"author":{"_account_id":30810,"name":"James Kirsch","email":"generalfuzz@gmail.com","username":"generalfuzz"},"change_message_id":"550c2355e9cc7c05cc83df134d20a9cb05c622a6","unresolved":false,"context_lines":[{"line_number":13,"context_line":"no-default-app \u003d true"},{"line_number":14,"context_line":"memory-report \u003d true"},{"line_number":15,"context_line":"wsgi-file \u003d /var/lib/kolla/venv/bin/barbican-wsgi-api"},{"line_number":16,"context_line":"buffer-size \u003d 65535"},{"line_number":17,"context_line":"hook-master-start \u003d unix_signal:15 gracefully_kill_them_all"},{"line_number":18,"context_line":"worker-reload-mercy \u003d 90"},{"line_number":19,"context_line":"paste \u003d config:/etc/barbican/barbican-api-paste.ini"}],"source_content_type":"text/x-jinja2","patch_set":2,"id":"ff570b3c_fd4ea3bf","line":16,"range":{"start_line":16,"start_character":0,"end_line":16,"end_character":19},"updated":"2020-05-08 20:36:01.000000000","message":"By default uWSGI allocates a very small buffer (4096 bytes) for the headers of each request. If you start receiving “invalid request block size” in your logs, it could mean you need a bigger buffer. Increase it (up to 65535) with the buffer-size option.\n\nI saw this once or twice in earlier uwsgi testing.","commit_id":"3b327a3b7a7e43df8b6a6282d08d05be8f1f56ff"},{"author":{"_account_id":30810,"name":"James Kirsch","email":"generalfuzz@gmail.com","username":"generalfuzz"},"change_message_id":"550c2355e9cc7c05cc83df134d20a9cb05c622a6","unresolved":false,"context_lines":[{"line_number":14,"context_line":"memory-report \u003d true"},{"line_number":15,"context_line":"wsgi-file \u003d /var/lib/kolla/venv/bin/barbican-wsgi-api"},{"line_number":16,"context_line":"buffer-size \u003d 65535"},{"line_number":17,"context_line":"hook-master-start \u003d unix_signal:15 gracefully_kill_them_all"},{"line_number":18,"context_line":"worker-reload-mercy \u003d 90"},{"line_number":19,"context_line":"paste \u003d config:/etc/barbican/barbican-api-paste.ini"}],"source_content_type":"text/x-jinja2","patch_set":2,"id":"ff570b3c_1dcb971e","line":17,"range":{"start_line":17,"start_character":0,"end_line":17,"end_character":59},"updated":"2020-05-08 20:36:01.000000000","message":"Nicely die when kill uwsgi","commit_id":"3b327a3b7a7e43df8b6a6282d08d05be8f1f56ff"},{"author":{"_account_id":30810,"name":"James Kirsch","email":"generalfuzz@gmail.com","username":"generalfuzz"},"change_message_id":"550c2355e9cc7c05cc83df134d20a9cb05c622a6","unresolved":false,"context_lines":[{"line_number":15,"context_line":"wsgi-file \u003d /var/lib/kolla/venv/bin/barbican-wsgi-api"},{"line_number":16,"context_line":"buffer-size \u003d 65535"},{"line_number":17,"context_line":"hook-master-start \u003d unix_signal:15 gracefully_kill_them_all"},{"line_number":18,"context_line":"worker-reload-mercy \u003d 90"},{"line_number":19,"context_line":"paste \u003d config:/etc/barbican/barbican-api-paste.ini"}],"source_content_type":"text/x-jinja2","patch_set":2,"id":"ff570b3c_9dd687c3","line":18,"range":{"start_line":18,"start_character":0,"end_line":18,"end_character":24},"updated":"2020-05-08 20:36:01.000000000","message":"Prob not necessary, but kind for restarting.","commit_id":"3b327a3b7a7e43df8b6a6282d08d05be8f1f56ff"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"8deccc44d6afc74f17d85f1fea3ad630613cbf4e","unresolved":false,"context_lines":[{"line_number":1,"context_line":"[uwsgi]"},{"line_number":2,"context_line":"wsgi-file \u003d /var/lib/kolla/venv/bin/barbican-wsgi-api"},{"line_number":3,"context_line":"{% if barbican_enable_tls_backend | bool %}"},{"line_number":4,"context_line":"https \u003d {{ api_interface_address | put_address_in_context(\u0027url\u0027) }}:{{ barbican_api_listen_port }},/etc/barbican/certs/barbican-cert.pem,/etc/barbican/certs/barbican-key.pem"},{"line_number":5,"context_line":"{% else %}"}],"source_content_type":"text/x-jinja2","patch_set":4,"id":"ff570b3c_b17a6b85","line":2,"updated":"2020-05-12 08:55:29.000000000","message":"This isn\u0027t going to work in binary images - the path is different. It seemed to work before, possibly via this:\n\nhttps://opendev.org/openstack/barbican/src/commit/1ad43597352b225b6f3a21ef6c4186330cadf660/setup.cfg#L53\n\nExample: https://7be45f872ef8ddac5c49-498f1015c47ee06cc2525a14ef8131d8.ssl.cf2.rackcdn.com/725032/7/check/kolla-ansible-centos8-source-scenario-nfv/fde7898/primary/logs/kolla/barbican/barbican-api.txt","commit_id":"4c1d898c4b449d0d94a7ae940c2133f57e7ca0a7"},{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"1bf2ae59864f95e44520d51a93fa3305f763ebbf","unresolved":false,"context_lines":[{"line_number":1,"context_line":"[uwsgi]"},{"line_number":2,"context_line":"wsgi-file \u003d /var/lib/kolla/venv/bin/barbican-wsgi-api"},{"line_number":3,"context_line":"{% if barbican_enable_tls_backend | bool %}"},{"line_number":4,"context_line":"https \u003d {{ api_interface_address | put_address_in_context(\u0027url\u0027) }}:{{ barbican_api_listen_port }},/etc/barbican/certs/barbican-cert.pem,/etc/barbican/certs/barbican-key.pem"},{"line_number":5,"context_line":"{% else %}"}],"source_content_type":"text/x-jinja2","patch_set":4,"id":"ff570b3c_b1a54bb8","line":2,"in_reply_to":"ff570b3c_b17a6b85","updated":"2020-05-12 09:01:47.000000000","message":"we should not need to set it, it worked before without setting this","commit_id":"4c1d898c4b449d0d94a7ae940c2133f57e7ca0a7"},{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"5de3f3915daabe634acd359c75e8c39810ff2678","unresolved":false,"context_lines":[{"line_number":9,"context_line":"vacuum \u003d true"},{"line_number":10,"context_line":"no-default-app \u003d true"},{"line_number":11,"context_line":"memory-report \u003d true"},{"line_number":12,"context_line":"plugins \u003d python3"},{"line_number":13,"context_line":"paste \u003d config:/etc/barbican/barbican-api-paste.ini"},{"line_number":14,"context_line":"add-header \u003d Connection: close"}],"source_content_type":"text/x-jinja2","patch_set":5,"id":"ff570b3c_719bb371","line":12,"updated":"2020-05-12 09:02:50.000000000","message":"yeah, this is a separate fix to barbican; it needs to adapt in the older branches based on distro\u0027s python; only needed for binary; triggers warnings for source","commit_id":"981e785f9cccdf0b45c417143e83ae63b4f72556"}]}
