)]}'
{"id":"openstack%2Fkolla-ansible~730388","triplet_id":"openstack%2Fkolla-ansible~master~I27f0835b904e05006ae401adf383090322e1b891","project":"openstack/kolla-ansible","branch":"master","topic":"bug/1880220","hashtags":[],"change_id":"I27f0835b904e05006ae401adf383090322e1b891","subject":"Improve error reporting in password utilities","status":"MERGED","created":"2020-05-22 18:21:08.000000000","updated":"2020-06-25 11:00:42.000000000","submitted":"2020-06-25 10:36:14.000000000","submitter":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"total_comment_count":4,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"730388-1593081374491-995c8465","meta_rev_id":"cf3dede967f4dc623137ef3b87eea1aac3d1d01b","_number":730388,"virtual_id_number":730388,"owner":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"all":[{"value":0,"_account_id":28048,"name":"Will Szumski","email":"will@stackhpc.com","username":"jovial"},{"value":0,"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},{"value":0,"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},{"tag":"autogenerated:zuul:gate","value":2,"date":"2020-06-25 10:36:14.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"recommended":{"_account_id":28048,"name":"Will Szumski","email":"will@stackhpc.com","username":"jovial"},"all":[{"value":1,"date":"2020-06-04 08:45:22.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":28048,"name":"Will Szumski","email":"will@stackhpc.com","username":"jovial"},{"value":2,"date":"2020-06-25 09:11:26.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},{"value":2,"date":"2020-05-23 09:29:19.000000000","_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","value":1,"default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"all":[{"value":0,"_account_id":28048,"name":"Will Szumski","email":"will@stackhpc.com","username":"jovial"},{"value":1,"date":"2020-06-25 09:11:26.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},{"value":0,"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true},"Backport-Candidate":{"all":[{"value":0,"_account_id":28048,"name":"Will Szumski","email":"will@stackhpc.com","username":"jovial"},{"value":0,"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},{"value":0,"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-1":"Do Not Backport"," 0":"Backport Review Needed","+1":"Should Backport"},"description":"","default_value":0,"optional":true},"Review-Priority":{"all":[{"value":0,"_account_id":28048,"name":"Will Szumski","email":"will@stackhpc.com","username":"jovial"},{"value":0,"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},{"value":0,"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-1":"Branch Freeze"," 0":"No Priority","+1":"Important Change","+2":"Gate Blocker Fix / Urgent Change"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},{"_account_id":28048,"name":"Will Szumski","email":"will@stackhpc.com","username":"jovial"},{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2020-05-23 09:29:19.000000000","updated_by":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"reviewer":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"state":"REVIEWER"},{"updated":"2020-06-04 08:45:22.000000000","updated_by":{"_account_id":28048,"name":"Will Szumski","email":"will@stackhpc.com","username":"jovial"},"reviewer":{"_account_id":28048,"name":"Will Szumski","email":"will@stackhpc.com","username":"jovial"},"state":"REVIEWER"},{"updated":"2020-06-25 09:11:26.000000000","updated_by":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"reviewer":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"state":"REVIEWER"},{"updated":"2020-06-25 10:36:14.000000000","updated_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"reviewer":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"state":"REVIEWER"}],"messages":[{"id":"b3b271a19b731cc539e51caadcd6ddf909b5cb7a","author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"date":"2020-05-22 18:21:08.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"6c6d8c21411d5afb4606d53cbc06ab1f927aded8","tag":"autogenerated:zuul:check-arm64","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2020-05-22 19:53:30.000000000","message":"Patch Set 1:\n\nBuild succeeded (ARM64 pipeline).\n\n- kolla-ansible-debian-source-aarch64 https://zuul.opendev.org/t/openstack/build/64042e67322846a3b5974f7dd75349aa : SUCCESS in 1h 27m 31s (non-voting)\n- kolla-ansible-debian-source-upgrade-aarch64 https://zuul.opendev.org/t/openstack/build/e2e57c3df3c84cd29187f5e0ba8edabb : FAILURE in 45m 36s (non-voting)","accounts_in_message":[],"_revision_number":1},{"id":"6f23a1f75b27bc98ca57f6ebeb6496cccc35d2d0","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2020-05-22 20:26:27.000000000","message":"Patch Set 1: Verified+1\n\nBuild succeeded (check pipeline).\n\n- openstack-tox-cover https://zuul.opendev.org/t/openstack/build/9e79188cf0124928be624666b2ab11c1 : SUCCESS in 4m 32s\n- openstack-tox-lower-constraints https://zuul.opendev.org/t/openstack/build/0160bdc8318948d3a4967ad4b0fe99f4 : SUCCESS in 4m 45s\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/04d3ebc5319d43df9d12e3af261d1af6 : SUCCESS in 6m 24s\n- openstack-tox-py36 https://zuul.opendev.org/t/openstack/build/5b089d05556d40339eb9bab17a02c2d7 : SUCCESS in 4m 46s\n- openstack-tox-py37 https://zuul.opendev.org/t/openstack/build/5302adbbc92b45df8f81a91891243ff0 : SUCCESS in 5m 13s\n- openstack-tox-py38 https://zuul.opendev.org/t/openstack/build/94ea7726f96344d6976576349ba745ba : SUCCESS in 5m 08s (non-voting)\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/e3c2289dd4804e25837929e646f190d6 : SUCCESS in 5m 57s\n- openstack-tox-linters https://zuul.opendev.org/t/openstack/build/e1458e12547240ffb6df084b44739a2a : SUCCESS in 10m 25s\n- build-openstack-releasenotes https://zuul.opendev.org/t/openstack/build/73a5e63794b9485c9a026d2cd0cbb5d9 : SUCCESS in 5m 54s\n- kolla-ansible-centos8-source https://zuul.opendev.org/t/openstack/build/c0f74160830948a296e718233c933eb1 : SUCCESS in 1h 05m 29s\n- kolla-ansible-debian-source https://zuul.opendev.org/t/openstack/build/6db2c536cc0c4a38bf7581f5bba3127e : SUCCESS in 49m 06s (non-voting)\n- kolla-ansible-ubuntu-source https://zuul.opendev.org/t/openstack/build/35c983ea1ef24e42a62de35501374138 : SUCCESS in 54m 31s\n- kolla-ansible-ubuntu-source-multinode-ipv6 https://zuul.opendev.org/t/openstack/build/b2f7df9a365f4448a1f59679a82852aa : SUCCESS in 1h 07m 08s (non-voting)\n- kolla-ansible-centos8-source-upgrade https://zuul.opendev.org/t/openstack/build/956674eb1d4e492683dbd2603fcf0c4c : SUCCESS in 1h 13m 32s\n- kolla-ansible-debian-source-upgrade https://zuul.opendev.org/t/openstack/build/810d96b7b2e34294b6a753d58525b07e : SUCCESS in 53m 11s (non-voting)\n- kolla-ansible-ubuntu-source-upgrade https://zuul.opendev.org/t/openstack/build/5c18a7d893124800b2671b9f29fe2533 : SUCCESS in 1h 05m 04s\n- kolla-ansible-centos8-binary https://zuul.opendev.org/t/openstack/build/aede17172e7c49218626ec3e041daef6 : SUCCESS in 1h 00m 22s (non-voting)\n- kolla-ansible-ubuntu-binary https://zuul.opendev.org/t/openstack/build/5d225d9064f84b6e84c23337b0b0f1fe : SUCCESS in 48m 42s (non-voting)\n- kolla-ansible-centos8-source-cells https://zuul.opendev.org/t/openstack/build/3ff1aa5ad7914b67b8d16e37fb25f142 : SUCCESS in 1h 43m 13s (non-voting)\n- kolla-ansible-centos8-source-ceph-ansible https://zuul.opendev.org/t/openstack/build/80be71786d614382b344c4616ee42569 : SUCCESS in 1h 55m 12s (non-voting)\n- kolla-ansible-ubuntu-source-ceph-ansible https://zuul.opendev.org/t/openstack/build/4dd7ded2652f42df99949ed23840aa8b : SUCCESS in 1h 35m 22s (non-voting)\n- kolla-ansible-centos8-source-upgrade-ceph-ansible https://zuul.opendev.org/t/openstack/build/508e9cdfabb2483aaf6ea239200fe459 : SUCCESS in 2h 02m 17s (non-voting)\n- kolla-ansible-ubuntu-source-upgrade-ceph-ansible https://zuul.opendev.org/t/openstack/build/458fa649d95a4981b983073a44741011 : SUCCESS in 1h 52m 48s (non-voting)","accounts_in_message":[],"_revision_number":1},{"id":"5c24b8e6cdda866dfc4b58afe526df702840c0e8","author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"date":"2020-05-23 09:29:19.000000000","message":"Patch Set 1: Code-Review+2\n\n(4 comments)","accounts_in_message":[],"_revision_number":1},{"id":"9fff1e8b0f77cd35302193a1246be3ba07cab025","author":{"_account_id":28048,"name":"Will Szumski","email":"will@stackhpc.com","username":"jovial"},"date":"2020-06-04 08:45:22.000000000","message":"Patch Set 1: Code-Review+1","accounts_in_message":[],"_revision_number":1},{"id":"f83f3996190973adb8a348633b3179412806f4b3","author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"date":"2020-06-25 09:11:26.000000000","message":"Patch Set 1: Code-Review+2 Workflow+1","accounts_in_message":[],"_revision_number":1},{"id":"b250b2d9a394153c287b81c05eb3c4bc4328180d","tag":"autogenerated:zuul:gate","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2020-06-25 09:11:39.000000000","message":"Patch Set 1: -Verified\n\nStarting gate jobs.","accounts_in_message":[],"_revision_number":1},{"id":"c38d7f0d1a86368825caee38784657bb8e09de4e","tag":"autogenerated:zuul:gate","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2020-06-25 10:36:14.000000000","message":"Patch Set 1: Verified+2\n\nBuild succeeded (gate pipeline).\n\n- openstack-tox-lower-constraints https://zuul.opendev.org/t/openstack/build/17735bf500594876a01531ca5761b28c : SUCCESS in 5m 37s\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/8ec48b8b4ee944c28562b1adaf158b7f : SUCCESS in 4m 38s\n- openstack-tox-py36 https://zuul.opendev.org/t/openstack/build/c4145d49165e4b859d7e9c5ecf119b13 : SUCCESS in 5m 30s\n- openstack-tox-py38 https://zuul.opendev.org/t/openstack/build/d4e8a10ca4c0471eb60e3debf2c6fc9f : SUCCESS in 8m 03s\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/8e424561d0494a4bb911018b93e71b06 : SUCCESS in 10m 08s\n- openstack-tox-linters https://zuul.opendev.org/t/openstack/build/b93e5317febe4cbfa51bae3fadf4286e : SUCCESS in 13m 06s\n- build-openstack-releasenotes https://zuul.opendev.org/t/openstack/build/2d84b38bfe5747dfa536ab632818543a : SUCCESS in 5m 08s\n- kolla-ansible-centos8-source https://zuul.opendev.org/t/openstack/build/d80d3339ed7e4d51aa2fdd7913b1efd7 : SUCCESS in 1h 04m 40s\n- kolla-ansible-centos8-source-upgrade https://zuul.opendev.org/t/openstack/build/2213d6c513af4aedab40b04c99339aae : SUCCESS in 1h 09m 13s\n- kolla-ansible-ubuntu-source https://zuul.opendev.org/t/openstack/build/679ff0c75cd5462690cce98a952e0281 : SUCCESS in 52m 55s\n- kolla-ansible-ubuntu-source-upgrade https://zuul.opendev.org/t/openstack/build/adca240462fc47aab9e922a62426dbfd : SUCCESS in 1h 04m 06s","accounts_in_message":[],"_revision_number":1},{"id":"96ecf958aa7547a012fcc0a64b8a7dda2072ead8","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2020-06-25 10:36:14.000000000","message":"Change has been successfully merged by Zuul","accounts_in_message":[],"_revision_number":1},{"id":"306a3e404657513e541ea6958aa663482a2d10a0","tag":"autogenerated:zuul:promote","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2020-06-25 10:41:21.000000000","message":"Patch Set 1:\n\nBuild succeeded (promote pipeline).\n\n- promote-openstack-tox-docs https://zuul.opendev.org/t/openstack/build/f50924669eae494b8175b9664ffe8516 : SUCCESS in 2m 04s\n- promote-openstack-releasenotes https://zuul.opendev.org/t/openstack/build/1e2b36e2e7f74b75b09091306d93f98f : SUCCESS in 1m 44s","accounts_in_message":[],"_revision_number":1},{"id":"c351d87877686af6f74bfe50e46dc9ed3e788747","author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"date":"2020-06-25 11:00:42.000000000","message":"Patch Set 1: Cherry Picked\n\nThis patchset was cherry picked to branch stable/ussuri as commit 94c7e5a963d7427d1f941f384961c356efa8a271","accounts_in_message":[],"_revision_number":1}],"current_revision_number":1,"current_revision":"620b808cf366596d7cdd521cd5b44a973d5cdeab","revisions":{"620b808cf366596d7cdd521cd5b44a973d5cdeab":{"kind":"REWORK","_number":1,"created":"2020-05-22 18:21:08.000000000","uploader":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"ref":"refs/changes/88/730388/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/kolla-ansible","ref":"refs/changes/88/730388/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/kolla-ansible refs/changes/88/730388/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/kolla-ansible refs/changes/88/730388/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/kolla-ansible refs/changes/88/730388/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/kolla-ansible refs/changes/88/730388/1"}}},"commit":{"parents":[{"commit":"8659acb238d7ee3fede8b70baa79c55919e322bc","subject":"Merge \"Add First login steps back into Kibana doc\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/kolla-ansible/commit/8659acb238d7ee3fede8b70baa79c55919e322bc"}]}],"author":{"name":"Mark Goddard","email":"mark@stackhpc.com","date":"2020-05-22 18:16:02.000000000","tz":60},"committer":{"name":"Mark Goddard","email":"mark@stackhpc.com","date":"2020-05-22 18:20:47.000000000","tz":60},"subject":"Improve error reporting in password utilities","message":"Improve error reporting in password utilities\n\nThe kolla-genpwd and kolla-mergepwd commands can be used to manipulate\nthe kolla passwords.yml file. The format is a YAML encoded dict of\npassword variable names to their values. If the format is not a dict,\nthe error messages are unhelpful.  In particular, this can happen if the\nfile is encrypted e.g. via Ansible Vault.\n\nFor kolla-genpwd:\n\n    AttributeError: \u0027NoneType\u0027 object has no attribute \u0027items\u0027\n\nFor kolla-mergepwd:\n\n    AttributeError: \u0027NoneType\u0027 object has no attribute \u0027update\u0027\n\nThis change adds a more friendly message.\n\nChange-Id: I27f0835b904e05006ae401adf383090322e1b891\nCloses-Bug: #1880220\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/kolla-ansible/commit/620b808cf366596d7cdd521cd5b44a973d5cdeab"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/kolla-ansible/commit/620b808cf366596d7cdd521cd5b44a973d5cdeab"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}