)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"94f3fcba22a61cdf9bc4d80ee4fab2800b772605","unresolved":false,"context_lines":[{"line_number":14,"context_line":""},{"line_number":15,"context_line":"This patch is fixing this by setting mode to 0644."},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"Change-Id: Icf3bbae38b9f5630b69d5c8cf6a8bee11786a836"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"ff570b3c_494a6d5b","line":17,"updated":"2020-06-08 10:10:53.000000000","message":"Could you raise a bug, link here and add a release note?","commit_id":"595360d96b6fac915202f3d7c4a70b29ae009ac4"},{"author":{"_account_id":27339,"name":"Michal Arbet","email":"michal.arbet@ultimum.io","username":"michalarbet"},"change_message_id":"e95679765a4a09790817cfc4bf5d6bcef8ac153e","unresolved":false,"context_lines":[{"line_number":14,"context_line":""},{"line_number":15,"context_line":"This patch is fixing this by setting mode to 0644."},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"Change-Id: Icf3bbae38b9f5630b69d5c8cf6a8bee11786a836"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"ff570b3c_896ac5ea","line":17,"in_reply_to":"ff570b3c_494a6d5b","updated":"2020-06-09 09:10:55.000000000","message":"Yes, sure.","commit_id":"595360d96b6fac915202f3d7c4a70b29ae009ac4"}],"ansible/roles/baremetal/tasks/post-install.yml":[{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"f306884d952a86fe76a8e6248ae2b4ba5ed584f3","unresolved":false,"context_lines":[{"line_number":146,"context_line":"    - ansible_distribution \u003d\u003d \"Ubuntu\""},{"line_number":147,"context_line":"    - apparmor_libvirtd_profile.stat.exists"},{"line_number":148,"context_line":""},{"line_number":149,"context_line":"- name: Get stat of chronyd apparmor profile"},{"line_number":150,"context_line":"  stat:"},{"line_number":151,"context_line":"    path: /etc/apparmor.d/usr.sbin.chronyd"},{"line_number":152,"context_line":"  register: apparmor_chronyd_profile"}],"source_content_type":"text/x-yaml","patch_set":7,"id":"ff570b3c_b88c0780","line":149,"updated":"2020-06-10 10:35:37.000000000","message":"I guess we don\u0027t want to touch this now","commit_id":"c09a040f2a8a6abadd4a90f3edba2b4bf03881ca"},{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"e896ef176d6711624189934346075759dec58c9c","unresolved":false,"context_lines":[{"line_number":146,"context_line":"    - ansible_distribution \u003d\u003d \"Ubuntu\""},{"line_number":147,"context_line":"    - apparmor_libvirtd_profile.stat.exists"},{"line_number":148,"context_line":""},{"line_number":149,"context_line":"- name: Get stat of chronyd apparmor profile"},{"line_number":150,"context_line":"  stat:"},{"line_number":151,"context_line":"    path: /etc/apparmor.d/usr.sbin.chronyd"},{"line_number":152,"context_line":"  register: apparmor_chronyd_profile"}],"source_content_type":"text/x-yaml","patch_set":7,"id":"ff570b3c_4eb07ede","line":149,"in_reply_to":"ff570b3c_38ed978b","updated":"2020-06-10 14:49:40.000000000","message":"OK, makes sense to me.","commit_id":"c09a040f2a8a6abadd4a90f3edba2b4bf03881ca"},{"author":{"_account_id":27339,"name":"Michal Arbet","email":"michal.arbet@ultimum.io","username":"michalarbet"},"change_message_id":"ee56d3cdb5cb3c5c9e84103e27af150bacaf978e","unresolved":false,"context_lines":[{"line_number":146,"context_line":"    - ansible_distribution \u003d\u003d \"Ubuntu\""},{"line_number":147,"context_line":"    - apparmor_libvirtd_profile.stat.exists"},{"line_number":148,"context_line":""},{"line_number":149,"context_line":"- name: Get stat of chronyd apparmor profile"},{"line_number":150,"context_line":"  stat:"},{"line_number":151,"context_line":"    path: /etc/apparmor.d/usr.sbin.chronyd"},{"line_number":152,"context_line":"  register: apparmor_chronyd_profile"}],"source_content_type":"text/x-yaml","patch_set":7,"id":"ff570b3c_38ed978b","line":149,"in_reply_to":"ff570b3c_b88c0780","updated":"2020-06-10 11:20:06.000000000","message":"If idea of this review is correct and kolla-ansible will remove chrony dist packages from system when enable_chrony is True, this has to be removed also, because unfortunatelly package is not removing apparmor profile, so even if package is removed, apparmor profile still working and chrony container not working.","commit_id":"c09a040f2a8a6abadd4a90f3edba2b4bf03881ca"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"5eefeea998d87f74cad429acdb48893721896e10","unresolved":false,"context_lines":[{"line_number":151,"context_line":"    path: /etc/apparmor.d/usr.sbin.chronyd"},{"line_number":152,"context_line":"  register: apparmor_chronyd_profile"},{"line_number":153,"context_line":"  when:"},{"line_number":154,"context_line":"    - ansible_distribution \u003d\u003d \"Ubuntu\""},{"line_number":155,"context_line":"    - enable_chrony | bool"},{"line_number":156,"context_line":""},{"line_number":157,"context_line":"- name: Remove apparmor profile for chrony"}],"source_content_type":"text/x-yaml","patch_set":8,"id":"bf51134e_58199286","line":154,"range":{"start_line":154,"start_character":31,"end_line":154,"end_character":37},"updated":"2020-06-15 10:35:17.000000000","message":"What about Debian?","commit_id":"68d897c9425f681527a657ef9710ebe2ae0309e8"},{"author":{"_account_id":27339,"name":"Michal Arbet","email":"michal.arbet@ultimum.io","username":"michalarbet"},"change_message_id":"59dc4743a6341d94ec49bc8f4f553ec569716408","unresolved":false,"context_lines":[{"line_number":151,"context_line":"    path: /etc/apparmor.d/usr.sbin.chronyd"},{"line_number":152,"context_line":"  register: apparmor_chronyd_profile"},{"line_number":153,"context_line":"  when:"},{"line_number":154,"context_line":"    - ansible_distribution \u003d\u003d \"Ubuntu\""},{"line_number":155,"context_line":"    - enable_chrony | bool"},{"line_number":156,"context_line":""},{"line_number":157,"context_line":"- name: Remove apparmor profile for chrony"}],"source_content_type":"text/x-yaml","patch_set":8,"id":"bf51134e_f349a732","line":154,"range":{"start_line":154,"start_character":31,"end_line":154,"end_character":37},"in_reply_to":"bf51134e_58199286","updated":"2020-06-15 11:00:58.000000000","message":"Done","commit_id":"68d897c9425f681527a657ef9710ebe2ae0309e8"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"5eefeea998d87f74cad429acdb48893721896e10","unresolved":false,"context_lines":[{"line_number":158,"context_line":"  command: apparmor_parser -R /etc/apparmor.d/usr.sbin.chronyd"},{"line_number":159,"context_line":"  become: True"},{"line_number":160,"context_line":"  when:"},{"line_number":161,"context_line":"    - ansible_distribution \u003d\u003d \"Ubuntu\""},{"line_number":162,"context_line":"    - enable_chrony | bool"},{"line_number":163,"context_line":"    - apparmor_chronyd_profile.stat.exists"},{"line_number":164,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":8,"id":"bf51134e_381e5e70","line":161,"updated":"2020-06-15 10:35:17.000000000","message":"Debian?","commit_id":"68d897c9425f681527a657ef9710ebe2ae0309e8"},{"author":{"_account_id":27339,"name":"Michal Arbet","email":"michal.arbet@ultimum.io","username":"michalarbet"},"change_message_id":"59dc4743a6341d94ec49bc8f4f553ec569716408","unresolved":false,"context_lines":[{"line_number":158,"context_line":"  command: apparmor_parser -R /etc/apparmor.d/usr.sbin.chronyd"},{"line_number":159,"context_line":"  become: True"},{"line_number":160,"context_line":"  when:"},{"line_number":161,"context_line":"    - ansible_distribution \u003d\u003d \"Ubuntu\""},{"line_number":162,"context_line":"    - enable_chrony | bool"},{"line_number":163,"context_line":"    - apparmor_chronyd_profile.stat.exists"},{"line_number":164,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":8,"id":"bf51134e_d3462322","line":161,"in_reply_to":"bf51134e_381e5e70","updated":"2020-06-15 11:00:58.000000000","message":"Done","commit_id":"68d897c9425f681527a657ef9710ebe2ae0309e8"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"6dee8fdb4106748b0a1bfc9503c7ba07f9c3e70e","unresolved":false,"context_lines":[{"line_number":151,"context_line":"    path: /etc/apparmor.d/usr.sbin.chronyd"},{"line_number":152,"context_line":"  register: apparmor_chronyd_profile"},{"line_number":153,"context_line":"  when:"},{"line_number":154,"context_line":"    - ansible_distribution \u003d\u003d \"Ubuntu\" or ansible_distribution \u003d\u003d \"Debian\""},{"line_number":155,"context_line":"    - enable_chrony | bool"},{"line_number":156,"context_line":""},{"line_number":157,"context_line":"- name: Remove apparmor profile for chrony"}],"source_content_type":"text/x-yaml","patch_set":10,"id":"bf51134e_530973db","line":154,"range":{"start_line":154,"start_character":6,"end_line":154,"end_character":74},"updated":"2020-06-15 11:04:09.000000000","message":"ansible_os_family \u003d\u003d \"Debian\"","commit_id":"c07b836e773549be2235eaee5b3629a6743e6625"},{"author":{"_account_id":27339,"name":"Michal Arbet","email":"michal.arbet@ultimum.io","username":"michalarbet"},"change_message_id":"188b0c5c6c0111127e2ad4a5cd8e35ecaa30309a","unresolved":false,"context_lines":[{"line_number":151,"context_line":"    path: /etc/apparmor.d/usr.sbin.chronyd"},{"line_number":152,"context_line":"  register: apparmor_chronyd_profile"},{"line_number":153,"context_line":"  when:"},{"line_number":154,"context_line":"    - ansible_distribution \u003d\u003d \"Ubuntu\" or ansible_distribution \u003d\u003d \"Debian\""},{"line_number":155,"context_line":"    - enable_chrony | bool"},{"line_number":156,"context_line":""},{"line_number":157,"context_line":"- name: Remove apparmor profile for chrony"}],"source_content_type":"text/x-yaml","patch_set":10,"id":"bf51134e_533213a9","line":154,"range":{"start_line":154,"start_character":6,"end_line":154,"end_character":74},"in_reply_to":"bf51134e_530973db","updated":"2020-06-15 11:07:09.000000000","message":"Done","commit_id":"c07b836e773549be2235eaee5b3629a6743e6625"}],"ansible/roles/chrony/templates/chrony.json.j2":[{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"94f3fcba22a61cdf9bc4d80ee4fab2800b772605","unresolved":false,"context_lines":[{"line_number":4,"context_line":"        {"},{"line_number":5,"context_line":"            \"source\": \"{{ container_config_directory }}/chrony.conf\","},{"line_number":6,"context_line":"            \"dest\": \"/etc/chrony/chrony.conf\","},{"line_number":7,"context_line":"            \"owner\": \"chrony\","},{"line_number":8,"context_line":"            \"perm\": \"0644\""},{"line_number":9,"context_line":"        }"},{"line_number":10,"context_line":"    ],"}],"source_content_type":"text/x-jinja2","patch_set":1,"id":"ff570b3c_093355f8","line":7,"range":{"start_line":7,"start_character":22,"end_line":7,"end_character":28},"updated":"2020-06-08 10:10:53.000000000","message":"This suggests that chrony is not running as the chrony user. I assume this is on Debian?","commit_id":"595360d96b6fac915202f3d7c4a70b29ae009ac4"}],"releasenotes/notes/bug-1882513-chrony-permission-denied-917b3bffc5cdb38d.yaml":[{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"e896ef176d6711624189934346075759dec58c9c","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"fixes:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Removing chrony package from docker host if containerized chrony"},{"line_number":5,"context_line":"    is enabled."},{"line_number":6,"context_line":"    `LP#1882513 \u003chttps://bugs.launchpad.net/kolla-ansible/+bug/1882513\u003e`__"}],"source_content_type":"text/x-yaml","patch_set":7,"id":"ff570b3c_8ec9f65b","line":4,"range":{"start_line":4,"start_character":20,"end_line":4,"end_character":27},"updated":"2020-06-10 14:49:40.000000000","message":"package and AppArmor profile","commit_id":"c09a040f2a8a6abadd4a90f3edba2b4bf03881ca"},{"author":{"_account_id":27339,"name":"Michal Arbet","email":"michal.arbet@ultimum.io","username":"michalarbet"},"change_message_id":"45159db50323ec5d7bf05cf204c33f915d0b8daa","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"fixes:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Removing chrony package from docker host if containerized chrony"},{"line_number":5,"context_line":"    is enabled."},{"line_number":6,"context_line":"    `LP#1882513 \u003chttps://bugs.launchpad.net/kolla-ansible/+bug/1882513\u003e`__"}],"source_content_type":"text/x-yaml","patch_set":7,"id":"ff570b3c_226b8b1f","line":4,"range":{"start_line":4,"start_character":20,"end_line":4,"end_character":27},"in_reply_to":"ff570b3c_8ec9f65b","updated":"2020-06-11 12:01:47.000000000","message":"Done","commit_id":"c09a040f2a8a6abadd4a90f3edba2b4bf03881ca"}]}
